drm/i915: double unlock in intel_setup_overlay()

2011-06-23 Thread Dan Carpenter
Smatch complains about the recent locking changes in intel_setup_overlay() that it unlocks twice on an error path. I was also curious if we shouldn't call i915_gem_object_unpin() on that error path. I don't know the drm code well enough to know about unpinning so I'm sending this bug report inste

drm/i915: double unlock in intel_setup_overlay()

2011-06-23 Thread Chris Wilson
On Thu, 23 Jun 2011 21:06:16 +0300, Dan Carpenter wrote: > Smatch complains about the recent locking changes in > intel_setup_overlay() that it unlocks twice on an error path. I was > also curious if we shouldn't call i915_gem_object_unpin() on that > error path. I don't know the drm code well e

Re: drm/i915: double unlock in intel_setup_overlay()

2011-06-23 Thread Chris Wilson
On Thu, 23 Jun 2011 21:06:16 +0300, Dan Carpenter wrote: > Smatch complains about the recent locking changes in > intel_setup_overlay() that it unlocks twice on an error path. I was > also curious if we shouldn't call i915_gem_object_unpin() on that > error path. I don't know the drm code well e

drm/i915: double unlock in intel_setup_overlay()

2011-06-23 Thread Dan Carpenter
Smatch complains about the recent locking changes in intel_setup_overlay() that it unlocks twice on an error path. I was also curious if we shouldn't call i915_gem_object_unpin() on that error path. I don't know the drm code well enough to know about unpinning so I'm sending this bug report inste