Re: [PATCH 00/14] amdgpu: remove load and unload callbacks

2020-02-05 Thread Christian König
Am 05.02.20 um 04:48 schrieb Alex Deucher: These are deprecated and the drm will soon start warning when drivers still use them. It was a long and twisty road, but seems to work. Acked-by: Christian König for the whole series. Alex Deucher (14): drm/amdgpu: rename amdgpu_debugfs_preempt

Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h

2020-02-05 Thread Andy Shevchenko
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote: > On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote: > > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote: > > > Replace with appropriate types.h. > > > > Thanks for your patch! > > > > I have only one very sho

Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler

2020-02-05 Thread Alyssa Rosenzweig
Patch 2 is `Reviewed-by: Alyssa Rosenzweig ` On Tue, Feb 04, 2020 at 03:35:04PM +0100, Boris Brezillon wrote: > ->job_run() can return an ERR_PTR() if somethings fails. Let's > propagate the error returned by panfrost_fence_create() instead of > returning NULL. > > Signed-off-by: Boris Brezillon

[v5] arm64: dts: sc7180: add display dt nodes

2020-02-05 Thread Harigovindan P
Add display, DSI hardware DT nodes for sc7180. Co-developed-by: Kalyan Thota Signed-off-by: Kalyan Thota Signed-off-by: Harigovindan P --- Changes in v1: - Added display DT nodes for sc7180 Changes in v2: - Renamed node names - Corrected code alignments - Remove

[PATCH v6] drm/dp_mst: Fix W=1 warnings

2020-02-05 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard Reviewed-by: Lyude Paul --- version 6: - change drm_dp_check_mstb_guid() prototype to be able to return an error - add c

Re: [Freedreno] [v1] dt-bindings: msm:disp: update dsi and dpu bindings

2020-02-05 Thread Jeffrey Hugo
On Tue, Feb 4, 2020 at 7:15 AM Harigovindan P wrote: > > Updating bindings of dsi and dpu by adding and removing certain > properties. > > Signed-off-by: Harigovindan P > --- > > Changes in v1: > - Adding "ahb" clock as a required property. > - Adding "bus", "rot", "lut" as option

[PATCH v1] drm: shmobile: Platform data shan't include kernel.h

2020-02-05 Thread Andy Shevchenko
Replace with appropriate types.h. Signed-off-by: Andy Shevchenko --- include/linux/platform_data/shmob_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..08605fdb2226 100

Re: [v4] arm64: dts: sc7180: add display dt nodes

2020-02-05 Thread harigovi
On 2020-02-01 01:02, Doug Anderson wrote: Hi, On Tue, Jan 28, 2020 at 5:25 AM Harigovindan P wrote: Add display, DSI hardware DT nodes for sc7180. Signed-off-by: Harigovindan P --- Changes in v1: -Added display DT nodes for sc7180 Changes in v2: -Renamed node names

[v1] dt-bindings: msm:disp: update dsi and dpu bindings

2020-02-05 Thread Harigovindan P
Updating bindings of dsi and dpu by adding and removing certain properties. Signed-off-by: Harigovindan P --- Changes in v1: - Adding "ahb" clock as a required property. - Adding "bus", "rot", "lut" as optional properties for sc7180 device. - Removing properties from dsi

Re: [PATCH 00/14] amdgpu: remove load and unload callbacks

2020-02-05 Thread Thomas Zimmermann
Hi Alex Am 05.02.20 um 04:48 schrieb Alex Deucher: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. > > Alex Deucher (14): > drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup > drm/amdgpu/ttm: move deb

[PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Tomeu Vizoso
If the exception type isn't one of the normal faults, don't try to map and instead go straight to a terminal fault. Otherwise, we can get flooded by kernel warnings and further faults. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 +++-- 1 file changed, 3 insertion

[PATCH] drm/virtio: ratelimit error logging

2020-02-05 Thread Gerd Hoffmann
Avoid flooding the log in case we screw up badly. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_vq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index 5914e79d3429..83f22933

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-05 Thread Kieran Bingham
Hi Andy, On 05/02/2020 09:32, Andy Shevchenko wrote: > This file doesn't need everything provided by . > All it needs are some types, which are provided by . > > Note, already includes , but > not relying on implicit includes is indeed a good thing. This explains things a bit better :-) I'm su

[PATCH 0/4] drm/virtio: rework backing storage handling

2020-02-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Gerd Hoffmann (4): drm/virtio: simplify virtio_gpu_alloc_cmd drm/virtio: resource teardown tweaks drm/virtio: move mapping teardown to virtio_gpu_cleanup_object() drm/virtio: move virtio_gpu_mem_entry initialization to new function drivers/gpu/drm/virtio/vir

[PATCH 3/4] drm/virtio: move mapping teardown to virtio_gpu_cleanup_object()

2020-02-05 Thread Gerd Hoffmann
Stop sending DETACH_BACKING commands, that will happening anyway when releasing resources via UNREF. Handle guest-side cleanup in virtio_gpu_cleanup_object(), called when the host finished processing the UNREF command. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h|

[PATCH 2/4] drm/virtio: resource teardown tweaks

2020-02-05 Thread Gerd Hoffmann
Add new virtio_gpu_cleanup_object() helper function for object cleanup. Wire up callback function for resource unref, do cleanup from callback when we know the host stopped using the resource. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h| 3 ++- drivers/gpu/drm/virt

[PATCH 4/4] drm/virtio: move virtio_gpu_mem_entry initialization to new function

2020-02-05 Thread Gerd Hoffmann
Introduce new virtio_gpu_object_shmem_init() helper function which will create the virtio_gpu_mem_entry array, containing the backing storage information for the host. For the most path this just moves code from virtio_gpu_object_attach(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio

[PATCH 1/4] drm/virtio: simplify virtio_gpu_alloc_cmd

2020-02-05 Thread Gerd Hoffmann
Just call virtio_gpu_alloc_cmd_resp with some fixed args instead of duplicating most of the function body. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_vq.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/virtio/vi

[PATCH v3 9/9] drm/vmwgfx: Hook up the helpers to align buffer objects

2020-02-05 Thread VMware
From: Thomas Hellstrom Start using the helpers that align buffer object user-space addresses and buffer object vram addresses to huge page boundaries. This is to improve the chances of allowing huge page-table entries. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kiri

[PATCH v3 3/9] mm: Split huge pages on write-notify or COW

2020-02-05 Thread VMware
From: Thomas Hellstrom We currently only do COW and write-notify on the PTE level, so if the huge_fault() handler returns VM_FAULT_FALLBACK on wp faults, split the huge pages and page-table entries. Also do this for huge PUDs if there is no huge_fault() handler and the vma is not anonymous, simil

[PATCH v3 0/9] Huge page-table entries for TTM

2020-02-05 Thread VMware
In order to reduce TLB misses and CPU usage this patchset enables huge- and giant page-table entries for TTM and TTM-enabled graphics drivers. Patch 1 and 2 introduce a vma_is_special_huge() function to make the mm code take the same path as DAX when splitting huge- and giant page table entries, (

[PATCH v3 2/9] mm: Introduce vma_is_special_huge

2020-02-05 Thread VMware
From: Thomas Hellstrom For VM_PFNMAP and VM_MIXEDMAP vmas that want to support transhuge pages and -page table entries, introduce vma_is_special_huge() that takes the same codepaths as vma_is_dax(). The use of "special" follows the definition in memory.c, vm_normal_page(): "Special" mappings do

[PATCH v3 7/9] drm: Add a drm_get_unmapped_area() helper

2020-02-05 Thread VMware
From: Thomas Hellstrom Unaligned virtual addresses makes it unlikely that huge page-table entries can be used. So align virtual buffer object address huge page boundaries to the underlying physical address huge page boundaries taking buffer object sizes into account to determine when it might be

[PATCH v3 1/9] fs: Constify vma argument to vma_is_dax

2020-02-05 Thread VMware
From: Thomas Hellstrom The vma argument is only dereferenced for reading. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christian König" Cc: Dan Williams Signed-off-by: Thomas Hellstrom Reviewed-by:

[PATCH v3 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-02-05 Thread VMware
From: Thomas Hellstrom Support huge (PMD-size and PUD-size) page-table entries by providing a huge_fault() callback. We still support private mappings and write-notify by splitting the huge page-table entries on write-access. Note that for huge page-faults to occur, either the kernel needs to be

[PATCH v3 4/9] mm: Add vmf_insert_pfn_xxx_prot() for huge page-table entries

2020-02-05 Thread VMware
From: Thomas Hellstrom For graphics drivers needing to modify the page-protection, add huge page-table entries counterparts to vmf_insert_pfn_prot(). Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christ

[PATCH v3 8/9] drm/vmwgfx: Introduce a huge page aligning TTM range manager

2020-02-05 Thread VMware
From: Thomas Hellstrom Using huge page-table entries requires that the physical address of the start of a buffer object is huge page size aligned. Make a special version of the TTM range manager that accomplishes this, but falls back to a smaller page size alignment (PUD->PMD, PMD->NORMAL) to avo

[PATCH v3 6/9] drm/vmwgfx: Support huge page faults

2020-02-05 Thread VMware
From: Thomas Hellstrom With vmwgfx dirty-tracking we need a specialized huge_fault callback. Implement and hook it up. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christian König" Cc: Dan Williams S

Re: [PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Robin Murphy
On 05/02/2020 10:07 am, Tomeu Vizoso wrote: If the exception type isn't one of the normal faults, don't try to map and instead go straight to a terminal fault. "One of the the normal faults" seems a rather vague way of saying "a translation fault", which is what we're specifically handling her

Re: [PATCH 1/2] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv

2020-02-05 Thread Steven Price
On 04/02/2020 14:35, Boris Brezillon wrote: > Jobs can be in-flight when the file descriptor is closed (either because > the process did not terminate properly, or because it didn't wait for > all GPU jobs to be finished), and apparently panfrost_job_close() does > not cancel already running jobs.

Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler

2020-02-05 Thread Steven Price
On 04/02/2020 14:35, Boris Brezillon wrote: > ->job_run() can return an ERR_PTR() if somethings fails. Let's > propagate the error returned by panfrost_fence_create() instead of > returning NULL. > > Signed-off-by: Boris Brezillon In your previous posting[1] you also handled the case where job->

Re: [PATCH 1/2] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv

2020-02-05 Thread Boris Brezillon
On Wed, 5 Feb 2020 13:39:21 + Steven Price wrote: > On 04/02/2020 14:35, Boris Brezillon wrote: > > Jobs can be in-flight when the file descriptor is closed (either because > > the process did not terminate properly, or because it didn't wait for > > all GPU jobs to be finished), and apparent

Re: [PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Steven Price
On 05/02/2020 13:25, Robin Murphy wrote: > On 05/02/2020 10:07 am, Tomeu Vizoso wrote: >> If the exception type isn't one of the normal faults, don't try to map >> and instead go straight to a terminal fault. > > "One of the the normal faults" seems a rather vague way of saying "a > translation fa

Re: [PATCH 1/2] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv

2020-02-05 Thread Steven Price
On 05/02/2020 14:01, Boris Brezillon wrote: > On Wed, 5 Feb 2020 13:39:21 + > Steven Price wrote: > >> On 04/02/2020 14:35, Boris Brezillon wrote: >>> Jobs can be in-flight when the file descriptor is closed (either because >>> the process did not terminate properly, or because it didn't wait

Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler

2020-02-05 Thread Boris Brezillon
On Wed, 5 Feb 2020 13:47:55 + Steven Price wrote: > On 04/02/2020 14:35, Boris Brezillon wrote: > > ->job_run() can return an ERR_PTR() if somethings fails. Let's > > propagate the error returned by panfrost_fence_create() instead of > > returning NULL. > > > > Signed-off-by: Boris Brezill

Re: [PATCH 00/14] amdgpu: remove load and unload callbacks

2020-02-05 Thread Harry Wentland
Patches 10-12 are Reviewed-by: Harry Wentland Harry On 2020-02-04 10:48 p.m., Alex Deucher wrote: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. > > Alex Deucher (14): > drm/amdgpu: rename amdgpu_deb

Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler

2020-02-05 Thread Steven Price
On Wed, Feb 05, 2020 at 02:21:55PM +, Boris Brezillon wrote: > On Wed, 5 Feb 2020 13:47:55 + > Steven Price wrote: > > > On 04/02/2020 14:35, Boris Brezillon wrote: > > > ->job_run() can return an ERR_PTR() if somethings fails. Let's > > > propagate the error returned by panfrost_fence_

RE: [PATCH v3 01/17] drm: add DP 1.4 VSC SDP Payload related enums and a structure

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 01/17] drm: add DP 1.4 VSC SDP Payload related e

Re: [PATCH 4/5] drm/i915: Wean off drm_pci_alloc/drm_pci_free

2020-02-05 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: de09d31dd38a ("page-flags: define PG_reserved behavior on compound pages"). The bot has tested the following trees: v5.5.1, v5.4.17, v4.19.101, v4.14.169, v4.9.212. v5.5.1: Build

RE: [PATCH v3 02/17] drm/i915/dp: Add compute routine for DP VSC SDP

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 02/17] drm/i915/dp: Add compute routine for DP V

RE: [PATCH v3 03/17] drm/i915/dp: Add compute routine for DP HDR Metadata Infoframe SDP

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 03/17] drm/i915/dp: Add compute routine for DP H

Re: [PATCH v3 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-02-05 Thread Christian König
Am 05.02.20 um 13:53 schrieb Thomas Hellström (VMware): From: Thomas Hellstrom Support huge (PMD-size and PUD-size) page-table entries by providing a huge_fault() callback. We still support private mappings and write-notify by splitting the huge page-table entries on write-access. Note that fo

[PATCH V6] drm: Add support for DP 1.4 Compliance edid corruption test

2020-02-05 Thread Jerry (Fangzhi) Zuo
Unlike DP 1.2 edid corruption test, DP 1.4 requires to calculate real CRC value of the last edid data block, and write it back. Current edid CRC calculates routine adds the last CRC byte, and check if non-zero. This behavior is not accurate; actually, we need to return the actual CRC value when co

[PATCH 03/15] drm/amdgpu/pm: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for pm. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 7 +++ drivers/gpu/drm/amd/amdgpu/am

[PATCH 00/15] amdgpu: remove load and unload callbacks (v2)

2020-02-05 Thread Alex Deucher
These are deprecated and the drm will soon start warning when drivers still use them. It was a long and twisty road, but seems to work. v2: Add additional patch (13/15) which should fix the crash reported by Thomas Zimmermann. Alex Deucher (15): drm/amdgpu: rename amdgpu_debugfs_preempt_cleanu

[PATCH 04/15] drm/amdgpu/sa: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for SA (sub allocator). Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 drivers/gpu/drm/

[PATCH 10/15] drm/amdgpu/display: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for display. Reviewed-by: Harry Wentland Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |

[PATCH 07/15] drm/amdgpu/regs: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for register access files. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 drivers/gpu/d

[PATCH 06/15] drm/amdgpu/gem: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for gem. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 02/15] drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for ttm. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 10 ++ drivers/gpu/drm/amd/amdg

[PATCH 01/15] drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup

2020-02-05 Thread Alex Deucher
to amdgpu_debugfs_fini. It will be used for other things in the future. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 3 file

[PATCH 15/15] drm/amdgpu: drop legacy drm load and unload callbacks

2020-02-05 Thread Alex Deucher
We've moved the debugfs handling into a centralized place so we can remove the legacy load an unload callbacks. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 13 +++-- 2 files

[PATCH 11/15] drm/amd/display: move dpcd debugfs members setup

2020-02-05 Thread Alex Deucher
Into the function that creates the debugfs files rather than setting them explicitly in the callers. Reviewed-by: Harry Wentland Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- drivers/gpu/drm/amd/display/amdgpu_dm/a

[PATCH 05/15] drm/amdgpu/fence: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for fence handling. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 +++ drivers/gpu/drm/amd/a

[PATCH 08/15] drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for firmware. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 drivers/gpu/drm/amd/amdgpu

[PATCH 12/15] drm/amdgpu/display: add a late register connector callback

2020-02-05 Thread Alex Deucher
To handle debugfs setup on non DP MST connectors. Reviewed-by: Harry Wentland Acked-by: Christian König Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH 14/15] drm/amdgpu/ring: move debugfs init into core amdgpu debugfs

2020-02-05 Thread Alex Deucher
In order to remove the load and unload drm callbacks, we need to reorder the init sequence to move all the drm debugfs file handling. Do this for rings. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 23 - drivers/gpu

[PATCH 13/15] drm/amdgpu/display: split dp connector registration

2020-02-05 Thread Alex Deucher
Split into init and register functions to avoid a segfault in some configs when the load/unload callbacks are removed. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 10 ++ drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +--- .../d

[PATCH 09/15] drm/amdgpu: don't call drm_connector_register for non-MST ports

2020-02-05 Thread Alex Deucher
The core does this for us now. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 1 - drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 3 files changed, 3 deletions(-) di

[PATCH v4 02/17] drm/i915/dp: Add compute routine for DP VSC SDP

2020-02-05 Thread Gwan-gyeong Mun
In order to support state readout for DP VSC SDP, we need to have a structure which holds DP VSC SDP payload data such as "union hdmi_infoframe drm" which is used for DRM infoframe. It adds a struct drm_dp_vsc_sdp vsc to intel_crtc_state.infoframes. And it stores computed dp vsc sdp to infoframes.

[PATCH v4 12/17] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP

2020-02-05 Thread Gwan-gyeong Mun
Added state readout for DP HDR Metadata Infoframe SDP. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_ddi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 857014fe5880..

[PATCH v4 11/17] drm/i915: Program DP SDPs with computed configs

2020-02-05 Thread Gwan-gyeong Mun
In order to use computed config for DP SDPs (DP VSC SDP and DP HDR Metadata Infoframe SDP), it replaces intel_dp_vsc_enable() function and intel_dp_hdr_metadata_enable() function to intel_dp_set_infoframes() function. Before applying it, routines of program SDP always calculated configs when they

[PATCH v4 01/17] drm: add DP 1.4 VSC SDP Payload related enums and a structure

2020-02-05 Thread Gwan-gyeong Mun
It adds new enumeration definitions for VSC SDP Payload for Pixel Encoding/Colorimetry Format. And it adds a new drm data structure for DP VSC SDP. enum dp_colorspace and enum dp_colorimetry correspond "Pixel Encoding and Colorimetry Formats". enum dp_dynamic_range corresponds "Dynamic Range". And

[PATCH v4 07/17] drm: Add logging function for DP VSC SDP

2020-02-05 Thread Gwan-gyeong Mun
When receiving video it is very useful to be able to log DP VSC SDP. This greatly simplifies debugging. v2: Minor style fix v3: Move logging functions to drm core [Jani N] Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/drm_dp_helper.c | 174 include/drm/drm_

[PATCH v4 10/17] drm/i915: Include DP VSC SDP in the crtc state dump

2020-02-05 Thread Gwan-gyeong Mun
Dump out the DP VSC SDP in the normal crtc state dump v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp Use drm core's DP VSC SDP logging function Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_display.c | 13 + 1 file changed, 13 insert

[PATCH v4 05/17] video/hdmi: Add Unpack only function for DRM infoframe

2020-02-05 Thread Gwan-gyeong Mun
It adds an unpack only function for DRM infoframe for dynamic range and mastering infoframe readout. It unpacks the information data block contained in the binary buffer into a structured frame of the HDMI Dynamic Range and Mastering (DRM) information frame. In contrast to hdmi_drm_infoframe_unpac

[PATCH v4 03/17] drm/i915/dp: Add compute routine for DP HDR Metadata Infoframe SDP

2020-02-05 Thread Gwan-gyeong Mun
It stores computed dp hdr metadata infoframe sdp to infoframes.drm of crtc state. It referenced intel_hdmi_compute_drm_infoframe(). While computing, we'll also fill out the inforames.enable bitmask appropriately. v2: Wrap a long line. v4: Use struct drm_device logging macros Signed-off-by: Gwan-

[PATCH v4 00/17] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-02-05 Thread Gwan-gyeong Mun
In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata Infoframe SDP, DP VSC SDP), it refactors handling DP SDPs codes. It adds new compute routines for DP HDR Metadata Infoframe SDP and DP VSC SDP. And new writing routines of DP SDPs (Secondary Data Packet) that uses computed configs

[PATCH v4 08/17] drm/i915: Include HDMI DRM infoframe in the crtc state dump

2020-02-05 Thread Gwan-gyeong Mun
Dump out the HDMI Dynamic Range and Mastering (DRM) infoframe in the normal crtc state dump. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915

[PATCH v4 13/17] drm/i915: Add state readout for DP VSC SDP

2020-02-05 Thread Gwan-gyeong Mun
Added state readout for DP VSC SDP and enabled state validation for DP VSC SDP. v2: Minor style fix v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp v4: Use struct drm_device logging macros Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_ddi.c | 1

[PATCH v4 06/17] drm/i915/dp: Read out DP SDPs (Secondary Data Packet)

2020-02-05 Thread Gwan-gyeong Mun
It adds code to read the DP SDPs from the video DIP and unpack them into the crtc state. It adds routines that read out DP VSC SDP and DP HDR Metadata Infoframe SDP In order to unpack DP VSC SDP, it adds intel_dp_vsc_sdp_unpack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header Byte

[PATCH v4 04/17] drm/i915/dp: Add writing of DP SDPs (Secondary Data Packet)

2020-02-05 Thread Gwan-gyeong Mun
It adds routines that write DP VSC SDP and DP HDR Metadata Infoframe SDP. In order to pack DP VSC SDP, it adds intel_dp_vsc_sdp_pack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header Bytes] and [Table 2-117: VSC SDP Payload for DB16 through DB18] In order to pack DP HDR Metadata In

[PATCH v4 16/17] drm/i915/dp: Add compute routine for DP PSR VSC SDP

2020-02-05 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it adds a compute routine for PSR VSC SDP. As PSR routine can not use infoframes.vsc of crtc state, it also adds new writing of DP SDPs (Secondary Data Packet) for PSR. PSR routine has its own scenario and timings of writing a VS

[PATCH v4 09/17] drm/i915: Include DP HDR Metadata Infoframe SDP in the crtc state dump

2020-02-05 Thread Gwan-gyeong Mun
Dump out the DP HDR Metadata Infoframe SDP in the normal crtc state dump. HDMI Dynamic Range and Mastering (DRM) infoframe and DP HDR Metadata Infoframe SDP use the same member variable in infoframes of crtc state. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_display.c

[PATCH v4 14/17] drm/i915: Program DP SDPs on pipe updates

2020-02-05 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes() function on pipe updates to make sure that we send VSC SDP and HDR Metadata Infoframe SDP (when applicable) on fastsets. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/

[PATCH v4 15/17] drm/i915: Stop sending DP SDPs on intel_ddi_post_disable_dp()

2020-02-05 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes(false) function on intel_ddi_post_disable_dp() to make sure not to send VSC SDP and HDR Metadata Infoframe SDP. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/disp

[PATCH v4 17/17] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-02-05 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it uses a new psr vsc sdp compute routine. Because PSR routine has its own scenario and timings of writing a VSC SDP, the current PSR routine needs to have its own drm_dp_vsc_sdp structure member variable on struct i915_psr. In

Re: [PATCH 1/2] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv

2020-02-05 Thread Robin Murphy
On 04/02/2020 2:35 pm, Boris Brezillon wrote: Jobs can be in-flight when the file descriptor is closed (either because the process did not terminate properly, or because it didn't wait for all GPU jobs to be finished), and apparently panfrost_job_close() does not cancel already running jobs. Let'

Re: [PATCH V6] drm: Add support for DP 1.4 Compliance edid corruption test

2020-02-05 Thread Harry Wentland
On 2020-02-05 10:22 a.m., Jerry (Fangzhi) Zuo wrote: > Unlike DP 1.2 edid corruption test, DP 1.4 requires to calculate > real CRC value of the last edid data block, and write it back. > Current edid CRC calculates routine adds the last CRC byte, > and check if non-zero. > > This behavior is no

RE: [PATCH v3 04/17] drm/i915/dp: Add writing of DP SDPs (Secondary Data Packet)

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 04/17] drm/i915/dp: Add writing of DP SDPs (Secon

RE: [Intel-gfx] [PATCH v3 05/17] video/hdmi: Add Unpack only function for DRM infoframe

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 05/17] video/hdmi: Add Unpack only f

Re: [PATCH 00/15] amdgpu: remove load and unload callbacks (v2)

2020-02-05 Thread Thomas Zimmermann
Hi Am 05.02.20 um 16:39 schrieb Alex Deucher: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. > > v2: Add additional patch (13/15) which should fix the crash reported by > Thomas Zimmermann. I tried agai

RE: [PATCH v3 06/17] drm/i915/dp: Read out DP SDPs (Secondary Data Packet)

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 06/17] drm/i915/dp: Read out DP SDPs (Secondary D

RE: [Intel-gfx] [PATCH v3 07/17] drm: Add logging function for DP VSC SDP

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 07/17] drm: Add logging function for

Re: [PATCHv3 1/2] dt-bindings: display: add visionox rm69299 panel variant

2020-02-05 Thread Rob Herring
On Wed, 5 Feb 2020 18:36:29 +0530, Harigovindan P wrote: > Add bindings for visionox rm69299 panel. > > Signed-off-by: Harigovindan P > --- > > Changes in v1: > - Added a compatible string to support sc7180 panel version. > Changes in v2: > - Removed unwanted properties from descrip

RE: [PATCH v3 08/17] drm/i915: Include HDMI DRM infoframe in the crtc state dump

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 08/17] drm/i915: Include HDMI DRM infoframe in t

RE: [PATCH v3 09/17] drm/i915: Include DP HDR Metadata Infoframe SDP in the crtc state dump

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 09/17] drm/i915: Include DP HDR Metadata Infofra

RE: [PATCH v3 10/17] drm/i915: Include DP VSC SDP in the crtc state dump

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 10/17] drm/i915: Include DP VSC SDP in the crtc

RE: [Intel-gfx] [PATCH v3 11/17] drm/i915: Program DP SDPs with computed configs

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 11/17] drm/i915: Program DP SDPs with

RE: [Intel-gfx] [PATCH v3 12/17] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 12/17] drm/i915: Add state readout f

[PATCH] drm/msm/a6xx: Update the GMU bus tables for sc7180

2020-02-05 Thread Jordan Crouse
Fixup the GMU bus table values for the sc7180 target. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 85 --- 1 file changed, 60 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/adr

RE: [PATCH v3 13/17] drm/i915: Add state readout for DP VSC SDP

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 13/17] drm/i915: Add state readout for DP VSC SD

RE: [PATCH v3 14/17] drm/i915: Program DP SDPs on pipe updates

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 14/17] drm/i915: Program DP SDPs on pipe updates

RE: [PATCH v3 15/17] drm/i915: Stop sending DP SDPs on intel_ddi_post_disable_dp()

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 15/17] drm/i915: Stop sending DP SDPs on > intel

RE: [PATCH v3 16/17] drm/i915/dp: Add compute routine for DP PSR VSC SDP

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [PATCH v3 16/17] drm/i915/dp: Add compute routine for DP P

RE: [Intel-gfx] [PATCH v3 17/17] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-02-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Gwan- > gyeong Mun > Sent: Tuesday, February 4, 2020 4:50 AM > To: intel-...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 17/17] drm/i915/psr: Use new DP VSC

Re: [PATCH v4 1/3] dt-bindings: add vendor prefix for OzzMaker and Waveshare Electronics

2020-02-05 Thread Rob Herring
On Mon, 27 Jan 2020 19:55:33 +0530, Kamlesh Gurudasani wrote: > Add vendor prefix for OzzMaker [1] and Waveshare Electronics [2] > Both are display manufacturers > > [1] https://ozzmaker.com/about/ > [2] https://www.waveshare.com/contact_us > > Signed-off-by: Kamlesh Gurudasani > --- > Document

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-05 Thread Laurent Pinchart
Hi Andy, Thank you for the patch. On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote: > This file doesn't need everything provided by . > All it needs are some types, which are provided by . > > Note, already includes , but > not relying on implicit includes is indeed a good thing.

[Intel-gfx] [PATCH v6 4/7] drm/i915/display/power: Make WARN* drm specific where drm_priv ptr is available

2020-02-05 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[Intel-gfx] [PATCH v6 0/7] drm: Introduce struct drm_device based WARN* and use them in i915

2020-02-05 Thread Pankaj Bharadiya
Device specific dev_WARN and dev_WARN_ONCE macros available in kernel include device information in the backtrace, so we know what device the warnings originate from. Similar to this, add new struct drm_device based drm_WARN* macros. These macros include device information in the backtrace, so we

  1   2   >