Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Sam Ravnborg
Hi Rob. On Wed, Apr 15, 2020 at 07:55:48PM -0500, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts

Re: Multiple regulators for one device [was drm/panfrost: add devfreq regulator support]

2020-04-16 Thread Steven Price
On 14/04/2020 20:16, Clément Péron wrote: Hi Mark, On Tue, 14 Apr 2020 at 20:55, Mark Brown wrote: On Tue, Apr 14, 2020 at 08:20:23PM +0200, Clément Péron wrote: Hi Liam and Mark, You might want to flag stuff like this in the subject line, I very nearly deleted this without opening it

Re: [PATCH] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

2020-04-16 Thread Rob Herring
On Thu, Apr 16, 2020 at 7:51 AM Adrian Ratiu wrote: > > This converts the Synopsis MIPI DSI binding documentation to yaml and > should be quite straightforward. I've added a missing ref clk and also > added Mark and Rob as maintainers based on 'get_maintainer.pl' results. > > Cc: Rob Herring >

Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller

2020-04-16 Thread Sam Ravnborg
Hi Linus. On Thu, Apr 16, 2020 at 01:26:32PM +0200, Linus Walleij wrote: > On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > > > Rob wrote: > > > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > > case found in dts files. We should fix that to dsi(@.*)?. > > >

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Arnd Bergmann
On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula wrote: > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: > >> BTW how about adding a new Kconfig option to hide the details of > >> ( BAR || !BAR) ? as Jason already explained and suggested, this

[PATCH] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

2020-04-16 Thread Adrian Ratiu
This converts the Synopsis MIPI DSI binding documentation to yaml and should be quite straightforward. I've added a missing ref clk and also added Mark and Rob as maintainers based on 'get_maintainer.pl' results. Cc: Rob Herring Cc: Mark Rutland Cc: devicet...@vger.kernel.org Suggested-by:

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Rob Herring
On Thu, Apr 16, 2020 at 7:44 AM Sam Ravnborg wrote: > > Hi Rob. > > On Wed, Apr 15, 2020 at 07:55:48PM -0500, Rob Herring wrote: > > Fix various inconsistencies in schema indentation. Most of these are > > list indentation which should be 2 spaces more than the start of the > > enclosing keyword.

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-16 Thread Laurent Pinchart
On Thu, Apr 16, 2020 at 08:51:14AM +0200, Daniel Vetter wrote: > On Wed, Apr 15, 2020 at 11:22 PM Arnd Bergmann wrote: > > On Wed, Apr 15, 2020 at 11:12 PM Laurent Pinchart wrote: > > > On Wed, Apr 15, 2020 at 09:07:14PM +0200, Arnd Bergmann wrote: > > > > On Wed, Apr 15, 2020 at 5:18 PM Arnd

Re: Multiple regulators for one device [was drm/panfrost: add devfreq regulator support]

2020-04-16 Thread Mark Brown
On Thu, Apr 16, 2020 at 02:42:13PM +0100, Steven Price wrote: > On 14/04/2020 20:16, Clément Péron wrote: > > That's can be reworked and Panfrost can only probe regulator if there > > is no opp-table. > This is what I was thinking about looking at. But it may make sense instead > to extend the

Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller

2020-04-16 Thread Rob Herring
On Thu, Apr 16, 2020 at 6:26 AM Linus Walleij wrote: > > On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > > > Rob wrote: > > > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > > case found in dts files. We should fix that to dsi(@.*)?. > > > > See:

Re: [PATCH 1/1] AMDGPU: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)

2020-04-16 Thread Sandeep Raghuraman
Initialize thermal controller fields in the PowerPlay table for Hawaii GPUs, so that fan speeds are reported. Signed-off-by: Sandeep Raghuraman --- .../drm/amd/powerplay/hwmgr/processpptables.c | 28 +++ 1 file changed, 28 insertions(+) diff --git

Re: [PATCH v2 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-16 Thread Laurent Pinchart
Hi Enric, On Thu, Apr 16, 2020 at 11:33:24PM +0200, Enric Balletbo i Serra wrote: > On 16/4/20 19:36, Laurent Pinchart wrote: > > On Thu, Apr 16, 2020 at 08:35:26PM +0300, Laurent Pinchart wrote: > >> On Thu, Apr 16, 2020 at 05:57:19PM +0200, Enric Balletbo i Serra wrote: > >>> Use the

[drm-intel:topic/core-for-CI 2/20] kernel/locking/lockdep.c:2744:49: sparse: sparse: cast truncates bits from constant value (a0000 becomes 0)

2020-04-16 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/core-for-CI head: d0435a9b45070b945578c093dcd363b6b73a502c commit: cbc1ad45be43de36150fd98dae644fc89a69a5a0 [2/20] lockdep: Up MAX_LOCKDEP_CHAINS reproduce: # apt-get install sparse # sparse version:

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Andrzej Hajda
On 16.04.2020 20:21, Jason Gunthorpe wrote: > On Thu, Apr 16, 2020 at 11:12:56AM -0400, Nicolas Pitre wrote: >> On Thu, 16 Apr 2020, Arnd Bergmann wrote: >> >>> On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula >>> wrote: On Thu, 16 Apr 2020, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-16 Thread Enric Balletbo Serra
Hi Adrian, [snip] > >> > >> +static void dw_mipi_dsi_get_hw_version(struct dw_mipi_dsi > >> *dsi) +{ + regmap_read(dsi->regs, DSI_VERSION, > >> >hw_version); + dsi->hw_version &= VERSION; + > >> if (!dsi->hw_version) + dev_err(dsi->dev, "Failed > >> to read DSI hw

Re: [PATCH 11/29] mm: only allow page table mappings for built-in zsmalloc

2020-04-16 Thread Minchan Kim
On Tue, Apr 14, 2020 at 03:13:30PM +0200, Christoph Hellwig wrote: > This allows to unexport map_vm_area and unmap_kernel_range, which are > rather deep internal and should not be available to modules, as they for > example allow fine grained control of mapping permissions, and also > allow

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Laurent Pinchart
Hi Dmitry, On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > 16.04.2020 21:52, Dmitry Osipenko пишет: > ... > >> May I also recommend switching to the DRM panel bridge helper ? It will > >> simplify the code. > > > > Could you please clarify what is the "DRM panel bridge

Re: [PATCH trivial 1/6] dt-bindings: Fix misspellings of "Analog Devices"

2020-04-16 Thread Rob Herring
On Thu, 16 Apr 2020 12:30:53 +0200, Geert Uytterhoeven wrote: > According to https://www.analog.com/, the company name is spelled > "Analog Devices". > > Signed-off-by: Geert Uytterhoeven > --- > .../devicetree/bindings/display/bridge/adi,adv7123.txt| 4 ++-- >

Re: [PATCH 1/1] AMDGPU: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)

2020-04-16 Thread Alex Deucher
On Thu, Apr 16, 2020 at 4:07 PM Sandeep Raghuraman wrote: > > Initialize thermal controller fields in the PowerPlay table for Hawaii > GPUs, so that fan speeds are reported. > > Signed-off-by: Sandeep Raghuraman Applied. Thanks! Alex > > --- > .../drm/amd/powerplay/hwmgr/processpptables.c |

Re: [PATCH v6 01/12] dt-bindings: add img,pvrsgx.yaml for Imagination GPUs

2020-04-16 Thread Rob Herring
On Wed, 15 Apr 2020 10:35:08 +0200, "H. Nikolaus Schaller" wrote: > The Imagination PVR/SGX GPU is part of several SoC from > multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, > Allwinner A83 and others. > > With this binding, we describe how the SGX processor is > interfaced to the

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-16 Thread Minchan Kim
Hi Christoph, Sorry for the late. On Sat, Apr 11, 2020 at 09:20:52AM +0200, Christoph Hellwig wrote: > Hi Minchan, > > On Fri, Apr 10, 2020 at 04:11:36PM -0700, Minchan Kim wrote: > > It doesn't mean we couldn't use zsmalloc as module any longer. It means > > we couldn't use zsmalloc as module

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Sam Ravnborg
Hi Dimitry. On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > 16.04.2020 21:52, Dmitry Osipenko пишет: > ... > >> May I also recommend switching to the DRM panel bridge helper ? It will > >> simplify the code. > > > > Could you please clarify what is the "DRM panel bridge

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Laurent Pinchart
Hi Dmitry, On Fri, Apr 17, 2020 at 12:15:33AM +0300, Dmitry Osipenko wrote: > 16.04.2020 23:50, Laurent Pinchart пишет: > > On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > >> 16.04.2020 21:52, Dmitry Osipenko пишет: > >> ... > May I also recommend switching to the DRM

Re: [PATCH] drm/bridge: panel: Return always an error pointer in drm_panel_bridge_add()

2020-04-16 Thread Laurent Pinchart
Hi Enric, Thank you for the patch. On Thu, Apr 16, 2020 at 11:06:54PM +0200, Enric Balletbo i Serra wrote: > Since commit 89958b7cd955 ("drm/bridge: panel: Infer connector type from > panel by default"), drm_panel_bridge_add() and their variants can return > NULL and an error pointer. This is

Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings

2020-04-16 Thread Doug Anderson
Hi, On Wed, Apr 15, 2020 at 5:54 PM Laurent Pinchart wrote: > > Hi Doug, > > On Wed, Apr 15, 2020 at 04:49:00PM -0700, Doug Anderson wrote: > > On Wed, Apr 15, 2020 at 1:33 PM Laurent Pinchart wrote: > > > On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote: > > > > Quoting Douglas

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Lee Jones
On Wed, 15 Apr 2020, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do transforms on the

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 07:55:49PM -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 07:55:48PM -0500, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do

[PATCH] drm/nouveau: Fix regression by audio component transition

2020-04-16 Thread Takashi Iwai
Since the commit 742db30c4ee6 ("drm/nouveau: Add HD-audio component notifier support"), the nouveau driver notifies and pokes the HD-audio HPD and ELD via audio component, but this seems broken. The culprit is the naive assumption that crtc->index corresponds to the HDA pin. Actually this rather

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Lee Jones
On Wed, 15 Apr 2020, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Arnd Bergmann
On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: > > On Tue, 2020-04-14 at 20:47 +0200, Arnd Bergmann wrote: > > On Tue, Apr 14, 2020 at 7:49 PM Saeed Mahameed > > wrote: > > > On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote: > > > > On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe >

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Linus Walleij
On Thu, Apr 16, 2020 at 2:55 AM Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09

Re: [PATCH] drm/i915/gt: remove redundant assignment to variable x

2020-04-16 Thread Dan Carpenter
On Wed, Apr 15, 2020 at 12:07:44PM +0300, Jani Nikula wrote: > On Tue, 14 Apr 2020, Colin Ian King wrote: > > Hi Dan, > > > > I'd post a revert, but I don't seem to see an upstream commit for this > > this to revert against. What's the revert policy in these cases? Or can > > the patch be just

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Vinod Koul
On 15-04-20, 19:55, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Vinod Koul
On 15-04-20, 19:55, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do transforms on the

UAPI doc (Re: KMS enums and bitfields UAPI)

2020-04-16 Thread Pekka Paalanen
On Wed, 15 Apr 2020 10:40:36 + Simon Ser wrote: > On Tuesday, April 14, 2020 3:33 PM, Daniel Vetter wrote: > > > > What I'm suggesting isn't to make all enum values UAPI. I'm suggesting > > > to add standard enum values as #defines in the UAPI headers to make > > > these values UAPI.

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

2020-04-16 Thread Krzysztof Kozlowski
On Wed, Apr 15, 2020 at 11:17:16AM -0700, Jonathan Bakker wrote: > >> > >>> + > >>> + assigned-clocks = < MOUT_G3D>, < > >>> DOUT_G3D>; > >>> + assigned-clock-rates = <0>, <6670>; > >>> + assigned-clock-parents = <

Re: [PATCH v12 09/11] backlight: pwm_bl: Use 64-bit division function

2020-04-16 Thread Lee Jones
On Wed, 08 Apr 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.period's datatype > to u64, prepare for this transition by using div_u64 to handle a 64-bit > dividend instead of a straight division operation. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc:

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Jani Nikula
On Thu, 16 Apr 2020, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: >> BTW how about adding a new Kconfig option to hide the details of >> ( BAR || !BAR) ? as Jason already explained and suggested, this will >> make it easier for the users and developers to

[PATCH trivial 6/6] ASoC: Fix misspellings of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
According to https://www.analog.com/, the company name is spelled "Analog Devices". Signed-off-by: Geert Uytterhoeven --- sound/soc/codecs/ad1980.c | 2 +- sound/soc/codecs/ad73311.c | 2 +- sound/soc/codecs/wm8782.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH trivial 0/6] Fix misspellings of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
Hi all, In several files the company also known as ADI is spelled as "Analog Device". However, according to https://www.analog.com/, the company name is spelled "Analog Devices". Hence this patch series, one per subsystem, fixes these misspellings. Thanks for your comments! Geert

[PATCH trivial 1/6] dt-bindings: Fix misspellings of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
According to https://www.analog.com/, the company name is spelled "Analog Devices". Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/display/bridge/adi,adv7123.txt| 4 ++-- .../devicetree/bindings/display/bridge/adi,adv7511.txt| 4 ++--

[PATCH trivial 5/6] ALSA: Fix misspellings of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
According to https://www.analog.com/, the company name is spelled "Analog Devices". Signed-off-by: Geert Uytterhoeven --- sound/isa/ad1816a/ad1816a.c | 2 +- sound/pci/ac97/ac97_patch.c | 2 +- sound/pci/hda/Kconfig | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH trivial 2/6] dma: Fix misspelling of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
According to https://www.analog.com/, the company name is spelled "Analog Devices". Signed-off-by: Geert Uytterhoeven --- drivers/dma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 0924836443152fb5..c35c0e03b40f026b

[PATCH trivial 3/6] drm: Fix misspellings of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
According to https://www.analog.com/, the company name is spelled "Analog Devices". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/adv7511/Kconfig | 2 +- drivers/gpu/drm/drm_fb_cma_helper.c| 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- 3 files changed, 3

[PATCH trivial 4/6] iio: Fix misspellings of "Analog Devices"

2020-04-16 Thread Geert Uytterhoeven
According to https://www.analog.com/, the company name is spelled "Analog Devices". Signed-off-by: Geert Uytterhoeven --- drivers/iio/adc/ad7791.c | 2 +- drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- drivers/staging/iio/Documentation/overview.txt | 2 +- 3 files

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Mark Brown
On Wed, Apr 15, 2020 at 07:55:49PM -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed Acked-by: Mark

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Mark Brown
On Wed, Apr 15, 2020 at 07:55:48PM -0500, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-16 Thread Dan Carpenter
On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > @@ -238,6 +242,10 @@ static void ion_unmap_dma_buf(struct dma_buf_attachment > *attachment, > struct sg_table *table, > enum dma_data_direction direction) > { > + struct

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-16 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman > wrote: > > > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > > is actually mapped on

Re: [PATCH v2 05/36] dt-bindings: display: convert arm,versatile-tft-panel to DT Schema

2020-04-16 Thread Linus Walleij
On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > v2: > - Fix entry in MAINTAINERS > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel

Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller

2020-04-16 Thread Linus Walleij
On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > Rob wrote: > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > case found in dts files. We should fix that to dsi(@.*)?. > > See: https://lore.kernel.org/dri-devel/2020031903.GK29911@bogus/ > > Fix it. > >

Re: [PATCH] drm: Don't free a struct never allocated by drm_gem_fb_init()

2020-04-16 Thread Andrzej Pietrasiewicz
W dniu 15.04.2020 o 20:33, Daniel Vetter pisze: On Wed, Apr 15, 2020 at 7:19 PM Andrzej Pietrasiewicz wrote: drm_gem_fb_init() is passed the fb and never allocates it, so it should be not the one freeing it. As it is now the second call to kfree() is possible with the same fb. Coverity

<    1   2