Re: [PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug

2020-06-23 Thread Christian König
Am 23.06.20 um 07:11 schrieb Andrey Grodzovsky: On 6/22/20 3:40 PM, Christian König wrote: Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: entity->rq becomes null aftre device unplugged so just return early in that case. Mhm, do you have a backtrace for this? This should only be called by

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

2020-06-23 Thread Greg KH
On Tue, Jun 23, 2020 at 12:51:00AM -0400, Andrey Grodzovsky wrote: > > On 6/22/20 12:45 PM, Greg KH wrote: > > On Mon, Jun 22, 2020 at 12:07:25PM -0400, Andrey Grodzovsky wrote: > > > On 6/22/20 7:21 AM, Greg KH wrote: > > > > On Mon, Jun 22, 2020 at 11:51:24AM +0200, Daniel Vetter wrote: > > > >

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Deepak Rawat
On Tue, 2020-06-23 at 02:31 +, Dexuan Cui wrote: > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Deepak Rawat > > Sent: Monday, June 22, 2020 4:06 AM > > > > DRM driver for hyperv synthetic video device, based on hyperv_fb > > framebuffer driver. Also added config option

Re: [PATCH v2 6/6] drm/i915/dp_mst: Ensure the DPCD ACT sent flag is cleared before waiting for it

2020-06-23 Thread Imre Deak
On Wed, Jun 17, 2020 at 12:11:46AM +0300, Imre Deak wrote: > Atm, we clear the ACT sent flag in the sink's DPCD before updating the > sink's payload table, along clearing the payload table updated flag. > The sink is supposed to set this flag once it detects that the source > has completed the ACT

Re: [virtio-dev] Re: [PATCH v5 0/3] Support virtio cross-device resources

2020-06-23 Thread David Stevens
Unless there are any remaining objections to these patches, what are the next steps towards getting these merged? Sorry, I'm not familiar with the workflow for contributing patches to Linux. Thanks, David On Tue, Jun 9, 2020 at 6:53 PM Michael S. Tsirkin wrote: > > On Tue, Jun 09, 2020 at

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Thomas Zimmermann
Hi Deepak I did not receive you pat series, so I can only comment on Sam's reply. See below for some points. Am 22.06.20 um 17:19 schrieb Sam Ravnborg: > Hi Deepak > > On Mon, Jun 22, 2020 at 04:06:22AM -0700, Deepak Rawat wrote: >> DRM driver for hyperv synthetic video device, based on

Re: [PATCH v2 0/8] RFC Support hot device unplug in amdgpu

2020-06-23 Thread Michel Dänzer
On 2020-06-23 7:14 a.m., Andrey Grodzovsky wrote: > I am fighting with Thunderbird to make limit a line to 80 chars but > nothing helps. Any suggestions please. Maybe try disabling mail.compose.default_to_paragraph, or check other *wrap* settings. -- Earthling Michel Dänzer |

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 03:20:34PM -0700, Deepak Rawat wrote: > On Mon, 2020-06-22 at 14:46 +0200, Gerd Hoffmann wrote: > > Hi, > > > > > +/* Should be done only once during init and resume */ > > > +static int synthvid_update_vram_location(struct hv_device *hdev, > > > +

RE: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Deepak Rawat > Sent: Monday, June 22, 2020 4:06 AM > > DRM driver for hyperv synthetic video device, based on hyperv_fb > framebuffer driver. Also added config option "DRM_HYPERV" to enabled > this driver. Hi Deepak, I had a quick look

[RFC] Host1x/TegraDRM UAPI

2020-06-23 Thread Mikko Perttunen
# Host1x/TegraDRM UAPI proposal This is a proposal for a stable UAPI for Host1x and TegraDRM, to replace the current TegraDRM UAPI that is behind `STAGING` and quite obsolete in many ways. I haven't written any implementation yet -- I'll do that once there is some agreement on the

Re: [PATCH v2 6/8] drm/amdgpu: Unmap entire device address space on device remove.

2020-06-23 Thread Christian König
Am 23.06.20 um 12:22 schrieb Daniel Vetter: On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote: On Mon, Jun 22, 2020 at 3:38 PM Christian König wrote: Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: Use the new TTM interface to invalidate all exsisting BO CPU mappings form all user

Re: [PATCH v2 0/9] Convert the remaining text files to ReST and add SPDX for GFDL

2020-06-23 Thread Mauro Carvalho Chehab
Hi Kate, Em Tue, 23 Jun 2020 06:58:55 -0500 Kate Stewart escreveu: > On Tue, Jun 23, 2020 at 4:53 AM Mauro Carvalho Chehab > wrote: > > > > The main goal of this series is to finish the ReST conversion. After this > > series, we have just those files still in plain old format: > > > >

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-23 Thread Christian König
Am 23.06.20 um 12:25 schrieb Daniel Vetter: On Tue, Jun 23, 2020 at 01:00:02AM -0400, Andrey Grodzovsky wrote: On 6/22/20 5:45 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: Helper function to be used to invalidate all BOs CPU mappings once device

[PATCH v3 3/7] docs: move nommu-mmap.txt to admin-guide and rename to ReST

2020-06-23 Thread Mauro Carvalho Chehab
The nommu-mmap.txt file provides description of user visible behaviuour. So, move it to the admin-guide. As it is already at the ReST, also rename it. Suggested-by: Mike Rapoport Suggested-by: Jonathan Corbet Signed-off-by: Mauro Carvalho Chehab --- Documentation/admin-guide/mm/index.rst

Re: [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)

2020-06-23 Thread Pavel Machek
Hi! > > > > Would it not be better to have one st7703 driver that suipports both > > > > panels? > > > > > > > > The driver would need dedicated init functions depending on the panel. > > > > But a lot could also be shared. > > > > > > I guess I can move the code there. > > In the same process

[PATCH v3 0/7] Convert the remaining text files to ReST

2020-06-23 Thread Mauro Carvalho Chehab
The main goal of this series is to finish the ReST conversion. After this series, we have just those files still in plain old format: - Documentation/RCU/RTFP.txt - Documentation/atomic_bitops.txt - Documentation/memory-barriers.txt - Documentation/atomic_t.txt

RE: [PATCH v2] dmabuf: use spinlock to access dmabuf->name

2020-06-23 Thread Ruhl, Michael J
>-Original Message- >From: charante=codeaurora@mg.codeaurora.org > On Behalf Of Charan Teja >Kalla >Sent: Tuesday, June 23, 2020 7:34 AM >To: Ruhl, Michael J ; Sumit Semwal >; david.lai...@aculab.com; open list:DMA >BUFFER SHARING FRAMEWORK ; DRI mailing >list >Cc: Linaro MM SIG ;

Re: [PATCH v2 6/8] drm/amdgpu: Unmap entire device address space on device remove.

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote: > On Mon, Jun 22, 2020 at 3:38 PM Christian König > wrote: > > > > Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: > > > Use the new TTM interface to invalidate all exsisting BO CPU mappings > > > form all user proccesses. > > > > > >

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Asus T101HA panel

2020-06-23 Thread Hans de Goede
Hi, On 5/31/20 7:25 PM, Emil Velikov wrote: On Sun, 31 May 2020 at 10:30, Hans de Goede wrote: Like the Asus T100HA the Asus T101HA also uses a panel which has been mounted 90 degrees rotated, add a quirk for this. Reading the commit message, made me wonder: If it's similar why it doesn't

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Thomas Zimmermann
Hi Am 23.06.20 um 11:12 schrieb Deepak Rawat: > On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: >> Hi Deepak >> >> I did not receive you pat series, so I can only comment on Sam's >> reply. >> See below for some points. > > Hi Thomas, Thanks for the review. I wanted to add you in cc

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-23 Thread Daniel Vetter
On Fri, Jun 12, 2020 at 1:35 AM Felix Kuehling wrote: > > Am 2020-06-11 um 10:15 a.m. schrieb Jason Gunthorpe: > > On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel Vetter wrote: > >>> I still have my doubts about allowing fence waiting from within shrinkers. > >>> IMO ideally they should use a

Re: [PATCH v1 1/2] drm/panel-simple: Correct EDT ET057090DHU connector type

2020-06-23 Thread Dmitry Osipenko
22.06.2020 01:29, Laurent Pinchart пишет: > Hi Dmitry, > > Thank you for the patch. > > On Mon, Jun 22, 2020 at 01:27:41AM +0300, Dmitry Osipenko wrote: >> The EDT ET057090DHU panel has a DPI connector and not LVDS. This patch >> corrects the panel's description. >> >> Reported-by: Laurent

Re: [PATCH v2] dmabuf: use spinlock to access dmabuf->name

2020-06-23 Thread Charan Teja Kalla
Hello Mike, On 6/19/2020 7:11 PM, Ruhl, Michael J wrote: >> -Original Message- >> From: charante=codeaurora@mg.codeaurora.org >> On Behalf Of Charan Teja >> Kalla >> Sent: Friday, June 19, 2020 7:57 AM >> To: Sumit Semwal ; Ruhl, Michael J >> ; david.lai...@aculab.com; open list:DMA

Re: [PATCH v1 0/11] support cmdq helper function on mt6779 platform

2020-06-23 Thread Dennis-YC Hsieh
Hi Bibby, On Mon, 2020-06-22 at 10:40 +0800, Bibby Hsieh wrote: > Hi, Dennis, > > Please add "depends on patch: support gce on mt6779 platform" in cover > letter. Thanks ok will do, thanks Regards, Dennis > > Bibby > > On Sun, 2020-06-21 at 22:18 +0800, Dennis YC Hsieh wrote: > > This

Re: [PATCH v1 03/11] soc: mediatek: cmdq: add write_s function

2020-06-23 Thread Dennis-YC Hsieh
Hi Matthias, On Mon, 2020-06-22 at 17:54 +0200, Matthias Brugger wrote: > > On 22/06/2020 17:36, Dennis-YC Hsieh wrote: > > Hi Matthias, > > > > thanks for your comment. > > > > On Mon, 2020-06-22 at 13:07 +0200, Matthias Brugger wrote: > >> > >> On 21/06/2020 16:18, Dennis YC Hsieh wrote: >

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-23 Thread Jason Gunthorpe
On Fri, Jun 19, 2020 at 04:31:47PM -0400, Jerome Glisse wrote: > Not doable as page refcount can change for things unrelated to GUP, with > John changes we can identify GUP and we could potentialy copy GUPed page > instead of COW but this can potentialy slow down fork() and i am not sure > how

[PATCH 1/1] drm/mm/selftests: fix wrong return type casting

2020-06-23 Thread Nirmoy Das
Function prepare_igt_frag() and get_insert_time() were casting signed value to unsigned value before returning error. So error check in igt_frag() would not work with unsigned return value from get_insert_time() compared against negative value. Addresses-Coverity: ("Unsigned compared against 0,

[PATCH] drm/omap: Remove aggregate initialization of new_mode in omap_connector_mode_valid

2020-06-23 Thread Nathan Chancellor
After commit 42acb06b01b1 ("drm: pahole struct drm_display_mode"), clang warns: drivers/gpu/drm/omapdrm/omap_connector.c:92:39: warning: braces around scalar initializer [-Wbraced-scalar-init] struct drm_display_mode new_mode = { { 0 } };

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-23 Thread Jason Gunthorpe
On Mon, Jun 22, 2020 at 04:15:40PM -0400, Jerome Glisse wrote: > On Mon, Jun 22, 2020 at 08:46:17AM -0300, Jason Gunthorpe wrote: > > On Fri, Jun 19, 2020 at 04:31:47PM -0400, Jerome Glisse wrote: > > > Not doable as page refcount can change for things unrelated to GUP, with > > > John changes we

[PATCH] drm/gma500: Fix direction check in psb_accel_2d_copy()

2020-06-23 Thread Denis Efremov
psb_accel_2d_copy() checks direction PSB_2D_COPYORDER_BR2TL twice. Based on psb_accel_2d_copy_direction() results, PSB_2D_COPYORDER_TL2BR should be checked instead in the second direction check. Fixes: 4d8d096e9ae8 ("gma500: introduce the framebuffer support code") Cc: sta...@vger.kernel.org

valgrind-mmt: rebased against latest upstream valgrind release v3.16.1

2020-06-23 Thread Rhys Kidd
As an update to the nouveau development community, the downstream fork of Valgrind with a mmap tracing tool ("mmt") we maintain has been rebased against the latest upstream release of Valgrind, v3.16.1 Code branch: https://github.com/envytools/valgrind/tree/mmt-3.16.1 Features of upstream

Re: [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)

2020-06-23 Thread Ondřej Jirman
Hello Sam, On Mon, Jun 22, 2020 at 10:08:02AM +0200, Sam Ravnborg wrote: > On Sun, Jun 21, 2020 at 12:30:10AM +0200, Ondřej Jirman wrote: > > On Sat, Jun 20, 2020 at 11:25:29PM +0200, Sam Ravnborg wrote: > > > Hi Ondrej et al. ... > > > Would it not be better to have one st7703 driver that

[PATCH v2] drm/mediatek: check plane visibility in atomic_update

2020-06-23 Thread Hsin-Yi Wang
Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() would proceed with invalid plane and we may see vblank timeout. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu --- v2: Add fixes tag ---

[PATCH 07/14] drm/ast: Don't enable HW cursors twice during atomic update

2020-06-23 Thread Thomas Zimmermann
The ast_cursor_show() helper enables the cursor to be displayed. No need to repeat that operation in the plane's atomic-update function. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c

[PATCH 13/14] drm/ast: Use managed mode-config init

2020-06-23 Thread Thomas Zimmermann
Using drmm_mode_config_init() sets up managed release of modesetting resources. The existing modesetting's finalizer is empty, so remove it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_main.c | 6 +++--- drivers/gpu/drm/ast/ast_mode.c | 4

[PATCH 10/14] drm/ast: Managed cursor release

2020-06-23 Thread Thomas Zimmermann
Register a release function to finalize cursors. The _fini() function gets un-exported from the source file. The function ast_mode_fini() is now empty and will be removed by a later patch. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 38

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Deepak Rawat
On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: > Hi Deepak > > I did not receive you pat series, so I can only comment on Sam's > reply. > See below for some points. Hi Thomas, Thanks for the review. I wanted to add you in cc list but messed it up with final git send-email. Sorry

[PATCH v2 0/9] Convert the remaining text files to ReST and add SPDX for GFDL

2020-06-23 Thread Mauro Carvalho Chehab
The main goal of this series is to finish the ReST conversion. After this series, we have just those files still in plain old format: - Documentation/RCU/RTFP.txt - Documentation/atomic_bitops.txt - Documentation/memory-barriers.txt - Documentation/atomic_t.txt

Re: [PATCH v1 03/11] soc: mediatek: cmdq: add write_s function

2020-06-23 Thread Dennis-YC Hsieh
Hi Matthias, thanks for your comment. On Mon, 2020-06-22 at 13:07 +0200, Matthias Brugger wrote: > > On 21/06/2020 16:18, Dennis YC Hsieh wrote: > > add write_s function in cmdq helper functions which > > writes value contains in internal register to address > > with large dma access support. >

[PATCH v4] drm/mediatek: check plane visibility in atomic_update

2020-06-23 Thread Hsin-Yi Wang
Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() would proceed with invalid plane and we may see vblank timeout. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu Reviewed-by: Tomasz Figa

Re: [PATCH v2] drm/mediatek: check plane visibility in atomic_update

2020-06-23 Thread Hsin-Yi Wang
On Mon, Jun 22, 2020 at 11:20 PM Tomasz Figa wrote: > > Hi Hsin-Yi, > > On Mon, Jun 22, 2020 at 11:01:09PM +0800, Hsin-Yi Wang wrote: > > Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() > > would proceed with invalid plane and we may see vblank timeout. > > > > Fixes:

Re: [PATCH v13 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-06-23 Thread Xin Ji
On Sun, Jun 21, 2020 at 10:09:25AM +0200, Sam Ravnborg wrote: > Hi Xin. > > > On Tue, Jun 09, 2020 at 03:19:50PM +0800, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > > >

Re: [PATCH v1 03/11] soc: mediatek: cmdq: add write_s function

2020-06-23 Thread Dennis-YC Hsieh
Hi Matthias, On Mon, 2020-06-22 at 19:08 +0200, Matthias Brugger wrote: > > On 22/06/2020 18:12, Dennis-YC Hsieh wrote: > > Hi Matthias, > > > > On Mon, 2020-06-22 at 17:54 +0200, Matthias Brugger wrote: > >> > >> On 22/06/2020 17:36, Dennis-YC Hsieh wrote: > >>> Hi Matthias, > >>> > >>>

[PATCH v3] drm/mediatek: check plane visibility in atomic_update

2020-06-23 Thread Hsin-Yi Wang
Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() would proceed with invalid plane and we may see vblank timeout. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu Change-Id:

Re: [PATCH v1 10/11] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-06-23 Thread Dennis-YC Hsieh
Hi Matthias, thanks for your comment. On Mon, 2020-06-22 at 13:19 +0200, Matthias Brugger wrote: > > On 21/06/2020 16:18, Dennis YC Hsieh wrote: > > Add clear parameter to let client decide if > > event should be clear to 0 after GCE receive it. > > > > Signed-off-by: Dennis YC Hsieh > >

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-23 Thread Jason Gunthorpe
On Fri, Jun 19, 2020 at 04:10:11PM -0400, Jerome Glisse wrote: > Maybe we can audit how user ptr buffer are use today and see if > we can define a usage pattern that would allow to cut corner in > kernel. For instance we could use mmu notifier just to block CPU > pte update while we do GUP and

[PATCH] drm/radeon: fix fb_div check in ni_init_smc_spll_table()

2020-06-23 Thread Denis Efremov
clk_s is checked twice in a row in ni_init_smc_spll_table(). fb_div should be checked instead. Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)") Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov --- drivers/gpu/drm/radeon/ni_dpm.c | 2 +- 1 file changed, 1

[PATCH 01/14] drm/ast: Move cursor functions to ast_cursor.c

2020-06-23 Thread Thomas Zimmermann
The cursor manipulation functions are unrelated to modesetting. Move them into their own file. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/Makefile | 3 +- drivers/gpu/drm/ast/ast_cursor.c | 218 +++ drivers/gpu/drm/ast/ast_drv.h| 9 ++

[PATCH 11/14] drm/ast: Init cursors before creating modesetting structures

2020-06-23 Thread Thomas Zimmermann
The cursor helpers reserve buffer objects in VRAM and update their content. So although tied to modesetting, cursor helpers are more of a memory manager. The modesetting's cursor plane requires this functionality, so initialize cursors before modesetting. While at it, also add an error check for

[PATCH 00/14] drm/ast: Managed modesetting

2020-06-23 Thread Thomas Zimmermann
This is the first patchset to convert ast to use managed interfaces. These patches address modesetting. I expect that there will be at least one more set of patches for memory management and one for device strcutures. Patches 1 to 11 tackle HW cursor handling. The overall point is to get cursor

[PATCH 09/14] drm/ast: Keep cursor HW BOs mapped

2020-06-23 Thread Thomas Zimmermann
Updating the image in a cursor's HW BO requires a mapping of the BO's buffer in the kernel's address space. Cursor image updates can happen frequently and create CPU overhead. As cursor HW BOs are small and never move, they are now map exactly once during the initialization and the mapping is

[PATCH 03/14] drm/ast: Move cursor fb pinning and mapping into helper

2020-06-23 Thread Thomas Zimmermann
The new helper ast_cursor_blit() updates a cursor's backbuffer HW BO from a framebuffer structure. The cursor plane's prepare_fb() function now uses the new interface. Pinning and mapping of BOs is done automatically by the helper. This includes the source BO, which was not pinned by the original

[PATCH 14/14] drm/ast: Initialize mode setting in ast_mode_config_init()

2020-06-23 Thread Thomas Zimmermann
There's modesetting init code in ast_main.c. Move it to ast_mode.c and merge it with the modesetting init code in ast_mode_init(). The result is ast_mode_config_init(), which initalizes the whole modesetting. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 2 +-

[PATCH 02/14] drm/ast: Pass struct ast_private instance to cursor init/fini functions

2020-06-23 Thread Thomas Zimmermann
Removes some typecasting. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 7 +++ drivers/gpu/drm/ast/ast_drv.h| 4 ++-- drivers/gpu/drm/ast/ast_mode.c | 6 -- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_cursor.c

[PATCH 05/14] drm/ast: Move cursor pageflip into helper

2020-06-23 Thread Thomas Zimmermann
The new helper ast_cursor_page_flip() switches the cursor's front and back BOs. This simplifies the cursor plane's update helper. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 20 +++- drivers/gpu/drm/ast/ast_drv.h| 2 +-

[PATCH 06/14] drm/ast: Replace ast_cursor_move() with ast_cursor_show()

2020-06-23 Thread Thomas Zimmermann
Having a cursor move function is misleading, as it actually enables the cursor's image for displaying. So rename it to ast_cursor_show(). It's semantics is to show a cursor at the specified location on the screen. The displayed cursor is always the image in the cursor front BO. This change also

[PATCH 12/14] drm/ast: Replace struct ast_crtc with struct drm_crtc

2020-06-23 Thread Thomas Zimmermann
Struct ast_crtc has been cleaned up and it's now a wrapper around the DRM CRTC structure struct drm_crtc. This patch converts the driver to struct drm_crtc and removes struct ast_crtc. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 5 - drivers/gpu/drm/ast/ast_mode.c

[PATCH 04/14] drm/ast: Update cursor image and checksum from same function

2020-06-23 Thread Thomas Zimmermann
Cursor image and checksum go hand in hand. Update both in the same place. The helper cannot fail, so remove the return type. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git

[PATCH 08/14] drm/ast: Add helper to hide cursor

2020-06-23 Thread Thomas Zimmermann
As the inverse to ast_cursor_show(), ast_cursor_hide() disables the HW cursor. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 5 + drivers/gpu/drm/ast/ast_drv.h| 1 + drivers/gpu/drm/ast/ast_mode.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff

Re: [PATCH] drm/mgag200: Enable caching for SHMEM pages

2020-06-23 Thread Rong Chen
On 6/22/20 11:12 PM, Thomas Zimmermann wrote: Hi Am 22.06.20 um 17:00 schrieb Rong Chen: Hi Thomas, I tested the patch based on commit 24b806b0a1dd3, the regression Thanks! of phoronix-test-suite.glmark2.1024x768.score still exists: I expected that the test is related to drawing onto

[PATCH v2 5/9] docs: move nommu-mmap.txt to admin-guide and rename to ReST

2020-06-23 Thread Mauro Carvalho Chehab
The nommu-mmap.txt file provides description of user visible behaviuour. So, move it to the admin-guide. As it is already at the ReST, also rename it. Suggested-by: Mike Rapoport Suggested-by: Jonathan Corbet Signed-off-by: Mauro Carvalho Chehab --- Documentation/admin-guide/mm/index.rst

Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 11:20:51AM +0100, Brian Starkey wrote: > On Fri, Jun 19, 2020 at 06:36:17PM +0200, Daniel Vetter wrote: > > On Fri, Jun 19, 2020 at 01:39:34PM +0100, Brian Starkey wrote: > > > Hi Simon, > > > > > > On Fri, Jun 19, 2020 at 11:12:25AM +, Simon Ser wrote: > > > > There

Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-23 Thread Brian Starkey
On Tue, Jun 23, 2020 at 10:45:51AM +0200, Daniel Vetter wrote: > On Mon, Jun 22, 2020 at 11:20:51AM +0100, Brian Starkey wrote: > > On Fri, Jun 19, 2020 at 06:36:17PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 19, 2020 at 01:39:34PM +0100, Brian Starkey wrote: > > > > Hi Simon, > > > > > > > >

Re: [igt-dev] [Intel-gfx] [PATCH libdrm] intel: sync i915_pciids.h with kernel

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 06:31:24PM +0300, Jani Nikula wrote: > On Tue, 16 Jun 2020, ramadevi.ga...@intel.com wrote: > > From: Gandi Ramadevi > > > > Add DG1 PCI ID > > There are no DG1 PCI IDs in kernel. So please don't add them here > either. Also, do we have anything left using libdrm-intel?

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2020 at 01:00:02AM -0400, Andrey Grodzovsky wrote: > > On 6/22/20 5:45 AM, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: > > > Helper function to be used to invalidate all BOs CPU mappings > > > once device is removed. > > > > > >

Re: [PATCH 08/18] drm/amdgpu: add dma-fence annotations to atomic commit path

2020-06-23 Thread Daniel Vetter
Hi Roland & vmwgfx maintainers, Thomas has played around with these annotations on his vmwgfx setup, and found some issues. Apparently in the atomic_commit_tail path when handling the dirty rectangle stuff you acquire a ttm reservation, which is a no-go since it could deadlock with other paths -

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-06-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #21 from rtmasura+ker...@hotmail.com --- OK. I've uninstalled the vast majority of KDE and am using a vanilla XFCE4. It's been about 12 hours on 5.7.4-arch1-1 and I have yet to have a crash. It is looking like it may be something with

[PATCH] drm/fb-helper: Fix vt restore

2020-06-23 Thread Daniel Vetter
In the past we had a pile of hacks to orchestrate access between fbdev emulation and native kms clients. We've tried to streamline this, by always preferring the kms side above fbdev calls when a drm master exists, because drm master controls access to the display resources. Unfortunately this

Re: [PATCH 4/8] drm/mtk: Use __drm_atomic_helper_crtc_reset

2020-06-23 Thread Chun-Kuang Hu
Hi, Daniel: Daniel Vetter 於 2020年6月13日 週六 上午12:01寫道: > > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > which means vblank state isn't ill-defined and fail-y at driver load > before the first modeset on each crtc. > Acked-by: Chun-Kuang Hu > Signed-off-by: Daniel

Re: [PATCH] drm/gma500: Fix direction check in psb_accel_2d_copy()

2020-06-23 Thread Patrik Jakobsson
On Mon, Jun 22, 2020 at 10:45 PM Denis Efremov wrote: > > psb_accel_2d_copy() checks direction PSB_2D_COPYORDER_BR2TL twice. > Based on psb_accel_2d_copy_direction() results, PSB_2D_COPYORDER_TL2BR > should be checked instead in the second direction check. > > Fixes: 4d8d096e9ae8 ("gma500:

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-06-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #19 from Lyude Paul (ly...@redhat.com) --- Hi! Ben Skeggs pushed a fix for this to their kernel repository: https://github.com/skeggsb/nouveau/commit/2b9345f98be41e2145f561f6cfecc99686f4ef71.patch You should be able to apply it (you

[RFC v6] drm/nouveau/kms/nvd9-: Add CRC support

2020-06-23 Thread Lyude Paul
This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp"

Re: [Linux-graphics-maintainer] [PATCH 2/3] drm: uapi: Use SPDX in DRM drivers uAPI headers

2020-06-23 Thread Roland Scheidegger
At least for the vmwgfx bits, no objections here, Reviewed-by: Roland Scheidegger Am 21.06.20 um 04:07 schrieb Laurent Pinchart: > Most of the DRM drivers uAPI headers are licensed under the MIT license, > and carry copies of the license with slight variations. Replace them > with SPDX headers.

[Bug 208179] [amdgpu] black screen after exiting X

2020-06-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208179 --- Comment #3 from Shlomo (shl...@fastmail.com) --- Yes, this fixes the bug. (tested on top of v5.8-rc2) -- You are receiving this mail because: You are on the CC list for the bug. You are watching the assignee of the bug.

[Bug 208179] [amdgpu] black screen after exiting X

2020-06-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208179 --- Comment #2 from Daniel Vetter (dan...@ffwll.ch) --- Created attachment 289849 --> https://bugzilla.kernel.org/attachment.cgi?id=289849=edit polished fix, hopefully works -- You are receiving this mail because: You are on the CC list for

[PATCH v7 05/17] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling

2020-06-23 Thread Sean Paul
From: Sean Paul Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi. This is particularly important for MST. Suggested-by: Ville Syrjälä Reviewed-by: Ramalingam C Signed-off-by: Sean

[PATCH v7 07/17] drm/i915: Protect workers against disappearing connectors

2020-06-23 Thread Sean Paul
From: Sean Paul This patch adds some protection against connectors being destroyed before the HDCP workers are finished. For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction. In the case of prop_work, we can't

[PATCH v7 09/17] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-06-23 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable

[PATCH v7 04/17] drm/i915: Intercept Aksv writes in the aux hooks

2020-06-23 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an

[PATCH v7 01/17] drm/i915: Fix sha_text population code

2020-06-23 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being

[PATCH v7 02/17] drm/i915: Clear the repeater bit on HDCP disable

2020-06-23 Thread Sean Paul
From: Sean Paul On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect. Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation) Cc: Chris Wilson Cc: Ramalingam C Cc: Daniel Vetter Cc: Sean

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Gerd Hoffmann
Hi, > > > > + msg->vram.user_ctx = msg->vram.vram_gpa = vram_pp; > > > > + msg->vram.is_vram_gpa_specified = 1; > > > > + synthvid_send(hdev, msg); > > > > > > That suggests it is possible to define multiple framebuffers in vram, > > > then pageflip by setting vram.vram_gpa.

Re: [RFC v5 01/10] drm/vblank: Register drmm cleanup action once per drm_vblank_crtc

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 04:07:21PM -0400, Lyude Paul wrote: > Since we'll be allocating resources for kthread_create_worker() in the > next commit (which could fail and require us to clean up the mess), > let's simplify the cleanup process a bit by registering a > drm_vblank_init_release() action

[PATCH v5] drm/fourcc: document modifier uniqueness requirements

2020-06-23 Thread Simon Ser
There have suggestions to bake pitch alignment, address alignement, contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) constraints into modifiers. Last time this was brought up it seemed like the consensus was to not allow this. Document this in drm_fourcc.h. There are several

[kbuild] Re: [PATCH v7 33/36] rapidio: fix common struct sg_table related issues

2020-06-23 Thread Dan Carpenter
Hi Marek, url: https://github.com/0day-ci/linux/commits/Marek-Szyprowski/DRM-fix-struct-sg_table-nents-vs-orig_nents-misuse/20200619-184302 base:ce2cc8efd7a40cbd17841add878cb691d0ce0bba config: i386-randconfig-m021-20200623 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

[PATCH v7 16/17] drm/i915: Print HDCP version info for all connectors

2020-06-23 Thread Sean Paul
From: Sean Paul De-duplicate the HDCP version code for each connector and print it for all connectors. Cc: Juston Li Cc: Ramalingam C Reviewed-by: Juston Li Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-06-23 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Cc: Juston Li Signed-off-by: Sean Paul Link:

[PATCH v7 12/17] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst

2020-06-23 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so move them into a dedicated file for both sst and mst to use. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-11-s...@poorly.run #v1 Link:

[PATCH v7 14/17] drm/i915: Add connector to hdcp_shim->check_link()

2020-06-23 Thread Sean Paul
From: Sean Paul Currently we derive the connector from digital port in check_link(). For MST, this isn't sufficient since the digital port passed into the function can have multiple connectors downstream. This patch adds connector to the check_link() arguments so we have it when we need it.

[PATCH v7 08/17] drm/i915: Clean up intel_hdcp_disable

2020-06-23 Thread Sean Paul
From: Sean Paul Add an out label and un-indent hdcp disable in preparation for hdcp_mutex. No functional changes Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200429195502.39919-9-s...@poorly.run #v6 Changes in v7: -Split into separate patch (Ramalingam) ---

[PATCH v7 06/17] drm/i915: Factor out hdcp->value assignments

2020-06-23 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v7 03/17] drm/i915: WARN if HDCP signalling is enabled upon disable

2020-06-23 Thread Sean Paul
From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-s...@poorly.run #v2 Link:

[PATCH v7 00/17] drm/i915: Add support for HDCP 1.4 over MST

2020-06-23 Thread Sean Paul
From: Sean Paul No functional changes, this set has the following changes since v6: - rebased on drm-tip - split "drm/i915: Clean up intel_hdcp_disable" out of "drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it" - remove hdcp2 dpmst stubs Regarding "level of testing"

[PATCH v7 13/17] drm/i915: Plumb port through hdcp init

2020-06-23 Thread Sean Paul
From: Sean Paul This patch plumbs port through hdcp init instead of relying on intel_attached_encoder() to return a non-NULL encoder which won't work for MST connectors. Cc: Ville Syrjälä Signed-off-by: Sean Paul Link:

[PATCH v7 11/17] drm/i915: Use ddi_update_pipe in intel_dp_mst

2020-06-23 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-10-s...@poorly.run #v1

[PATCH v7 10/17] drm/i915: Support DP MST in enc_to_dig_port() function

2020-06-23 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-9-s...@poorly.run #v1 Link:

[PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-06-23 Thread Sean Paul
From: Sean Paul Used to query whether an MST stream is encrypted or not. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-s...@poorly.run #v4 Link: https://patchwork.freedesktop.org/patch/msgid/20200305201236.152307-15-s...@poorly.run

Re: [PATCH 02/14] drm/ast: Pass struct ast_private instance to cursor init/fini functions

2020-06-23 Thread Sam Ravnborg
Hi Thomas. On Tue, Jun 23, 2020 at 10:18:49AM +0200, Thomas Zimmermann wrote: > Removes some typecasting. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/ast/ast_cursor.c | 7 +++ > drivers/gpu/drm/ast/ast_drv.h| 4 ++-- > drivers/gpu/drm/ast/ast_mode.c | 6 -- > 3

Re: [RFC v5 02/10] drm/vblank: Add vblank works

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 04:07:22PM -0400, Lyude Paul wrote: > Add some kind of vblank workers. The interface is similar to regular > delayed works, and is mostly based off kthread_work. It allows for > scheduling delayed works that execute once a particular vblank sequence > has passed. It also

Re: [PATCH 00/27] Converter R-Car DU to the DRM bridge connector helper

2020-06-23 Thread Sam Ravnborg
Hi Laurent. On Tue, May 26, 2020 at 04:14:38AM +0300, Laurent Pinchart wrote: > Hello, > > This patch series converts the R-Car DU driver to use the DRM bridge > connector helper drm_bridge_connector_init(). > > The bulk of the series is conversion of the adv7511, simple-bridge, > rcar-lbds and

  1   2   >