[PATCH v2 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-07-28 Thread Frank Wunderlich
From: Ryder Lee Add display subsystem related device nodes for MT7623. Cc: CK Hu Signed-off-by: chunhui dai Signed-off-by: Bibby Hsieh Signed-off-by: Ryder Lee Signed-off-by: Frank Wunderlich Tested-by: Frank Wunderlich --- arch/arm/boot/dts/mt7623.dtsi | 177 +

[PATCH 1/2] drm/ingenic: Handle errors of drm_atomic_get_plane_state

2020-07-28 Thread Paul Cercueil
drm_atomic_get_plane_state() can return errors, so we need to handle these. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c

[PATCH RFC v6 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-07-28 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/dpu.yaml

[Linux-kernel-mentees] [PATCH v2] drm/bufs: Prevent kernel-infoleak in copy_one_buf()

2020-07-28 Thread Peilin Ye
Currently `struct drm_buf_desc` is defined as follows: struct drm_buf_desc { int count; int size; int low_mark; int high_mark; enum { _DRM_PAGE_ALIGN = 0x01, _DRM_AGP_BUFFER = 0x02, _DRM_SG_BUFFER = 0x04,

[PATCH v3] drm/hisilicon: Fixed the warning: Assignment of 0/1 to bool variable

2020-07-28 Thread Tian Tao
fixed the following warning: hibmc_drm_drv.c:296:1-18:WARNING: Assignment of 0/1 to bool variable. hibmc_drm_drv.c:301:2-19: WARNING: Assignment of 0/1 to bool variable. v2: using the pci_dev.msi_enabled instead of priv->msi_enabled. v3: just call pci_enable_msi() and pci_disable_msi(), it's no n

[PATCH RFC v6 0/6] Add Unisoc's drm kms module

2020-07-28 Thread Kevin Tang
From: Kevin Tang ChangeList: v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc&

[PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-07-28 Thread Kevin Tang
From: Kevin Tang Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. RFC v6: - Access registers via readl/writel - Checking for unsupported KMS properties (format, rotation, blend_mode, etc)

Re: [PATCH v5 05/16] pwm: lpss: Add pwm_lpss_prepare_enable() helper

2020-07-28 Thread Andy Shevchenko
On Fri, Jul 17, 2020 at 03:37:42PM +0200, Hans de Goede wrote: > In the not-enabled -> enabled path pwm_lpss_apply() needs to get a > runtime-pm reference; and then on any errors it needs to release it > again. > > This leads to somewhat hard to read code. This commit introduces a new > pwm_lpss_p

[PATCH RFC v6 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-07-28 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/dphy.yaml | 75 + .../devicetree/bindings/display/sprd/dsi.yaml

[PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-07-28 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/drm.yaml | 36 ++

[PATCH V2 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013

2020-07-28 Thread Marek Vasut
Add DT bindings for Powertip PH800480T013 800x480 parallel LCD, this one is used in the Raspberry Pi 7" touchscreen display unit. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- V2: Add the bindi

[PATCH RFC v6 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2020-07-28 Thread Kevin Tang
From: Kevin Tang Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/g

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Andrew Cooper
On 28/07/2020 17:59, Roger Pau Monné wrote: > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: >> Hi, >> >> On 27/07/2020 10:13, Roger Pau Monne wrote: >>> To be used in order to create foreign mappings. This is based on the >>> ZONE_DEVICE facility which is used by persistent memory d

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Julien Grall
Hi Roger, On 28/07/2020 17:59, Roger Pau Monné wrote: On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: Hi, On 27/07/2020 10:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devi

[PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-07-28 Thread Frank Wunderlich
From: chunhui dai - disable tmds on phy on mt2701 - support other resolutions like 1280x1024 without this Patch i see flickering on my TFT (1280x1024), so i guess clock is wrong. Signed-off-by: chunhui dai Signed-off-by: Frank Wunderlich Tested-by: Frank Wunderlich --- drivers/gpu/drm/media

[PATCH V2 3/3] drm/panel: simple: Add DT bindings for Powertip PH800480T013

2020-07-28 Thread Marek Vasut
Add support for Powertip PH800480T013 800x480 parallel LCD, this one is used in the Raspberry Pi 7" touchscreen display unit. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- V2: Add bus_flags and

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:06:25PM +0100, Andrew Cooper wrote: > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > >> Hi, > >> > >> On 27/07/2020 10:13, Roger Pau Monne wrote: > >>> To be used in order to create foreign mappings. This is

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Julien Grall
Hi, On 27/07/2020 10:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kerne

[PATCH v2 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-07-28 Thread Frank Wunderlich
From: Stu Hsieh Test: build pass and run ok Signed-off-by: Stu Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 + 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/dr

[PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master

2020-07-28 Thread Kevin Tang
From: Kevin Tang Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by m

RE: [Linux-kernel-mentees] [PATCH v2] drm/bufs: Prevent kernel-infoleak in copy_one_buf()

2020-07-28 Thread David Laight
From: Peilin Ye > Sent: 28 July 2020 12:52 > Currently `struct drm_buf_desc` is defined as follows: > > struct drm_buf_desc { > int count; > int size; > int low_mark; > int high_mark; > enum { > _DRM_PAGE_ALIGN = 0x01, > _DRM_AGP_BUFFER = 0

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-28 Thread Paul Menzel
Dear Linux folks, Am 25.07.20 um 07:20 schrieb Mazin Rezk: On Saturday, July 25, 2020 12:59 AM, Duncan wrote: On Sat, 25 Jul 2020 03:03:52 + Mazin Rezk wrote: Am 24.07.20 um 19:33 schrieb Kees Cook: There was a fix to disable the async path for this driver that worked around the bug t

Re: [PATCH RFC v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-07-28 Thread Kevin Tang
Hi Emil, Sorry, I left for a long time because of other things. Now i'm back~ V6 fix access registers via readl/writel, check unsupported KMS properties (format, rotation, blend mode, etc) by plane_check callback ops and remove always true checks for dpu core ops Add changelog within the correspo

[PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-07-28 Thread Frank Wunderlich
From: Bibby Hsieh We can select output component by decive node port. Main path default output component is DSI. External path default output component is DPI. without this Patch i get this warning: WARNING: CPU: 3 PID: 70 at drivers/gpu/drm/drm_mode_config.c:621 drm_mode_config_validate+0x1d8

[PATCH 2/2] drm/ingenic: Validate mode in a .mode_valid callback

2020-07-28 Thread Paul Cercueil
Validate modes in the drm_crtc_helper_funcs.mode_valid() callback, which is designed for this purpose, instead of doing it in drm_crtc_helper_funcs.atomic_check(). Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +-- 1 file changed, 20 insertio

Re: [PATCH v5 06/16] pwm: lpss: Use pwm_lpss_apply() when restoring state on resume

2020-07-28 Thread Andy Shevchenko
On Fri, Jul 17, 2020 at 03:37:43PM +0200, Hans de Goede wrote: > Before this commit a suspend + resume of the LPSS PWM controller > would result in the controller being reset to its defaults of > output-freq = clock/256, duty-cycle=100%, until someone changes > to the output-freq and/or duty-cycle

[PATCH 2/2] drm/sun4i: backend: Disable alpha on the lowest plane on the A20

2020-07-28 Thread Maxime Ripard
Unlike we previously thought, the per-pixel alpha is just as broken on the A20 as it is on the A10. Remove the quirk that says we can use it. Cc: Paul Kocialkowski Fixes: dcf496a6a608 ("drm/sun4i: sun4i: Introduce a quirk for lowest plane alpha support") Signed-off-by: Maxime Ripard --- driver

[PATCH 1/2] drm/sun4i: backend: Support alpha property on lowest plane

2020-07-28 Thread Maxime Ripard
Unlike what we previously thought, only the per-pixel alpha is broken on the lowest plane and the per-plane alpha isn't. Remove the check on the alpha property being set on the lowest plane to reject a mode. Cc: Paul Kocialkowski Fixes: dcf496a6a608 ("drm/sun4i: sun4i: Introduce a quirk for lowes

Re: [Linux-kernel-mentees] [PATCH v2] drm/bufs: Prevent kernel-infoleak in copy_one_buf()

2020-07-28 Thread Peilin Ye
On Tue, Jul 28, 2020 at 12:35:17PM +, David Laight wrote: > From: Peilin Ye > > Sent: 28 July 2020 12:52 > > Currently `struct drm_buf_desc` is defined as follows: > > > > struct drm_buf_desc { > > int count; > > int size; > > int low_mark; > > int high_mark; > > enum { > >

[PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-07-28 Thread Frank Wunderlich
From: Jitao Shi [Detail] dpi/dsi get the possible_crtc by mtk_drm_find_possible_crtc_by_comp(*drm_dev, ddp_comp) Test: build pass and boot to logo Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- 2 files changed, 4 insertions

Re: [Linux-kernel-mentees] [PATCH] drm/bufs: Prevent kernel-infoleak in copy_one_buf()

2020-07-28 Thread Peilin Ye
On Tue, Jul 28, 2020 at 10:11:09AM +0200, Arnd Bergmann wrote: > On Tue, Jul 28, 2020 at 3:45 AM Peilin Ye wrote: > > > > copy_one_buf() is copying uninitialized stack memory to userspace due to > > the compiler not initializing holes in statically allocated structures. > > Fix it by initializing

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > Hi, > > On 27/07/2020 10:13, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order to create struct pages and k

[PATCH V2 1/3] dt-bindings: Add vendor prefix for Powertip

2020-07-28 Thread Marek Vasut
The Powertip Tech. Corp. is an LCD panel manufacturer. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- V2: No change --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file cha

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:12:46PM +0100, Julien Grall wrote: > Hi Roger, > > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 27/07/2020 10:13, Roger Pau Monne wrote: > > > > To be used in order to create forei

Re: [PATCH v5 05/16] pwm: lpss: Add pwm_lpss_prepare_enable() helper

2020-07-28 Thread Hans de Goede
Hi, On 7/28/20 8:45 PM, Andy Shevchenko wrote: On Fri, Jul 17, 2020 at 03:37:42PM +0200, Hans de Goede wrote: In the not-enabled -> enabled path pwm_lpss_apply() needs to get a runtime-pm reference; and then on any errors it needs to release it again. This leads to somewhat hard to read code.

Re: [PATCH v5 06/16] pwm: lpss: Use pwm_lpss_apply() when restoring state on resume

2020-07-28 Thread Hans de Goede
Hi, On 7/28/20 8:57 PM, Andy Shevchenko wrote: On Fri, Jul 17, 2020 at 03:37:43PM +0200, Hans de Goede wrote: Before this commit a suspend + resume of the LPSS PWM controller would result in the controller being reset to its defaults of output-freq = clock/256, duty-cycle=100%, until someone ch

Re: [PATCH v5 07/16] pwm: crc: Fix period / duty_cycle times being off by a factor of 256

2020-07-28 Thread Hans de Goede
Hi, On 7/28/20 9:36 PM, Andy Shevchenko wrote: On Fri, Jul 17, 2020 at 03:37:44PM +0200, Hans de Goede wrote: While looking into adding atomic-pwm support to the pwm-crc driver I noticed something odd, there is a PWM_BASE_CLK define of 6 MHz and there is a clock-divider which divides this with

Re: [PATCH] nouveau: use ttm populate mapping functions. (v2)

2020-07-28 Thread Ben Skeggs
On Wed, 29 Jul 2020 at 02:08, Ruhl, Michael J wrote: > > >-Original Message- > >From: dri-devel On Behalf Of > >Dave Airlie > >Sent: Monday, July 27, 2020 11:26 PM > >To: dri-devel@lists.freedesktop.org > >Cc: bske...@redhat.com > >Subject: [PATCH] nouveau: use ttm populate mapping functi

Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread Sam Ravnborg
Hi Paul. On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > Here are a few cleanups to the ingenic-drm driver. > - some error paths were missing and have been added; > - the mode validation has been moved to the .mode_valid helper callback. > > Cheers, > -Paul > > Paul Cercueil (2)

Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-07-28 Thread Sam Ravnborg
Hi Kevin On Tue, Jul 28, 2020 at 06:07:54PM +0800, Kevin Tang wrote: > From: Kevin Tang > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed

RE: [PATCH] nouveau: use ttm populate mapping functions. (v2)

2020-07-28 Thread Ruhl, Michael J
>-Original Message- >From: Ben Skeggs >Sent: Tuesday, July 28, 2020 4:16 PM >To: Ruhl, Michael J >Cc: Dave Airlie ; dri-devel@lists.freedesktop.org; >bske...@redhat.com >Subject: Re: [PATCH] nouveau: use ttm populate mapping functions. (v2) > >On Wed, 29 Jul 2020 at 02:08, Ruhl, Michael J

Re: [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master

2020-07-28 Thread Sam Ravnborg
Hi Kevin. Nice split of the driver. Some feedback in the following. Most to bring the driver up-to-date with what have happened since we saw it last time. Keeping up with the changes in drm is not always easy. Sam On Tue, Jul 28, 2020 at 06:07:55PM +0800, Kevin Tang wrote: > From: Kevin

Re: [PATCH RFC v6 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-07-28 Thread Sam Ravnborg
Hi Kevin. On Tue, Jul 28, 2020 at 06:07:56PM +0800, Kevin Tang wrote: > From: Kevin Tang > > DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs > which transfers the image data from a video memory buffer to an internal > LCD interface. > > Cc: Orson Zhai > Cc: Chunyan Z

Re: [PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-07-28 Thread Sam Ravnborg
Hi Kevin. Some feedback in the following. I lost track of thing for the atomic modesettting stuff and I hope other will review that. Sam On Tue, Jul 28, 2020 at 06:07:57PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds DPU(Display Processor Unit) support for the Unisoc's display

Re: [PATCH RFC v6 0/6] Add Unisoc's drm kms module

2020-07-28 Thread Sam Ravnborg
Hi Kevin. Thanks for submitting this set of drivers. To better review the pataches can you please give some kind of high level overview. An ascii block diagram that identifies all the relevant blocks and how they relate would be great. This makes it easier to verify if the right modelling is us

[PATCH 2/2] drm/mcde: Fix display data flow control

2020-07-28 Thread Linus Walleij
Revamp the way that the flow of data to the display is defined. I realized that the hardware supports something like 5 different modes of flow: oneshot, command with TE IRQ, command with BTA (bus turn around) and TE IRQ, video with TE IRQ and video without TE IRQ instead synchronizing to the outpu

[PATCH 1/2] drm/mcde: Rename flow function

2020-07-28 Thread Linus Walleij
The function mcde_display_send_one_frame() has a historical name that stems from being implemented when the driver only supported single frame updates. Rename it mcde_start_flow() so that it reflects the current usage. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/m

Re: [PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-07-28 Thread Daniel Vetter
On Tue, Jul 28, 2020 at 12:08 PM Kevin Tang wrote: > > From: Kevin Tang > > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > RFC v6: > - Access registers via readl/writel > - Checking

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-28 Thread daniel
On Tue, Jul 28, 2020 at 04:16:34PM +, Sidong Yang wrote: > On Sun, Jul 26, 2020 at 12:26:08PM +0200, Daniel Vetter wrote: > > On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen wrote: > > > > > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > > > > > > > No, this very first warning continu

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-28 Thread daniel
On Tue, Jul 28, 2020 at 01:07:13PM -0400, Kazlauskas, Nicholas wrote: > On 2020-07-28 5:22 a.m., Paul Menzel wrote: > > Dear Linux folks, > > > > > > Am 25.07.20 um 07:20 schrieb Mazin Rezk: > > > On Saturday, July 25, 2020 12:59 AM, Duncan wrote: > > > > > > > On Sat, 25 Jul 2020 03:03:52 +

Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread daniel
On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: > Hi Paul. > > On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > > Here are a few cleanups to the ingenic-drm driver. > > - some error paths were missing and have been added; > > - the mode validation has been moved to th

Re: [PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-28 Thread daniel
Hi Hyun Kwon, Are you all sorted with drm-misc commit rights so you can push the 3 (maybe there's more) xlnx fixup patches to drm-misc-next-fixes? Cheers, Daniel On Sat, Jul 25, 2020 at 06:34:29AM +, Wei Yongjun wrote: > Fix typo in parameter description. > > Fixes: d76271d22694 ("drm: xlnx

Re: linux-next: Tree for Jul 27 (drivers/gpu/drm/xlnx/zynqmp-dpsub)

2020-07-28 Thread Laurent Pinchart
Hi Randy, (adding a few people to the CC list to discuss the proposed solution below) Thanks for the report. On Mon, Jul 27, 2020 at 05:49:41PM -0700, Randy Dunlap wrote: > On 7/27/20 6:23 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200724: > > on x86_64: > > WARNING: unme

Re: [PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-28 Thread Laurent Pinchart
Hi Wei, Thank you for the patch. On Sat, Jul 25, 2020 at 06:34:29AM +, Wei Yongjun wrote: > Fix typo in parameter description. > > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort > Subsystem") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Reviewed-b

Re: [PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-28 Thread Laurent Pinchart
On Wed, Jul 29, 2020 at 12:02:05AM +0200, dan...@ffwll.ch wrote: > Hi Hyun Kwon, > > Are you all sorted with drm-misc commit rights so you can push the 3 > (maybe there's more) xlnx fixup patches to drm-misc-next-fixes? Thanks Daniel for bringing this up. Hyun, would that work for you ? > On Sa

Re: [PATCH][next] drm: xln: fix spelling mistake "failes" -> "failed"

2020-07-28 Thread Laurent Pinchart
Hi Colin, Thank you for the patch. On Fri, Jul 24, 2020 at 12:12:58PM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_dbg messages. Fix it. There is a spelling mistake in the commit message, s/xln/xlnx/ ;-) > Signed-off-by: Colin Ian King Reviewed-by

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-28 Thread Jim Quinlan
Hi Christoph, On Tue, Jul 28, 2020 at 8:33 AM Christoph Hellwig wrote: > > A few tiny nitpicks: > > The subject should have the dma-mapping prefix, this doesn't > really touch the device core. > > > - rc = of_dma_get_range(np, &dma_addr, &paddr, &size); > > + rc = of_dma_get_range(np, &ma

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-28 Thread Jim Quinlan
On Tue, Jul 28, 2020 at 11:05 AM Rob Herring wrote: > > On Fri, Jul 24, 2020 at 2:45 PM Jim Quinlan > wrote: > > > > The new field 'dma_range_map' in struct device is used to facilitate the > > use of single or multiple offsets between mapping regions of cpu addrs and > > dma addrs. It subsumes

Re: [PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-28 Thread Zack Rusin
> On Jul 27, 2020, at 11:42 PM, Dave Airlie wrote: > > From: Dave Airlie > > Just drop the argument from this. > > This does ask the question if this is the function vmwgfx > should be using or should it be doing an evict all like > the other drivers. Yea, it really should. This code is real

Re: [PATCH] drm/ttm: drop unusued function declaration

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 17:49, Christian König wrote: > > Am 28.07.20 um 06:51 schrieb Dave Airlie: > > From: Dave Airlie > > > > This was removed in > > f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove > > TTM_MEMTYPE_FLAG_CMA > > > > but the the declaration was left dangling. > > > > Si

Re: [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 17:49, Christian König wrote: > > Am 28.07.20 um 06:17 schrieb Dave Airlie: > > From: Dave Airlie > > > > This is confusing, and from my reading of all the drivers only > > nouveau got this right. > > > > Just make the API act under driver control of it's own allocation > >

Re: [PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-28 Thread Hyun Kwon
Hello, On Tue, Jul 28, 2020 at 03:35:43PM -0700, Laurent Pinchart wrote: > On Wed, Jul 29, 2020 at 12:02:05AM +0200, dan...@ffwll.ch wrote: > > Hi Hyun Kwon, > > > > Are you all sorted with drm-misc commit rights so you can push the 3 > > (maybe there's more) xlnx fixup patches to drm-misc-next-fi

Re: [PATCH 1/2] drm/sun4i: backend: Support alpha property on lowest plane

2020-07-28 Thread kernel test robot
Hi Maxime, I love your patch! Yet something to improve: [auto build test ERROR on sunxi/sunxi/for-next] [also build test ERROR on soc/for-next xlnx/master linus/master v5.8-rc7 next-20200728] [cannot apply to mripard/sunxi/for-next] [If your patch is applied to the wrong git tree, kindly drop

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #106 from Duncan (1i5t5.dun...@cox.net) --- (In reply to Duncan from comment #101) > (In reply to Nicholas Kazlauskas from comment #95) > > Created attachment 290583 [details] > > 0001-drm-amd-display-Force-add-all-CRTCs-to-state-when-

Re: [Nouveau] [PATCH v2] drm/nouveau: Accept 'legacy' format modifiers

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 04:51, James Jones wrote: > > On 7/23/20 9:06 PM, Ben Skeggs wrote: > > On Sat, 18 Jul 2020 at 13:34, James Jones wrote: > >> > >> Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK() > >> family of modifiers to handle broken userspace > >> Xorg modesetting and Mesa drivers. Exis

Re: [Nouveau] [PATCH v2] drm/nouveau: Accept 'legacy' format modifiers

2020-07-28 Thread Ben Skeggs
On Wed, 29 Jul 2020 at 12:48, Dave Airlie wrote: > > On Tue, 28 Jul 2020 at 04:51, James Jones wrote: > > > > On 7/23/20 9:06 PM, Ben Skeggs wrote: > > > On Sat, 18 Jul 2020 at 13:34, James Jones wrote: > > >> > > >> Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK() > > >> family of modifiers to ha

[git pull] drm fixes for 5.8-rc8

2020-07-28 Thread Dave Airlie
Hi Linus, I'm sending this out a bit early, just to give you a chance to reject it or help decide on an rc8. The nouveau fixes missed the last pull by a few hours, and we had a few arm driver/panel/bridge fixes come in. This is possibly a bit more than I'm comfortable sending at this stage, but I

Re: PROBLEM: 5.8-rc7 no video output with nouveau on NV36 (regression)

2020-07-28 Thread Dave Airlie
On Wed, 29 Jul 2020 at 15:05, Nick Bowler wrote: > > Hi, > > After installing Linux 5.8-rc7 I seem to get no video output on my > NV36 card once the nouveau module is loaded. The display (connected > to the digital output) simply reports "No Signal". > > I bisected to the following commit, and re

[RFC][PATCH 2/2] dma-heap: Add a system-uncached heap

2020-07-28 Thread John Stultz
This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping the buffer over and over between devices, we

[RFC][PATCH 1/2] dma-heap: Keep track of the heap device struct

2020-07-28 Thread John Stultz
Keep track of the heap device struct. This will be useful for special DMA allocations and actions. Cc: Sumit Semwal Cc: Andrew F. Davis Cc: Benjamin Gaignard Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedeskto

Re: [PATCH] nouveau: use ttm populate mapping functions. (v2)

2020-07-28 Thread Ben Skeggs
On Wed, 29 Jul 2020 at 06:33, Ruhl, Michael J wrote: > >-Original Message- > >From: Ben Skeggs > >Sent: Tuesday, July 28, 2020 4:16 PM > >To: Ruhl, Michael J > >Cc: Dave Airlie ; dri-devel@lists.freedesktop.org; > >bske...@redhat.com > >Subject: Re: [PATCH] nouveau: use ttm populate map

[PATCH] drm/dp_mst: Add ddc i2c device links for DP MST connectors

2020-07-28 Thread Sam McNally
As of commit d8bd15b37d32 ("drm/dp_mst: Fix the DDC I2C device registration of an MST port"), DP MST DDC I2C devices are consistently parented to the underlying DRM device, making it challenging to associate the ddc i2c device with its connector from userspace. Given the need for further refactori

Re: [drm/ttm] Memory corruption problem when ttm_tt_init() fails.

2020-07-28 Thread Dave Airlie
On Wed, 15 Jul 2020 at 17:00, Tetsuo Handa wrote: > > On 2020/07/14 18:13, Gu Jinxiang wrote: > > I've encountered [BUG: unable to handle kernel NULL pointer dereference at] > > which has call stack like your pattern2. > > And before this happended, I got a lot of memory allocation failure > > w

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-28 Thread Dave Airlie
On Fri, 24 Jul 2020 at 16:43, Thomas Zimmermann wrote: > > > > Am 23.07.20 um 17:17 schrieb Christian König: > > Instead of repeating that in each driver. > > > > Signed-off-by: Christian König > > Reviewed-by: Thomas Zimmermann I'm not sure what happened but the patchwork copies of this series

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-28 Thread Dave Airlie
On Wed, 29 Jul 2020 at 16:21, Dave Airlie wrote: > > On Fri, 24 Jul 2020 at 16:43, Thomas Zimmermann wrote: > > > > > > > > Am 23.07.20 um 17:17 schrieb Christian König: > > > Instead of repeating that in each driver. > > > > > > Signed-off-by: Christian König > > > > Reviewed-by: Thomas Zimmerm

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #107 from Paul Menzel (pmenzel+bugzilla.kernel@molgen.mpg.de) --- Everyone seeing this, it’d be great, if you tested [PATCH] drm/amd/display: Clear dm_state for fast updates and reported any noticeable performance regression

[PATCH 2/3] dt-bindings: Add DT bindings for Chefree CH101OLHLWH-002

2020-07-28 Thread Marek Vasut
Add DT bindings for Chefree CH101OLHLWH-002 10.1" 1280x800 LCD. This panel is connected via LVDS. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/display/panel/panel-simple.yaml |

[PATCH 1/3] dt-bindings: Add vendor prefix for Chefree

2020-07-28 Thread Marek Vasut
The Chefree Technology Corp. is an LCD panel manufacturer. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --g

Re: linux-next: Tree for Jul 27 (drivers/gpu/drm/xlnx/zynqmp-dpsub)

2020-07-28 Thread Randy Dunlap
On 7/28/20 3:32 PM, Laurent Pinchart wrote: > Hi Randy, > > (adding a few people to the CC list to discuss the proposed solution > below) > > Thanks for the report. > > On Mon, Jul 27, 2020 at 05:49:41PM -0700, Randy Dunlap wrote: >> On 7/27/20 6:23 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>

[Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-28 Thread Peilin Ye
Compiler leaves a 4-byte hole near the end of `dev_info`, causing amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace when `size` is greater than 356. In 2015 we tried to fix this issue by doing `= {};` on `dev_info`, which unfortunately does not initialize that 4-byte hole.

Re: [PATCH v5 07/16] pwm: crc: Fix period / duty_cycle times being off by a factor of 256

2020-07-28 Thread Andy Shevchenko
On Fri, Jul 17, 2020 at 03:37:44PM +0200, Hans de Goede wrote: > While looking into adding atomic-pwm support to the pwm-crc driver I > noticed something odd, there is a PWM_BASE_CLK define of 6 MHz and > there is a clock-divider which divides this with a value between 1-128, > and there are 256 du

PROBLEM: 5.8-rc7 no video output with nouveau on NV36 (regression)

2020-07-28 Thread Nick Bowler
Hi, After installing Linux 5.8-rc7 I seem to get no video output on my NV36 card once the nouveau module is loaded. The display (connected to the digital output) simply reports "No Signal". I bisected to the following commit, and reverting this commit on top of 5.8-rc7 appears to correct the iss

Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread Paul Cercueil
Le mer. 29 juil. 2020 à 0:00, dan...@ffwll.ch a écrit : On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: Hi Paul. On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > Here are a few cleanups to the ingenic-drm driver. > - some error paths were missing and have be

[PATCH] drm: re-add deleted doc for drm_gem_open_ioctl

2020-07-28 Thread Steve Cohen
Add back the removed documentation for drm_gem_open_ioctl. This patch is submitted in response to [1]. [1] https://lore.kernel.org/linux-arm-msm/20200728085244.GY6419@phenom.ffwll.local/ Signed-off-by: Steve Cohen --- drivers/gpu/drm/drm_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH] vt: Handle recursion in vc_do_resize().

2020-07-28 Thread Tetsuo Handa
syzbot is reporting OOB read bug in vc_do_resize() [1] caused by memcpy() based on outdated old_{rows,row_size} values, for resize_screen() can recurse into vc_do_resize() which changes vc->vc_{cols,rows} that outdates old_{rows,row_size} values which were read before calling resize_screen(). Mini

Re: PROBLEM: 5.8-rc7 no video output with nouveau on NV36 (regression)

2020-07-28 Thread Nick Bowler
On 2020-07-29, Dave Airlie wrote: > On Wed, 29 Jul 2020 at 15:05, Nick Bowler wrote: >> >> Hi, >> >> After installing Linux 5.8-rc7 I seem to get no video output on my >> NV36 card once the nouveau module is loaded. The display (connected >> to the digital output) simply reports "No Signal". >>

[PATCH] drm/vkms: Fix soft lockup.

2020-07-28 Thread Xu Qiang
A soft deadlock occurs when call hrtimer_cancel in softirq context: a) The main frequency of the machine is very slow b) output->period_ns is very small, even only 1 ns The problem can be solved in the following way: Setting a hrtimer exit flag in the vkms_disable_vblank function

[PATCH 3/3] drm/panel: simple: Add Chefree CH101OLHLWH-002 panel

2020-07-28 Thread Marek Vasut
Add support for the Chefree CH101OLHLWH-002 10.1" (1280x800) color TFT LCD panel, connected over LVDS. Timings are taken from the datasheet version P0.5. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- drivers/

<    1   2