Re: [PATCH] drm/ttm: fix deref of bo->ttm without holding the lock v2

I take that as an reviewed-by :) Thanks, Christian. Am 07.06.21 um 16:14 schrieb Pan, Xinhui: [AMD Official Use Only] Looks good to me. *From:* Christian König *Sent:* Monday, June 7, 2021 8:52:21 PM *To:*

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > > [Adding VC4 folks -- please see the KASAN splat below!] > > > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > > -next) is causing vc4 to hang

Re: [PATCH] RDMA/umem: fix missing automated rename

Reviewed-by: Alex Deucher On Mon, Jun 7, 2021 at 7:01 AM Christian König wrote: > > Ping. Can anybody give me a quick rb or ack-by? > > The driver currently doesn't compile without this on the drm-misc-next > branch. > > Thanks, > Christian. > > Am 07.06.21 um 09:06 schrieb Christian König: > >

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

On Mon, Jun 07, 2021 at 02:39:54PM +0100, Will Deacon wrote: > [Adding VC4 folks -- please see the KASAN splat below!] > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > -next) is causing vc4 to hang on Rpi3b due to a probable driver bug. > > Will > > On Mon, Jun

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

Thomas any comments on this? Is the purpose of this now clear enough? Thanks, Christian. Am 01.06.21 um 14:25 schrieb Christian König: From: Lang Yu Sometimes drivers need to use bounce buffers to evict BOs. While those reside in some domain they are not necessarily suitable for CS. Add a

Re: [PATCH v2] drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device

On Mon, Jun 07, 2021 at 10:58:36AM +0200, Ondrej Jirman wrote: > From: Saravana Kannan > > On sunxi boards that use HDMI output, HDMI device probe keeps being > avoided indefinitely with these repeated messages in dmesg: > > platform 1ee.hdmi: probe deferral - supplier 1ef.hdmi-phy >

Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown()

Am 07.06.21 um 14:27 schrieb Tiezhu Yang: radeon_suspend_kms() puts the hw in the suspend state (all asics), it should always call radeon_suspend_kms() in radeon_pci_shutdown(), this is a normal cleanup process to avoid more operations on radeon, just remove #ifdef CONFIG_PPC64 and the related

Re: [PATCH] drm/ttm: fix deref of bo->ttm without holding the lock v2

[AMD Official Use Only] Looks good to me. From: Christian König Sent: Monday, June 7, 2021 8:52:21 PM To: dri-devel@lists.freedesktop.org ; Pan, Xinhui ; Das, Nirmoy ; Huang, Ray Cc: Thomas Hellström Subject: Re: [PATCH] drm/ttm: fix deref of bo->ttm without

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

On 6/7/2021 3:01 PM, Christian König wrote: Hi Nirmoy, can you give that patch set a testing round and an review? Sure! I will get back asap. The memory stress test with low VRAM on APUs should be sufficient and you should have that setup still around. Thanks in advance, Christian.

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > > [Adding VC4 folks -- please see the KASAN splat below!] > > > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > > -next) is causing vc4 to hang

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

On Mon, Jun 7, 2021 at 5:17 PM Maxime Ripard wrote: > On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > On Mon, Jun 07, 2021 at 02:08:59PM +0100, Mark Rutland wrote: > > > > On Mon, Jun 07, 2021 at 01:01:18PM +0100, Mark

[PATCH][next] drm/amd/display: Fix two spelling mistakes, clean wide lines

From: Colin Ian King There are two spelling mistakes in dml_print messages, fix these and clear up checkpatch warning on overly wide line length. Signed-off-by: Colin Ian King --- .../drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

Sure. LGTM, Reviewed-by: Thomas Hellström On 6/7/21 2:36 PM, Christian König wrote: Thomas any comments on this? Is the purpose of this now clear enough? Thanks, Christian. Am 01.06.21 um 14:25 schrieb Christian König: From: Lang Yu Sometimes drivers need to use bounce buffers to evict

Re: [PATCH] drm/ttm: fix deref of bo->ttm without holding the lock v2

Am 28.05.21 um 15:06 schrieb Thomas Hellström: On 5/28/21 3:00 PM, Christian König wrote: We need to grab the resv lock first before doing that check. v2 (chk): simplify the change for -fixes Signed-off-by: Christian König Signed-off-by: Thomas Hellström Hmm, OK, but this doesn't fix

[PATCH] drm/msm: cleanup coding style a bit

cleanup coding style a bit Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c index 82bebb40234d..87e834850e44 100644 ---

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

[AMD Official Use Only] Thanks，please let Nirmoy do it. Regards， Lang 获取 Outlook for iOS 发件人: Christian König 发送时间: Monday, June 7, 2021 8:41:49 PM 收件人: Thomas Hellström (Intel) ; Yu, Lang 抄送: dri-devel@lists.freedesktop.org 主题: Re:

[PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a reference to the underlaying page on

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > [Adding VC4 folks -- please see the KASAN splat below!] > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > -next) is causing vc4 to hang on Rpi3b due to a probable driver bug. The great news for the patch that

Re: [PATCH 0/7] libdrm tests for hot-unplug fe goature

Hey, MR created at https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172, please help review. Andrey On 2021-06-03 10:26 p.m., Alex Deucher wrote: Code review happens on gitlab now for libdrm. Alex On Thu, Jun 3, 2021 at 6:02 PM Grodzovsky, Andrey wrote: Is libdrm on gitlab ? I

Re: handle exclusive fence similar to shared ones

On Mon, Jun 07, 2021 at 11:59:11AM +0200, Christian König wrote: > Am 07.06.21 um 10:58 schrieb Daniel Vetter: > > Hi Christian, > > > > So unfortunately I got distracted with some i915 bugs and fun last > > week completely, so didn't get around to it. > > > > On Sun, Jun 6, 2021 at 12:03 PM

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

Hi Nirmoy, can you give that patch set a testing round and an review? The memory stress test with low VRAM on APUs should be sufficient and you should have that setup still around. Thanks in advance, Christian. Am 07.06.21 um 14:58 schrieb Yu, Lang: [AMD Official Use Only] Thanks，please

Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown()

On Mon, Jun 7, 2021 at 8:30 AM Christian König wrote: > > Am 07.06.21 um 14:27 schrieb Tiezhu Yang: > > radeon_suspend_kms() puts the hw in the suspend state (all asics), > > it should always call radeon_suspend_kms() in radeon_pci_shutdown(), > > this is a normal cleanup process to avoid more

Re: [PATCH] drm/i915/display: remove duplicated argument

On Sat, Jun 05, 2021 at 11:22:07AM +0800, Wan Jiabing wrote: > Fix the following coccicheck warning: > > ./drivers/gpu/drm/i915/display/intel_display_power.c:3081:1-28: > duplicated argument to & or | > > This commit fixes duplicate argument. It might be a typo. > But what I can do is to remove

Re: [PATCH] drm/amdkfd: remove duplicate include of kfd_svm.h

Am 2021-06-04 um 10:54 p.m. schrieb Wan Jiabing: > kfd_svm.h is included duplicately in commit 42de677f7 > ("drm/amdkfd: register svm range"). > > After checking possible related header files, > remove the former one to make the code format more reasonable. > > Signed-off-by: Wan Jiabing

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

[Adding VC4 folks -- please see the KASAN splat below!] Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in -next) is causing vc4 to hang on Rpi3b due to a probable driver bug. Will On Mon, Jun 07, 2021 at 02:08:59PM +0100, Mark Rutland wrote: > On Mon, Jun 07, 2021 at

[PATCH] drm/malidp: convert sysfs snprintf to sysfs_emit

From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm/arm/malidp_drv.c:657:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang --- drivers/gpu/drm/arm/malidp_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v6 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

On Thu, 2021-05-27 at 15:35 +0200, Thomas Zimmermann wrote: > Hi > > if no further comments come in, this can be moved in a few days. > Since > you'll be the maintainer, you should request commit access to the > drm-misc repository. See > >   >

[PATCH AUTOSEL 5.10 32/39] drm/amdgpu: refine amdgpu_fru_get_product_info

From: Jiansong Chen [ Upstream commit 5cfc912582e13b05d71fb7acc4ec69ddfa9af320 ] 1. eliminate potential array index out of bounds. 2. return meaningful value for failure. Signed-off-by: Jiansong Chen Reviewed-by: Jack Gui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.10 34/39] drm/amd/display: Fix potential memory leak in DMUB hw_init

From: Roman Li [ Upstream commit c5699e2d863f58221044efdc3fa712dd32d55cde ] [Why] On resume we perform DMUB hw_init which allocates memory: dm_resume->dm_dmub_hw_init->dc_dmub_srv_create->kzalloc That results in memory leak in suspend/resume scenarios. [How] Allocate memory for the DC wrapper

[PATCH AUTOSEL 5.10 33/39] drm/amd/display: Fix overlay validation by considering cursors

From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After

[PATCH AUTOSEL 5.10 10/39] drm/tegra: sor: Do not leak runtime PM reference

From: "Pavel Machek (CIP)" [ Upstream commit 73a395c46704304b96bc5e2ee19be31124025c0c ] It's theoretically possible for the runtime PM reference to leak if the code fails anywhere between the pm_runtime_resume_and_get() and pm_runtime_put() calls, so make sure to release the runtime PM

[PATCH AUTOSEL 5.10 11/39] gpu: host1x: Split up client initalization and registration

From: Thierry Reding [ Upstream commit 0cfe5a6e758fb20be8ad3e8f10cb087cc8033eeb ] In some cases we may need to initialize the host1x client first before registering it. This commit adds a new helper that will do nothing but the initialization of the data structure. At the same time, the

[PATCH AUTOSEL 5.10 12/39] drm/tegra: sor: Fully initialize SOR before registration

From: Thierry Reding [ Upstream commit 5dea42759bcef74b0802ea64b904409bc37f9045 ] Before registering the SOR host1x client, make sure that it is fully initialized. This avoids a potential race condition between the SOR's probe and the host1x device initialization in cases where the SOR is the

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

On 6/7/21 3:58 PM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a

[PATCH AUTOSEL 5.10 31/39] drm/amd/display: Allow bandwidth validation for 0 streams.

From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non

[PATCH AUTOSEL 5.10 35/39] drm/amd/amdgpu:save psp ring wptr to avoid attack

From: Victor Zhao [ Upstream commit 2370eba9f552eaae3d8aa1f70b8e9eec5c560f9e ] [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

Am 07.06.21 um 18:13 schrieb Thomas Hellström (Intel): On 6/7/21 3:58 PM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for

Re: [PATCH] drm/amdgpu: Fix a a typo in a comment

Applied. Thanks! Alex On Mon, Jun 7, 2021 at 6:46 AM Christian König wrote: > > Am 05.06.21 um 11:06 schrieb Christophe JAILLET: > > s/than/then/ > > > > Signed-off-by: Christophe JAILLET > > Acked-by: Christian König > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- > > 1 file

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

On Thu, May 27, 2021 at 04:11:50PM +0100, Tvrtko Ursulin wrote: > > On 27/05/2021 15:35, Matthew Brost wrote: > > On Thu, May 27, 2021 at 11:02:24AM +0100, Tvrtko Ursulin wrote: > > > > > > On 26/05/2021 19:10, Matthew Brost wrote: > > > > > > [snip] > > > > > > > > > > > +static int

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */   static int ttm_bo_mem_force_space(struct

Re: [Intel-gfx] [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation

On 07.06.2021 19:45, Matthew Brost wrote: > On Mon, Jun 07, 2021 at 11:03:51AM -0700, Matthew Brost wrote: >> From: Michal Wajdeczko >> >> GuC ABI documentation is now ready to be included in i915.rst >> >> Signed-off-by: Michal Wajdeczko >> Signed-off-by: Matthew Brost >> Cc: Piotr

[PATCH v2] drm/msm/dsi: add continuous clock support for 7nm PHY

Unlike previous generations, 7nm PHYs are required to collaborate with the host for conitnuos clock mode. Add changes neccessary to enable continuous clock mode in the 7nm DSI PHYs. Signed-off-by: Dmitry Baryshkov --- Changes since v1: - Remove the need for a separate

[PATCH AUTOSEL 5.4 24/29] drm/amd/display: Allow bandwidth validation for 0 streams.

From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non

[PATCH AUTOSEL 5.4 25/29] drm/amd/display: Fix overlay validation by considering cursors

From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After

[PATCH AUTOSEL 5.4 09/29] drm/tegra: sor: Do not leak runtime PM reference

From: "Pavel Machek (CIP)" [ Upstream commit 73a395c46704304b96bc5e2ee19be31124025c0c ] It's theoretically possible for the runtime PM reference to leak if the code fails anywhere between the pm_runtime_resume_and_get() and pm_runtime_put() calls, so make sure to release the runtime PM

Re: handle exclusive fence similar to shared ones

Am 07.06.21 um 17:09 schrieb Daniel Vetter: On Mon, Jun 07, 2021 at 11:59:11AM +0200, Christian König wrote: Am 07.06.21 um 10:58 schrieb Daniel Vetter: Hi Christian, So unfortunately I got distracted with some i915 bugs and fun last week completely, so didn't get around to it. On Sun,

RE: [PATCH 01/21] drm: Add Enhanced Gamma and color lut range attributes

> -Original Message- > From: Harry Wentland > Sent: Friday, June 4, 2021 8:53 PM > To: Shankar, Uma ; Pekka Paalanen > > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Modem, > Bhanuprakash > Subject: Re: [PATCH 01/21] drm: Add Enhanced Gamma and color lut range

Re: [PATCH] drm/ttm: fix access to uninitialized variable.

On 6/7/21 7:11 PM, Christian König wrote: The resource is not allocated yet, so no chance that this will work. Use the placement instead. Signed-off-by: Christian König Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2] drm/rockchip: remove of_match_ptr()

Kernel test robot throws below warning when CONFIG_OF is not set. >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:457:34: warning: unused variable 'rockchip_dp_dt_ids' [-Wunused-const-variable] static const struct of_device_id rockchip_dp_dt_ids[] = { Fixed it by removing of_match_ptr().

Re: [PATCH] drm/ttm: fix access to uninitialized variable.

Reviewed-by:  Nirmoy Das On 6/7/2021 7:11 PM, Christian König wrote: The resource is not allocated yet, so no chance that this will work. Use the placement instead. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH 13/13] drm/i915/guc: Update firmware to v62.0.0

On Mon, Jun 07, 2021 at 11:03:55AM -0700, Matthew Brost wrote: > From: John Harrison > > Signed-off-by: John Harrison > Signed-off-by: Michal Wajdeczko > Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 26

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

https://bugzilla.kernel.org/show_bug.cgi?id=213145 --- Comment #6 from Tomas Gayoso (tgay...@gmail.com) --- I upgraded my setep to mesa-21.1.2, but I can still trigger the bug at will on fresh boot by opening a single xterm on i3wm and resizing it while running any fast scrolling character

Re: [Intel-gfx] [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation

On Mon, Jun 07, 2021 at 09:38:58PM +0200, Michal Wajdeczko wrote: > > > On 07.06.2021 19:45, Matthew Brost wrote: > > On Mon, Jun 07, 2021 at 11:03:51AM -0700, Matthew Brost wrote: > >> From: Michal Wajdeczko > >> > >> GuC ABI documentation is now ready to be included in i915.rst > >> > >>

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, */ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, const struct ttm_place *place, -

Re: [PATCH][next] drm/amd/display: Fix two spelling mistakes, clean wide lines

Applied. Thanks! Alex On Mon, Jun 7, 2021 at 7:58 AM Colin King wrote: > > From: Colin Ian King > > There are two spelling mistakes in dml_print messages, fix these and > clear up checkpatch warning on overly wide line length. > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH 10/13] drm/i915/guc: Kill guc_clients.ct_pool

On Mon, Jun 07, 2021 at 11:03:52AM -0700, Matthew Brost wrote: > From: Michal Wajdeczko > > CTB pool is now maintained internally by the GuC as part of its > "private data". No need to allocate separate buffer and pass it > to GuC as yet another ADS. > > Signed-off-by: Matthew Brost #v4 >

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

Am 07.06.21 um 18:40 schrieb Thomas Hellström (Intel): On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */   static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,     const

[PATCH V6 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings

Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. Reviewed-by: Linus Walleij Reviewed-by: Rob Herring Signed-off-by: Marek Vasut Cc: Douglas Anderson Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Rob Herring Cc: Sam Ravnborg Cc: Stephen Boyd Cc:

[PATCH V6 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but easy to add. The driver operates the chip via I2C bus. Currently the LVDS clock

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */  

[PATCH] drm/ttm: fix warning after moving resource to ghost obj

After we moved the resource to the ghost the bo->resource pointer needs to be resetted since the owner of the resource is now the ghost. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c

RE: [PATCH 0/9] Enhance pipe color support for multi segmented luts

> -Original Message- > From: Harry Wentland > Sent: Saturday, June 5, 2021 12:21 AM > To: Shankar, Uma ; intel-...@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: Modem, Bhanuprakash ; Cyr, Aric > > Subject: Re: [PATCH 0/9] Enhance pipe color support for multi

Re: [PATCH] drm/ttm: fix warning after moving resource to ghost obj

On 6/7/21 7:57 PM, Christian König wrote: After we moved the resource to the ghost the bo->resource pointer needs to be resetted since the owner of the resource is now the ghost. s/resetted/reset/ Signed-off-by: Christian König Reviewed-by: Thomas Hellström

Re: [PATCH 5/7] dma-buf: rename and cleanup dma_resv_get_list

On Sun, Jun 6, 2021 at 3:53 AM Christian König wrote: > > Am 02.06.21 um 22:22 schrieb Jason Ekstrand: > > On Wed, Jun 2, 2021 at 6:17 AM Christian König > > wrote: > >> When the comment needs to state explicitly that this is doesn't get a > >> reference > >> to the object then the function is

Re: [PATCH v2] drm/panel: db7430: Add driver for Samsung DB7430

Hi, On Fri, Jun 4, 2021 at 4:19 PM Linus Walleij wrote: > > On Tue, Jun 1, 2021 at 11:31 PM Doug Anderson wrote: > > > Still hoping that this can work atop DBI so we can avoid the raw SPI > > writes. You said you're trying for it for v3 so I'm looking forward to > > checking it out there. > >

[PATCH v9 07/11] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev

On its own, this change looks a little strange and doesn't do too much useful. To understand why we're doing this we need to look forward to future patches where we're going to probe our panel using the new DP AUX bus. See the patch ("drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus").

[PATCH v9 10/11] drm/bridge: ti-sn65dsi86: Improve probe errors with dev_err_probe()

As I was testing to make sure that the DEFER path worked well with my patch series, I got tired of seeing this scary message in my logs just because the panel needed to defer: [drm:ti_sn_bridge_probe] *ERROR* could not find any panel node Let's use dev_err_probe() which nicely quiets this error

[PATCH v9 09/11] drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC

This is really just a revert of commit 58074b08c04a ("drm/bridge: ti-sn65dsi86: Read EDID blob over DDC"), resolving conflicts. The old code failed to read the EDID properly in a very important case: before the bridge's pre_enable() was called. The way things need to work: 1. Read the EDID. 2.

[PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip

Putting the panel under the bridge chip (under the aux-bus node) allows the panel driver to get access to the DP AUX bus, enabling all sorts of fabulous new features. While we're at this, get rid of a level of hierarchy for the panel node. It doesn't need "ports / port" and can just have a "port"

Re: [PATCH v8 08/11] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev

Hi, On Sat, Jun 5, 2021 at 9:40 PM Bjorn Andersson wrote: > > > + /* > > + * We couldn't do this pre-probe because it would confuse pinctrl. > > + * It would have tried to grab the same pins that the main device had. > > + * Set it now so that we can put the proper (sub)

Re: [PATCH v8 07/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC

Hi, On Fri, Jun 4, 2021 at 9:10 AM wrote: > > Hi Doug, > > > panel->no_hpd = of_property_read_bool(dev->of_node, "no-hpd"); > > if (!panel->no_hpd) { > > @@ -708,6 +712,8 @@ static int panel_simple_probe(struct device *dev, > > const struct panel_desc *desc) > > > > if

Re: [PATCH] drm/amd/display: remove no need variable

On Sat, Jun 5, 2021 at 8:31 AM Bernard Zhao wrote: > > remove no need variable, just return the DC_OK > > Signed-off-by: Bernard Zhao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

RE: [PATCH 02/21] drm: Add Plane Degamma Mode property

> -Original Message- > From: Harry Wentland > Sent: Friday, June 4, 2021 11:54 PM > To: Shankar, Uma ; intel-...@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: Modem, Bhanuprakash ; Cyr, Aric > > Subject: Re: [PATCH 02/21] drm: Add Plane Degamma Mode property > >

[PATCH 02/13] drm/i915/guc: Update MMIO based communication

From: Michal Wajdeczko The MMIO based Host-to-GuC communication protocol has been updated to use unified HXG messages. Update our intel_guc_send_mmio() function by correctly handle BUSY, RETRY and FAILURE replies. Also update our documentation. GuC: 55.0.0 Signed-off-by: Matthew Brost

[PATCH 04/13] drm/i915/guc: Support per context scheduling policies

From: John Harrison GuC firmware v53.0.0 introduced per context scheduling policies. This includes changes to some of the ADS structures which are required to load the firmware even if not using GuC submission. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew

[PATCH 07/13] drm/i915/guc: New definition of the CTB registration action

From: Michal Wajdeczko Definition of the CTB registration action has changed. Add some ABI documentation and implement required changes. Signed-off-by: Michal Wajdeczko Signed-off-by: Matthew Brost Cc: Piotr Piórkowski #4 --- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 107

RE: [PATCH 0/9] Enhance pipe color support for multi segmented luts

> -Original Message- > From: dri-devel On Behalf Of Pekka > Paalanen > Sent: Monday, June 7, 2021 1:00 PM > To: Harry Wentland > Cc: intel-...@lists.freedesktop.org; Shankar, Uma ; > Sebastian Wick ; dri-devel@lists.freedesktop.org; > Modem, Bhanuprakash > Subject: Re: [PATCH 0/9]

Re: [PATCH 12/13] drm/i915/guc: Unified GuC log

On Mon, Jun 07, 2021 at 11:03:54AM -0700, Matthew Brost wrote: > From: John Harrison > > GuC v57 unified the 'DPC' and 'ISR' buffers into a single buffer with > the option for it to be larger. > > Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost > Signed-off-by: John Harrison > Cc:

[PATCH 2/6] drm/i915/ttm: add i915_sg_from_buddy_resource

We need to be able to build an sg table from our list of buddy blocks, so that we can later plug this into our ttm backend, and replace our use of the range manager. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/i915_scatterlist.c | 80 +

[PATCH 1/6] drm/i915/ttm: add ttm_buddy_man

Add back our standalone i915_buddy allocator and integrate it into a ttm_resource_manager. This will plug into our ttm backend for managing device local-memory in the next couple of patches. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/Makefile |

[PATCH 6/6] drm/i915/ttm: restore min_page_size behaviour

We now have bo->page_alignment which perfectly describes what we need if we have min page size restrictions for lmem. We can also drop the flag here, since this is the default behaviour for all objects. Signed-off-by: Matthew Auld Cc: Thomas Hellström ---

[PATCH 3/6] drm/i915/ttm: Calculate the object placement at get_pages time

From: Thomas Hellström Instead of relying on a static placement, calculate at get_pages() time. This should work for LMEM regions and system for now. For stolen we need to take preallocated range into account. That well be added later. Signed-off-by: Thomas Hellström ---

[PATCH 4/6] drm/i915/ttm: pass along the I915_BO_ALLOC_CONTIGUOUS

Currently we just ignore the I915_BO_ALLOC_CONTIGUOUS flag, which is fine since everything is already contiguous with the ttm range manager. However in the next patch we want to switch over to the ttm buddy manager, where allocations are by default not contiguous. Signed-off-by: Matthew Auld Cc:

[PATCH 5/6] drm/i915/ttm: switch over to ttm_buddy_man

Move back to the buddy allocator for managing device local memory, and restore the lost mock selftests. Keep around the range manager related bits, since we likely need this for managing stolen at some point. For stolen we also don't need to reserve anything so no need to support a generic reserve

[PATCH 0/6] Add back the buddy allocator

Needs to be applied on top of: https://patchwork.freedesktop.org/series/90681/ Matthew Auld (5): drm/i915/ttm: add ttm_buddy_man drm/i915/ttm: add i915_sg_from_buddy_resource drm/i915/ttm: pass along the I915_BO_ALLOC_CONTIGUOUS drm/i915/ttm: switch over to ttm_buddy_man drm/i915/ttm:

[PATCH] Fix i.MX IPU-v3 offset calculations for (semi)planar U/V formats

Video captured in 1400x1050 resolution (bytesperline aka stride = 1408 bytes) is invalid. Fix it. Signed-off-by: Krzysztof Halasa --- a/drivers/gpu/ipu-v3/ipu-cpmem.c +++ b/drivers/gpu/ipu-v3/ipu-cpmem.c @@ -585,21 +585,21 @@ static const struct ipu_rgb def_bgra_16 = { .bits_per_pixel =

[PATCH] drm/rockchip: remove of_match_ptr() from vop_driver_dt_match

kernel test robot throws warning when CONFIG_OF not set. >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c:1038:34: warning: unused variable 'vop_driver_dt_match' [-Wunused-const-variable] static const struct of_device_id vop_driver_dt_match[] = { Fixed it by removing of_match_ptr().

[PATCH v9 04/11] drm: Introduce the DP AUX bus

Historically "simple" eDP panels have been handled by panel-simple which is a basic platform_device. In the device tree, the panel node was at the top level and not connected to anything else. Let's change it so that, instead, panels can be represented as being children of the "DP AUX bus".

[PATCH v9 06/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC

If panel-simple is instantiated as a DP AUX bus endpoint then we have access to the DP AUX bus. Let's stash it in the panel-simple structure, leaving it NULL for the cases where the panel is instantiated in other ways. If we happen to have access to the DP AUX bus and we weren't provided the

[PATCH v9 08/11] drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus

We want to provide our panel with access to the DP AUX channel. The way to do this is to let our panel be a child of ours using the fancy new DP AUX bus support. Signed-off-by: Douglas Anderson Acked-by: Linus Walleij Reviewed-by: Lyude Paul --- Changes in v9: - Rebased atop v9 ("Promote the

[PATCH v9 05/11] drm/panel: panel-simple: Allow panel-simple be a DP AUX endpoint device

The panel-simple driver can already have devices instantiated as platform devices or MIPI DSI devices. Let's add a 3rd way to instantiate it: as DP AUX endpoint devices. At the moment there is no benefit to instantiating it in this way, but: - In the next patch we'll give it access to the DDC

[PATCH v9 02/11] dt-bindings: drm: Introduce the DP AUX bus

We want to be able to list an eDP panel as a child of an eDP controller node to represent the fact that the panel is connected to the controller's DP AUX bus. Though the panel and the controller are connected in several ways, the DP AUX bus is the primary control interface between the two and thus

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */   static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,     const struct

[PATCH v9 03/11] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child

The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about how using the DP AUX bus is better than learning how to slice bread. Let's add it to the ti-sn65dsi86 bindings. Signed-off-by: Douglas Anderson Reviewed-by: Rob Herring --- Changes in v9: - Use an absolute path to refer to

[PATCH v9 00/11] drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus

The primary goal of this series is to try to properly fix EDID reading for eDP panels using the ti-sn65dsi86 bridge. Previously we had a patch that added EDID reading but it turned out not to work at bootup. This caused some extra churn at bootup as we tried (and failed) to read the EDID several

[PATCH v9 01/11] dt-bindings: display: simple: List hpd properties in panel-simple

The HPD (Hot Plug Detect) signal is present in many (probably even "most") eDP panels. For eDP, this signal isn't actually used for detecting hot-plugs of the panel but is more akin to a "panel ready" signal. After you provide power to the panel, panel timing diagrams typically say that you should

Re: [PATCH] drm/amd/display: Fix duplicate included dce110_hw_sequencer.h

Applied. Thanks! Alex On Mon, Jun 7, 2021 at 6:27 AM Jiapeng Chong wrote: > > Clean up the following includecheck warning: > > ./drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c: > dce110_hw_sequencer.h is included more than once. > > No functional change. > > Reported-by: Abaci

Re: [Intel-gfx] [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation

On Mon, Jun 07, 2021 at 11:03:51AM -0700, Matthew Brost wrote: > From: Michal Wajdeczko > > GuC ABI documentation is now ready to be included in i915.rst > > Signed-off-by: Michal Wajdeczko > Signed-off-by: Matthew Brost > Cc: Piotr Piórkowski Michal - I noticed while putting this series

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

Am 07.06.21 um 19:58 schrieb Thomas Hellström (Intel): On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int

Re: [PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

On Wed, Jun 2, 2021 at 3:37 PM Robin Murphy wrote: > > On 2021-06-02 09:02, Souptick Joarder wrote: > > Kernel test robot throws below warning when CONFIG_OF > > is not set. > > > >>> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:457:34: > > warning: unused variable 'rockchip_dp_dt_ids'

  1   2   3   >