Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just trival clean, no functional change.

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

Hi, On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just

[PATCH 0/5] drm/exynos: Convert fbdev to DRM client

Convert exynos' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in exynos is now just another DRM client that runs after the DRM device has been registered. Once all drivers'

[PATCH 2/5] drm/exynos: Remove struct exynos_drm_fbdev

Remove struct exynos_drm_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-)

[PATCH 3/5] drm/exynos: Remove fb_helper from struct exynos_drm_private

The DRM device stores a pointer to the fbdev helper. Remove struct exynos_drm_private.fb_helper, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 15

Re: [PATCH v2] dt-bindings: display: seiko,43wvf1g: Change the maintainer's contact

Hi, On Wed, 29 Mar 2023 17:11:50 -0300, Fabio Estevam wrote: > Marco's NXP email is no longer valid. > > Marco told me offline that he has no interest to be listed as the > maintainer contact for this binding, so add my contact. > > Thanks, Applied to

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

On Thu, Mar 30, 2023 at 08:57:36AM +0200, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in

[PATCH 3/6] drm/omapdrm: Remove bo from struct omap_fbdev

Fbdev's framebuffer stores a pointer to the GEM object. Remove struct omap_fbdev.exynos_gem, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 32 +--- 1 file changed, 19 insertions(+), 13

[PATCH 5/6] drm/omapdrm: Initialize fbdev DRM client

Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 33

Re: [PATCH] drm/scdc-helper: Pimp SCDC debugs

Hi, On Wed, Mar 29, 2023 at 08:14:02PM +0300, Ville Syrjala wrote: > diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c > b/drivers/gpu/drm/display/drm_scdc_helper.c > index c3ad4ab2b456..2b124152384c 100644 > --- a/drivers/gpu/drm/display/drm_scdc_helper.c > +++

Re: [PATCH v7 10/12] drm/bridge: Implement enable_next_first to alter bridge init order

On Wed, Mar 29, 2023 at 10:16 PM Maxime Ripard wrote: > > On Wed, Mar 29, 2023 at 05:28:28PM +0100, Dave Stevenson wrote: > > On Wed, 29 Mar 2023 at 14:19, Jagan Teki wrote: > > > > > > DSI sink devices typically send the MIPI-DCS commands to the DSI host > > > via general MIPI_DSI_DCS read and

[PATCH 2/7] accel/habanalabs: remove completion from abnormal interrupt work name

From: Tomer Tayar Decoder abnormal interrupts are for errors and not for completion, so rename the relevant work and work function to not include 'completion'. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/decoder.c|

[PATCH 3/7] accel/habanalabs: fix events mask of decoder abnormal interrupts

From: Tomer Tayar The decoder IRQ status register may have several set bits upon an abnormal interrupt. Therefore, when setting the events mask, need to check all bits and not using if-else. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay ---

[PATCH 6/7] accel/habanalabs: don't wait for STS_OK after sending COMMS WFE

From: Koby Elbaz Sending COMMS_GOTO_WFE instructs the FW's CPU to halt (WFE state). Once sent, FW's CPU isn't expected to continue communicating with LKD. Therefore, the stage of waiting for COMMS_STS_OK should be skipped or else waiting for COMMS_STS_OK will simply timeout, which will trigger

[PATCH 7/7] accel/habanalabs: fixes for unexpected error interrupt

From: Ofir Bitton Removing redundant asic prop variable as we don't need to expose this to common code. In addition, fix some typos. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/habanalabs.h | 2 --

[PATCH 5/7] accel/habanalabs: sync f/w events interrupt in hard reset

From: Tal Cohen Receiving events from FW, while the device is in hard reset, causes a warning message in Driver log. The message may point to a problem in the Driver or FW. But It also can appear as a result of events that have been sent from FW just before the hard reset. In order to avoid

[PATCH 4/7] accel/habanalabs: fix wrong reset and event flags

From: Ofir Bitton During event handling, driver sets relevant reset and user event notifier flags. Fix few wrong flags settings. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 13 + 1 file changed, 9

[PATCH 1/5] drm/exynos: Remove exynos_gem from struct exynos_drm_fbdev

Fbdev's framebuffer stores a pointer to the GEM object. Remove struct exynos_drm_fbdev.exynos_gem, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 13 - 1 file changed, 4 insertions(+), 9

[PATCH 5/5] drm/exynos: Implement fbdev emulation as in-kernel client

Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH 4/5] drm/exynos: Initialize fbdev DRM client

Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 35

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

On 29/03/2023 16:41, Fabio Estevam wrote: > From: Fabio Estevam > > The Samsung DSIM IP block allows the inversion of the clock and > data lanes. > > Add an optional property called 'lane-polarities' that describes the > polarities of the MIPI DSI clock and data lanes. > > This is property is

Re: [PATCH 1/2] dt-bindings: display: bridge: ldb: Add i.MX6SX support

On 29/03/2023 15:04, Fabio Estevam wrote: > From: Fabio Estevam > > i.MX6SX has a single LVDS port and share a similar LDB_CTRL register > layout with i.MX8MP and i.MX93. > > Signed-off-by: Fabio Estevam > --- > .../devicetree/bindings/display/bridge/fsl,ldb.yaml | 11 +++ > 1 file

[PATCH 2/3] drm/drm_gem.c: remove surplus else after return clause

From: Sui Jingfeng else is not generally useful after return Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_gem.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index a6208e2c089b..364e3733af98 100644 ---

[PATCH 3/3] drm/fbdev-generic: optimize out a redundant assignment clause

From: Sui Jingfeng The assignment already done in drm_client_buffer_vmap(), this patch save a copy. No functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 1/3] dma-buf/dma-buf.c: add a blank line between the two adjoining functions

From: Sui Jingfeng Trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index aa4ea8530cb3..485b022a31fa 100644 ---

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just

Re: [PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

On Wed, Mar 29, 2023 at 9:36 PM Maxime Ripard wrote: > > On Wed, Mar 29, 2023 at 09:08:17PM +0530, Jagan Teki wrote: > > On Wed, Mar 29, 2023 at 8:29 PM Maxime Ripard wrote: > > > > > > Hi, > > > > > > The patch prefix should be drm/sun4i: > > > > I did follow my previous prefix, I will update

[PATCH 1/6] drm/omapdrm: Include

Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index

[PATCH 4/6] drm/omapdrm: Remove fbdev from struct omap_drm_private

The DRM device stores a pointer to the fbdev helper. Remove struct omap_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 6 +++--- drivers/gpu/drm/omapdrm/omap_drv.c | 1 +

[PATCH 6/6] drm/omapdrm: Implement fbdev emulation as in-kernel client

Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH 2/6] drm/omapdrm: Remove fb from struct omap_fbdev

Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct omap_fbdev.fb, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[PATCH 0/6] drm/omapdrm: Convert fbdev to DRM client

Convert omapdrm's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in omapdrm is now just another DRM client that runs after the DRM device has been registered. Once all

[PATCH 3/4] drm/armada: Initialize fbdev DRM client

Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 43

[PATCH 4/4] drm/armada: Implement fbdev emulation as in-kernel client

Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH 0/4] drm/armada: Convert fbdev to DRM client

Convert armada's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other driver's fbdev emulation, fbdev in armada is now just another DRM client that runs after the DRM device has been registered. Once all

Re: [PATCH] drm/i915/hwmon: Use 0 to designate disabled PL1 power limit

On Tue, 28 Mar 2023 16:35:43 -0700, Ashutosh Dixit wrote: > > On ATSM the PL1 limit is disabled at power up. The previous uapi assumed > that the PL1 limit is always enabled and therefore did not have a notion of > a disabled PL1 limit. This results in erroneous PL1 limit values when the > PL1

Re: [PATCH v3 0/7] drm/msm: add support for SM8550

On 29/03/2023 22:13, Dmitry Baryshkov wrote: On 29/03/2023 22:52, Rob Herring wrote: On Tue, Mar 28, 2023 at 5:38 PM Dmitry Baryshkov wrote: On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is

[PATCH 1/7] accel/habanalabs: print raw binning masks in debug level

From: Ofir Bitton There are rare cases of failures when cards are initialized due to wrong values in efuse mappings that are parsed by firmware. To help debug those cases, print (in debug level) the raw binning masks as fetched from the firmware during device initialization. Signed-off-by:

[PATCH 2/4] drm/armada: Hide fbdev support behind config option

Only build armada's fbdev emulation if CONFIG_DRM_FBDEV_EMULATION has been enabled. No functional changes, but allows to build armada without fbdev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/Makefile | 3 ++- drivers/gpu/drm/armada/armada_drm.h | 14 -- 2

Re: [PATCH v2] dt-bindings: display: seiko,43wvf1g: Change the maintainer's contact

On 29/03/2023 22:11, Fabio Estevam wrote: > From: Fabio Estevam > > Marco's NXP email is no longer valid. > > Marco told me offline that he has no interest to be listed as the > maintainer contact for this binding, so add my contact. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH 1/4] drm/armada: Include

Include to get declarations of of_node_put() and of_device_is_available(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/armada/armada_drv.c

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

On 2023/3/30 15:26, Thomas Zimmermann wrote: Hi Am 30.03.23 um 09:17 schrieb Sui Jingfeng: Hi, On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23

Re: [PATCH v9 2/2] drm: add kms driver for loongson display controller

://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230329155033.1303550-3-15330273260%40189.cn patch subject: [PATCH v9 2/2] drm: add kms driver for loongson display controller config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230330

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

On Thu, Mar 30, 2023 at 1:08 PM Krzysztof Kozlowski wrote: > > On 29/03/2023 16:41, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The Samsung DSIM IP block allows the inversion of the clock and > > data lanes. > > > > Add an optional property called 'lane-polarities' that describes the >

Re: [PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

On Thu, Mar 30, 2023 at 12:15:49PM +0530, Jagan Teki wrote: > On Wed, Mar 29, 2023 at 9:36 PM Maxime Ripard wrote: > > > > On Wed, Mar 29, 2023 at 09:08:17PM +0530, Jagan Teki wrote: > > > On Wed, Mar 29, 2023 at 8:29 PM Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > The patch prefix

Re: [PATCH v9 2/2] drm: add kms driver for loongson display controller

: https://lore.kernel.org/r/20230329155033.1303550-3-15330273260%40189.cn patch subject: [PATCH v9 2/2] drm: add kms driver for loongson display controller config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230330/202303301403.lrjtbd5k-...@intel.com/config) compiler: clang

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

Hi Am 30.03.23 um 09:17 schrieb Sui Jingfeng: Hi, On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment

[PATCH 4/6] drm/msm: Remove fbdev from struct msm_drm_private

The DRM device stores a pointer to the fbdev helper. Remove struct msm_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_debugfs.c | 5 ++--- drivers/gpu/drm/msm/msm_drv.c | 4 ++--

[PATCH 5/6] drm/msm: Initialize fbdev DRM client

Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 38

[PATCH 0/6] drm/msm: Convert fbdev to DRM client

Convert msm' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in msm is now just another DRM client that runs after the DRM device has been registered. Once all drivers' fbdev

[PATCH 3/6] drm/msm: Remove struct msm_fbdev

Remove struct msm_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git

[PATCH 2/6] drm/msm: Remove fb from struct msm_fbdev

Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct msm_fbdev.fb, which contains thre same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 32 +--- 1 file changed, 13 insertions(+), 19

[PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH 1/6] drm/msm: Clear aperture ownership outside of fbdev code

Move aperture management out of the fbdev code. It is unrelated and needs to run even if fbdev support has been disabled. Call the helper at the top of msm_drm_init() to take over hardware from other drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_drv.c | 6 ++

[PATCH 7/7] drm/tegra: Implement fbdev emulation as in-kernel client

Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH 4/7] drm/tegra: Remove struct tegra_fbdev

Remove struct tegra_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/drm.h | 10 --- drivers/gpu/drm/tegra/fb.c | 59 ++--- 2 files

[PATCH 5/7] drm/tegra: Hide fbdev support behind config option

Only build tegra's fbdev emulation if CONFIG_DRM_FBDEV_EMULATION has been enabled. As part of this change, move the code into its own source file. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/Makefile | 2 + drivers/gpu/drm/tegra/drm.h| 20 +++

[PATCH 1/7] drm/tegra: Include

Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/output.c | 2 ++ drivers/gpu/drm/tegra/rgb.c| 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c

[PATCH 0/7] drm/tegra: Convert fbdev to DRM client

Convert tegra's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in tegra is now just another DRM client that runs after the DRM device has been registered. Once all drivers'

[PATCH 2/7] drm/tegra: Include

Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index d31c87f48da0..dc2dcb5ca1c8 100644 ---

[PATCH 3/7] drm/tegra: Removed fb from struct tegra_fbdev

Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct tegra_fbdev.fb, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/drm.h | 1 - drivers/gpu/drm/tegra/fb.c | 23 --- 2 files changed,

[PATCH 6/7] drm/tegra: Initialize fbdev DRM client

Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/fbdev.c | 33

[PATCH 2/4] log2: have is_power_of_2() support bigger types than unsigned long

is_power_of_2() does not work properly for e.g. u64 in 32-bit builds. Choose an unsigned long long version if the argument is bigger than unsigned long. Cc: Andrew Morton Cc: Christian König Cc: David Gow Link: https://lore.kernel.org/r/20230329065532.2122295-2-david...@google.com

[PATCH 1/4] log2: add helper __IS_POWER_OF_2()

Add a helper to avoid duplication in the subsequent changes. Cc: Andrew Morton Cc: Christian König Cc: David Gow Signed-off-by: Jani Nikula --- include/linux/log2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/log2.h b/include/linux/log2.h index

[PATCH 3/4] log2: allow use of is_power_of_2() in constant expressions

Even though the static inline functions are __attribute__((const)) you can't use them in constant expressions. Make is_power_of_2() a constant expression if possible. Cc: Andrew Morton Cc: Christian König Cc: David Gow Signed-off-by: Jani Nikula --- include/linux/log2.h | 8 +--- 1 file

[PATCH 0/4] log2: make is_power_of_2() more generic

is_power_of_2() only works for types <= sizeof(unsigned long) and it's also not a constant expression. There are a number of places in kernel where is_power_of_2() is called on u64, which fails on 32-bit builds. Try to remedy that. While at it, make it a constant expression when possible. I admit

[PATCH 4/4] drm/i915/reg: use is_power_of_2() from log2.h

Now that log2.h is_power_of_2() supports constant expressions, use it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg_defs.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg_defs.h b/drivers/gpu/drm/i915/i915_reg_defs.h index

Re: [PATCH 1/2] drm: buddy_allocator: Fix buddy allocator init on 32-bit systems

On Wed, 29 Mar 2023, David Gow wrote: > The drm buddy allocator tests were broken on 32-bit systems, as > rounddown_pow_of_two() takes a long, and the buddy allocator handles > 64-bit sizes even on 32-bit systems. > > This can be reproduced with the drm_buddy_allocator KUnit tests on i386: >

Re: [1/4] drm/armada: Include

Reviewed-by: Sui Jingfeng On 2023/3/30 15:30, Thomas Zimmermann wrote: Include to get declarations of of_node_put() and of_device_is_available(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_drv.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 2/6] drm/omapdrm: Remove fb from struct omap_fbdev

On 30/03/2023 11:32, Thomas Zimmermann wrote: Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct omap_fbdev.fb, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 11 ++- 1 file

Re: [PATCH 5/6] drm/omapdrm: Initialize fbdev DRM client

On 30/03/2023 11:32, Thomas Zimmermann wrote: Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. I don't see this doing any cleanups. I think this

Re: [v2,29/50] drm/msm/dpu: split MSM8998 catalog entry to the separate file

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 189 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 191 +- > 2 files changed, 191 insertions(+), 189 deletions(-) >

Re: [v2,33/50] drm/msm/dpu: duplicate sm8150 catalog entries

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sm8150 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h| 134

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

On 30/03/2023 01:10, Teres Alexis, Alan Previn wrote: On Wed, 2023-03-29 at 08:43 +0100, Tvrtko Ursulin wrote: On 28/03/2023 18:52, Rodrigo Vivi wrote: On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn wrote: On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote:

Re: [PATCH 6/6] drm/omapdrm: Implement fbdev emulation as in-kernel client

Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc4 next-20230330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

Hi Jagan, On Thu, Mar 30, 2023 at 4:55 AM Jagan Teki wrote: > I have a previous iteration of this conversion. Can I resend it on top > of drm-misc-next? > https://lore.kernel.org/all/20210704090230.26489-9-ja...@amarulasolutions.com/ I tried applying your patch against linux-next, but I get

Re: [v2,21/50] drm/msm/dpu: split SC7280 catalog entry to the separate file

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_7_2_sc7280.h| 149 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 145 + > 2 files changed, 151 insertions(+), 143 deletions(-) >

Re: [PATCH 1/6] drm/omapdrm: Include

On 30/03/2023 11:32, Thomas Zimmermann wrote: Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c

Re: [v2,27/50] drm/msm/dpu: split SC8180X catalog entry to the separate file

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 108 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 106 + > 2 files changed, 109 insertions(+), 105 deletions(-) >

Re: [PATCH 4/6] drm/omapdrm: Remove fbdev from struct omap_drm_private

On 30/03/2023 11:32, Thomas Zimmermann wrote: The DRM device stores a pointer to the fbdev helper. Remove struct omap_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 6 +++---

Re: [v2,35/50] drm/msm/dpu: duplicate sm8350 catalog entries

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sm8350 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 10

Re: [v2,36/50] drm/msm/dpu: use defined symbol for sc8280xp's maxwidth

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Use defined name DEFAULT_DPU_OUTPUT_LINE_WIDTH instead of open coding > the value. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 2 +- > 1 file changed,

Re: [1/7] drm/tegra: Include

Reviewed-by: Sui Jingfeng > On 2023/3/30 16:36, Thomas Zimmermann wrote: Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/output.c | 2 ++ drivers/gpu/drm/tegra/rgb.c| 1 +

Re: [2/7] drm/tegra: Include

Reviewed-by: Sui Jingfeng > On 2023/3/30 16:36, Thomas Zimmermann wrote: Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/output.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [v2, 47/50] drm/msm/dpu: rename CTL_foo_MASK to contain major DPU version

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > To ease review and reuse rename CTL feature masks to contain base DPU > version since which this mask is used. > > Signed-off-by: Dmitry Baryshkov > --- > .../gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 10 +- >

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

Hi Fabio, On Thu, Mar 30, 2023 at 4:39 PM Fabio Estevam wrote: > > Hi Jagan, > > On Thu, Mar 30, 2023 at 4:55 AM Jagan Teki wrote: > > > I have a previous iteration of this conversion. Can I resend it on top > > of drm-misc-next? > >

[PATCH] accel/habanalabs/uapi: new Gaudi2 server type

Add definition of a new Gaudi2 server type. This represents the connectivity between the cards in that server type. Signed-off-by: Oded Gabbay --- include/uapi/drm/habanalabs_accel.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/habanalabs_accel.h

Re: [PATCH 0/6] drm/msm: Convert fbdev to DRM client

On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Convert msm' fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in msm is now just > another DRM client that runs

Re: [RFC][PATCH v2 1/3] drm: Introduce plane SIZE_HINTS property

On Tue, 21 Mar 2023 16:36:41 +0200 Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the

Re: [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

On 30.03.2023 00:24, Dmitry Baryshkov wrote: > Konrad brought up the topic of scaling the MX domain according to the > OPP changes. Here is my RFC for this functionality. I post it as an RFC > for two reasons: > > 1) I'm not sure that we should scale MX if we are not scaling main > voltage

Re: [v2,19/50] drm/msm/dpu: split SM8450 catalog entry to the separate file

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_8_1_sm8450.h| 203 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 204 +- > 2 files changed, 205 insertions(+), 202 deletions(-) >

Re: [v2,23/50] drm/msm/dpu: split SM6115 catalog entry to the separate file

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_6_3_sm6115.h| 96 +++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 90 + > 2 files changed, 98 insertions(+), 88 deletions(-) > create

Re: [v2,24/50] drm/msm/dpu: split QCM2290 catalog entry to the separate file

On 30.03.2023 13:52, Dmitry Baryshkov wrote: > On 30/03/2023 14:50, Konrad Dybcio wrote: >> >> >> On 12.02.2023 00:12, Dmitry Baryshkov wrote: >>> Signed-off-by: Dmitry Baryshkov >>> --- >>>   .../msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h   | 116 ++ >>>  

Re: [v2,26/50] drm/msm/dpu: split SM8250 catalog entry to the separate file

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h| 131 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 132 +- > 2 files changed, 132 insertions(+), 131 deletions(-) >

Re: [v2,32/50] drm/msm/dpu: duplicate sc7180 catalog entries

On 30/03/2023 15:22, Konrad Dybcio wrote: On 12.02.2023 00:12, Dmitry Baryshkov wrote: Duplicate some of sc7180 catalog entries to remove dependencies between DPU major generations. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 9 +++--

Re: [v2,45/50] drm/msm/dpu: inline IRQ_n_MASK defines

On 12.02.2023 00:12, Dmitry Baryshkov wrote: > IRQ masks are rarely shared between different DPU revisions. Inline them > to the dpu_mdss_cfg intances and drop them from the dpu_hw_catalog.c > > Signed-off-by: Dmitry Baryshkov > --- Everything looks good! Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] drm/ttm: set TTM allocated pages as reserved

On Thu, Mar 30, 2023 at 2:22 AM Sean Christopherson wrote: > > +David > > On Wed, Mar 29, 2023, Paolo Bonzini wrote: > > On 3/29/23 18:43, Christian K�nig wrote: > > > > > > > > > > > > 3) other uses of kmap() must switch to MMU-notifier protection. > > > > > > I would rather suggest to return

[PATCH v1 4/6] drm/bridge: tc358768: Add TC9594

From: Francesco Dolcini Add TC9594 ids, from the software point of view this is fully compatible with tc358768, the only difference is the automotive qualification. Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v1 5/6] drm/bridge: tc358768: Add parallel data format cfg

From: Francesco Dolcini Add configuration for parallel data format register, tc358768 supports different mapping on the parallel input RGB interface, enable the configuration for it. Valid values, and the related meaning, are: 0 = R[7:0], G[7:0], B[7:0] 1 = R[1:0], G[1:0], B[1:0], R[7:2],

  1   2   3   4   >