Re: [PATCH 4/4] drm/mgag200: Use DMA to copy the framebuffer to the VRAM

2023-05-09 Thread Jocelyn Falempe
On 08/05/2023 10:04, Thomas Zimmermann wrote: Hi Jocelyn Am 05.05.23 um 14:43 schrieb Jocelyn Falempe: Even if the transfer is not faster, it brings significant improvement in latencies and CPU usage. I think I shot down this patch already. I don't want to maintain the extra code for DMA

[PATCH v6 1/8] drm/bridge: tfp410: Support format negotiation hooks

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, tfp410 will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for state management. Input format is the one

[PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Signed-off-by: Nikhil

[PATCH v6 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar When removing the tidss driver, there is a warning reported by kernel about an unhandled interrupt for mhdp driver. [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option) ... [snipped backtrace] [ 43.330735] handlers: [ 43.333020]

[PATCH v6 7/8] drm/tidss: Update encoder/bridge chain connect model

2023-05-09 Thread Aradhya Bhatia
With the new encoder/bridge chain model, the display controller driver is required to create a drm_connector entity instead of asking the bridge to do so during drm_bridge_attach. Moreover, the controller driver should create a drm_bridge entity to negotiate bus formats and a 'simple' drm_encoder

[PATCH v6 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-05-09 Thread Aradhya Bhatia
With new connector model, sii902x will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for state management. Input

Re: [PATCH] drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX

2023-05-09 Thread Jani Nikula
On Thu, 04 May 2023, Simon Ser wrote: > Reviewed-by: Simon Ser Thanks, pushed to drm-misc-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

[PATCH v6 0/8] drm/tidss: Use new connector model for tidss

2023-05-09 Thread Aradhya Bhatia
Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tidss to using new connectoe model, where the SoC driver (tidss) creates the connector and all the bridges are attached with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR. It also now creates bridge to

[PATCH v6 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook

[PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support minimal format negotiations hooks in the drm_bridge_funcs. Complete format negotiation can be added based on EDID data.

[PATCH v2 RESEND 7/7] swiotlb: per-device flag if there are dynamically allocated buffers

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik Do not walk the list of dynamically allocated bounce buffers if the list is empty. This avoids taking dma_io_tlb_dyn_lock for devices which do not use any dynamically allocated bounce buffers. When unmapping the last dynamically allocated bounce buffer, the flag is set to

[PATCH v2 RESEND 6/7] drm: Use DMA_ATTR_MAY_SLEEP from process context

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik These mappings are never done from atomic context. If a dynamically allocated bounce buffer is used for the mapping, this change allows to allocate from CMA. Signed-off-by: Petr Tesarik --- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- drivers/gpu/drm/drm_prime.c

[PATCH v2 RESEND 5/7] swiotlb: Add a boot option to enable dynamic bounce buffers

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik The main goal of allocating bounce buffers dynamically is to allow allocating a minimal fixed swiotlb at boot time but avoid hard limits on the amount of I/O that can be handled later. Compared to fixed IO TLB slots, dynamic allocation of bounce buffers typically increases

[PATCH v2 RESEND 4/7] swiotlb: Dynamically allocated bounce buffers

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik The software IO TLB was designed with the assumption that it is not used much, especially on 64-bit systems, so a small fixed memory area (currently 64 MiB) is sufficient to handle the few cases which still require a bounce buffer. However, these cases are not so rare in some

[PATCH v2 RESEND 3/7] dma-mapping: introduce the DMA_ATTR_MAY_SLEEP attribute

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik Introduce a DMA attribute to tell the DMA-mapping subsystem that the operation is allowed to sleep. This patch merely adds the flag, but it does not do anything at the moment. Signed-off-by: Petr Tesarik --- Documentation/core-api/dma-attributes.rst | 10 ++

[PATCH v2 RESEND 2/7] swiotlb: Move code around in preparation for dynamic bounce buffers

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik To prepare for the introduction of dynamically allocated bounce buffers, separate out common code and code which handles non-dynamic (aka fixed) bounce buffers. No functional change, but this commit should make the addition of dynamic allocations easier to review.

[PATCH v2 RESEND 1/7] swiotlb: Use a helper to initialize swiotlb fields in struct device

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik Move swiotlb initialization code to swiotlb.h. This change also allows to provide a stub implementation if swiotlb is not configured, getting rid of an #ifdef in driver core. Signed-off-by: Petr Tesarik --- drivers/base/core.c | 4 +--- include/linux/swiotlb.h | 12

[PATCH v2 RESEND 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-05-09 Thread Petr Tesarik
From: Petr Tesarik The goal of my work is to provide more flexibility in the sizing of SWIOTLB. The software IO TLB was designed with these assumptions: 1. It would not be used much, especially on 64-bit systems. 2. A small fixed memory area (64 MiB by default) is sufficient to handle the

Re: [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Konrad Dybcio
On 9.05.2023 10:23, Neil Armstrong wrote: > On 09/05/2023 01:27, Dmitry Baryshkov wrote: >> On 08/05/2023 23:09, Abhinav Kumar wrote: >>> >>> >>> On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: > Currently, word count is calculated using

Re: [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-09 Thread Konrad Dybcio
On 8.05.2023 23:15, Akhil P Oommen wrote: > On Mon, May 08, 2023 at 10:59:24AM +0200, Konrad Dybcio wrote: >> >> >> On 6.05.2023 16:46, Akhil P Oommen wrote: >>> On Fri, May 05, 2023 at 12:35:18PM +0200, Konrad Dybcio wrote: On 5.05.2023 10:46, Akhil P Oommen wrote: > On Thu,

Re: [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Neil Armstrong
On 09/05/2023 01:27, Dmitry Baryshkov wrote: On 08/05/2023 23:09, Abhinav Kumar wrote: On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: Currently, word count is calculated using slice_count. This is incorrect as downstream uses slice per packet, which

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Pekka Paalanen
On Mon, 8 May 2023 18:54:09 -0500 Steven Kucharzyk wrote: > I'd like to ask if there is a block/flow chart/diagram that has been > created that represent the elements that are being discussed for this > RFC? If so, would you be so kind as to point me to it or send it to me? Hi Steven, the

Re: [PATCH 3/3] drm/i915: Temporary conversion to new GENMASK/BIT macros

2023-05-09 Thread Lucas De Marchi
On Tue, May 09, 2023 at 10:57:19AM +0300, Jani Nikula wrote: On Mon, 08 May 2023, Lucas De Marchi wrote: Convert the REG_* macros from i915_reg_defs.h to use the new macros defined in linux/bits.h. This is just to help on the implementation of the new macros and not intended to be applied.

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-09 Thread Konrad Dybcio
On 9.05.2023 01:38, Dmitry Baryshkov wrote: > On Mon, 8 May 2023 at 21:01, Dmitry Baryshkov > wrote: >> >> On 08/05/2023 13:49, Dmitry Baryshkov wrote: >>> On 08/05/2023 13:38, Konrad Dybcio wrote: On 8.05.2023 12:33, Dmitry Baryshkov wrote: > On 08/05/2023 11:33, Konrad

Re: [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Konrad Dybcio
On 9.05.2023 01:27, Dmitry Baryshkov wrote: > On 08/05/2023 23:09, Abhinav Kumar wrote: >> >> >> On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: >>> On 03/05/2023 04:19, Jessica Zhang wrote: Currently, word count is calculated using slice_count. This is incorrect as downstream uses slice

Re: [PATCH 46/53] drm/tidss: Convert to platform remove callback returning void

2023-05-09 Thread Tomi Valkeinen
On 07/05/2023 19:26, Uwe Kleine-König wrote: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Pekka Paalanen
On Thu, 04 May 2023 15:22:59 + Simon Ser wrote: > Hi all, > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > pipeline before blending, ie. after a pixel is tapped from a plane's > framebuffer and before it's blended with other planes. With this new uAPI we >

Re: [PATCH v5 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-09 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [cannot apply to deller-parisc/for-next arnd-asm-generic/master linus/master v6.4-rc1 next-20230509] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH 3/3] drm/i915: Temporary conversion to new GENMASK/BIT macros

2023-05-09 Thread Jani Nikula
On Mon, 08 May 2023, Lucas De Marchi wrote: > Convert the REG_* macros from i915_reg_defs.h to use the new macros > defined in linux/bits.h. This is just to help on the implementation > of the new macros and not intended to be applied. This drops a number of build time input checks as well as

[PATCH v2] drm: rcar-du: remove R-Car H3 ES1.* workarounds

2023-05-09 Thread Wolfram Sang
R-Car H3 ES1.* was only available to an internal development group and needed a lot of quirks and workarounds. These become a maintenance burden now, so our development group decided to remove upstream support for this SoC and prevent booting it. Public users only have ES2 onwards. Signed-off-by:

Re: [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support

2023-05-09 Thread neil . armstrong
On 08/05/2023 10:38, Liu Ying wrote: Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support. The panel has a LVDS display interface. The panel's product specification can be found at: http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf

Re: [PATCH 2/2] drm/panel: sharp-ls043t1le01: drop dummy functions and data fields

2023-05-09 Thread Neil Armstrong
On 07/05/2023 19:26, Dmitry Baryshkov wrote: Drop sharp_nt_panel_disable() and sharp_nt_panel_enable(), which bear no useful code. Also drop sharp_nt_panel::enable and sharp_nt_panel::mode fields which also provide no use now. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH 1/2] drm/panel: sharp-ls043t1le01: adjust mode settings

2023-05-09 Thread Neil Armstrong
On 07/05/2023 19:26, Dmitry Baryshkov wrote: Using current settings causes panel flickering on APQ8074 dragonboard. Adjust panel settings to follow the vendor-provided mode. This also enables MIPI_DSI_MODE_VIDEO_SYNC_PULSE, which is also specified by the vendor dtsi for the mentioned

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-05-09 Thread Greg Kroah-Hartman
On Tue, May 09, 2023 at 09:16:35AM +0200, Petr Tesařík wrote: > On Wed, 26 Apr 2023 14:44:39 +0200 > Petr Tesařík wrote: > > > Hi Greg, > > > > On Wed, 26 Apr 2023 14:26:36 +0200 > > Greg Kroah-Hartman wrote: > > > > > On Wed, Apr 26, 2023 at 02:15:20PM +0200, Petr Tesařík wrote: > > > >

Re: [PATCH 41/53] drm/sti: Convert to platform remove callback returning void

2023-05-09 Thread Alain Volmat
Hi, Acked-by: Alain Volmat Regards, Alain On Sun, May 07, 2023 at 06:26:04PM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However

Re: [PATCH 2/4] drm/mgag200: Simplify offset and scale computation.

2023-05-09 Thread Jocelyn Falempe
On 08/05/2023 09:44, Thomas Zimmermann wrote: Hi Am 05.05.23 um 14:43 schrieb Jocelyn Falempe: Now that the driver handles only 16, 24 and 32-bit framebuffer, it can be simplified. I think it should say that the driver never really handled 8-bit colors. Or at least I'm not aware of. Ok I

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-05-09 Thread Petr Tesařík
On Wed, 26 Apr 2023 14:44:39 +0200 Petr Tesařík wrote: > Hi Greg, > > On Wed, 26 Apr 2023 14:26:36 +0200 > Greg Kroah-Hartman wrote: > > > On Wed, Apr 26, 2023 at 02:15:20PM +0200, Petr Tesařík wrote: > > > Hi, > > > > > > On Wed, 19 Apr 2023 12:03:52 +0200 > > > Petr Tesarik wrote: > > >

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-09 Thread Thomas Zimmermann
Hi, for the whole series: Reviewed-by: Thomas Zimmermann Please see my comment on the patches to tiny/. Let me know if you want me to merge this patchset into drm-misc-next. Best regards Thomas Am 07.05.23 um 18:25 schrieb Uwe Kleine-König: Hello, this patch series adapts the platform

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-09 Thread Uwe Kleine-König
[A few addressed bounced and my script to find the recipents for a patch series broke and invented some addresses. I fixed all the problem I'm aware of in this mail.] On Mon, May 08, 2023 at 09:06:27AM +0200, Thomas Zimmermann wrote: > for the whole series: > > Reviewed-by: Thomas Zimmermann >

[PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-09 Thread Uwe Kleine-König
Hello, this patch series adapts the platform drivers below drivers/gpu/drm to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only

Re: [PATCH 06/53] drm/atmel-hlcdc: Convert to platform remove callback returning void

2023-05-09 Thread Claudiu.Beznea
On 07.05.2023 19:25, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically

Re: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-09 Thread Leonard Lausen
Abhinav Kumar writes: > On 5/7/2023 7:15 PM, Bjorn Andersson wrote: >> When booting with the cable connected on my X13s, 100 is long enough for >> my display to time out and require me to disconnect and reconnect the >> cable again. >> >> Do we have any idea of why the reduction to 0 is causing

Re: [PATCH V2] drm/amdgpu/display: Enable DC_FP for LoongArch

2023-05-09 Thread WANG Xuerui
On 2023/5/5 19:32, Huacai Chen wrote: Now LoongArch provides kernel_fpu_begin() and kernel_fpu_end() in commit 2b3bd32ea3a22ea2d ("LoongArch: Provide kernel fpu functions"), so we can enable DC_FP for DCN devices. Some grammatical fixes and paraphrasing: "LoongArch now provides

[PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-09 Thread Leonard Lausen
This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. Removing the delay of 100 units broke hot plug detection for USB-C displays on qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares dp_hot_plug_det in the dts. Other sc7180 based devices like aspire1 were not

Regarding Xorg EVoC

2023-05-09 Thread Bhav Khurana 4-Year B.Tech. Computer Science and Engineering
This is Bhav Khurana, currently studying in the Indian Institute of Technology (BHU), Varanasi, India. I am writing this because I had applied for GSoC'23 in the CCExtractor Organisation. Unfortunately, my proposal didn't get selected because of tough competition in that project. I feel that my

Re: [V3] drm/amdgpu/display: Enable DC_FP for LoongArch

2023-05-09 Thread WANG Xuerui
On 2023/5/9 00:34, Sui Jingfeng wrote: I have tested glmark2 on ls3a5000 with this patch applied, I have also bought a better gpu (vega 56), which is on the way. currently only have a rx550 at hand. I pasted the performance score here, how about this score? Does this looks normal? [snip of

Re: [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-09 Thread Marijn Suijten
On 2023-05-09 02:08:52, Dmitry Baryshkov wrote: > On 09/05/2023 00:46, Jessica Zhang wrote: > > > > > > On 5/7/2023 9:00 AM, Marijn Suijten wrote: > >> On 2023-05-05 14:23:50, Jessica Zhang wrote: > >>> Add DATA_COMPRESS feature flag to DPU INTF block. > >>> > >>> In DPU 7.x and later, DSC/DCE

Re: [PATCH v6 6/7] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-09 Thread Marijn Suijten
On 2023-05-08 17:51:08, Jessica Zhang wrote: > > > On 5/7/2023 11:34 AM, Marijn Suijten wrote: > > On 2023-05-07 17:27:33, Marijn Suijten wrote: > >> On 2023-05-04 15:05:15, Abhinav Kumar wrote: > >>> > >>> > >>> On 5/4/2023 2:56 PM, Marijn Suijten wrote: > On 2023-04-12 16:25:20, Jessica

Re: [Freedreno] [PATCH v2 4/4] drm/msm/dpu: Set DATA_COMPRESS for command mode

2023-05-09 Thread Marijn Suijten
On 2023-05-08 17:00:12, Jessica Zhang wrote: > On 5/8/2023 4:17 PM, Jessica Zhang wrote: > > On 5/7/2023 9:06 AM, Marijn Suijten wrote: > >> On 2023-05-05 14:23:51, Jessica Zhang wrote: > >>> Add a DPU INTF op to set DATA_COMPRESS register for command mode > >>> panels if > >>> the

Re: [PATCH v2 4/4] drm/msm/dpu: Set DATA_COMPRESS for command mode

2023-05-09 Thread Marijn Suijten
On 2023-05-08 16:17:54, Jessica Zhang wrote: > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h > >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h > >> index 73b0885918f8..a8def68a5ec2 100644 > >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h > >> +++

Re: (subset) [PATCH 00/19] drm/bridge: Convert to platform remove callback returning void

2023-05-09 Thread Uwe Kleine-König
Hello Neil, On Mon, Mar 20, 2023 at 11:54:12AM +0100, Neil Armstrong wrote: > On Sat, 18 Mar 2023 20:07:45 +0100, Uwe Kleine-König wrote: > > this series adapts the platform drivers below drivers/gpu/drm/bridge to use > > the > > .remove_new() callback. Compared to the traditional .remove()

<    1   2