Re: [PATCH 2/5] drm/mediatek: Add cnt checking for coverity issue

2023-06-13 Thread 林睿祥

Re: [PATCH] drm/sched: Call drm_sched_fence_set_parent() from drm_sched_fence_scheduled()

2023-06-13 Thread Boris Brezillon
On Tue, 13 Jun 2023 11:44:24 +0200 Boris Brezillon wrote: > Drivers that can delegate waits to the firmware/GPU pass the scheduled > fence to drm_sched_job_add_dependency(), and issue wait commands to > the firmware/GPU at job submission time. For this to be possible, they > need all their

[PATCH v2] fbdev/media: Use GPIO descriptors for VIA GPIO

2023-06-13 Thread Linus Walleij
The VIA fbdev exposes a custom GPIO chip for its GPIOs, these are in turn looked up the camera driver using a custom API. Drop the custom API, provide a look-up table and convert to GPIO descriptors. Note proper polarity on the RESET line. Cc: Jonathan Corbet Signed-off-by: Linus Walleij ---

Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings

2023-06-13 Thread Miquel Raynal
Hi Michael, michael.rie...@wolfvision.net wrote on Tue, 13 Jun 2023 08:15:26 +0200: > Hi Miquel, > > On 6/9/23 16:59, Miquel Raynal wrote: > > The spi core warns us about using an of_device_id table without a > > s/spi/SPI ? Actually both are accepted in the kernel, IIRC it depends whether

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Jun 12, 2023 at 10:43 PM Wolfram Sang wrote: > > Perhaps we should first think through what an ancillary device really > > is. My understanding is that it is used to talk to secondary addresses > > of a multi-address I2C slave device. > > As I mentioned somewhere before,

Re: [PATCH] drm/bridge: ps8640: Drop the ability of ps8640 to fetch the EDID

2023-06-13 Thread Sam Ravnborg
Hi Douglas, On Mon, Jun 12, 2023 at 04:32:57PM -0700, Douglas Anderson wrote: > In order to read the EDID from an eDP panel, you not only need to > power on the bridge chip itself but also the panel. In the ps8640 > driver, this was made to work by having the bridge chip manually power > the

Re: [PATCH v2 36/38] fbdev/core: Move file-I/O code into separate file

2023-06-13 Thread Thomas Zimmermann
Am 12.06.23 um 16:08 schrieb Thomas Zimmermann: Move fbdev's file-I/O code into a separate file and contain it in init and cleanup helpers. No functional changes. v2: * rename source file (Sam) I just noticed that fb_chrdev.c is missing from this patch. It got lost during the rename.

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
On 2023/6/13 17:10, Maxime Ripard wrote: On Tue, Jun 13, 2023 at 04:35:44PM +0800, Sui Jingfeng wrote: Hi, On 2023/6/13 16:30, Maxime Ripard wrote: Hi, On Mon, Jun 12, 2023 at 10:58:54PM +0800, Sui Jingfeng wrote: Hi, Any ideas for this trivial DC driver? Sorry about my broken English.

[PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers

2023-06-13 Thread Manikandan Muralidharan
From: Durai Manickam KR The register address of the XLCDC IP used in SAM9X7 are different from the previous HLCDC.Defining those address space with valid macros. Signed-off-by: Durai Manickam KR [manikanda...@microchip.com: Remove unused macro definitions] Signed-off-by: Manikandan

[PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller

2023-06-13 Thread Manikandan Muralidharan
Add compatible for SAM9X7 HLCD controller. Signed-off-by: Manikandan Muralidharan --- drivers/mfd/atmel-hlcdc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c index 3c2414ba4b01..8755c91ce854 100644 --- a/drivers/mfd/atmel-hlcdc.c +++

[PATCH 0/9] Add support for XLCDC to sam9x7 SoC family.

2023-06-13 Thread Manikandan Muralidharan
From: Manikandan This patch series aims to add support for XLCDC IP of sam9x7 SoC family to the DRM subsystem.XLCDC IP has additional registers and new configuration bits compared to the existing register set of HLCDC IP. The compatible string "microchip,sam9x7-xlcdc", defined for sam9x7 SoC

[PATCH 3/9] drm: atmel-hlcdc: add LCD controller layer definition for SAM9X7

2023-06-13 Thread Manikandan Muralidharan
Add the LCD controller layer definition and descriptor structure for SAM9X7 for the following layers, - Base Layer - Overlay1 Layer - Overlay2 Layer - High End Overlay Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 96 1 file

[PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC

2023-06-13 Thread Manikandan Muralidharan
From: Durai Manickam KR Add compatible string check to differentiate XLCDC and HLCDC code within the atmel-hlcdc driver files. Signed-off-by: Durai Manickam KR Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +++

[PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-13 Thread Manikandan Muralidharan
Add new compatible string for the XLCD controller on SAM9X7 SoC. Signed-off-by: Manikandan Muralidharan --- Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi everyone, > > > Perhaps we should first think through what an ancillary device really > > is. My understanding is that it is used to talk to secondary > > addresses of a

Re: [PATCH v4 5/8] drm/mediatek: hdmi: add v2 support

2023-06-13 Thread 胡俊光

[PATCH v3] drm/sched: Make sure we wait for all dependencies in kill_jobs_cb()

2023-06-13 Thread Boris Brezillon
drm_sched_entity_kill_jobs_cb() logic is omitting the last fence popped from the dependency array that was waited upon before drm_sched_entity_kill() was called (drm_sched_entity::dependency field), so we're basically waiting for all dependencies except one. In theory, this wait shouldn't be

[PATCH] drm/sched: Call drm_sched_fence_set_parent() from drm_sched_fence_scheduled()

2023-06-13 Thread Boris Brezillon
Drivers that can delegate waits to the firmware/GPU pass the scheduled fence to drm_sched_job_add_dependency(), and issue wait commands to the firmware/GPU at job submission time. For this to be possible, they need all their 'native' dependencies to have a valid parent since this is where the

Re: [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels

2023-06-13 Thread Neil Armstrong
On 12/06/2023 18:50, Konrad Dybcio wrote: On 12.06.2023 17:26, Neil Armstrong wrote: "low" was written "lov", fix this. Fixes: 99d33ee61cb0 ("arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels") Signed-off-by: Neil Armstrong ---

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-13 Thread Michael Riesch
Hi Miquel, On 6/9/23 16:59, Miquel Raynal wrote: > A very basic debugging rule when a device is connected for the first > time is to access a read-only register which contains known data in > order to ensure the communication protocol is properly working. This > driver lacked any read helper

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-13 Thread Pekka Paalanen
On Mon, 12 Jun 2023 12:56:57 -0400 Christopher Braga wrote: > On 6/12/2023 5:21 AM, Pekka Paalanen wrote: > > On Fri, 9 Jun 2023 19:11:25 -0400 > > Christopher Braga wrote: > > > >> On 6/9/2023 12:30 PM, Simon Ser wrote: > >>> Hi Christopher, > >>> > >>> On Friday, June 9th, 2023 at 17:52,

RE: [PATCH v5] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-13 Thread Lin, Wayne
[AMD Official Use Only - General] Noted. Thanks, Lyude! Regards, Wayne Lin > -Original Message- > From: Lyude Paul > Sent: Tuesday, June 13, 2023 6:34 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com;

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
Hi, On 2023/6/13 16:30, Maxime Ripard wrote: Hi, On Mon, Jun 12, 2023 at 10:58:54PM +0800, Sui Jingfeng wrote: Hi, Any ideas for this trivial DC driver? Sorry about my broken English. What to do next? Send a new version? Thomas already told you to merge it in the previous version:

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Maxime Ripard
On Tue, Jun 13, 2023 at 04:35:44PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/6/13 16:30, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jun 12, 2023 at 10:58:54PM +0800, Sui Jingfeng wrote: > > > Hi, > > > > > > > > > Any ideas for this trivial DC driver? Sorry about my broken English. > > >

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Maxime Ripard
On Tue, Jun 13, 2023 at 04:40:07PM +0800, Sui Jingfeng wrote: > > On 2023/6/13 16:30, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jun 12, 2023 at 10:58:54PM +0800, Sui Jingfeng wrote: > > > Hi, > > > > > > > > > Any ideas for this trivial DC driver? Sorry about my broken English. > > > > > >

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
On 2023/6/13 17:28, Maxime Ripard wrote: On Tue, Jun 13, 2023 at 05:17:00PM +0800, Sui Jingfeng wrote: On 2023/6/13 17:10, Maxime Ripard wrote: On Tue, Jun 13, 2023 at 04:35:44PM +0800, Sui Jingfeng wrote: Hi, On 2023/6/13 16:30, Maxime Ripard wrote: Hi, On Mon, Jun 12, 2023 at

[PATCH 7/9] drm: atmel-hlcdc: add DPI mode support for XLCDC

2023-06-13 Thread Manikandan Muralidharan
Add support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register. Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update DPI mode bit using is_xlcdc

[PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-06-13 Thread Manikandan Muralidharan
- XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag. - HEO scaling, window resampling, Alpha blending, YUV-to-RGB conversion in

Re: [PATCH] accel/qaic: Fix dereferencing freed memory

2023-06-13 Thread Pranjal Ramajor Asha Kanojiya
On 6/12/2023 4:52 PM, Christian König wrote: Am 10.06.23 um 04:12 schrieb Sukrut Bellary: smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:     dereferencing freed memory 'obj->import_attach' obj->import_attach is detached and freed using

Re: [PATCH] accel/qaic: Fix dereferencing freed memory

2023-06-13 Thread Pranjal Ramajor Asha Kanojiya
On 6/10/2023 7:42 AM, Sukrut Bellary wrote: smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error: dereferencing freed memory 'obj->import_attach' obj->import_attach is detached and freed using dma_buf_detach(). But used after free to decrease

Re: [PATCH] accel/qaic: Fix dereferencing freed memory

2023-06-13 Thread Pranjal Ramajor Asha Kanojiya
On 6/12/2023 8:39 PM, Jeffrey Hugo wrote: On 6/12/2023 7:21 AM, Christian König wrote: Am 12.06.23 um 15:03 schrieb Pranjal Ramajor Asha Kanojiya: On 6/12/2023 4:52 PM, Christian König wrote: Am 10.06.23 um 04:12 schrieb Sukrut Bellary: smatch warning:

[PATCH 8/9] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC

2023-06-13 Thread Manikandan Muralidharan
update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c |

[PATCH 9/9] drm: atmel-hlcdc: add support for DSI output formats

2023-06-13 Thread Manikandan Muralidharan
Add support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet: - 16BPPCFG1 - 16BPPCFG2 - 16BPPCFG3 - 18BPPCFG1 - 18BPPCFG2 - 24BPP Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update output format using is_xlcdc flag] Signed-off-by:

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Maxime Ripard
Hi, On Mon, Jun 12, 2023 at 10:58:54PM +0800, Sui Jingfeng wrote: > Hi, > > > Any ideas for this trivial DC driver? Sorry about my broken English. > > What to do next? Send a new version? Thomas already told you to merge it in the previous version:

Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings

2023-06-13 Thread Michael Riesch
Hi Miquel, On 6/9/23 16:59, Miquel Raynal wrote: > The spi core warns us about using an of_device_id table without a s/spi/SPI ? > spi_device_id table aside for module utilities in orter to not rely on s/in orter to/in order to ? > OF modaliases. Just add this table using the device name

linux-next: build warnings after merge of the drm tree

2023-06-13 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced these warnings: Documentation/gpu/i915:546: drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: ERROR: Unexpected indentation. Documentation/gpu/i915:546: drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote

Re: [PATCH 1/5] drm/mediatek: Remove freeing not dynamic allocated memory

2023-06-13 Thread 林睿祥

Re: [v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

2023-06-13 Thread Sui Jingfeng
Hi, Humble ping ? On 2023/6/7 19:06, Sui Jingfeng wrote: Otherwise its failed to pass basic compile test on platform without REGMAP_MMIO selected by defconfig make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- SYNCinclude/config/auto.conf.cmd Checking

Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

2023-06-13 Thread Thomas Zimmermann
Hi Am 12.06.23 um 17:17 schrieb Ruhl, Michael J: [...] Thomas, Looking at the fb.h file I see: struct device *device; /* This is the parent */ struct device *dev; /* This is this fb device */ Is this documentation "correct"? If so, how does that match

[Bug 217545] Serious regression on amdgpu (drm_display_helper/drm_dp_atomic_find_time_slots) with two DisplayPort connected via a HP G5 docking station

2023-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217545 --- Comment #4 from Christoph Biedl (bugzilla.kernel.b...@manchmal.in-ulm.de) --- Thanks, seems my search-foo didn't find that one. FWIW, the mentioned fix

Re: [PATCH 1/3] accel/habanalabs: remove pdev check on idle check

2023-06-13 Thread Ofir Bitton
On 12/06/2023 15:07, Oded Gabbay wrote: Our simulator supports idle check so no need anymore to check if pdev exists. Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] accel/habanalabs: reset device if scrubbing failed

2023-06-13 Thread Ofir Bitton
On 12/06/2023 15:07, Oded Gabbay wrote: If scrubbing memory after user released device has failed it means the device is in a bad state and should be reset. Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 4 +++- 1 file changed, 3

RE: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-13 Thread Kasireddy, Vivek
Hi David, > > On 12.06.23 09:10, Kasireddy, Vivek wrote: > > Hi Mike, > > Hi Vivek, > > > > > Sorry for the late reply; I just got back from vacation. > > If it is unsafe to directly use the subpages of a hugetlb page, then > > reverting > > this patch seems like the only option for

Re: [PATCH 4/5] drm/mediatek: Add casting before assign

2023-06-13 Thread 林睿祥

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Maxime Ripard
On Tue, Jun 13, 2023 at 05:17:00PM +0800, Sui Jingfeng wrote: > > On 2023/6/13 17:10, Maxime Ripard wrote: > > On Tue, Jun 13, 2023 at 04:35:44PM +0800, Sui Jingfeng wrote: > > > Hi, > > > > > > On 2023/6/13 16:30, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Mon, Jun 12, 2023 at

Re: [PATCH 3/5] drm/mediatek: Add initialization for mtk_gem_obj

2023-06-13 Thread 林睿祥

[PATCH v4 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS

2023-06-13 Thread Neil Armstrong
The DP output is shared with the USB3 SuperSpeed lanes and is usually connected to an USB-C port which Altmode is controlled by the PMIC Glink infrastructure. DT changes tying the DP controller to the USB-C port on the QRD board will be sent later. Signed-off-by: Neil Armstrong --- Changes in

[PATCH v4 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels

2023-06-13 Thread Neil Armstrong
"low" was written "lov", fix this. Fixes: 99d33ee61cb0 ("arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels") Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 2/2] arm64: dts: qcom: sm8550: add display port nodes

2023-06-13 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 89 +++- 1 file changed, 87 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
On 2023/6/13 16:30, Maxime Ripard wrote: Hi, On Mon, Jun 12, 2023 at 10:58:54PM +0800, Sui Jingfeng wrote: Hi, Any ideas for this trivial DC driver? Sorry about my broken English. What to do next? Send a new version? Thomas already told you to merge it in the previous version:

Re: [PATCH 5/5] drm/mediatek: Fix dereference before null check

2023-06-13 Thread 林睿祥

Re: [PATCH v14 0/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
Hi, On 2023/6/13 17:28, Maxime Ripard wrote: On Tue, Jun 13, 2023 at 05:17:00PM +0800, Sui Jingfeng wrote: On 2023/6/13 17:10, Maxime Ripard wrote: On Tue, Jun 13, 2023 at 04:35:44PM +0800, Sui Jingfeng wrote: Hi, On 2023/6/13 16:30, Maxime Ripard wrote: Hi, On Mon, Jun 12, 2023 at

Re: [PATCH v2 03/38] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:07:41PM +0200, Thomas Zimmermann wrote: > Struct gpio_backlight_platform_data refers to a platform device within > the Linux device hierarchy. The test in gpio_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix

Re: [PATCH v2 02/38] backlight/bd6107: Rename struct bd6107_platform_data.fbdev to 'dev'

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:07:40PM +0200, Thomas Zimmermann wrote: > Rename struct bd6107_platform_data.fbdev to 'dev', as it stores a > pointer to the Linux platform device; not the fbdev device. Makes > the code easier to understand. > > Signed-off-by: Thomas Zimmermann > Cc: Lee Jones > Cc:

Re: [PATCH v4 03/68] clk: Move no reparent case into a separate function

2023-06-13 Thread Marek Szyprowski
On 13.06.2023 13:15, Marek Szyprowski wrote: > On 05.05.2023 13:25, Maxime Ripard wrote: >> From: Stephen Boyd >> >> We'll need to turn the code in clk_mux_determine_rate_flags() to deal >> with CLK_SET_RATE_NO_REPARENT into a helper clock drivers will be able >> to use if they don't want to

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Karol Herbst
On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: > > Am 29.11.22 um 22:14 schrieb Felix Kuehling: > > On 2022-11-25 05:21, Christian König wrote: > >> Instead of a single worker going over the list of delete BOs in regular > >> intervals use a per BO worker which blocks for the resv object

Re: [PATCH v2 06/38] backlight/lv5207lp: Rename struct lv5207lp_platform_data.fbdev to 'dev'

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:07:44PM +0200, Thomas Zimmermann wrote: > Rename struct lv5207lp_platform_data.fbdev to 'dev', as it stores a > pointer to the Linux platform device; not the fbdev device. Makes > the code easier to understand. > > Signed-off-by: Thomas Zimmermann > Cc: Yoshinori Sato

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > On Mon, Jun 12, 2023 at 10:43 PM Wolfram Sang wrote: > > > Perhaps we should first think through what an ancillary device > > > really is. My understanding is that

Re: [PATCH v4 03/68] clk: Move no reparent case into a separate function

2023-06-13 Thread Marek Szyprowski
On 05.05.2023 13:25, Maxime Ripard wrote: > From: Stephen Boyd > > We'll need to turn the code in clk_mux_determine_rate_flags() to deal > with CLK_SET_RATE_NO_REPARENT into a helper clock drivers will be able > to use if they don't want to allow reparenting. > > Cc: Abel Vesa > Cc: Alessandro

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2023-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 webd...@gmail.com changed: What|Removed |Added CC||webd...@gmail.com --- Comment #53

[PATCH] drm/tegra: Enable runtime PM during probe

2023-06-13 Thread Mikko Perttunen
From: Mikko Perttunen Currently, engine drivers only enable runtime PM during the host1x init callback. This can happen slightly later than the probe, which can cause the power domain to intermittently not be turned off after probe. My hypothesis is that there is a race condition between the

Re: [PATCH v2 05/38] backlight/lv5207lp: Compare against struct fb_info.device

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:07:43PM +0200, Thomas Zimmermann wrote: > Struct lv5207lp_platform_data refers to a platform device within > the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the

Re: [PATCH v2 04/38] backlight/gpio_backlight: Rename field 'fbdev' to 'dev'

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:07:42PM +0200, Thomas Zimmermann wrote: > Rename the field 'fbdev' in struct gpio_backlight_platform_data and > struct gpio_backlight to 'dev', as they store pointers to the Linux > platform device; not the fbdev device. Makes the code easier to > understand. > >

RE: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-13 Thread David Laight
From: Kasireddy, Vivek > Sent: 13 June 2023 09:26 ... > > Is my understanding correct, that we can effectively long-term pin > > (worse than mlock) 64 MiB per UDMABUF_CREATE, allowing eventually !root > > users > > The 64 MiB limit is the theoretical upper bound that we have not seen hit in >

Re: [PATCH v4 03/68] clk: Move no reparent case into a separate function

2023-06-13 Thread Maxime Ripard
Hi, On Tue, Jun 13, 2023 at 02:15:10PM +0200, Marek Szyprowski wrote: > On 13.06.2023 13:15, Marek Szyprowski wrote: > > On 05.05.2023 13:25, Maxime Ripard wrote: > >> From: Stephen Boyd > >> > >> We'll need to turn the code in clk_mux_determine_rate_flags() to deal > >> with

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Christian König
Am 13.06.23 um 15:05 schrieb Karol Herbst: On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: Am 29.11.22 um 22:14 schrieb Felix Kuehling: On 2022-11-25 05:21, Christian König wrote: Instead of a single worker going over the list of delete BOs in regular intervals use a per BO worker

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Karol Herbst
On Tue, Jun 13, 2023 at 3:59 PM Christian König wrote: > > Am 13.06.23 um 15:05 schrieb Karol Herbst: > > On Mon, Dec 5, 2022 at 2:40 PM Christian König > > wrote: > >> Am 29.11.22 um 22:14 schrieb Felix Kuehling: > >>> On 2022-11-25 05:21, Christian König wrote: > Instead of a single

Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote: > Struct bd6107_platform_data refers to a platform device within > the Linux device hierarchy. The test in bd6107_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test

Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

2023-06-13 Thread Thomas Zimmermann
Hi Am 13.06.23 um 12:37 schrieb Daniel Thompson: On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote: Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct

[PATCH v3 34/38] fbdev/core: Add fb_device_{create,destroy}()

2023-06-13 Thread Thomas Zimmermann
Move the logic to create and destroy fbdev devices into the new helpers fb_device_create() and fb_device_destroy(). There was a call to fb_cleanup_device() in do_unregister_framebuffer() that was too late. The device had already been removed at this point. Move the call into fb_device_destroy().

[PATCH v3 23/38] fbdev/rivafb: Reorder backlight and framebuffer init/cleanup

2023-06-13 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg ---

[PATCH v3 37/38] fbdev/core: Rework fb init code

2023-06-13 Thread Thomas Zimmermann
Init the class "graphics" before the rest of fbdev. Later steps, such as the sysfs code, depend on the class. Also arrange the module's exit code in reverse order. Unexport the global variable fb_class, which is only shared internally within the fbdev core module. Signed-off-by: Thomas

Re: [PATCH v3 4/4] drm/stm: add an option to change FB bpp

2023-06-13 Thread Philippe CORNU
On 6/9/23 08:20, Dario Binacchi wrote: Boards that use the STM32F{4,7} series have limited amounts of RAM. The added parameter allows users to size, within certain limits, the memory footprint required by the framebuffer. Signed-off-by: Dario Binacchi --- Changes in v3: - drop [4/6]

Re: [PATCH v2 38/38] fbdev: Make support for userspace interfaces configurable

2023-06-13 Thread Daniel Thompson
On Mon, Jun 12, 2023 at 04:08:16PM +0200, Thomas Zimmermann wrote: > Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev > device optional. If the new option has not been selected, fbdev > does not create files in devfs, sysfs or procfs. > > Most modern Linux systems run a DRM-based

Re: [PATCH] drm/sched: Call drm_sched_fence_set_parent() from drm_sched_fence_scheduled()

2023-06-13 Thread Christian König
Am 13.06.23 um 11:46 schrieb Boris Brezillon: On Tue, 13 Jun 2023 11:44:24 +0200 Boris Brezillon wrote: Drivers that can delegate waits to the firmware/GPU pass the scheduled fence to drm_sched_job_add_dependency(), and issue wait commands to the firmware/GPU at job submission time. For this

[PATCH v3 36/38] fbdev/core: Move file-I/O code into separate file

2023-06-13 Thread Thomas Zimmermann
Move fbdev's file-I/O code into a separate file and contain it in init and cleanup helpers. No functional changes. v3: * add missing file fb_chrdev.c v2: * rename source file (Sam) * include (Javier, kernel test robot) Signed-off-by: Thomas Zimmermann Reviewed-by: Sam

[PATCH v3 08/38] fbdev/atyfb: Use hardware device as backlight parent

2023-06-13 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg ---

[PATCH v3 24/38] fbdev/rivafb: Use hardware device as backlight parent

2023-06-13 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas Reviewed-by: Javier Martinez Canillas Reviewed-by:

[PATCH v3 20/38] fbdev/pxa168fb: Do not assign to struct fb_info.dev

2023-06-13 Thread Thomas Zimmermann
Do not assign the hardware device to struct fb_info.dev. The field references the fbdev software device, which is unrelated. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/pxa168fb.c | 2 +- 1 file changed, 1

[PATCH v3 33/38] fbdev/core: Move framebuffer and backlight helpers into separate files

2023-06-13 Thread Thomas Zimmermann
Move framebuffer and backlight helpers into separate files. Leave fbsysfs.c to sysfs-related code. No functional changes. The framebuffer helpers are not in fbmem.c because they are under GPL-2.0-or-later copyright, while fbmem.c is GPL-2.0. v2: * include (Sam) Signed-off-by: Thomas

[PATCH v3 12/38] fbdev/ep93xx-fb: Alloc DMA memory from hardware device

2023-06-13 Thread Thomas Zimmermann
Pass the hardware device to the DMA helpers dma_alloc_wc(), dma_mmap_wc() and dma_free_coherent(). The fbdev device that is currently being used is a software device and does not provide DMA memory. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 10/38] fbdev/aty128fb: Use hardware device as backlight parent

2023-06-13 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg ---

[PATCH v3 16/38] fbdev/mb862xxfb: Output messages with fb_dbg()

2023-06-13 Thread Thomas Zimmermann
Fix cases were output helpers are called with struct fb_info.dev. Use fb_dbg() instead. Prepares fbdev for making struct fb_info.dev optional. v2: * fix another reference to struct fb_info.dev (kernel test reobot) * remove fb_err() from commit message Signed-off-by: Thomas

[PATCH v3 32/38] fbdev/core: Pass Linux device to pm_vt_switch_*() functions

2023-06-13 Thread Thomas Zimmermann
Pass the Linux device to pm_vt_switch_*() instead of the virtual fbdev device. Prepares fbdev for making struct fb_info.dev optional. The type of device that is passed to the PM functions does not matter much. It is only a token within the internal list of known devices. The PM functions do not

[PATCH v3 35/38] fbdev/core: Move procfs code to separate file

2023-06-13 Thread Thomas Zimmermann
Move fbdev's procfs code into a separate file and contain it in init and cleanup helpers. For the cleanup, replace remove_proc_entry() with proc_remove(). It is equivalent in functionality, but looks more like an inverse of proc_create_seq(). v2: * document proc_remove() usage (Sam)

[PATCH v3 19/38] fbdev/nvidiafb: Use hardware device as backlight parent

2023-06-13 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas Reviewed-by: Javier Martinez Canillas Reviewed-by:

[PATCH v3 07/38] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup

2023-06-13 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/aty/atyfb_base.c | 16

[PATCH v3 21/38] fbdev/radeonfb: Reorder backlight and framebuffer cleanup

2023-06-13 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the cleanup calls for both data structures. The init calls are already in the correct order. Signed-off-by: Thomas Zimmermann Cc: Benjamin Herrenschmidt Reviewed-by: Javier Martinez Canillas Reviewed-by:

[PATCH v3 18/38] fbdev/nvidiafb: Reorder backlight and framebuffer init/cleanup

2023-06-13 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg ---

[PATCH v3 38/38] fbdev: Make support for userspace interfaces configurable

2023-06-13 Thread Thomas Zimmermann
Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev device optional. If the new option has not been selected, fbdev does not create files in devfs, sysfs or procfs. Most modern Linux systems run a DRM-based graphics stack that uses the kernel's framebuffer console, but has otherwise

[PATCH v3 02/38] backlight/bd6107: Rename struct bd6107_platform_data.fbdev to 'dev'

2023-06-13 Thread Thomas Zimmermann
Rename struct bd6107_platform_data.fbdev to 'dev', as it stores a pointer to the Linux platform device; not the fbdev device. Makes the code easier to understand. Signed-off-by: Thomas Zimmermann Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Reviewed-by: Javier Martinez Canillas

[PATCH v3 01/38] backlight/bd6107: Compare against struct fb_info.device

2023-06-13 Thread Thomas Zimmermann
Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight

[PATCH v3 06/38] backlight/lv5207lp: Rename struct lv5207lp_platform_data.fbdev to 'dev'

2023-06-13 Thread Thomas Zimmermann
Rename struct lv5207lp_platform_data.fbdev to 'dev', as it stores a pointer to the Linux platform device; not the fbdev device. Makes the code easier to understand. Signed-off-by: Thomas Zimmermann Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: Lee Jones Cc: Daniel

[PATCH v3 09/38] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup

2023-06-13 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/aty/aty128fb.c | 10 +-

[PATCH v3 22/38] fbdev/radeonfb: Use hardware device as backlight parent

2023-06-13 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. v2: * add Cc: tag (Dan) Signed-off-by: Thomas Zimmermann Cc: Benjamin Herrenschmidt

[PATCH v3 30/38] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-13 Thread Thomas Zimmermann
Detect registered instances of fb_info by reading the reference counter from struct fb_info.read. Avoids looking at the dev field and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Cc: Steve Glendinning Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 14/38] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

2023-06-13 Thread Thomas Zimmermann
Do not assing the Linux device to struct fb_info.dev. The call to register_framebuffer() initializes the field to the fbdev device. Drivers should not override its value. Fixes a bug where the driver incorrectly decreases the hardware device's reference counter and leaks the fbdev device. v2:

[PATCH v3 13/38] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err()

2023-06-13 Thread Thomas Zimmermann
Fix cases were output helpers are called with struct fb_info.dev. Use fb_info() and fb_err() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/ep93xx-fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v3 04/38] backlight/gpio_backlight: Rename field 'fbdev' to 'dev'

2023-06-13 Thread Thomas Zimmermann
Rename the field 'fbdev' in struct gpio_backlight_platform_data and struct gpio_backlight to 'dev', as they store pointers to the Linux platform device; not the fbdev device. Makes the code easier to understand. Signed-off-by: Thomas Zimmermann Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc:

[PATCH v3 11/38] fbdev/broadsheetfb: Call device_remove_file() with hardware device

2023-06-13 Thread Thomas Zimmermann
Call device_remove_file() with the same device that has been used for device_create_file(), which is the hardware device stored in struct fb_info.device. Prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by:

  1   2   3   >