Re: linux-next: build failure after merge of the amdgpu tree

2023-10-24 Thread Stephen Rothwell
Hi Alex, On Tue, 24 Oct 2023 08:57:16 -0400 Alex Deucher wrote: > > The two patches are in my -next tree and in the PR I sent last week. Thanks. -- Cheers, Stephen Rothwell pgp0dvwDrF7ce.pgp Description: OpenPGP digital signature

Re: [PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-24 Thread Andi Shyti
Hi Jani, > > static void rc6_res_reg_init(struct intel_rc6 *rc6) > > { > > - memset(rc6->res_reg, INVALID_MMIO_REG.reg, sizeof(rc6->res_reg)); > > That's just bollocks. memset() is byte granularity, while > INVALID_MMIO_REG.reg is u32. If the value was anything other than 0, > this would

Re: [PATCH] drm/bridge: synopsys: dw-mipi-dsi: Fix hcomponent lbcc for burst mode

2023-10-24 Thread Heiko Stuebner
On Wed, 18 Oct 2023 11:52:12 +0800, Liu Ying wrote: > In order to support burst mode, vendor drivers set lane_mbps higher than > bandwidth through DPI interface. So, calculate horizontal component lane > byte clock cycle(lbcc) based on lane_mbps instead of pixel clock rate for > burst mode. > >

Re: [PATCH v5 0/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-10-24 Thread Heiko Stuebner
On Mon, 23 Oct 2023 17:37:13 +, Jonas Karlman wrote: > This series add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced > by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. > Also include 10-bit 4:4:4 support since VOP can support that also. > > First

Re: [PATCH v3 0/4] Add more format for vop2 driver

2023-10-24 Thread Heiko Stuebner
On Wed, 18 Oct 2023 17:41:22 +0800, Andy Yan wrote: > From: Andy Yan > > > This is a preparation for the upcoming support for rk3588 vop. > > Patch 1 make the bpp calculation covery more format > Patch 2 remove formats that are unsupported by cluster windows > Patch 3 add more formats > Patch

Re: [pull] amdgpu, amdkfd drm-next-6.7

2023-10-24 Thread Alex Deucher
On Fri, Oct 20, 2023 at 3:51 PM Alex Deucher wrote: > > Hi Dave, Sima, > > More updates for 6.7. Mostly bug fixes. > > The following changes since commit 27442758e9b4e083bef3f164a1739475c01f3202: > > Merge tag 'amd-drm-next-6.7-2023-10-13' of > https://gitlab.freedesktop.org/agd5f/linux into

Re: linux-next: build failure after merge of the amdgpu tree

2023-10-24 Thread Alex Deucher
On Tue, Oct 24, 2023 at 8:57 AM Alex Deucher wrote: > > On Mon, Oct 23, 2023 at 8:59 PM Stephen Rothwell > wrote: > > > > Hi all, > > > > On Thu, 19 Oct 2023 12:06:18 +1100 Stephen Rothwell > > wrote: > > > > > > On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell > > > wrote: > > > > > > >

Re: [PATCH 05/18] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC

2023-10-24 Thread Rob Herring
On Mon, Oct 23, 2023 at 04:40:05PM +0200, Alexandre Mergnat wrote: > Display Serial Interface for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. > > Signed-off-by: Alexandre Mergnat > --- >

Re: [PATCH v6 9/9] drm: Introduce documentation for hotspot properties

2023-10-24 Thread Michael Banack
Yes, that patch should be: Signed-off-by: Michael Banack --Michael Banack On 10/23/23 14:29, Javier Martinez Canillas wrote: Albert Esteve writes: From: Michael Banack To clarify the intent and reasoning behind the hotspot properties introduce userspace documentation that goes over

[PATCH] drm/amd/display: avoid variable reinitialization

2023-10-24 Thread Bragatheswaran Manickavel
The member variable enable_hpo_pg_support is already initialized and hence the reinitialization instruction can be removed. Issue identified using the doubleinit.cocci Coccinelle semantic patch script. Signed-off-by: Bragatheswaran Manickavel ---

Re: [PATCH 1/5] dt-bindings: display: panel: Update NewVision NV3051D compatibles

2023-10-24 Thread Chris Morgan
On Tue, Oct 24, 2023 at 01:27:55PM -0500, Rob Herring wrote: > On Thu, Oct 19, 2023 at 09:50:38AM -0500, Chris Morgan wrote: > > On Thu, Oct 19, 2023 at 11:22:19AM +0200, Krzysztof Kozlowski wrote: > > > On 18/10/2023 18:18, Chris Morgan wrote: > > > > From: Chris Morgan > > > > > > > > Update

Re: Bug#1054514: linux-image-6.1.0-13-amd64: Debian VM with qxl graphics freezes frequently

2023-10-24 Thread Salvatore Bonaccorso
Hi Timo, On Tue, Oct 24, 2023 at 11:14:32PM +0300, Timo Lindfors wrote: > Package: src:linux > Version: 6.1.55-1 > Severity: normal > > Steps to reproduce: > 1) Install Debian 12 as a virtual machine using virt-manager, choose qxl >graphics card. You only need basic installation without

Re: [PATCH 1/5] dt-bindings: display: panel: Update NewVision NV3051D compatibles

2023-10-24 Thread Rob Herring
On Thu, Oct 19, 2023 at 09:50:38AM -0500, Chris Morgan wrote: > On Thu, Oct 19, 2023 at 11:22:19AM +0200, Krzysztof Kozlowski wrote: > > On 18/10/2023 18:18, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Update the NewVision NV3051D compatible strings by adding a new panel, > > > the

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-10-24 Thread Abhinav Kumar
On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote: On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote: From: Rob Clark Seems like we need to pick INPUT_SEL=1 when CTM is enabled. But not

[PATCH v2 03/11] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2023-10-24 Thread Carlos Eduardo Gallo Filho
Replace the use of strcpy to strscpy on the test_to_desc of the drm_test_framebuffer_create test for better security and reliability. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 01/11] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2023-10-24 Thread Carlos Eduardo Gallo Filho
The dev_private member of drm_device is deprecated and its use should be avoided. Stop using it by embedding the drm_device onto a mock struct with a void pointer like dev_private, using it instead. Also start using drm_kunit_helper_alloc_drm_device() for allocating the drm_device mock.

[PATCH v2 02/11] drm/tests: Add parameters to the drm_test_framebuffer_create test

2023-10-24 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Non-zero buffer offset for an unused plane Also replace strcpy to strscpy on test_to_desc for improved security

[PATCH v2 00/11] Increase coverage on drm_framebuffer.c

2023-10-24 Thread Carlos Eduardo Gallo Filho
This patchset includes new KUnit tests for 7 untested functions from drm_framebuffer.c and improvements to the existent one. The first patch replace the use of dev_private member from drm_device mock on the existent test by embedding it into an outer struct containing a generic pointer. The

[PATCH v2 05/11] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Order kunit cases alphabetically. - Rename check_src_coords_case to drm_framebuffer_check_src_coords_case. - Remove unnecessary comments. - Add framebuffer size

[PATCH v2 06/11] drm/tests: Add test for drm_framebuffer_cleanup()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 37

[PATCH v2 07/11] drm/tests: Add test for drm_framebuffer_lookup()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_lookup function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Replace drm_mode_object_add() call to drm_framebuffer_init(). - Rely on drm_kunit_helper_alloc_device() for mock initialization.

[PATCH v2 08/11] drm/tests: Add test for drm_framebuffer_init()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_init function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Let fb1.dev unset instead of set it to wrong_drm to test mismatched drm_device passed as drm_framebuffer_init() argument. -

[PATCH v2 09/11] drm/tests: Add test for drm_framebuffer_free()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 49 1 file changed, 49 insertions(+) diff --git

[PATCH v2 10/11] drm/tests: Add test for drm_mode_addfb2()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_mode_addfb2 function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 104

[PATCH v2 11/11] drm/tests: Add test for drm_fb_release()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_fb_release function, which also implicitly test the static legacy_remove_fb function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Rely on drm_kunit_helper_alloc_device() for mock initialization. --- drivers/gpu/drm/tests/drm_framebuffer_test.c

[PATCH v2 04/11] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 28 1 file changed, 28

Re: Bug#1054514: linux-image-6.1.0-13-amd64: Debian VM with qxl graphics freezes frequently

2023-10-24 Thread Bagas Sanjaya
On Tue, Oct 24, 2023 at 11:09:10PM +0200, Salvatore Bonaccorso wrote: > Hi Timo, > > On Tue, Oct 24, 2023 at 11:14:32PM +0300, Timo Lindfors wrote: > > Package: src:linux > > Version: 6.1.55-1 > > Severity: normal > > > > Steps to reproduce: > > 1) Install Debian 12 as a virtual machine using

Re: [PATCH v2 07/11] drm/mediatek: Add secure layer config support for ovl

2023-10-24 Thread 胡俊光

Evoc proposal

2023-10-24 Thread DAVID WALTERS
Hello, I have a draft of a proposal that I would like feedback on from Maíra Canal (or another mentor). If you could please let me know their email address (or I could send you the draft and you could forward it to them). It's for the KUnit and DRM project. Thanks, David Walters.

[PATCH v8 2/6] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2023-10-24 Thread André Almeida
From: Simon Ser This new kernel capability indicates whether async page-flips are supported via the atomic uAPI. DRM clients can use it to check for support before feeding DRM_MODE_PAGE_FLIP_ASYNC to the kernel. Make it clear that DRM_CAP_ASYNC_PAGE_FLIP is for legacy uAPI only. Signed-off-by:

[PATCH v8 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2023-10-24 Thread André Almeida
From: Simon Ser This new field indicates whether the driver has the necessary logic to support async page-flips via the atomic uAPI. This is leveraged by the next commit to allow user-space to use this functionality. All atomic drivers setting drm_mode_config.async_page_flip are updated to also

[PATCH v8 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-24 Thread André Almeida
Given that prop changes may lead to modesetting, which would defeat the fast path of the async flip, refuse any atomic prop change for async flips in atomic API. The only exception is the framebuffer ID to flip to. Currently the only plane type supported is the primary one. Reviewed-by: Simon Ser

[PATCH v8 5/6] drm/doc: Define KMS atomic state set

2023-10-24 Thread André Almeida
From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida --- v8: - no changes v7: - add a note that drivers can make exceptions for ad-hoc prop changes - add

[PATCH v8 0/6] drm: Add support for atomic async page-flip

2023-10-24 Thread André Almeida
Hi, This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through the atomic API. This feature is already available via the legacy API. The use case is to be able to present a new frame immediately (or as soon as possible), even if after missing a vblank. This might result in

[PATCH v8 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-10-24 Thread André Almeida
From: Simon Ser If the driver supports it, allow user-space to supply the DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. Set drm_crtc_state.async_flip accordingly. Document that drivers will reject atomic commits if an async flip isn't possible. This allows user-space to fall back

[PATCH v8 6/6] amd/display: indicate support for atomic async page-flips on DC

2023-10-24 Thread André Almeida
From: Simon Ser amdgpu_dm_commit_planes() already sets the flip_immediate flag for async page-flips. This flag is used to set the UNP_FLIP_CONTROL register. Thus, no additional change is required to handle async page-flips with the atomic uAPI. Signed-off-by: Simon Ser Reviewed-by: André

[PATCH] drm/nouveau/nvif: avoid possible memory leak of 'args'

2023-10-24 Thread Su Hui
Use kfree() to free 'args' before return '-EINVAL'. Signed-off-by: Su Hui --- drivers/gpu/drm/nouveau/nvif/vmm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvif/vmm.c b/drivers/gpu/drm/nouveau/nvif/vmm.c index 99296f03371a..a0afe3bf0d78 100644 ---

Re: [PATCH v2 08/11] drm/mediatek: Add secure layer config support for ovl_adaptor

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 06:45, Jason-JH.Lin ha scritto: Add secure layer config support for ovl_adaptor and sub driver mdp_rdma. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 3 +++ drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 11 ---

Re: [PATCH v2 05/11] drm/mediatek: Add mtk_ddp_sec_write to config secure buffer info

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 06:45, Jason-JH.Lin ha scritto: Add mtk_ddp_sec_write to configure secure buffer information to cmdq secure packet data. Then secure cmdq driver will use these information to configure curresponding secure DRAM address to HW overlay in secure world. Signed-off-by: Jason-JH.Lin ---

Re: [PATCH v2 03/11] drm/mediatek: Add secure buffer control flow to mtk_drm_gem

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 06:45, Jason-JH.Lin ha scritto: Add secure buffer control flow to mtk_drm_gem. When user space takes DRM_MTK_GEM_CREATE_ENCRYPTED flag and size to create a mtk_drm_gem object, mtk_drm_gem will find a matched size dma buffer from secure dma-heap and bind it to mtk_drm_gem object.

Re: [PATCH v2 07/11] drm/mediatek: Add secure layer config support for ovl

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 06:45, Jason-JH.Lin ha scritto: Add secure layer config support for ovl. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 ++ drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 31 +-- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c

Re: [PATCH v2 02/11] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATED_ENCRYPTTED flag

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 06:45, Jason-JH.Lin ha scritto: Add DRM_MTK_GEM_CREATED_ENCRYPTTED flag to allocate a secure buffer to support secure video path feature. You have a typo in both the commit description and the title. Please fix. Signed-off-by: Jason-JH.Lin --- include/uapi/drm/mediatek_drm.h

Re: [PATCH] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full

2023-10-24 Thread Christopher Obbard
Hi Jonas, On Mon, 2023-10-23 at 21:11 +, Jonas Karlman wrote: > Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328 > and RK3399 result in wrong colors being displayed. > > The issue can be observed using modetest: > >   modetest -s @:1920x1080-60@RG24 >   modetest -s

Re: [PATCH v10 15/24] drm/mediatek: Remove ineffectual power management codes

2023-10-24 Thread 胡俊光

Re: [PATCH v10 15/24] drm/mediatek: Remove ineffectual power management codes

2023-10-24 Thread 宋孝謙

Re: [PATCH 03/18] dt-bindings: display: mediatek: color: add binding for MT8365 SoC

2023-10-24 Thread Chen-Yu Tsai
On Mon, Oct 23, 2023 at 10:40 PM Alexandre Mergnat wrote: > > Display Color for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. This unfortunately doesn't match what the patch is doing. ChenYu > Signed-off-by: Alexandre Mergnat > --- >

Re: [PATCH v3 0/4] Add more format for vop2 driver

2023-10-24 Thread Sascha Hauer
On Wed, Oct 18, 2023 at 05:41:22PM +0800, Andy Yan wrote: > From: Andy Yan > > > This is a preparation for the upcoming support for rk3588 vop. > > Patch 1 make the bpp calculation covery more format > Patch 2 remove formats that are unsupported by cluster windows > Patch 3 add more formats >

Re: [GIT PULL v2] drm: renesas: shmobile: Atomic conversion + DT support (was: Re: [PATCH v4 00/41] drm: renesas: shmobile: Atomic conversion + DT support)

2023-10-24 Thread Geert Uytterhoeven
On Mon, Oct 16, 2023 at 11:59 AM Geert Uytterhoeven wrote: > > Hi David, Daniel, > > The following changes since commit 389af786f92ecdff35883551d54bf4e507ffcccb: > > Merge tag 'drm-intel-next-2023-09-29' of > git://anongit.freedesktop.org/drm/drm-intel into drm-next (2023-10-04 >

Re: [PATCH v10 14/24] drm/mediatek: Power on/off devices with function pointers

2023-10-24 Thread 胡俊光

Re: [PATCH v2 01/11] drm/mediatek: Add interface to allocate MediaTek GEM buffer.

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 06:45, Jason-JH.Lin ha scritto: From: CK Hu Add an interface to allocate MediaTek GEM buffers, allow the IOCTLs to be used by render nodes. This patch also sets the RENDER driver feature. Signed-off-by: CK Hu Signed-off-by: Nicolas Boichat Signed-off-by: Philipp Zabel

Re: [PATCH drm-misc-next v7 1/7] drm/gpuvm: convert WARN() to drm_WARN() variants

2023-10-24 Thread Christian König
Am 23.10.23 um 22:16 schrieb Danilo Krummrich: Use drm_WARN() and drm_WARN_ON() variants to indicate drivers the context the failing VM resides in. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c| 32 ++

Re: [PATCH 11/18] dt-bindings: pwm: add power-domains property

2023-10-24 Thread Alexandre Mergnat
Hello Conor On 23/10/2023 19:38, Conor Dooley wrote: Yo, On Mon, Oct 23, 2023 at 04:40:11PM +0200, Alexandre Mergnat wrote: According to the Mediatek datasheet, the display PWM block has a power domain. Datasheet for which soc? The mt8173? Is it valid for all devices in this binding? I

Re: [PATCH 1/2] drm/v3d: wait for all jobs to finish before unregistering

2023-10-24 Thread Maira Canal
Hi Iago, On 10/24/23 02:57, Iago Toral wrote: El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió: Currently, we are only warning the user if the BIN or RENDER jobs don't finish before we unregister V3D. We must wait for all jobs to finish before unregistering. Therefore, warn the user

[PATCH] drm/ttm: Remove comment about kfree for bo->destroy

2023-10-24 Thread Kenjiro Nakayama
Since the kfree handling was removed[1], this patch removes the instruction comment. [1] 3507932390bb drm/ttm: move default BO destructor into VMWGFX v2 Signed-off-by: Kenjiro Nakayama --- drivers/gpu/drm/ttm/ttm_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

RE: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-24 Thread Zhang, Hawking
[AMD Official Use Only - General] Hi Aravind, Is it allowed to register multiple genl families per drm_device? Also, is it allowed to customize error type and even error counter (status)? SOC might integrate different type of controllers that report error in different types. Also, the

Re: [PATCH] drm/doc: describe PATH format for DP MST

2023-10-24 Thread Simon Ser
On Tuesday, October 24th, 2023 at 09:36, Pekka Paalanen wrote: > Are DP MST port numbers guaranteed to be tied to the physical hardware > configuration (e.g. how cables are connected) and therefore stable > across reboots? What about stable across kernel upgrades? > > If I knew that, I could

Re: [PATCH 14/18] drm/mediatek: dpi: add support for dpi clock

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 16:40, amerg...@baylibre.com ha scritto: From: Fabien Parent MT8365 requires an additional clock for DPI. Add support for that additional clock. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat I'm not convinced that this is right... at all. From a fast check of

Re: [PATCH 12/18] dt-bindings: pwm: add binding for mt8365 SoC

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 16:40, Alexandre Mergnat ha scritto: Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding along with MT8183 SoC. MT8365's Display PWM controller IP is the same as MT8183: blah blah blah :-) because saying that it is compatible doesn't mean that it is the

Re: [PATCH 15/18] drm/mediatek: add MT8365 SoC support

2023-10-24 Thread AngeloGioacchino Del Regno
Il 23/10/23 16:40, amerg...@baylibre.com ha scritto: From: Fabien Parent Add DRM support for MT8365 SoC. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

[PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node

2023-10-24 Thread Chen Ni
Add check for the return value of of_find_device_by_node() and return the error if it fails in order to avoid NULL pointer dereference. Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support") Signed-off-by: Chen Ni --- drivers/gpu/drm/tegra/dsi.c | 4 +++- 1 file changed, 3

Re: [RFC PATCH] drm/test: add a test suite for GEM objects backed by shmem

2023-10-24 Thread Maxime Ripard
Hi Marco, On Mon, Oct 23, 2023 at 06:45:40PM +0200, Marco Pagani wrote: > This patch introduces an initial KUnit test suite for GEM objects > backed by shmem buffers. > > Signed-off-by: Marco Pagani > --- > drivers/gpu/drm/Kconfig| 1 + > drivers/gpu/drm/tests/Makefile

Re: (subset) [PATCH] drm/vc4: fix typo

2023-10-24 Thread Maxime Ripard
On Mon, 23 Oct 2023 10:59:20 +0200, Dario Binacchi wrote: > Replace 'pack' with 'back'. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH] drm/doc: ci: Require more context for flaky tests

2023-10-24 Thread Maxime Ripard
On Fri, Oct 20, 2023 at 01:33:59AM -0300, Helen Koike wrote: > On 19/10/2023 13:51, Helen Koike wrote: > > On 19/10/2023 06:46, Maxime Ripard wrote: > > > Flaky tests can be very difficult to reproduce after the facts, which > > > will make it even harder to ever fix. > > > > > > Let's document

Re: [PATCH 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-10-24 Thread Maxime Ripard
Hi, On Thu, Oct 19, 2023 at 10:38:31AM +0200, Javier Martinez Canillas wrote: > Maxime Ripard writes: > > On Wed, Oct 11, 2023 at 04:38:07PM +0200, Thierry Reding wrote: > >> From: Thierry Reding > >> This contains two patches that bring simplefb up to feature parity with > >> simpledrm. The

Re: [PATCH] drm/doc: ci: Require more context for flaky tests

2023-10-24 Thread Maxime Ripard
On Thu, Oct 19, 2023 at 01:51:59PM -0300, Helen Koike wrote: > > > On 19/10/2023 06:46, Maxime Ripard wrote: > > Flaky tests can be very difficult to reproduce after the facts, which > > will make it even harder to ever fix. > > > > Let's document the metadata we agreed on to provide more

Re: [PATCH 03/18] dt-bindings: display: mediatek: color: add binding for MT8365 SoC

2023-10-24 Thread Alexandre Mergnat
On 24/10/2023 11:40, Chen-Yu Tsai wrote: On Mon, Oct 23, 2023 at 10:40 PM Alexandre Mergnat wrote: Display Color for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. This unfortunately doesn't match what the patch is doing. Yeah, I fixed it for v2.

[PATCH v2 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-24 Thread Imre Deak
Add helpers drivers can use to calculate the BW allocation overhead - due to SSC, FEC, DSC and data alignment on symbol cycles - and the channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On 128b/132b links the FEC overhead is part of the coding efficiency, so not accounted for in

[PATCH v2 07/29] drm/dp_mst: Add HBLANK expansion quirk for Synaptics MST hubs

2023-10-24 Thread Imre Deak
Add a quirk for Synaptics MST hubs, which require a workaround - at leat on i915 - for some modes, on which the hub applies HBLANK expansion. These modes will only work by enabling DSC decompression for them, a follow-up patch will do this in i915. v2: - Fix the quirk name in its docbook

Re: [PATCH] drm/doc: describe PATH format for DP MST

2023-10-24 Thread Pekka Paalanen
On Mon, 23 Oct 2023 20:36:39 + Simon Ser wrote: > This is already uAPI, xserver parses it. It's useful to document > since user-space might want to lookup the parent connector. > > Additionally, people (me included) have misunderstood the PATH > property for being stable across reboots, but

Re: [PATCH v10 13/24] drm/mediatek: Manage component's clock with function pointers

2023-10-24 Thread 胡俊光

Re: [PATCH v2 09/11] drm/mediatek: Add secure flow support to mediatek-drm

2023-10-24 Thread 胡俊光

RE: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required properties

2023-10-24 Thread Flavio Suligoi
Hi Conor, ... > On Mon, Oct 23, 2023 at 09:28:03AM +, Flavio Suligoi wrote: > > > On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote: > > > > The two properties: > > > > > > > > - max-brightness > > > > - default brightness > > > > > > > > are not really required, so they can be

Re: [PATCH] drm: Use device_get_match_data()

2023-10-24 Thread Andrew Jeffery
On Fri, 2023-10-20 at 07:52 -0500, Rob Herring wrote: > Use preferred device_get_match_data() instead of of_match_device() to > get the driver match data in a single step. With this, adjust the > includes to explicitly include the correct headers. That also serves as > preparation to remove

[PATCH] drm/ttm: Fix comment about return value of ttm_tt_init

2023-10-24 Thread Kenjiro Nakayama
ttm_tt_init returns -ENOMEM when out of memory. Signed-off-by: Kenjiro Nakayama --- include/drm/ttm/ttm_tt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h index a4eff85b1f44..243232be87b8 100644 ---

Re: [PATCH drm-misc-next v7 1/7] drm/gpuvm: convert WARN() to drm_WARN() variants

2023-10-24 Thread Danilo Krummrich
On 10/24/23 10:45, Christian König wrote: Am 23.10.23 um 22:16 schrieb Danilo Krummrich: Use drm_WARN() and drm_WARN_ON() variants to indicate drivers the context the failing VM resides in. Signed-off-by: Danilo Krummrich ---   drivers/gpu/drm/drm_gpuvm.c    | 32

Re: [Intel-gfx] [PATCH] drm/i915/gt: Use proper priority enum instead of 0

2023-10-24 Thread Andi Shyti
Hi Nirmoy, On Mon, Oct 23, 2023 at 02:13:05PM +0200, Nirmoy Das wrote: > I915_PRIORITY_NORMAL is 0 so use that instead for better > readability. > > Cc: John Harrison > Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Andi

Re: [PATCH] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full

2023-10-24 Thread Andy Yan
Hi: On 10/24/23 16:49, Christopher Obbard wrote: Hi Jonas, On Mon, 2023-10-23 at 21:11 +, Jonas Karlman wrote: Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328 and RK3399 result in wrong colors being displayed. The issue can be observed using modetest:   modetest

[PATCH] drm/vc4: tests: Fix UAF in the mock helpers

2023-10-24 Thread Maxime Ripard
The VC4 mock helpers allocate the CRTC, encoders and connectors using a call to kunit_kzalloc(), but the DRM device they are attache to survives for longer than the test itself which leads to use-after-frees reported by KASAN. Switch to drmm_kzalloc to tie the lifetime of these objects to the

Re: [PATCH v2 2/2] drm: introduce CLOSEFB IOCTL

2023-10-24 Thread Daniel Stone
On Fri, 20 Oct 2023 at 11:19, Simon Ser wrote: > This new IOCTL allows callers to close a framebuffer without > disabling planes or CRTCs. This takes inspiration from Rob Clark's > unref_fb IOCTL [1] and DRM_MODE_FB_PERSIST [2]. > > User-space patch for wlroots available at [3]. IGT test

[PATCH] drm: use correct name in comment

2023-10-24 Thread Kenjiro Nakayama
As drm_vma_node_is_allowed() searches @tag in the list, this patch corrects the comment. Signed-off-by: Kenjiro Nakayama --- drivers/gpu/drm/drm_vma_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_vma_manager.c

[PATCH] iosys-map: Rename locals used inside macros

2023-10-24 Thread Michał Winiarski
Widely used variable names can be used by macro users, potentially leading to name collisions. Suffix locals used inside the macros with an underscore, to reduce the collision potential. Suggested-by: Lucas De Marchi Signed-off-by: Michał Winiarski --- include/linux/iosys-map.h | 44

Re: linux-next: build failure after merge of the amdgpu tree

2023-10-24 Thread Alex Deucher
On Mon, Oct 23, 2023 at 8:59 PM Stephen Rothwell wrote: > > Hi all, > > On Thu, 19 Oct 2023 12:06:18 +1100 Stephen Rothwell > wrote: > > > > On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell > > wrote: > > > > > > After merging the amdgpu tree, today's linux-next build (x86_64 > > >

[PATCH v11 09/23] soc: mediatek: Support reset bit mapping in mmsys driver

2023-10-24 Thread Hsiao Chien Sung
- Reset ID must starts from 0 and be consecutive, but the reset bits in our hardware design is not continuous, some bits are left unused, we need a map to solve the problem - Use old style 1-to-1 mapping if .rst_tb is not defined Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao

[PATCH v11 18/23] drm/mediatek: Support MT8188 Padding in display driver

2023-10-24 Thread Hsiao Chien Sung
Padding is a new display module on MT8188, it provides ability to add pixels to width and height of a layer with specified colors. Due to hardware design, Mixer in VDOSYS1 requires width of a layer to be 2-pixel-align, or 4-pixel-align when ETHDR is enabled, we need Padding to deal with odd

[PATCH v11 14/23] drm/mediatek: Power on/off devices with function pointers

2023-10-24 Thread Hsiao Chien Sung
Different from OVL, OVL adaptor is a pseudo device so we didn't define it in the device tree, consequently, pm_runtime_resume_and_get() called by .atomic_enable() powers on no device. For this reason, we implement a function to power on the RDMAs in OVL adaptor, and the system will make sure the

[PATCH v11 11/23] drm/mediatek: Rename OVL_ADAPTOR_TYPE_RDMA

2023-10-24 Thread Hsiao Chien Sung
Rename OVL_ADAPTOR_TYPE_RDMA to OVL_ADAPTOR_TYPE_MDP_RDMA to align the naming rule of mtk_ovl_adaptor_comp_id. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 22 +-- 1 file

[PATCH v11 23/23] drm/mediatek: Support MT8188 VDOSYS1 in display driver

2023-10-24 Thread Hsiao Chien Sung
- The mmsys_dev_num in MT8188 VDOSYS0 was set to 1 since VDOSYS1 was not available before. Increase it to support VDOSYS1 in display driver. - Add compatible name for MT8188 VDOSYS1 (shares the same driver data with MT8195 VDOSYS1) Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm: docs: Remove item from TODO list

2023-10-24 Thread Maxime Ripard
Hi, On Mon, Oct 23, 2023 at 10:25:50AM -0700, Doug Anderson wrote: > On Mon, Oct 23, 2023 at 9:31 AM Yuran Pereira > wrote: > > > > Since "Clean up checks for already prepared/enabled in panels" has > > already been done and merged [1], I think there is no longer a need > > for this item to be

[PATCH v11 16/23] drm/mediatek: Sort OVL adaptor components

2023-10-24 Thread Hsiao Chien Sung
Sort OVL adaptor components' names in alphabetical order. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v11 07/23] soc: mediatek: Support MT8188 VDOSYS1 in mtk-mmsys

2023-10-24 Thread Hsiao Chien Sung
- Add register definitions for MT8188 - Add VDOSYS1 routing table - Update MUTEX definitions accordingly - Set VSYNC length from 0x40 (default) to 1 since ETHDR is bypassed Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 126

[PATCH v11 19/23] drm/mediatek: Add Padding to OVL adaptor

2023-10-24 Thread Hsiao Chien Sung
Add MT8188 Padding to OVL adaptor to probe the driver. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 26 +++ 1 file changed, 26 insertions(+) diff --git

[PATCH v11 08/23] soc: mediatek: Support MT8188 VDOSYS1 Padding in mtk-mmsys

2023-10-24 Thread Hsiao Chien Sung
- Add Padding components - Add Mutex module definitions for Padding Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-mutex.c | 16 include/linux/soc/mediatek/mtk-mmsys.h | 8 2 files changed, 24 insertions(+)

[PATCH v11 22/23] drm/mediatek: Fix underrun in VDO1 when switches off the layer

2023-10-24 Thread Hsiao Chien Sung
Do not reset Merge while using CMDQ because reset API doesn't wait for frame done event as CMDQ does and could lead to underrun when the layer is switching off. Fixes: aaf94f7c3ae6 ("drm/mediatek: Add display merge async reset control") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

[PATCH v11 03/23] dt-bindings: display: mediatek: merge: Add compatible for MT8188

2023-10-24 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 MERGE. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v11 00/23] Add display driver for MT8188 VDOSYS1

2023-10-24 Thread Hsiao Chien Sung
This series is based on mediatek-drm-next branch of kernel/git/chunkuang.hu/linux.git. Changes in v11: - Change "mtk-padding" to "mtk-disp-padding" for consistency - Remove patch "drm/mediatek: Remove ineffectual power management codes for backward compatibility Changes in v10: - Remove

[PATCH v11 01/23] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188

2023-10-24 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 ETHDR. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,ethdr.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH v11 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-24 Thread Hsiao Chien Sung
Padding is a new hardware module on MediaTek MT8188, add dt-bindings for it. Reviewed-by: Krzysztof Kozlowski Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- .../display/mediatek/mediatek,padding.yaml| 81 +++ 1 file

[PATCH v11 12/23] drm/mediatek: Add component ID to component match structure

2023-10-24 Thread Hsiao Chien Sung
Add component ID to component match structure so we can configure them with a for-loop. The main reason we do such code refactoring is that there is a new hardware component called "Padding" since MT8188, while MT8195 doesn't have this module, we can't use the original logic to manage the

[PATCH v11 13/23] drm/mediatek: Manage component's clock with function pointers

2023-10-24 Thread Hsiao Chien Sung
By registering component related functions to the pointers, we can easily manage them within a for-loop and simplify the logic of clock control significantly. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung ---

[PATCH v11 10/23] soc: mediatek: Add MT8188 VDOSYS reset bit map

2023-10-24 Thread Hsiao Chien Sung
Add MT8188 reset bit map for VDOSYS0 and VDOSYS1. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 84 + drivers/soc/mediatek/mtk-mmsys.c| 7 ++- 2 files changed, 90 insertions(+), 1 deletion(-)

  1   2   >