Re: [PATCH RESEND] drm/mediatek: Add 0 size check to mtk_drm_gem_obj

2024-03-19 Thread 胡俊光

[PATCH v2 05/14] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_hdmi" to "mtk_hdmi": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++--- 1 file changed, 7

[PATCH v2 01/14] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_crtc" to "mtk_crtc" due to the following benefits: - Lower the matches when searching the native drm_crtc* codes - Reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung ---

[PATCH v2 06/14] drm/mediatek: Rename files "mtk_drm_crtc.h" to "mtk_crtc.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.h to mtk_crtc.h. Reviewed-by: AngeloGiaocchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/{mtk_drm_crtc.h => mtk_crtc.h} | 0 drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +-

[PATCH v2 04/14] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_gem" to "mtk_gem": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +--

[PATCH v2 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.c to mtk_plane.c and modify the Makefile accordingly. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek/{mtk_drm_plane.c => mtk_plane.c} | 2 +- 2 files changed, 3

[PATCH v2 10/14] drm/mediatek: Rename files "mtk_drm_plane.h" to "mtk_plane.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.h to mtk_plane.h. Reviewed-by: AngeloGiaocchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h | 2 +-

[PATCH v2 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +++-

[PATCH v2 03/14] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_plane" to "mtk_plane": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 6 +++---

[PATCH v2 08/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.h" to "mtk_ddp_comp.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.h to mtk_ddp_comp.h. Reviewed-by: AngeloGiaocchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h | 2

[PATCH v2 12/14] drm/mediatek: Rename files "mtk_drm_gem.h" to "mtk_gem.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.h to mtk_gem.h. Reviewed-by: AngeloGiaocchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +-

[PATCH v2 07/14] drm/mediatek: Rename files "mtk_drm_crtc.c" to "mtk_crtc.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.c to mtk_crtc.c and modify the Makefile accordingly. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek/{mtk_drm_crtc.c => mtk_crtc.c} | 0 2 files changed, 2

[PATCH v2 14/14] drm/mediatek: Rename mtk_ddp_comp functions

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename functions of mtk_ddp_comp: - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 45 ++---

[PATCH v2 13/14] drm/mediatek: Rename files "mtk_drm_gem.c" to "mtk_gem.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.c to mtk_gem.c. Reviewed-by: AngeloGiaocchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 2 +- drivers/gpu/drm/mediatek/{mtk_drm_gem.c => mtk_gem.c} | 0 2 files changed, 1

[PATCH v2 09/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.c" to "mtk_ddp_comp.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.c to mtk_ddp_comp.c and modify the Makefile accordingly. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 2 +- drivers/gpu/drm/mediatek/{mtk_drm_ddp_comp.c => mtk_ddp_comp.c} | 0 2

[PATCH v2 00/14] Rename mtk_drm_* to mtk_*

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename some unnecessary "mtk_drm_*" to "mtk_*" because: - Lower the matches when searching the native drm_* codes - Reduce the code Changes in v2: - Sort header files alphabetically - Seperate patches for renaming .c files to avoid conflicts Hsiao Chien Sung (14):

Re: [PATCH v2 1/3] dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group

2024-03-19 Thread 胡俊光

Re: [PATCH v5 05/13] drm/mediatek: Set DRM mode configs accordingly

2024-03-19 Thread 宋孝謙

Re: [PATCH v2 3/3] drm/mediatek: Add gamma support for MT8195

2024-03-19 Thread 胡俊光

Re: [PATCH v2 2/3] dt-bindings: display: mediatek: gamma: Add support for MT8188

2024-03-19 Thread 胡俊光

Re: [PATCH v5 06/13] drm/mediatek: Turn off the layers with zero width or height

2024-03-19 Thread 宋孝謙

Re: [PATCH v2] drm,fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Neil Armstrong
Hi, On 19/03/2024 04:55, Li Zhijian wrote: Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to

[PATCH v4 12/12] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-19 Thread Thomas Zimmermann
Implement polling for VGA and SIL164 connectors. Set the flag DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the monitor cable. Implement struct drm_connector_helper_funcs.detect_ctx for each type of connector by testing for EDID data. The code for both types of connectors is

[PATCH v4 09/12] drm/ast: Rename struct i2c_algo_bit_data callbacks and their parameters

2024-03-19 Thread Thomas Zimmermann
Align the names of the algo-bit helpers with ast's convention of using an ast prefix plus the struct's name plus the callback's name for such function symbols. Change the parameter names of these helpers to 'data' and 'state', as used in the declaration of struct i2c_algo_bit_data. No functional

[PATCH v4 08/12] drm/ast: Store AST device in struct ast_ddc

2024-03-19 Thread Thomas Zimmermann
The DDC code needs the AST device. Store a pointer in struct ast_ddc and avoid internal upcasts. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_ddc.c | 10 +- drivers/gpu/drm/ast/ast_ddc.h | 4 ++-- 2 files changed, 7

[PATCH v4 06/12] drm/ast: Rename struct ast_i2c_chan to struct ast_ddc

2024-03-19 Thread Thomas Zimmermann
The struct struct ast_i2c_chan represents the Display Data Channel (DDC); I2C is the underlying bus. Rename the structure, the variables and the helper ast_i2c_create() to ddc-like terms. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_ddc.c | 71

[PATCH v3] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-19 Thread Roman Smirnov
The expression htotal * vtotal can have a zero value on overflow. It is necessary to prevent division by zero like in fb_var_to_videomode(). Found by Linux Verification Center (linuxtesting.org) with Svace. Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov --- V1 -> V2: Replaced the

[PATCH v4 07/12] drm/ast: Pass AST device to ast_ddc_create()

2024-03-19 Thread Thomas Zimmermann
The DDC code needs the AST device. Pass it to ast_ddc_create() and avoid an internal upcast. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_ddc.c | 3 ++- drivers/gpu/drm/ast/ast_ddc.h | 3 ++- drivers/gpu/drm/ast/ast_mode.c | 6 --

[PATCH v4 11/12] drm/ast: Use drm_connector_helper_get_modes()

2024-03-19 Thread Thomas Zimmermann
The .get_modes() code for VGA and SIL164 connectors does not depend on either type of connector. Replace the driver code with the common helper drm_connector_helper_get_modes(). It reads EDID data via DDC and updates the connector's EDID property. Signed-off-by: Thomas Zimmermann ---

[PATCH v4 04/12] drm/ast: Allocate instance of struct ast_i2c_chan with managed helpers

2024-03-19 Thread Thomas Zimmermann
Replace kzalloc() with drmm_kzalloc() and thereby put the release of the I2C instance into a separate action. Avoids explicit error roll- back in ast_i2c_chan_create(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_i2c.c | 9 ++--- 1 file changed, 2

[PATCH v4 03/12] drm/ast: Remove struct ast_{vga,sil165}_connector

2024-03-19 Thread Thomas Zimmermann
Both, struct ast_vga_connector and struct ast_sil164_connector, are now wrappers around struct drm_connector. Remove them. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson --- drivers/gpu/drm/ast/ast_drv.h | 24 ++-- drivers/gpu/drm/ast/ast_mode.c | 22

[PATCH v4 05/12] drm/ast: Move DDC code to ast_ddc.{c,h}

2024-03-19 Thread Thomas Zimmermann
Rename ast_i2c.c to ast_ddc.c and move its interface into the new header ast_ddc.h. Update all include statements as necessary and change the adapter name to 'AST DDC bus'. This avoids including I2C headers in the driver's main header file, which doesn't need them. Renaming files to _ddc

[PATCH v4 02/12] drm/ast: Fail probing if DDC channel could not be initialized

2024-03-19 Thread Thomas Zimmermann
Expect the hardware to provide a DDC channel. Fail probing if its initialization fails. Failing to initialize the DDC indicates a larger problem, so there's no point in continuing. v4: * give a rational in the commit message Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson

[PATCH v4 00/12] drm/ast: Detect connector status for VGA and SIL164

2024-03-19 Thread Thomas Zimmermann
(was: drm/ast: Connector cleanups and polling) Detect the status of the VGA or SIL164 conenctor by polling the DDC channel. Update the status at runtime and flip the BMC status as well. Patches 1 adds a missing include statement that will be required to make later patches compile. Patches 2 and

[PATCH v4 01/12] drm/ast: Include where necessary

2024-03-19 Thread Thomas Zimmermann
Include to get of_property_read_u32() in the source files that need it. Avoids the proxy include via . Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 1 + drivers/gpu/drm/ast/ast_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ast/ast_drv.c

[PATCH v4 10/12] drm/ast: Acquire I/O-register lock in DDC code

2024-03-19 Thread Thomas Zimmermann
The modeset lock protects the DDC code from concurrent modeset operations, which use the same registers. Move that code from the connector helpers into the DDC helpers .pre_xfer() and .post_xfer(). Both, .pre_xfer() and .post_xfer(), enclose the transfer of data blocks over the I2C channel in the

[PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-03-19 Thread Akhil R
Add support for Tegra Security Engine which can accelerate various crypto algorithms. The Engine has two separate instances within for AES and HASH algorithms respectively. The driver registers two crypto engines - one for AES and another for HASH algorithms and these operate independently and

[PATCH v6 2/5] gpu: host1x: Add Tegra SE to SID table

2024-03-19 Thread Akhil R
Add Tegra Security Engine details to the SID table in host1x driver. These entries are required to be in place to configure the stream ID for SE. Register writes to stream ID registers fail otherwise. Signed-off-by: Akhil R Acked-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 24

[PATCH v6 1/5] dt-bindings: crypto: Add Tegra Security Engine

2024-03-19 Thread Akhil R
Add DT binding document for Tegra Security Engine. The AES and HASH algorithms are handled independently by separate engines within the Security Engine. These engines are registered as two separate crypto engine drivers. Signed-off-by: Akhil R Reviewed-by: Krzysztof Kozlowski ---

Re: [PATCH v4 2/4] drm/bridge: add lvds controller support for sam9x7

2024-03-19 Thread Hari.PrasathGE
Hello Dharma, On 09/02/24 20:37, Dharma B - I70843 wrote: > Add a new LVDS controller driver for sam9x7 which does the following: > - Prepares and enables the LVDS Peripheral clock > - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself > to the global bridge list. > -

RE: about ArmChina NPU driver upstream

2024-03-19 Thread Dejia Shang
> -Original Message- > From: Arnd Bergmann > Sent: 2024年3月19日 15:28 > To: Dejia Shang ; Greg Kroah-Hartman > > Subject: Re: about ArmChina NPU driver upstream > > On Tue, Mar 19, 2024, at 05:09, Dejia Shang wrote: > > Dear Kernel Maintainers, > > > > I am a driver developer and plan to

Re: [PATCH v2] drm,fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Zhijian Li (Fujitsu)
On 19/03/2024 16:07, Neil Armstrong wrote: > Hi, > > On 19/03/2024 04:55, Li Zhijian wrote: >> Per filesystems/sysfs.rst, show() should only use sysfs_emit() >> or sysfs_emit_at() when formatting the value to be returned to user space. >> >> coccinelle complains that there are still a couple of

[RESEND v3 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-03-19 Thread Jani Nikula
Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST detect debug logging there. Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Do this regardless of whether we're actually enabling MST

[RESEND v3 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-03-19 Thread Jani Nikula
Clarify the conditions for choosing the MST mode to use by adding a new function intel_dp_mst_mode_choose(). This also prepares for being able to extend the MST modes to single-stream sideband messaging. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[RESEND v3 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-03-19 Thread Jani Nikula
Abstract the MST mode disconnect to a separate function. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

[RESEND v3 4/6] drm/i915/mst: use the MST mode detected previously

2024-03-19 Thread Jani Nikula
Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate logic for choosing MST mode, and store the chosen mode in struct intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() while at it. v2: Rebase on drm_dp_mst_detect() returning the mode, not bool Cc: Arun R

[RESEND v3 6/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-19 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, the topology manager should probably only set the sideband messaging related parts of the

[PATCH v3 0/2] drm: Add plane SIZE_HINTS property

2024-03-19 Thread Ville Syrjala
From: Ville Syrjälä Final final version I hope. Mainly for CI to test against the new IGTs. Real userspace implementation: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3165 IGT:

[PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank

2024-03-19 Thread Thomas Zimmermann
The field fb_blank in struct backlight_properties is deprecated and should not be used. Don't output its value in the driver's debug print. Signed-off-by: Thomas Zimmermann Reviewed-by: Dan Carpenter --- drivers/staging/fbtft/fb_ssd1351.c | 4 +--- drivers/staging/fbtft/fbtft-core.c | 5 ++---

[PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

2024-03-19 Thread Thomas Zimmermann
Remove the field fb_blank from struct backlight_properties and remove all code that still sets or reads it. Backlight blank status is now tracked exclusively in struct backlight_properties.state. The core backlight code keeps the fb_blank and state fields in sync, but doesn't do anything else

[PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank

2024-03-19 Thread Thomas Zimmermann
The field fb_blank in struct backlight_properties has been marked for removal. Remove it in favor of the power and state fields. Patches 1 to 5 prepare several backlight drivers. They remove fb_blank or replace driver code with existing helpers. Patch 6 removes fb_blank from backlight core and

[PATCH v2 1/6] auxdisplay: ht16k33: Replace use of fb_blank with backlight helper

2024-03-19 Thread Thomas Zimmermann
Replace the use of struct backlight_properties.fb_blank with a call to backlight_get_brightness(). The helper implements similar logic as the driver's function. It also accounts for BL_CORE_SUSPENDED for drivers that set BL_CORE_SUSPENDRESUME. Ht16k33 doesn't use this, so there's no change in

[PATCH v2 2/6] backlight: omap1: Remove unused struct omap_backlight_config.set_power

2024-03-19 Thread Thomas Zimmermann
The callback set_power in struct omap_backlight_config is not implemented anywhere. Remove it from the structure and driver. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Reviewed-by: Daniel Thompson Reviewed-by: Dan Carpenter --- v2: - update commit-message style according to

[PATCH v2 4/6] fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers

2024-03-19 Thread Thomas Zimmermann
Replace the use of struct backlight_properties.fb_blank with backlight helpers. This effects testing if the backlight is blanked and reading the backlight's brightness level. Signed-off-by: Thomas Zimmermann Reviewed-by: Dan Carpenter --- v2: - update commit-message style according to

[PATCH v2 3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off

2024-03-19 Thread Thomas Zimmermann
The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for any other value in fb_blank. But the field fb_blank in struct backlight_properties is deprecated and should not be used any longer. Replace the test for fb_blank in omap's backlight code with a simple boolean parameter and push the

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-19 Thread Maxime Ripard
On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: > On Mon, 11 Mar 2024, Mitul Golani > wrote: > > An Adaptive-Sync-capable DP protocol converter indicates its > > support by setting the related bit in the DPCD register. This > > is valid for DP and edp as well. > > > > Computes AS

Re: [RESEND v3 1/6] drm/mst: read sideband messaging cap

2024-03-19 Thread Maxime Ripard
On Tue, Mar 19, 2024 at 11:20:16AM +0200, Jani Nikula wrote: > On Tue, 19 Mar 2024, Jani Nikula wrote: > > Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST > > with sideband messaging", or "MST". Modify all call sites to take the > > new return value into account. > >

Re: [PATCH v4 12/12] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-19 Thread Thomas Zimmermann
Hi Am 19.03.24 um 10:37 schrieb Maxime Ripard: Hi, On Tue, Mar 19, 2024 at 09:00:32AM +0100, Thomas Zimmermann wrote: Implement polling for VGA and SIL164 connectors. Set the flag DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the monitor cable. Implement struct

[PATCH v2 3/4] arm64: dts: zynqmp: Add DMA for DP audio

2024-03-19 Thread Tomi Valkeinen
Add the two DMA channels used for the DisplayPort audio to the zynqmp_dpsub node. Signed-off-by: Tomi Valkeinen --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi

[PATCH] drm, fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Li Zhijian
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() and scnprintf() will be converted

[PATCH v2 4/4] drm: xlnx: zynqmp_dpsub: Add DP audio support

2024-03-19 Thread Tomi Valkeinen
Add basic DisplayPort audio support. Support non-live audio playback from two PCMs (DMA channels), and the volume control in the audio mixer. As older dtb files may not have the audio DMA channels defined, the driver will just mark the audio support as disabled if the audio DMA is missing, and

Re: [PATCH] drm,fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Zhijian Li (Fujitsu)
On 19/03/2024 11:43, Li Zhijian wrote: > diff --git > a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c > b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c > index 477789cff8e0..040a17a05baa 100644 > ---

[PATCH v6 0/5] Add Tegra Security Engine driver

2024-03-19 Thread Akhil R
Add support for Tegra Security Engine which can accelerates various crypto algorithms. The Engine has two separate instances within for AES and HASH algorithms respectively. The driver registers two crypto engines - one for AES and another for HASH algorithms and these operate independently and

[PATCH v2] drm, fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Li Zhijian
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() and scnprintf() will be converted

[PATCH v2 2/4] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs

2024-03-19 Thread Tomi Valkeinen
The DP subsystem for ZynqMP support audio via two channels, and the DP DMA has dma-engines for those channels. For some reason the DT binding has not specified those channels, even if the picture included in xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs. Add the two audio DMAs to the binding.

Re: drm/tiny: QUESTION: What to use instead of drm_simple_display_pipe ?

2024-03-19 Thread Thomas Zimmermann
Hi Am 18.03.24 um 20:18 schrieb Mehdi Djait: Hello everyone :) I am implementing a tiny drm driver and I am currently working on the V2: https://lore.kernel.org/dri-devel/cover.1701267411.git.mehdi.dj...@bootlin.com/ I got a review on the v1 telling me not to use the drm_simple_display_pipe.

Re: drm/tiny: QUESTION: What to use instead of drm_simple_display_pipe ?

2024-03-19 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Mehdi, > Hi > > Am 18.03.24 um 20:18 schrieb Mehdi Djait: >> Hello everyone :) >> >> I am implementing a tiny drm driver and I am currently working on the >> V2: >> https://lore.kernel.org/dri-devel/cover.1701267411.git.mehdi.dj...@bootlin.com/ >> >> I got a

[PATCH v3 1/2] drm: Introduce plane SIZE_HINTS property

2024-03-19 Thread Ville Syrjala
From: Ville Syrjälä Add a new immutable plane property by which a plane can advertise a handful of recommended plane sizes. This would be mostly exposed by cursor planes as a slightly more capable replacement for the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare a one size fits all

✗ Fi.CI.BAT: failure for drm: Add plane SIZE_HINTS property (rev6)

2024-03-19 Thread Patchwork
== Series Details == Series: drm: Add plane SIZE_HINTS property (rev6) URL : https://patchwork.freedesktop.org/series/113758/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_113758v6 Summary ---

Re: [PATCH v3 1/2] drm: Introduce plane SIZE_HINTS property

2024-03-19 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8 next-20240319] [If your patch is applied to the wrong git

[PATCH v3 2/2] drm/i915: Add SIZE_HINTS property for cursors

2024-03-19 Thread Ville Syrjala
From: Ville Syrjälä Advertize more suitable cursor sizes via the new SIZE_HINTS plane property. We can't really enumerate all supported cursor sizes on the platforms where the cursor height can vary freely, so for simplicity we'll just expose all square+POT sizes between each platform's min and

✗ Fi.CI.SPARSE: warning for drm: Add plane SIZE_HINTS property (rev6)

2024-03-19 Thread Patchwork
== Series Details == Series: drm: Add plane SIZE_HINTS property (rev6) URL : https://patchwork.freedesktop.org/series/113758/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [RESEND v3 1/6] drm/mst: read sideband messaging cap

2024-03-19 Thread Jani Nikula
On Tue, 19 Mar 2024, Jani Nikula wrote: > Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST > with sideband messaging", or "MST". Modify all call sites to take the > new return value into account. drm-misc and nouveau maintainers, ack for merging this via drm-intel, please?

[PATCH v3] video: fbdev: panel-tpo-td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Li Zhijian
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() and scnprintf() will be converted

[PATCH v3] drm/panel: tpo-td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-19 Thread Li Zhijian
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() and scnprintf() will be converted

Re: [PATCH v4 12/12] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-19 Thread Maxime Ripard
Hi, On Tue, Mar 19, 2024 at 09:00:32AM +0100, Thomas Zimmermann wrote: > Implement polling for VGA and SIL164 connectors. Set the flag > DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the > monitor cable. Implement struct drm_connector_helper_funcs.detect_ctx > for each type of

Re: [PATCH v2] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-19 Thread Roman Smirnov
On Mon, 18 Mar 2024 20:15:55 +0100 Helge Deller wrote: > On 3/18/24 09:11, Roman Smirnov wrote: > > On Fri, 15 Mar 2024 09:44:08 +0100 Helge Deller wrote: > > > On 3/5/24 14:51, Roman Smirnov wrote: > > > > The expression htotal * vtotal can have a zero value on > > > > overflow. > > > > > > I'm

[PATCH v2 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-19 Thread Tomi Valkeinen
Add DisplayPort audio support for Xilinx ZynqMP platforms. This depends on patch adding cyclic DMA mode for DPDMA driver: https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ If that patch is missing, starting an audio playback will fail with an ASoC error. The current DT

[PATCH v2 1/4] ASoC: dmaengine_pcm: Allow passing component name via config

2024-03-19 Thread Tomi Valkeinen
At the moment we cannot instantiate two dmaengine_pcms with the same parent device, as the components will be named the same, leading to conflicts. Add 'name' field to the snd_dmaengine_pcm_config, and use that (if defined) as the component name instead of deriving the component name from the

[PATCH v6 5/5] arm64: tegra: Add Tegra Security Engine DT nodes

2024-03-19 Thread Akhil R
Add device tree nodes for Tegra AES and HASH engines. Signed-off-by: Akhil R --- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi index

[PATCH v6 4/5] arm64: defconfig: Enable Tegra Security Engine

2024-03-19 Thread Akhil R
Enable Tegra Security Engine which can accelerate various AES and HASH algorithms on supported hardware. Signed-off-by: Akhil R --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

Re: [PATCH v2] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-19 Thread Sergey Shtylyov
On 3/19/24 11:12 AM, Roman Smirnov wrote: [...] On 3/5/24 14:51, Roman Smirnov wrote: > The expression htotal * vtotal can have a zero value on > overflow. I'm not sure if those always results in zero in kernel on overflow. Might be architecture-depended too, but let's

[RESEND v3 0/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-19 Thread Jani Nikula
Resend because I forgot to Cc: dri-devel on the original submission. Jani Nikula (6): drm/mst: read sideband messaging cap drm/i915/mst: improve debug logging of DP MST mode detect drm/i915/mst: abstract choosing the MST mode to use drm/i915/mst: use the MST mode detected previously

[RESEND v3 1/6] drm/mst: read sideband messaging cap

2024-03-19 Thread Jani Nikula
Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. v2: - Rename enumerators (Ville) Cc: Arun R Murthy Cc: Ville Syrjälä Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich

Re: [PATCH v3 0/2] drm: Add plane SIZE_HINTS property

2024-03-19 Thread Ville Syrjälä
On Mon, Mar 18, 2024 at 10:44:06PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Final final version I hope. Mainly for CI to test against the > new IGTs. > > Real userspace implementation: > https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3165 >

Re: [PATCH v4 12/12] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-19 Thread Jani Nikula
On Tue, 19 Mar 2024, Thomas Zimmermann wrote: > Hi > > Am 19.03.24 um 10:37 schrieb Maxime Ripard: >> Hi, >> >> On Tue, Mar 19, 2024 at 09:00:32AM +0100, Thomas Zimmermann wrote: >>> Implement polling for VGA and SIL164 connectors. Set the flag >>> DRM_CONNECTOR_POLL_DISCONNECT for each to detect

Re: [PATCH v4 12/12] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-19 Thread Jani Nikula
On Tue, 19 Mar 2024, Jani Nikula wrote: > On Tue, 19 Mar 2024, Thomas Zimmermann wrote: >> Hi >> >> Am 19.03.24 um 10:37 schrieb Maxime Ripard: >>> Hi, >>> >>> On Tue, Mar 19, 2024 at 09:00:32AM +0100, Thomas Zimmermann wrote: Implement polling for VGA and SIL164 connectors. Set the flag

Re: [PATCH v9 20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-19 Thread Maxime Ripard
On Mon, Mar 18, 2024 at 06:11:30PM +0200, Ville Syrjälä wrote: > On Mon, Mar 18, 2024 at 02:49:47PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Fri, Mar 15, 2024 at 10:22:05AM +0200, Ville Syrjälä wrote: > > > On Mon, Mar 11, 2024 at 03:49:48PM +0100, Maxime Ripard wrote: > > > > Infoframes in

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Christian König
Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which

Re: [PATCH v2 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-19 Thread AngeloGioacchino Del Regno
Il 19/03/24 08:02, Shawn Sung ha scritto: From: Hsiao Chien Sung Rename files mtk_drm_plane.c to mtk_plane.c and modify the Makefile accordingly. Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno

Re: [RESEND v3 1/6] drm/mst: read sideband messaging cap

2024-03-19 Thread Danilo Krummrich
On 3/19/24 10:12, Jani Nikula wrote: Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. v2: - Rename enumerators (Ville) Cc: Arun R Murthy Cc: Ville Syrjälä Cc: Karol

Re: [PATCH v2 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-19 Thread AngeloGioacchino Del Regno
Il 19/03/24 08:02, Shawn Sung ha scritto: From: Hsiao Chien Sung Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Shawn, I don't know if I typoed my own name (which is actually possible, since I

Re: [PATCH v4 12/12] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-19 Thread Thomas Zimmermann
Hi Am 19.03.24 um 11:08 schrieb Jani Nikula: On Tue, 19 Mar 2024, Thomas Zimmermann wrote: Hi Am 19.03.24 um 10:37 schrieb Maxime Ripard: Hi, On Tue, Mar 19, 2024 at 09:00:32AM +0100, Thomas Zimmermann wrote: Implement polling for VGA and SIL164 connectors. Set the flag

Re: [RESEND v3 1/6] drm/mst: read sideband messaging cap

2024-03-19 Thread Danilo Krummrich
On 3/19/24 10:20, Jani Nikula wrote: On Tue, 19 Mar 2024, Jani Nikula wrote: Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. drm-misc and nouveau maintainers, ack for

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Lazar, Lijo
On 3/19/2024 6:02 PM, Sunil Khatri wrote: > Refactor the code so debugfs and devcoredump can reuse > the common information and avoid unnecessary copy of it. > > created a new file which would be the right place to > hold functions which will be used between sysfs, debugfs > and devcoredump. >

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-19 Thread Huacai Chen
Hi, Jaak, On Mon, Mar 18, 2024 at 11:42 PM Jaak Ristioja wrote: > > Hi Huacai, > > Uh, no, sorry, I did not get to test such changes. From what Thomas > wrote I presumed that this got fixed and no further action would be > required. > > To speed things up I would appreciate it if you provided a

Re: [PATCH v2] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-19 Thread Melissa Wen
On 03/17, Maíra Canal wrote: > Hi Melissa, > > On 3/17/24 14:50, Melissa Wen wrote: > > On 03/16, Arthur Grillo wrote: > > > As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > > > To round a number, you need to add 0.5 to the number and floor that, > > >

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used

RE: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
[AMD Official Use Only - General] Ignore this as I have send v3. -Original Message- From: Sunil Khatri Sent: Tuesday, March 19, 2024 8:41 PM To: Deucher, Alexander ; Koenig, Christian ; Sharma, Shashank Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Christian König
Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):    - Dont handle clear page as TTM flag since when moving

  1   2   3   >