RE: linux-next: build warnings after merge of the drm-intel tree

2024-04-05 Thread Golani, Mitulkumar Ajitkumar
Hi, Thanks @Stephen Rothwell. I corrected the documentation and sent a patch with fixes. https://patchwork.freedesktop.org/series/132061/ Regards, Mitul > -Original Message- > From: Stephen Rothwell > Sent: Friday, April 5, 2024 8:47 AM > To: Daniel Vetter ; Jani Nikula > ; Joonas

Re: [PATCH 6/7] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-04-05 Thread Thomas Zimmermann
Hi Am 05.04.24 um 09:09 schrieb Jani Nikula: On Thu, 04 Apr 2024, Thomas Zimmermann wrote: Provide separate implementations of .get_modes() and .detect_ctx() from struct drm_connector. Switch to struct drm_edid. Udl's .detect() helper used to fetch the EDID from the adapter and the

Re: [PATCH 11/12] drm/client: Streamline mode selection debugs

2024-04-05 Thread Thomas Zimmermann
Hi Am 04.04.24 um 22:33 schrieb Ville Syrjala: From: Ville Syrjälä Get rid of all the redundant debugs and just wait until the end to print which mode (and of which type) we picked. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_client_modeset.c | 65 +--- 1

Re: [PATCH 12/12] drm/probe-helper: Switch to per-device debugs

2024-04-05 Thread Jani Nikula
On Thu, 04 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Switch to per-device debugs so that we know which > device we're dealing with. Again see the first handful of patches in the series [1]. It cleans up the mode printing as well. BR, Jani. [1]

Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-04-05 at 10:59 +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.24 um 10:34 schrieb Hogander, Jouni: > [...] > > >   > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > > b/drivers/gpu/drm/i915/i915_driver.c > > > index e0f13c62a1832..69178b73845e1 100644 > > > ---

Re: [PATCH v13 2/8] mm/gup: Introduce check_and_migrate_movable_folios()

2024-04-05 Thread David Hildenbrand
On 04.04.24 09:26, Vivek Kasireddy wrote: This helper is the folio equivalent of check_and_migrate_movable_pages(). Therefore, all the rules that apply to check_and_migrate_movable_pages() also apply to this one as well. Currently, this helper is only used by memfd_pin_folios(). This patch also

[PATCH] drm/dp: correct struct member name in documentation

2024-04-05 Thread Mitul Golani
Correct struct member name to 'mode' instead of 'operation mode' in 'drm_dp_as_sdp' structure description. Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Jani Nikula Signed-off-by: Mitul Golani --- include/drm/display/drm_dp_helper.h | 2

Re: [PATCH 10/12] drm/client: Use [CONNECTOR:%d:%s] formatting

2024-04-05 Thread Jani Nikula
On Thu, 04 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Switch to the canonical [CONNECTOR:%d:%s] etc. format for > printing out kms objects. I've been pinging for reviews on [1] for a while now. :/ I'm just doing what you do in patches 9-10 in one go, and I very much prefer having

Re: [PATCH 6/7] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-04-05 Thread Jani Nikula
On Thu, 04 Apr 2024, Thomas Zimmermann wrote: > Provide separate implementations of .get_modes() and .detect_ctx() > from struct drm_connector. Switch to struct drm_edid. > > Udl's .detect() helper used to fetch the EDID from the adapter and the > .get_modes() helper provided display modes from

Re: [PATCH v2 10/25] crypto: virtio - drop owner assignment

2024-04-05 Thread Herbert Xu
On Sun, Mar 31, 2024 at 10:43:57AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Depends on the first patch. > --- > drivers/crypto/virtio/virtio_crypto_core.c | 1 - > 1 file changed, 1

Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-03-01 at 14:42 +0100, Thomas Zimmermann wrote: > Replace all code that initializes or releases fbdev emulation > throughout the driver. Instead initialize the fbdev client by a > single call to intel_fbdev_setup() after i915 has registered its > DRM device. Just like similar code in

Re: [PATCH 1/6] drm/modes: add drm_mode_print() to dump mode in drm_printer

2024-04-05 Thread Thomas Zimmermann
Hi Am 07.03.24 um 21:39 schrieb Jani Nikula: Add a printer based function for dumping the modeline, so it's not limited to KMS debug. Note: The printed output intentionally does not have the "Modeline" prefix. Prefix, if any, is for the caller to decide when initializing drm_printer.

[PATCH] drm/msm: convert all pixel format logging to use %p4cc

2024-04-05 Thread Jani Nikula
Logging u32 pixel formats using %4.4s format string with a pointer to the u32 is somewhat questionable, as well as dependent on byte order. There's a kernel extension format specifier %p4cc to format 4cc codes. Use it across the board in msm for pixel format logging. This should also fix the

Re: [PATCH 2/7] drm/edid: Test for EDID header in drm_edit_probe_custom()

2024-04-05 Thread Thomas Zimmermann
Hi Am 05.04.24 um 08:38 schrieb Jani Nikula: On Thu, 04 Apr 2024, Thomas Zimmermann wrote: EDID read functions do not validate their return data. So they might return the required number of bytes of probing, but with invalid data. Therefore test for the presence of an EDID header similar to

Re: [PATCH] drm/dp: correct struct member name in documentation

2024-04-05 Thread Stephen Rothwell
Hi Mitul, Thanks. On Fri, 5 Apr 2024 12:21:59 +0530 Mitul Golani wrote: > > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Reported-by: Stephen Rothwell > Cc:

Re: [PATCH 0/6] drm: debug logging improvements

2024-04-05 Thread Thomas Zimmermann
Hi, with your Oops on [5/6] fixed and my comment on [1/6] considered: Reviewed-by: Thomas Zimmermann Best regards Thomas Am 07.03.24 um 21:39 schrieb Jani Nikula: Switch a handful of places over to drm device based logging and WARNs, unify connector and crtc logging, etc. Jani Nikula (6):

Re: [PATCH 0/6] drm: enable W=1 warnings by default across the subsystem

2024-04-05 Thread Aishwarya TCV
eport. I can't reproduce this myself, but please see if > [1] fixes the issue. > > > BR, > Jani. > > [1] > https://lore.kernel.org/dri-devel/20240405092907.2334007-1-jani.nik...@intel.com > > Thanks, as expected this fixes the issue. Tested the attached patch by building the modules with "defconfig+kselftest-ftrace" against next-20240405 kernel with Arm64. Tested-by: Aishwarya TCV

Re: [PATCH 07/12] drm/client: Use array notation for function arguments

2024-04-05 Thread Thomas Zimmermann
Hi Am 04.04.24 um 22:33 schrieb Ville Syrjala: From: Ville Syrjälä Use the array notation rather that the pointer notation for function arguments. This makes it clear to the reader that we are in fact dealing with an array rather than a single pointer. Functionally the two are equivalent.

Re: [PATCH 00/12] drm/client: Use after free and debug improvements

2024-04-05 Thread Thomas Zimmermann
Hi Reviewed-by: Thomas Zimmermann for the whole series. Best regards Thomas Am 04.04.24 um 22:33 schrieb Ville Syrjala: From: Ville Syrjälä Various improvements to the drm/client code: - Fix a use after free (fairly routinely hit by i915 CI) - Debug print improvements - Cleanups/etc.

Re: [PATCH v7 5/6] drm/i915: Implement fbdev client callbacks

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-03-01 at 14:42 +0100, Thomas Zimmermann wrote: > Move code from ad-hoc fbdev callbacks into DRM client functions > and remove the old callbacks. The functions instruct the client > to poll for changed output or restore the display. > > The DRM core calls both, the old callbacks and

Re: [PATCH 12/12] drm/probe-helper: Switch to per-device debugs

2024-04-05 Thread Thomas Zimmermann
Hi Am 05.04.24 um 10:25 schrieb Jani Nikula: On Thu, 04 Apr 2024, Ville Syrjala wrote: From: Ville Syrjälä Switch to per-device debugs so that we know which device we're dealing with. Again see the first handful of patches in the series [1]. It cleans up the mode printing as well. This

[PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-05 Thread Konrad Dybcio
Introduce getters for SoC product and feature codes and export them. Signed-off-by: Konrad Dybcio --- drivers/soc/qcom/smem.c | 66 +++ include/linux/soc/qcom/smem.h | 2 ++ 2 files changed, 68 insertions(+) diff --git a/drivers/soc/qcom/smem.c

[PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-05 Thread Konrad Dybcio
On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted through SMEM, instead of being directly available in a fuse. Add support for SMEM-based speed binning, which includes getting "feature code" and "product code" from said source and parsing them to form something that

[PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-04-05 Thread Konrad Dybcio
Add speebin data for A740, as found on SM8550 and derivative SoCs. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c

[PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-05 Thread Konrad Dybcio
In preparation for parsing the chip "feature code" (FC) and "product code" (PC) (essentially the parameters that let us conclusively characterize the sillicon we're running on, including various speed bins), move the socinfo version defines to the public header and include some more FC/PC defines.

[PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-05 Thread Konrad Dybcio
From: Neil Armstrong Usually, speedbin 0 is the "super SKU", a.k.a the one which can clock the highest. Falling back to it when things go wrong is largely suboptimal, as more often than not, the top frequencies are not supposed to work on other bins. Let the developer specify the intended

[PATCH 0/6] Add SMEM-based speedbin matching

2024-04-05 Thread Konrad Dybcio
Newer (SM8550+) SoCs don't seem to have a nice speedbin fuse anymore, but instead rely on a set of combinations of "feature code" (FC) and "product code" (PC) identifiers to match the bins. This series adds support for that. I suppose a qcom/for-soc immutable branch would be in order if we want

Re: [PATCH v13 1/8] mm/gup: Introduce unpin_folio/unpin_folios helpers

2024-04-05 Thread David Hildenbrand
On 04.04.24 09:26, Vivek Kasireddy wrote: These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find new uses in the future, when more and more

Re: [PATCH 4.19.y] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-05 Thread Greg KH
On Wed, Apr 03, 2024 at 05:47:16PM +0800, Guo Mengqi wrote: > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > in nonblocking commits") introduced drm_dev_get/put() to > drm_atomic_helper_shutdown(). And this cause problem in vkms driver exit > process. > > vkms_exit() >

Re: [PATCH 2/7] drm/edid: Test for EDID header in drm_edit_probe_custom()

2024-04-05 Thread Jani Nikula
On Thu, 04 Apr 2024, Thomas Zimmermann wrote: > EDID read functions do not validate their return data. So they might > return the required number of bytes of probing, but with invalid > data. Therefore test for the presence of an EDID header similar to > the code in edid_block_check(). I don't

Re: [PATCH 7/7] drm/udl: Remove struct udl_connector

2024-04-05 Thread Dan Carpenter
://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20240404150857.5520-8-tzimmermann%40suse.de patch subject: [PATCH 7/7] drm/udl: Remove struct udl_connector config: parisc-randconfig-r071-20240405 (https://download.01.org/0day-ci/archive/20240405

Re: [PATCH 06/12] drm/client: Constify modes

2024-04-05 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.9-rc2 next-20240405] [If your patch is applied to the wrong

Re: [PATCH 11/12] drm/client: Streamline mode selection debugs

2024-04-05 Thread Thomas Zimmermann
Hi this patch should probably go before [09/12]. Best regards Thomas Am 04.04.24 um 22:33 schrieb Ville Syrjala: From: Ville Syrjälä Get rid of all the redundant debugs and just wait until the end to print which mode (and of which type) we picked. Signed-off-by: Ville Syrjälä ---

[PATCH 6/6] arm64: dts: qcom: sm8550: Wire up GPU speed bin & more OPPs

2024-04-05 Thread Konrad Dybcio
Add the speedbin masks to ensure only the desired OPPs are available on chips of a given bin. Using this, add the binned 719 MHz OPP and the non-binned 124.8 MHz. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 21 - 1 file changed, 20 insertions(+),

Re: [PATCH v3 0/3] arch: Remove fbdev dependency from video helpers

2024-04-05 Thread Thomas Zimmermann
Hi, if there are no further comments, can this series be merged through asm-generic? Best regards Thomas Am 29.03.24 um 21:32 schrieb Thomas Zimmermann: Make architecture helpers for display functionality depend on general video functionality instead of fbdev. This avoids the dependency on

Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-05 Thread Wolfram Sang
Hello Easwar, On Fri, Mar 29, 2024 at 05:00:24PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of the >

Re: [PATCH] drm/dp: correct struct member name in documentation

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > Cc: Mitul Golani > Cc: Ankit Nautiyal > Cc: Jani

Re: [PATCH v2] drm/ast: Fix soft lockup

2024-04-05 Thread Thomas Zimmermann
Hi, I've added a Fixes tag and pushed to patch into drm-misc-fixes. Best regards Thomas Am 03.04.24 um 11:02 schrieb Jammy Huang: There is a while-loop in ast_dp_set_on_off() that could lead to infinite-loop. This is because the register, VGACRI-Dx, checked in this API is a scratch register

Re: [PATCH 08/12] drm/client: Extract drm_connector_first_mode()

2024-04-05 Thread Jani Nikula
On Thu, 04 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Use a consistent method for picking the first mode from the > connnector's mode list. Patches 1-8 inclusive are Reviewed-by: Jani Nikula > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_client_modeset.c | 17

Re: [PATCH v12 2/7] clk: meson: add vclk driver

2024-04-05 Thread Jerome Brunet
On Thu 04 Apr 2024 at 18:59, Neil Armstrong wrote: > On 04/04/2024 10:13, Jerome Brunet wrote: >> On Wed 03 Apr 2024 at 09:46, Neil Armstrong >> wrote: >> >>> The VCLK and VCLK_DIV clocks have supplementary bits. >>> >>> The VCLK gate has a "SOFT RESET" bit to toggle after the whole >>> VCLK

Re: [PATCH v7 4/6] drm/i915: Initialize fbdev DRM client with callback functions

2024-04-05 Thread Hogander, Jouni
On Fri, 2024-03-01 at 14:42 +0100, Thomas Zimmermann wrote: > Initialize i915's fbdev client by giving an instance of struct > drm_client_funcs to drm_client_init(). Also clean up with > drm_client_release(). > > Doing this in i915 prevents fbdev helpers from initializing and > releasing the

Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

2024-04-05 Thread Thomas Zimmermann
Hi Am 05.04.24 um 10:34 schrieb Hogander, Jouni: [...] diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index e0f13c62a1832..69178b73845e1 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -816,6 +816,8 @@ int

Re: [PATCH 0/6] drm: enable W=1 warnings by default across the subsystem

2024-04-05 Thread Jani Nikula
On Thu, 04 Apr 2024, Aishwarya TCV wrote: > Observed warning "include/drm/drm_print.h:536:35: warning: '%4.4s' > directive argument is null [-Wformat-overflow=]" when building the > modules with "defconfig+kselftest-ftrace"( >

Re: [PATCH v3 4/9] drm: xlnx: zynqmp_dpsub: Anounce supported input formats

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: DPSUB in bridge mode supports multiple input media bus formats. Announce the list of supported input media bus formats via drm_bridge.atomic_get_input_bus_fmts callback. Introduce a set of live input formats, supported by DPSUB. Rename

Re: [rebase 1/3] drm: Add drm_vblank_work_flush_all().

2024-04-05 Thread Lucas De Marchi
what does "rebase" instead of "PATCH" is supposed to mean here? And then we have a "PATCH v2" as reply to this one. Shouldn't this go to dri-devel (too)? Lucas De Marchi On Thu, Apr 04, 2024 at 12:48:11PM +0200, Maarten Lankhorst wrote: From: Maarten Lankhorst In some cases we want to flush

Re: [RESEND v7 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Thanks for the update! > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml > + compatible: > +oneOf: As adding more SoCs is expected, having oneOf from the start

Re: [PATCH 3/8] accel/ivpu: Fix PCI D0 state entry in resume

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" In case of failed power up we end up left in PCI D3hot state making it impossible to access NPU registers on retry. Enter D0 state on retry before proceeding with power up sequence. Fixes: 28083ff18d3f ("accel/ivpu: Fix

Re: [linux-next:master] BUILD REGRESSION 8568bb2ccc278f344e6ac44af6ed010a90aa88dc

2024-04-05 Thread Alexei Starovoitov
On Fri, Apr 5, 2024 at 8:37 AM kernel test robot wrote: > > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc Add linux-next > specific files for 20240405 > > Error/Warni

Re: [PATCH v2 0/3] accel/qaic: Add debugfs entries

2024-04-05 Thread Jeffrey Hugo
On 3/22/2024 11:57 AM, Jeffrey Hugo wrote: Add 3 debugfs entries that can be useful in debugging a variety of issues. bootlog - output the device bootloader log fifo_size - output the configured dbc fifo size queued - output how many requests are queued in the dbc fifo Bootlog is unique to

Re: [RESEND v7 14/37] clk: Compatible with narrow registers

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > divider and gate only support 32-bit registers. > Older hardware uses narrower registers, so I want to be able to handle > 8-bit and 16-bit wide registers. > > Seven clk_divider flags are used, and if I add flags for 8bit access

Re: (subset) [PATCH 1/7] drm/display: Select DRM_KMS_HELPER for DP helpers

2024-04-05 Thread Maxime Ripard
On Wed, 03 Apr 2024 12:56:19 +0200, Maxime Ripard wrote: > The DisplayPort helpers rely on some > (__drm_atomic_helper_private_obj_duplicate_state, > drm_kms_helper_hotplug_event) helpers found in files compiled by > DRM_KMS_HELPER. > > Prior to commit d674858ff979 ("drm/display: Make all helpers

Re: (subset) [PATCH 2/7] drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable

2024-04-05 Thread Maxime Ripard
On Wed, 03 Apr 2024 12:56:20 +0200, Maxime Ripard wrote: > Commit c0e0f139354c ("drm: Make drivers depends on DRM_DW_HDMI") turned > select dependencies into depends on ones. However, DRM_DW_HDMI was not > manually selectable which resulted in no way to enable the drivers that > were now depending

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-04-05 Thread Matthew Auld
On 01/04/2024 12:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/28/2024 10:18 PM, Matthew Auld wrote: On 28/03/2024 16:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking

[PATCH 1/1] vgacon: add HAS_IOPORT dependencies

2024-04-05 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle --- Note: This patch does not depend any

[PATCH 0/1] vgacon: Handle HAS_IOPORT dependencies

2024-04-05 Thread Niklas Schnelle
Hi Greg, Helge, This is a follow up in my ongoing effort of making inb()/outb() and similar I/O port accessors compile-time optional. Previously I sent this as a treewide series titled "treewide: Remove I/O port accessors for HAS_IOPORT=n" with the latest being its 5th version[0]. With a

Re: [PATCH v3 3/9] drm: xlnx: zynqmp_dpsub: Add connected live layer helper

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: Add a helper function capturing the first connected live display layer discovery logic. Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 37 +++-- 1 file changed, 23 insertions(+), 14

Re: [RESEND v7 09/37] dt-binding: Add compatible SH7750 SoC

2024-04-05 Thread Geert Uytterhoeven
On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical

[PULL] drm-misc-next

2024-04-05 Thread Maarten Lankhorst
Hi Dave, Sima, Everyone seems to be out on vacation, so the pull request is pretty empty. Cheers, ~Maarten drm-misc-next-2024-04-05: drm-misc-next for v6.10: Core Changes: - Fix DRM_DISPLAY_DP_HELPER dependencies. Driver Changes: - i2c and polling fixes to ast. - Small fixes to panthor. -

[syzbot] Monthly dri report (Apr 2024)

2024-04-05 Thread syzbot
Hello dri maintainers/developers, This is a 31-day syzbot report for the dri subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/dri During the period, 0 new issues were detected and 0 were fixed. In total, 19 issues are still open and 31 have

Re: [PATCH 2/8] drm/ttm: Use LRU hitches

2024-04-05 Thread Christian König
Am 29.03.24 um 15:57 schrieb Thomas Hellström: Have iterators insert themselves into the list they are iterating over using hitch list nodes. Since only the iterator owner can remove these list nodes from the list, it's safe to unlock the list and when continuing, use them as a starting point.

Re: [RESEND v7 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header.

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, Thanks for the update! On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > > SH7750 CPG Clock output define. (from my comments on v6) Please improve the patch description. > Signed-off-by: Yoshinori Sato > index ..04c10b0834ee > --- /dev/null > +++

[PATCH] drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2

2024-04-05 Thread Arnd Bergmann
From: Arnd Bergmann After my fix yesterday, I ran into another problem of the same kind: aarch64-linux-ld: drivers/gpu/drm/bridge/analogix/analogix_dp_core.o: in function `drm_dp_dpcd_readb': analogix_dp_core.c:(.text+0x194): undefined reference to `drm_dp_dpcd_read' aarch64-linux-ld:

Re: [PATCH 1/8] accel/ivpu: Check return code of ipc->lock init

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" Return value of drmm_mutex_init(ipc->lock) was unchecked. Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") Cc: # v6.3+ Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz Reviewed-by:

Re: [PATCH 7/8] accel/ivpu: Fix missed error message after VPU rename

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: Change "VPU" to "NPU" in ivpu_suspend() so it matches all other error messages. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/1] vgacon: add HAS_IOPORT dependencies

2024-04-05 Thread Arnd Bergmann
On Fri, Apr 5, 2024, at 17:43, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at > compile time. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann >

Re: [PATCH v3 1/9] drm: xlnx: zynqmp_dpsub: Set layer mode during creation

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: Set layer mode of operation (live or dma-based) during layer creation. Each DPSUB layer mode of operation is defined by corresponding DT node port connection, so it is possible to assign it during layer object creation. Previously it was set in

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-05 Thread Jason Gunthorpe
On Fri, Apr 05, 2024 at 03:33:10AM +, Zeng, Oak wrote: > > > > I didn't look at this series a lot but I wanted to make a few > > remarks.. This I don't like quite a lot. Yes, the DMA API interaction > > with hmm_range_fault is pretty bad, but it should not be hacked > > around like this. Leon

Re: [RESEND v7 33/37] sh: j2_mimas_v2.dts update

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, On Thu, Apr 4, 2024 at 7:16 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato >From my comments for v6: Please enhance the one-line summary, e.g. sh: j2_mimas_v2: Update CPU compatible value For the actual changes: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [Intel-gfx] [PATCH v5 0/7] Introduce __xchg, non-atomic xchg

2024-04-05 Thread Jani Nikula
On Mon, 27 Feb 2023, Peter Zijlstra wrote: > On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote: >> On 22.02.2023 18:04, Peter Zijlstra wrote: >> > On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote: >> > >> > > Andrzej Hajda (7): >> > >arch: rename all internal names

[PATCH v2] drm/vmwgfx: Don't memcmp equivalent pointers

2024-04-05 Thread Ian Forbes
These pointers are frequently the same and memcmp does not compare the pointers before comparing their contents so this was wasting cycles comparing 16 KiB of memory which will always be equal. Fixes: bb6780aa5a1d ("drm/vmwgfx: Diff cursors when using cmds") Signed-off-by: Ian Forbes Cc: #

Re: [PATCH 2/8] accel/ivpu: Remove d3hot_after_power_off WA

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: Always enter D3hot after entering D0i3 an all platforms. This minimizes power usage. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 6/8] accel/ivpu: Return max freq for DRM_IVPU_PARAM_CORE_CLOCK_RATE

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: DRM_IVPU_PARAM_CORE_CLOCK_RATE returned current NPU frequency which Commit text should be present tense, so returned->returns could be 0 if device was sleeping. This value wasn't really useful to also wasn't->isn't the user space, so return

[linux-next:master] BUILD REGRESSION 8568bb2ccc278f344e6ac44af6ed010a90aa88dc

2024-04-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc Add linux-next specific files for 20240405 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404051333.7und7ppw-...@intel.com https

Re: [PATCH v3 2/9] drm: xlnx: zynqmp_dpsub: Update live format defines

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG register layout. I think this description needs a bit more. Mention that the defines are not currently used, so we can change them like this without any other change. Tomi

Re: [PATCH v3 1/9] drm: xlnx: zynqmp_dpsub: Set layer mode during creation

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: Set layer mode of operation (live or dma-based) during layer creation. Each DPSUB layer mode of operation is defined by corresponding DT node port connection, so it is possible to assign it during layer object creation. Previously it was set in

Re: [PATCH v3 5/9] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: Avoid usage of global zynqmp_dpsub.dma_enabled flag in DPSUB layer context. This flag signals whether the driver runs in DRM CRTC or DRM bridge mode, assuming that all display layers share the same live or non-live mode of operation. Using per-layer

Re: [PATCH v15 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

2024-04-05 Thread Vinod Koul
On 06-03-24, 11:16, Alexander Stein wrote: > From: Sandor Yu > > Add Cadence HDP-TX DisplayPort and HDMI PHY driver for i.MX8MQ. > > Cadence HDP-TX PHY could be put in either DP mode or > HDMI mode base on the configuration chosen. > DisplayPort or HDMI PHY mode is configured in the driver. >

Re: [PATCH v15 2/8] phy: Add HDMI configuration options

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 07:54:46PM +0530, Vinod Koul wrote: > On 06-03-24, 15:48, Maxime Ripard wrote: > > Hi Alexander, > > > > On Wed, Mar 06, 2024 at 11:16:19AM +0100, Alexander Stein wrote: > > > From: Sandor Yu > > > > > > Allow HDMI PHYs to be configured through the generic > > >

Re: [PATCH 5/8] accel/ivpu: Improve clarity of MMU error messages

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" This patch improves readability and clarity of MMU error messages. Previously, the error strings were somewhat confusing and could lead to ambiguous interpretations, making it difficult to diagnose issues. Signed-off-by:

[PATCH v2 3/3] drm/lima: mask irqs in timeout path before hard reset

2024-04-05 Thread Erico Nunes
There is a race condition in which a rendering job might take just long enough to trigger the drm sched job timeout handler but also still complete before the hard reset is done by the timeout handler. This runs into race conditions not expected by the timeout handler. In some very specific cases

[PATCH v2 1/3] drm/lima: add mask irq callback to gp and pp

2024-04-05 Thread Erico Nunes
This is needed because we want to reset those devices in device-agnostic code such as lima_sched. In particular, masking irqs will be useful before a hard reset to prevent race conditions. Signed-off-by: Erico Nunes --- drivers/gpu/drm/lima/lima_bcast.c | 12

[PATCH v2 0/3] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-04-05 Thread Erico Nunes
v1 reference: https://patchwork.freedesktop.org/series/131902/ Changes v1 -> v2: - Split synchronize_irq of pp bcast irq change into (new) patch 2. Erico Nunes (3): drm/lima: add mask irq callback to gp and pp drm/lima: include pp bcast irq in timeout handler check drm/lima: mask irqs in

[PATCH v2 2/3] drm/lima: include pp bcast irq in timeout handler check

2024-04-05 Thread Erico Nunes
In commit 53cb55b20208 ("drm/lima: handle spurious timeouts due to high irq latency") a check was added to detect an unexpectedly high interrupt latency timeout. With further investigation it was noted that on Mali-450 the pp bcast irq may also be a trigger of race conditions against the timeout

Re: [PATCH 1/8] drm/ttm: Allow TTM LRU list nodes of different types

2024-04-05 Thread Christian König
Am 29.03.24 um 15:57 schrieb Thomas Hellström: To be able to handle list unlocking while traversing the LRU list, we want the iterators not only to point to the next position of the list traversal, but to insert themselves as list nodes at that point to work around the fact that the next node

Re: [RESEND v7 14/37] clk: Compatible with narrow registers

2024-04-05 Thread Damien Le Moal
On 4/5/24 21:56, Geert Uytterhoeven wrote: > Hi Sato-san, > > On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato > wrote: >> divider and gate only support 32-bit registers. >> Older hardware uses narrower registers, so I want to be able to handle >> 8-bit and 16-bit wide registers. >> >> Seven

Re: [RESEND v7 23/37] dt-bindings: display: sm501 register definition helper

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, Thanks for your patch! On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > Miscellaneous Timing and Miscellaneous Control registers definition. Please do not put raw register value definitions into DT bindings. > Signed-off-by: Yoshinori Sato > --- /dev/null > +++

Re: [PATCH v15 2/8] phy: Add HDMI configuration options

2024-04-05 Thread Vinod Koul
On 06-03-24, 15:48, Maxime Ripard wrote: > Hi Alexander, > > On Wed, Mar 06, 2024 at 11:16:19AM +0100, Alexander Stein wrote: > > From: Sandor Yu > > > > Allow HDMI PHYs to be configured through the generic > > functions through a custom structure added to the generic union. > > > > The

Re: [PATCH 8/8] accel/ivpu: Fix deadlock in context_xa

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: ivpu_device->context_xa is locked both in kernel thread and IRQ context. It requires XA_FLAGS_LOCK_IRQ flag to be passed during initialization otherwise the lock could be acquired from a thread and interrupted by an IRQ that locks it for the second

Re: [PATCH] drm: nv04: Add check to avoid out of bounds access

2024-04-05 Thread Danilo Krummrich
On 3/31/24 08:45, Mikhail Kobuk wrote: Output Resource (dcb->or) value is not guaranteed to be non-zero (i.e. in drivers/gpu/drm/nouveau/nouveau_bios.c, in 'fabricate_dcb_encoder_table()' 'dcb->or' is assigned value '0' in call to 'fabricate_dcb_output()'). I don't really know much about the

[PATCH] drm/msm: remove an unused-but-set variable

2024-04-05 Thread Arnd Bergmann
From: Arnd Bergmann The modification to a6xx_get_shader_block() had no effect other than causing a warning: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] u64 out = dumper->iova + A6XX_CD_DATA_OFFSET;

Re: [RESEND v7 34/37] sh: Add dtbs target support.

2024-04-05 Thread Geert Uytterhoeven
On Thu, Apr 4, 2024 at 7:16 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato My Reviewed-by: Geert Uytterhoeven on v6 is still valid. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

Re: [PATCH v3 6/9] drm: xlnx: zynqmp_dpsub: Set input live format

2024-04-05 Thread Tomi Valkeinen
On 21/03/2024 22:43, Anatoliy Klymenko wrote: Program live video input format according to selected media bus format. In the bridge mode of operation, DPSUB is connected to FPGA CRTC which almost certainly supports a single media bus format as its output. Expect this to be delivered via the new

Re: (subset) [PATCH v2 1/1] Revert "drm/qxl: simplify qxl_fence_wait"

2024-04-05 Thread Maxime Ripard
On Thu, 04 Apr 2024 19:14:48 +0100, Alex Constantino wrote: > This reverts commit 5a838e5d5825c85556011478abde708251cc0776. > > Changes from commit 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait") would > result in a '[TTM] Buffer eviction failed' exception whenever it reached a > timeout. > Due

Re: [RESEND v7 21/37] dt-bindings: serial: renesas, scif: Add scif-sh7751.

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > Add Renesas SH7751 SCIF. > > Signed-off-by: Yoshinori Sato > Reviewed-by: Geert Uytterhoeven > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++

Re: [PATCH 4/8] accel/ivpu: Put NPU back to D3hot after failed resume

2024-04-05 Thread Jeffrey Hugo
On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote: Put NPU in D3hot after ivpu_resume() fails to power up the device. This will assure that D3->D0 power cycle will be performed before the next resume and also will minimize power usage in this corner case. Fixes: 28083ff18d3f ("accel/ivpu: Fix DevTLB

Re: [PATCH v0 13/14] drm/nouveau: Make I2C terminology more inclusive

2024-04-05 Thread Easwar Hariharan
On 4/5/2024 9:15 AM, Danilo Krummrich wrote: > Hi Easwar, > > On 3/29/24 18:00, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the

Re: [PATCH 2/3] drm/msm/dsi: move next bridge acquisition to dsi_bind

2024-04-05 Thread Dmitry Baryshkov
On Fri, 5 Apr 2024 at 20:35, Abhinav Kumar wrote: > > > > On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: > > Currently the MSM DSI driver looks for the next bridge during > > msm_dsi_modeset_init(). If the bridge is not registered at that point, > > this might result in -EPROBE_DEFER, which can be

Re: [PATCH 1/3] drm/msm/dsi: remove the drm_bridge_attach fallback

2024-04-05 Thread Abhinav Kumar
On 4/5/2024 11:19 AM, Dmitry Baryshkov wrote: On Fri, 5 Apr 2024 at 21:17, Abhinav Kumar wrote: On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote: On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar wrote: On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: All the bridges that are being used with the

Re: [PATCH 01/12] drm/client: Fully protect modes[] with dev->mode_config.mutex

2024-04-05 Thread Ville Syrjälä
On Fri, Apr 05, 2024 at 06:24:01AM +0300, Dmitry Baryshkov wrote: > On Thu, Apr 04, 2024 at 11:33:25PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The modes[] array contains pointers to modes on the connectors' > > mode lists, which are protected by dev->mode_config.mutex. > >

Re: [PATCH v3] drm/msm/dp: assign correct DP controller ID to x1e80100 interface table

2024-04-05 Thread Abhinav Kumar
On Fri, 29 Mar 2024 12:46:26 -0700, Kuogee Hsieh wrote: > At current x1e80100 interface table, interface #3 is wrongly > connected to DP controller #0 and interface #4 wrongly connected > to DP controller #2. Fix this problem by connect Interface #3 to > DP controller #0 and interface #4 connect

  1   2   >