On Sat, Nov 26, 2011 at 4:57 PM, Chris Wilson
wrote:
> On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick gmail.com> wrote:
>> On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote:
>> > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter
>> > wrote:
>> >
>> >> Indeed, nice catch (albeit
On Fri, Nov 25, 2011 at 09:13:56PM +0100, Daniel Vetter wrote:
> On Fri, Nov 25, 2011 at 01:14:00PM -0600, Rob Clark wrote:
> > btw, Inki, Daniel, Konrad, and everyone who's reviewed this driver
> > over the (what seems like) years, I'd appreciate r-b's or comments if
> > you think there is
On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick
wrote:
> Yes, no real problem with current code. I was just thinking from code
> cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
No, just documentation as a reminder that the request should be
preallocated, ideally so that we can
On Fri, Nov 25, 2011 at 17:28, Dave Airlie wrote:
> I've rebuilt my PRIME interface on top of dmabuf to see how it would work,
>
> I've got primed gears running again on top, but I expect all my object
> lifetime and memory ownership rules need fixing up (i.e. leaks like a
> sieve).
>
>
On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick
wrote:
> On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote:
> > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter
> > wrote:
> >
> >> Indeed, nice catch (albeit totally unlikely to be hit, because the error
> >> only happens when the gpu
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote:
> On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter wrote:
>
>> Indeed, nice catch (albeit totally unlikely to be hit, because the error
>> only happens when the gpu ceases to progress in the ring, so imo not
>> stable material). Keith,
allocating request. Though, it's unlikely cause if request is NULL
then BUG_ON will be hit in i915_add_request(). So, to unify the callee
uses of i915_add_request(), I'm proposing the following patch. Please
let me know what do you guys think. If you guys agree, I can sent a
formal patch.
Index:
https://bugs.freedesktop.org/show_bug.cgi?id=43248
--- Comment #2 from Sandeep 2011-11-25 16:02:45 PST
---
This happens for OpenArena as well.
Trine on the other hand works properly (on low detail)
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are
On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard kei...@keithp.com wrote:
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter dan...@ffwll.ch wrote:
Indeed, nice catch (albeit totally unlikely to be hit, because
On Fri, Nov 25, 2011 at 17:28, Dave Airlie airl...@gmail.com wrote:
I've rebuilt my PRIME interface on top of dmabuf to see how it would work,
I've got primed gears running again on top, but I expect all my object
lifetime and memory ownership rules need fixing up (i.e. leaks like a
sieve).
On Sat, Nov 26, 2011 at 4:57 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard kei...@keithp.com wrote:
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter
On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
Yes, no real problem with current code. I was just thinking from code
cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
No, just documentation as a reminder that the request should be
preallocated,
On Sat, Nov 26, 2011 at 8:00 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Fri, Nov 25, 2011 at 17:28, Dave Airlie airl...@gmail.com wrote:
I've rebuilt my PRIME interface on top of dmabuf to see how it would work,
I've got primed gears running again on top, but I expect all my object
lifetime
13 matches
Mail list logo
