[Bug 89059] Dota crashes constantly before 10min mark

2015-04-16 Thread bugzilla-dae...@freedesktop.org
: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150416/8c624537/attachment.html>

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

2015-04-16 Thread bugzilla-dae...@freedesktop.org
! Only tried my normal settings on valley which are quality ultra + 8x AA -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150

[PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-16 Thread weiyj...@163.com
From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/intel_audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 2396cc7..d00d488

[PATCH] drm/sti: fix return value check in sti_dvo_probe()

2015-04-16 Thread weiyj...@163.com
From: Wei Yongjun In case of error, the function devm_ioremap_nocache() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sti/sti_dvo.c | 4 ++-- 1 file

[PATCH] drm/exynos: fix source data argument for plane

2015-04-16 Thread Joonyoung Shim
The exynos_update_plane function needs 16.16 fixed point source data. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c

[PATCH 08/10] drm: Fix for DP CTS test 4.2.2.5 - I2C DEFER handling

2015-04-16 Thread Paulo Zanoni
2015-04-15 12:38 GMT-03:00 Todd Previte : > For test 4.2.2.5 to pass per the Link CTS Core 1.2 rev1.1 spec, the source > device must attempt at least 7 times to read the EDID when it receives an > I2C defer. The normal DRM code makes only 7 retries, regardless of whether > or not the response is a

[PATCH 2/2] ARM: DMA: Use vm_pgoff for IOMMU mmap

2015-04-16 Thread Ørjan Eide
arm_iommu_mmap_attrs() ignores the page offset in vma->vm_pgoff that was specified in the mmap call. Any user of dma_mmap_* will get an unexpected result when the device uses the IOMMU DMA ops. Some DRM driver that use dma_mmap_* seems to depend on it ignoring vma->vm_pgoff. Both the Samsung

[PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api

2015-04-16 Thread Ørjan Eide
Set vm_pgoff to 0 after using it to look up the GEM node, before passing it on rockchip_gem_mmap_buf() where the offset must be from the start of the buffer. Passing in the fake offset currently works because the dma_mmap_attrs implementation that is used for this device, arm_iommu_mmap_attrs,

[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-16 Thread Daniel Vetter
On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com wrote: > From: Wei Yongjun > > Remove duplicated include. > > Signed-off-by: Wei Yongjun Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_audio.c | 1 - > 1 file changed, 1 deletion(-) > > diff

[RFC 3/6] drm/exynos: introduce struct exynos_drm_plane_config

2015-04-16 Thread Tobias Jakobi
Hello! On 2015-04-15 22:33, Gustavo Padovan wrote: >> > As a follow up of my atomic series I started cleaning up exynos drm a bit >> > more >> > and right now I'm removing most of struct exynos_drm_plane. Most of the >> > plane >> > information there is also present in plane->state thus I'm

[Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Daniel Vetter
On Thu, Apr 16, 2015 at 08:30:55AM -0400, Peter Hurley wrote: > On 04/15/2015 01:31 PM, Daniel Vetter wrote: > > On Wed, Apr 15, 2015 at 09:00:04AM -0400, Peter Hurley wrote: > >> Hi Daniel, > >> > >> On 04/15/2015 03:17 AM, Daniel Vetter wrote: > >>> This was a bit too much cargo-culted, so lets

[PATCH 10/10] drm: Fix the 'native defer' message in drm_dp_i2c_do_msg()

2015-04-16 Thread Daniel Vetter
On Wed, Apr 15, 2015 at 08:38:47AM -0700, Todd Previte wrote: > The debug message is missing a newline at the end and it makes the > logs hard to read when a device defers a lot. Simple 2-character fix > adds the newline at the end. > > Signed-off-by: Todd Previte > Cc: dri-devel at

[PATCH 10/10] drm: Fix the 'native defer' message in drm_dp_i2c_do_msg()

2015-04-16 Thread Daniel Vetter
On Wed, Apr 15, 2015 at 08:38:47AM -0700, Todd Previte wrote: > The debug message is missing a newline at the end and it makes the > logs hard to read when a device defers a lot. Simple 2-character fix > adds the newline at the end. > > Signed-off-by: Todd Previte > Cc: dri-devel at

[PATCH] DRM: Don't re-poll connector for disconnect

2015-04-16 Thread Josef Holzmayr
DRM probe should not repoll a connector if it is already connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set. Signed-off-by: Josef Holzmayr --- drivers/gpu/drm/drm_probe_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Bug 88152] 720p and 1080 H.264 videos lock-up on playback with vlc / vdpau on Radeon 3850HD

2015-04-16 Thread bugzilla-dae...@freedesktop.org
vel/attachments/20150416/df72a015/attachment.html>

[PATCH] drm/radeon: Use drm_calloc_ab for CS relocs

2015-04-16 Thread Michel Dänzer
On 16.04.2015 11:17, Michel Dänzer wrote: > From: Michel Dänzer > > The number of relocs is passed in by userspace and can be large. It has > been observed to cause kmalloc failures in the wild. That should of course say 'kcalloc failures'. -- Earthling Michel Dänzer |

[PATCH] drm/radeon: Use drm_calloc_ab for CS relocs

2015-04-16 Thread Michel Dänzer
From: Michel Dänzer The number of relocs is passed in by userspace and can be large. It has been observed to cause kmalloc failures in the wild. Cc: stable at vger.kernel.org Signed-off-by: Michel Dänzer --- drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- 1 file

[PATCH 00/31] Convert omapdrm to the atomic updates API

2015-04-16 Thread Daniel Vetter
On Thu, Apr 16, 2015 at 01:09:17AM +0300, Laurent Pinchart wrote: > Hello, > > This patch set converts the omapdrm to the atomic update API in 31 small(ish) > and hopefully reviewable steps. > > The series is based on the latest drm/next branch and depends on the pending > "drm: omapdrm: Store

[PATCH RFC v9 11/20] drm/bridge: Add Synopsys DesignWare MIPI DSI host controller driver

2015-04-16 Thread Archit Taneja
On 04/09/2015 02:13 PM, Thierry Reding wrote: > On Thu, Feb 12, 2015 at 02:01:34PM +0800, Liu Ying wrote: > [...] >> diff --git a/drivers/gpu/drm/bridge/dw_mipi_dsi.c >> b/drivers/gpu/drm/bridge/dw_mipi_dsi.c > [...] >> +struct dw_mipi_dsi { >> +struct mipi_dsi_host dsi_host; >> +struct

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Daniel Vetter
On Thu, Apr 16, 2015 at 05:00:02AM -0400, Peter Hurley wrote: > On 04/16/2015 02:39 AM, Mario Kleiner wrote: > > I think i'm still not getting something about why the compiler would > > be allowed to reorder in this way in absence of the additional > > smp_rmb? Or is that barrier required for

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Daniel Vetter
This was a bit too much cargo-culted, so lets make it solid: - vblank->count doesn't need to be an atomic, writes are always done under the protection of dev->vblank_time_lock. Switch to an unsigned long instead and update comments. Note that atomic_read is just a normal read of a volatile

[PATCH libdrm] Add missing includes

2015-04-16 Thread Greg Hackmann
A couple of files use ffs() without explicitly including strings.h. Some systems will pull in ffs()'s declaration through another header anyway, but not when compiling against bionic in AOSP master. Signed-off-by: Greg Hackmann --- nouveau/nouveau.c | 1 + tests/modetest/modetest.c | 1

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Daniel Vetter
On Wed, Apr 15, 2015 at 11:26:37PM +0200, Mario Kleiner wrote: > A couple of questions to educate me and one review comment. > > On 04/15/2015 07:34 PM, Daniel Vetter wrote: > >This was a bit too much cargo-culted, so lets make it solid: > >- vblank->count doesn't need to be an atomic, writes are

[PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

2015-04-16 Thread Paulo Zanoni
2015-04-15 19:03 GMT-03:00 Todd Previte : > Displayport compliance test 4.2.2.6 requires that a source device be capable > of > detecting a corrupt EDID. The test specification states that the sink device > sets up the EDID with an invalid checksum. To do this, the sink sets up an > invalid EDID

[PATCH] drm/radeon: Use drm_calloc_ab for CS relocs

2015-04-16 Thread Alex Deucher
On Thu, Apr 16, 2015 at 3:58 AM, Christian König wrote: > On 16.04.2015 04:30, Michel Dänzer wrote: >> >> On 16.04.2015 11:17, Michel Dänzer wrote: >>> >>> From: Michel Dänzer >>> >>> The number of relocs is passed in by userspace and can be large. It has >>> been observed to cause kmalloc

[PATCH] drm/radeon: Use drm_calloc_ab for CS relocs

2015-04-16 Thread Christian König
On 16.04.2015 04:30, Michel Dänzer wrote: > On 16.04.2015 11:17, Michel Dänzer wrote: >> From: Michel Dänzer >> >> The number of relocs is passed in by userspace and can be large. It has >> been observed to cause kmalloc failures in the wild. > That should of course say 'kcalloc failures'.

[PATCH 3/3] drm/atomic-helper: Don't call atomic_update_plane when it stays off

2015-04-16 Thread Daniel Vetter
On Thu, Apr 16, 2015 at 12:46:53AM +0300, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Friday 10 April 2015 16:22:39 Daniel Vetter wrote: > > It's a silly thing to do and surprises driver writers. Most likely > > this did already blow up for exynos. > > > > It's also

[PATCH 1/3] drm/msm: match wait_for_completion_timeout return type

2015-04-16 Thread Nicholas Mc Guire
On Mon, 13 Apr 2015, Thierry Reding wrote: > On Sat, Apr 11, 2015 at 03:10:36PM +0200, Nicholas Mc Guire wrote: > > return type of wait_for_completion_timeout is unsigned long not int, this > > patch assigns the return value of wait_for_completion_timeout to an > > appropriately typed and named

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Peter Hurley
On 04/16/2015 02:39 AM, Mario Kleiner wrote: > On 04/16/2015 03:29 AM, Peter Hurley wrote: >> On 04/15/2015 05:26 PM, Mario Kleiner wrote: >> Because the time scales for these events don't require that level of >> resolution; consider how much code has to get executed between a >> hardware vblank

[PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

2015-04-16 Thread Todd Previte
Displayport compliance test 4.2.2.6 requires that a source device be capable of detecting a corrupt EDID. The test specification states that the sink device sets up the EDID with an invalid checksum. To do this, the sink sets up an invalid EDID header, expecting the source device to generate the

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Mario Kleiner
On 04/16/2015 03:29 AM, Peter Hurley wrote: > On 04/15/2015 05:26 PM, Mario Kleiner wrote: >> A couple of questions to educate me and one review comment. >> >> On 04/15/2015 07:34 PM, Daniel Vetter wrote: >>> This was a bit too much cargo-culted, so lets make it solid: >>> - vblank->count doesn't

[Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Peter Hurley
On 04/15/2015 01:31 PM, Daniel Vetter wrote: > On Wed, Apr 15, 2015 at 09:00:04AM -0400, Peter Hurley wrote: >> Hi Daniel, >> >> On 04/15/2015 03:17 AM, Daniel Vetter wrote: >>> This was a bit too much cargo-culted, so lets make it solid: >>> - vblank->count doesn't need to be an atomic, writes

[Bug 89685] Cripling Dota 2 freeze with Morphling at hero selection or loadout

2015-04-16 Thread bugzilla-dae...@freedesktop.org
ed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150416/f1e15a4e/attachment.html>

[Bug 89980] [Regression] Graphical corruption after resuming from suspend (w/ dual monitor configuration)

2015-04-16 Thread bugzilla-dae...@freedesktop.org
ou are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150416/d0bc2784/attachment.html>

[PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

2015-04-16 Thread Todd Previte
On 4/16/2015 6:34 AM, Paulo Zanoni wrote: > 2015-04-15 19:03 GMT-03:00 Todd Previte : >> Displayport compliance test 4.2.2.6 requires that a source device be capable >> of >> detecting a corrupt EDID. The test specification states that the sink device >> sets up the EDID with an invalid

[Bug 83274] XCom Enemy Unknown segfault at src/gallium/drivers/radeon/r600_texture.c:602

2015-04-16 Thread bugzilla-dae...@freedesktop.org
launching steam (export DEBUGGER="valgrind --log-file=valgrindxcom.log") -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attach

[Bug 89980] [Regression] Graphical corruption after resuming from suspend (w/ dual monitor configuration)

2015-04-16 Thread bugzilla-dae...@freedesktop.org
rubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150416/3cb361fe/attachment.html>

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Peter Hurley
On 04/16/2015 02:39 AM, Mario Kleiner wrote: > On 04/16/2015 03:29 AM, Peter Hurley wrote: >> On 04/15/2015 05:26 PM, Mario Kleiner wrote: >>> A couple of questions to educate me and one review comment. >>> >>> On 04/15/2015 07:34 PM, Daniel Vetter wrote: This was a bit too much cargo-culted,

[Bug 89980] [Regression] Graphical corruption after resuming from suspend (w/ dual monitor configuration)

2015-04-16 Thread bugzilla-dae...@freedesktop.org
tp://lists.freedesktop.org/archives/dri-devel/attachments/20150416/d30e25ba/attachment.html>

[Bug 83274] XCom Enemy Unknown segfault at src/gallium/drivers/radeon/r600_texture.c:602

2015-04-16 Thread bugzilla-dae...@freedesktop.org
r the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150416/6413e420/attachment.html>

[PATCH 31/31] drm: omapdrm: omap_crtc_flush() isn't called with modeset locked

2015-04-16 Thread Laurent Pinchart
When performing asynchronous atomic updates the modeset lock isn't taken around the callers of omap_crtc_flush(). This isn't an issue though, as access to the CRTC is properly serialized. Just drop the warning. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 1 - 1

[PATCH 30/31] drm: omapdrm: Don't get/put dispc in omap_crtc_flush()

2015-04-16 Thread Laurent Pinchart
The omap_crtc_flush() function is always called with a reference to the dispc held. Remove unnecessary calls to dispc_runtime_get() and dispc_runtime_put(). Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 29/31] drm: omapdrm: Make the omap_crtc_flush function static

2015-04-16 Thread Laurent Pinchart
The function isn't used outside of its compilation unit, make it static. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +- drivers/gpu/drm/omapdrm/omap_drv.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c

[PATCH 28/31] drm: omapdrm: Remove omap_plane enabled field

2015-04-16 Thread Laurent Pinchart
The field tracks the plane state to avoid double-enable or -disable. This isn't required anymore, as - the DRM atomic core guarantees that the plane atomic_update and atomic_disable functions will never be called on an enabled/disabled plane - the CRTC enable/disable operations that

[PATCH 27/31] drm: omapdrm: Remove omap_crtc enabled field

2015-04-16 Thread Laurent Pinchart
The field tracks the CRTC state to avoid double-enable or -disable. As the DRM atomic core guarantees that the CRTC enable and disable functions won't be called on an already enabled or disabled CRTC, such tracking isn't needed. Remove the enabled field. Signed-off-by: Laurent Pinchart ---

[PATCH 26/31] drm: omapdrm: Move crtc info out of the crtc structure

2015-04-16 Thread Laurent Pinchart
The crtc info structure is only used to setup the crtc through the DSS API. Move it from the crtc structure to local variables in omap_crtc_dss_enable(). Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 18 -- 1 file changed, 8 insertions(+), 10

[PATCH 25/31] drm: omapdrm: Move plane info and win out of the plane structure

2015-04-16 Thread Laurent Pinchart
The plane info and win structures are only used to setup the plane through the DSS API. Move them from the plane structure to local variables in omap_plane_setup(). Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_plane.c | 92 1 file

[PATCH 24/31] drm: omapdrm: Switch crtc and plane set_property to atomic helpers

2015-04-16 Thread Laurent Pinchart
Allow setting up plane properties atomically using the plane set_property atomic helper. The properties are now stored in the plane state (requiring subclassing it) and applied when updating the planes. The CRTC exposes the properties of its primary plane for legacy reason. We can't get rid of

[PATCH 23/31] drm: omapdrm: Drop manual framebuffer pin handling

2015-04-16 Thread Laurent Pinchart
Since the removal of omap_plane_mode_set(), framebuffers are now pinned exclusively through the plane .prepare_fb() and .cleanup_fb() operations as the remaining callers of omap_plane_setup() don't modify the framebuffer. Remove the manual pin/unpin infrastructure. Signed-off-by: Laurent Pinchart

[PATCH 22/31] drm: omapdrm: Switch page flip to atomic helpers

2015-04-16 Thread Laurent Pinchart
The atomic page flip helper implements the page flip operation using asynchronous commits. As the legacy page flip was the last caller of omap_plane_mode_set(), remove the function. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 222

[PATCH 21/31] drm: omapdrm: Implement asynchronous commit support

2015-04-16 Thread Laurent Pinchart
Implement a custom .atomic_commit() handler that supports asynchronous commits using a work queue. This can be used for userspace-driven asynchronous commits, as well as for an atomic page flip implementation. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 99

[PATCH 20/31] drm: omapdrm: Replace encoder mode_fixup with atomic_check

2015-04-16 Thread Laurent Pinchart
The encoder .mode_fixup() operation is legacy, atomic updates uses the new .atomic_check() operation. Convert the encoder driver. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_encoder.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 19/31] drm: omapdrm: Switch connector DPMS to atomic helpers

2015-04-16 Thread Laurent Pinchart
The atomic connector DPMS helper implements the connector DPMS operation using atomic commit, removing the need for DPMS helper operations on CRTCs and encoders. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_connector.c | 2 +- drivers/gpu/drm/omapdrm/omap_crtc.c | 14

[PATCH 18/31] drm: omapdrm: Switch mode config to atomic helpers

2015-04-16 Thread Laurent Pinchart
This removes the legacy mode config code. The CRTC and encoder prepare and commit operations are not used anymore, remove them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c| 37 +- drivers/gpu/drm/omapdrm/omap_encoder.c | 10

[PATCH 17/31] drm: omapdrm: Switch plane update to atomic helpers

2015-04-16 Thread Laurent Pinchart
This removes the legacy plane update code. Wire up the default atomic check and atomic commit mode config helpers as needed by the plane update atomic helpers. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 3 +++ drivers/gpu/drm/omapdrm/omap_plane.c | 4 ++-- 2

[PATCH 16/31] drm: omapdrm: Handle primary plane config through atomic plane ops

2015-04-16 Thread Laurent Pinchart
Use the new CRTC atomic transitional helpers drm_helper_crtc_mode_set() and drm_helper_crtc_mode_set_base() to implement the CRTC .mode_set and .mode_set_base operations. This delegates primary plane configuration to the plane .atomic_update and .atomic_disable operations, removing duplicate code

[PATCH 15/31] drm: omapdrm: Implement planes atomic operations

2015-04-16 Thread Laurent Pinchart
Implement the CRTC .atomic_begin() and .atomic_flush() operations, the plane .atomic_check(), .atomic_update() and operations, and use the transitional atomic helpers to implement the plane update and disable operations on top of the new atomic operations. Signed-off-by: Laurent Pinchart ---

[PATCH 14/31] drm: omapdrm: Wire up atomic state object scaffolding

2015-04-16 Thread Laurent Pinchart
Hook up the default .reset(), .atomic_duplicate_state() and .atomic_free_state() helpers to ensure that state objects are properly created and destroyed, and call drm_mode_config_reset() at init time to create the initial state objects. Framebuffer reference count also gets maintained

[PATCH 13/31] drm: omapdrm: Implement encoder .disable() and .enable() operations

2015-04-16 Thread Laurent Pinchart
The operations are required by the atomic helpers, implement them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_encoder.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c index

[PATCH 12/31] drm: omapdrm: Rework CRTC enable/disable for atomic updates

2015-04-16 Thread Laurent Pinchart
When using atomic updates the CRTC .enable() and .disable() helper operations are preferred over the (then legacy) .prepare() and .commit() operations. Implement .enable() and rework .disable() to not depend on DPMS, easing DPMS removal later on. Signed-off-by: Laurent Pinchart ---

[PATCH 11/31] drm: omapdrm: Rename CRTC DSS operations with an omap_crtc_dss_ prefix

2015-04-16 Thread Laurent Pinchart
The omap_crtc_enable() and omap_crtc_disable() DSS operations functions will clash with the new CRTC enable and disable helpers. Rename them to omap_crtc_dss_*, as well as the other DSS operations for consistency. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 36

[PATCH 10/31] drm: omapdrm: Clean up #include's

2015-04-16 Thread Laurent Pinchart
Use the <...> include style instead of "..." for DRM headers and sort the headers alphabetically to ease detection of duplicates. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_connector.c | 6 +++--- drivers/gpu/drm/omapdrm/omap_crtc.c | 8

[PATCH 09/31] drm: omapdrm: Fix page flip race with CRTC disable

2015-04-16 Thread Laurent Pinchart
We can't rely on crtc->primary->fb in the page flip worker, as a racing CRTC disable (due for instance to an explicit framebuffer deletion from userspace) would set that field to NULL before the worker gets a change to run. Store the framebuffer queued for page flip in a new field of omap_crtc

[PATCH 08/31] drm: omapdrm: Turn vblank on/off when enabling/disabling CRTC

2015-04-16 Thread Laurent Pinchart
The DRM core vblank handling mechanism requires drivers to forcefully turn vblank reporting off when disabling the CRTC, and to restore the vblank reporting status when enabling the CRTC. Implement this using the drm_crtc_vblank_on/off helpers. When disabling vblank we must first wait for page

[PATCH 07/31] drm: omapdrm: Rework page flip handling

2015-04-16 Thread Laurent Pinchart
To implement proper vblank control the driver will need to wait for page flip completion before disabling the vblank interrupt. This is made complex by the page flip implementation which queues and submits page flips to the hardware in two separate steps between which DRM locks are released. We

[PATCH 06/31] drm: omapdrm: Cancel pending page flips when closing device

2015-04-16 Thread Laurent Pinchart
Pending page flips must be cancelled when closing the device, otherwise their completion at next vblank will result in nasty effects, including possible oopses due to resources required to complete the page flip being freed. Signed-off-by: Laurent Pinchart ---

[PATCH 05/31] drm: omapdrm: Simplify IRQ registration

2015-04-16 Thread Laurent Pinchart
The omapdrm can't use drm_irq_install() and drm_irq_uninstall() as it delegates IRQ handling to the omapdss driver. However, the code still declares IRQ-related operations used by the DRM IRQ helpers, and calls them indirectly. Simplify the implementation by calling the functions directly or

[PATCH 04/31] drm: omapdrm: Rename omap_crtc page flip-related fields

2015-04-16 Thread Laurent Pinchart
The old_fb field is only used to indicate whether a page flip is pending. Turn it into a bool named flip_pending. Rename event and page_flip_work to flip_event and flip_work for consistency. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 47

[PATCH 03/31] drm: omapdrm: Rename omap_crtc_page_flip_locked to omap_crtc_page_flip

2015-04-16 Thread Laurent Pinchart
The operation is called page_flip, rename its implementation accordingly. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c

[PATCH 02/31] drm: omapdrm: Apply settings synchronously

2015-04-16 Thread Laurent Pinchart
The omapdrm driver implements a mechanism to apply new settings (due to plane update, plane disable, plane property set, CRTC mode set or CRTC DPMS) asynchronously. While this improves performance, it adds a level of complexity that makes transition to the atomic update API close to impossible.

[PATCH 01/31] drm: omapdrm: Store the rotation property in dev->mode_config

2015-04-16 Thread Laurent Pinchart
Rotation is a standard property, store it in dev->mode_config.rotation_property. While at it, extract the properties initialization code to a separate function instead of running it for every plane. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 4 +---

[PATCH 00/31] Convert omapdrm to the atomic updates API

2015-04-16 Thread Laurent Pinchart
Hello, This patch set converts the omapdrm to the atomic update API in 31 small(ish) and hopefully reviewable steps. The series is based on the latest drm/next branch and depends on the pending "drm: omapdrm: Store the rotation property in dev->mode_config" patch by Daniel Vetter. The omapdrm

[PATCH 3/3] drm/atomic-helper: Don't call atomic_update_plane when it stays off

2015-04-16 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Friday 10 April 2015 16:22:39 Daniel Vetter wrote: > It's a silly thing to do and surprises driver writers. Most likely > this did already blow up for exynos. > > It's also a silly thing to change plane state when it's off, but fbdev > is silly (it does an

[PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-04-16 Thread Mario Kleiner
A couple of questions to educate me and one review comment. On 04/15/2015 07:34 PM, Daniel Vetter wrote: > This was a bit too much cargo-culted, so lets make it solid: > - vblank->count doesn't need to be an atomic, writes are always done >under the protection of dev->vblank_time_lock. Switch