Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-05 Thread Mark Brown
On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > Add basic support with a simple implementation that utilizes the generic > read/write commands to allow device registers to be configured. This looks good to me but I really don't know anything about DSI, I'd appreciate some review

Re: [PATCH 0/4] Add a generic driver for LED-based backlight

2019-07-05 Thread Sebastian Reichel
Hi, On Fri, Jul 05, 2019 at 12:14:34PM +0200, Pavel Machek wrote: > On Mon 2019-07-01 17:14:19, Jean-Jacques Hiblot wrote: > > This series aims to add a led-backlight driver, similar to pwm-backlight, > > but using a LED class device underneath. > > > > A few years ago (2015), Tomi Valkeinen

Re: [PATCH v6 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section

2019-07-05 Thread Luis Chamberlain
On Wed, Jul 03, 2019 at 05:36:15PM -0700, Brendan Higgins wrote: > Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section. > > Signed-off-by: Brendan Higgins > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Logan Gunthorpe > Acked-by: Luis Chamberlain Come to think of it,

Re: [PATCH v1 05/33] drm/mxsfb: drop use of drmP.h

2019-07-05 Thread Stefan Agner
On 2019-06-30 08:18, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > > While touching the list of include files divided them > in blocks and sort them within each block. > Fixed fallout in the relevant files. > > Signed-off-by: Sam Ravnborg > Cc: Marek Vasut > Cc: Stefan

Re: [PATCH v1 08/33] drm/fsl-dcu: drop use of drmP.h

2019-07-05 Thread Stefan Agner
On 2019-06-30 08:18, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > Fix fallout. > > Signed-off-by: Sam Ravnborg > Cc: Stefan Agner > Cc: Alison Wang Acked-by: Stefan Agner -- Stefan > --- > The list of cc: was too large to add all recipients to the cover letter. >

Re: [PATCH v6 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-07-05 Thread Luis Chamberlain
On Wed, Jul 03, 2019 at 05:36:14PM -0700, Brendan Higgins wrote: > From: Iurii Zaikin > > KUnit tests for initialized data behavior of proc_dointvec that is > explicitly checked in the code. Includes basic parsing tests including > int min/max overflow. > > Signed-off-by: Iurii Zaikin >

Re: [PATCH v6 02/18] kunit: test: add test resource management API

2019-07-05 Thread Luis Chamberlain
On Wed, Jul 03, 2019 at 05:35:59PM -0700, Brendan Higgins wrote: > diff --git a/kunit/test.c b/kunit/test.c > index c030ba5a43e40..a70fbe449e922 100644 > --- a/kunit/test.c > +++ b/kunit/test.c > @@ -122,7 +122,8 @@ static void kunit_print_test_case_ok_not_ok(struct > kunit_case *test_case, > >

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 4:15 PM Yrjan Skrimstad wrote: > > On Sun, Jun 16, 2019 at 04:43:10PM +0200, Yrjan Skrimstad wrote: > > That is an interesting observation to me. I am actually running > > lm-sensors, although only every 15 seconds. I suppose that this might > > be the reason this happens

Re: [PATCH v2 07/35] drm/amdgpu: Use kmemdup rather than duplicating its implementation

2019-07-05 Thread Alex Deucher
On Wed, Jul 3, 2019 at 1:13 PM Fuqian Huang wrote: > > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memcpy, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller

Re: [PATCH v6 01/18] kunit: test: add KUnit test runner core

2019-07-05 Thread Luis Chamberlain
On Wed, Jul 03, 2019 at 05:35:58PM -0700, Brendan Higgins wrote: > +struct kunit { > + void *priv; > + > + /* private: internal use only. */ > + const char *name; /* Read only after initialization! */ > + bool success; /* Read only after test_case finishes! */ > +}; No lock

Re: [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 9:17 AM Andrzej Pietrasiewicz wrote: > > W dniu 02.07.2019 o 22:54, Alex Deucher pisze: > > On Fri, Jun 28, 2019 at 12:31 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generic connector. > >> > >> Signed-off-by: Andrzej Pietrasiewicz >

Re: [PATCH v6 01/18] kunit: test: add KUnit test runner core

2019-07-05 Thread Luis Chamberlain
On Wed, Jul 03, 2019 at 05:35:58PM -0700, Brendan Higgins wrote: > Add core facilities for defining unit tests; this provides a common way > to define test cases, functions that execute code which is under test > and determine whether the code under test behaves as expected; this also > provides a

Re: [PATCH] drm/msm/mdp5: Use eariler mixers when possible

2019-07-05 Thread Jeffrey Hugo
On Mon, Jul 1, 2019 at 1:55 PM Rob Clark wrote: > > On Mon, Jul 1, 2019 at 10:41 AM Jeffrey Hugo wrote: > > > > When assigning a mixer, we will iterate through the entire list looking for > > a suitable match. This results in selecting the last match. We should > > stop at the first match,

Re: [PATCH 2/2] drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

2019-07-05 Thread Sam Ravnborg
Hi Jeffrey. On Fri, Jul 05, 2019 at 12:35:30PM -0600, Jeffrey Hugo wrote: > On Fri, Jul 5, 2019 at 11:21 AM Sam Ravnborg wrote: > > > > Hi Jeffrey. > > > > Patch looks good, but there is a few fields that are not initialized. > > Did you forget them, or are they not needed? > > Thanks for the

Re: [PATCH 1/2] dt-bindings: panel: Add Sharp LD-D5116Z01B

2019-07-05 Thread Jeffrey Hugo
On Fri, Jul 5, 2019 at 11:23 AM Sam Ravnborg wrote: > > Hi Jeffrey. > > On Fri, Jul 05, 2019 at 09:56:55AM -0700, Jeffrey Hugo wrote: > > + panel: panel { > > + compatible = "sharp,ld-d5116z01b"; > > + power-supply = <_3v3>; > > + no-hpd > The binding do

Re: [PATCH 2/2] drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

2019-07-05 Thread Jeffrey Hugo
On Fri, Jul 5, 2019 at 11:21 AM Sam Ravnborg wrote: > > Hi Jeffrey. > > Patch looks good, but there is a few fields that are not initialized. > Did you forget them, or are they not needed? Thanks for the review. Overlooked some of them. > > On Fri, Jul 05, 2019 at 09:57:55AM -0700, Jeffrey

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-05 Thread Michael Nazzareno Trimarchi
Hi Maxime On Wed, Jul 3, 2019 at 1:49 PM Maxime Ripard wrote: > > On Tue, Jun 25, 2019 at 09:00:36PM +0530, Jagan Teki wrote: > > On Tue, Jun 25, 2019 at 8:19 PM Maxime Ripard > > wrote: > > > > > > On Thu, Jun 20, 2019 at 11:57:44PM +0530, Jagan Teki wrote: > > > > On Fri, Jun 14, 2019 at

Re: [PATCH 1/2] dt-bindings: panel: Add Sharp LD-D5116Z01B

2019-07-05 Thread Sam Ravnborg
Hi Jeffrey. On Fri, Jul 05, 2019 at 09:56:55AM -0700, Jeffrey Hugo wrote: > The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution. > > Signed-off-by: Jeffrey Hugo > --- > .../display/panel/sharp,ld-d5116z01b.txt | 27 +++ > 1 file changed, 27

Re: [PATCH 2/2] drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

2019-07-05 Thread Sam Ravnborg
Hi Jeffrey. Patch looks good, but there is a few fields that are not initialized. Did you forget them, or are they not needed? On Fri, Jul 05, 2019 at 09:57:55AM -0700, Jeffrey Hugo wrote: > The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution. > > Signed-off-by: Jeffrey Hugo

[PATCH v2 8/8] drm/etnaviv: implement per-process address spaces on MMUv2

2019-07-05 Thread Lucas Stach
This builds on top of the MMU contexts introduced earlier. Instead of having one context per GPU core, each GPU client receives its own context. On MMUv1 this still means a single shared pagetable set is used by all clients, but on MMUv2 there is now a distinct set of pagetables for each client.

[PATCH v2 4/8] drm/etnaviv: replace MMU flush marker with flush sequence

2019-07-05 Thread Lucas Stach
If a MMU is shared between multiple GPUs, all of them need to flush their TLBs, so a single marker that gets reset on the first flush won't do. Replace the flush marker with a sequence number, so that it's possible to check if the TLB is in sync with the current page table state for each GPU.

[PATCH v2 3/8] drm/etnaviv: share a single cmdbuf suballoc region across all GPUs

2019-07-05 Thread Lucas Stach
There is no need for each GPU to have it's own cmdbuf suballocation region. Only allocate a single one for the the etnaviv virtual device and share it across all GPUs. As the suballoc space is now potentially shared by more hardware jobs running in parallel, double its size to 512KB to avoid

[PATCH v2 2/8] drm/etnaviv: split out cmdbuf mapping into address space

2019-07-05 Thread Lucas Stach
This allows to decouple the cmdbuf suballocator create and mapping the region into the GPU address space. Allowing multiple AS to share a single cmdbuf suballoc. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 23 drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 35

[PATCH v2 7/8] drm/etnaviv: provide MMU context to etnaviv_gem_mapping_get

2019-07-05 Thread Lucas Stach
In preparation to having a context per process, etnaviv_gem_mapping_get should not use the current GPU context, but needs to be told which context to use. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_gem.c| 20 drivers/gpu/drm/etnaviv/etnaviv_gem.h

[PATCH v2 5/8] drm/etnaviv: rework MMU handling

2019-07-05 Thread Lucas Stach
This reworks the MMU handling to make it possible to have multiple MMU contexts. A context is basically one instance of GPU page tables. Currently we have one set of page tables per GPU, which isn't all that clever, as it has the following two consequences: 1. All GPU clients (aka processes) are

[PATCH v2 6/8] drm/etnaviv: split out starting of FE idle loop

2019-07-05 Thread Lucas Stach
Move buffer setup and starting of the FE loop in the kernel ringbuffer into a separate function. This is a preparation to start the FE later in the submit process. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 -- 1 file changed, 16

[PATCH v2 1/8] drm/etnaviv: simplify unbind checks

2019-07-05 Thread Lucas Stach
Remember if the GPU has been sucessfully initialized. Only in that case do we need to clean up various structures in the unbind path. If the GPU hasn't been sucessfully initialized all the cleanups should happen in the failure paths of the init function. Signed-off-by: Lucas Stach ---

Re: [alsa-devel] [PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-05 Thread Mark Brown
On Fri, Jul 05, 2019 at 03:31:24PM +0800, Cheng-yi Chiang wrote: > It was a long discussion. > I think the conclusion was that if we are only talking about > hdmi-codec, then we just need to extend the ops exposed in hdmi-codec > and don't need to use > hdmi-notifier or drm_audio_component. What

[PATCH 1/2] drm/etnaviv: fix etnaviv_cmdbuf_suballoc_new return value

2019-07-05 Thread Lucas Stach
The call site expects to get either a valid suballoc or an error pointer, so a NULL return will not be treated as an error. Make sure to always return a proper error pointer in case something goes wrong. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 6 -- 1 file

[PATCH 2/2] drm/etnaviv: remove unused function etnaviv_gem_mapping_reference

2019-07-05 Thread Lucas Stach
Hasn't been used for quite a while. There is no point in keeping unused code around. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 12 drivers/gpu/drm/etnaviv/etnaviv_gem.h | 1 - 2 files changed, 13 deletions(-) diff --git

[PATCH 2/2] drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

2019-07-05 Thread Jeffrey Hugo
The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/panel/panel-simple.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

[PATCH 1/2] dt-bindings: panel: Add Sharp LD-D5116Z01B

2019-07-05 Thread Jeffrey Hugo
The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution. Signed-off-by: Jeffrey Hugo --- .../display/panel/sharp,ld-d5116z01b.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644

[PATCH 0/2] Add Sharp panel option for Lenovo Miix 630

2019-07-05 Thread Jeffrey Hugo
The Lenovo Miix 630 laptop can be found with one of two panels - a BOE or Sharp option. This likely provides options during manufacturing. These panels connect via eDP, however they sit behind a DSI to eDP bridge on the laptop, so they can easily be handled by the existing simple panel code.

[PATCH v3 01/13] dt-bindings: display: Convert common panel bindings to DT schema

2019-07-05 Thread Rob Herring
Convert the common panel bindings to DT schema consolidating scattered definitions to a single schema file. The 'simple-panel' binding just a collection of properties and not a complete binding itself. All of the 'simple-panel' properties are covered by the panel-common.txt binding with the

[PATCH v3 11/13] dt-bindings: display: Convert mitsubishi, aa104xd12 panel to DT schema

2019-07-05 Thread Rob Herring
Convert the mitsubishi,aa104xd12 LVDS panel binding to DT schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/mitsubishi,aa104xd12.txt| 47 .../display/panel/mitsubishi,aa104xd12.yaml

[PATCH v3 12/13] dt-bindings: display: Convert mitsubishi, aa121td01 panel to DT schema

2019-07-05 Thread Rob Herring
Convert the mitsubishi,aa121td01 LVDS panel binding to DT schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/mitsubishi,aa121td01.txt| 47 .../display/panel/mitsubishi,aa121td01.yaml

[PATCH v3 05/13] dt-bindings: display: Convert dlc, dlc0700yzg-1 panel to DT schema

2019-07-05 Thread Rob Herring
Convert the dlc,dlc0700yzg-1 panel binding to DT schema. Cc: Philipp Zabel Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/dlc,dlc0700yzg-1.txt| 13

[PATCH v3 06/13] dt-bindings: display: Convert pda, 91-00156-a0 panel to DT schema

2019-07-05 Thread Rob Herring
Convert the pda,91-00156-a0 panel binding to DT schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/pda,91-00156-a0.txt | 14 -

[PATCH v3 02/13] dt-bindings: display: Convert ampire, am-480272h3tmqw-t01h panel to DT schema

2019-07-05 Thread Rob Herring
Convert the ampire,am-480272h3tmqw-t01h panel binding to DT schema. Cc: Yannick Fertre Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Acked-by: Thierry Reding Signed-off-by: Rob Herring ---

[PATCH v3 10/13] dt-bindings: display: Convert innolux, ee101ia-01 panel to DT schema

2019-07-05 Thread Rob Herring
Convert the innolux,ee101ia-01 LVDS panel binding to DT schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Acked-by: Thierry Reding Signed-off-by: Rob Herring --- .../display/panel/innolux,ee101ia-01d.txt | 7

[PATCH v3 07/13] dt-bindings: display: Convert raspberrypi, 7inch-touchscreen panel to DT schema

2019-07-05 Thread Rob Herring
Convert the raspberrypi,7inch-touchscreen panel binding to DT schema. Cc: Eric Anholt Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../panel/raspberrypi,7inch-touchscreen.txt | 49

[PATCH v3 13/13] dt-bindings: display: Convert sgd,gktw70sdae4se panel to DT schema

2019-07-05 Thread Rob Herring
Convert the sgd,gktw70sdae4se LVDS panel binding to DT schema. Cc: Neil Armstrong Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/sgd,gktw70sdae4se.txt | 41 ---

[PATCH v3 00/13] Conversion of panel bindings to DT schema

2019-07-05 Thread Rob Herring
This series converts the common panel bindings to DT schema format. Besides the conversion of common panel properties, a few panel bindings are converted here as well. These are all the ones with references to panel-common.txt or panel-lvds.txt. I'll apply the series to drm-misc. One patch

[PATCH v3 09/13] dt-bindings: display: Convert panel-lvds to DT schema

2019-07-05 Thread Rob Herring
Convert the panel-lvds binding to use DT schema. The panel-lvds schema inherits from the panel-common.yaml schema and specific LVDS panel bindings should inherit from this schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime

[PATCH v3 08/13] dt-bindings: display: Convert tfc, s9700rtwv43tr-01b panel to DT schema

2019-07-05 Thread Rob Herring
Convert the tfc,s9700rtwv43tr-01b panel binding to DT schema. Cc: Heiko Stuebner Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/tfc,s9700rtwv43tr-01b.txt | 15

[PATCH v3 03/13] dt-bindings: display: Convert armadeus, st0700-adapt panel to DT schema

2019-07-05 Thread Rob Herring
Convert the armadeus,st0700-adapt panel binding to DT schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/armadeus,st0700-adapt.txt | 9 -

[PATCH v3 04/13] dt-bindings: display: Convert bananapi, s070wv20-ct16 panel to DT schema

2019-07-05 Thread Rob Herring
Convert the bananapi,s070wv20-ct16 panel binding to DT schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Maxime Ripard Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maxime Ripard Signed-off-by: Rob Herring --- .../display/panel/bananapi,s070wv20-ct16.txt | 12 ---

[Bug 110886] After S3 resume, kernel: [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:57:crtc-0] flip_done timed out

2019-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110886 --- Comment #4 from Kai-Heng Feng --- (In reply to Alex Deucher from comment #3) > Is this a regression? If so, can you bisect? No this is not a regression. This issue (S3 resume fail) also happens on previous kernel versions, but without any

[Bug 110886] After S3 resume, kernel: [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:57:crtc-0] flip_done timed out

2019-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110886 --- Comment #3 from Alex Deucher --- Is this a regression? If so, can you bisect? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[PATCH][next] drm/exynos: remove redundant assignment to pointer 'node'

2019-07-05 Thread Colin King
From: Colin Ian King The pointer 'node' is being assigned with a value that is never read and is re-assigned later. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- 1 file

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-05 Thread Marek Olšák
On Fri, Jul 5, 2019 at 5:27 AM Timur Kristóf wrote: > On Wed, 2019-07-03 at 14:44 -0400, Marek Olšák wrote: > > You can run: > > AMD_DEBUG=testdmaperf glxgears > > > > It tests transfer sizes of up to 128 MB, and it tests ~60 slightly > > different methods of transfering data. > > > > Marek > >

Re: [PATCH -next] video: fbdev: imxfb: fix a typo in imxfb_probe()

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 7/4/19 11:52 AM, Wei Yongjun wrote: > Fix the return value check which testing the wrong variable > in imxfb_probe(). I added following comment while merging the patch: b.zolnierkie: please note that ->screen_base and ->screen_buffer are equivalent (they are part of unnamed union in struct

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:01 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_blank’: >

Re: [PATCH] drm/doc: Document kapi doc expectations

2019-07-05 Thread Daniel Vetter
On Thu, Jul 04, 2019 at 04:50:54PM +0200, Daniel Vetter wrote: > We've had this already for anything new. With my drm_prime.c cleanup I > also think documentation for everything already existing is complete, > and we can bake this in as a requirements subsystem wide. > > v2: Improve wording a bit

[Bug 106795] Laptop with Intel+Nvidia hybrid graphics won't suspend after hibernation

2019-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106795 --- Comment #1 from network...@rkmail.ru --- Created attachment 144714 --> https://bugs.freedesktop.org/attachment.cgi?id=144714=edit kernel error message Still happening as of kernel 5.1.16 -- You are receiving this mail because: You are

[PATCH v1] drm/tegra: Fix gpiod_get_from_of_node() regression

2019-07-05 Thread Dmitry Osipenko
That function now returns ERR_PTR instead of NULL if "hpd-gpio" is not present in device-tree. The offending patch missed to adapt the Tegra's DRM driver for the API change. Fixes: 025bf37725f1 ("gpio: Fix return value mismatch of function gpiod_get_from_of_node()") Signed-off-by: Dmitry

Re: [PATCH 09/11] video: fbdev: sm501fb: convert platform driver to use dev_groups

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 7/4/19 10:46 AM, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a bunch of sysfs files. > > Cc: Bartlomiej Zolnierkiewicz > Cc:

Re: [PATCH 08/11] video: fbdev: w100fb: convert platform driver to use dev_groups

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 7/4/19 10:46 AM, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a bunch of sysfs files. > > Cc: Tony Prisk > Cc: Bartlomiej

Re: [PATCH 07/11] video: fbdev: wm8505fb: convert platform driver to use dev_groups

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 7/4/19 4:26 PM, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a sysfs file. > > Cc: Tony Prisk > Cc: Bartlomiej Zolnierkiewicz > Cc:

AMDGPU mesa3d ABI specs

2019-07-05 Thread sylvain . bertrand
Hi, Is there a document which describes, with implementat-able accuracy, the mesa3d ABI for amdgpu? Namely, proper document to generate a mesa3d loadable ELF object, and what GPU state shader code can expect to run. regards, -- Sylvain ___

[PATCH v2] drm/sysfs: Add mstpath attribute to connector devices

2019-07-05 Thread sunpeng.li
From: Leo Li This can be used to create more descriptive symlinks for MST aux devices. Consider the following udev rule: SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{mstpath}=="?*", SYMLINK+="drm_dp_aux/by-path/$attr{mstpath}" The following symlinks will be created (depending

Re: [PATCH] drm/etnaviv: clean up includes

2019-07-05 Thread Sam Ravnborg
Hi Lucas. On Thu, Jul 04, 2019 at 12:43:37PM +0200, Lucas Stach wrote: > Drop unused includes, move more includes from the generic etnaviv_drv.h to > the units where they are actually used, sort includes. > > Signed-off-by: Lucas Stach Tedious work But looks good. Acked-by: Sam Ravnborg

Re: [PATCH v7 07/11] drm: Add Content protection type property

2019-07-05 Thread Pekka Paalanen
On Fri, 5 Jul 2019 12:03:18 +0530 Ramalingam C wrote: > On 2019-07-05 at 16:00:37 +0300, Pekka Paalanen wrote: > > On Thu, 4 Jul 2019 16:06:05 +0530 > > Ramalingam C wrote: > > > > > On 2019-07-04 at 14:11:59 +0300, Pekka Paalanen wrote: > > > > On Tue, 7 May 2019 21:57:41 +0530 > > > >

Re: [PATCH v6 15/18] drm/virtio: rework virtio_gpu_transfer_to_host_ioctl fencing

2019-07-05 Thread Gerd Hoffmann
> > > ... 3d case passes the objs list to virtio_gpu_cmd_transfer_to_host_3d, > > > so it gets added to the vbuf and released when the command is finished. > > Why doesn't this apply to virtio_gpu_cmd_transfer_to_host_2d? > > Hmm, yes, makes sense to handle both the same way. > > With virgl=off

Re: [PATCH 03/10] drm/sysfs: Add mstpath attribute to connector devices

2019-07-05 Thread Li, Sun peng (Leo)
On 2019-07-04 3:33 p.m., Ville Syrjälä wrote: > On Thu, Jul 04, 2019 at 03:05:12PM -0400, sunpeng...@amd.com wrote: >> From: Leo Li >> >> This can be used to create more descriptive symlinks for MST aux >> devices. Consider the following udev rule: >> >> SUBSYSTEM=="drm_dp_aux_dev",

Re: [PATCH v7 10/11] drm/hdcp: update content protection property with uevent

2019-07-05 Thread Pekka Paalanen
On Thu, 4 Jul 2019 16:41:15 +0530 Ramalingam C wrote: > On 2019-07-04 at 14:14:19 +0300, Pekka Paalanen wrote: > > On Tue, 7 May 2019 21:57:44 +0530 > > Ramalingam C wrote: > > > > > drm function is defined and exported to update a connector's > > > content protection property state and to

Re: [PATCH 5/5] RFC: MAINTAINERS: maintain drm/arm drivers in drm-misc for now

2019-07-05 Thread Liviu Dudau
On Fri, Jul 05, 2019 at 02:10:06PM +0200, Daniel Vetter wrote: > From discussions with Liviu it sounded like the komeda team would > benefit a bit from more cross-review with other drivers. To make sure > komeda is aligned with how similar problems are solved in other > drivers (in the end

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 6:55 AM Michel Dänzer wrote: > > On 2019-07-03 1:04 p.m., Timur Kristóf wrote: > > > >>> There may be other factors, yes. I can't offer a good explanation > >>> on > >>> what exactly is happening, but it's pretty clear that amdgpu can't > >>> take > >>> full advantage of

Re: [PATCH v7 09/11] drm: uevent for connector status change

2019-07-05 Thread Pekka Paalanen
On Thu, 4 Jul 2019 16:12:10 +0530 Ramalingam C wrote: > On 2019-07-04 at 14:12:27 +0300, Pekka Paalanen wrote: > > On Tue, 7 May 2019 21:57:43 +0530 > > Ramalingam C wrote: > > > > > DRM API for generating uevent for a status changes of connector's > > > property. > > > > > > This uevent

Re: [PATCH v7 07/11] drm: Add Content protection type property

2019-07-05 Thread Ramalingam C
On 2019-07-05 at 16:00:37 +0300, Pekka Paalanen wrote: > On Thu, 4 Jul 2019 16:06:05 +0530 > Ramalingam C wrote: > > > On 2019-07-04 at 14:11:59 +0300, Pekka Paalanen wrote: > > > On Tue, 7 May 2019 21:57:41 +0530 > > > Ramalingam C wrote: > > > > > > > This patch adds a DRM ENUM property

Re: [PATCH v7 07/11] drm: Add Content protection type property

2019-07-05 Thread Pekka Paalanen
On Thu, 4 Jul 2019 16:06:05 +0530 Ramalingam C wrote: > On 2019-07-04 at 14:11:59 +0300, Pekka Paalanen wrote: > > On Tue, 7 May 2019 21:57:41 +0530 > > Ramalingam C wrote: > > > > > This patch adds a DRM ENUM property to the selected connectors. > > > This property is used for mentioning

Re: [PATCH -next] drm/i915: Remove set but not used variable 'encoder'

2019-07-05 Thread Ville Syrjälä
On Fri, Jul 05, 2019 at 11:31:12AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/intel_dp.c: In function > 'intel_dp_set_drrs_state': > drivers/gpu/drm/i915/display/intel_dp.c:6623:24: warning: > variable 'encoder' set but not used

Re: [PATCH -next] drm/i915: Remove set but not used variable 'intel_dig_port'

2019-07-05 Thread Ville Syrjälä
On Fri, Jul 05, 2019 at 11:31:38AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/intel_ddi.c: In function 'intel_ddi_get_config': > drivers/gpu/drm/i915/display/intel_ddi.c:3774:29: warning: > variable 'intel_dig_port' set but not used

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. Good to have the audio graph card support, looks ok. Reviewed-by: Philippe Cornu Philippe :-) On 7/3/19 10:04 AM, Olivier Moysan wrote: > Implement get_dai_id callback of audio HDMI codec > to support ASoC audio graph card. > HDMI audio output has to

Re: [PATCH] drm/komeda: Adds VRR support

2019-07-05 Thread james qian wang (Arm Technology China)
On Fri, Jul 05, 2019 at 09:23:20AM +0200, Daniel Vetter wrote: > On Thu, Jul 4, 2019 at 5:41 PM Brian Starkey wrote: > > > > Hi, > > > > On Thu, Jul 04, 2019 at 11:57:00AM +0100, james qian wang (Arm Technology > > China) wrote: > > > On Wed, Jul 03, 2019 at 12:01:49PM +0200, Daniel Vetter

Re: [PATCH 3/3] drm/bridge: sii902x: make audio mclk optional

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. Reviewed-by: Philippe Cornu Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > The master clock on i2s bus is not mandatory, > as sii902X internal PLL can be used instead. > Make use of mclk optional. > > Fixes: ff5781634c41 ("drm/bridge:

Re: [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. I have double checked in the sil9022/24 datasheet and you are right: "As an option, the original MCLK signal used to strobe the I2S signals out from the sourcing chip can be used. If the internal PLL is used, then an external MCLK input is not

Re: [PATCH] drm/komeda: Adds VRR support

2019-07-05 Thread james qian wang (Arm Technology China)
On Thu, Jul 04, 2019 at 11:41:38PM +0800, Brian Starkey wrote: > Hi, > > On Thu, Jul 04, 2019 at 11:57:00AM +0100, james qian wang (Arm Technology > China) wrote: > > On Wed, Jul 03, 2019 at 12:01:49PM +0200, Daniel Vetter wrote: > > > > > > Uh, what exactly are you doing reinventing uapi

Re: [PATCH 5/5] RFC: MAINTAINERS: maintain drm/arm drivers in drm-misc for now

2019-07-05 Thread Maxime Ripard
On Fri, Jul 05, 2019 at 02:10:06PM +0200, Daniel Vetter wrote: > From discussions with Liviu it sounded like the komeda team would > benefit a bit from more cross-review with other drivers. To make sure > komeda is aligned with how similar problems are solved in other > drivers (in the end

Re: [PATCH 2/2] drm/komeda: Computing layer_split and image_enhancer internally

2019-07-05 Thread Daniel Vetter
On Fri, Jul 05, 2019 at 11:44:45AM +, james qian wang (Arm Technology China) wrote: > For layer_split: > Enable it if the scaling exceed the accept range of scaler. > > For image_enhancer: > Enable it if the scaling is a 2x+ scaling Imo should be two patches. Aside from that (and with 0

Re: [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. I do not see how audio could work without your patch, so: Reviewed-by: Philippe Cornu Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > Add devm_clk_get call to retrieve reference to master clock. > > Fixes: ff5781634c41 ("drm/bridge: sii902x:

Re: [PATCH 1/2] drm/komeda: Disable slave pipeline support

2019-07-05 Thread Daniel Vetter
On Fri, Jul 05, 2019 at 11:44:16AM +, james qian wang (Arm Technology China) wrote: > Since the property slave_planes have been removed, to avoid the resource > assignment problem in user disable slave pipeline support temporarily. > > Signed-off-by: james qian wang (Arm Technology China) >

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-05 Thread Mark Brown
On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > > +typedef void (*hdmi_codec_plugged_cb)(struct platform_device *dev, > > + bool plugged); > > + > The callback prototype is "weird" by

[PATCH 5/5] RFC: MAINTAINERS: maintain drm/arm drivers in drm-misc for now

2019-07-05 Thread Daniel Vetter
From discussions with Liviu it sounded like the komeda team would benefit a bit from more cross-review with other drivers. To make sure komeda is aligned with how similar problems are solved in other drivers (in the end everyone ends up with similar ideas on how to solve various display engine

[PATCH 2/5] drm/komeda: remove slave_planes property

2019-07-05 Thread Daniel Vetter
Properties are uapi like anything else, with all the usual rules regarding review, testcases, open source userspace ... Furthermore driver-private kms properties are highly discouraged, over the past few years we've realized we need to make a serious effort at better standardizing this stuff.

[PATCH 3/5] drm/komeda: remove img_enhancement property

2019-07-05 Thread Daniel Vetter
Properties are uapi like anything else, with all the usual rules regarding review, testcases, open source userspace ... Furthermore driver-private kms properties are highly discouraged, over the past few years we've realized we need to make a serious effort at better standardizing this stuff.

[PATCH 4/5] drm/komeda: Remove layer_split property

2019-07-05 Thread Daniel Vetter
Properties are uapi like anything else, with all the usual rules regarding review, testcases, open source userspace ... Furthermore driver-private kms properties are highly discouraged, over the past few years we've realized we need to make a serious effort at better standardizing this stuff.

[PATCH 1/5] drm/komeda: Remove clock ratio property

2019-07-05 Thread Daniel Vetter
Properties are uapi like anything else, with all the usual rules regarding review, testcases, open source userspace ... Furthermore driver-private kms properties are highly discouraged, over the past few years we've realized we need to make a serious effort at better standardizing this stuff.

[PATCH 2/2] drm/komeda: Computing layer_split and image_enhancer internally

2019-07-05 Thread james qian wang (Arm Technology China)
For layer_split: Enable it if the scaling exceed the accept range of scaler. For image_enhancer: Enable it if the scaling is a 2x+ scaling Signed-off-by: james qian wang (Arm Technology China) --- .../gpu/drm/arm/display/komeda/komeda_pipeline.h | 3 ++-

[PATCH 1/2] drm/komeda: Disable slave pipeline support

2019-07-05 Thread james qian wang (Arm Technology China)
Since the property slave_planes have been removed, to avoid the resource assignment problem in user disable slave pipeline support temporarily. Signed-off-by: james qian wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1

[GIT PULL] drm/imx: IPUv3 image converter improvements, enable scanout FIFO watermark

2019-07-05 Thread Philipp Zabel
Hi Dave, Daniel, please consider merging these (mostly image converter) updates for v5.3. This series changes the API between ipu-v3 and the imx-media driver to enable improved colorimetry configuration of the image converter, and so it contains commits that touch drivers/staging/media. As a

Re: [PATCH 0/4] Add a generic driver for LED-based backlight

2019-07-05 Thread Jean-Jacques Hiblot
On 05/07/2019 12:14, Pavel Machek wrote: On Mon 2019-07-01 17:14:19, Jean-Jacques Hiblot wrote: This series takes it from there and implements the binding that was discussed in https://patchwork.kernel.org/patch/7293991/. In this new binding the backlight device is a child of the LED

[PATCH -next] drm/i915: Remove set but not used variable 'encoder'

2019-07-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/i915/display/intel_dp.c: In function 'intel_dp_set_drrs_state': drivers/gpu/drm/i915/display/intel_dp.c:6623:24: warning: variable 'encoder' set but not used [-Wunused-but-set-variable] It's never used, so can be removed.Also remove

[PATCH -next] drm/i915: Remove set but not used variable 'intel_dig_port'

2019-07-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/i915/display/intel_ddi.c: In function 'intel_ddi_get_config': drivers/gpu/drm/i915/display/intel_ddi.c:3774:29: warning: variable 'intel_dig_port' set but not used [-Wunused-but-set-variable] struct intel_digital_port

Re: [PATCH v5 08/12] dt-bindings: mediatek: Change the binding for mmsys clocks

2019-07-05 Thread Matthias Brugger
On 05/07/2019 03:35, CK Hu wrote: > Hi, Uli: > > On Thu, 2019-07-04 at 17:33 +0200, Ulrich Hecht wrote: >>> On July 4, 2019 at 11:08 AM Matthias Brugger wrote: >>> You are right, it took far too long for me to respond with a new version of >>> the >>> series. The problem I face is, that I use

Re: [PATCH 3/4] backlight: add led-backlight driver

2019-07-05 Thread Jean-Jacques Hiblot
Pavel On 05/07/2019 12:08, Pavel Machek wrote: Hi! Also still relevant is whether the LED device is being correctly modelled if the act of turning on the LED doesn't, in fact, turn the LED on. Is it *really* a correct implementation of an LED device that setting it to LED_FULL using sysfs

[Bug 203963] Unable to overclock memory while core is overclocking fine. RX560X

2019-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203963 --- Comment #1 from Haxk20 (haxk...@gmail.com) --- I just tried overclocking with setting ppmask and im not now able to even overclock the core. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE

2019-07-05 Thread Philipp Zabel
Hi Wen, On Wed, 2019-05-08 at 10:56 +, Wen He wrote: > The new LS1028A DP driver code causes a link failure when DRM_IMX built-in, > but platform is ARCH_LAYERSCAPE: > > drivers/gpu/drm/imx/ipuv3-crtc.c:51: undefined reference to `ipu_prg_enable' > drivers/gpu/drm/imx/ipuv3-crtc.c:52:

Re: [PATCH 0/4] Add a generic driver for LED-based backlight

2019-07-05 Thread Daniel Thompson
On Fri, Jul 05, 2019 at 12:14:34PM +0200, Pavel Machek wrote: > On Mon 2019-07-01 17:14:19, Jean-Jacques Hiblot wrote: > > This series aims to add a led-backlight driver, similar to pwm-backlight, > > but using a LED class device underneath. > > > > A few years ago (2015), Tomi Valkeinen posted a

Re: [PATCH 0/4] Add a generic driver for LED-based backlight

2019-07-05 Thread Pavel Machek
On Mon 2019-07-01 17:14:19, Jean-Jacques Hiblot wrote: > This series aims to add a led-backlight driver, similar to pwm-backlight, > but using a LED class device underneath. > > A few years ago (2015), Tomi Valkeinen posted a series implementing a > backlight driver on top of a LED device: >

  1   2   >