Re: [PATCH v1] drm/i2c/tda998x: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Sun, Jun 30, 2019 at 07:21:13AM +0200, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > Fix fallout. > > Signed-off-by: Sam Ravnborg > Cc: Russell King > Cc: David Airlie > Cc: Daniel Vetter > --- > The patch is build tested using several configs and > several architec

Re: [PATCH v2 0/19] drm: drop use of drmp.h in drm-misc

2019-07-15 Thread Sam Ravnborg
Copied all recipients on the cover letter. As the list is long this mail may not hit the mailing lists. Sam On Tue, Jul 16, 2019 at 08:42:01AM +0200, Sam Ravnborg wrote: > This patch set removes a far share of the remaining uses of drmP.h. > Common for all patches are that the respective

[PATCH v2 15/19] drm/i2c/ch7006: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop using the deprecated drmP.h header file. Fix fallout. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/i2c/ch7006_priv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/ch7006_priv.h b/drivers/gpu/drm/i2c/ch

[PATCH v2 13/19] drm/i810: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header. Replace with necessary includes. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter Cc: Dan Carpenter --- drivers/gpu/drm/i810/i810_dma.c | 17 - drivers/gpu/drm/i810/i810_drv.c | 8 +--- driver

[PATCH v2 10/19] drm/selftests: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop the single user of drmP.h - replace it with relevant includes. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter Cc: Alexandru-Cosmin Gheorghe Cc: Maarten Lankhorst --- drivers/gpu/drm/selftests/test-drm_framebuffer.c | 7 ++- 1 file changed, 6 i

[PATCH v2 19/19] drm/mediatek: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. While touching the include files divide them up in blocks in the typical order: \#include \#include \#include \#include "" And sort the includes in the blocks Add the necessary includes to fix build after removal of drmP.h Signed-off-by: Sam

[PATCH v2 17/19] drm/imx: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. While touching the include files divide them in blocks and sort the include files within each block. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Shawn Guo Cc: Sascha Hauer Cc: Peng

[PATCH v2 14/19] drm/tilcdc: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Dropped drmP.h and all other header files not used by tilcdc_drv.h. Added the minimal includes and forwards to make the header file self-contained. Then dropped the remaining uses of drmP.h and fixed all fall-out. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Jyri Sarha Cc: Tomi Valke

[PATCH v2 18/19] drm/rockchip: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. While touching the list of include files move the blocks so they follow the common pattern: \#include \#include \#include \#include "" Within each block sort the include files. Add the includes needed to fix build after the removal of drmP.h.

[PATCH v2 07/19] drm/r128: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Replace use of the deprecated drmP.h header file with relevant includes. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/r128/r128_ioc32.c | 3 ++- drivers/gpu/drm/r128/r128_irq.c | 5 - 2 files changed, 6 insertions(+), 2 deleti

[PATCH v2 12/19] drm/vgem: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated header drmP.h. Replace with necessary includes in the individual .c files. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter Cc: Deepak Sharma Cc: Thomas Zimmermann --- drivers/gpu/drm/vgem/vgem_drv.c | 11 +-- drivers

[PATCH v2 06/19] drm/vc4: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated header drmP.h. Fix so vc4_drv.h is now self-contained, and fixed fall-out in remaining files. Divided include files in blocks. Sorted include files within their blocks. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Eric Anholt --- drivers/gpu/drm/vc4/vc4_cr

[PATCH v2 16/19] drm/i2c/sil164: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. Fix fallout. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter Cc: Francisco Jerez --- drivers/gpu/drm/i2c/sil164_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c

[PATCH v2 09/19] drm/omapdrm: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated header drmP.h. Rearranged list of include files to match rest of DRM too. The drmP.h file was deleted from the header file, and the necessary includes was added to the .c files to fix build. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Tomi Valkeinen Cc: Dav

[PATCH v2 11/19] drm/tdfx: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Replace drmP.h include with necessary include files. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/tdfx/tdfx_drv.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tdfx/tdfx_drv.c b/driv

[PATCH v2 08/19] drm/udl: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
The drmP.h header file is deprecated. Drop it from all files in the udl driver. Made the header files self contained, which then made it simpler to update the .c files. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Jani Nikula Cc: Ro

[PATCH v2 04/19] drm/zte: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. Fix fallout. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Shawn Guo Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/zte/zx_drm_drv.c | 3 ++- drivers/gpu/drm/zte/zx_hdmi.c| 2 +- drivers/gpu/drm/zte/zx_plane.c | 2 +- driv

[PATCH v2 05/19] drm/sun4i: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. While touching the list of include file, use the typical order of the blocks: \#include \#include \#include \#include "" Within each block, sort the files. Include necessary files to fix build after the drmP.h removal. Signed-off-by: Sam Ravnb

[PATCH v2 03/19] drm/pl111: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header. Sort includes in blocks while touching the files. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/pl111/pl111_debugfs.c | 4 +++- drivers/gpu/drm/pl111/pl111_display.c |

[PATCH v2 02/19] drm/v3d: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header file. Made v3d_drv.h self-contained with only sufficient include files. Fixed fallout in remaining files. Signed-off-by: Sam Ravnborg Acked-by: Emil Velikov Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/v3d/v3d_debugfs.c | 3

[PATCH v2 01/19] drm/meson: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header. While doing so used the opportunity to clean up a little so includes are now sorted and removed unused include files. In a few cases added some forwards to allow header files to built in different include order. Signed-off-by: Sam Ravnborg Acked-by: Emil

[PATCH v2 0/19] drm: drop use of drmp.h in drm-misc

2019-07-15 Thread Sam Ravnborg
This patch set removes a far share of the remaining uses of drmP.h. Common for all patches are that the respective files are maintained in drm-misc. All patches are independent. Patches have all been build tested with various configs and various architectures. There are likely introduced a few bui

Re: [git pull] drm pull for 5.3-rc1

2019-07-15 Thread pr-tracker-bot
The pull request you sent on Tue, 16 Jul 2019 04:37:38 +1000: > git://anongit.freedesktop.org/drm/drm drm-next-5.3-backmerge-conflicts has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/be8454afc50f43016ca8b6130d9673bdd0bd56ec Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH] Staging: fbtft: Fix GPIO handling

2019-07-15 Thread Nicolas Saenz Julienne
On Tue, 2019-07-16 at 00:04 +0900, Jan Sebastian Götte wrote: > Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor > interface") breaks GPIO handling. In several places, checks to only set > a GPIO if it was configured ended up backwards. > I have tested this fix. The fixed driver

[PATCH 0/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-15 Thread Phil Reid
GPIO probing and reset polarity are broken. Fix them. Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") Changes from v2: - Add fixes tag to "Fix reset assertion when using gpio descriptor" - Add tested-by / reviewed-by tags Phil Reid (2): Staging: fbtft: Fix probi

Re: [PATCH 6/7] drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

2019-07-15 Thread Nathan Chancellor
On Mon, Jul 15, 2019 at 11:25:29AM +0200, Arnd Bergmann wrote: > On Thu, Jul 4, 2019 at 7:52 AM Nathan Chancellor > wrote: > > > > clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:995:39: warning: > > implicit conversion from enumeration type 'PPCLK_e' to different > > enu

Re: [PATCH v7 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-07-15 Thread Dmitry Torokhov
On Mon, Jul 15, 2019 at 11:04 AM Dmitry Torokhov wrote: > > Hi, > > On Tue, Jul 02, 2019 at 11:39:56PM -0700, Life is hard, and then you die > wrote: > > > > On Tue, Jul 02, 2019 at 03:50:49PM +0200, Andrzej Hajda wrote: > > > On 19.04.2019 10:19, Ronald Tschalär wrote: > > > > commit d6abe6df706

Re: [PATCH 0/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-15 Thread Nicolas Saenz Julienne
On Thu, 2019-07-11 at 16:31 +0800, Phil Reid wrote: > GPIO probing and reset polarity are broken. > Fix them. > > Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor > interface") > > Phil Reid (2): > Staging: fbtft: Fix probing of gpio descriptor > Staging: fbtft: Fix reset a

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Jason Gunthorpe
On Mon, Jul 15, 2019 at 04:19:26PM +0200, Daniel Vetter wrote: > > Linus, do you have any advice on how best to handle sharing mm > > patches? The hmm.git was mildly painful as it sits between quilt on > > the -mm side and what seems like 'a world of interesting git things' > > on the DRM side (bu

Re: drm/amd/powerplay: remove redundant memset

2019-07-15 Thread Markus Elfring
> kzalloc has already zeroed the memory. > So the memset is unneeded. See also a previous patch: drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings() https://lore.kernel.org/lkml/de3f6a5e-8ac4-bc8e-0d0c-3a4a5db28...@web.de/ https://lore.kernel.org/patchwork/p

[PATCH] drm/amd/powerplay: remove redundant memset

2019-07-15 Thread Fuqian Huang
kzalloc has already zeroed the memory. So the memset is unneeded. Signed-off-by: Fuqian Huang --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c index 8fafcbdb1

[PATCH v2 1/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-15 Thread Phil Reid
Conversion to use gpio descriptors broke all gpio lookups as devm_gpiod_get_index was converted to use dev->driver->name for the gpio name lookup. Fix this by using the name param. In addition gpiod_get post-fixes the -gpios to the name so that shouldn't be included in the call. However this then b

[PATCH v2 2/2] Staging: fbtft: Fix reset assertion when using gpio descriptor

2019-07-15 Thread Phil Reid
Typically gpiod_set_value calls would assert the reset line and then release it using the symantics of: gpiod_set_value(par->gpio.reset, 0); ... delay gpiod_set_value(par->gpio.reset, 1); And the gpio binding would specify the polarity. Prior to conversion to gpiod calls th

Re: [git pull] drm pull for 5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 11:38 AM Dave Airlie wrote: > > The reason I was waiting for the HMM tree to land, is a single silent > merge conflict needs to be resolved after merging this as below. There's more than that there. For example, the DRM_AMDGPU_USERPTR config has a depends on ARCH

RE: [PATCH 6/7] drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

2019-07-15 Thread Quan, Evan
Thanks! This is reviewed-by: Evan Quan Regards Evan > -Original Message- > From: Nathan Chancellor > Sent: Monday, July 15, 2019 11:40 PM > To: Arnd Bergmann > Cc: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; Wentland, Harry ; > Li, Sun peng (Leo) ; Rex Zhu ; >

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-15 Thread Vasily Khoruzhick
On Fri, Jul 12, 2019 at 1:15 PM Maxime Ripard wrote: > > On Wed, Jul 10, 2019 at 03:11:04PM -0700, Vasily Khoruzhick wrote: > > On Wed, Jul 10, 2019 at 4:40 AM Maxime Ripard > > wrote: > > > > > > There's another issue: if we introduce edp-connector we'll have to > > > > > > specify power up del

[Bug 204145] amdgpu video playback causes host to hard reset (checkstop) on POWER9 with RX 580

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204145 --- Comment #7 from Daniel Kolesa (li...@octaforge.org) --- Maybe narrow it down first (i.e. find the last release that was good, by testing 5.1.14 first, and then bisect only history between the last good and first bad release. We know 5.1.9 is g

[Bug 204145] amdgpu video playback causes host to hard reset (checkstop) on POWER9 with RX 580

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204145 Timothy Pearson (tpear...@raptorengineering.com) changed: What|Removed |Added CC||tpearso

Re: [PATCH] gpu: drm: pl111: pl111_vexpress.c: Add of_node_put() before return

2019-07-15 Thread Eric Anholt
Nishka Dasgupta writes: > Each iteration of for_each_available_child_of_node puts the previous > node, but in the case of a break from the middle of the loop there is > no put, thus causing a memory leak. Hence add an of_node_put before the > break. > Issue found with Coccinelle. Pushed. Thanks

[Bug 111077] link_shader and deserialize_glsl_program suddenly consume huge amount of RAM

2019-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111077 --- Comment #6 from Timothy Arceri --- (In reply to rol...@rptd.ch from comment #4) > I tried compiling from source but it does not work. Seems to have troubles > with libdrm. > > configure: error: Package requirements (libdrm >= 2.4.75 libdrm_

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Brendan Higgins
On Mon, Jul 15, 2019 at 3:11 PM Brendan Higgins wrote: > > On Mon, Jul 15, 2019 at 3:04 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-07-15 14:11:50) > > > On Mon, Jul 15, 2019 at 1:43 PM Stephen Boyd wrote: > > > > > > > > I also wonder if it would be better to just have a big sl

Re: drm pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 1:07 PM Linus Torvalds wrote: > > The mm_walk struct is indeed a bit similar, and is in fact a bit > problematic exactly because it mixes function pointers with non-const > data. This made me look at how nasty that would be to fix. Not too bad. The attached patch does ad

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:30) > diff --git a/include/kunit/kunit-stream.h b/include/kunit/kunit-stream.h > new file mode 100644 > index 0..a7b53eabf6be4 > --- /dev/null > +++ b/include/kunit/kunit-stream.h > @@ -0,0 +1,81 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Brendan Higgins
On Mon, Jul 15, 2019 at 3:04 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-07-15 14:11:50) > > On Mon, Jul 15, 2019 at 1:43 PM Stephen Boyd wrote: > > > > > > I also wonder if it would be better to just have a big slop buffer of a > > > 4K page or something so that we almost never have

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-15 14:11:50) > On Mon, Jul 15, 2019 at 1:43 PM Stephen Boyd wrote: > > > > I also wonder if it would be better to just have a big slop buffer of a > > 4K page or something so that we almost never have to allocate anything > > with a string_stream and we can just re

Re: [PATCH v9 01/18] kunit: test: add KUnit test runner core

2019-07-15 Thread Brendan Higgins
On Mon, Jul 15, 2019 at 1:10 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-07-12 01:17:27) > > Add core facilities for defining unit tests; this provides a common way > > to define test cases, functions that execute code which is under test > > and determine whether the code under test

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Brendan Higgins
On Mon, Jul 15, 2019 at 1:43 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-07-12 01:17:29) > > diff --git a/include/kunit/string-stream.h b/include/kunit/string-stream.h > > new file mode 100644 > > index 0..0552a05781afe > > --- /dev/null > > +++ b/include/kunit/string-stre

Re: [PATCH v9 02/18] kunit: test: add test resource management API

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-15 13:30:22) > On Mon, Jul 15, 2019 at 1:24 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-07-12 01:17:28) > > > diff --git a/kunit/test.c b/kunit/test.c > > > index 571e4c65deb5c..f165c9d8e10b0 100644 > > > One solution would be to piggyback on all

Re: [PATCH v9 06/18] kbuild: enable building KUnit

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:32) > KUnit is a new unit testing framework for the kernel and when used is > built into the kernel as a part of it. Add KUnit to the root Kconfig and > Makefile to allow it to be actually built. > > Signed-off-by: Brendan Higgins > Acked-by: Masahiro Yam

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:29) > diff --git a/include/kunit/string-stream.h b/include/kunit/string-stream.h > new file mode 100644 > index 0..0552a05781afe > --- /dev/null > +++ b/include/kunit/string-stream.h > @@ -0,0 +1,49 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ >

Re: [PATCH v9 02/18] kunit: test: add test resource management API

2019-07-15 Thread Brendan Higgins
On Mon, Jul 15, 2019 at 1:24 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-07-12 01:17:28) > > diff --git a/kunit/test.c b/kunit/test.c > > index 571e4c65deb5c..f165c9d8e10b0 100644 > > --- a/kunit/test.c > > +++ b/kunit/test.c > > @@ -171,6 +175,96 @@ int kunit_run_tests(struct kunit_s

Re: [PATCH v9 02/18] kunit: test: add test resource management API

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:28) > diff --git a/kunit/test.c b/kunit/test.c > index 571e4c65deb5c..f165c9d8e10b0 100644 > --- a/kunit/test.c > +++ b/kunit/test.c > @@ -171,6 +175,96 @@ int kunit_run_tests(struct kunit_suite *suite) > return 0; > } > > +struct kunit_resource

Re: [PATCH v9 01/18] kunit: test: add KUnit test runner core

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:27) > Add core facilities for defining unit tests; this provides a common way > to define test cases, functions that execute code which is under test > and determine whether the code under test behaves as expected; this also > provides a way to group togeth

Re: drm pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 12:36 PM Thomas Hellström (VMware) wrote: > > - I've never had any kernel code more reviewed than this. Hmm. It may have been reviewed, but that wasn't visible in the commits themselves, so when I look at the pull request, I don't see that. > - The combined callback / arg

Re: drm pull for v5.3-rc1

2019-07-15 Thread VMware
Hi, All. On 7/15/19 8:00 PM, Linus Torvalds wrote: On Mon, Jul 15, 2019 at 10:37 AM Linus Torvalds wrote: I'm not pulling this. Why did you merge it into your tree, when apparently you were aware of how questionable it is judging by the drm pull request. Looking at some of the fallout, I also

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 12:17 PM Jason Gunthorpe wrote: > > About the only thing I could concretely suggest for working with -mm > is if there was some way the -mm quilt patches could participate in > 'git merge' resolution at your level. Andrew did make noises about having multiple git branches.

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Jason Gunthorpe
On Mon, Jul 15, 2019 at 11:16:11AM -0700, Linus Torvalds wrote: > [ Ugh, I have three different threads about the drm pull because of > the subject / html confusion. So now I'm replying in separate threads > and I'm hoping the people involved have better threading than gmail > does ;/ ] > > On Mon

[Bug 106447] System freeze after resuming from suspend (amdgpu)

2019-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106447 --- Comment #18 from richard --- Hello , i don't know if this is the correct place to state this, but i have a Desktop PC running Ubuntu 16.04 and i noticed too that the system won't resume from suspend after installation of amdgpu-driver

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 11:16 AM Linus Torvalds wrote: > > On Mon, Jul 15, 2019 at 5:29 AM Jason Gunthorpe wrote: > > > > The 'hmm' tree is something I ran to try and help workflow issues like > > this, as it could be merged to DRM as a topic branch - maybe consider > > this flow in future? > > >

[PATCH libdrm 3/3] intel: Add support for EHL

2019-07-15 Thread Lucas De Marchi
From: Rodrigo Vivi Add the PCI ID import for EHL. Cc: Rodrigo Vivi Signed-off-by: James Ausmus Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 157c2c7d..f6e37ee7 100644 --- a/inte

[PATCH libdrm 2/3] intel: add the TGL 12 PCI IDs and macros

2019-07-15 Thread Lucas De Marchi
From: Rodrigo Vivi Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 1 + intel/intel_chipset.h | 1 + 2 files changed, 2 insertions(+) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 5aa4a2f2..157c2c7d 100644 --- a/intel/intel_chipset.c +++ b/intel/

[PATCH libdrm 1/3] intel: sync i915_pciids.h with kernel

2019-07-15 Thread Lucas De Marchi
Straight copy from the kernel file, aligned with drm-intel-next-queued commit cb823ed9915b ("drm/i915/gt: Use intel_gt as the primary object for handling resets") Signed-off-by: Lucas De Marchi --- intel/i915_pciids.h | 194 1 file changed, 141 insert

Re: drm pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 11:29 AM Dave Airlie wrote: > > Not that I want to defend that code, but the mm patch that conflicts > already shows that removing the token is fine as nobody needs or > requires it. So the fixup patch in my tree was just a bridge to that patch, > which reduces conflicts. R

Re: drm pull for v5.3-rc1

2019-07-15 Thread Dave Airlie
On Tue, 16 Jul 2019 at 04:00, Linus Torvalds wrote: > > On Mon, Jul 15, 2019 at 10:37 AM Linus Torvalds > wrote: > > > > I'm not pulling this. Why did you merge it into your tree, when > > apparently you were aware of how questionable it is judging by the drm > > pull request. > > Looking at some

Re: drm pull for v5.3-rc1

2019-07-15 Thread Dave Airlie
On Tue, 16 Jul 2019 at 03:38, Linus Torvalds wrote: > > On Mon, Jul 15, 2019 at 12:08 AM Dave Airlie wrote: > > > > VMware had some mm helpers go in via my tree (looking back I'm not > > sure Thomas really secured enough acks on these, but I'm going with it > > for now until I get push back). > >

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
[ Ugh, I have three different threads about the drm pull because of the subject / html confusion. So now I'm replying in separate threads and I'm hoping the people involved have better threading than gmail does ;/ ] On Mon, Jul 15, 2019 at 5:29 AM Jason Gunthorpe wrote: > > The 'hmm' tree is some

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Daniel Vetter
On Mon, Jul 15, 2019 at 7:57 PM Jason Gunthorpe wrote: > > On Mon, Jul 15, 2019 at 07:53:06PM +0200, Daniel Vetter wrote: > > > > So, I'll put it on a topic and send you two a note next week to decide > > > if you want to merge it or not. I'm really unclear how nouveau's and > > > AMD's patchflow

Re: [PATCH v7 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-07-15 Thread Dmitry Torokhov
Hi, On Tue, Jul 02, 2019 at 11:39:56PM -0700, Life is hard, and then you die wrote: > > On Tue, Jul 02, 2019 at 03:50:49PM +0200, Andrzej Hajda wrote: > > On 19.04.2019 10:19, Ronald Tschalär wrote: > > > commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency > > > of RC_CORE) cha

Re: drm pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 10:37 AM Linus Torvalds wrote: > > I'm not pulling this. Why did you merge it into your tree, when > apparently you were aware of how questionable it is judging by the drm > pull request. Looking at some of the fallout, I also see that you then added that "adjust apply_to_

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Jason Gunthorpe
On Mon, Jul 15, 2019 at 07:53:06PM +0200, Daniel Vetter wrote: > > So, I'll put it on a topic and send you two a note next week to decide > > if you want to merge it or not. I'm really unclear how nouveau's and > > AMD's patchflow works.. > > DRM is 2-level for pretty much everything. First it la

Re: DRM pull for v5.3-rc1

2019-07-15 Thread Daniel Vetter
On Mon, Jul 15, 2019 at 5:04 PM Jason Gunthorpe wrote: > > On Mon, Jul 15, 2019 at 04:19:26PM +0200, Daniel Vetter wrote: > > > > Linus, do you have any advice on how best to handle sharing mm > > > patches? The hmm.git was mildly painful as it sits between quilt on > > > the -mm side and what see

Re: drm pull for v5.3-rc1

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 12:08 AM Dave Airlie wrote: > > VMware had some mm helpers go in via my tree (looking back I'm not > sure Thomas really secured enough acks on these, but I'm going with it > for now until I get push back). Yeah, this is the kind of completely unacceptable stuff that I was

[Bug 111139] linux 5.2: rare NULL pointer dereference when SteamVR idles

2019-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39 Bug ID: 39 Summary: linux 5.2: rare NULL pointer dereference when SteamVR idles Product: DRI Version: DRI git Hardware: Other OS: All Statu

[Bug 111122] 2500U: Graphics corruption on kernel 5.2

2019-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=22 --- Comment #4 from Chí-Thanh Christopher Nguyễn --- Same symptoms here after upgrading from Linux 5.1 to 5.2 on Dell Latitude 5495, Ryzen Pro 2700U. Graphical corruption, and/or the GUI will stop responding. Magic SysRq is needed to reboot the

Re: [PATCH v1 33/33] drm/hisilicon: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Mon, Jul 15, 2019 at 11:34:51AM +0100, Emil Velikov wrote: > On 2019/07/15, Sam Ravnborg wrote: > > Hi Emil. > > > > > > --- > > > > The list of cc: was too large to add all recipients to the cover letter. > > > > Please find cover letter here: > > > > https://lists.freedesktop.org/archives/dri

Re: [PATCH v1 32/33] drm/ast: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Sun, Jun 30, 2019 at 09:34:49AM +0200, Thomas Zimmermann wrote: > Acked-by: Thomas Zimmermann Thanks, applied. sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 31/33] drm/bochs: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Mon, Jul 01, 2019 at 08:39:08AM +0200, Gerd Hoffmann wrote: > On Sun, Jun 30, 2019 at 08:19:20AM +0200, Sam Ravnborg wrote: > > Drop use of the deprecated drmP.h header file. > > Made bochs.h self-contained and then fixed > > fallout in remaining files. > > Several unused includes was dropped in

Re: [PATCH v1 30/33] drm: add missing include to drm_vram_mm_helper.h

2019-07-15 Thread Sam Ravnborg
On Tue, Jul 02, 2019 at 03:35:52PM +0200, Daniel Vetter wrote: > On Sun, Jun 30, 2019 at 08:19:19AM +0200, Sam Ravnborg wrote: > > The macro DRM_VRAM_MM_FILE_OPERATIONS referencs > > functions declared in other header files. > > Include these header files so this header files > > pulls in what it r

Re: [PATCH v1 27/33] drm/virtgpu: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Mon, Jul 01, 2019 at 08:38:56AM +0200, Gerd Hoffmann wrote: > On Sun, Jun 30, 2019 at 08:19:16AM +0200, Sam Ravnborg wrote: > > Drop use of the deprecated drmP.h header file. > > Fix fallout by adding missing include files. > > > > Signed-off-by: Sam Ravnborg > > Cc: David Airlie > > Cc: Gerd

Re: [PATCH v1 25/33] drm/scheduler: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Sun, Jun 30, 2019 at 12:08:26PM +, Koenig, Christian wrote: > Am 30.06.19 um 08:19 schrieb Sam Ravnborg: > > Drop use of the deprecated drmP.h header file. > > Fix fallout. > > > > Signed-off-by: Sam Ravnborg > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Alex Deucher > > Cc: Andrey

Re: [PATCH v1 12/33] drm/vkms: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Tue, Jul 09, 2019 at 12:00:20PM -0300, Rodrigo Siqueira wrote: > On Sun, Jun 30, 2019 at 3:19 AM Sam Ravnborg wrote: > > > > Drop use of the deprecated drmP.h header. > > Replace it with the necessary includes in the individual .c files. > > The header files was self-contained, and extra includ

Re: [PATCH v1 14/33] drm/atmel_hlcdc: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Mon, Jul 15, 2019 at 10:15:37AM +0200, Boris Brezillon wrote: > On Sun, 30 Jun 2019 08:19:03 +0200 > Sam Ravnborg wrote: > > > Drop use of the deprecated header drmP.h. > > Make header file self-contained, with only the required set > > of include files. > > And fixed fallout in remaining file

Re: [PATCH v1 08/33] drm/fsl-dcu: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Fri, Jul 05, 2019 at 10:46:50PM +0200, Stefan Agner wrote: > On 2019-06-30 08:18, Sam Ravnborg wrote: > > Drop use of the deprecated drmP.h header file. > > Fix fallout. > > > > Signed-off-by: Sam Ravnborg > > Cc: Stefan Agner > > Cc: Alison Wang > > Acked-by: Stefan Agner Thanks, applied

Re: [PATCH v1 09/33] drm/qxl: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Mon, Jul 01, 2019 at 08:38:43AM +0200, Gerd Hoffmann wrote: > On Sun, Jun 30, 2019 at 08:18:58AM +0200, Sam Ravnborg wrote: > > Drop use of the deprecated drmP.h header file. > > While touching the files divided includes in blocks, > > and when needed sort the blocks. > > Fix fallout. > > > > S

Re: [PATCH v1 05/33] drm/mxsfb: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Fri, Jul 05, 2019 at 10:47:30PM +0200, Stefan Agner wrote: > On 2019-06-30 08:18, Sam Ravnborg wrote: > > Drop use of the deprecated drmP.h header file. > > > > While touching the list of include files divided them > > in blocks and sort them within each block. > > Fixed fallout in the relevant

Re: [PATCH v1 02/33] drm/xen: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Mon, Jul 01, 2019 at 08:05:24AM +0200, Sam Ravnborg wrote: > Hi Oleksandr > > > > --- a/drivers/gpu/drm/xen/xen_drm_front.h > > > +++ b/drivers/gpu/drm/xen/xen_drm_front.h > > > @@ -11,13 +11,19 @@ > > > #ifndef __XEN_DRM_FRONT_H_ > > > #define __XEN_DRM_FRONT_H_ > > > -#include > > > -#in

Re: [PATCH v1 04/33] drm/tve200: drop use of drmP.h

2019-07-15 Thread Sam Ravnborg
On Thu, Jul 04, 2019 at 09:32:10AM +0200, Linus Walleij wrote: > On Sun, Jun 30, 2019 at 8:19 AM Sam Ravnborg wrote: > > > Drop use of the deprecated header drmP.h. > > > > Fix so header file became self-contained, > > and then fixed fallout in the other files. > > > > Signed-off-by: Sam Ravnborg

Re: [PATCH v3 05/24] drm/amdgpu: remove memset after kzalloc

2019-07-15 Thread Alex Deucher
On Mon, Jul 15, 2019 at 3:57 AM Fuqian Huang wrote: > > kzalloc has already zeroed the memory during the allocation. > So memset is unneeded. > > Signed-off-by: Fuqian Huang Applied. thanks! Alex > --- > Changes in v3: > - Fix subject prefix: gpu/drm -> drm/amdgpu > > drivers/gpu/drm/amd/di

Re: [PATCH] drm/amd/amdgpu: hide #warning for missing DC config

2019-07-15 Thread Alex Deucher
On Fri, Jul 12, 2019 at 5:41 AM Arnd Bergmann wrote: > > It is annoying to have #warnings that trigger in randconfig > builds like > > drivers/gpu/drm/amd/amdgpu/soc15.c:653:3: error: "Enable CONFIG_DRM_AMD_DC > for display support on SOC15." > drivers/gpu/drm/amd/amdgpu/nv.c:400:3: error: "Enabl

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #11 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283709 --> https://bugzilla.kernel.org/attachment.cgi?id=283709&action=edit /proc/interrupts -- You are receiving this mail because: You are watching the assig

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #10 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- Thanks for all the logs. I meant drm.debug=4 actually, the drm=debug=4 was a typo on my part - sorry! -- You are receiving this mail because: You are watching the assign

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #9 from Sergey Kondakov (virtuous...@gmail.com) --- (In reply to Nicholas Kazlauskas from comment #1) > Do you mind posting an dmesg log with drm=debug=4 as part of your boot > parameters? > > An xorg log would be good too if applicab

Re: [PATCH v3 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-15 Thread Tzung-Bi Shih
On Fri, Jul 12, 2019 at 6:58 PM Russell King - ARM Linux admin wrote: > > On Fri, Jul 12, 2019 at 06:04:39PM +0800, Cheng-Yi Chiang wrote: > > Add an op in hdmi_codec_ops so codec driver can register callback > > function to handle plug event. > > > > Driver in DRM can use this callback function t

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #8 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283707 --> https://bugzilla.kernel.org/attachment.cgi?id=283707&action=edit lspci -t -PP -q -k -v -- You are receiving this mail because: You are watching the a

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #7 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283705 --> https://bugzilla.kernel.org/attachment.cgi?id=283705&action=edit lspci -vv -- You are receiving this mail because: You are watching the assignee of t

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #6 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283703 --> https://bugzilla.kernel.org/attachment.cgi?id=283703&action=edit lsmem -- You are receiving this mail because: You are watching the assignee of the b

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #5 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283701 --> https://bugzilla.kernel.org/attachment.cgi?id=283701&action=edit X.log amdgpu has TearFree and VariableRefresh (no LCD support though) enabled. Dual-s

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #4 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283699 --> https://bugzilla.kernel.org/attachment.cgi?id=283699&action=edit amdgpu parameters These doesn't seem to change anything about the hang. Although, may

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #2 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283695 --> https://bugzilla.kernel.org/attachment.cgi?id=283695&action=edit dmesg with "drm=debug=4" -- You are receiving this mail because: You are watching th

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #3 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 283697 --> https://bugzilla.kernel.org/attachment.cgi?id=283697&action=edit kernel build config -- You are receiving this mail because: You are watching the ass

  1   2   >