[PATCH] drm/vgem: Added page prefaulting

2019-08-19 Thread Szymon Andrzejuk
Page fault handler inside vgem driver now preallocates pages in advance when fault occurs for the first time. Pages can be allocated in direction of increasing/decreasing addresses, depending on memory access profile. In case of random access no preallocation occurs. Synthetic benchmark showed ove

Re: [PATCH] drm/qxl: fix a memory leak bug

2019-08-19 Thread Gerd Hoffmann
On Mon, Aug 19, 2019 at 01:08:18PM -0500, Wenwen Wang wrote: > In qxl_bo_create(), the temporary 'bo' is allocated through kzalloc(). > However, it is not deallocated in the following execution if ttm_bo_init() > fails, leading to a memory leak bug. To fix this issue, free 'bo' before > returning t

Re: [PATCHv2 2/2] i915: do not leak module ref counter

2019-08-19 Thread Christoph Hellwig
On Tue, Aug 20, 2019 at 12:13:59PM +0900, Sergey Senozhatsky wrote: > Always put_filesystem() in i915_gemfs_init(). > > Signed-off-by: Sergey Senozhatsky > --- > - v2: rebased (i915 does not remount gemfs anymore) Which means it real doesn't need its mount anyore, and thus can use plain old shm

Re: [PATCH] drm/panfrost: Queue jobs on the hardware

2019-08-19 Thread Tomeu Vizoso
On 8/16/19 11:31 AM, Steven Price wrote: The hardware has a set of '_NEXT' registers that can hold a second job while the first is executing. Make use of these registers to enqueue a second job per slot. I like this in principle, but upon some quick testing I found that Mesa is around 10% slow

[Bug 111434] MesaTest1

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111434 Bug ID: 111434 Summary: MesaTest1 Product: Mesa Version: 5.1 Hardware: ARM OS: All Status: NEW Severity: major Priority: medium Compon

[Bug 109380] [CI][BAT] igt@kms_chamelium@*- warn/fail - Last errno: 113, No route to host

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109380 Arek Hiler changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 111414] [REGRESSION] [BISECTED] Segmentation fault in si_bind_blend_state after removal of the blend state NULL check

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111414 --- Comment #3 from Dieter Nützel --- (In reply to Marek Olšák from comment #1) > Created attachment 145103 [details] [review] > possible fix > > Does the attached patch fix it? Yes, it fixed vdpau with Mplayer for me. mplayer -vo vdpau /data

[Bug 111433] Bug1 for DRI

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111433 Ruchira changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Ruchira --- Thi

[Bug 111433] Bug1 for DRI

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111433 Bug ID: 111433 Summary: Bug1 for DRI Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104602 --- Comment #25 from Marek Olšák --- This might help: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1714/diffs?commit_id=b991b7dd54a899d0df89c809c936401baa341d9d -- You are receiving this mail because: You are the assignee for the bu

[PATCHv2 1/2] fs: export put_filesystem()

2019-08-19 Thread Sergey Senozhatsky
Modules, e.g. i915, can use exported get_fs_type(), but are unable to put_filesystem(). Export it and let modules to decrement file systems' reference counters. Signed-off-by: Sergey Senozhatsky --- fs/filesystems.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/filesystems.c b/fs/filesy

linux-next: manual merge of the drm-misc tree with the drm-intel tree

2019-08-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c between commit: 70d6894d1456 ("drm/i915: Serialize against vma moves") from the drm-intel tree and commit: 52791eeec1d9 ("dma-buf: rename reservation_object to dma_res

Re: linux-next: Tree for Aug 19 (amdgpu)

2019-08-19 Thread Stephen Rothwell
Hi all, On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap wrote: > > On 8/19/19 2:18 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190816: > > > > on x86_64: > > ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’: > ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv

[GIT PULL] mediatek drm fixes for 5.3

2019-08-19 Thread CK Hu
Hi Dave, Daniel: This include PRIME buffer and of_node fixes. Regards, CK The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: https://github.com/ckhu-mediatek/linux.git-tags tags/med

[PATCH v2 50/50] drm/omap: dss: Remove unused omapdss_of_find_connected_device() function

2019-08-19 Thread Laurent Pinchart
The omapdss_of_find_connected_device() function isn't used anymore, remove it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/Makefile | 2 +- drivers/gpu/drm/omapdrm/dss/dss-of.c | 28 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 --- 3 files change

[PATCH v2 48/50] drm/omap: dss: Remove unused omap_dss_device operations

2019-08-19 Thread Laurent Pinchart
The omap_dss_device .pre_enable(), .post_disable() and .set_timings() are not used anymore. Remove them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c | 26 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 drivers/gpu/drm/omapdrm/omap_encoder.c | 44

[PATCH v2 14/50] drm/bridge: tfp410: Don't include drmP.h

2019-08-19 Thread Laurent Pinchart
The drmP.h header is deprecated, replace it with the headers specifically needed by the tfp410 driver. While at it, replace the DRM print macros with dev_info() and dev_err() instead of including drm_print.h Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/ti-tfp410.c | 6 -- 1 fil

[PATCH v2 46/50] drm/omap: sdi: Register a drm_bridge

2019-08-19 Thread Laurent Pinchart
In order to integrate with a chain of drm_bridge, the internal SDI output has to expose its operations through the drm_bridge API. Register a bridge at initialisation time to do so and remove the omap_dss_device operations that are now unused. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/

[PATCH v2 32/50] drm/omap: dss: Remove .set_hdmi_mode() and .set_infoframe() operations

2019-08-19 Thread Laurent Pinchart
The omapdss_hdmi_ops .set_hdmi_mode() and .set_infoframe() operations operations are not used anymore, remove them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 --- drivers/gpu/drm/omapdrm/omap_encoder.c | 26 -- 2 files changed, 29 del

[PATCH v2 45/50] drm/omap: sdi: Sort includes alphabetically

2019-08-19 Thread Laurent Pinchart
This makes it easier to quickly locate duplicate includes. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/sdi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/sdi.c b/drivers/gpu/drm/omapdrm/dss/sdi.c index 11aa2f712ff4..

[PATCH v2 22/50] drm/omap: Add infrastructure to support drm_bridge local to DSS outputs

2019-08-19 Thread Laurent Pinchart
In order to support drm_bridge-based pipeline, the internal HDMI encoders will need to expose the EDID read operation through the drm_bridge API, and thus to expose a drm_bridge instance corresponding to the encoder. The HDMI encoders are however handled as omap_dss_device instances, which conflict

[PATCH v2 47/50] drm/omap: Simplify connector implementation

2019-08-19 Thread Laurent Pinchart
Now that the omap_connector is used for DSI only we can simplify its implementation. Signed-off-by: Laurent Pinchart --- Changes since v1: - Remove export of omapdss_device_connector_type() --- drivers/gpu/drm/omapdrm/dss/base.c | 1 - drivers/gpu/drm/omapdrm/omap_connector.c | 31 ++

[PATCH v2 19/50] drm/omap: Factor out display type to connector type conversion

2019-08-19 Thread Laurent Pinchart
Move the code that computes the DRM connector type for the omapdss_device display type to a new omapdss_device_connector_type() function for later reuse. Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 23 +++ driver

[PATCH v2 34/50] drm/omap: Create connector for bridges

2019-08-19 Thread Laurent Pinchart
Use the drm_bridge_connector helper to create a connector for pipelines that use drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and handling all connector operations internally. Si

[PATCH v2 36/50] drm/omap: Remove HPD, detect and EDID omapdss operations

2019-08-19 Thread Laurent Pinchart
Due to the removal of several omapdrm display drivers, the omapdss HPD, detected and EDID operations are not used anymore. Remove them and all related code. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 61 drivers/gpu/drm/omapdrm/dss/hdmi5.c | 46

[PATCH v2 41/50] drm/omap: dpi: Sort includes alphabetically

2019-08-19 Thread Laurent Pinchart
This makes it easier to quickly locate duplicate includes. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dpi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c index 2d0eb5fcbb5

[PATCH v2 44/50] drm/omap: dpi: Register a drm_bridge

2019-08-19 Thread Laurent Pinchart
In order to integrate with a chain of drm_bridge, the internal DPI output has to expose its operations through the drm_bridge API. Register a bridge at initialisation time to do so and remove the omap_dss_device operations that are now unused. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/

[PATCH v2 11/50] drm/bridge: Add bridge driver for display connectors

2019-08-19 Thread Laurent Pinchart
Display connectors are modelled in DT as a device node, but have so far been handled manually in several bridge drivers. This resulted in duplicate code in several bridge drivers, with slightly different (and thus confusing) logics. In order to fix this, implement a bridge driver for display conne

[PATCH v2 38/50] drm/omap: venc: Remove omap_dss_device operations

2019-08-19 Thread Laurent Pinchart
Now that the VENC output is driven fully through the drm_bridge API its omap_dss_device operations are not used anymore. Remove them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/venc.c | 45 -- 1 file changed, 45 deletions(-) diff --git a/drivers/

[PATCH v2 49/50] drm/omap: dss: Inline the omapdss_display_get() function

2019-08-19 Thread Laurent Pinchart
Inline the omapdss_display_get() in its only caller to simplify the code. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/display.c | 9 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - drivers/gpu/drm/omapdrm/omap_drv.c| 7 --- 3 files changed, 4 insertions(+), 13

[PATCH v2 35/50] drm/omap: Switch the HDMI and VENC outputs to drm_bridge

2019-08-19 Thread Laurent Pinchart
The TPD12S015, OPA362 and analog and HDMI connectors are now supported by DRM bridge drivers, and the omapdrm HDMI and VENC outputs can be handled through the drm_bridge API. Switch the outputs to drm_bridge by making the next bridge mandatory and removing the related omapdrm-specific display drive

[PATCH v2 18/50] drm/omap: Simplify HDMI mode and infoframe configuration

2019-08-19 Thread Laurent Pinchart
Remove the omap_connector_get_hdmi_mode() function as the HDMI mode can be accessed directly from the connector's display info. Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_connector.c | 11 --- drivers/gpu/drm/omapdrm/omap_connector.h |

[PATCH v2 12/50] drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter

2019-08-19 Thread Laurent Pinchart
The TI TPD12S015 is an HDMI level shifter and ESD protector controlled through GPIOs. Add a DRM bridge driver for the device. Signed-off-by: Laurent Pinchart --- Changes since v1: - Remove empty .hpd_enable() and .hpd_disable() operations --- drivers/gpu/drm/bridge/Kconfig| 8 ++ driv

[PATCH v2 15/50] drm/bridge: tfp410: Replace manual connector handling with bridge

2019-08-19 Thread Laurent Pinchart
Now that a driver is available for display connectors, replace the manual connector handling code with usage of the DRM bridge API. The tfp410 driver doesn't deal with the display connector directly anymore, but still delegates drm_connector operations to the next bridge. This brings us one step cl

[PATCH v2 42/50] drm/omap: dpi: Reorder functions in sections

2019-08-19 Thread Laurent Pinchart
Group functions based on their purpose and split them in sections to make the source code easier to navigate. No functional change is included. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dpi.c | 146 -- 1 file changed, 79 insertions(+), 67 deleti

[PATCH v2 26/50] drm/omap: hdmi5: Rework EDID read to isolate data read

2019-08-19 Thread Laurent Pinchart
In preparation of adding DRM bridge support to the hdmi5 encoder code, rework the EDID read to isolate data read. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 89 ++-- drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 48 +++-- drivers/gpu/d

[PATCH v2 13/50] drm/bridge: panel: Implement bridge connector operations

2019-08-19 Thread Laurent Pinchart
Implement the newly added bridge connector operations, allowing the usage of drm_bridge_panel with drm_bridge_connector. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/panel.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridg

[PATCH v2 30/50] drm/omap: hdmi5: Move mode set, enable and disable operations to bridge

2019-08-19 Thread Laurent Pinchart
Move the omap_dss_device .set_timings(), .enable() and .disable() operations to the drm_bridge functions. As the drm_bridge for the HDMI encoder is unconditionally registered and attached, those operations will be called at the appropriate time. Signed-off-by: Laurent Pinchart --- drivers/gpu/dr

[PATCH v2 17/50] drm: Add helper to create a connector for a chain of bridges

2019-08-19 Thread Laurent Pinchart
Most bridge drivers create a DRM connector to model the connector at the output of the bridge. This model is historical and has worked pretty well so far, but causes several issues: - It prevents supporting more complex display pipelines where DRM connector operations are split over multiple compo

[PATCH v2 06/50] drm/bridge: dumb-vga-dac: Rename internal symbols to simple-bridge

2019-08-19 Thread Laurent Pinchart
The dumb-vga-dac driver is a simple DRM bridge driver for simple VGA DACs that don't require configuration. Other non-VGA bridges fall in a similar category, and would benefit from a common driver. Prepare for this by renaming the internal symbols from dumb-vga-dac to simple-bridge. Signed-off-by:

[PATCH v2 21/50] drm/omap: dss: Fix output next device lookup in DT

2019-08-19 Thread Laurent Pinchart
The DSS core looks up the next device connected to an output by traversing the OF graph. It currently hardcodes the local port number to 0, which breaks any output with a different port number (SDI on OMAP3 and any DPI output but the first one). Fix this by repurposing the currently unused of_ports

[PATCH v2 28/50] drm/omap: hdmi5: Register a drm_bridge for EDID read

2019-08-19 Thread Laurent Pinchart
In order to integrate with a chain of drm_bridge, the internal HDMI5 encoder has to expose the EDID read operation through the drm_bridge API. Register a bridge at initialisation time to do so. For the time being make the next bridge in the chain optional as the HDMI output is still based on omap_

[PATCH v2 27/50] drm/omap: hdmi4: Register a drm_bridge for EDID read

2019-08-19 Thread Laurent Pinchart
In order to integrate with a chain of drm_bridge, the internal HDMI4 encoder has to expose the EDID read operation through the drm_bridge API. Register a bridge at initialisation time to do so. For the time being make the next bridge in the chain optional as the HDMI output is still based on omap_

[PATCH v2 37/50] drm/omap: hdmi: Remove omap_dss_device operations

2019-08-19 Thread Laurent Pinchart
Now that the HDMI outputs are driven fully through the drm_bridge API their omap_dss_device operations are not used anymore. Remove them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi.h | 1 - drivers/gpu/drm/omapdrm/dss/hdmi4.c | 18 -- drivers/gpu/drm/o

[PATCH v2 40/50] drm/omap: hdmi5: Simplify EDID read

2019-08-19 Thread Laurent Pinchart
Now that the omap_dss_device EDID read operation has been removed, simplify the bridge-based EDID access by merging multiple functions together. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 86 - 1 file changed, 35 insertions(+), 51 deleti

[PATCH v2 43/50] drm/omap: dpi: Simplify clock setting API

2019-08-19 Thread Laurent Pinchart
The dpi_set_pll_clk() and dpi_set_dispc_clk() return various information through pointer arguments that are never used by the callers. Remove them to simplify the clock setting API. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dpi.c | 32 --- 1 file

[PATCH v2 23/50] drm/omap: dss: Make omap_dss_device_ops optional

2019-08-19 Thread Laurent Pinchart
As part of the move to drm_bridge ops, the dssdev ops will become empty for some of the internal encoders. Make them optional in the driver to allow them to be removed completely, easing the transition. Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/

[PATCH v2 31/50] drm/omap: hdmi4: Implement drm_bridge .hpd_notify() operation

2019-08-19 Thread Laurent Pinchart
The HDMI4 encoder is transitioning to the drm_bridge API, implement the last missing operation. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/d

[PATCH v2 39/50] drm/omap: hdmi4: Simplify EDID read

2019-08-19 Thread Laurent Pinchart
Now that the omap_dss_device EDID read operation has been removed, simplify the bridge-based EDID access by merging multiple functions together. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 96 - 1 file changed, 40 insertions(+), 56 deleti

[PATCH v2 01/50] video: hdmi: Change return type of hdmi_avi_infoframe_init() to void

2019-08-19 Thread Laurent Pinchart
The hdmi_avi_infoframe_init() never needs to return an error, change its return type to void. Signed-off-by: Laurent Pinchart Reviewed-by: Andrzej Hajda --- Changes since v1: - Removed documentation of the return value Cc: Bartlomiej Zolnierkiewicz --- drivers/gpu/drm/drm_edid.c | 5 +

[PATCH v2 04/50] drm/bridge: Add connector-related bridge operations and data

2019-08-19 Thread Laurent Pinchart
To support implementation of DRM connectors on top of DRM bridges instead of by bridges, the drm_bridge needs to expose new operations and data: - Output detection, hot-plug notification, mode retrieval and EDID retrieval operations - Bitmask of supported operations - Bridge output type - I2C ad

[PATCH v2 05/50] drm/bridge: Extend bridge API to disable connector creation

2019-08-19 Thread Laurent Pinchart
Most bridge drivers create a DRM connector to model the connector at the output of the bridge. This model is historical and has worked pretty well so far, but causes several issues: - It prevents supporting more complex display pipelines where DRM connector operations are split over multiple compo

[PATCH v2 29/50] drm/omap: hdmi4: Move mode set, enable and disable operations to bridge

2019-08-19 Thread Laurent Pinchart
Move the omap_dss_device .set_timings(), .enable() and .disable() operations to the drm_bridge functions. As the drm_bridge for the HDMI encoder is unconditionally registered and attached, those operations will be called at the appropriate time. Signed-off-by: Laurent Pinchart --- drivers/gpu/dr

[PATCH v2 25/50] drm/omap: hdmi4: Rework EDID read to isolate data read

2019-08-19 Thread Laurent Pinchart
In preparation of adding DRM bridge support to the hdmi4 encoder code, rework the EDID read to isolate data read. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 94 +++- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 59 +++ drivers/gpu

[PATCH v2 07/50] drm/bridge: dumb-vga-dac: Rename driver to simple-bridge

2019-08-19 Thread Laurent Pinchart
The dumb-vga-dac driver can support simple DRM bridges without being limited to VGA DACs. Rename it to simple-bridge. Signed-off-by: Laurent Pinchart Reviewed-by: Andrzej Hajda --- arch/arm/configs/davinci_all_defconfig | 2 +- arch/arm/configs/integrator_defconfig| 2 +-

[PATCH v2 16/50] drm/bridge: tfp410: Allow operation without drm_connector

2019-08-19 Thread Laurent Pinchart
The tfp410 driver can operate as part of a pipeline where the drm_connector is created by the display controller. Enable this mode of operation by skipping creation of a drm_connector internally. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 ins

[PATCH v2 00/50] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

2019-08-19 Thread Laurent Pinchart
Hello, This patch series (nearly, see [1]) completes the rework of the omapdrm driver to move to drm_bridge and drm_panel. Let's start with some context (copied from v1) to understand the problem. omapdrm contains custom drivers for external encoders, panels and connectors (collectively referred

[PATCH v2 03/50] drm/edid: Add flag to drm_display_info to identify HDMI sinks

2019-08-19 Thread Laurent Pinchart
The drm_display_info structure contains many fields related to HDMI sinks, but none that identifies if a sink compliant with CEA-861 (EDID) shall be treated as an HDMI sink or a DVI sink. Add such a flag, and populate it according to section 8.3.3 ("DVI/HDMI Device Discrimination") of the HDMI v1.3

[PATCH v2 09/50] drm/bridge: simple-bridge: Add support for enable GPIO

2019-08-19 Thread Laurent Pinchart
If an enable GPIO is declared in the firmware, assert it when enabling the bridge and deassert it when disabling it. Signed-off-by: Laurent Pinchart Reviewed-by: Andrzej Hajda Reviewed-by: Stefan Agner --- drivers/gpu/drm/bridge/simple-bridge.c | 22 ++ 1 file changed, 18 i

[PATCH v2 33/50] drm/omap: venc: Register a drm_bridge

2019-08-19 Thread Laurent Pinchart
In order to integrate with a chain of drm_bridge, the internal VENC encoder has to expose the mode valid, fixup and set, the enable and disable and the get modes operations through the drm_bridge API. Register a bridge at initialisation time to do so. Most of those operations are removed from the

[PATCH v2 24/50] drm/omap: hdmi: Allocate EDID in the .read_edid() operation

2019-08-19 Thread Laurent Pinchart
Bring the omapdss-specific .read_edid() operation in sync with the drm_bridge .get_edid() operation to ease code reuse. Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen --- Changes since v1: - Keep MAX_EDID macro --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 36

[PATCH v2 08/50] drm/bridge: simple-bridge: Add support for non-VGA bridges

2019-08-19 Thread Laurent Pinchart
Create a new simple_bridge_info structure that stores information about the bridge model, and store the bridge timings in there, along with the connector type. Use that new structure for of_device_id data. This enables support for non-VGA bridges. Signed-off-by: Laurent Pinchart Reviewed-by: Andr

[PATCH v2 10/50] drm/bridge: simple-bridge: Add support for the TI OP362

2019-08-19 Thread Laurent Pinchart
The TI OP362 is an analog video amplifier controlled through a GPIO. Add support for it to the simple-bridge driver. Signed-off-by: Laurent Pinchart Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/simple-bridge.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/bri

[PATCH v2 20/50] drm/omap: Use the drm_panel_bridge API

2019-08-19 Thread Laurent Pinchart
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen --- Changes since v1: -

[PATCH v2 02/50] drm/connector: Add helper to get a connector type name

2019-08-19 Thread Laurent Pinchart
drm_connector.c contains a map of connector types (DRM_MODE_CONNECTOR_*) to name strings, but doesn't expose it. This leads to drivers having to store a similar map. Add a new drm_get_connector_type_name() helper function that return a name string for a connector type. Signed-off-by: Laurent Pinc

[PATCH 0/3] dt-bindings for lima support on HiKey

2019-08-19 Thread John Stultz
Peter sent a patchset out back in April to enable Lima support on HiKey, but there's not been much action on it since since. I've been carrying the patchset in my tree, and figured I'd send out just these three dt-bindings changes just so hopefully they can go in and the dependent driver changes c

[PATCH 2/3] dt-bindings: reset: hisilicon: Update compatible documentation

2019-08-19 Thread John Stultz
From: Peter Griffin The reset driver now supports the ao reset controller, so update the documentation to match. Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Mark Rutland Cc: Philipp Zabel Cc: dri-devel@lists.freedesktop.org Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring

[PATCH 3/3] dt-bindings: reset: hisilicon: Add ao reset controller

2019-08-19 Thread John Stultz
From: Peter Griffin This is required to bring Mali450 gpu out of reset. Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Mark Rutland Cc: Philipp Zabel Cc: dri-devel@lists.freedesktop.org Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Peter Griffin Signed-off

[PATCH 1/3] dt-bindings: gpu: mali-utgard: add hisilicon, hi6220-mali compatible

2019-08-19 Thread John Stultz
From: Peter Griffin The Hisilicon hi6220 uses a Mali-450MP4 with 4 PPs, so add a compatible for it. Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Mark Rutland Cc: Philipp Zabel Cc: dri-devel@lists.freedesktop.org Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-b

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-08-19 Thread Chanwoo Choi
Hi Artur and Leonard, On 19. 8. 9. 오전 12:00, Leonard Crestez wrote: > On 29.07.2019 04:49, Chanwoo Choi wrote: >> On 19. 7. 23. 오후 9:20, Artur Świgoń wrote: >>> This patch adds interconnect functionality to the exynos-bus devfreq >>> driver. >>> >>> The devfreq target() callback provided by exynos

[Bug 111122] 2500U: Graphics corruption on kernel 5.2

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=22 --- Comment #22 from Marek Olšák --- How do I reproduce the Xfce hang and corruption? It's not reproducible with Ubuntu 16.04. -- You are receiving this mail because: You are the assignee for the bug.___

Re: [RESEND][PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support

2019-08-19 Thread John Stultz
On Sun, Aug 18, 2019 at 9:40 PM Sam Ravnborg wrote: > > > As Maintainers can we please get some feedback from one of you. > > > Just an "OK to commit" would do it. > > > But preferably an ack or a review on the individual patches. > > > > As I have done a pre-review and talked with the author bef

[Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega

2019-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104602 --- Comment #24 from Timothy Arceri --- (In reply to Marek Olšák from comment #23) > Connor, there is indeed an issue with how we set SPI_TMPRING_SIZE and same > for compute. I wonder if this is the issue reported in bug #108194 -- You are re

[PATCH v4 10/25] drm: kirin: Move workqueue to ade_hw_ctx structure

2019-08-19 Thread John Stultz
The workqueue used to reset the display when we hit an LDI underflow error is ADE specific, so since this patch series works to make the kirin_crtc structure more generic, move the workqueue to the ade_hw_ctx structure instead. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vette

[PATCH v4 14/25] drm: kirin: Move channel formats to driver data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the channel format arrays into the kirin_drm_data structure. This will make it easier to add support for new devices via a new kirin_drm_data structure. Cc: Rongrong Zou Cc:

[PATCH v4 16/25] drm: kirin: Move plane number and primay plane in driver data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the number of planes and the primary plane value to the kirin_drm_data structure This will make it easier to add support for new devices via a new kirin_drm_data structure. C

[PATCH v4 18/25] drm: kirin: Move drm driver to driver data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the drm_driver structure to be under device specific driver data. This will allow us to more easily add support for kirin960 hardware with later patches. Cc: Rongrong Zou Cc

[PATCH v4 17/25] drm: kirin: Move config max_width and max_height to driver data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the max_width and max_height values used in kirin_drm_mode_config_inita to hardware specific driver data. This will make it easier to add support for new devices via a new kir

[PATCH v4 22/25] drm: kirin: Make driver_data variable non-global

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the driver_data value to not be a global variable. Instead the driver_data value is accessed via the of_device_get_match_data() when needed. Cc: Rongrong Zou Cc: Xinliang L

[PATCH v4 19/25] drm: kirin: Add register connect helper functions in drm init

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch adds a flag to the device specific driver data so that we can conditionally register the connectors at init. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter

[PATCH v4 20/25] drm: kirin: Rename plane_init and crtc_init

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames ade_crtc/plane_init kirin_plane/crtc_init, as they will later be moved to kirin drm drv and shared with the kirin960 hardware support. Cc: Rongrong Zou Cc: Xinliang Liu Cc

[PATCH v4 15/25] drm: kirin: Move mode config function to driver_data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the mode config initialization values into the kirin_drm_data structure. This will make it easier to add support for new devices via a new kirin_drm_data structure. Cc: Rongr

[PATCH v4 23/25] drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the alloc/clean_hw_ctx functions to be called via driver_data specific funciton pointers. This will allow the ade_drm_init to later be made generic and moved to kirin_drm_dr

[PATCH v4 24/25] drm: kirin: Pass driver data to crtc init and plane init

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the code via a passed in driver_data pointer, rather than hardcoding them via ade_driver_data variable. This will allow those funcitons to be later moved to the generic kiri

[PATCH v4 21/25] drm: kirin: Fix dev->driver_data setting

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the dev->driver_data to point to a drm_device, not ade_data. Thus we set the driver data to drm device after alloc. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc

[PATCH v4 25/25] drm: kirin: Move ade drm init to kirin drm drv

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames ade_data to kirin_drm_private, and moves crtc_init and plane_init to kirin drm drv too. Now that they are generic the functions can be shared between the kirin620 and (to be

[PATCH v4 09/25] drm: kirin: Move request irq handle in ade hw ctx alloc

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch modifies the initialization routines so the devm_request_irq() function is called as part of the allocation function. This will be needed in the future when we will have different a

[PATCH v4 08/25] drm: kirin: Dynamically allocate the hw_ctx

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch modifies the initialization function to dynamically allocate the ade_hw_ctx structure previously kept as part of struct ade_data. This is done so that later we can have the hw_ctx p

[PATCH v4 12/25] drm: kirin: Reanme dc_ops to kirin_drm_data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames the struct kirin_dc_ops to struct kirin_drm_data and cleans up the related variable names. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-d

[PATCH v4 11/25] drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves some shared structures and helpers to the common kirin_drm_drv.h These structures will later used by both kirin620 and future kirin960 driver Cc: Rongrong Zou Cc: Xinliang L

[PATCH v4 03/25] drm: kirin: Remove unreachable return

2019-08-19 Thread John Stultz
The 'return 0' in kirin_drm_platform_probe() is unreachable code, so remove it. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Acked-by: Xinliang Liu Reviewed-by: Sam Ravnborg Suggested by: Xu YiPing Signed-off-by: John Stultz --- dri

[PATCH v4 13/25] drm: kirin: Move ade crtc/plane help functions to driver_data

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the crtc and plane funcs/helper_funcs to the struct kirin_drm_data. This will make it easier to add support for new devices via a new kirin_drm_data structure. Cc: Rongrong Z

[PATCH v4 07/25] drm: kirin: Rename ade_crtc to kirin_crtc

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames the struct ade_crtc to kirin_crtc. The struct kirin_crtc will later used by both kirin620 and future kirin960 driver, and will be moved to a common kirin_drm_drv.h in a futu

[PATCH v4 02/25] drm: kirin: Remove HISI_KIRIN_DW_DSI config option

2019-08-19 Thread John Stultz
The CONFIG_HISI_KIRIN_DW_DSI option is only used w/ kirin driver, so cut out the middleman and condense the config logic down. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Acked-by: Xinliang Liu Reviewed-by: Sam Ravnborg Signed-off-by:

[PATCH v4 01/25] drm: kirin: Fix for hikey620 display offset problem

2019-08-19 Thread John Stultz
From: Da Lv The original HiKey (620) board has had a long running issue where when using a 1080p montior, the display would occasionally blink and come come back with a horizontal offset (usually also shifting the colors, depending on the value of the offset%4). After lots of analysis by HiSi de

[PATCH v4 05/25] drm: kirin: Remove out_format from ade_crtc

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch removes the out_format field in the struct ade_crtc, which was only ever set to LDI_OUT_RGB_888. Thus this patch removes the field and instead directly uses LDI_OUT_RGB_888. Cc: Ro

[PATCH v4 00/25] drm: Kirin driver cleanups to prep for Kirin960 support

2019-08-19 Thread John Stultz
Sending this out again, to get it based on drm-misc-next. This patchset contains one fix (in the front, so its easier to eventually backport), and a series of changes from YiPing to refactor the kirin drm driver so that it can be used on both kirin620 based devices (like the original HiKey board)

[PATCH v4 04/25] drm: kirin: Remove uncessary parameter indirection

2019-08-19 Thread John Stultz
From: Xu YiPing In a few functions, we pass in a struct ade_crtc, which we only use to get to the underlying struct ade_hw_ctx. Thus this patch refactors the functions to just take the struct ade_hw_ctx directly. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-d

[PATCH v4 06/25] drm: kirin: Rename ade_plane to kirin_plane

2019-08-19 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames the struct ade_plane to kirin_plane. The struct kirin_plane will later used by both kirin620 and future kirin960 driver, and will be moved to a common kirin_drm_drv.h in a f

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-08-19 Thread Laurent Pinchart
Hi Andrzej, On Mon, Aug 19, 2019 at 10:38:35AM +0200, Andrzej Hajda wrote: > On 14.08.2019 14:40, Daniel Vetter wrote: > > On Wed, Aug 14, 2019 at 01:04:03PM +0300, Laurent Pinchart wrote: > >> On Wed, Aug 14, 2019 at 08:23:12AM +0200, Andrzej Hajda wrote: > >>> On 11.08.2019 00:43, Laurent Pincha

  1   2   3   >