Re: [v7, PATCH 6/7] drm/mediatek: add fifo_size into rdma private data

2020-07-24 Thread Chun-Kuang Hu
The primary thing of this patch is to get fifo size from device tree. So you may modify title to show the primary thing. Yongqiang Niu 於 2020年7月23日 週四 上午10:12寫道: > > the fifo size of rdma in mt8183 is different. > rdma0 fifo size is 5k > rdma1 fifo size is 2k I would like the description to be

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月25日 週六 上午11:32寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > > > 1.ovl_2l share driver with ovl > > > > I think

[RFC][PATCH] dma-heap: Add proper kref handling on dma-buf heaps

2020-07-24 Thread John Stultz
Add proper refcounting on the dma_heap structure. While existing heaps are built-in, we may eventually have heaps loaded from modules, and we'll need to be able to properly handle the references to the heaps Cc: Sumit Semwal Cc: Andrew F. Davis Cc: Benjamin Gaignard Cc: Liam Mark Cc: Laura

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-24 Thread Sidong Yang
On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > On 07/22, dan...@ffwll.ch wrote: > > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > > This patch adds a missing drm_crtc_vblank_put op to the pair > >

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #93 from mn...@protonmail.com --- (In reply to Nicholas Kazlauskas from comment #92) > This sounds very similar to a bug I fixed a year ago but that issue was with > freeing the dc_state. > >

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月23日 週四 上午10:05寫道: > > add mmsys private data > > Feature: drm/mediatek > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mmsys/Makefile | 2 + >

Re: [PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-24 Thread Paulo Zanoni
Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: > Add enable/disable flip done functions and the flip done handler > function which handles the flip done interrupt. > > Enable the flip done interrupt in IER. > > Enable flip done function is called before writing the > surface address

Re: [PATCH v5 2/5] drm/i915: Add support for async flips in I915

2020-07-24 Thread Paulo Zanoni
Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: > Set the Async Address Update Enable bit in plane ctl > when async flip is requested. > > v2: -Move the Async flip enablement to individual patch (Paulo) > > v3: -Rebased. > > v4: -Add separate plane hook for async flip case (Ville) > >

Re: [PATCH v5 0/5] Asynchronous flip implementation for i915

2020-07-24 Thread Paulo Zanoni
Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: > Without async flip support in the kernel, fullscreen apps where game > resolution is equal to the screen resolution, must perform an extra blit > per frame prior to flipping. > > Asynchronous page flips will also boost the FPS of Mesa

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-24 Thread Chun-Kuang Hu
Hi Yongqiang: Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > This patch add support for mediatek SOC MT8183 > 1.ovl_2l share driver with ovl I think this is done in [1], [2], [3], this patch just add the support of mt8183-ovl and mt8183-ovl-2l. [1]

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 --- Comment #5 from Shannon Gaines (iknstu...@protonmail.com) --- Created attachment 290549 --> https://bugzilla.kernel.org/attachment.cgi?id=290549=edit mmiotrace for nvidia initialization -- You are receiving this mail because: You are

Re: [git pull] drm fixes for 5.8-rc7

2020-07-24 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Jul 2020 14:56:40 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-07-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/88fff0b7dcc132c924d710d75d1401264b6d0ef6 Thank you! -- Deet-doot-dot, I am a bot.

Re: warning in omap_connector

2020-07-24 Thread Laurent Pinchart
Hi Dave, On Thu, Jul 23, 2020 at 02:28:22PM +1000, Dave Airlie wrote: > I think I'm still seeing this. I'm sorry, I've let it slip through the cracks :-S Ville as beaten me at submitting a patch (kiitos paljon Ville). > On Wed, 1 Jul 2020 at 01:08, Ville Syrjälä wrote: > > On Tue, Jun 30, 2020

Re: [PATCH] drm/omap: Use {} to zero initialize the mode

2020-07-24 Thread Laurent Pinchart
Hi Ville, Thank you for the patch, and sorry for having let this issue slip through the cracks :-S On Fri, Jul 24, 2020 at 10:07:18PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The first member of drm_display_mode is no longer a structure, but > the code is still using {{0}} to zero

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #92 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- This sounds very similar to a bug I fixed a year ago but that issue was with freeing the dc_state. https://bugzilla.kernel.org/show_bug.cgi?id=204181 1. Client requests

[pull] amdgpu drm-next-5.9

2020-07-24 Thread Alex Deucher
Hi Dave, Daniel, Last few bits 5.9. Fixes and cleanups. The following changes since commit 6e14adea0ac3037d923a9591d1a094c115d7947c: drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read() (2020-07-15 13:27:34 -0400) are available in the Git repository at:

Re: [PATCH] drm/omap: Use {} to zero initialize the mode

2020-07-24 Thread Daniel Vetter
On Fri, Jul 24, 2020 at 10:04 PM Ville Syrjälä wrote: > > On Fri, Jul 24, 2020 at 09:43:45PM +0200, Daniel Vetter wrote: > > On Fri, Jul 24, 2020 at 9:07 PM Ville Syrjala > > wrote: > > > > > > From: Ville Syrjälä > > > > > > The first member of drm_display_mode is no longer a structure, but >

Re: [PATCH] drm/omap: Use {} to zero initialize the mode

2020-07-24 Thread Ville Syrjälä
On Fri, Jul 24, 2020 at 09:43:45PM +0200, Daniel Vetter wrote: > On Fri, Jul 24, 2020 at 9:07 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > The first member of drm_display_mode is no longer a structure, but > > the code is still using {{0}} to zero initialize it. Make that just >

Re: [PATCH] drm/omap: Use {} to zero initialize the mode

2020-07-24 Thread Daniel Vetter
On Fri, Jul 24, 2020 at 9:07 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > The first member of drm_display_mode is no longer a structure, but > the code is still using {{0}} to zero initialize it. Make that just > {} so it works regardless of what lies inside. > > Cc: Dave Airlie > Cc:

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 laser.eyess.track...@gmail.com changed: What|Removed |Added CC|

[PATCH] drm/omap: Use {} to zero initialize the mode

2020-07-24 Thread Ville Syrjala
From: Ville Syrjälä The first member of drm_display_mode is no longer a structure, but the code is still using {{0}} to zero initialize it. Make that just {} so it works regardless of what lies inside. Cc: Dave Airlie Cc: Laurent Pinchart Cc: Tomi Valkeinen Fixes: 42acb06b01b1 ("drm: pahole

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Kees Cook
On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: > Am 24.07.20 um 00:32 schrieb Kees Cook: > > On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: > As Linux 5.8-rc7 is going to be released this Sunday, I wonder, if commit > 3202fa62f ("slub: relocate freelist pointer to middle

[PATCH 1/2] drm/probe_helper: Add drm_connector_helper_funcs->get_modes_ctx()

2020-07-24 Thread Lyude Paul
Currently nouveau relies on being able to use the drm_connector_helper_funcs->mode_valid() hook within drm_connector_helper_funcs->get_modes() so that we can ignore invalid modes when figuring out the connector's native mode. Since we're about to add a ->mode_valid_ctx() hook for MST, we'll also

[PATCH 2/2] drm/nouveau/kms/nv50-: Check MST display modes against available PBN

2020-07-24 Thread Lyude Paul
While we already check whether a given atomic state can fit in the available bandwidth for an MST topology, we don't currently bother to prune display modes on MST connectors if said modes are impossible to fit on the MST link irregardless of the current display state. So, let's avoid reporting

[PATCH 0/2] drm/probe_helper, drm/nouveau: Validate MST modes against PBN

2020-07-24 Thread Lyude Paul
Now that we've added the hooks that we've needed for this and used them in i915, let's add one more hook (which I could use some feedback on, I'm not sure if it's worth maybe just reworking how we do mode pruning in nouveau instead...) and start using this in our mst ->mode_valid callback to

[Bug 208679] AMDGPU - HDMI audio not available

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208679 kurmi...@libero.it changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-24 Thread Boris Ostrovsky
On 7/24/20 10:34 AM, David Hildenbrand wrote: > CCing Dan > > On 24.07.20 14:42, Roger Pau Monne wrote: >> diff --git a/drivers/xen/unpopulated-alloc.c >> b/drivers/xen/unpopulated-alloc.c >> new file mode 100644 >> index ..aaa91cefbbf9 >> --- /dev/null >> +++

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions v2

2020-07-24 Thread Felix Kuehling
Am 2020-07-24 um 7:56 a.m. schrieb Christian König: > We can't pipeline that during eviction because the memory needs > to be available immediately. > > v2: fix how we cleanup the BOs resources > > Signed-off-by: Christian König Reviewed-by: Felix Kuehling It would be good to get a Tested-by

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-24 Thread Bjorn Helgaas
On Fri, Jul 24, 2020 at 12:57:51PM +0300, Mika Westerberg wrote: > On Thu, Jul 23, 2020 at 10:30:58PM +0200, Karol Herbst wrote: > > On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg > > wrote: > > > > > > On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > > > > On 7/21/20 10:27

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-24 Thread David Hildenbrand
CCing Dan On 24.07.20 14:42, Roger Pau Monne wrote: > To be used in order to create foreign mappings. This is based on the > ZONE_DEVICE facility which is used by persistent memory devices in > order to create struct pages and kernel virtual mappings for the IOMEM > areas of such devices. Note

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-24 Thread Jürgen Groß
On 24.07.20 14:42, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 --- Comment #4 from Shannon Gaines (iknstu...@protonmail.com) --- As suggested in IRC, I tried nouveau.modeset=0. It didn't help with the backlight issue, without or without non-free firmware. So I believe the issue isn't related to modesetting.

[Bug 208679] AMDGPU - HDMI audio not available

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208679 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [v7, PATCH 3/7] mtk-mmsys: add mt8183 mmsys support

2020-07-24 Thread Nicolas Boichat
On Thu, Jul 23, 2020 at 10:05 AM Yongqiang Niu wrote: > > add mt8183 mmsys support > > Feature: drm/mediatek > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 161 > ++ >

[Bug 208679] New: AMDGPU - HDMI audio not available

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208679 Bug ID: 208679 Summary: AMDGPU - HDMI audio not available Product: Drivers Version: 2.5 Kernel Version: 5.7.10 Hardware: All OS: Linux Tree: Mainline

[PATCH] drm/ttm: fix pipelined gutting for evictions v2

2020-07-24 Thread Christian König
We can't pipeline that during eviction because the memory needs to be available immediately. v2: fix how we cleanup the BOs resources Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is running, causing a race condition where state (and then dm_state) is sometimes freed while amdgpu_dm_atomic_commit_tail is running. This bug has occurred since

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
On Thursday, July 23, 2020 6:32 PM, Kees Cook wrote: > On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: > > > When amdgpu_dm_atomic_commit_tail is running in the workqueue, > > drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is > > running, causing a race

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
It seems that I spoke too soon. I ran the system for another hour after submitting the patch and the bug just occurred. :/ Sadly, that means the bug isn't really fixed and that I have to go investigate further. At the very least, this patch seems to delay the occurrence of the bug significantly

[PATCH][next] drm: xln: fix spelling mistake "failes" -> "failed"

2020-07-24 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_dbg messages. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index

[PATCH][next] drm/amdgpu: fix spelling mistake "Falied" -> "Failed"

2020-07-24 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR error message. Fix it. Signed-off-by: Colin Ian King --- Can folk please use checkpatch, it should catch these errors. --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] newport_con: vc_color is now in state

2020-07-24 Thread Jiri Slaby
On 24. 07. 20, 11:30, Sergei Shtylyov wrote: > On 24.07.2020 9:27, Jiri Slaby wrote: > >> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as > >    Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). That's because it's not in Linus' repo yet. -- js suse labs

Re: [PATCH v2 1/2] drm: add drmm_encoder_init()

2020-07-24 Thread Daniel Vetter
On Fri, Jul 24, 2020 at 11:37 AM Daniel Vetter wrote: > > On Fri, Jul 24, 2020 at 11:33 AM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 24.07.20 um 11:07 schrieb Daniel Vetter: > > > On Fri, Jul 24, 2020 at 10:49 AM Philipp Zabel > > > wrote: > > >> > > >> On Thu, 2020-07-23 at 16:56

Re: [PATCH] newport_con: vc_color is now in state

2020-07-24 Thread Greg KH
On Fri, Jul 24, 2020 at 12:30:59PM +0300, Sergei Shtylyov wrote: > On 24.07.2020 9:27, Jiri Slaby wrote: > > > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as > >Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should > enclose the commit summary

Re: [PATCH v2 1/2] drm: add drmm_encoder_init()

2020-07-24 Thread Daniel Vetter
On Fri, Jul 24, 2020 at 11:33 AM Thomas Zimmermann wrote: > > Hi > > Am 24.07.20 um 11:07 schrieb Daniel Vetter: > > On Fri, Jul 24, 2020 at 10:49 AM Philipp Zabel > > wrote: > >> > >> On Thu, 2020-07-23 at 16:56 +0200, Philipp Zabel wrote: > >>> Add a drm_encoder_init() variant that allocates

Re: [PATCH v2 1/2] drm: add drmm_encoder_init()

2020-07-24 Thread Thomas Zimmermann
Hi Am 24.07.20 um 11:07 schrieb Daniel Vetter: > On Fri, Jul 24, 2020 at 10:49 AM Philipp Zabel wrote: >> >> On Thu, 2020-07-23 at 16:56 +0200, Philipp Zabel wrote: >>> Add a drm_encoder_init() variant that allocates an encoder with >>> drmm_kzalloc() and registers drm_encoder_cleanup() with >>>

[PULL] nouveau-next 5.9

2020-07-24 Thread Ben Skeggs
Hey Dave, This is the main nouveau pull for 5.9. Nothing too exciting here, most of it is (a lot of) trivial prep-work for future improvements: - Conversion of all push buffer emission to a new set of macros, with better safety, sanity-checking, debug ability, and the use of NVIDIA's class

[PATCH v8 3/5] drm/imx/dcss: use drm_bridge_connector API

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Make use of drm_bridge_connector API to have the connector initialized by the display controller. Signed-off-by: Laurentiu Palcu CC: Sam Ravnborg CC: Laurent Pinchart --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +--- drivers/gpu/drm/imx/dcss/dcss-kms.c |

[PATCH v8 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu Reviewed-by: Rob Herring --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644

[PATCH v8 1/5] drm/imx: compile imx directory by default

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v8 4/5] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcss. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dad5a62d21a7..200c5985b41f 100644 --- a/MAINTAINERS

[PATCH v8 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found here:

[PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

Re: [PATCH v2 1/2] drm: add drmm_encoder_init()

2020-07-24 Thread Daniel Vetter
On Fri, Jul 24, 2020 at 10:49 AM Philipp Zabel wrote: > > On Thu, 2020-07-23 at 16:56 +0200, Philipp Zabel wrote: > > Add a drm_encoder_init() variant that allocates an encoder with > > drmm_kzalloc() and registers drm_encoder_cleanup() with > > drmm_add_action_or_reset(). > > > > Signed-off-by:

Re: [PATCH v2 1/2] drm: add drmm_encoder_init()

2020-07-24 Thread Philipp Zabel
On Thu, 2020-07-23 at 16:56 +0200, Philipp Zabel wrote: > Add a drm_encoder_init() variant that allocates an encoder with > drmm_kzalloc() and registers drm_encoder_cleanup() with > drmm_add_action_or_reset(). > > Signed-off-by: Philipp Zabel > --- > New in v2 > --- >

[PULL] nouveau-fixes 5.8

2020-07-24 Thread Ben Skeggs
Hey Dave, A couple of fixes for issues relating to format modifiers (there's still a patch pending from James Jones to hopefully address the remaining ones), regression fix from the recent HDA nightmare, and a race fix for Turing modesetting. Thanks, Ben. The following changes since commit

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-24 Thread Daniel Vetter
On Thu, Jul 23, 2020 at 4:46 PM Philipp Zabel wrote: > > Hi Daniel, > > On Thu, 2020-07-23 at 00:22 +0200, dan...@ffwll.ch wrote: > [...] > > Yeah the drmm_ versions of these need to check that the ->cleanup hook is > > NULL. > > > > Also there's not actually a double-free, since drm_foo_cleanup

Re: [PATCH v2] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-24 Thread Bartlomiej Zolnierkiewicz
On 7/23/20 4:21 PM, Greg Kroah-Hartman wrote: > On Wed, Jul 22, 2020 at 10:07:06AM +0200, Daniel Vetter wrote: >> On Tue, Jul 21, 2020 at 6:08 PM Greg Kroah-Hartman >> wrote: >>> >>> On Thu, Jul 16, 2020 at 08:27:21PM +0900, Tetsuo Handa wrote: On 2020/07/16 19:00, Daniel Vetter wrote:

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-24 Thread Daniel Vetter
On Fri, Jul 24, 2020 at 8:24 AM Sam Ravnborg wrote: > > Hi Dave. > On Fri, Jul 24, 2020 at 02:53:30PM +1000, Dave Airlie wrote: > > On Tue, 14 Jul 2020 at 18:56, Thomas Zimmermann wrote: > > > > > > Hi > > > > > > Am 14.07.20 um 10:41 schrieb Daniel Vetter: > > > > On Tue, Jul 14, 2020 at

Re: [PATCH] newport_con: vc_color is now in state

2020-07-24 Thread Jiri Slaby
On 24. 07. 20, 9:58, Greg KH wrote: > On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote: >> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as >> vc->state.color. Somehow both me and 0-day bot missed this driver during >> the conversion. >> >> So fix the driver now.

Re: [PATCH] newport_con: vc_color is now in state

2020-07-24 Thread Greg KH
On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote: > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as > vc->state.color. Somehow both me and 0-day bot missed this driver during > the conversion. > > So fix the driver now. > > Signed-off-by: Jiri Slaby > Cc:

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-24 Thread Philipp Zabel
Hi Thomas, On Fri, 2020-07-24 at 09:17 +0200, Thomas Zimmermann wrote: [...] > > > > @@ -71,6 +72,47 @@ int drm_simple_encoder_init(struct drm_device *dev, > > > > } > > > > EXPORT_SYMBOL(drm_simple_encoder_init); > > > > > > > > +static void drmm_encoder_cleanup(struct drm_device *dev, void

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-07-24 Thread Felipe Balbi
Nicolas Boichat writes: > On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi wrote: >> >> Nicolas Boichat writes: >> >> > trace_printk should not be used in production code, replace it >> > call with dev_dbg. >> > >> > Signed-off-by: Nicolas Boichat >> > >> > --- >> > >> > Unclear why a

Re: [PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-24 Thread Christian König
Am 24.07.20 um 08:50 schrieb Thomas Zimmermann: Am 23.07.20 um 17:17 schrieb Christian König: Instead use a boolean field in the memory manager structure. Also invert the meaning of the field since the use of a TT structure is the special case here. Signed-off-by: Christian König There's a

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Christian König
Am 24.07.20 um 00:58 schrieb Mazin Rezk: On Thursday, July 23, 2020 6:32 PM, Kees Cook wrote: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #90 from mn...@protonmail.com --- (In reply to Christian König from comment #89) > (In reply to mnrzk from comment #87) > > Good news, I wrote a patch that fixed this bug on my machine and submitted > > it to the Linux kernel mailing

Re: [v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-24 Thread Yongqiang Niu
On Thu, 2020-07-23 at 11:34 +0200, Enric Balletbo Serra wrote: > Hi Yongqian Niu, > > Thank you for your patch > > Missatge de Yongqiang Niu del dia dj., 23 > de jul. 2020 a les 4:05: > > > > move ddp component defint into mtk_mmsys.h > > > > There is a typo, should be "defines". But why you

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-24 Thread Christian König
Am 24.07.20 um 04:56 schrieb Felix Kuehling: Am 2020-07-23 um 9:58 p.m. schrieb philip yang: On 2020-07-23 7:02 p.m., Felix Kuehling wrote: Am 2020-07-23 um 5:00 a.m. schrieb Christian König: We can't pipeline that during eviction because the memory needs to be available immediately.

Re: [PATCH v2 2/2] iommu: Add gfp parameter to io_pgtable_ops->map()

2020-07-24 Thread Baolin Wang
On Tue, Jul 14, 2020 at 09:28:21AM +0100, Will Deacon wrote: > On Fri, Jun 12, 2020 at 11:39:55AM +0800, Baolin Wang wrote: > > Now the ARM page tables are always allocated by GFP_ATOMIC parameter, > > but the iommu_ops->map() function has been added a gfp_t parameter by > > commit 781ca2de89ba

Re: How to handle disconnection of eDP panels due to dynamic display mux switches

2020-07-24 Thread Daniel Dadap
Sorry for letting this stagnate. I have some patches ready for discussion which I'll send shortly, but wanted to follow up on some of the previous conversation: On 4/28/20 5:14 AM, Daniel Vetter wrote: On Wed, Apr 22, 2020 at 05:04:54PM -0500, Daniel Dadap wrote: On 4/3/20 2:59 PM, Daniel

[PATCH] drm: of: Fix double-free bug

2020-07-24 Thread Biju Das
Fix double-free bug in the error path. Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Reported-by: Pavel Machek Signed-off-by: Biju Das Cc: sta...@vger.kernel.org --- This patch is tested against drm-fixes and drm-next. --- drivers/gpu/drm/drm_of.c | 4 +--- 1 file

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #89 from Christian König (christian.koe...@amd.com) --- (In reply to mnrzk from comment #87) > Good news, I wrote a patch that fixed this bug on my machine and submitted > it to the Linux kernel mailing list [1]. You should probably

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-24 Thread Thomas Zimmermann
Hi Am 23.07.20 um 16:46 schrieb Philipp Zabel: > Hi Thomas, > > On Thu, 2020-07-23 at 09:35 +0200, Thomas Zimmermann wrote: >> Hi >> >> I have meanwhile seen your imx patchset where this would be useful. >> >> I still think you should try to pre-allocated all encoders up to a >> limit, so that

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-24 Thread Thomas Zimmermann
Hi Am 24.07.20 um 06:53 schrieb Dave Airlie: > On Tue, 14 Jul 2020 at 18:56, Thomas Zimmermann wrote: >> >> Hi >> >> Am 14.07.20 um 10:41 schrieb Daniel Vetter: >>> On Tue, Jul 14, 2020 at 08:41:58AM +0200, Thomas Zimmermann wrote: Hi Am 13.07.20 um 18:21 schrieb Daniel Vetter:

Re: [PATCH 8/9] drm/vram-helper: stop implementing init_mem_type

2020-07-24 Thread Thomas Zimmermann
Am 23.07.20 um 17:17 schrieb Christian König: > Instead just initialize the memory type parameters > before calling ttm_bo_init_mm. > > Signed-off-by: Christian König Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 16 > 1 file changed, 4

Re: [PATCH 9/9] drm/ttm: remove the init_mem_type callback

2020-07-24 Thread Thomas Zimmermann
Am 23.07.20 um 17:17 schrieb Christian König: > It is a very strange concept to call a function which just > calls back the caller for the functions parameters. > > Signed-off-by: Christian König Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 7 ---

Re: [PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-24 Thread Thomas Zimmermann
Am 23.07.20 um 17:17 schrieb Christian König: > Instead use a boolean field in the memory manager structure. > > Also invert the meaning of the field since the use of a TT > structure is the special case here. > > Signed-off-by: Christian König There's a comment further below. In any case

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-24 Thread Thomas Zimmermann
Am 23.07.20 um 17:17 schrieb Christian König: > Instead of repeating that in each driver. > > Signed-off-by: Christian König Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 --- > drivers/gpu/drm/drm_gem_vram_helper.c | 3 --- >

[PATCH] newport_con: vc_color is now in state

2020-07-24 Thread Jiri Slaby
Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as vc->state.color. Somehow both me and 0-day bot missed this driver during the conversion. So fix the driver now. Signed-off-by: Jiri Slaby Cc: Bartlomiej Zolnierkiewicz Cc: dri-devel@lists.freedesktop.org Cc:

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-24 Thread Sam Ravnborg
Hi Dave. On Fri, Jul 24, 2020 at 02:53:30PM +1000, Dave Airlie wrote: > On Tue, 14 Jul 2020 at 18:56, Thomas Zimmermann wrote: > > > > Hi > > > > Am 14.07.20 um 10:41 schrieb Daniel Vetter: > > > On Tue, Jul 14, 2020 at 08:41:58AM +0200, Thomas Zimmermann wrote: > > >> Hi > > >> > > >> Am