[PATCH 2/3] drm/amdgpu: Get DRM dev from adev by inline-f

2020-08-18 Thread Luben Tuikov
Add a static inline adev_to_drm() to obtain the DRM device pointer from an amdgpu_device pointer. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 6 +-

[PATCH 0/3] Embed drm_device and eliminate use of dev_private (v2)

2020-08-18 Thread Luben Tuikov
As per the comments in include/drm/drm_device.h, struct drm_device::dev_private seems to be obsolete and it's recommended that drivers embed struct drm_device into their larger per-device structure. This patchset embeds struct drm_device into struct amdgpu_device, adds inline functions to access

[PATCH 1/3] drm/amdgpu: drm_device to amdgpu_device by inline-f (v2)

2020-08-18 Thread Luben Tuikov
Get the amdgpu_device from the DRM device by use of an inline function, drm_to_adev(). The inline function resolves a pointer to struct drm_device to a pointer to struct amdgpu_device. v2: Use a typed visible static inline function instead of an invisible macro. Signed-off-by: Luben Tuikov

[PATCH 3/3] drm/amdgpu: Embed drm_device into amdgpu_device (v2)

2020-08-18 Thread Luben Tuikov
a) Embed struct drm_device into struct amdgpu_device. b) Modify the inline-f drm_to_adev() accordingly. c) Modify the inline-f adev_to_drm() accordingly. d) Eliminate the use of drm_device.dev_private, in amdgpu. e) Switch from using drm_dev_alloc() to drm_dev_init(). f) Add a DRM driver

Re: [Virtual ppce500] virtio_gpu virtio0: swiotlb buffer is full

2020-08-18 Thread Gerd Hoffmann
On Tue, Aug 18, 2020 at 04:41:38PM +0200, Christian Zigotzky wrote: > Hello Gerd, > > I compiled a new kernel with the latest DRM misc updates today. The patch is > included in these updates. > > This kernel works with the VirtIO-GPU in a virtual e5500 QEMU/KVM HV machine > on my X5000. > >

Re: [PATCH] drm/qxl: Fix build errors

2020-08-18 Thread Dave Airlie
On Tue, 18 Aug 2020 at 15:32, Gerd Hoffmann wrote: > > Hi, > > > I guess things are never quite so easy :-). It looks like Daniel's > > patch is in drm-misc-fixes and Sidong's patch is in drm-misc-next. On > > their own they're fine, but once they are merged in drm-tip the build > > error shows

Re: [PATCH v2 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

2020-08-18 Thread Almahallawy, Khaled
On Tue, 2020-08-18 at 14:29 -0700, Navare, Manasi wrote: > On Wed, Jul 22, 2020 at 05:36:27PM -0700, Khaled Almahallawy wrote: > > Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source > > tests. > > > > v2: uniform bit names TP4a/b/c (Manasi) > > > > Signed-off-by: Khaled Almahallawy >

Re: [PATCH v6 14/14] drm/print: Add tracefs support to the drm logging helpers

2020-08-18 Thread kernel test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master drm-exynos/exynos-drm-next v5.9-rc1 next-20200818] [cannot apply to drm/drm-next] [If your patch

Re: [PATCH v2 0/3] Fix Kconfig dependency issue with DMAENGINES selection

2020-08-18 Thread Laurent Pinchart
Matt, Alexandre, Gentle ping. As this should be fixed in v5.9, a quick reply would be really appreciated. Otherwise I'll have to bundle the rapidio fix with the DPSUB fix, and get them both merged through the DRM/KMS tree without your ack. On Wed, Aug 12, 2020 at 01:52:04AM +0300, Laurent

Re: [PATCH] drm: ast: fix double __iomem sparse warning

2020-08-18 Thread kernel test robot
Hi Randy, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.9-rc1 next-20200818] [cannot apply to linux/master drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 --- Comment #7 from Coleman Kane (ck...@colemankane.org) --- Thanks for the tip - I think I understand how this works now, so I will go through the cycles of bisecting and follow up with what it finds, or a patch if I think I'm able to address it

Re: [PATCH v6 11/14] drm/mst: Convert debug printers to debug category printers

2020-08-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Tue, 2020-08-18 at 17:05 -0400, Sean Paul wrote: > From: Sean Paul > > The printers in dp_mst are meant to be gated on DRM_UT_DP, so use the > debug category printer to avoid dumping mst transactions to the wrong > place. > > Signed-off-by: Sean Paul > Link: >

Re: [PATCH v8 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-08-18 Thread Lyude Paul
Just one small comment On Tue, 2020-08-18 at 11:39 -0400, Sean Paul wrote: > From: Sean Paul > > Used to query whether an MST stream is encrypted or not. > > Cc: Lyude Paul > Reviewed-by: Anshuman Gupta > Signed-off-by: Sean Paul > > Link: >

Re: [PATCH v2 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

2020-08-18 Thread Navare, Manasi
On Wed, Jul 22, 2020 at 05:36:27PM -0700, Khaled Almahallawy wrote: > Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. > > v2: uniform bit names TP4a/b/c (Manasi) > > Signed-off-by: Khaled Almahallawy Looks good to me, Reviewed-by: Manasi Navare Khaled, could you also

[PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers

2020-08-18 Thread Sean Paul
From: Sean Paul Use drm logging helpers to add support for the upcoming tracefs implementation. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-s...@poorly.run #v5 Changes in v5: -Added to the set Changes in v6: -None ---

[PATCH v6 04/14] drm/msm/dpu: Replace definitions for dpu debug macros

2020-08-18 Thread Sean Paul
From: Sean Paul The debug messages shouldn't be logged as errors when debug categories are enabled. Use the drm logging helpers to do the right thing Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-5-s...@poorly.run #v5 Changes in v5: -Added

[PATCH v6 13/14] drm/atomic: Use debug category printer for atomic state printer

2020-08-18 Thread Sean Paul
From: Sean Paul The atomic state is printed if the DRM_UT_STATE is active, but it's printed at INFO level. This patch converts it to use the debug category printer so: a- it's consistent with other DRM_UT_STATE logging b- it's properly routed through drm_trace when introduced Signed-off-by:

[PATCH v6 12/14] drm/i915: Use debug category printer for welcome message

2020-08-18 Thread Sean Paul
From: Sean Paul The welcome printer is meant to be gated on DRM_UT_DRIVER, so use the debug category printer to avoid dumping the message in the wrong place. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-13-s...@poorly.run #v5 Changes in

[PATCH v6 07/14] drm/etnaviv: Change buffer dump checks to target syslog

2020-08-18 Thread Sean Paul
From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Signed-off-by: Sean Paul Link:

[PATCH v6 06/14] drm/amd: Gate i2c transaction logs on drm_debug_syslog

2020-08-18 Thread Sean Paul
From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Acked-by: Christian König Signed-off-by: Sean Paul Link:

[PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs

2020-08-18 Thread Sean Paul
From: Sean Paul Mostly a rebase on drm-tip. New changes: - Use the new trace_array_init_printk() call init the global trace buffers. - Add patch 13 to the set to pipe atomic state logging through trace v5 is available here: https://patchwork.freedesktop.org/series/78133/ Sean Paul (14):

[PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog

2020-08-18 Thread Sean Paul
From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Signed-off-by: Sean Paul Link:

[PATCH v6 01/14] drm/mipi_dbi: Convert pr_debug calls to DRM_DEBUG_DRIVER

2020-08-18 Thread Sean Paul
From: Sean Paul Use the drm logging helpers to output these messages to ensure they'll be included by the drm tracefs instance. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-2-s...@poorly.run #v5 Changes in v5: -Added to the set Changes in

[PATCH v6 10/14] drm/print: Add drm_debug_category_printer

2020-08-18 Thread Sean Paul
From: Sean Paul This patch adds a new printer which will select the appropriate output for a given debug category. Currently there is only one output target, which is syslog. However in the future we'll have tracefs and it will be useful to print to syslog, tracefs, or both. Drivers just need to

[PATCH v6 14/14] drm/print: Add tracefs support to the drm logging helpers

2020-08-18 Thread Sean Paul
From: Sean Paul This patch adds a new module parameter called drm.trace which accepts the same mask as drm.debug. When a debug category is enabled, log messages will be put in a new tracefs instance called drm for consumption. Using the new tracefs instance will allow distros to enable drm

[PATCH v6 02/14] drm/sil164: Convert dev_printk to drm_dev_dbg

2020-08-18 Thread Sean Paul
From: Sean Paul Use the drm debug helper instead of dev_printk in order to leverage the upcoming tracefs support Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-3-s...@poorly.run #v5 Changes in v5: -Added to the set Changes in v6: -None ---

[PATCH v6 05/14] drm/print: rename drm_debug* to be more syslog-centric

2020-08-18 Thread Sean Paul
From: Sean Paul In preparation for tracefs support, rename drm_debug related functions to reflect that it targets the syslog. This will allow us to selectively target syslog and/or tracefs. No functional changes here. Signed-off-by: Sean Paul Link:

[PATCH v6 08/14] drm/nouveau: Change debug checks to specifically target syslog

2020-08-18 Thread Sean Paul
From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Signed-off-by: Sean Paul Link:

[PATCH v6 11/14] drm/mst: Convert debug printers to debug category printers

2020-08-18 Thread Sean Paul
From: Sean Paul The printers in dp_mst are meant to be gated on DRM_UT_DP, so use the debug category printer to avoid dumping mst transactions to the wrong place. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-12-s...@poorly.run #v5 Changes

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread James Bottomley
On Tue, 2020-08-18 at 13:10 -0700, Kees Cook wrote: > On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > > > On 8/17/20 12:48 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > > >

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-18 Thread John Stultz
On Tue, Aug 18, 2020 at 12:45 AM Hyesoo Yu wrote: > > These patch series to introduce a new dma heap, chunk heap. > That heap is needed for special HW that requires bulk allocation of > fixed high order pages. For example, 64MB dma-buf pages are made up > to fixed order-4 pages * 1024. > > The

Re: [PATCH v1 0/5] drm/panel: Use dev_ based logging

2020-08-18 Thread Sam Ravnborg
On Sat, Aug 15, 2020 at 02:54:01PM +0200, Sam Ravnborg wrote: > The drm/panel drivers uses a mixture of DRM_ and dev_ based logging. > With this patchset all panel drivers are migrated to use dev_ based > logging as the DRM_ based logging did not add any extra info. > > Drop the now unused

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread James Bottomley
On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > On 8/17/20 12:48 PM, Kees Cook wrote: > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > On 8/17/20 12:29 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote: > > > > > On 8/17/20 2:15 AM,

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote: > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > > On 8/17/20 12:48 PM, Kees Cook wrote: > > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > > On 8/17/20 12:29 PM, Kees Cook wrote: > > > > > On Mon, Aug

[Bug 208115] amdgpu (likely) - power management and display connection problems with an RX590 card

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208115 --- Comment #1 from Adarion from userland (h_mailingli...@posteo.de) --- Sadly I did not yet find the time for long time tests in my productive systems. a quick check: RX 590 in my FX-6300 based box (Asus M5A78L-M PLUS/USB3) I did one

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 --- Comment #6 from Coleman Kane (ck...@colemankane.org) --- Thanks Alex - I have added the four attachments you requested. I haven't done a git bisect before, but I am very familiar with using git and understand the concept of a bisect, so I

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 --- Comment #5 from Coleman Kane (ck...@colemankane.org) --- Created attachment 292017 --> https://bugzilla.kernel.org/attachment.cgi?id=292017=edit Xorg log from failure case (same 5.9-next kernel) Xorg.log from trying to run Xorg under

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 --- Comment #4 from Coleman Kane (ck...@colemankane.org) --- Created attachment 292015 --> https://bugzilla.kernel.org/attachment.cgi?id=292015=edit Xorg.log from working case (Arch 5.8.1-1 kernel) Xorg from working case on Arch 5.8.1-1 kernel

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 --- Comment #3 from Coleman Kane (ck...@colemankane.org) --- Created attachment 292013 --> https://bugzilla.kernel.org/attachment.cgi?id=292013=edit dmesg on faliure case from linux-next.git as of 2020-08-18 00:00:00 (pending-fixes branch) I

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 --- Comment #2 from Coleman Kane (ck...@colemankane.org) --- Created attachment 292011 --> https://bugzilla.kernel.org/attachment.cgi?id=292011=edit Working dmesg from Arch "linux" kernel 5.8.1-1 Working dmesg from Arch "linux" kernel 5.8.1-1

Re: [PATCH] drm/panel: s6e63m0: Order enable/disable sequence

2020-08-18 Thread Sam Ravnborg
Hi Linus. On Mon, Aug 17, 2020 at 11:39:06PM +0200, Linus Walleij wrote: > The upstream S6E63M0 driver has some pecularities around > the prepare/enable disable/unprepare sequence: the screen > is taken out of sleep in prepare() as part of > s6e63m0_init() the put to on with

Re: [PATCH v3 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-18 Thread Guido Günther
Hi Sam, On Tue, Aug 18, 2020 at 07:05:56PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote: > > > > The panel uses a Focaltech FT8006p, the touch part is handled by the already > > existing edt-ft5x06. It can be found in e.g. the Librem 5.

Re: [PATCH 0/4] drm/panel: s6e63m0: Add DSI transport

2020-08-18 Thread Sam Ravnborg
Hi Linus. On Sun, Aug 09, 2020 at 11:51:00PM +0200, Linus Walleij wrote: > This begins to modify the Samsung S6E63M0 driver to provide > DSI support. > > After these initial changes the driver can already be used > with the Samsung GT-I8190 (Golden) phone. > > After this initial support we will

Re: [PATCH] drm/malidp: Use struct drm_gem_object_funcs.get_sg_table internally

2020-08-18 Thread Liviu Dudau
On Thu, Aug 13, 2020 at 02:01:19PM +0200, Daniel Vetter wrote: > On Thu, Aug 13, 2020 at 12:39 PM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 13.08.20 um 12:31 schrieb Daniel Vetter: > > > On Thu, Aug 13, 2020 at 12:28:55PM +0200, Thomas Zimmermann wrote: > > >> > > >> > > >> Am 13.08.20 um

Re: [PATCH v3 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-18 Thread Sam Ravnborg
Hi Guido. On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote: > > The panel uses a Focaltech FT8006p, the touch part is handled by the already > existing edt-ft5x06. It can be found in e.g. the Librem 5. > > Changes from v2: > - Due to review comments by Sam Ravnborg, thanks! >

Re: [PATCH 1/2] dt-bindings: Add DT bindings for RaspberryPi 7" display ATTINY88-based regulator/backlight controller

2020-08-18 Thread Mark Brown
On Sun, 9 Aug 2020 12:59:37 +0200, Marek Vasut wrote: > Add DT bindings for RaspberryPi 7" display ATTINY88-based > regulator/backlight controller, this one is used in the > Raspberry Pi 7" touchscreen display unit. Applied to

Re: [PATCH 3/3] dma-heap: Devicetree binding for chunk heap

2020-08-18 Thread Rob Herring
On Tue, 18 Aug 2020 17:04:15 +0900, Hyesoo Yu wrote: > Document devicetree binding for chunk heap on dma heap framework > > Signed-off-by: Hyesoo Yu > --- > .../devicetree/bindings/dma-buf/chunk_heap.yaml| 46 > ++ > 1 file changed, 46 insertions(+) > create mode

[PATCH] drm/msm: enable vblank during atomic commits

2020-08-18 Thread Rob Clark
From: Rob Clark This has roughly the same effect as drm_atomic_helper_wait_for_vblanks(), basically just ensuring that vblank accounting is enabled so that we get valid timestamp/seqn on pageflip events. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_atomic.c | 36

[PATCH] drm/vkms: Use alpha value to blend values.

2020-08-18 Thread Sidong Yang
I wrote this patch for TODO list in vkms documentation. Use alpha value to blend source value and destination value Instead of just overwrite with source value. Cc: Rodrigo Siqueira Cc: Haneen Mohammed Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_composer.c | 14 --

[PATCH v8 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-08-18 Thread Sean Paul
From: Sean Paul Used to query whether an MST stream is encrypted or not. Cc: Lyude Paul Reviewed-by: Anshuman Gupta Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-s...@poorly.run #v4 Link:

[PATCH v8 16/17] drm/i915: Print HDCP version info for all connectors

2020-08-18 Thread Sean Paul
From: Sean Paul De-duplicate the HDCP version code for each connector and print it for all connectors. Cc: Juston Li Cc: Ramalingam C Reviewed-by: Juston Li Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v8 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-08-18 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Cc: Juston Li Reviewed-by: Anshuman Gupta Signed-off-by: Sean Paul

[PATCH v8 14/17] drm/i915: Add connector to hdcp_shim->check_link()

2020-08-18 Thread Sean Paul
From: Sean Paul Currently we derive the connector from digital port in check_link(). For MST, this isn't sufficient since the digital port passed into the function can have multiple connectors downstream. This patch adds connector to the check_link() arguments so we have it when we need it.

[PATCH v8 08/17] drm/i915: Clean up intel_hdcp_disable

2020-08-18 Thread Sean Paul
From: Sean Paul Add an out label and un-indent hdcp disable in preparation for hdcp_mutex. No functional changes Reviewed-by: Anshuman Gupta Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200429195502.39919-9-s...@poorly.run #v6

[PATCH v8 12/17] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst

2020-08-18 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so move them into a dedicated file for both sst and mst to use. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-11-s...@poorly.run #v1 Link:

[PATCH v8 05/17] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling

2020-08-18 Thread Sean Paul
From: Sean Paul Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi. This is particularly important for MST. Suggested-by: Ville Syrjälä Reviewed-by: Ramalingam C Signed-off-by: Sean

[PATCH v8 06/17] drm/i915: Factor out hdcp->value assignments

2020-08-18 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v8 09/17] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-08-18 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable

[PATCH v8 07/17] drm/i915: Protect workers against disappearing connectors

2020-08-18 Thread Sean Paul
From: Sean Paul This patch adds some protection against connectors being destroyed before the HDCP workers are finished. For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction. In the case of prop_work, we can't

[PATCH v8 13/17] drm/i915: Plumb port through hdcp init

2020-08-18 Thread Sean Paul
From: Sean Paul This patch plumbs port through hdcp init instead of relying on intel_attached_encoder() to return a non-NULL encoder which won't work for MST connectors. Cc: Ville Syrjälä Reviewed-by: Anshuman Gupta Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v8 11/17] drm/i915: Use ddi_update_pipe in intel_dp_mst

2020-08-18 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v8 10/17] drm/i915: Support DP MST in enc_to_dig_port() function

2020-08-18 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-9-s...@poorly.run #v1 Link:

[PATCH v8 04/17] drm/i915: Intercept Aksv writes in the aux hooks

2020-08-18 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an

[PATCH v8 02/17] drm/i915: Clear the repeater bit on HDCP disable

2020-08-18 Thread Sean Paul
From: Sean Paul On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect. Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation) Cc: Chris Wilson Cc: Ramalingam C Cc: Daniel Vetter Cc: Sean

[PATCH v8 01/17] drm/i915: Fix sha_text population code

2020-08-18 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being

[PATCH v8 03/17] drm/i915: WARN if HDCP signalling is enabled upon disable

2020-08-18 Thread Sean Paul
From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-s...@poorly.run #v2 Link:

[PATCH v8 00/17] drm/i915: Add support for HDCP 1.4 over MST

2020-08-18 Thread Sean Paul
From: Sean Paul Only one functional change, reversed the hdcp_1x/2x_present bits in the QUERY_STREAM_ENCRYPTION_STATUS parsing with a comment explaining my confusion. Other than that, lots of rebasing, the most notable being the s/intel_dig_port/dig_port/ rename. Every patch now has a

Re: [v2] drm/msm: add shutdown support for display platform_driver

2020-08-18 Thread Rob Clark
On Tue, Aug 18, 2020 at 3:03 AM Sai Prakash Ranjan wrote: > > Hi, > > On 2020-06-01 16:33, Krishna Manikandan wrote: > > Define shutdown callback for display drm driver, > > so as to disable all the CRTCS when shutdown > > notification is received by the driver. > > > > This change will turn off

Re: [PATCH] drm/amd/display: should check error using DC_OK

2020-08-18 Thread Alex Deucher
On Mon, Aug 17, 2020 at 3:08 AM Tong Zhang wrote: > > core_link_read_dpcd returns only DC_OK(1) and DC_ERROR_UNEXPECTED(-1), > the caller should check error using DC_OK instead of checking against 0 > > Signed-off-by: Tong Zhang Applied. Thanks! Alex > --- >

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-18 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: > > > > > > horizontal_backporch_byte should be hbp * bpp - hbp extra bytes. > > > So remove the wrong subtraction 10. > > > > >

Re: [PATCH][next] drm/amd/display: fix potential integer overflow when shifting 32 bit variable bl_pwm

2020-08-18 Thread Alex Deucher
On Tue, Aug 18, 2020 at 8:09 AM Colin King wrote: > > From: Colin Ian King > > The 32 bit unsigned integer bl_pwm is being shifted using 32 bit arithmetic > and then being assigned to a 64 bit unsigned integer. There is a potential > for a 32 bit overflow so cast bl_pwm to enforce a 64 bit

Re: [git pull] drm for 5.8-rc1

2020-08-18 Thread Thierry Reding
On Fri, Aug 14, 2020 at 07:25:17PM +0200, Daniel Vetter wrote: > On Fri, Aug 14, 2020 at 7:17 PM Daniel Stone wrote: > > > > Hi, > > > > On Fri, 14 Aug 2020 at 17:22, Thierry Reding > > wrote: > > > I suspect that the reason why this works in X but not in Wayland is > > > because X passes the

Re: [PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON

2020-08-18 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2020 at 05:19:40PM +0300, Tomer Samara wrote: > On Tue, Aug 18, 2020 at 04:11:06PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Aug 16, 2020 at 10:23:25PM +0300, Tomer Samara wrote: > > > BUG_ON() is replaced with WARN_ON at ion_page_pool.c > > > > Why? > > > > > Fixes the

Re: [PATCH v2 4/4] staging: android: Add error handling to order_to_index callers

2020-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 16, 2020 at 10:31:22PM +0300, Tomer Samara wrote: > Add error check to: > - free_buffer_page > - alloc_buffer_page > after calling order_to_index, due to converting BUG to WARN at > order_to_index. You are fixing a bug you caused in a previous patch, not good :) thanks, greg k-h

Re: [PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON

2020-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 16, 2020 at 10:23:25PM +0300, Tomer Samara wrote: > BUG_ON() is replaced with WARN_ON at ion_page_pool.c Why? > Fixes the following issue: > Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan > BUG() or BUG_ON(). Ideally you can get rid of WARN_ON() too,

Re: [PATCH v2 3/4] staging: android: Convert BUG to WARN

2020-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 16, 2020 at 10:30:10PM +0300, Tomer Samara wrote: > replace BUG() with WARN() at ion_sytem_heap.c, this > fix the following checkpatch issue: > Avoid crashing the kernel - try using WARN_ON & > recovery code ratherthan BUG() or BUG_ON(). > > Signed-off-by: Tomer Samara > --- >

Re: [PATCH v2 2/4] staging: android: Add error handling to ion_page_pool_shrink

2020-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 16, 2020 at 10:24:22PM +0300, Tomer Samara wrote: > Add error check to ion_page_pool_shrink after calling > ion_page_pool_remove, due to converting BUG_ON to WARN_ON. > > Signed-off-by: Tomer Samara So this fixes a previous patch? That's not good, please merge them together so you

[Bug 208909] amdgpu Ryzen 7 4700U NULL pointer dereference multi monitor with rotation

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208909 --- Comment #7 from ker...@890.at --- FullHD -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[Bug 208909] amdgpu Ryzen 7 4700U NULL pointer dereference multi monitor with rotation

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208909 --- Comment #6 from Alex Deucher (alexdeuc...@gmail.com) --- What resolutions are your displays? -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing

[Bug 208947] amdgpu DisplayPort won't recognize all display modes after 5.9 merges

2020-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208947 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: fbdevdrm

2020-08-18 Thread Thomas Zimmermann
(cc'ing dri-devel. It's public information that others should be able to find.) Hi Mark, generally speaking, what you try to do should be possible with fbconv/fbdevdrm. Am 17.08.20 um 21:12 schrieb Nnext unnnext: > Hey Thomas! > > I am working on postmarketOS, mobile Alpine Linux distribution,

[PATCH][next] drm/amd/display: fix potential integer overflow when shifting 32 bit variable bl_pwm

2020-08-18 Thread Colin King
From: Colin Ian King The 32 bit unsigned integer bl_pwm is being shifted using 32 bit arithmetic and then being assigned to a 64 bit unsigned integer. There is a potential for a 32 bit overflow so cast bl_pwm to enforce a 64 bit shift operation to avoid this. Addresses-Coverity:

[PATCH RESEND v10 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-08-18 Thread Jim Quinlan
Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. See the 'v1' notes below for more info. v10: Commit: "device-mapping: Introduce DMA range map,

[PATCH RESEND v10 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-08-18 Thread Jim Quinlan
The new field 'dma_range_map' in struct device is used to facilitate the use of single or multiple offsets between mapping regions of cpu addrs and dma addrs. It subsumes the role of "dev->dma_pfn_offset" which was only capable of holding a single uniform offset and had no region bounds checking.

[PATCH v3 0/2] Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html It only touches DRM (dri-devel) in such a way that it changes the help message of sysrq_drm_fb_helper_restore_op, otherwise it is unrelated to DRM. Patch 2/2 adds a configurable handler to execute a

[PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
Userland might want to execute e.g. 'w' (show blocked tasks), followed by 's' (sync), followed by 1000 ms delay and then followed by 'c' (crash) upon a single magic SysRq. Or one might want to execute the famous "Raising Elephants Is So Utterly Boring" action. This patch adds a configurable

[PATCH v3 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-18 Thread Andrzej Pietrasiewicz
All slots in sysrq_key_table[] are either used, reserved or at least commented with their intended use. This patch adds capital letter versions available, which means adding 26 more entries. For already existing SysRq operations the user presses Alt-SysRq-, and for the newly added ones

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-18 Thread Brian Starkey
Hi, On Tue, Aug 18, 2020 at 05:04:12PM +0900, Hyesoo Yu wrote: > These patch series to introduce a new dma heap, chunk heap. > That heap is needed for special HW that requires bulk allocation of > fixed high order pages. For example, 64MB dma-buf pages are made up > to fixed order-4 pages * 1024.

Re: [PATCH drm/hisilicon 0/4] Use drv_err instead of DRM_ERROR in hibmc driver

2020-08-18 Thread Sam Ravnborg
On Tue, Aug 18, 2020 at 02:51:40PM +0800, Tian Tao wrote: > patch #1 is using the drv_err instead of DRM_ERROR in hibmc_ttm.c > patch #2 is using the drv_err instead of DRM_ERROR in hibmc_drm_vdac.c > patch #3 is using the drv_err and drm_dbg_atomic instead of DRM_ERROR > and DRM_DEBUG_ATOMIC in

Re: [PATCH 2/3] dma-buf: heaps: add chunk heap to dmabuf heaps

2020-08-18 Thread David Hildenbrand
On 18.08.20 10:04, Hyesoo Yu wrote: > This patch adds support for a chunk heap that allows for buffers > that are made up of a list of fixed size chunks taken from a CMA. > Chunk sizes are configuratd when the heaps are created. > > Signed-off-by: Hyesoo Yu > --- > drivers/dma-buf/heaps/Kconfig

Re: [PATCH 16/20] drm/msm/a6xx: Add support for per-instance pagetables

2020-08-18 Thread Akhil P Oommen
Reviewed-by: Akhil P Oommen On 8/18/2020 3:31 AM, Rob Clark wrote: From: Jordan Crouse Add support for using per-instance pagetables if all the dependencies are available. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 63

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-08-18 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Jun 12, 2020 at 5:51 PM Laurent Pinchart wrote: > On Fri, Jun 12, 2020 at 05:36:07PM +0200, Eugeniu Rosca wrote: > > On Fri, Jun 12, 2020 at 06:10:05PM +0300, Laurent Pinchart wrote: > > > On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote: > > > > On Tue, Jun 09,

Re: [PATCH 0/4] *** SUBJECT HERE ***

2020-08-18 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2020 at 12:17:08PM +0300, Tomer Samara wrote: > *** BLURB HERE *** Really? And your subject line could use some work too :( ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH v2 2/2] drm/virtio: set max_segment

2020-08-18 Thread Gerd Hoffmann
When initializing call virtio_max_dma_size() to figure the scatter list limit. Needed to make virtio-gpu work properly with SEV. v2: place max_segment in drm driver not gem object. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Gerd Hoffmann
Add max_segment argument to drm_prime_pages_to_sg(). When set pass it through to the __sg_alloc_table_from_pages() call, otherwise use SCATTERLIST_MAX_SEGMENT. Also add max_segment field to drm driver and pass it to drm_prime_pages_to_sg() calls in drivers and helpers. v2: place max_segment in

[PATCH v2 0/2] drm: fix virtio-gpu + sev

2020-08-18 Thread Gerd Hoffmann
virtio-gpu must make sure scatter list segments are not too big. Gerd Hoffmann (2): drm: allow limiting the scatter list size. drm/virtio: set max_segment include/drm/drm_device.h| 8 include/drm/drm_prime.h | 3 ++-

Re: [PATCH 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Gerd Hoffmann
Hi, > > > I'm missing an explanation why this should be useful (it certainly is). > > virtio-gpu needs this to work properly with SEV (see patch 2/2 of this > > series). > > Yeah, that's the problem patch 2/2 never showed up here :) The list should have everything. Your inbox probably has

[PATCH 3/8] newport_con: make module's init & exit static using module_driver

2020-08-18 Thread Jiri Slaby
The compiler complains that newport_console_init and newport_console_exit are not declared: drivers/video/console/newport_con.c:745:12: warning: no previous prototype for 'newport_console_init' drivers/video/console/newport_con.c:750:13: warning: no previous prototype for

[PATCH 2/8] newport_con: fix no return statement in newport_show_logo

2020-08-18 Thread Jiri Slaby
When CONFIG_LOGO_SGI_CLUT224 is unset, newport_show_logo contains no return, despite it should return a pointer. Add one returning NULL to fix a compiler warning: drivers/video/console/newport_con.c: In function 'newport_show_logo': drivers/video/console/newport_con.c:132:1: warning: no

Re: [PATCH 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Christian König
Am 18.08.20 um 10:27 schrieb Gerd Hoffmann: On Tue, Aug 18, 2020 at 09:57:59AM +0200, Christian König wrote: Am 18.08.20 um 09:48 schrieb Gerd Hoffmann: Add max_segment argument to drm_prime_pages_to_sg(). When set pass it through to the __sg_alloc_table_from_pages() call, otherwise use

  1   2   >