Re: [PATCH 2/5] Fonts: Make font size unsigned in font_desc

2020-10-27 Thread Peilin Ye
On Tue, Oct 27, 2020 at 07:50:58PM +0100, Daniel Vetter wrote: > On Tue, Oct 27, 2020 at 12:33:05PM -0400, Peilin Ye wrote: > > It is improper to define `width` and `height` as signed in `struct > > font_desc`. Make them unsigned. Also, change the corresponding printk() > > format identifiers from

Re: Following up

2020-10-27 Thread Peilin Ye
On Tue, Oct 27, 2020 at 07:36:54PM +0100, Daniel Vetter wrote: > On Tue, Oct 27, 2020 at 5:50 PM Peilin Ye wrote: > > ...you mentioned code search, where & what should we look at, in order > > to confirm it's safe to remove them? > > Way back there was google's code search, which was

Re: [PATCH 4/5] fbcon: Avoid hard-coding built-in font charcount

2020-10-27 Thread Peilin Ye
On Tue, Oct 27, 2020 at 08:13:53PM +0100, Daniel Vetter wrote: > On Tue, Oct 27, 2020 at 12:37:29PM -0400, Peilin Ye wrote: > > fbcon_startup() and fbcon_init() are hard-coding the number of characters > > of our built-in fonts as 256. Recently, we included that information in > > our kernel font

[radeon-alex:drm-next 534/551] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/navi10_ppt.c:2532:35: warning: unused variable 'navi10_i2c_algo'

2020-10-27 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: 2e3a5bc5feeab1ed21f0105f1440a2ff0aef62f9 commit: 19cc89dcb94b47a015fece85db685f1a2563a422 [534/551] drm/amdgpu/swsmu: drop smu i2c bus on navi1x config: x86_64-randconfig-a004-20201026 (attached as .config) compiler: clang

Re: [PATCH 3/3] drm/ttm: avoid multihop moves in drivers.

2020-10-27 Thread Dave Airlie
Since I know both of you have looked at this, can someone give me an r-b? Dave. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: xlnx: Use dma_request_chan for DMA channel request

2020-10-27 Thread Hyun Kwon
Hi Peter, Thanks for the patch. On Fri, Oct 23, 2020 at 02:46:02AM -0700, Peter Ujfalusi wrote: > There is no need to use the of_dma_request_slave_channel() directly as > dma_request_chan() is going to try to get the channel via OF as well. > > Signed-off-by: Peter Ujfalusi So now

[radeon-alex:drm-next 511/551] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:1234:29: warning: no previous prototype for function 'asic_internal_ss_get_ss_table'

2020-10-27 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: 2e3a5bc5feeab1ed21f0105f1440a2ff0aef62f9 commit: f6638d0e6f93501dae110d66445c159309aa366a [511/551] drm/amd/pm: correct the checks for sclk/mclk SS support config: x86_64-randconfig-a004-20201026 (attached as .config)

linux-next: manual merge of the drm-misc tree with the amdgpu tree

2020-10-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c between commit: ff72bc403170 ("drm/amdgpu: Add debugfs entry for printing VM info") from the amdgpu tree and commit: 4671078eb8e3 ("drm/amdgpu: switch over to the new pin

Re: [PATCH 1/9] drm/ttm: new TT backend allocation pool v2

2020-10-27 Thread Dave Airlie
On Tue, 27 Oct 2020 at 03:41, Christian König wrote: > > This replaces the spaghetti code in the two existing page pools. > > First of all depending on the allocation size it is between 3 (1GiB) and > 5 (1MiB) times faster than the old implementation. > > It makes better use of buddy pages to

Re: [PATCH libdrm] xf86drm.c: Use integer logarithm.

2020-10-27 Thread Dave Airlie
I've applied this to libdrm master. Thanks, Dave. On Mon, 26 Oct 2020 at 23:27, Paul Gofman wrote: > > log() is affected by FP control word and can provide inaccurate result. > > Fixes Killer Instinct under Wine not being able to find AMD vulkan > device. > > Signed-off-by: Paul Gofman > --- >

[radeon-alex:drm-next 505/551] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:1743:13: warning: variable 'min' is used uninitialized whenever 'if' condition is false

2020-10-27 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: 2e3a5bc5feeab1ed21f0105f1440a2ff0aef62f9 commit: a90e6fbe47ff6707a57e55aa578e623b10f79b10 [505/551] drm/amd/pm: correct the settings for ro range minimum and maximum config: x86_64-randconfig-a004-20201026 (attached as

[PATCH] drm/shme-helpers: Fix dma_buf_mmap forwarding bug

2020-10-27 Thread Daniel Vetter
When we forward an mmap to the dma_buf exporter, they get to own everything. Unfortunately drm_gem_mmap_obj() overwrote vma->vm_private_data after the driver callback, wreaking the exporter complete. This was noticed because vb2_common_vm_close blew up on mali gpu with panfrost after commit

[radeon-alex:amd-staging-drm-next 294/322] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:1234:29: warning: no previous prototype for 'asic_internal_ss_get_ss_table'

2020-10-27 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: d8ac65b954234b1616864dc1cbdb7879be0ddc84 commit: 65030ffadab76b8309dca5bd751ca59b564b9fb5 [294/322] drm/amd/pm: correct the checks for sclk/mclk SS support config: alpha-allyesconfig (attached as .config) compiler:

RE: [PATCH v6 4/4] RDMA/mlx5: Support dma-buf based userspace memory region

2020-10-27 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Tuesday, October 27, 2020 1:08 PM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Leon Romanovsky > ; Sumit Semwal ; Christian Koenig > ; Vetter, Daniel > > Subject: Re:

RE: [PATCH v6 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-27 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Tuesday, October 27, 2020 1:00 PM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Leon Romanovsky > ; Sumit Semwal ; Christian Koenig > ; Vetter, Daniel > > Subject: Re:

[PATCH] drm/amd/display: remove unneeded semicolon

2020-10-27 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] drm: panel: simple: Allow timing constraints, not fixed delays

2020-10-27 Thread Sam Ravnborg
On Tue, Oct 27, 2020 at 08:23:18PM +0100, Daniel Vetter wrote: > On Tue, Oct 27, 2020 at 06:14:59PM +0100, Thierry Reding wrote: > > On Tue, Oct 27, 2020 at 09:45:54AM -0700, Douglas Anderson wrote: > > > The simple panel code currently allows panels to define fixed delays > > > at certain stages

Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property

2020-10-27 Thread Krzysztof Kozlowski
On Tue, Oct 27, 2020 at 10:19:28PM +0300, Dmitry Osipenko wrote: > 27.10.2020 13:25, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: > >> External memory controller is interconnected with memory controller and > >> with external memory. Document new

Re: [PATCH v6 08/52] dt-bindings: memory: tegra20: emc: Document mfd-simple compatible and statistics sub-device

2020-10-27 Thread Krzysztof Kozlowski
On Tue, Oct 27, 2020 at 10:22:19PM +0300, Dmitry Osipenko wrote: > 27.10.2020 12:02, Krzysztof Kozlowski пишет: > >> @@ -31,17 +32,34 @@ Example: > >>... > >>}; > >> > >> + emc_bw_dfs_opp_table: emc_opp_table1 { > > Hyphens for node name. > > We already use underscores for the

Re: [PATCH v6 09/52] dt-bindings: memory: tegra30: mc: Document new interconnect property

2020-10-27 Thread Krzysztof Kozlowski
On Tue, Oct 27, 2020 at 10:18:35PM +0300, Dmitry Osipenko wrote: > 27.10.2020 12:05, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:52AM +0300, Dmitry Osipenko wrote: > >> Memory controller is interconnected with memory clients and with the > >> External Memory Controller. Document

Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure

2020-10-27 Thread Jyri Sarha
On 26/10/2020 21:41, Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Wmissing-field-initializer warning when building with W=2 > turns into an error because tilcdc is built with -Werror: > > drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer >

Re: [PATCH v6 05/52] dt-bindings: memory: tegra20: mc: Document new interconnect property

2020-10-27 Thread Krzysztof Kozlowski
On Tue, Oct 27, 2020 at 10:17:48PM +0300, Dmitry Osipenko wrote: > 27.10.2020 11:55, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:48AM +0300, Dmitry Osipenko wrote: > >> Memory controller is interconnected with memory clients and with the > >> External Memory Controller. Document

Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property

2020-10-27 Thread Krzysztof Kozlowski
On Tue, Oct 27, 2020 at 10:17:19PM +0300, Dmitry Osipenko wrote: > 27.10.2020 11:54, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: > >> Tegra20 External Memory Controller talks to DRAM chips and it needs to be > >> reprogrammed when memory

Re: [PATCH 1/3] drm: panel: simple: Allow timing constraints, not fixed delays

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 06:14:59PM +0100, Thierry Reding wrote: > On Tue, Oct 27, 2020 at 09:45:54AM -0700, Douglas Anderson wrote: > > The simple panel code currently allows panels to define fixed delays > > at certain stages of initialization. These work OK, but they don't > > really map all

Re: [PATCH 6/8] drm: atomic: use krealloc_array()

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 01:17:23PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski Acked-by: Daniel Vetter I don't expect

Re: [PATCH 5/5] parisc/sticore: Avoid hard-coding built-in font charcount

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 12:41:02PM -0400, Peilin Ye wrote: > sti_select_fbfont() and sti_cook_fonts() are hard-coding the number of > characters of our built-in fonts as 256. Recently, we included that > information in our kernel font descriptor `struct font_desc`, so use > `fbfont->charcount`

Re: [PATCH 4/5] fbcon: Avoid hard-coding built-in font charcount

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 12:37:29PM -0400, Peilin Ye wrote: > fbcon_startup() and fbcon_init() are hard-coding the number of characters > of our built-in fonts as 256. Recently, we included that information in > our kernel font descriptor `struct font_desc`, so use `font->charcount` > instead of a

[PATCH] drm/amdgpu: remove unneeded semicolon

2020-10-27 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c

Re: [PATCH 03/65] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 7:51 PM Christoph Hellwig wrote: > Is there a list that has the cover letter and the whole series? > I've only found fragments (and mostly the same fragments) while > wading through my backlog in various list folders.. Typoed git send-email command that I only caught

Re: [PATCH 3/5] Fonts: Add charcount field to font_desc

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 12:34:26PM -0400, Peilin Ye wrote: > Subsystems are assuming the number of characters of our built-in fonts. > Include that information in our kernel font descriptor, `struct > font_desc`. > > Signed-off-by: Peilin Ye Reviewed-by: Daniel Vetter atm can't merge this

Re: [PATCH 2/5] Fonts: Make font size unsigned in font_desc

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 12:33:05PM -0400, Peilin Ye wrote: > It is improper to define `width` and `height` as signed in `struct > font_desc`. Make them unsigned. Also, change the corresponding printk() > format identifiers from `%d` to `%u`, in sti_select_fbfont(). > > Signed-off-by: Peilin Ye

Re: [Freedreno] [PATCH] drm/msm/dpu: fix clock scaling on non-sc7180 board

2020-10-27 Thread abhinavk
On 2020-10-27 03:23, Dmitry Baryshkov wrote: c33b7c0389e1 ("drm/msm/dpu: add support for clk and bw scaling for display") has added support for handling bandwidth voting in kms path in addition to old mdss path. However this broke all other platforms since _dpu_core_perf_crtc_update_bus() will

Re: [PATCH 1/5] fbdev/atafb: Remove unused extern variables

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 12:31:08PM -0400, Peilin Ye wrote: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with

Re: Following up

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 5:50 PM Peilin Ye wrote: > > Hi Daniel, > > More about the 3 things we've discussed before: > > 1. Cleaning up con_font_op(): > > (drivers/tty/vt/vt.c) > int con_font_op(struct vc_data *vc, struct console_font_op *op) > { > switch (op->op) { > case

Re: [PATCH 5/8] edac: ghes: use krealloc_array()

2020-10-27 Thread Borislav Petkov
On Tue, Oct 27, 2020 at 01:17:22PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/edac/ghes_edac.c | 4

Re: [PATCH 1/8] mm: slab: provide krealloc_array()

2020-10-27 Thread Vlastimil Babka
On 10/27/20 1:17 PM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users

RE: [PATCH v6 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-27 Thread Xiong, Jianxin
> -Original Message- > From: Christoph Hellwig > Sent: Tuesday, October 27, 2020 1:08 AM > To: Jason Gunthorpe > Cc: Christoph Hellwig ; Daniel Vetter ; > Xiong, Jianxin ; linux- > r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Leon Romanovsky > ; Doug Ledford ; > Vetter,

Re: [PATCH 1/3] drm: panel: simple: Allow timing constraints, not fixed delays

2020-10-27 Thread Thierry Reding
On Tue, Oct 27, 2020 at 09:45:54AM -0700, Douglas Anderson wrote: > The simple panel code currently allows panels to define fixed delays > at certain stages of initialization. These work OK, but they don't > really map all that clearly to the requirements presented in many > panel datasheets.

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-27 Thread Joe Perches
On Tue, 2020-10-27 at 17:58 +0100, Bartosz Golaszewski wrote: > On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote: > > > > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski >

[PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-10-27 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. v2: Init the hdcp port data k for HDMI/DP SST strem. v3: Cosmetic changes. [Uma] Cc: Ramalingam C Signed-off-by: Anshuman Gupta ---

[PATCH v4 15/16] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-10-27 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. v2: Added a WARN_ON() instead of drm_err. [Uma] Cosmetic chnages. [Uma] Cc: Ramalingam C Signed-off-by: Anshuman Gupta ---

[PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-27 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. This also enable the stream encryption support for older generations, which was missing earlier. v2: - Added debug print for stream encryption. - Disable the hdcp on port after disabling last stream encryption. v3: - Cosmetic change, removed the value less

[PATCH v4 09/16] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-10-27 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta ---

[PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-10-27 Thread Anshuman Gupta
Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP encryption over DP MST Transport Link. HDCP 1.4 stream encryption requires to validate the stream encryption status in HDCP_STATUS_{TRANSCODER,PORT} register driving

[PATCH v4 11/16] drm/hdcp: Max MST content streams

2020-10-27 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4

[PATCH v4 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-10-27 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2

[PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-10-27 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4 ++--

[PATCH v4 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-10-27 Thread Anshuman Gupta
Fix the size of WIRED_REPEATER_AUTH_STREAM_REQ cmd buffer size. It is based upon the actual number of MST streams and size of wired_cmd_repeater_auth_stream_req_in. Excluding the size of hdcp_cmd_header. v2: hdcp_cmd_header size annotation nitpick. [Tomas] Cc: Tomas Winkler Cc: Ramalingam C

[PATCH v4 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-10-27 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions(+) diff --git

[PATCH v4 16/16] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-10-27 Thread Anshuman Gupta
Enable HDCP 2.2 over DP MST. Authenticate and enable port encryption only once for an active HDCP 2.2 session, once port is authenticated and encrypted enable encryption for each stream that requires encryption on this port. Similarly disable the stream encryption for each encrypted stream, once

[PATCH v4 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-10-27 Thread Anshuman Gupta
DP MST stream encryption status requires time of a link frame in order to change its status, but as there were some HDCP encryption timeout observed earlier, it is safer to use ENCRYPT_STATUS_CHANGE_TIMEOUT_MS timeout for stream status too, it requires to move the macro to a header. It will be

[PATCH v4 00/16] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-10-27 Thread Anshuman Gupta
This is v4 version to test with IGT https://patchwork.freedesktop.org/series/82987/ This has addressed the review comments from Uma. It has been also tested manually with IGT above series. [PATCH v4 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len has an Ack from Tomas to merge it via

[PATCH v4 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-10-27 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp.c

[PATCH v4 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-10-27 Thread Anshuman Gupta
Gen12 has H/W delta with respect to HDCP{1.x,2.x} display engine instances lies in Transcoder instead of DDI as in Gen11. This requires hdcp driver to use mst_master_transcoder for link authentication and stream transcoder for stream encryption separately. This will be used for both HDCP 1.4 and

[PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-10-27 Thread Anshuman Gupta
When crtc state need_modeset is true it is not necessary it is going to be a real modeset, it can turns to be a fastset instead of modeset. This turns content protection property to be DESIRED and hdcp update_pipe left with property to be in DESIRED state but actual hdcp->value was ENABLED. This

[PATCH v4 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-10-27 Thread Anshuman Gupta
Get DRM connector reference count while scheduling a prop work to avoid any possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED state. Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing connectors") Cc: Sean Paul Cc: Ramalingam C Signed-off-by: Anshuman

Following up

2020-10-27 Thread Peilin Ye
Hi Daniel, More about the 3 things we've discussed before: 1. Cleaning up con_font_op(): (drivers/tty/vt/vt.c) int con_font_op(struct vc_data *vc, struct console_font_op *op) { switch (op->op) { case KD_FONT_OP_SET: return con_font_set(vc, op); case

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-27 Thread Joe Perches
On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Use the helper that checks for overflows internally instead of manually > > calculating the size of the new array. > > > >

Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-27 Thread Arnd Bergmann
On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson wrote: > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > >

Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure

2020-10-27 Thread Arnd Bergmann
On Tue, Oct 27, 2020 at 4:31 PM Jyri Sarha wrote: > On 26/10/2020 21:41, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The -Wmissing-field-initializer warning when building with W=2 > > turns into an error because tilcdc is built with -Werror: > > > > drm/tilcdc/tilcdc_drv.c:431:33:

[PATCH 1/3] drm: panel: simple: Allow timing constraints, not fixed delays

2020-10-27 Thread Douglas Anderson
The simple panel code currently allows panels to define fixed delays at certain stages of initialization. These work OK, but they don't really map all that clearly to the requirements presented in many panel datasheets. Instead of defining a fixed delay, those datasheets provide a timing diagram

[PATCH 2/3] drm: panel: simple: Add BOE NV110WTM-N61

2020-10-27 Thread Douglas Anderson
Add support for the BOE NV110WTM-N61 panel. The EDID lists two modes (one for 60 Hz refresh rate and one for 40 Hz), so we'll list both of them here. Note that the panel datasheet requires 80 ms between HPD asserting and the backlight power being turned on. We'll use the new timing constraints

[PATCH 3/3] dt-bindings: dt-bindings: display: simple: Add BOE NV110WTM-N61

2020-10-27 Thread Douglas Anderson
Add yet another eDP panel. Signed-off-by: Douglas Anderson --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

Subject: [RFC] clang tooling cleanups

2020-10-27 Thread trix
This rfc will describe An upcoming treewide cleanup. How clang tooling was used to programatically do the clean up. Solicit opinions on how to generally use clang tooling. The clang warning -Wextra-semi-stmt produces about 10k warnings. Reviewing these, a subset of semicolon after a switch looks

[PATCH 5/5] parisc/sticore: Avoid hard-coding built-in font charcount

2020-10-27 Thread Peilin Ye
sti_select_fbfont() and sti_cook_fonts() are hard-coding the number of characters of our built-in fonts as 256. Recently, we included that information in our kernel font descriptor `struct font_desc`, so use `fbfont->charcount` instead of hard-coded values. This patch depends on patch "Fonts: Add

[PATCH 4/5] fbcon: Avoid hard-coding built-in font charcount

2020-10-27 Thread Peilin Ye
fbcon_startup() and fbcon_init() are hard-coding the number of characters of our built-in fonts as 256. Recently, we included that information in our kernel font descriptor `struct font_desc`, so use `font->charcount` instead of a hard-coded value. This patch depends on patch "Fonts: Add

[PATCH 3/5] Fonts: Add charcount field to font_desc

2020-10-27 Thread Peilin Ye
Subsystems are assuming the number of characters of our built-in fonts. Include that information in our kernel font descriptor, `struct font_desc`. Signed-off-by: Peilin Ye --- include/linux/font.h | 1 + lib/fonts/font_10x18.c | 1 + lib/fonts/font_6x10.c | 1 +

[PATCH 2/5] Fonts: Make font size unsigned in font_desc

2020-10-27 Thread Peilin Ye
It is improper to define `width` and `height` as signed in `struct font_desc`. Make them unsigned. Also, change the corresponding printk() format identifiers from `%d` to `%u`, in sti_select_fbfont(). Signed-off-by: Peilin Ye --- Build-tested. drivers/video/console/sticore.c | 2 +-

[PATCH 1/5] fbdev/atafb: Remove unused extern variables

2020-10-27 Thread Peilin Ye
Remove 6 unused extern variables to reduce confusion. It is worth mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file has nothing to do with them. Signed-off-by: Peilin Ye --- $ # Build-tested (Ubuntu 20.04) $

[PATCH 0/5] Preparation work for using font_desc in vc_data

2020-10-27 Thread Peilin Ye
Hi Daniel, Hi Greg, Hi all, We are planning to use `font_desc` instead of `console_font` in `vc_data`, and this is just some prep work for it. It doesn't do much, but at least it removes two "FIXME"s in fbcon.c :) Peilin Ye (5): [1/5] fbdev/atafb: Remove unused extern variables Searching for

Re: [PATCH] drm/vc4: hdmi: Avoid sleeping in atomic context

2020-10-27 Thread Mark Brown
On Tue, Oct 27, 2020 at 11:15:58AM +0100, Maxime Ripard wrote: > When running the trigger hook, ALSA by default will take a spinlock, and > thus will run the trigger hook in atomic context. Reviewed-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] drm/msm/a6xx: Add support for using system cache on MMU500 based targets

2020-10-27 Thread Robin Murphy
On 2020-10-26 18:54, Jordan Crouse wrote: This is an extension to the series [1] to enable the System Cache (LLC) for Adreno a6xx targets. GPU targets with an MMU-500 attached have a slightly different process for enabling system cache. Use the compatible string on the IOMMU phandle to see if

Re: [PATCH] drm: bridge: cdns: Kconfig: Switch over dependency to ARCH_K3

2020-10-27 Thread Tomi Valkeinen
On 26/10/2020 18:54, Nishanth Menon wrote: > With the integration of chip-id detection scheme in kernel[1], there > is no specific need to maintain multitudes of SoC specific config > options, discussed as per [2], we have deprecated the usage in other > places for v5.10-rc1. Fix the missing user

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 2:52 PM Hans de Goede wrote: > > Add missing pci_iounmap() calls to properly unmap the memory on > probe-failure and remove. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Hans de Goede I think switching over to devm would be really

Re: [PATCH v2 1/3] drm/radeon: Add new callback that exposes vddc

2020-10-27 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 27, 2020 at 7:53 AM Sandeep wrote: > > On Mon, 26 Oct 2020 at 23:53, Alex Deucher wrote: > > > > I don't see them on the mailing list. Are you sure they went out? > > > > Alex > > The original email in this chain is the v2, sent in the correct form. > > > >

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski No problem with the patch, it does

Re: [PATCH 2/4] drm/imx: tve remove extraneous type qualifier

2020-10-27 Thread Philipp Zabel
On Mon, 2020-10-26 at 20:41 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang warns about functions returning a 'const int' result: > > drivers/gpu/drm/imx/imx-tve.c:487:8: warning: type qualifiers ignored on > function return type [-Wignored-qualifiers] > > Remove the extraneous

Re: [PATCH] drm/msm/a6xx: Add support for using system cache on MMU500 based targets

2020-10-27 Thread Jordan Crouse
On Tue, Oct 27, 2020 at 12:38:02PM +0530, Sai Prakash Ranjan wrote: > On 2020-10-27 00:24, Jordan Crouse wrote: > >This is an extension to the series [1] to enable the System Cache (LLC) > >for > >Adreno a6xx targets. > > > >GPU targets with an MMU-500 attached have a slightly different process

Re: [PATCH 2/4] disp/msm/dpu: add support to dump dpu registers

2020-10-27 Thread kernel test robot
Hi Abhinav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.10-rc1 next-20201027] [cannot apply to drm/drm-next

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:16AM +0300, Dmitry Osipenko wrote: > Now Internal and External Memory Controllers are memory interconnection > providers. This allows us to use interconnect API for tuning of memory > configuration. EMC driver now supports OPPs and DVFS. > > Signed-off-by: Dmitry

Re: [PATCH v6 31/52] memory: tegra20-emc: Use devm_platform_ioremap_resource()

2020-10-27 Thread Krzysztof Kozlowski
On Tue, 27 Oct 2020 at 14:50, Thierry Reding wrote: > > On Mon, Oct 26, 2020 at 01:17:14AM +0300, Dmitry Osipenko wrote: > > Use devm_platform_ioremap_resource() helper which makes code a bit > > cleaner. > > > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/memory/tegra/tegra20-emc.c | 4

Re: [PATCH v6 32/52] memory: tegra20-emc: Continue probing if timings are missing in device-tree

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:15AM +0300, Dmitry Osipenko wrote: > EMC driver will become mandatory after turning it into interconnect > provider because interconnect users, like display controller driver, will > fail to probe using newer device-trees that have interconnect properties. > Thus make

[PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-10-27 Thread Hans de Goede
Add missing pci_iounmap() calls to properly unmap the memory on probe-failure and remove. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_main.c | 23 --- 1 file changed, 16 insertions(+), 7

Re: [PATCH v6 31/52] memory: tegra20-emc: Use devm_platform_ioremap_resource()

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:14AM +0300, Dmitry Osipenko wrote: > Use devm_platform_ioremap_resource() helper which makes code a bit > cleaner. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra20-emc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) I'm not a

Re: [PATCH v6 30/52] memory: tegra20-emc: Make driver modular

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:13AM +0300, Dmitry Osipenko wrote: > This patch adds modularization support to the Tegra20 EMC driver. Driver > now can be compiled as a loadable kernel module. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/Kconfig | 2 +- >

Re: [PATCH v6 29/52] memory: tegra-mc: Add interconnect framework

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:12AM +0300, Dmitry Osipenko wrote: > Now Memory Controller is a memory interconnection provider. This allows > us to use interconnect API for tuning of memory configuration. This patch > adds common ICC core and adds hooks which should be implemented by the SoC >

Re: [PATCH v6 28/52] memory: tegra: Add and use devm_tegra_get_memory_controller()

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:11AM +0300, Dmitry Osipenko wrote: > Multiple Tegra drivers need to retrieve Memory Controller and there is > duplication of the retrieval code among the drivers. This patch removes > the duplication and fixes put_device() which was missed in the duplicated > code. >

Re: [PATCH v6 21/52] ARM: tegra: Add interconnect properties to Tegra20 device-tree

2020-10-27 Thread Thierry Reding
On Tue, Oct 27, 2020 at 10:12:47AM +0100, Krzysztof Kozlowski wrote: > On Mon, Oct 26, 2020 at 01:17:04AM +0300, Dmitry Osipenko wrote: > > Add interconnect properties to the Memory Controller, External Memory > > Controller and the Display Controller nodes in order to describe hardware > >

Re: [PATCH v6 08/52] dt-bindings: memory: tegra20: emc: Document mfd-simple compatible and statistics sub-device

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:16:51AM +0300, Dmitry Osipenko wrote: > External Memory Controller can gather various hardware statistics that > are intended to be used for debugging purposes and for dynamic frequency > scaling of memory bus. > > Document the new mfd-simple compatible and EMC

Re: [PATCH v6 03/52] dt-bindings: memory: tegra20: emc: Correct registers range in example

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:16:46AM +0300, Dmitry Osipenko wrote: > There is superfluous zero in the registers base address and registers > size should be twice bigger. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 +- > 1 file

Re: [PATCH v6 02/52] soc/tegra: fuse: Export tegra_read_ram_code()

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:16:45AM +0300, Dmitry Osipenko wrote: > The tegra_read_ram_code() is used by EMC drivers and we're going to make > these driver modular, hence this function needs to be exported. > > Signed-off-by: Dmitry Osipenko > --- > drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 ++

Re: [PATCH v6 01/52] clk: tegra: Export Tegra20 EMC kernel symbols

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:16:44AM +0300, Dmitry Osipenko wrote: > We're going to modularize Tegra EMC drivers and some of the EMC clk driver > symbols need to be exported, let's export them. > > Signed-off-by: Dmitry Osipenko > --- > drivers/clk/tegra/clk-tegra20-emc.c | 3 +++ > 1 file

Re: [PATCH 1/9] drm/ttm: new TT backend allocation pool v2

2020-10-27 Thread Huang Rui
On Mon, Oct 26, 2020 at 06:41:09PM +0100, Christian König wrote: > This replaces the spaghetti code in the two existing page pools. > > First of all depending on the allocation size it is between 3 (1GiB) and > 5 (1MiB) times faster than the old implementation. > > It makes better use of buddy

Re: [PATCH 2/8] ALSA: pcm: use krealloc_array()

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 13:17:19 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Takashi Iwai thanks,

Re: [PATCH 8/8] dma-buf: use krealloc_array()

2020-10-27 Thread Christian König
Am 27.10.20 um 13:17 schrieb Bartosz Golaszewski: From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Christian König --- drivers/dma-buf/sync_file.c | 4

Re: [PATCH v3 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-27 Thread Anshuman Gupta
On 2020-10-27 at 11:59:14 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.org; Nikula, Jani ; C, > > Ramalingam ;

Re: [PATCH 1/9] drm/ttm: new TT backend allocation pool v2

2020-10-27 Thread Huang Rui
On Mon, Oct 26, 2020 at 06:41:09PM +0100, Christian König wrote: > This replaces the spaghetti code in the two existing page pools. > > First of all depending on the allocation size it is between 3 (1GiB) and > 5 (1MiB) times faster than the old implementation. > > It makes better use of buddy

Re: [PATCH v2 1/3] drm/radeon: Add new callback that exposes vddc

2020-10-27 Thread Sandeep
On Mon, 26 Oct 2020 at 23:53, Alex Deucher wrote: > > I don't see them on the mailing list. Are you sure they went out? > > Alex The original email in this chain is the v2, sent in the correct form. > > On Sat, Oct 24, 2020 at 1:47 PM Sandeep wrote: > > > > Hello, > > > > I've resent the

Re: [PATCH] drm/vc4: hdmi: Avoid sleeping in atomic context

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 11:15:58 +0100, Maxime Ripard wrote: > > When running the trigger hook, ALSA by default will take a spinlock, and > thus will run the trigger hook in atomic context. > > However, our HDMI driver will send the infoframes as part of the trigger > hook, and part of that process

Re: [PATCH v6 41/52] memory: tegra124-emc: Use devm_platform_ioremap_resource()

2020-10-27 Thread Krzysztof Kozlowski
On Mon, Oct 26, 2020 at 01:17:24AM +0300, Dmitry Osipenko wrote: > Use devm_platform_ioremap_resource() helper which makes code a bit > cleaner. Such cleanups (and few other in this patchset) should be at beginning of patchset or even as part of a separate one. I think there is not much stopping

  1   2   >