Re: [PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

2021-10-11 Thread Lucas De Marchi
On Mon, Oct 11, 2021 at 9:10 AM Ramalingam C wrote: > > Details of the new features getting added as part of DG2 enabling and their > implicit impact on the uAPI. > > Signed-off-by: Ramalingam C > cc: Daniel Vetter > cc: Matthew Auld > --- > Documentation/gpu/rfc/i915_dg2.rst | 47

Re: [PATCH v2 2/2] qcom_scm: hide Kconfig symbol

2021-10-11 Thread John Stultz
On Thu, Oct 7, 2021 at 8:10 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Now that SCM can be a loadable module, we have to add another > dependency to avoid link failures when ipa or adreno-gpu are > built-in: > > aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': >

Re: [PATCH] drm/msm/dp: do not initialize combo phy until plugin interrupt

2021-10-11 Thread Bjorn Andersson
On Wed 06 Oct 10:59 CDT 2021, Kuogee Hsieh wrote: > Combo phy support both USB3 and DP simultaneously. USB3 is the > master of combo phy so that USB3 should initialize and power on > its phy before DP initialize its phy. At current implementation, > DP driver initialize its phy happen earlier

linux-next: build failure after merge of the drm-misc tree

2021-10-11 Thread Stephen Rothwell
=unused-variable] 491 | u32 inst, aper; | ^~~~ cc1: all warnings being treated as errors Caused by commit 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.") I have used the drm-misc tree from next-20211011 for today. -- Cheers, Stephe

Re: [PATCH] drm/msm/dpu: Add CRC support for DPU

2021-10-11 Thread Dmitry Baryshkov
On 12/10/2021 02:41, Jessica Zhang wrote: Add CRC support to DPU, which is currently not supported by this driver. Only supports CRC for CRTC for now, but will extend support to other blocks later on. Tested on Qualcomm RB3 (debian, sdm845) Signed-off-by: Jessica Zhang ---

Re: BUG: KASAN: use-after-free in enqueue_timer+0x4f/0x1e0

2021-10-11 Thread David Airlie
On Tue, Oct 12, 2021 at 2:07 AM Kim Phillips wrote: > > Hi, > > On 10/5/21 1:10 PM, Kim Phillips wrote: > > Hi, I occasionally see the below trace with Linus' master on an > > AMD Milan system: > > > > [ 25.657322] BUG: kernel NULL pointer dereference, address: > > > > [

Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding

2021-10-11 Thread Rob Herring
On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The controller can have two forms,

Re: [PATCH 0/5] Revert series "CMDQ refinement of Mediatek DRM driver"

2021-10-11 Thread Chun-Kuang Hu
Enric Balletbo Serra 於 2021年10月8日 週五 下午9:33寫道: > > Hi Chun-Kuang, > > Thank you to take time to send this, for full series > > Tested-by: Enric Balletbo i Serra > > Display is now working again. Applied to mediatek-drm-fixes [1]. [1]

Re: [PATCH v4 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-10-11 Thread kernel test robot
Hi Markus, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on pza/reset/next linus/master v5.15-rc5 next-20211011] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH] drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-11 Thread Matthew Brost
The hangcheck selftest blocks per engine resets by setting magic bits in the reset flags. This is incorrect for GuC submission because if the GuC fails to reset an engine we would like to do a full GT reset. Do no set these magic bits when using GuC submission. Side note this lockless algorithm

Re: [PATCH v4 1/7] dt-bindings: mediatek,dpintf: Add DP_INTF binding

2021-10-11 Thread Rob Herring
On Mon, 11 Oct 2021 11:46:18 +0200, Markus Schneider-Pargmann wrote: > DP_INTF is a similar functional block to mediatek,dpi but is different > in that it serves the DisplayPort controller on mediatek SoCs and uses > different clocks. Therefore this patch creates a new binding file for > this

Re: [PATCH] [v5] dt-bindings: drm/msm/gpu: convert to YAML

2021-10-11 Thread Rob Herring
On Sun, Oct 10, 2021 at 10:42:45AM +0200, David Heidelberg wrote: > Conversion of text binding for Adreno GPU to the YAML format. Blank line needed. > Signed-off-by: David Heidelberg > --- > v2: > - added compatbile description from Rob Clark > - dropped reg description > - reg numbers

[PATCH] drm/msm/dpu: Add CRC support for DPU

2021-10-11 Thread Jessica Zhang
Add CRC support to DPU, which is currently not supported by this driver. Only supports CRC for CRTC for now, but will extend support to other blocks later on. Tested on Qualcomm RB3 (debian, sdm845) Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 169

Re: [PATCH 20/26] drm/i915/guc: Implement no mid batch preemption for multi-lrc

2021-10-11 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: For some users of multi-lrc, e.g. split frame, it isn't safe to preempt mid BB. To safely enable preemption at the BB boundary, a handshake between to parent and child is needed. This is implemented via custom between to parent -> between parent

Re: [RFC PATCH 2/2] RDMA/efa: Add support for dmabuf memory regions

2021-10-11 Thread Jason Gunthorpe
On Sun, Oct 10, 2021 at 09:55:49AM +0300, Gal Pressman wrote: > On 07/10/2021 14:40, Jason Gunthorpe wrote: > > On Thu, Oct 07, 2021 at 01:43:00PM +0300, Gal Pressman wrote: > > > >> @@ -1491,26 +1493,29 @@ static int efa_create_pbl(struct efa_dev *dev, > >>return 0; > >> } > >> > >>

Re: [PATCH 17/26] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 03:09:43PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Introduce 'set parallel submit' extension to connect UAPI to GuC > > multi-lrc interface. Kernel doc in new uAPI should explain it all. > > > > IGT:

Re: [PATCH 24/26] drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fences

2021-10-11 Thread Daniele Ceraolo Spurio
On 10/4/2021 3:06 PM, Matthew Brost wrote: Parallel submission create composite fences (dma_fence_array) for excl / shared slots in objects. The I915_GEM_BUSY IOCTL checks these slots to determine the busyness of the object. Prior to patch it only check if the fence in the slot was a

Re: Questions over DSI within DRM.

2021-10-11 Thread Andrzej Hajda
On 08.10.2021 19:33, Dave Stevenson wrote: On Thu, 7 Oct 2021 at 21:19, Andrzej Hajda wrote: On 07.10.2021 13:07, Dave Stevenson wrote: On Tue, 5 Oct 2021 at 22:03, Andrzej Hajda wrote: On 05.10.2021 17:32, Dave Stevenson wrote: Hi Andrzej Thanks for joining in the discussion. On Tue,

Re: [PATCH 17/26] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-11 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Introduce 'set parallel submit' extension to connect UAPI to GuC multi-lrc interface. Kernel doc in new uAPI should explain it all. IGT: https://patchwork.freedesktop.org/patch/447008/?series=93071=1 media UMD:

Re: [PATCH v4 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-10-11 Thread kernel test robot
Hi Markus, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on pza/reset/next linus/master v5.15-rc5 next-20211011] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH] drm/panel-simple: Add Vivax TPC-9150 panel v6

2021-10-11 Thread Nikola Pavlica
The model and make of the LCD panel of the Vivax TPC-9150 is unknown, hence the panel settings that were retrieved with a FEX dump are named after the device NOT the actual panel. The LCD in question is a 50 pin MISO TFT LCD panel of the resolution 1024x600 used by the aforementioned device.

Re: [PATCH v4 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-10-11 Thread kernel test robot
Hi Markus, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on pza/reset/next linus/master v5.15-rc5 next-20211011] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [Freedreno] [PATCH v2] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL

2021-10-11 Thread abhinavk
On 2021-10-11 13:16, Marijn Suijten wrote: div_u64_rem provides the result of the division and additionally the remainder; don't use this function to solely calculate the remainder while calculating the division again with div_u64. A similar improvement was applied earlier to the 10nm pll in

Re: [PATCH v3 4/5] drm: mxsfb: Print failed bus format in hex

2021-10-11 Thread Laurent Pinchart
Hi Guido, Thank you for the patch. On Mon, Oct 11, 2021 at 03:41:26PM +0200, Guido Günther wrote: > media-bus-formats.h has them in hexadecimal as well so matching with > that file saves one conversion when debugging. > > Signed-off-by: Guido Günther > Reviewed-by: Lucas Stach > Reviewed-by:

Re: [PATCH] drm/bridge: dw-mipi-dsi: Find the possible DSI devices

2021-10-11 Thread Michael Nazzareno Trimarchi
On Mon, Oct 11, 2021 at 8:43 AM Michael Trimarchi wrote: > > Hi > > On Sun, Jul 04, 2021 at 07:33:09PM +0530, Jagan Teki wrote: > > Finding panel_or_bridge might vary based on associated > > DSI devices like DSI panel, bridge, and I2C based DSI > > bridge. > > > > 1. DSI panels and bridges will

Re: [PATCH 00/13] Make some spi device drivers return zero in .remove()

2021-10-11 Thread Uwe Kleine-König
Hello, On Mon, Oct 11, 2021 at 03:27:41PM +0200, Uwe Kleine-König wrote: > this series is part of my new quest to make spi remove callbacks return > void. Today they return an int, but the only result of returning a > non-zero value is a warning message. So it's a bad idea to return an > error

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-10-11 Thread Sam Ravnborg
Hi Alexander, On Wed, Oct 06, 2021 at 09:47:13AM +0200, Alexander Stein wrote: > The enable signal may not be controllable by the kernel. Make it > optional. > This is a similar to commit bbda1704fc15 ("drm/bridge: ti-sn65dsi86: Make > enable GPIO optional") > > Signed-off-by: Alexander Stein

Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-11 Thread Sam Ravnborg
On Wed, Oct 06, 2021 at 09:47:12AM +0200, Alexander Stein wrote: > Add a VCC regulator which needs to be enabled before the EN pin is > released. > > Signed-off-by: Alexander Stein Looks good, Reviewed-by: Sam Ravnborg When you resend please put bindings patches first, we should not commit

Re: [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-11 Thread Lukas Wunner
On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: > Debugfs APIs returns encoded error on failure so use > debugfs_lookup() instead of checking for NULL. [...] > --- a/drivers/gpu/vga/vga_switcheroo.c > +++ b/drivers/gpu/vga/vga_switcheroo.c > @@ -914,7 +914,7 @@ static void

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

2021-10-11 Thread Sam Ravnborg
Hi Alexander, On Wed, Oct 06, 2021 at 09:47:11AM +0200, Alexander Stein wrote: > VCC needs to be enabled before releasing the enable GPIO. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) >

Re: [PATCH v2] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL

2021-10-11 Thread AngeloGioacchino Del Regno
div_u64_rem provides the result of the division and additionally the remainder; don't use this function to solely calculate the remainder while calculating the division again with div_u64. A similar improvement was applied earlier to the 10nm pll in 5c191fef4ce2 ("drm/msm/dsi_pll_10nm: Fix

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

2021-10-11 Thread Sam Ravnborg
Hi Alexander, On Wed, Oct 06, 2021 at 09:47:11AM +0200, Alexander Stein wrote: > VCC needs to be enabled before releasing the enable GPIO. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) >

[PATCH v2] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL

2021-10-11 Thread Marijn Suijten
div_u64_rem provides the result of the division and additionally the remainder; don't use this function to solely calculate the remainder while calculating the division again with div_u64. A similar improvement was applied earlier to the 10nm pll in 5c191fef4ce2 ("drm/msm/dsi_pll_10nm: Fix

Re: [PATCH] dt-bindings: display/bridge: tc358764: Convert to YAML binding

2021-10-11 Thread Sam Ravnborg
Hi AngeloGioacchino, On Wed, Oct 06, 2021 at 03:51:50PM +0200, AngeloGioacchino Del Regno wrote: > Convert the Toshiba TC358764 txt documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > Thanks for all these conversions to DT-schema. It would be very good if the changelog

Re: [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-11 Thread Umesh Nerlige Ramappa
On Mon, Oct 11, 2021 at 12:41:19PM +0100, Tvrtko Ursulin wrote: On 07/10/2021 23:55, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to

Re: [PATCH -next v2] drm/connector: fix all kernel-doc warnings

2021-10-11 Thread Sam Ravnborg
Hi Randy, On Sun, Oct 10, 2021 at 03:44:59PM -0700, Randy Dunlap wrote: > Clean up all of the kernel-doc issues in drm_connector.c: > > drivers/gpu/drm/drm_connector.c:2611: warning: Excess function parameter > 'connector' description in 'drm_connector_oob_hotplug_event' >

[PATCH] drm/i915/selftests: Skip hangcheck selftest on DG1

2021-10-11 Thread Matthew Brost
The hangcheck selftest blows on DG1 CI and aborts the BAT run. Investigation is underway to root cause the failure but in the meantime disable to this test on DG1 to unblock CI. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 8 1 file changed, 8

[PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-11 Thread Nirmoy Das
Debugfs APIs returns encoded error on failure so use debugfs_lookup() instead of checking for NULL. CC: Lukas Wunner CC: David Airlie CC: Daniel Vetter CC: Maarten Lankhorst CC: Maxime Ripard CC: Thomas Zimmermann Signed-off-by: Nirmoy Das --- drivers/gpu/vga/vga_switcheroo.c | 2 +- 1

[PATCH 3/4] drm/i915/gt: do not check for NULL debugfs dentry

2021-10-11 Thread Nirmoy Das
Do not check for NULL value as drm.primary->debugfs_root will either contain a valid pointer or an encoded error instead of NULL. CC: Jani Nikula CC: Joonas Lahtinen CC: Rodrigo Vivi CC: David Airlie CC: Daniel Vetter Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/debugfs_gt.c | 3

[PATCH 2/4] drm/ttm: do not set NULL to debugfs dentry

2021-10-11 Thread Nirmoy Das
For debugfs directory, it is recommended to save the result and pass over to next debugfs API for creating debugfs files/directories. Error conditions are handled by debugfs APIs. CC: Christian Koenig CC: Huang Rui CC: David Airlie CC: Daniel Vetter Signed-off-by: Nirmoy Das ---

[PATCH 1/4] dri: do not check for NULL debugfs dentry

2021-10-11 Thread Nirmoy Das
Debugfs APIs returns encoded error on failure instead of NULL and for drm primary/minor debugfs directories, we save the returned value in the dentry pointer and pass it on to drm drivers to further create debugfs files/directories. Error conditions are handled by debugfs APIs, so no need to check

Re: Fw: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-11 Thread Jani Nikula
On Mon, 11 Oct 2021, Greg KH wrote: > On Mon, Oct 11, 2021 at 07:38:22PM +0300, Jani Nikula wrote: >> On Mon, 11 Oct 2021, Greg KH wrote: >> > On Mon, Oct 11, 2021 at 04:19:58PM +0200, Christian König wrote: >> >> > > > > And then throw it away, later, when you want to remove the >> >> > > > >

Re: [PATCH v4 1/7] dt-bindings: mediatek,dpintf: Add DP_INTF binding

2021-10-11 Thread Rob Herring
On Mon, Oct 11, 2021 at 8:43 AM Markus Schneider-Pargmann wrote: > > Hi, > > On Mon, Oct 11, 2021 at 08:36:18AM -0500, Rob Herring wrote: > > On Mon, 11 Oct 2021 11:46:18 +0200, Markus Schneider-Pargmann wrote: > > > DP_INTF is a similar functional block to mediatek,dpi but is different > > > in

Re: [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:04PM +0530, Thanneeru Srinivasulu wrote: > Replace DRM_ERROR with i915_probe_error to report early HuC failures. > > Signed-off-by: Thanneeru Srinivasulu Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: > Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. > > Signed-off-by: Thanneeru Srinivasulu Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 3/4] drm/i915/guc: Inject probe errors for MMIO send

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:05PM +0530, Thanneeru Srinivasulu wrote: > Injecting probe errors -ENXIO for MMIO send. > > Signed-off-by: Thanneeru Srinivasulu Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:06PM +0530, Thanneeru Srinivasulu wrote: > Inject probe errors -ENXIO, -EBUSY for CT send. > > Signed-off-by: Thanneeru Srinivasulu > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

[PATCH] drm/i915/selftests: Increase timeout in requests perf selftest

2021-10-11 Thread Matthew Brost
perf_parallel_engines is micro benchmark to test i915 request scheduling. The test creates a thread per physical engine and submits NOP requests and waits the requests to complete in a loop. In execlists mode this works perfectly fine as powerful CPU has enough cores to feed each engine and

Re: [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-11 Thread Bjorn Andersson
On Mon 11 Oct 08:24 PDT 2021, khs...@codeaurora.org wrote: > On 2021-10-08 09:44, Bjorn Andersson wrote: > > On Fri 08 Oct 09:07 PDT 2021, khs...@codeaurora.org wrote: > > > > > On 2021-10-07 15:34, Stephen Boyd wrote: > > > > Quoting khs...@codeaurora.org (2021-10-07 13:28:12) > > > > > On

RE: [PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

2021-10-11 Thread Tang, CQ
> -Original Message- > From: C, Ramalingam > Sent: Monday, October 11, 2021 9:12 AM > To: dri-devel ; intel-gfx g...@lists.freedesktop.org> > Cc: Daniel Vetter ; Auld, Matthew > ; Tang, CQ ; Hellstrom, > Thomas ; C, Ramalingam > ; Daniel Vetter > Subject: [PATCH 14/14]

Re: Fw: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-11 Thread Greg KH
On Mon, Oct 11, 2021 at 07:38:22PM +0300, Jani Nikula wrote: > On Mon, 11 Oct 2021, Greg KH wrote: > > On Mon, Oct 11, 2021 at 04:19:58PM +0200, Christian König wrote: > >> > > > > And then throw it away, later, when you want to remove the > >> > > > > directory, > >> > > > > look it up with a

Re: [PATCH] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-11 Thread Vlastimil Babka
On 10/7/21 13:01, Marco Elver wrote: > On Thu, Oct 07, 2021 at 11:58AM +0200, Vlastimil Babka wrote: > [...] >> - Add a CONFIG_STACKDEPOT_ALWAYS_INIT flag to keep using the current >> well-defined point of allocation as part of mem_init(). Make CONFIG_KASAN >> select this flag. >> - Other

Re: [PATCH v2] drm/r128: fix build for UML

2021-10-11 Thread Sam Ravnborg
On Mon, Oct 11, 2021 at 01:00:06AM -0700, Randy Dunlap wrote: > Fix a build error on CONFIG_UML, which does not support (provide) > wbinvd(). UML can use the generic mb() instead. > > ../drivers/gpu/drm/r128/ati_pcigart.c: In function ‘drm_ati_pcigart_init’: >

Re: [PATCH v3 0/5] mxsfb/nwl/panels: media bus format fixes

2021-10-11 Thread Sam Ravnborg
Hi Guido, On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido Günther wrote: > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if > present") added bus format probing to mxsfb this exposed several issues in the > display stack as used on the Librem 5: > > The nwl bridge and

Re: [PATCH 01/13] drm/panel: s6e63m0: Make s6e63m0_remove() return void

2021-10-11 Thread Sam Ravnborg
Hi Uwe, On Mon, Oct 11, 2021 at 03:27:42PM +0200, Uwe Kleine-König wrote: > Up to now s6e63m0_remove() returns zero unconditionally. Make it return > void instead which makes it easier to see in the callers that there is > no error to handle. > > Also the return value of spi remove callbacks is

Re: Fw: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-11 Thread Jani Nikula
On Mon, 11 Oct 2021, Greg KH wrote: > On Mon, Oct 11, 2021 at 04:19:58PM +0200, Christian König wrote: >> > > > > And then throw it away, later, when you want to remove the directory, >> > > > > look it up with a call to debugfs_lookup() and pass that to >> > > > > debugfs_remove() (which does so

Re: [PATCH v2] drm: of: Add drm_of_lvds_get_data_mapping

2021-10-11 Thread Marek Vasut
On 10/11/21 6:26 PM, Sam Ravnborg wrote: Hi Marek, On Mon, Oct 11, 2021 at 01:21:33PM +0200, Marek Vasut wrote: Add helper function to convert DT "data-mapping" property string value into media bus format value, and deduplicate the code in panel-lvds.c and lvds-codec.c . Signed-off-by: Marek

Re: [PATCH v2] drm: of: Add drm_of_lvds_get_data_mapping

2021-10-11 Thread Sam Ravnborg
Hi Marek, On Mon, Oct 11, 2021 at 01:21:33PM +0200, Marek Vasut wrote: > Add helper function to convert DT "data-mapping" property string value > into media bus format value, and deduplicate the code in panel-lvds.c > and lvds-codec.c . > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart >

Re: [PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-10-11 Thread Sam Ravnborg
Hi Oleksij, On Mon, Oct 11, 2021 at 11:01:48AM +0200, Oleksij Rempel wrote: > On Sat, Oct 09, 2021 at 05:12:44PM +0200, Sam Ravnborg wrote: > > Hi Oleksij, Robin, > > > > On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote: > > > Add compatible and timings for the Innolux G070Y2-T02

[PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

2021-10-11 Thread Ramalingam C
Details of the new features getting added as part of DG2 enabling and their implicit impact on the uAPI. Signed-off-by: Ramalingam C cc: Daniel Vetter cc: Matthew Auld --- Documentation/gpu/rfc/i915_dg2.rst | 47 ++ Documentation/gpu/rfc/index.rst| 3 ++ 2

[PATCH 11/14] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2021-10-11 Thread Ramalingam C
From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in “XEHPSDV_FLAT_CCS_BASE_ADDR”. So to get effective device memory we need to subtract total device memory by Flat CCS memory size.

[PATCH 13/14] drm/i915/uapi: document behaviour for DG2 64K support

2021-10-11 Thread Ramalingam C
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. Signed-off-by: Matthew Auld Signed-off-by: Ramalingam C ---

[PATCH 12/14] drm/i915/gt: Clear compress metadata for Gen12.5 >= platforms

2021-10-11 Thread Ramalingam C
From: Ayaz A Siddiqui Gen12.5+ devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W. Address

[PATCH 10/14] drm/i915/xehpsdv: Add has_flat_ccs to device info

2021-10-11 Thread Ramalingam C
From: CQ Tang Gen12+ devices support 3D surface (buffer) compression and various compression formats. This is accomplished by an additional compression control state (CCS) stored for each surface. Gen 12 devices(TGL family and DG1) stores compression states in a separate region of memory. It is

[PATCH 09/14] drm/i915/xehpsdv: implement memory coloring

2021-10-11 Thread Ramalingam C
From: Matthew Auld The basic idea is that each 2M block(page-table) has a color, depending on if the page-table is occupied by LMEM objects(64K) or SMEM objects(4K), where our goal is to prevent mixing 64K and 4K GTT pages in the page-table, which is not supported by the HW. Signed-off-by:

[PATCH 08/14] drm/i915/selftests: account for min_alignment in GTT selftests

2021-10-11 Thread Ramalingam C
From: Matthew Auld We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account. Signed-off-by: Matthew Auld Signed-off-by: Ramalingam C ---

[PATCH 07/14] drm/i915: Add vm min alignment support

2021-10-11 Thread Ramalingam C
From: Bommu Krishnaiah Replace the hard coded 4K alignment value with vm->min_alignment. Cc: Wilson Chris P Signed-off-by: Bommu Krishnaiah Signed-off-by: Ramalingam C --- .../i915/gem/selftests/i915_gem_client_blt.c | 23 --- drivers/gpu/drm/i915/gt/intel_gtt.c |

[PATCH 06/14] drm/i915/xehpsdv: support 64K GTT pages

2021-10-11 Thread Ramalingam C
From: Matthew Auld XEHPSDV optimises 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no longer

[PATCH 05/14] drm/i915/gtt/xehpsdv: move scratch page to system memory

2021-10-11 Thread Ramalingam C
From: Matthew Auld On some platforms the hw has dropped support for 4K GTT pages when dealing with LMEM, and due to the design of 64K GTT pages in the hw, we can only mark the *entire* page-table as operating in 64K GTT mode, since the enable bit is still on the pde, and not the pte. And since

[PATCH 04/14] drm/i915: enforce min page size for scratch

2021-10-11 Thread Ramalingam C
From: Matthew Auld If the device needs 64K minimum GTT pages for device local-memory, like on XEHPSDV, then we need to fail the allocation if we can't meet it, instead of falling back to 4K pages, otherwise we can't safely support the insertion of device local-memory pages for this vm, since the

[PATCH 03/14] drm/i915/xehpsdv: enforce min GTT alignment

2021-10-11 Thread Ramalingam C
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_vma.c | 9 +++--

[PATCH 02/14] drm/i915/xehpsdv: set min page-size to 64K

2021-10-11 Thread Ramalingam C
From: Matthew Auld LMEM should be allocated at 64K granularity, since 4K page support will eventually be dropped for LMEM when using the PPGTT. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahtinen Cc: Rodrigo Vivi ---

[PATCH 01/14] drm/i915: Add has_64k_pages flag

2021-10-11 Thread Ramalingam C
From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 2 ++

[PATCH 00/14] drm/i915/dg2: Enabling 64k page size and flat ccs

2021-10-11 Thread Ramalingam C
This series introduces the enabling patches for new flat ccs feature and 64k page support for i915 local memory, along with documentation on the uAPI impact. 64k page support On discrete platforms, starting from DG2, we have to contend with GTT page size restrictions when

Re: BUG: KASAN: use-after-free in enqueue_timer+0x4f/0x1e0

2021-10-11 Thread Kim Phillips
Hi, On 10/5/21 1:10 PM, Kim Phillips wrote: Hi, I occasionally see the below trace with Linus' master on an AMD Milan system: [   25.657322] BUG: kernel NULL pointer dereference, address: [   25.665097] #PF: supervisor instruction fetch in kernel mode [   25.671448] #PF:

[PATCH 0/4] drm/i915/guc: Inject probe errors for MMIO send, CT send

2021-10-11 Thread Thanneeru Srinivasulu
Injecting probe errors for MMIO send, CT send to make probe flow more robust. Use i915_probe_error to report probe injection errors. Thanneeru Srinivasulu (4): drm/i915/huc: Use i915_probe_error to report early CTB failures drm/i915/huc: Use i915_probe_error to report early HuC failures

[PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-11 Thread Thanneeru Srinivasulu
Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c

Re: [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-11 Thread khsieh
On 2021-10-08 09:44, Bjorn Andersson wrote: On Fri 08 Oct 09:07 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-07 15:34, Stephen Boyd wrote: > Quoting khs...@codeaurora.org (2021-10-07 13:28:12) > > On 2021-10-07 13:06, Bjorn Andersson wrote: > > > On Thu 07 Oct 12:51 PDT 2021,

[PATCH 3/4] drm/i915/guc: Inject probe errors for MMIO send

2021-10-11 Thread Thanneeru Srinivasulu
Injecting probe errors -ENXIO for MMIO send. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c index 8f8182bf7c11..490d66712afc

[PATCH 4/4] drm/i915/guc: Inject probe errors for CT send

2021-10-11 Thread Thanneeru Srinivasulu
Inject probe errors -ENXIO, -EBUSY for CT send. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index

[PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures

2021-10-11 Thread Thanneeru Srinivasulu
Replace DRM_ERROR with i915_probe_error to report early HuC failures. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c

Re: Fw: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-11 Thread Das, Nirmoy
On 10/11/2021 4:19 PM, Christian König wrote: Am 08.10.21 um 17:11 schrieb Greg KH: On Fri, Oct 08, 2021 at 04:22:06PM +0200, Christian König wrote: Hi guys, thanks Nirmoy for forwarding this, there is seriously something wrong with the AMD mail servers. On 10/8/2021 1:07 PM, Greg KH

[PATCH v8 8/8] drm/i915/ttm: enable shmem tt backend

2021-10-11 Thread Matthew Auld
Turn on the shmem tt backend, and enable shrinking. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c

[PATCH v8 7/8] drm/i915/ttm: use cached system pages when evicting lmem

2021-10-11 Thread Matthew Auld
This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström ---

[PATCH v8 6/8] drm/i915/ttm: move shrinker management into adjust_lru

2021-10-11 Thread Matthew Auld
We currently just evict lmem objects to system memory when under memory pressure. For this case we might lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets

[PATCH v8 5/8] drm/i915: add some kernel-doc for shrink_pin and friends

2021-10-11 Thread Matthew Auld
Attempt to document shrink_pin and the other relevant interfaces that interact with it, before we start messing with it. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 24 +-

[PATCH v8 2/8] drm/i915/ttm: add tt shmem backend

2021-10-11 Thread Matthew Auld
For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. v2(Thomas): - Add optional try_to_writeback hook for objects. Importantly we need

[PATCH v8 3/8] drm/i915/gtt: drop unneeded make_unshrinkable

2021-10-11 Thread Matthew Auld
We already do this when mapping the pages. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 - drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 1 - 2 files changed, 2 deletions(-) diff --git

[PATCH v8 1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-11 Thread Matthew Auld
From: Thomas Hellström Break out some shmem backend utils for future reuse by the TTM backend: shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects. Main functional change here is that we now

[PATCH v8 4/8] drm/i915: drop unneeded make_unshrinkable in free_object

2021-10-11 Thread Matthew Auld
The comment here is no longer accurate, since the current shrinker code requires a full ref before touching any objects. Also unset_pages() should already do the required make_unshrinkable() for us, if needed, which is also nicely balanced with set_pages(). Signed-off-by: Matthew Auld Cc: Thomas

Re: Fw: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-11 Thread Greg KH
On Mon, Oct 11, 2021 at 04:19:58PM +0200, Christian König wrote: > > > > > And then throw it away, later, when you want to remove the directory, > > > > > look it up with a call to debugfs_lookup() and pass that to > > > > > debugfs_remove() (which does so recursively). > > > > > > > > > > There

Re: [PATCH] video: fbdev: use memset_io() instead of memset()

2021-10-11 Thread Michael Ellerman
On Wed, 15 Sep 2021 15:34:35 +0200, Christophe Leroy wrote: > While investigating a lockup at startup on Powerbook 3400C, it was > identified that the fbdev driver generates alignment exception at > startup: > > --- interrupt: 600 at memset+0x60/0xc0 > NIP: c0021414 LR: c03fc49c CTR:

Re: Fw: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-11 Thread Christian König
Am 08.10.21 um 17:11 schrieb Greg KH: On Fri, Oct 08, 2021 at 04:22:06PM +0200, Christian König wrote: Hi guys, thanks Nirmoy for forwarding this, there is seriously something wrong with the AMD mail servers. On 10/8/2021 1:07 PM, Greg KH wrote: On Fri, Oct 08, 2021 at 12:40:47PM +0300,

Re: [Linaro-mm-sig] [PATCH] dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion

2021-10-11 Thread Christian König
Am 11.10.21 um 14:32 schrieb Tvrtko Ursulin: On 08/10/2021 13:19, Christian König wrote: Am 08.10.21 um 12:49 schrieb Tvrtko Ursulin: On 08/10/2021 11:21, Christian König wrote: Am 08.10.21 um 11:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Cache the count of shared fences in the

[PATCH 5.14 024/151] fbdev: simplefb: fix Kconfig dependencies

2021-10-11 Thread Greg Kroah-Hartman
From: Arnd Bergmann commit ec7cc3f74b4236860ce612656aa5be7936d1c594 upstream. Configurations with both CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM=m are allowed by Kconfig because the 'depends on !DRM_SIMPLEDRM' dependency does not disallow FB_SIMPLE as long as SIMPLEDRM is not built-in. This

Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding

2021-10-11 Thread Markus Schneider-Pargmann
Hi, On Mon, Oct 11, 2021 at 08:36:18AM -0500, Rob Herring wrote: > On Mon, 11 Oct 2021 11:46:19 +0200, Markus Schneider-Pargmann wrote: > > This controller is present on several mediatek hardware. Currently > > mt8195 and mt8395 have this controller without a functional difference, > > so only

Re: [PATCH v4 1/7] dt-bindings: mediatek,dpintf: Add DP_INTF binding

2021-10-11 Thread Markus Schneider-Pargmann
Hi, On Mon, Oct 11, 2021 at 08:36:18AM -0500, Rob Herring wrote: > On Mon, 11 Oct 2021 11:46:18 +0200, Markus Schneider-Pargmann wrote: > > DP_INTF is a similar functional block to mediatek,dpi but is different > > in that it serves the DisplayPort controller on mediatek SoCs and uses > >

[PATCH v3 5/5] drm: mxsfb: Set fallback bus format when the bridge doesn't provide one

2021-10-11 Thread Guido Günther
If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in that case. This unbreaks e.g. using mxsfb with the nwl bridge and mipi dsi panels. Reported-by: Martin Kepplinger Signed-off-by: Guido Günther

[PATCH v3 4/5] drm: mxsfb: Print failed bus format in hex

2021-10-11 Thread Guido Günther
media-bus-formats.h has them in hexadecimal as well so matching with that file saves one conversion when debugging. Signed-off-by: Guido Günther Reviewed-by: Lucas Stach Reviewed-by: Robert Foss --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 2/5] drm/panel: mantix: Add media bus format

2021-10-11 Thread Guido Günther
This allows the DSI bridge to detect the correct bus format. We currently only support MEDIA_BUS_FMT_RGB888_1X24. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 9 + 1 file changed, 9 insertions(+) diff --git

  1   2   >