[PATCH v2] drm/msm/dp: remove fail safe mode related code

2022-04-25 Thread Kuogee Hsieh
Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow stack trace) after edp driver call dp_hpd_plug_handle() from dp_bridge_enable() which is

[linux-next:master] BUILD REGRESSION e7d6987e09a328d4a949701db40ef63fbb970670

2022-04-25 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e7d6987e09a328d4a949701db40ef63fbb970670 Add linux-next specific files for 20220422 Error/Warning reports: https://lore.kernel.org/linux-mm/202204081656.6x4pfen4-...@intel.com

RE: [PATCH v1 2/2] drm/aspeed: Add 1024x768 mode for AST2600

2022-04-25 Thread Tommy Huang
Hi Joel, > -Original Message- > From: Joel Stanley > Sent: Tuesday, April 26, 2022 11:27 AM > To: Tommy Huang > Cc: David Airlie ; Daniel Vetter ; Rob > Herring ; Andrew Jeffery ; > linux-aspeed ; open list:DRM DRIVERS > ; devicetree ; > Linux ARM ; Linux Kernel Mailing List > ; BMC-SW

Re: [PATCH 0/2] drm/nvdla: Add driver support for NVDLA

2022-04-25 Thread Peter Robinson
On Tue, Apr 19, 2022 at 3:08 PM Cai Huoqing wrote: > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > which is integrated into NVIDIA Jetson AGX Xavier, > so add driver support for this accelerator. > > NVDLA introduce: > http://nvdla.org/primer.html > > User mode driver: >

RE: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-25 Thread Sankeerth Billakanti (QUIC)
Hi Stephen, >> >> int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c >> >> b/drivers/gpu/drm/msm/dp/dp_display.c >> >> index 055681a..dea4de9 100644 >> >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> >> +++

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-25 Thread Abhinav Kumar
On 4/25/2022 7:18 PM, Doug Anderson wrote: Hi, On Mon, Apr 25, 2022 at 6:42 PM Abhinav Kumar wrote: 2) When there was a valid EDID but no 640x480 mode This is the equipment specific case and the one even I was a bit surprised. There is a DP compliance equipment we have in-house and

Re: [PATCH v1 2/2] drm/aspeed: Add 1024x768 mode for AST2600

2022-04-25 Thread Joel Stanley
On Fri, 4 Mar 2022 at 06:32, Tommy Haung wrote: > > Update the aspeed_gfx_set_clk with display width. > At AST2600, the display clock could be coming from > HPLL clock / 16 = 75MHz. It would fit 1024x768@70Hz. > Another chip will still keep 800x600. > > Signed-off-by: Tommy Haung > --- >

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-25 Thread Doug Anderson
Hi, On Mon, Apr 25, 2022 at 6:42 PM Abhinav Kumar wrote: > > >> 2) When there was a valid EDID but no 640x480 mode > >> > >> This is the equipment specific case and the one even I was a bit > >> surprised. There is a DP compliance equipment we have in-house and while > >> validation, it was

Re: [PATCH v5 15/19] drm/msm/dpu: initialize dpu encoder and connector for writeback

2022-04-25 Thread Dmitry Baryshkov
On 26/04/2022 03:32, Laurent Pinchart wrote: Hi Abhinav, On Sun, Apr 24, 2022 at 05:32:06PM -0700, Abhinav Kumar wrote: Initialize dpu encoder and connector for writeback if the target supports it in the catalog. changes in v2: - start initialing the encoder for writeback since we

linux-next: build failure after merge of the drm-intel tree

2022-04-25 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: modpost: "intel_runtime_pm_put" [drivers/gpu/drm/i915/kvmgt.ko] undefined! Possibly caused by commit 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko") or one of

RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Sankeerth Billakanti (QUIC)
Hi Stephen, Quoting Sankeerth Billakanti (2022-04-22 02:11:03) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index d7a19d6..055681a 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-25 Thread Igor Torrente
Hi Pekka, On 4/25/22 05:10, Pekka Paalanen wrote: On Sat, 23 Apr 2022 15:53:20 -0300 Igor Torrente wrote: I forgot to respond some points from your review. On 4/23/22 13:04, Igor Torrente wrote: Hi Pekka, On 4/20/22 09:36, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:12 -0300 Igor

Re: linux-next: manual merge of the drm-misc tree with the drm-misc-fixes tree

2022-04-25 Thread Stephen Rothwell
Hi all, On Thu, 14 Apr 2022 09:47:15 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/radeon/radeon_sync.c > > between commit: > > 022074918042 ("drm/radeon: fix logic inversion in radeon_sync_resv") > > from the

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-25 Thread Abhinav Kumar
Hi Doug On 4/25/2022 5:26 PM, Doug Anderson wrote: Hi, On Sat, Apr 23, 2022 at 8:34 AM Abhinav Kumar wrote: On 4/22/2022 11:25 PM, Dmitry Baryshkov wrote: On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar wrote: On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote: On 23/04/2022 02:45, Kuogee

[PATCH] drm/bridge: tc358762: drop connector field

2022-04-25 Thread Dmitry Baryshkov
The tc358762.connector field is unused. Remove it to save space. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/tc358762.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index 7104828024fd..5416e8bbf827

Re: [PATCH v5 5/9] drm: vkms: Add fb information to `vkms_writeback_job`

2022-04-25 Thread Igor Torrente
Hi Pekka, On 4/25/22 04:56, Pekka Paalanen wrote: On Sat, 23 Apr 2022 12:12:51 -0300 Igor Torrente wrote: Hi Pekka, On 4/20/22 08:23, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:11 -0300 Igor Torrente wrote: This commit is the groundwork to introduce new formats to the planes and

Re: [PATCH v3 1/2] dt-bindings: display: bridge: ldb: Implement simple NXP i.MX8MP LDB bridge

2022-04-25 Thread Rob Herring
On Sat, Apr 23, 2022 at 04:16:24AM +0200, Marek Vasut wrote: > The i.MX8MP contains two syscon registers which are responsible > for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding > which represents this serializer as a bridge. > > Acked-by: Sam Ravnborg > Signed-off-by: Marek

Re: [PATCH v5 10/19] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-25 Thread Dmitry Baryshkov
On 26/04/2022 03:44, Abhinav Kumar wrote: Hi Dmitry On 4/25/2022 5:21 PM, Dmitry Baryshkov wrote: On 25/04/2022 03:32, Abhinav Kumar wrote: Make changes to dpu_encoder to support virtual encoder needed to support writeback for dpu. changes in v4: - squash dpu_encoder pieces from [1] [1]

Re: [PATCH v5 10/19] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-25 Thread Abhinav Kumar
Hi Dmitry On 4/25/2022 5:21 PM, Dmitry Baryshkov wrote: On 25/04/2022 03:32, Abhinav Kumar wrote: Make changes to dpu_encoder to support virtual encoder needed to support writeback for dpu. changes in v4: - squash dpu_encoder pieces from [1] [1]

Re: [PATCH v5 15/19] drm/msm/dpu: initialize dpu encoder and connector for writeback

2022-04-25 Thread Abhinav Kumar
Hi Laurent On 4/25/2022 5:32 PM, Laurent Pinchart wrote: Hi Abhinav, On Sun, Apr 24, 2022 at 05:32:06PM -0700, Abhinav Kumar wrote: Initialize dpu encoder and connector for writeback if the target supports it in the catalog. changes in v2: - start initialing the encoder for writeback

[PATCH v1] drm/msm: select DRM_DP_AUX_BUS for the AUX bus support

2022-04-25 Thread Dmitry Baryshkov
Add missing dependency on the AUX bus implementation. Fixes: 82c59ed16695 ("drm/msm/dp: Add eDP support via aux_bus") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig

Re: [PATCH v5 15/19] drm/msm/dpu: initialize dpu encoder and connector for writeback

2022-04-25 Thread Laurent Pinchart
Hi Abhinav, On Sun, Apr 24, 2022 at 05:32:06PM -0700, Abhinav Kumar wrote: > Initialize dpu encoder and connector for writeback if the > target supports it in the catalog. > > changes in v2: > - start initialing the encoder for writeback since we > have migrated to using

Re: [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-25 Thread Doug Anderson
Hi, On Sat, Apr 23, 2022 at 8:34 AM Abhinav Kumar wrote: > > On 4/22/2022 11:25 PM, Dmitry Baryshkov wrote: > > On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote: > >>> On 23/04/2022 02:45, Kuogee Hsieh wrote: > Current

Re: [PATCH v5 10/19] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-25 Thread Dmitry Baryshkov
On 25/04/2022 03:32, Abhinav Kumar wrote: Make changes to dpu_encoder to support virtual encoder needed to support writeback for dpu. changes in v4: - squash dpu_encoder pieces from [1] [1] https://patchwork.freedesktop.org/patch/483099/?series=102964=2 Signed-off-by: Abhinav Kumar

Re: [PATCH v5 14/19] drm/msm/dpu: add the writeback connector layer

2022-04-25 Thread Dmitry Baryshkov
On 25/04/2022 03:32, Abhinav Kumar wrote: Introduce the dpu_writeback module which serves as the interface between dpu operations and the drm_writeback. This module manages the connector related operations for dpu writeback. changes in v2: - start using

Re: [PATCH v4 11/20] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-25 Thread Dmitry Baryshkov
On 23/04/2022 02:06, Abhinav Kumar wrote: Make changes to dpu_encoder to support virtual encoder needed to support writeback for dpu. changes in v4: - squash dpu_encoder pieces from [1] [1] https://patchwork.freedesktop.org/patch/483099/?series=102964=2 Signed-off-by: Abhinav Kumar

[PATCH v2 1/2] drm/msm/dp: reset DP controller before transmit phy test pattern

2022-04-25 Thread Kuogee Hsieh
DP controller state can not switch from video ready state to transmit phy pattern state at run time. DP mainlink has to be teared down followed by reset controller to default state to have DP controller switch to transmit phy test pattern state and start generate specified phy test pattern to

[PATCH v2 2/2] drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

2022-04-25 Thread Kuogee Hsieh
At normal operation, transmit phy test pattern has to be terminated before DP controller switch to video ready state. However during phy compliance testing, transmit phy test pattern should not be terminated until end of compliance test which usually indicated by unplugged interrupt. Only stop

[PATCH v2 0/2] fix DP phy compliance test

2022-04-25 Thread Kuogee Hsieh
Current DP phy compliance test failed due to test pattern generation was terminated premature. Kuogee Hsieh (2): drm/msm/dp: reset DP controller before transmit phy test pattern drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

Re: [PATCH] drm/msm/disp/dpu1: set vbif hw config to NULL to avoid use after memory free during pm runtime resume

2022-04-25 Thread Dmitry Baryshkov
On 25/04/2022 06:26, Vinod Polimera wrote: BUG: Unable to handle kernel paging request at virtual address 006b6b6b6b6b6be3 Call trace: dpu_vbif_init_memtypes+0x40/0xb8 dpu_runtime_resume+0xcc/0x1c0 pm_generic_runtime_resume+0x30/0x44 __genpd_runtime_resume+0x68/0x7c

Re: [PATCH v1 2/2] drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

2022-04-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-25 15:11:03) > At normal operation, transmit phy test pattern has to be terminated before > DP controller switch to video ready state. However during phy compliance > testing, transmit phy test pattern should not be terminated until end of > compliance test which

Re: [PATCH v1 1/2] drm/msm/dp: reset DP controller before transmit phy test pattern

2022-04-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-25 15:11:02) > DP controller state can not switch from video ready state to > transmit phy pattern state at run time. DP mainlink has to be > teared down followed by reset controller to default state to have > DP controller switch to transmit phy test pattern state

Re: [PATCH] drm/msm/dp: tear down main link at unplug handle immediately

2022-04-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-25 15:29:30) > > On 4/20/2022 3:38 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-04-14 14:03:43) > > > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index 01453db..f5bd8f5 100644 > >> ---

Re: [PATCH v2] drm/msm/dp: add fail safe mode outside of event_mutex context

2022-04-25 Thread Dmitry Baryshkov
On 09/04/2022 00:04, Kuogee Hsieh wrote: There is possible circular locking dependency detected on event_mutex (see below logs). This is due to set fail safe mode is done at dp_panel_read_sink_caps() within event_mutex scope. To break this possible circular locking, this patch move setting fail

Re: [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-25 Thread Dmitry Baryshkov
On 23/04/2022 18:33, Abhinav Kumar wrote: On 4/22/2022 11:25 PM, Dmitry Baryshkov wrote: On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar wrote: On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote: On 23/04/2022 02:45, Kuogee Hsieh wrote: Current DP driver implementation has adding safe mode done

[PATCH v2] drm/msm/dp: tear down main link at unplug handle immediately

2022-04-25 Thread Kuogee Hsieh
Two stages are required to setup up main link to be ready to transmit video stream. Stage 1: dp_hpd_plug_handle() perform link training to set up main link stage 2: user space framework (msm_dp_display_enable()) to enable pixel clock and transfer main link to video ready state. At current

Re: [PATCH] drm/msm/dp: tear down main link at unplug handle immediately

2022-04-25 Thread Kuogee Hsieh
On 4/20/2022 3:38 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-04-14 14:03:43) Two stages are required to setup up main link to be ready to transmit video stream. Stage 1: dp_hpd_plug_handle() perform link training to set up main link stage 2: user space framework

Re: [PATCH v2] drm/msm/dp: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Dmitry Baryshkov
On 24/04/2022 06:24, cgel@gmail.com wrote: From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi

Re: [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Dmitry Baryshkov
On 24/04/2022 06:19, cgel@gmail.com wrote: From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov --- v2: don't print irq, and return

Re: [PATCH] drm/msm: change msm_sched_ops from global to static

2022-04-25 Thread Dmitry Baryshkov
On 21/04/2022 16:15, Tom Rix wrote: Smatch reports this issue msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static? msm_sched_ops is only used in msm_ringbuffer.c so change its storage-class specifier to static. Signed-off-by: Tom Rix Reviewed-by:

[PATCH v1 2/2] drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

2022-04-25 Thread Kuogee Hsieh
At normal operation, transmit phy test pattern has to be terminated before DP controller switch to video ready state. However during phy compliance testing, transmit phy test pattern should not be terminated until end of compliance test which usually indicated by unplugged interrupt. Fixes:

[PATCH v1 1/2] drm/msm/dp: reset DP controller before transmit phy test pattern

2022-04-25 Thread Kuogee Hsieh
DP controller state can not switch from video ready state to transmit phy pattern state at run time. DP mainlink has to be teared down followed by reset controller to default state to have DP controller switch to transmit phy test pattern state and start generate specified phy test pattern to

[PATCH v1 0/2] fix DP phy compliance test

2022-04-25 Thread Kuogee Hsieh
Current DP phy compliance test failed due to test pattern generation was terminated premature. Kuogee Hsieh (2): drm/msm/dp: reset DP controller before transmit phy test pattern drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

Re: [PATCH v4 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-04-25 Thread Dmitry Baryshkov
On 21/04/2022 07:15, Bjorn Andersson wrote: It's typical for the bootloader to bring up the display for showing a boot splash or efi framebuffer. But in some cases the kernel driver ends up only partially configuring (in particular) the DPU, which might result in e.g. that two different data

Re: [PATCH] drm/amd/display: fix if == else warning

2022-04-25 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Apr 24, 2022 at 4:15 PM Liu, Zhan wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Guo Zhengkui > > Sent: 2022/April/24, Sunday 5:06 AM > > To: Wentland, Harry ; Li, Sun peng (Leo) > > ; Siqueira, Rodrigo ; > > Deucher,

Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

2022-04-25 Thread Doug Anderson
Hi, On Mon, Apr 25, 2022 at 2:14 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2022-04-25 14:06:42) > > We're supposed to list the supplies in the dt bindings but there are > > none in the DP controller bindings. Looking at the Linux driver and > > existing device trees, we can see that

Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

2022-04-25 Thread Stephen Boyd
Quoting Douglas Anderson (2022-04-25 14:06:42) > We're supposed to list the supplies in the dt bindings but there are > none in the DP controller bindings. Looking at the Linux driver and > existing device trees, we can see that two supplies are expected: > - vdda-0p9-supply > - vdda-1p2-supply >

[PATCH v2 3/3] topic/core-for-CI: Add remaining DG2 and ATS-M device IDs

2022-04-25 Thread Matt Roper
The device IDs here are associated with DG2 add-in cards. We need to wait for some additional functionality (e.g., small BAR recovery) to land before we're ready to truly upstream these via drm-intel; for now we'll just add them to the core-for-CI branch for CI coverage. Cc: Lucas De Marchi

[PATCH v2 0/3] i915: Upstream initial DG2 PCI IDs

2022-04-25 Thread Matt Roper
We've had all of our DG2 and ATS-M PCI IDs in the topic/core-for-CI branch for a while, but we've now got the critical uapi changes in place to unblock upstreaming the initial subset (which correspond to "motherboard down" designs) through the drm-intel tree. The remaining IDs (which correspond

[PATCH v2 2/3] drm/i915: Add first set of DG2 PCI IDs

2022-04-25 Thread Matt Roper
The IDs added here are the subset reserved for 'motherboard down' designs of DG2. We have all the necessary support upstream to enable these now (although they'll continue to require force_probe until the usual requirements are met). The remaining DG2 IDs for add-in cards will come in a future

[PATCH v2 1/3] topic/core-for-CI: Revert DG2 and ATS-M device IDs

2022-04-25 Thread Matt Roper
Some of the IDs here are ready to formally upstream via drm-intel. We'll rebase these out of the topic/core-for-CI branch (but they're sent here as a revert to avoid confusing CI). - 92b805135ed2 ("drm/i915: Add DG2 PCI IDs") - bca8f652e1a0 ("topic/core-for-CI: Add ATS-M PCI IDs") Cc: Lucas De

Re: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Dmitry Baryshkov
On 25/04/2022 23:26, Stephen Boyd wrote: Quoting Sankeerth Billakanti (QUIC) (2022-04-25 02:39:43) Hi Stephen, Quoting Sankeerth Billakanti (2022-04-22 02:11:03) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index d7a19d6..055681a 100644 ---

Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Dmitry Baryshkov
On 25/04/2022 23:11, Stephen Boyd wrote: Quoting cgel@gmail.com (2022-04-25 02:18:31) From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return a negative value anyhow, so never enter this conditional branch. Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use

Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Dmitry Baryshkov
On 25/04/2022 23:10, Stephen Boyd wrote: Quoting cgel@gmail.com (2022-04-25 02:09:47) From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return a negative value anyhow, so never enter this conditional branch. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU

[PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

2022-04-25 Thread Douglas Anderson
We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected: - vdda-0p9-supply - vdda-1p2-supply Let's list them both in the bindings. Note that the

[PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy

2022-04-25 Thread Douglas Anderson
We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings. Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. NOTE: from looking at the Qualcomm datasheet for

[PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP

2022-04-25 Thread Douglas Anderson
While looking through dts changes for sc7280 eDP I found that none of the regulators that were being defined were listed in the bindings. That being said, the current Linux drivers _were_ looking for regulators. This series tries to document the reality to the best of my ability. If someone from

[PATCH 2/2] drm: Remove the drm_get_unmapped_area() helper

2022-04-25 Thread Zack Rusin
From: Zack Rusin This has been only used by the vmwgfx driver and vmwgfx over the last year removed support for transparent hugepages on vram leaving drm_get_unmapped_area completely unused. There's no point in keeping unused code in core drm. Signed-off-by: Zack Rusin Cc: Thomas Hellström

[PATCH 1/2] drm/vmwgfx: Remove unused hugepage support

2022-04-25 Thread Zack Rusin
From: Zack Rusin There's no point in explicitly trying to align virtual memory to facilitate huge page table entries or huge page memory in buffer objects given that they're not being used. Transparent hugepages support for vram allocations has been gradually retired over the last two years

RE: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-04-24 19:55:29) > >Quoting Sankeerth Billakanti (2022-04-22 02:11:04) > > > >> int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) diff > >> --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index

RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-04-25 02:39:43) > Hi Stephen, > > >Quoting Sankeerth Billakanti (2022-04-22 02:11:03) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index d7a19d6..055681a 100644 > >> ---

Re: [PATCH] drm/msm: fix returnvar.cocci warning

2022-04-25 Thread Stephen Boyd
Quoting Guo Zhengkui (2022-04-25 05:22:21) > Fix the following coccicheck warning: > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: > "ret". Return "0" on line 75. > > Signed-off-by: Guo Zhengkui > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Stephen Boyd
Quoting cgel@gmail.com (2022-04-25 02:18:31) > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return a negative value anyhow, so never enter this conditional branch. > > Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains") > Reported-by: Zeal Robot

Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Stephen Boyd
Quoting cgel@gmail.com (2022-04-25 02:09:47) > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return a negative value anyhow, so never enter this conditional branch. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Reported-by: Zeal

Re: [PATCH v2 1/3] drm/msm/dpu: index dpu_kms->hw_vbif using vbif_idx

2022-04-25 Thread Abhinav Kumar
+ Vinod Hi Dmitry Can we also absorb https://patchwork.freedesktop.org/patch/483255/ into this change? Looks like they are touching the same code and can be absorbed easily. Thanks Abhinav On 4/19/2022 9:20 AM, Dmitry Baryshkov wrote: Remove loops over hw_vbif. Instead always VBIF's idx

[PATCH] drm/ssd130x: Make ssd130x_remove() return void

2022-04-25 Thread Uwe Kleine-König
This function returns zero unconditionally, so there isn't any benefit of returning a value. Make it return void to be able to see at a glance that the return value of ssd130x_i2c_remove() is always zero. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe

Re: [PATCH 04/11] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-04-25 Thread Randy Dunlap
On 4/5/22 08:15, Borislav Petkov wrote: > From: Borislav Petkov > > Fix: > > drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: > drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to > an integer constant > case R128_PM4_64BM_64VCBM_64INDBM: >

RE: [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Yang, Fei
>> > --- a/drivers/gpu/drm/i915/gt/intel_gt.c >> > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c >> > @@ -1175,6 +1175,7 @@ void intel_gt_invalidate_tlbs(struct intel_gt *gt) >> >[VIDEO_DECODE_CLASS]= GEN12_VD_TLB_INV_CR, >> >[VIDEO_ENHANCEMENT_CLASS] =

Re: [PATCH v2 3/3] fbdev: Refactor implementation of page_mkwrite

2022-04-25 Thread Sam Ravnborg
Hi Thomas. On Mon, Apr 25, 2022 at 01:27:51PM +0200, Thomas Zimmermann wrote: > Refactor the page-write handler for deferred I/O. Drivers use the > function to let fbdev track written pages of mmap'ed framebuffer > memory. I like how the comments got a brush up and a little more info was added.

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Laurent Pinchart
On Mon, Apr 25, 2022 at 10:48:07AM -0700, Abhinav Kumar wrote: > On 4/25/2022 10:32 AM, Laurent Pinchart wrote: > > On Mon, Apr 25, 2022 at 01:50:43PM +0300, Dmitry Baryshkov wrote: > >> On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: > >>> On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav

Re: [PATCH v2 2/3] fbdev: Track deferred-I/O pages in pageref struct

2022-04-25 Thread Sam Ravnborg
Hi Thomas, a little ramblings below. Just my thoughts while trying to understand the code - especially since I looked at it before. Sam On Mon, Apr 25, 2022 at 01:27:50PM +0200, Thomas Zimmermann wrote: > Store the per-page state for fbdev's deferred I/O in struct >

Re: [PATCH] video: clps711x-fb: Use syscon_regmap_lookup_by_phandle

2022-04-25 Thread Helge Deller
On 4/20/22 09:06, Alexander Shiyan wrote: > Since version 5.13, the standard syscon bindings have been added > to all clps711x DT nodes, so we can now use the more general > syscon_regmap_lookup_by_phandle function to get the syscon pointer. > > Signed-off-by: Alexander Shiyan applied. Thanks,

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Abhinav Kumar
Hi Laurent On 4/25/2022 10:32 AM, Laurent Pinchart wrote: On Mon, Apr 25, 2022 at 01:50:43PM +0300, Dmitry Baryshkov wrote: On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: On 4/24/2022 11:12 AM, Abhinav Kumar wrote: On

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread Sam Ravnborg
Hi Thomas, On Mon, Apr 25, 2022 at 07:26:32PM +0200, Sam Ravnborg wrote: > Hi Thomas, > > > diff --git a/drivers/video/fbdev/core/fb_defio.c > > b/drivers/video/fbdev/core/fb_defio.c > > index 6aaf6d0abf39..6924d489a289 100644 > > --- a/drivers/video/fbdev/core/fb_defio.c > > +++

Re: [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Matt Roper
On Mon, Apr 25, 2022 at 11:41:36AM +0100, Tvrtko Ursulin wrote: > > On 22/04/2022 20:50, Matt Roper wrote: > > We're now ready to start exposing compute engines to userspace. > > > > While we're at it, let's extend the kerneldoc description for the other > > engine types as well. > > > > Cc:

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Laurent Pinchart
On Mon, Apr 25, 2022 at 01:50:43PM +0300, Dmitry Baryshkov wrote: > On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: > > On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: > > > On 4/24/2022 11:12 AM, Abhinav Kumar wrote: > > > > On 4/24/2022 7:50 AM, Laurent Pinchart wrote: > > >

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread Sam Ravnborg
Hi Thomas, > diff --git a/drivers/video/fbdev/core/fb_defio.c > b/drivers/video/fbdev/core/fb_defio.c > index 6aaf6d0abf39..6924d489a289 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -181,6 +181,7 @@ int fb_deferred_io_mmap(struct fb_info

Re: Screen corruption using radeon kernel driver

2022-04-25 Thread Alex Deucher
+ dri-devel On Mon, Apr 25, 2022 at 3:33 AM Krylov Michael wrote: > > Hello! > > After updating my Linux kernel from version 4.19 (Debian 10 version) to > 5.10 (packaged with Debian 11), I've noticed that the image > displayed on my older computer, 32-bit Pentium 4 using ATI Radeon X1950 > AGP

Re: [PATCH] drm/radeon: change cac_weights_* to static

2022-04-25 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Apr 23, 2022 at 4:02 PM Tom Rix wrote: > > Sparse reports these issues > si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. > Should it be static? > si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. > Should it be

Re: [PATCH] drm/radeon: change cik_default_state table from global to static

2022-04-25 Thread Alex Deucher
On Sat, Apr 23, 2022 at 9:44 AM Tom Rix wrote: > > Sparse reports these issues > cik_blit_shaders.c:31:11: warning: symbol 'cik_default_state' was not > declared. Should it be static? > cik_blit_shaders.c:246:11: warning: symbol 'cik_default_size' was not > declared. Should it be static? > >

Re: [PATCH] drm/amd/display: fix non-kernel-doc comment warnings

2022-04-25 Thread Alex Deucher
On Fri, Apr 22, 2022 at 9:29 PM Randy Dunlap wrote: > > Fix kernel-doc warnings for a comment that should not use > kernel-doc notation: > > dmub_psr.c:235: warning: This comment starts with '/**', but isn't a > kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Set PSR power

Re: [PATCH 5/5] dt-bindings: mediatek: add ethdr definition for mt8195

2022-04-25 Thread Rob Herring
On Tue, Apr 19, 2022 at 11:32:37AM +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,ethdr.yaml | 158

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Abhinav Kumar
On 4/25/2022 3:50 AM, Dmitry Baryshkov wrote: On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: Hi Abhinav, On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: On 4/24/2022 11:12 AM, Abhinav Kumar wrote: On 4/24/2022 7:50 AM, Laurent Pinchart wrote: On Fri, Apr 22, 2022

[PATCH v2 4/4] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-04-25 Thread Ramalingam C
Capture the impact of memory region preference list of an object, on their memory residency and Flat-CCS capability of the objects. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] Signed-off-by: Ramalingam C cc: Matthew Auld cc: Thomas Hellstrom ---

[PATCH v2 2/4] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-04-25 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 36 + 1 file changed, 12 insertions(+), 24

[PATCH v2 3/4] drm/i915/gt: Document the eviction of the Flat-CCS objects

2022-04-25 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable, lmem objects. v2: Fix the Flat-ccs capbility of lmem obj with smem residency possibility [Thomas] Signed-off-by: Ramalingam C cc: Thomas Hellstrom cc: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++-

[PATCH v2 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-25 Thread Ramalingam C
While locating the start of ccs scatterlist in smem scatterlist, that has to be the size of lmem obj size + corresponding ccs data size. Report bug if scatterlist terminate before that length. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++ 1 file changed, 6

[PATCH v2 0/4] Flat-CCS eviction enhancements

2022-04-25 Thread Ramalingam C
Flat-CCS eviction enhancements v2: Correcting the memory residency requirement for flat-ccs capability [Thomas] Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Document the eviction of

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/fbdev-Decouple-deferred-I-O-from-struct-page/20220425-192955 base

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-25 Thread Andrey Grodzovsky
On 2022-04-25 04:36, Hangyu Hua wrote: When drm_sched_job_add_dependency() fails, dma_fence_put() will be called internally. Calling it again after drm_sched_job_add_dependency() finishes may result in a dangling pointer. Fix this by removing redundant dma_fence_put(). Signed-off-by: Hangyu

Re: [PATCH v17 11/21] drm/mediatek: add display merge start/stop API for cmdq support

2022-04-25 Thread Matthias Brugger
On 25/04/2022 15:32, Chun-Kuang Hu wrote: Hi, Matthias: Matthias Brugger 於 2022年4月22日 週五 下午7:48寫道: On 16/04/2022 04:07, Nancy.Lin wrote: Add merge start/stop API for cmdq support. The ovl_adaptor merges are configured with each drm plane update. Need to enable/disable merge with cmdq

[PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-04-25 Thread Ramalingam C
From: Chris Wilson Userspace may leave predication enabled upon return from the batch buffer, which has the consequent of preventing all operation from the ring from being executed, including all the synchronisation, coherency control, arbitration and user signaling. This is more than just a

[PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

2022-04-25 Thread Ramalingam C
From: Chris Wilson When predication is enabled all commands baring a few (such as MI_BB_END) are nop'ed. If we accidentally enable predication while poisoning the context, not only is the rest of the poisoning skipped (thus disabling the test), but the closing instructions of the poison request

[PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-04-25 Thread Ramalingam C
From: Akeem G Abodunrin When bit 19 of MI_LOAD_REGISTER_IMM instruction opcode is set on tgl+ devices, HW does not care about certain register address offsets, but instead check the following for valid address ranges on specific engines: RCS && CCS: BITS(0 - 10) BCS: BITS(0 - 11)

[PATCH 0/3] Handle predicate programming

2022-04-25 Thread Ramalingam C
Userspace can leave SET_PREDICATE_RESULT active at the end of their batch, causing all the kernel operations from the ring to be noop'ed. This includes workarounds for memory corruption on dg2, as well as the usual synchronisation, arbitration, coherency and signaling. The latter can be used to

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Daniel Stone
Hi Piotr, On Fri, 15 Apr 2022 at 12:11, Piotr Oniszczuk wrote: > Looking on Qt sources it looks to me this format should be supported: > > https://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/kmsconvenience/qkmsdevice.cpp?h=5.15.2#n380 > > Interesting that with custom Qt config1:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Xe_HP SDV and DG2 have up to 4 CCS engines

2022-04-25 Thread Andi Shyti
On Fri, Apr 22, 2022 at 12:50:07PM -0700, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > Cc: Vinay Belgaumkar > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matt Roper > Reviewed-by: Matt Roper Reviewed-by: Andi Shyti Andi

Re: [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Daniel Stone
On Fri, 22 Apr 2022 at 08:30, Sascha Hauer wrote: > It's v11 time. There's only one small change to v10. Discussion seems to > have settled now. Is there anything left that prevents the series from > being merged? I'd really like to have it in during the next merge > window. I don't believe

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Andi Shyti
Hi Matt, On Fri, Apr 22, 2022 at 12:50:06PM -0700, Matt Roper wrote: > We're now ready to start exposing compute engines to userspace. > > While we're at it, let's extend the kerneldoc description for the other > engine types as well. I would make two different patches. The kerneldoc

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-25 Thread Cai Huoqing
On 22 4月 22 01:01:14, Kari Argillander wrote: > This is just quick look up. I basically check some style issues and did > some basic static analyzing. > > I have run > - cppcheck (which found couple mistakes) > - flawfinder (did not found anything to my eyes) > - codespell (did find couple

  1   2   >