RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-26 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, I will check this issue. Regards, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, April 26, 2022 10:06 PM To: Mike Lothian ; Paneer Selvam, Arunpravin Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;

Re: [PATCH 1/2] drm/vmwgfx: Remove unused hugepage support

2022-04-26 Thread Intel
On 4/25/22 22:31, Zack Rusin wrote: From: Zack Rusin There's no point in explicitly trying to align virtual memory to facilitate huge page table entries or huge page memory in buffer objects given that they're not being used. Transparent hugepages support for vram allocations has been

[Bug 215892] 6500XT [drm:amdgpu_dm_init.isra.0.cold [amdgpu]] *ERROR* Failed to register vline0 irq 30!

2022-04-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215892 --- Comment #4 from Mark Johnston (ula...@gmail.com) --- Created attachment 300815 --> https://bugzilla.kernel.org/attachment.cgi?id=300815=edit acpidump summary -- You may reply to this email to add a comment. You are receiving this mail

[Bug 215892] 6500XT [drm:amdgpu_dm_init.isra.0.cold [amdgpu]] *ERROR* Failed to register vline0 irq 30!

2022-04-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215892 --- Comment #3 from Mark Johnston (ula...@gmail.com) --- Created attachment 300814 --> https://bugzilla.kernel.org/attachment.cgi?id=300814=edit lspci The hardware configuration that was most recently tested. -- You may reply to this email

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-26 Thread Hangyu Hua
On 2022/4/26 22:55, Andrey Grodzovsky wrote: On 2022-04-25 22:54, Hangyu Hua wrote: On 2022/4/25 23:42, Andrey Grodzovsky wrote: On 2022-04-25 04:36, Hangyu Hua wrote: When drm_sched_job_add_dependency() fails, dma_fence_put() will be called internally. Calling it again after

[Bug 215892] 6500XT [drm:amdgpu_dm_init.isra.0.cold [amdgpu]] *ERROR* Failed to register vline0 irq 30!

2022-04-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215892 --- Comment #2 from Mark Johnston (ula...@gmail.com) --- Created attachment 300813 --> https://bugzilla.kernel.org/attachment.cgi?id=300813=edit Prior PowerColor (6500XT) board with chip that does not produce error -- You may reply to this

[Bug 215892] 6500XT [drm:amdgpu_dm_init.isra.0.cold [amdgpu]] *ERROR* Failed to register vline0 irq 30!

2022-04-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215892 --- Comment #1 from Mark Johnston (ula...@gmail.com) --- Created attachment 300812 --> https://bugzilla.kernel.org/attachment.cgi?id=300812=edit full dmesg -- You may reply to this email to add a comment. You are receiving this mail because:

[Bug 215892] New: 6500XT [drm:amdgpu_dm_init.isra.0.cold [amdgpu]] *ERROR* Failed to register vline0 irq 30!

2022-04-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215892 Bug ID: 215892 Summary: 6500XT [drm:amdgpu_dm_init.isra.0.cold [amdgpu]] *ERROR* Failed to register vline0 irq 30! Product: Drivers Version: 2.5 Kernel Version: 5.18-rc4

Re: [PATCH 03/25] drm/msm/dpu: add support for SSPP allocation to RM

2022-04-26 Thread Abhinav Kumar
On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: Add support for handling and allocting SSPP blocks through the resource manager. Handling code is not converted to use it though. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 10 +++

[PATCH v3] drm/amdgpu: Disable ABM when AC mode

2022-04-26 Thread Ryan Lin
Disable ABM feature when the system is running on AC mode to get the more perfect contrast of the display. v2: remove "UPSTREAM" from the subject. v3: adv->pm.ac_power updating by amd gpu_acpi_event_handler. Signed-off-by: Ryan Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 3 +-

Re: [PATCH 2/2] drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write()

2022-04-26 Thread Randy Dunlap
Alex-- On 4/26/22 07:47, Alex Deucher wrote: > Applied the series. Thanks! > > Alex > I just saw a build warning here when CONFIG_DEBUG_FS is not enabled: ../drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c:281:23: warning: 'amdgpu_ta_if_debugfs_create' defined but not used [-Wunused-function]

Re: [PATCH 02/25] drm/msm/dpu: do not limit the zpos property

2022-04-26 Thread Abhinav Kumar
On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: Stop limiting zpos property values, we use normalized_zpos anyway. And nothing stops userspace from assigning several planes to a single zpos (it is a userspace bug, but the kernel is forgiving about it). Signed-off-by: Dmitry Baryshkov

Re: [PATCH 01/25] drm/msm/dpu: rip out master planes support

2022-04-26 Thread Abhinav Kumar
On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: Master/virtual planes were used for multirect support. In preparation to reworking DPU planes, drop support for master planes (which was not used anyway). Signed-off-by: Dmitry Baryshkov Agreed, master planes were unused today anyway. hence,

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-26 Thread Igor Torrente
On April 26, 2022 10:03:09 PM GMT-03:00, Igor Torrente wrote: > > >On 4/25/22 22:54, Igor Torrente wrote: >> Hi Pekka, >> >> On 4/25/22 05:10, Pekka Paalanen wrote: >>> On Sat, 23 Apr 2022 15:53:20 -0300 >>> Igor Torrente wrote: >>> I forgot to respond some points from your review.

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-26 Thread Igor Torrente
On 4/25/22 22:54, Igor Torrente wrote: Hi Pekka, On 4/25/22 05:10, Pekka Paalanen wrote: On Sat, 23 Apr 2022 15:53:20 -0300 Igor Torrente wrote: I forgot to respond some points from your review. On 4/23/22 13:04, Igor Torrente wrote: Hi Pekka, On 4/20/22 09:36, Pekka Paalanen wrote:

Re: [PATCH v5 9/9] drm: vkms: Add support to the RGB565 format

2022-04-26 Thread Igor Torrente
Hi Pekka, On 4/21/22 07:58, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:15 -0300 Igor Torrente wrote: Adds this common format to vkms. This commit also adds new helper macros to deal with fixed-point arithmetic. It was done to improve the precision of the conversion to ARGB16161616

Re: [PATCH v5 5/9] drm: vkms: Add fb information to `vkms_writeback_job`

2022-04-26 Thread Igor Torrente
On 4/26/22 04:09, Pekka Paalanen wrote: On Mon, 25 Apr 2022 21:56:12 -0300 Igor Torrente wrote: Hi Pekka, On 4/25/22 04:56, Pekka Paalanen wrote: On Sat, 23 Apr 2022 12:12:51 -0300 Igor Torrente wrote: Hi Pekka, On 4/20/22 08:23, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:11

[PATCH 3/4] drm/i915/huc: Prepare for GSC-loaded HuC

2022-04-26 Thread Daniele Ceraolo Spurio
HuC loading via GSC is performed via a PXP command sent through the mei modules, so we need both MEI_GSC and MEI_PXP to be available. Given that the GSC will do both the transfer and the authentication, the legacy HuC loading paths can be safely skipped. Also note that the GSC-loaded HuC survives

[PATCH 4/4] drm/i915/huc: Don't fail the probe if HuC init fails

2022-04-26 Thread Daniele Ceraolo Spurio
The previous patch introduced new failure cases in the HuC init flow that can be hit by simply changing the config, so we want to avoid failing the probe in those scenarios. HuC load failure is already considered a non-fatal error and we have a way to report to userspace if the HuC is not

[PATCH 1/4] drm/i915/huc: check HW directly for HuC auth status

2022-04-26 Thread Daniele Ceraolo Spurio
The huc_is_authenticated function return is based on our SW tracking of the HuC auth status. However, around suspend/resume and reset this can go out of sync with the actual HW state, which is why we use huc_check_state() to look at the actual HW state. Instead of having this duality, just make

[PATCH 2/4] drm/i915/huc: Add fetch support for gsc-loaded HuC binary

2022-04-26 Thread Daniele Ceraolo Spurio
On newer platforms (starting DG2 G10 B-step and G11 A-step), ownership of HuC loading has been moved from the GuC to the GSC. As part of the change, the header format of the HuC binary has been updated and does not match the GuC anymore. The GSC will perform all the required checks on the binary

[PATCH 0/4] drm/i915: Prepare for GSC-loaded HuC

2022-04-26 Thread Daniele Ceraolo Spurio
On newer platforms (starting DG2 G10 B-step and G11 A-step), ownership of HuC loading and authentication has been moved from the GuC to the GSC, with both actions being performed via a single PXP command. Given that the mei code has not fully landed yet (see [1]), we can't implement the new load

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-26 Thread Andrey Grodzovsky
On 2022-04-25 22:54, Hangyu Hua wrote: On 2022/4/25 23:42, Andrey Grodzovsky wrote: On 2022-04-25 04:36, Hangyu Hua wrote: When drm_sched_job_add_dependency() fails, dma_fence_put() will be called internally. Calling it again after drm_sched_job_add_dependency() finishes may result in a

Re: [PATCH 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()

2022-04-26 Thread Abhinav Kumar
On 4/26/2022 11:46 AM, Douglas Anderson wrote: The drm_helper_probe_single_connector_modes() is a bit long. Let's break a chunk off to update and validate modes. This helps avoid one goto and also will allow us to more easily call the helper a second time in a future patch without adding

Re: [RFC v2 1/2] drm/vrr: Attach vrr_enabled property to the drm crtc

2022-04-26 Thread Navare, Manasi
On Mon, Apr 25, 2022 at 12:16:11PM +0530, Bhanuprakash Modem wrote: > Modern display hardware is capable of supporting variable refresh rates. > This patch introduces helpers to attach and set "vrr_enabled" property > on the crtc to allow userspace to query VRR enabled status on that crtc. > >

Re: [PATCH] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit

2022-04-26 Thread Stephen Boyd
Quoting Vinod Polimera (2022-04-25 23:02:11) > Avoid clearing irqs and derefernce hw_intr when hw_intr is null. Presumably this is only the case when the display driver doesn't fully probe and something probe defers? Can you clarify how this situation happens? > > BUG: Unable to handle kernel

Re: [PATCH v2] drm: rcar-du: Fix Alpha blending issue on Gen3

2022-04-26 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Tue, Apr 26, 2022 at 09:41:57AM +0100, Biju Das wrote: > From: LUU HOAI > > As per R-Car-Gen3_Common_OPC_Customer_Notifications_V30.1.pdf, > unexpected image output(such as incorrect colors or planes being > invisible) can happen on the below conditions, as

Re: [PATCH v6] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 2:12 PM Kuogee Hsieh wrote: > > Current DP driver implementation has adding safe mode done at > dp_hpd_plug_handle() which is expected to be executed under event > thread context. > > However there is possible circular locking happen (see blow stack trace) > after edp

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-04-26 Thread Abhinav Kumar
On 4/26/2022 1:52 PM, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 1:46 PM Abhinav Kumar wrote: On 4/26/2022 1:21 PM, Douglas Anderson wrote: If we're unable to read the EDID for a display because it's corrupt / bogus / invalid then we'll add a set of standard modes for the display.

Re: [PATCH v6] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-26 14:12:14) > Current DP driver implementation has adding safe mode done at > dp_hpd_plug_handle() which is expected to be executed under event > thread context. > [...] > > Changes in v6: > -- fix Fixes commit ID > > Fixes: 8b2c181e3dcf ("drm/msm/dp: add fail safe

Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 2:11 PM Abhinav Kumar wrote: > > > > On 4/26/2022 1:26 PM, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 26, 2022 at 12:20 PM Abhinav Kumar > > wrote: > >> > >> Missed one more comment. > >> > >> On 4/26/2022 12:16 PM, Abhinav Kumar wrote: > >>> Hi Doug > >>> >

[PATCH v6] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Kuogee Hsieh
Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow stack trace) after edp driver call dp_hpd_plug_handle() from dp_bridge_enable() which is

Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Abhinav Kumar
On 4/26/2022 1:26 PM, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 12:20 PM Abhinav Kumar wrote: Missed one more comment. On 4/26/2022 12:16 PM, Abhinav Kumar wrote: Hi Doug One minor comment below. But otherwise, looking at this change this should work for us acc to me. We will

Re: [PATCH 0/4] mgag200: Improve damage handling

2022-04-26 Thread Lyude Paul
Nice work! For the whole series: Reviewed-by: Lyude Paul Will probably let it sit on the ML for a little bit just to make sure that Thomas gets a chance to look at this On Tue, 2022-04-26 at 18:41 +0200, Jocelyn Falempe wrote: > This series improves the damage handling on Matrox gpu, and

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-26 Thread Bjorn Andersson
On Tue 26 Apr 06:50 PDT 2022, Paul Kocialkowski wrote: > On Tue 26 Apr 22, 15:19, Maxime Ripard wrote: > > On Tue, Apr 26, 2022 at 03:04:17PM +0200, Paul Kocialkowski wrote: > > > On Tue 26 Apr 22, 14:55, Maxime Ripard wrote: > > > > On Tue, Apr 26, 2022 at 02:54:01PM +0200, Maxime Ripard wrote:

Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable

2022-04-26 Thread Felix Kuehling
Am 2022-04-26 um 14:47 schrieb Christophe JAILLET: Le 26/04/2022 à 20:01, Felix Kuehling a écrit : Hi Christophe, I just stumbled over this patch series while cleaning up my inbox. Sorry for dropping it back in November. I'm about to apply it but I noticed that patch 1 is missing a

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 1:46 PM Abhinav Kumar wrote: > > On 4/26/2022 1:21 PM, Douglas Anderson wrote: > > If we're unable to read the EDID for a display because it's corrupt / > > bogus / invalid then we'll add a set of standard modes for the > > display. When userspace looks at these modes

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-04-26 Thread Abhinav Kumar
On 4/26/2022 1:21 PM, Douglas Anderson wrote: If we're unable to read the EDID for a display because it's corrupt / bogus / invalid then we'll add a set of standard modes for the display. When userspace looks at these modes it doesn't really have a good concept for which mode to pick and

Re: [PATCH v5] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 1:30 PM Kuogee Hsieh wrote: > > Current DP driver implementation has adding safe mode done at > dp_hpd_plug_handle() which is expected to be executed under event > thread context. > > However there is possible circular locking happen (see blow stack trace) > after edp

[PATCH v5] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Kuogee Hsieh
Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow stack trace) after edp driver call dp_hpd_plug_handle() from dp_bridge_enable() which is

Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 12:20 PM Abhinav Kumar wrote: > > Missed one more comment. > > On 4/26/2022 12:16 PM, Abhinav Kumar wrote: > > Hi Doug > > > > One minor comment below. > > > > But otherwise, looking at this change this should work for us acc to me. > > > > We will test this out with

Re: [PATCH 3/5] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-04-26 Thread Rob Herring
On Tue, Apr 19, 2022 at 11:32:35AM +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 RDMA definition. How does this compare to the mediatek,mt8183-mdp3-rdma or mediatek,mt8195-disp-rdma? > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > > --- >

[RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-04-26 Thread Douglas Anderson
If we're unable to read the EDID for a display because it's corrupt / bogus / invalid then we'll add a set of standard modes for the display. When userspace looks at these modes it doesn't really have a good concept for which mode to pick and it'll likely pick the highest resolution one by

Re: [PATCH v4] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Dmitry Baryshkov
On 26/04/2022 23:04, Kuogee Hsieh wrote: Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow stack trace) after edp driver call

[PATCH v4] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Kuogee Hsieh
Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow stack trace) after edp driver call dp_hpd_plug_handle() from dp_bridge_enable() which is

Re: How should "max bpc" KMS property work?

2022-04-26 Thread Ville Syrjälä
On Tue, Apr 26, 2022 at 03:38:25PM -0400, Alex Deucher wrote: > On Tue, Apr 26, 2022 at 4:35 AM Pekka Paalanen wrote: > > > > Hi all, > > > > I'm working on setting HDR & WCG video modes in Weston, and I thought > > setting "max bpc" KMS property on the connector would be a good idea. > > I'm

[PATCH v3] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Kuogee Hsieh
Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow stack trace) after edp driver call dp_hpd_plug_handle() from dp_bridge_enable() which is

Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 12:16 PM Abhinav Kumar wrote: > > Hi Doug > > One minor comment below. > > But otherwise, looking at this change this should work for us acc to me. > > We will test this out with our equipment and then provide R-b. > > Thanks > > Abhinav > On 4/26/2022 11:46 AM,

Re: How should "max bpc" KMS property work?

2022-04-26 Thread Alex Deucher
On Tue, Apr 26, 2022 at 4:35 AM Pekka Paalanen wrote: > > Hi all, > > I'm working on setting HDR & WCG video modes in Weston, and I thought > setting "max bpc" KMS property on the connector would be a good idea. > I'm confused about how it works though. > > I did some digging in >

[PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge

2022-04-26 Thread Marek Vasut
The i.MX8MP contains two syscon registers which are responsible for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding which represents this serializer as a bridge. Acked-by: Sam Ravnborg Signed-off-by: Marek Vasut Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Peng

[PATCH v4 2/2] drm: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge

2022-04-26 Thread Marek Vasut
The i.MX8MP contains two syscon registers which are responsible for configuring the on-SoC DPI-to-LVDS serializer. Implement a simple bridge driver for this serializer. Reviewed-by: Sam Ravnborg Signed-off-by: Marek Vasut Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Peng Fan

[PATCH v3 17/18] drm/edid: Extract drm_edid_decode_mfg_id()

2022-04-26 Thread Ville Syrjala
From: Ville Syrjälä Make the PNPID decoding available for other users. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- include/drm/drm_edid.h | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Abhinav Kumar
Missed one more comment. On 4/26/2022 12:16 PM, Abhinav Kumar wrote: Hi Doug One minor comment below. But otherwise, looking at this change this should work for us acc to me. We will test this out with our equipment and then provide R-b. Thanks Abhinav On 4/26/2022 11:46 AM, Douglas

Re: [Intel-gfx] [PULL] gvt-next

2022-04-26 Thread Robert Beckett
On 26/04/2022 17:58, Wang, Zhi A wrote: On 4/26/22 3:53 PM, Jason Gunthorpe wrote: On Tue, Apr 26, 2022 at 07:58:59AM +, Wang, Zhi A wrote: Hi folks: Here is the pull of gvt-next which fixs the compilation error when i915 debug is open after the GVT-g refactor patches. Thanks so much

Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Abhinav Kumar
Hi Doug One minor comment below. But otherwise, looking at this change this should work for us acc to me. We will test this out with our equipment and then provide R-b. Thanks Abhinav On 4/26/2022 11:46 AM, Douglas Anderson wrote: As per Displayport spec section 5.2.1.2 ("Video Timing

Re: [PATCH v2 1/2] drm/sched: use DECLARE_EVENT_CLASS

2022-04-26 Thread Andrey Grodzovsky
Done Andrey On 2022-04-26 14:52, Chia-I Wu wrote: That would be great. I don't have push permission. On Tue, Apr 26, 2022 at 11:25 AM Andrey Grodzovsky wrote: It's ok to land but it wasn't, do you have push permissions to drm-misc-next ? If not, I will do it for you. Andrey On 2022-04-26

Re: [PATCH 06/19] drm/edid: clean up cea_db_is_*() functions

2022-04-26 Thread Ville Syrjälä
On Thu, Apr 14, 2022 at 06:06:49PM +0300, Jani Nikula wrote: > Abstract helpers for matching vendor data blocks and extended tags, and > use them to simplify all the cea_db_is_*() functions. > > Take void pointer as parameter to allow transitional use for both u8 * > and struct cea_db *. > > v2:

Re: [PATCH 02/19] drm/edid: check for HF-SCDB block

2022-04-26 Thread Ville Syrjälä
On Thu, Apr 14, 2022 at 06:06:45PM +0300, Jani Nikula wrote: > From: Lee Shawn C > > Find HF-SCDB information in CEA extensions block. And retrieve > Max_TMDS_Character_Rate that support by sink device. > > v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse >

Re: [GIT PULL] fbdev updates & fixes for v5.18-rc5

2022-04-26 Thread pr-tracker-bot
The pull request you sent on Tue, 26 Apr 2022 17:18:42 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/for-5.18/fbdev-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cf424ef014ac30b0da27125dd1fbdf10b0d3a520 Thank you! --

Re: [PATCH v2 1/2] drm/sched: use DECLARE_EVENT_CLASS

2022-04-26 Thread Chia-I Wu
That would be great. I don't have push permission. On Tue, Apr 26, 2022 at 11:25 AM Andrey Grodzovsky wrote: > > It's ok to land but it wasn't, do you have push permissions to > drm-misc-next ? If not, I will do it for you. > > Andrey > > On 2022-04-26 12:29, Chia-I Wu wrote: > > On Tue, Apr

Re: [PATCH 01/19] drm/edid: reset display info in drm_add_edid_modes() for NULL edid

2022-04-26 Thread Ville Syrjälä
On Thu, Apr 14, 2022 at 06:06:44PM +0300, Jani Nikula wrote: > If a NULL edid gets passed to drm_add_edid_modes(), we should probably > also reset the display info. One concern I had with this is resetting of eg. {width,height}_mm which might have been populated by intel_panel_add_fixed_mode().

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Chia-I Wu
On Tue, Apr 26, 2022 at 11:02 AM Christian König wrote: > > Am 26.04.22 um 19:40 schrieb Chia-I Wu: > > [SNIP] > Well I just send a patch to completely remove the trace point. > > As I said it absolutely doesn't make sense to use this for > visualization, that's what the

Re: [PATCH v2] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Doug Anderson
Hi, On Mon, Apr 25, 2022 at 10:56 PM Kuogee Hsieh wrote: > > Current DP driver implementation has adding safe mode done at > dp_hpd_plug_handle() which is expected to be executed under event > thread context. > > However there is possible circular locking happen (see blow stack trace) > after

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 8:37 AM Abhinav Kumar wrote: > > > Can you provide the exact EDID from the failing test case? Maybe that > > will help shed some light on what's going on. I looked at the original > > commit and it just referred to 4.2.2.1, which I assume is "EDID Read > > upon HPD

Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable

2022-04-26 Thread Christophe JAILLET
Le 26/04/2022 à 20:01, Felix Kuehling a écrit : Hi Christophe, I just stumbled over this patch series while cleaning up my inbox. Sorry for dropping it back in November. I'm about to apply it but I noticed that patch 1 is missing a Signed-off-by. Is it OK to add that in your name? Hi, No

[PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-04-26 Thread Douglas Anderson
As per Displayport spec section 5.2.1.2 ("Video Timing Format") says that all detachable sinks shall support 640x480 @60Hz as a fail safe mode. A DP compliance test expected us to utilize the above fact when all modes it presented to the DP source were not achievable. It presented only modes that

[PATCH 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()

2022-04-26 Thread Douglas Anderson
The drm_helper_probe_single_connector_modes() is a bit long. Let's break a chunk off to update and validate modes. This helps avoid one goto and also will allow us to more easily call the helper a second time in a future patch without adding looping or another goto. This change is intended to be

Re: [PATCH 1/3] drm: Add infrastructure to allow seamless mode switches

2022-04-26 Thread Ville Syrjälä
On Tue, Apr 26, 2022 at 06:32:01PM +, Souza, Jose wrote: > On Tue, 2022-04-26 at 21:08 +0300, Ville Syrjälä wrote: > > On Thu, Apr 21, 2022 at 12:22:03PM -0700, José Roberto de Souza wrote: > > > Intel hardware supports change between modes with different refresh > > > rates without any

Requests For Proposals for hosting XDC 2023 are now open

2022-04-26 Thread Lyude Paul
Hello everyone! The X.org board is soliciting proposals to host XDC in 2023. Since XDC 2022 is being held in North America this year, XDC 2023 is expected to be in Europe. However, the board is open to other locations, especially if there's an interesting co-location with another conference. If

XDC 2022: Registration & Call for Proposals now open!

2022-04-26 Thread Lyude Paul
Hello! The 2022 X.Org Developers Conference is being held in conjunction with the 2022 Wine Developers Conference. This is a meeting to bring together developers working on all things open graphics (Linux kernel, Mesa, DRM, Wayland, X11, etc.) as well as developers for the Wine Project, a key

Re: [PATCH 1/3] drm: Add infrastructure to allow seamless mode switches

2022-04-26 Thread Souza, Jose
On Tue, 2022-04-26 at 21:08 +0300, Ville Syrjälä wrote: > On Thu, Apr 21, 2022 at 12:22:03PM -0700, José Roberto de Souza wrote: > > Intel hardware supports change between modes with different refresh > > rates without any glitches or visual artifacts, that feature is called > > seamless DRRS. > >

Re: [PATCH 1/5] dt-bindings: arm: mediatek: mmsys: add power and gce properties

2022-04-26 Thread Rob Herring
On Tue, Apr 19, 2022 at 11:32:33AM +0800, Rex-BC Chen wrote: > From: "jason-jh.lin" > > Power: > 1. Add description for power-domains property. > > GCE: > 1. Add description for mboxes property. > 2. Add description for mediatek,gce-client-reg property. > > Signed-off-by: jason-jh.lin >

RE: [PATCH 1/3] drm: New function to get luminance range based on static hdr metadata

2022-04-26 Thread Navare, Manasi D
Yes I agree that this data parsed from EDID/Display ID should be stored in structs defined in drm_display_info. Like for the VRR range that we parse from EDID, we store that in a struct monitor_range in drm_display_info. Manasi -Original Message- From: dri-devel On Behalf Of Jani

Re: [PATCH v2 1/2] drm/sched: use DECLARE_EVENT_CLASS

2022-04-26 Thread Andrey Grodzovsky
It's ok to land but it wasn't, do you have push permissions to drm-misc-next ? If not, I will do it for you. Andrey On 2022-04-26 12:29, Chia-I Wu wrote: On Tue, Apr 12, 2022 at 1:48 PM Chia-I Wu wrote: drm_sched_job and drm_run_job have the same prototype. v2: rename the class from

Re: [PATCH] drm/nouveau: fix returnvar.cocci warning

2022-04-26 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a moment On Mon, 2022-04-25 at 19:47 +0800, Guo Zhengkui wrote: > Fix the following coccicheck warning: > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gt215.c:71:5-12: > Unneeded variable: "disable". Return "0ULL" on line 85. > > Signed-off-by: Guo

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Replace crtc_state's has_drrs by drrs_downclock_mode

2022-04-26 Thread Souza, Jose
On Mon, 2022-04-25 at 14:55 +0300, Jani Nikula wrote: > On Thu, 21 Apr 2022, José Roberto de Souza wrote: > > Will be adding some additional control options to DRRS that will > > require to have the DRRS downclock mode stored in the crtc_state. > > > > So to optimize memory usage a bit here

Re: [PATCH 1/3] drm: Add infrastructure to allow seamless mode switches

2022-04-26 Thread Ville Syrjälä
On Thu, Apr 21, 2022 at 12:22:03PM -0700, José Roberto de Souza wrote: > Intel hardware supports change between modes with different refresh > rates without any glitches or visual artifacts, that feature is called > seamless DRRS. > > So far i915 driver was automatically changing between

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Dmitry Baryshkov
On 26/04/2022 20:56, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 10:44 AM Dmitry Baryshkov wrote: On 26/04/2022 20:11, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov wrote: On 26/04/2022 18:37, Abhinav Kumar wrote: Hi Doug On 4/26/2022 8:20 AM, Doug

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Abhinav Kumar
On 4/26/2022 10:56 AM, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 10:44 AM Dmitry Baryshkov wrote: On 26/04/2022 20:11, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov wrote: On 26/04/2022 18:37, Abhinav Kumar wrote: Hi Doug On 4/26/2022 8:20 AM,

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Christian König
Am 26.04.22 um 19:40 schrieb Chia-I Wu: [SNIP] Well I just send a patch to completely remove the trace point. As I said it absolutely doesn't make sense to use this for visualization, that's what the trace_dma_fence_init trace point is good for. I am a bit confused by this. _emit and

Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable

2022-04-26 Thread Felix Kuehling
Hi Christophe, I just stumbled over this patch series while cleaning up my inbox. Sorry for dropping it back in November. I'm about to apply it but I noticed that patch 1 is missing a Signed-off-by. Is it OK to add that in your name? Thanks,   Felix Am 2021-11-28 um 11:45 schrieb

[PATCH v3 1/2] drm/msm/dp: reset DP controller before transmit phy test pattern

2022-04-26 Thread Kuogee Hsieh
DP controller state can not switch from video ready state to transmit phy pattern state at run time. DP mainlink has to be teared down followed by reset controller to default state to have DP controller switch to transmit phy test pattern state and start generate specified phy test pattern to

[PATCH v3 2/2] drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

2022-04-26 Thread Kuogee Hsieh
At normal operation, transmit phy test pattern has to be terminated before DP controller switch to video ready state. However during phy compliance testing, transmit phy test pattern should not be terminated until end of compliance test which usually indicated by unplugged interrupt. Only stop

[PATCH v3 0/2] fix DP phy compliance test

2022-04-26 Thread Kuogee Hsieh
Current DP phy compliance test failed due to test pattern generation was terminated premature. Kuogee Hsieh (2): drm/msm/dp: reset DP controller before transmit phy test pattern drm/msm/dp: do not stop transmitting phy test pattern during DP phy compliance test

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 10:44 AM Dmitry Baryshkov wrote: > > On 26/04/2022 20:11, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov > > wrote: > >> > >> On 26/04/2022 18:37, Abhinav Kumar wrote: > >>> Hi Doug > >>> > >>> On 4/26/2022 8:20 AM, Doug

Re: How should "max bpc" KMS property work?

2022-04-26 Thread Ville Syrjälä
On Tue, Apr 26, 2022 at 11:35:02AM +0300, Pekka Paalanen wrote: > Hi all, > > I'm working on setting HDR & WCG video modes in Weston, and I thought > setting "max bpc" KMS property on the connector would be a good idea. > I'm confused about how it works though. > > I did some digging in >

Re: [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wndw and gv100_disp_wndw_mthd static

2022-04-26 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a moment On Mon, 2022-04-25 at 09:13 -0400, Tom Rix wrote: > Sparse reports these issues > wndwgv100.c:120:1: warning: symbol 'gv100_disp_wndw_mthd' was not declared. > Should it be static? > wndwgv100.c:140:1: warning: symbol 'gv100_disp_wndw' was

Re: [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static

2022-04-26 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a moment On Mon, 2022-04-25 at 09:00 -0400, Tom Rix wrote: > Sparse reports this issue > wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should > it be static? > > This variable is only used in wimmgv100.c.  Single file

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Dmitry Baryshkov
On 26/04/2022 20:11, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov wrote: On 26/04/2022 18:37, Abhinav Kumar wrote: Hi Doug On 4/26/2022 8:20 AM, Doug Anderson wrote: Hi, On Mon, Apr 25, 2022 at 8:35 PM Abhinav Kumar wrote: On 4/25/2022 7:18 PM, Doug

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Chia-I Wu
On Tue, Apr 26, 2022 at 10:20 AM Christian König wrote: > > Am 26.04.22 um 19:16 schrieb Rob Clark: > > On Tue, Apr 26, 2022 at 10:08 AM Christian König > > wrote: > >> Am 26.04.22 um 19:05 schrieb Rob Clark: > >>> On Tue, Apr 26, 2022 at 9:42 AM Christian König > >>> wrote: > Am 26.04.22

Re: [PATCH v2] drm/msm/dp: remove fail safe mode related code

2022-04-26 Thread Abhinav Kumar
On 4/25/2022 11:00 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-04-25 22:56:35) Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected to be executed under event thread context. However there is possible circular locking happen (see blow

Re: [PATCH] drm/nouveau/kms/gv100: use static for gv100_disp_core_mthd_[base|sor]

2022-04-26 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a bit On Fri, 2022-04-22 at 14:51 -0400, Tom Rix wrote: > Sparse reports these issues > coregv100.c:27:1: warning: symbol 'gv100_disp_core_mthd_base' was not > declared. Should it be static? > coregv100.c:43:1: warning: symbol

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Abhinav Kumar
On 4/26/2022 10:11 AM, Doug Anderson wrote: Hi, On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov wrote: On 26/04/2022 18:37, Abhinav Kumar wrote: Hi Doug On 4/26/2022 8:20 AM, Doug Anderson wrote: Hi, On Mon, Apr 25, 2022 at 8:35 PM Abhinav Kumar wrote: On 4/25/2022 7:18 PM, Doug

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Christian König
Am 26.04.22 um 19:16 schrieb Rob Clark: On Tue, Apr 26, 2022 at 10:08 AM Christian König wrote: Am 26.04.22 um 19:05 schrieb Rob Clark: On Tue, Apr 26, 2022 at 9:42 AM Christian König wrote: Am 26.04.22 um 18:32 schrieb Chia-I Wu: On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu wrote: In

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-26 Thread Doug Anderson
Hi, On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov wrote: > > On 26/04/2022 18:37, Abhinav Kumar wrote: > > Hi Doug > > > > On 4/26/2022 8:20 AM, Doug Anderson wrote: > >> Hi, > >> > >> On Mon, Apr 25, 2022 at 8:35 PM Abhinav Kumar > >> wrote: > >>> > >>> On 4/25/2022 7:18 PM, Doug Anderson

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Rob Clark
On Tue, Apr 26, 2022 at 10:08 AM Christian König wrote: > > Am 26.04.22 um 19:05 schrieb Rob Clark: > > On Tue, Apr 26, 2022 at 9:42 AM Christian König > > wrote: > >> Am 26.04.22 um 18:32 schrieb Chia-I Wu: > >>> On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu wrote: > In practice,

Re: [PATCH v6 10/19] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-26 Thread Dmitry Baryshkov
On 26/04/2022 17:41, Abhinav Kumar wrote: Make changes to dpu_encoder to support virtual encoder needed to support writeback for dpu. changes in v4: - squash dpu_encoder pieces from [1] changes in v5: - none changes in v6: - fix the comment about intf_idx and wb_idx

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Christian König
Am 26.04.22 um 19:05 schrieb Rob Clark: On Tue, Apr 26, 2022 at 9:42 AM Christian König wrote: Am 26.04.22 um 18:32 schrieb Chia-I Wu: On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu wrote: In practice, trace_dma_fence_init called from dma_fence_init is good enough and almost no driver calls

Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Rob Clark
On Tue, Apr 26, 2022 at 9:42 AM Christian König wrote: > > Am 26.04.22 um 18:32 schrieb Chia-I Wu: > > On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu wrote: > >> In practice, trace_dma_fence_init called from dma_fence_init is good > >> enough and almost no driver calls trace_dma_fence_emit. But

Re: [PATCH] dma-buf: remove trace_dma_fence_emit

2022-04-26 Thread Christian König
Add a few more people on CC. Am 26.04.22 um 19:00 schrieb Christian König: There was never any significant difference between trace_dma_fence_emit() and trace_dma_fence_init() and the only place where it would made a significant difference was never implemented. So remove

  1   2   3   >