Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-06-06 Thread Keisuke Nishimura
On 2022/06/02 16:38, Arnd Bergmann wrote: I think that SmPL script worked great, almost every instance is something that ought to be changed, as long as it stops reporting those structures that are also __aligned(). I would extend it to also report structures with 'bool', 'enum', or any

[PATCH] drm/msm: Fix double pm_runtime_disable() call

2022-06-06 Thread Maximilian Luz
Following commit 17e822f7591f ("drm/msm: fix unbalanced pm_runtime_enable in adreno_gpu_{init, cleanup}"), any call to adreno_unbind() will disable runtime PM twice, as indicated by the call trees below: adreno_unbind() -> pm_runtime_force_suspend() -> pm_runtime_disable()

Re: [PATCH v4 5/8] drm/panel: panel-simple: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
On Tue, Jun 7, 2022 at 3:25 AM Sam Ravnborg wrote: > > Hi Hsin-Yi, > > On Mon, Jun 06, 2022 at 11:24:28PM +0800, Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > Reviewed-by: Douglas Anderson >

Re: [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread Hsin-Yi Wang
On Tue, Jun 7, 2022 at 3:31 AM Sam Ravnborg wrote: > > Hi Hsin-Yi, > > On Mon, Jun 06, 2022 at 11:24:31PM +0800, Hsin-Yi Wang wrote: > > Panel orientation property should be set before drm_dev_register(). > > Mediatek drm driver calls drm_dev_register() in .bind(). However, most > > panels sets

Re: [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread Hsin-Yi Wang
On Tue, Jun 7, 2022 at 3:16 AM Stephen Boyd wrote: > > Quoting Hsin-Yi Wang (2022-06-06 08:24:31) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index d9f10a33e6fa..c56282412bfa 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++

RE: [PATCH v1 2/2] drm/aspeed: Add 1024x768 mode for AST2600

2022-06-06 Thread Tommy Huang
Hi Joel, We have released related datasheet and update these registers description. SCU300: Clock Selection Register ... 10:8 Soc display clock selection 000b: D-PLL 001b: Reserved 010b: 40MHz from USB 2.0 port1 PHY 011b: GPIOC6

Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

2022-06-06 Thread Brian Norris
On Mon, Jun 6, 2022 at 1:30 PM Doug Anderson wrote: > On Fri, Jun 3, 2022 at 8:17 AM Doug Anderson wrote: > > On Fri, Jun 3, 2022 at 8:11 AM Sean Paul wrote: > > > Apologies for the delay. Please in future ping on irc/chat if you're > > > waiting for review from me, my inbox is often neglected.

[PATCH 2/2] vfio: Replace the iommu notifier with a device list

2022-06-06 Thread Jason Gunthorpe
Instead of bouncing the function call to the driver op through a blocking notifier just have the iommu layer call it directly. Register each device that is being attached to the iommu with the lower driver which then threads them on a linked list and calls the appropriate driver op at the right

[PATCH 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-06-06 Thread Jason Gunthorpe
Instead of having drivers register the notifier with explicit code just have them provide a dma_unmap callback op in their driver ops and rely on the core code to wire it up. Suggested-by: Christoph Hellwig Signed-off-by: Jason Gunthorpe --- drivers/gpu/drm/i915/gvt/gvt.h| 1 -

[PATCH 0/2] Remove the VFIO_IOMMU_NOTIFY_DMA_UNMAP notifier

2022-06-06 Thread Jason Gunthorpe
This is the last notifier toward the drivers, replace it with a simple op callback in the vfio_device_ops. Jason Gunthorpe (2): vfio: Replace the DMA unmapping notifier with a callback vfio: Replace the iommu notifier with a device list drivers/gpu/drm/i915/gvt/gvt.h| 1 -

RE: [PATCH v2 2/2] drm/virtio: fence created per cursor/plane update

2022-06-06 Thread Kasireddy, Vivek
Hi DW, > Subject: [PATCH v2 2/2] drm/virtio: fence created per cursor/plane update > > Having one fence for a vgfb would cause conflict in case there are > multiple planes referencing the same vgfb (e.g. Xorg screen covering > two displays in extended mode) being flushed simultaneously. So it

RE: [PATCH v2 1/2] drm/virtio: .release ops for virtgpu fence release

2022-06-06 Thread Kasireddy, Vivek
> virtio_gpu_fence_release is added to free virtio-gpu-fence > upon release of dma_fence. > > Cc: Gurchetan Singh > Cc: Gerd Hoffmann > Cc: Vivek Kasireddy > Signed-off-by: Dongwon Kim > --- > drivers/gpu/drm/virtio/virtgpu_fence.c | 8 > 1 file changed, 8 insertions(+) > > diff

Re: Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property

2022-06-06 Thread Jernej Škrabec
Dne ponedeljek, 06. junij 2022 ob 10:17:20 CEST je Roman Stratiienko napisal(a): > Hello Jernej, > > Thank you for having a look. > > вс, 5 июн. 2022 г. в 23:37, Jernej Škrabec : > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko napisal(a): > > > Allwinner DE2 and DE3

Re: [PATCH] drm/msm: Fix double pm_runtime_disable() call

2022-06-06 Thread Rob Clark
On Mon, Jun 6, 2022 at 2:13 PM Maximilian Luz wrote: > > Following commit 17e822f7591f ("drm/msm: fix unbalanced > pm_runtime_enable in adreno_gpu_{init, cleanup}"), any call to > adreno_unbind() will disable runtime PM twice, as indicated by the call > trees below: > > adreno_unbind() >->

Re: [PATCH] drm/msm: Fix double pm_runtime_disable() call

2022-06-06 Thread Bjorn Andersson
On Mon 06 Jun 14:13 PDT 2022, Maximilian Luz wrote: > Following commit 17e822f7591f ("drm/msm: fix unbalanced > pm_runtime_enable in adreno_gpu_{init, cleanup}"), any call to > adreno_unbind() will disable runtime PM twice, as indicated by the call > trees below: > > adreno_unbind() >->

Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Sam Ravnborg
Hi Hans, > > Please move this up so it is together with the other get_* methods, in > > alphabetic order. That is, right after get_modes(), and then this also > > matches the order in the .c file with is extra bonus. > > The downside of moving this up is that it will break drivers which don't >

RE: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-06 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Vishwanathapura, Niranjana > Sent: June 2, 2022 4:49 PM > To: Zeng, Oak > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, > Daniel ; Brost, Matthew ; > Hellstrom, Thomas ; ja...@jlekstrand.net; > Wilson, Chris P

Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

2022-06-06 Thread Doug Anderson
Hi, On Fri, Jun 3, 2022 at 8:17 AM Doug Anderson wrote: > > Hi, > > On Fri, Jun 3, 2022 at 8:11 AM Sean Paul wrote: > > > > On Mon, May 23, 2022 at 5:51 PM Brian Norris > > wrote: > > > > > > On Thu, Mar 10, 2022 at 3:50 PM Brian Norris > > > wrote: > > > > On Mon, Feb 28, 2022 at 12:25 PM

Re: [PATCH v4] drm/probe-helper: Default to 640x480 if no EDID on DP

2022-06-06 Thread Doug Anderson
Hi, On Wed, Jun 1, 2022 at 11:23 AM Douglas Anderson wrote: > > If we're unable to read the EDID for a display because it's corrupt / > bogus / invalid then we'll add a set of standard modes for the > display. Since we have no true information about the connected > display, these modes are

Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Hans de Goede
Hi, On 6/6/22 21:20, Sam Ravnborg wrote: > Hi Hsin-Yi, > On Mon, Jun 06, 2022 at 11:24:24PM +0800, Hsin-Yi Wang wrote: >> Panels usually call drm_connector_set_panel_orientation(), which is >> later than drm/kms driver calling drm_dev_register(). This leads to a >> WARN(). >> >> The orientation

[PATCH v2 2/2] drm/msm: Expose client engine utilization via fdinfo

2022-06-06 Thread Rob Clark
From: Rob Clark Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for msm. Example output: # cat /proc/`pgrep glmark2`/fdinfo/6 pos:0

[PATCH v2 1/2] drm: Add DRM_GEM_FOPS

2022-06-06 Thread Rob Clark
From: Rob Clark The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to provide additional file ops, like show_fdinfo(). Signed-off-by: Rob Clark --- include/drm/drm_gem.h | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git

Re: [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread Sam Ravnborg
Hi Hsin-Yi, On Mon, Jun 06, 2022 at 11:24:31PM +0800, Hsin-Yi Wang wrote: > Panel orientation property should be set before drm_dev_register(). > Mediatek drm driver calls drm_dev_register() in .bind(). However, most > panels sets orientation property relatively late, mostly in .get_modes() >

Re: [PATCH v4 0/8] Add a panel API to return panel orientation

2022-06-06 Thread Sam Ravnborg
Hi Hsin-Yi, thanks for this nice series. On Mon, Jun 06, 2022 at 11:24:23PM +0800, Hsin-Yi Wang wrote: > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known

Re: [PATCH v4 5/8] drm/panel: panel-simple: Implement .get_orientation callback

2022-06-06 Thread Sam Ravnborg
Hi Hsin-Yi, On Mon, Jun 06, 2022 at 11:24:28PM +0800, Hsin-Yi Wang wrote: > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > --- > drivers/gpu/drm/panel/panel-simple.c | 16 +++- >

Re: [PATCH v3] dt-bindings: display: bridge: sil, sii9022: Convert to json-schema

2022-06-06 Thread Rob Herring
On Thu, 19 May 2022 15:41:06 +0200, Geert Uytterhoeven wrote: > Convert the Silicon Image sii902x HDMI bridge Device Tree binding > documentation to json-schema. > > Add missing sil,sii9022-cpi and sil,sii9022-tpi compatible values. > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - Add

Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Sam Ravnborg
Hi Hsin-Yi, On Mon, Jun 06, 2022 at 11:24:24PM +0800, Hsin-Yi Wang wrote: > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN(). > > The orientation property is known earlier. For example, some panels

Re: [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-06 08:24:31) > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index d9f10a33e6fa..c56282412bfa 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -822,6 +823,12 @@ static int

Re: [PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback

2022-06-06 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-06 08:24:27) > diff --git a/drivers/gpu/drm/panel/panel-lvds.c > b/drivers/gpu/drm/panel/panel-lvds.c > index f11252fb00fe..491b64c2c8d6 100644 > --- a/drivers/gpu/drm/panel/panel-lvds.c > +++ b/drivers/gpu/drm/panel/panel-lvds.c > @@ -99,15 +99,30 @@ static int

Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-06 08:24:24) > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index f634371c717a..e12056cfeca8 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -223,6 +223,15 @@ int drm_panel_get_modes(struct drm_panel

[PATCH] drm/doc: Add KUnit documentation

2022-06-06 Thread José Expósito
Explain how to run the KUnit tests present in the DRM subsystem and clarify why the UML-only options were not added to the configuration file present in drivers/gpu/drm/.kunitconfig [1] [2]. [1] https://lore.kernel.org/dri-devel/CABVgOSn8i=lo5p7830h2xu1jgg0krn0qtnxkomhf1otgxja...@mail.gmail.com/

[PATCH v2] drm/msm/dp: check core_initialized before disable interrupts at dp_display_unbind()

2022-06-06 Thread Kuogee Hsieh
During msm initialize phase, dp_display_unbind() will be called to undo initializations had been done by dp_display_bind() previously if there is error happen at msm_drm_bind. In this case, core_initialized flag had to be check to make sure clocks is on before update DP controller register to

[PATCH 2/2] vfio/pci: Remove console drivers

2022-06-06 Thread Alex Williamson
Console drivers can create conflicts with PCI resources resulting in userspace getting mmap failures to memory BARs. This is especially evident when trying to re-use the system primary console for userspace drivers. Attempt to remove all nature of conflicting drivers as part of our VGA

[PATCH 0/2] Improve vfio-pci primary GPU assignment behavior

2022-06-06 Thread Alex Williamson
Users attempting to enable vfio PCI device assignment with a GPU will often block the default PCI driver from the device to avoid conflicts with the device initialization or release path. This means that vfio-pci is sometimes the first PCI driver to bind to the device. In the case of assigning

[PATCH 1/2] drm/aperture: Split conflicting platform driver removal

2022-06-06 Thread Alex Williamson
Split the removal of platform drivers conflicting with PCI resources from drm_aperture_remove_conflicting_pci_framebuffers() to support both non-DRM callers and better modularity. This is intended to support the vfio-pci driver, which can acquire ownership of PCI graphics devices, but is not

Re: [PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-06-06 Thread Russell King (Oracle)
On Mon, Jun 06, 2022 at 06:14:36PM +0100, Mark Brown wrote: > The tda9950 driver prints an error message if it is instantiated without > an interrupt being available since the device is non-functional in that > case. Unfortunately due to packaging of tda9950 with tda998x series devices > the

Re: [PATCH v1 1/2] drm/msm: enable msm irq after all initializations are done successfully at msm_drm_init()

2022-06-06 Thread Kuogee Hsieh
I will drop this patch since the problem had been fixed by Dmitry Baryshkov patch. https://gitlab.freedesktop.org/drm/msm/-/commit/577e2a9dfc8fba7938aaf75db63fae7e328cc3cb On 6/3/2022 2:28 PM, Kuogee Hsieh wrote: At msm initialize phase, msm_drm_init() is called to initialize modules

Re: [PATCH] MAINTAINERS: rectify entries for ARM DRM DRIVERS after dt conversion

2022-06-06 Thread Rob Herring
On Wed, 01 Jun 2022 06:17:46 +0200, Lukas Bulwahn wrote: > The three commits: > > 36fd2a65bcaf ("dt-bindings: display: convert Arm HDLCD to DT schema") > 0f6983509ea1 ("dt-bindings: display: convert Arm Komeda to DT schema") > 2c8b082a3ab1 ("dt-bindings: display: convert Arm Mali-DP to DT

[PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-06-06 Thread Mark Brown
The tda9950 driver prints an error message if it is instantiated without an interrupt being available since the device is non-functional in that case. Unfortunately due to packaging of tda9950 with tda998x series devices the tda998x driver unconditionally instantiates a tda9950 so systems with a

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread José Expósito
Hi! Javier Martinez Canillas wrote: > Hello José, > > On 6/6/22 11:55, José Expósito wrote: > > Test the conversion from XRGB to RGB332. > > > > What is tested? > > > > - Different values for the X in XRGB to make sure it is ignored > > - Different clip values: Single pixel and full

Re: [PATCH v4] dma-buf: Add a capabilities directory

2022-06-06 Thread Robin Murphy
On 2022-06-06 16:22, Greg KH wrote: On Mon, Jun 06, 2022 at 04:10:09PM +0100, Robin Murphy wrote: On 2022-06-02 07:47, Daniel Vetter wrote: On Thu, 2 Jun 2022 at 08:34, Simon Ser wrote: On Thursday, June 2nd, 2022 at 08:25, Greg KH wrote: On Thu, Jun 02, 2022 at 06:17:31AM +, Simon

Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

2022-06-06 Thread Hsin-Yi Wang
On Mon, May 30, 2022 at 7:30 PM Hsin-Yi Wang wrote: > > krane, kakadu, and kodama boards have a default panel rotation. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Enric Balletbo i Serra > Tested-by: Enric Balletbo i Serra > --- Hi Matthias, The series ("Add a panel API to return panel

Re: [PATCH v3 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Hsin-Yi Wang
On Mon, Jun 6, 2022 at 10:21 PM Doug Anderson wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > later than drm/kms driver calling drm_dev_register(). This leads to a > > WARN(). > > > > The

Re: [PATCH v3 4/8] drm/panel: lvds: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
On Mon, Jun 6, 2022 at 10:27 PM Doug Anderson wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > > > To return the orientation property to drm/kms driver. > > > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > v2->v3: add comments for notice. > >

[PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread Hsin-Yi Wang
Panel orientation property should be set before drm_dev_register(). Mediatek drm driver calls drm_dev_register() in .bind(). However, most panels sets orientation property relatively late, mostly in .get_modes() callback, since this is when they are able to get the connector and binds the

[PATCH v4 7/8] drm/panel: elida-kd35t133: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
To return the orientation property to drm/kms driver. Signed-off-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v4 6/8] drm/panel: ili9881c: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
To return the orientation property to drm/kms driver. Signed-off-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v4 5/8] drm/panel: panel-simple: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
To return the orientation property to drm/kms driver. Signed-off-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-simple.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

[PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
To return the orientation property to drm/kms driver. Signed-off-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: Douglas Anderson --- v3->v4: rebase to latest linux-next to solve conflict. --- drivers/gpu/drm/panel/panel-lvds.c | 15 +++ 1 file changed, 15 insertions(+)

[PATCH v4 3/8] drm/panel: panel-edp: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
To return the orientation property to drm/kms driver. Signed-off-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-edp.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[PATCH v4 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback

2022-06-06 Thread Hsin-Yi Wang
To return the orientation property to drm/kms driver. Signed-off-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Hsin-Yi Wang
Panels usually call drm_connector_set_panel_orientation(), which is later than drm/kms driver calling drm_dev_register(). This leads to a WARN(). The orientation property is known earlier. For example, some panels parse the property through device tree during probe. Add an API to return the

[PATCH v4 0/8] Add a panel API to return panel orientation

2022-06-06 Thread Hsin-Yi Wang
Panels usually call drm_connector_set_panel_orientation(), which is later than drm/kms driver calling drm_dev_register(). This leads to a WARN()[1]. The orientation property is known earlier. For example, some panels parse the property through device tree during probe. The series add a panel API

Re: [PATCH v4] dma-buf: Add a capabilities directory

2022-06-06 Thread Greg KH
On Mon, Jun 06, 2022 at 04:10:09PM +0100, Robin Murphy wrote: > On 2022-06-02 07:47, Daniel Vetter wrote: > > On Thu, 2 Jun 2022 at 08:34, Simon Ser wrote: > > > > > > On Thursday, June 2nd, 2022 at 08:25, Greg KH wrote: > > > > > > > On Thu, Jun 02, 2022 at 06:17:31AM +, Simon Ser wrote:

Re: [PATCH] drm/i915/dg2: Catch and log more unexpected values in DG1_MSTR_TILE_INTR

2022-06-06 Thread Matt Roper
On Mon, Jun 06, 2022 at 12:55:20PM +0100, Tvrtko Ursulin wrote: > > On 27/05/2022 19:42, Matt Roper wrote: > > On Thu, May 26, 2022 at 11:18:17AM +0100, Tvrtko Ursulin wrote: > > > On 25/05/2022 19:05, Matt Roper wrote: > > > > On Wed, May 25, 2022 at 05:03:13PM +0100, Tvrtko Ursulin wrote: > > >

Re: [PATCH v4] dma-buf: Add a capabilities directory

2022-06-06 Thread Robin Murphy
On 2022-06-02 07:47, Daniel Vetter wrote: On Thu, 2 Jun 2022 at 08:34, Simon Ser wrote: On Thursday, June 2nd, 2022 at 08:25, Greg KH wrote: On Thu, Jun 02, 2022 at 06:17:31AM +, Simon Ser wrote: On Thursday, June 2nd, 2022 at 07:40, Greg KH g...@kroah.com wrote: On Wed, Jun 01,

Re: [RFC PATCH v2 00/27] DRM.debug on DYNAMIC_DEBUG, add trace events

2022-06-06 Thread jim . cromie
On Wed, May 25, 2022 at 9:02 AM Daniel Vetter wrote: > On Mon, May 16, 2022 at 04:56:13PM -0600, Jim Cromie wrote: > > DRM.debug API is 23 macros, issuing 10 exclusive categories of debug > > messages. By rough count, they are used 5140 times in the kernel. > > These all call drm_dbg or

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Javier Martinez Canillas
Hello Daniel, On 6/6/22 16:19, Daniel Latypov wrote: [snip] >> That's what I asked in the previous RFC too. Daniel mentioned that it >> shouldn't >> go there because is platform specific (AFAIU, one might want to test it on >> x86, > > Slight correction, it was David who explicitly suggested

Re: [PATCH v3 6/8] drm/panel: ili9881c: Implement .get_orientation callback

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > v2->v3: add comments for notice. > --- > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 14 ++ > 1

Re: [PATCH v3 7/8] drm/panel: elida-kd35t133: Implement .get_orientation callback

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > v2->v3: add comments for notice. > --- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 14 ++ > 1

Re: [RESEND 12/14] leds: mt6370: Add Mediatek MT6370 Indicator support

2022-06-06 Thread kernel test robot
Hi ChiaEn, Thank you for the patch! Yet something to improve: [auto build test ERROR on pavel-leds/for-next] [also build test ERROR on lee-mfd/for-mfd-next lee-backlight/for-backlight-next v5.19-rc1 next-20220606] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3 5/8] drm/panel: panel-simple: Implement .get_orientation callback

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > v2->v3: add comments for notice. > --- > drivers/gpu/drm/panel/panel-simple.c | 16 +++- > 1 file

Re: [PATCH v3 4/8] drm/panel: lvds: Implement .get_orientation callback

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > v2->v3: add comments for notice. > --- > drivers/gpu/drm/panel/panel-lvds.c | 14 ++ > 1 file

Re: [PATCH v3 3/8] drm/panel: panel-edp: Implement .get_orientation callback

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > v2->v3: add comments for notice. > --- > drivers/gpu/drm/panel/panel-edp.c | 15 ++- > 1 file

Re: [PATCH v3 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > v2->v3: add comments for notice. > --- > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 14 ++ >

Re: [PATCH v3 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Doug Anderson
Hi, On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN(). > > The orientation property is known earlier. For example, some panels > parse the

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Maxime Ripard
On Mon, Jun 06, 2022 at 03:57:45PM +0200, Javier Martinez Canillas wrote: > Hello Maxime, > > On 6/6/22 15:52, Maxime Ripard wrote: > > hi, > > > > On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote: > >> Hello Maxime, > >> > >> On 6/6/22 15:42, Maxime Ripard wrote: > >>>

Re: [PATCH 13/14] drm/vc4: crtc: Fix out of order frames during asynchronous page flips

2022-06-06 Thread Maxime Ripard
Hi, On Thu, May 12, 2022 at 09:44:42AM -0100, Melissa Wen wrote: > On 05/09, Melissa Wen wrote: > > O 05/09, Melissa Wen wrote: > > > On 05/03, Maxime Ripard wrote: > > > > When doing an asynchronous page flip (PAGE_FLIP ioctl with the > > > > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Javier Martinez Canillas
Hello Maxime, On 6/6/22 15:52, Maxime Ripard wrote: > hi, > > On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote: >> Hello Maxime, >> >> On 6/6/22 15:42, Maxime Ripard wrote: >>> Hi, >>> >>> On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: Test the

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Maxime Ripard
hi, On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote: > Hello Maxime, > > On 6/6/22 15:42, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: > >> Test the conversion from XRGB to RGB332. > >> > >> What is tested? > >>

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Javier Martinez Canillas
Hello Maxime, On 6/6/22 15:42, Maxime Ripard wrote: > Hi, > > On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: >> Test the conversion from XRGB to RGB332. >> >> What is tested? >> >> - Different values for the X in XRGB to make sure it is ignored >> - Different clip

Re: [PATCH v13 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-06-06 Thread Bjorn Andersson
On Wed 25 May 14:02 PDT 2022, Kuogee Hsieh wrote: > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Douglas Anderson Reviewed-by: Bjorn Andersson > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 12 >

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Maxime Ripard
Hi, On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: > Test the conversion from XRGB to RGB332. > > What is tested? > > - Different values for the X in XRGB to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well known

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread Javier Martinez Canillas
Hello José, On 6/6/22 11:55, José Expósito wrote: > Test the conversion from XRGB to RGB332. > > What is tested? > > - Different values for the X in XRGB to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well known colors: White,

Re: [PATCH] drm/ttm: fix missing NULL check in ttm_device_swapout

2022-06-06 Thread Felix Kuehling
Am 2022-06-03 um 06:46 schrieb Christian König: Resources about to be destructed are not tied to BOs any more. Signed-off-by: Christian König Reviewed-by: Felix Kuehling --- drivers/gpu/drm/ttm/ttm_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [RESEND v4 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-06-06 Thread Rob Herring
On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 RDMA definition. > > Signed-off-by: Nancy.Lin > Signed-off-by: Bo-Chen Chen > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Krzysztof Kozlowski > Tested-by: AngeloGioacchino Del Regno >

Re: [RESEND v4 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-06-06 Thread Rob Herring
On Mon, 06 Jun 2022 13:11:31 +0800, Bo-Chen Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Signed-off-by: Bo-Chen Chen > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Krzysztof Kozlowski > Tested-by:

Re: [PATCH] drm/i915/dg2: Catch and log more unexpected values in DG1_MSTR_TILE_INTR

2022-06-06 Thread Tvrtko Ursulin
On 27/05/2022 19:42, Matt Roper wrote: On Thu, May 26, 2022 at 11:18:17AM +0100, Tvrtko Ursulin wrote: On 25/05/2022 19:05, Matt Roper wrote: On Wed, May 25, 2022 at 05:03:13PM +0100, Tvrtko Ursulin wrote: On 24/05/2022 18:51, Matt Roper wrote: On Tue, May 24, 2022 at 10:43:39AM +0100,

[PATCH 3/3] drm/komeda - Fix handling of pending crtc state commit to avoid lock-up

2022-06-06 Thread carsten . haitzler
From: Carsten Haitzler Sometimes there is an extra dcm crtc state in the pipeline whose penting vblank event has not been handled yet. We would previously throw this out and the vblank event never triggers leading to hard lockups higher up the stack where an expected vlank event never comes back

[PATCH 2/3] drm/komeda - At init write GCU control block to handle already on DPU

2022-06-06 Thread carsten . haitzler
From: Carsten Haitzler If something has already set up the DPU before the komeda driver comes up, it will fail to init because it was just writing to the SRST bit in the GCU control register and ignoring others. This resulted in TBU bringup stalling and init failing. By writing completely we

[PATCH 1/3] drm/komeda - Add legacy FB support so VT's work as expected

2022-06-06 Thread carsten . haitzler
From: Carsten Haitzler The komeda driver doesn't come up with a visible text (FB) mode VT by default as it was missing legacy FB support. It's useful to have a working text VT on a system for debug and general usability, so enable it. You can always toggle CONFIG_FRAMEBUFFER_CONSOLE.

Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property

2022-06-06 Thread Roman Stratiienko
Hi Maxime, пн, 6 июн. 2022 г. в 12:22, Maxime Ripard : > > On Mon, Jun 06, 2022 at 11:20:06AM +0200, Maxime Ripard wrote: > > On Mon, Jun 06, 2022 at 11:17:20AM +0300, Roman Stratiienko wrote: > > > Hello Jernej, > > > > > > Thank you for having a look. > > > > > > вс, 5 июн. 2022 г. в 23:37,

Re: [RFC PATCH 3/5] drm/amdgpu: Allow explicit sync for VM ops.

2022-06-06 Thread Bas Nieuwenhuizen
On Mon, Jun 6, 2022 at 12:35 PM Christian König wrote: > > Am 06.06.22 um 12:30 schrieb Bas Nieuwenhuizen: > > On Mon, Jun 6, 2022 at 12:15 PM Christian König > > wrote: > >> > >> > >> Am 03.06.22 um 21:11 schrieb Bas Nieuwenhuizen: > >>> On Fri, Jun 3, 2022 at 8:41 PM Christian König > >>>

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-06 Thread Christian König
Am 05.06.22 um 18:47 schrieb Daniel Vetter: On Fri, 27 May 2022 at 01:55, Dmitry Osipenko wrote: Introduce a common DRM SHMEM shrinker framework that allows to reduce code duplication among DRM drivers by replacing theirs custom shrinker implementations with the generic shrinker. In order to

Re: [RFC PATCH 3/5] drm/amdgpu: Allow explicit sync for VM ops.

2022-06-06 Thread Christian König
Am 06.06.22 um 12:30 schrieb Bas Nieuwenhuizen: On Mon, Jun 6, 2022 at 12:15 PM Christian König wrote: Am 03.06.22 um 21:11 schrieb Bas Nieuwenhuizen: On Fri, Jun 3, 2022 at 8:41 PM Christian König wrote: Am 03.06.22 um 19:50 schrieb Bas Nieuwenhuizen: [SNIP] Yeah, but that's exactly

Re: [RFC PATCH 3/5] drm/amdgpu: Allow explicit sync for VM ops.

2022-06-06 Thread Bas Nieuwenhuizen
On Mon, Jun 6, 2022 at 12:15 PM Christian König wrote: > > > > Am 03.06.22 um 21:11 schrieb Bas Nieuwenhuizen: > > On Fri, Jun 3, 2022 at 8:41 PM Christian König > > wrote: > >> Am 03.06.22 um 19:50 schrieb Bas Nieuwenhuizen: > >>> [SNIP] > >> Yeah, but that's exactly the bubble we try to

Re: [PATCH] drm/ttm: fix missing NULL check in ttm_device_swapout

2022-06-06 Thread Christian König
Am 04.06.22 um 00:44 schrieb Felix Kuehling: [+amd-gfx] On 2022-06-03 15:37, Felix Kuehling wrote: On 2022-06-03 06:46, Christian König wrote: Resources about to be destructed are not tied to BOs any more. I've been seeing a backtrace in that area with a patch series I'm working on, but

Re: [PATCH v2] drm/sun4i: Enable output signal premultiplication for DE2/DE3

2022-06-06 Thread Roman Stratiienko
Hi, вс, 5 июн. 2022 г. в 23:23, Jernej Škrabec : > > Dne nedelja, 05. junij 2022 ob 11:40:18 CEST je Roman Stratiienko napisal(a): > > Otherwise alpha value is discarded, resulting incorrect pixel > > apperance on the display. > > > > This also fixes missing transparency for the most bottom

Re: [RFC PATCH 3/5] drm/amdgpu: Allow explicit sync for VM ops.

2022-06-06 Thread Christian König
Am 03.06.22 um 21:11 schrieb Bas Nieuwenhuizen: On Fri, Jun 3, 2022 at 8:41 PM Christian König wrote: Am 03.06.22 um 19:50 schrieb Bas Nieuwenhuizen: [SNIP] Yeah, but that's exactly the bubble we try to avoid. Isn't it? For this series, not really. To clarify there are two sides for

[PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread José Expósito
Test the conversion from XRGB to RGB332. What is tested? - Different values for the X in XRGB to make sure it is ignored - Different clip values: Single pixel and full and partial buffer - Well known colors: White, black, red, green, blue, magenta, yellow and cyan - Other colors:

[PATCH 0/1] KUnit tests for drm_format_helper

2022-06-06 Thread José Expósito
Hello everyone, Recently Javier added a new task in the ToDo list [1] to create KUnit tests for the functions present in "drm_format_helper". This patch includes the changes suggested in the RFC version [2]. Best wishes, José Expósito [1]

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-06 Thread José Expósito
Hello everyone, On Thu, Jun 02, 2022 at 07:21:28PM +0200, Javier Martinez Canillas wrote: > Hello David, > > On 6/2/22 19:07, David Gow wrote: > > On Thu, Jun 2, 2022 at 9:27 AM Javier Martinez Canillas > > [snip] > > >> > >> And doing that will also allow you to get rid of this, since just

Re: [PATCH v3 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread AngeloGioacchino Del Regno
Il 06/06/22 06:47, Hsin-Yi Wang ha scritto: Panel orientation property should be set before drm_dev_register(). Mediatek drm driver calls drm_dev_register() in .bind(). However, most panels sets orientation property relatively late, mostly in .get_modes() callback, since this is when they are

Re: (subset) [PATCH 3/3] ARM: dts: exynos: add panel and backlight to p4note

2022-06-06 Thread Krzysztof Kozlowski
On Mon, 16 May 2022 21:37:09 +0200, Martin Jücker wrote: > Add configuration for the LTL101AL01 panel and a pwm backlight to drive > the display in the p4note devices. > > Applied, thanks! [3/3] ARM: dts: exynos: add panel and backlight to p4note

Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property

2022-06-06 Thread Maxime Ripard
On Mon, Jun 06, 2022 at 11:20:06AM +0200, Maxime Ripard wrote: > On Mon, Jun 06, 2022 at 11:17:20AM +0300, Roman Stratiienko wrote: > > Hello Jernej, > > > > Thank you for having a look. > > > > вс, 5 июн. 2022 г. в 23:37, Jernej Škrabec : > > > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST

Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property

2022-06-06 Thread Maxime Ripard
On Mon, Jun 06, 2022 at 11:17:20AM +0300, Roman Stratiienko wrote: > Hello Jernej, > > Thank you for having a look. > > вс, 5 июн. 2022 г. в 23:37, Jernej Škrabec : > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko > > napisal(a): > > > Allwinner DE2 and DE3 hardware

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2022 14:38:54 + Zack Rusin wrote: > > On Jun 3, 2022, at 10:32 AM, Simon Ser wrote: > > > > ⚠ External Email > > > > On Friday, June 3rd, 2022 at 16:27, Zack Rusin wrote: > > > >>> In particular: since the driver will ignore the KMS cursor plane > >>> position set by

Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property

2022-06-06 Thread Roman Stratiienko
Hello Jernej, Thank you for having a look. вс, 5 июн. 2022 г. в 23:37, Jernej Škrabec : > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko napisal(a): > > Allwinner DE2 and DE3 hardware support 3 pixel blend modes: > > "None", "Pre-multiplied", "Coverage" > > > > Add the blend

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-06 Thread Simon Ser
On Sunday, June 5th, 2022 at 20:16, Zack Rusin wrote: > > At any rate, I consider broken any driver which exposes a cursor plane, > > then doesn't display it exactly at the CRTC_X/CRTC_Y > > But we do… The cursor is at crtc_x, crtc_y. How do you show the cursor on the host side then? Pretty

[PATCH] drm/bridge: it6505: Power off downstream device in .atomic_enable

2022-06-06 Thread Pin-Yen Lin
Power off the downstream device in .atomic_enable callback, so the external display shows up again after changing resolution. Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream") Signed-off-by: Pin-Yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 3 +++ 1 file

  1   2   >