Re: [PATCH] drm/i915/guc: support v69 in parallel to v70

2022-07-17 Thread Ceraolo Spurio, Daniele
On 7/15/2022 3:54 PM, Daniele Ceraolo Spurio wrote: This patch re-introduces support for GuC v69 in parallel to v70. As this is a quick fix, v69 has been re-introduced as the single "fallback" guc version in case v70 is not available on disk. All v69 specific code has been labeled as such for

Re: [PATCH 4/4] Documentation/gpu/amdgpu/amdgpu_dm: add DM docs for pixel blend mode

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: AMD GPU display manager (DM) maps DRM pixel blend modes (None, Pre-multiplied, Coverage) to MPC hw blocks through blend configuration options. Describe relevant elements and how to set and test them to get the expected DRM blend mode on DCN hw.

Re: [PATCH 3/4] drm/amd/display: add doc entries for MPC blending configuration

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: Describe structs and enums used to set blend mode properties to MPC blocks. Some pieces of information are already available as code comments, and were just formatted. Others were collected and summarised from discusssions on AMD issue tracker[1][2].

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-17 Thread Stephen Rothwell
Hi all, On Mon, 11 Jul 2022 10:05:45 +0200 Christian König wrote: > > Am 11.07.22 um 04:47 schrieb Stephen Rothwell: > > > > Today's linux-next merge of the drm tree got a conflict in: > > > >drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c > > > > between commit: > > > >925b6e59138c

Re: [PATCH 2/4] Documentation/amdgpu/display: add DC color caps info

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: Add details about color correction capabilities and explain a bit about differences between DC hw generations and also how they are mapped between DRM and DC interface. Two schemas for DCN 2.0 and 3.0 (converted to svg from the original png) is included to

Re: [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups

2022-07-17 Thread Michael Schmitz
Hi Geert, On 12/07/22 03:50, Geert Uytterhoeven wrote: Hi all, This patch series contains miscellaneous fixes and cleanups for the Atari frame buffer device driver, which were identified while working on the Atari DRM driver. Most of them have been tested on ARAnyM, and should be

Re: [PATCH 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and can be converted as kernel docs. v2: - rebase to amd-staging-drm-next Reviewed-by:

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-17 Thread Dmitry Osipenko
On 7/15/22 18:58, Christian König wrote: > Am 15.07.22 um 17:36 schrieb Thomas Zimmermann: >> Hi >> >> Am 15.07.22 um 13:15 schrieb Christian König: >>> I've stumbled over this while reviewing patches for DMA-buf and it looks >>> like we completely messed the locking up here. >>> >>> In general

Re: [Intel-gfx] [PULL] drm-intel-fixes

2022-07-17 Thread pr-tracker-bot
The pull request you sent on Sun, 17 Jul 2022 14:59:42 -0400: > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2022-07-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/55ea9bd666887ed4159df38d1494c204246cf2bc Thank you! -- Deet-doot-dot, I am a

[Bug 201957] amdgpu: ring gfx timeout

2022-07-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #83 from Danil (s48g...@gmail.com) --- Log from what I described above - "fixed just by switching to system-terminal(ctrl+alt+f1)", nothing crash even GPU apps keep working, just huge mouse+UI freeze and switching to F1 terminal and

Re: [PATCH] drm/tests: Split up test cases in igt_check_drm_format_min_pitch

2022-07-17 Thread Guenter Roeck
On 7/17/22 11:43, Maíra Canal wrote: The igt_check_drm_format_min_pitch() function had a lot of KUNIT_EXPECT_* calls, all of which ended up allocating and initializing various test assertion structures on the stack. This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, and

[PULL] drm-intel-fixes

2022-07-17 Thread Rodrigo Vivi
Hi Dave and Daniel (and Linus), Our 'dim' flow has a problem with fixes of fixes getting missed. We need to take a look on that later. Meanwhile, please allow me to quickly propagate this fix here upstream. Here goes drm-intel-fixes-2022-07-17: - Fix 32b build Thanks, Rodrigo. The following

Re: [PATCH] drm/i915: Fix 32-bit build

2022-07-17 Thread Vivi, Rodrigo
On Sun, 2022-07-17 at 09:20 -0700, Guenter Roeck wrote: > Commit aff1e0b09b54 ("drm/i915/ttm: fix sg_table construction") > introduces > an additional parameter to i915_rsgt_from_mm_node(). The parameter is > used > to calculate segment_pages. This in turn is used in DIV_ROUND_UP() as > divisor.

Re: [git pull] drm fixes for 5.19-rc7

2022-07-17 Thread Vivi, Rodrigo
On Sat, 2022-07-16 at 15:08 -0700, Linus Torvalds wrote: > On Sat, Jul 16, 2022 at 2:35 PM Linus Torvalds > wrote: > > > > That said, even those type simplifications do not fix the > > fundamental > > issue. That "DIV_ROUND_UP()" still ends up being a 64-bit divide, > > although now it's at

[PATCH] drm/tests: Split up test cases in igt_check_drm_format_min_pitch

2022-07-17 Thread Maíra Canal
The igt_check_drm_format_min_pitch() function had a lot of KUNIT_EXPECT_* calls, all of which ended up allocating and initializing various test assertion structures on the stack. This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, and MIPS architectures, such as:

[PATCH v1 12/12] drm/todo: Add bridge related todo items

2022-07-17 Thread Sam Ravnborg
Add todo in the hope someone will help updating the bridge drivers. v2: - Updated descriptions in todo.rst Signed-off-by: Sam Ravnborg Acked-by: Maxime Ripard Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter ---

[PATCH v1 10/12] drm/omapdrm: Use drm_bridge_funcs.atomic_check

2022-07-17 Thread Sam Ravnborg
Replace the deprecated drm_bridge_funcs.mode_fixup() with drm_bridge_funcs.atomic_check(). drm_bridge_funcs.atomic_check() requires the atomic state operations, update these to the default implementations. Likewise update enable/disable to their atomic variants. With these changes omapdrm now

[PATCH v1 11/12] drm/bridge: Drop drm_bridge_funcs.mode_fixup

2022-07-17 Thread Sam Ravnborg
All users are converted over to drm_bridge_funcs.atomic_check() so it is safe to drop the mode_fixup support. Update the comment for atomic_check with relevant parts from mode_fixup. Signed-off-by: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie

[PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check

2022-07-17 Thread Sam Ravnborg
Replace the deprecated drm_bridge_funcs.mode_fixup() with drm_bridge_funcs.atomic_check(). The driver implements the state operations, so no other changes are required for the replacement. Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Kieran Bingham Cc: linux-renesas-...@vger.kernel.org

[PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup

2022-07-17 Thread Sam Ravnborg
The implementation of drm_bridge_funcs.mode_fixup is optional so there is no need to provide an empty implementation. Drop mtk_hdmi_bridge_mode_fixup() so the driver no longer uses the deprecated drm_bridge_funcs.mode_fixup() operation. Signed-off-by: Sam Ravnborg Cc: Chun-Kuang Hu Cc: Philipp

Re: [PATCH v5 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-17 Thread Maíra Canal
On 7/14/22 21:03, Daniel Latypov wrote: > On Thu, Jul 14, 2022 at 4:51 PM Guenter Roeck wrote: >> >> On Fri, Jul 08, 2022 at 05:30:47PM -0300, Maíra Canal wrote: >>> Considering the current adoption of the KUnit framework, convert the >>> DRM format selftest to the KUnit API. >>> >>> Tested-by:

[PATCH v1 04/12] drm/bridge: Drop drm_bridge_chain_mode_fixup

2022-07-17 Thread Sam Ravnborg
There are no users left of drm_bridge_chain_mode_fixup() and we do not want to have this function available, so drop it. Signed-off-by: Sam Ravnborg Reviewed-by: Maxime Ripard Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel

[PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2022-07-17 Thread Sam Ravnborg
The mode_valid implementation had a call to drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is not allowed to change anything - only to validate the mode. As the next bridge is often/always a connector the call had no effect anyway. So drop it. >From the git history I could

[PATCH v1 05/12] drm/bridge: sii8620: Use drm_bridge_funcs.atomic_check

2022-07-17 Thread Sam Ravnborg
Replace the deprecated drm_bridge_funcs.mode_fixup() with drm_bridge_funcs.atomic_check(). drm_bridge_funcs.atomic_check() requires the atomic state operations, update these to the default implementations. Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc:

[PATCH v1 06/12] drm/bridge: cros-ec-anx7688: Use drm_bridge_funcs.atomic_check

2022-07-17 Thread Sam Ravnborg
Replace the deprecated drm_bridge_funcs.mode_fixup() with drm_bridge_funcs.atomic_check(). drm_bridge_funcs.atomic_check() requires the atomic state operations, update these to the default implementations. Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc:

[PATCH v1 07/12] drm/bridge: tc358767: Use drm_bridge_funcs.atomic_check

2022-07-17 Thread Sam Ravnborg
When atomic_check() is defined, then mode_fixup() is ignored, so it had no effect that drm_bridge_funcs.mode_fixup was assigned. Embed the original implementation in the caller and drop the function. Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent

[PATCH v1 01/12] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2022-07-17 Thread Sam Ravnborg
The atomic variants of enable/disable in drm_bridge_funcs are the preferred operations - introduce these. The ps8640 driver used the non-atomic variants of the drm_bridge_chain_pre_enable/ drm_bridge_chain_post_disable - convert these to the atomic variants. v2: - Init state operations in

[PATCH v1 02/12] drm/bridge: Drop unused drm_bridge_chain functions

2022-07-17 Thread Sam Ravnborg
The drm_bridge_chain_{pre_enable,enable,disable,post_disable} has no users left and we have atomic variants that should be used. Drop them so they do not gain new users. Adjust a few comments to avoid references to the dropped functions. Signed-off-by: Sam Ravnborg Reviewed-by: Maxime Ripard

[PATCH v1 0/12] drm bridge updates

2022-07-17 Thread Sam Ravnborg
This is a collection of bridge patches that I had left unfinished more than a year ago. Now where I have some spare time I dusted them off for review and testing. The patches builds, but has seen no run-time testing. The patches are grouped like this: 1+2: - Updates parade-ps8640 for atomic

Re: [PATCH v2 4/4] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()

2022-07-17 Thread José Expósito
José Expósito wrote: > I already fixed the warning and added the reviewed by tags, however, I > noticed that rebasing the series on the latest drm-misc-next show this > error: > [...] Sorry for the extra email. I forgot to mention that the error is only present in UML. Running in other

Re: [PATCH v2 4/4] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()

2022-07-17 Thread José Expósito
Hi David, On Sat, Jul 16, 2022 at 05:32:51PM +0800, David Gow wrote: > On Sat, Jul 9, 2022 at 7:58 PM José Expósito > wrote: > > > > Extend the existing test cases to test the conversion from XRGB to > > RGB565. > > > > The documentation and the color picker available on [1] are useful > >

[PATCH] drm/i915: Fix 32-bit build

2022-07-17 Thread Guenter Roeck
Commit aff1e0b09b54 ("drm/i915/ttm: fix sg_table construction") introduces an additional parameter to i915_rsgt_from_mm_node(). The parameter is used to calculate segment_pages. This in turn is used in DIV_ROUND_UP() as divisor. So far segment_pages was a constant and handled without divide

Re: [PATCH v1 11/11] drm: Move dri1 core files to drm/dri1

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > To have more of the dri1 specific support in one place move the dri1 > core files to the dri1 folder. > The files continue to be part of the drm module, we just refer to the files > with a folder name. > > Signed-off-by: Sam Ravnborg > --- This patch

Re: [PATCH v1 10/11] drm/dri1: Move Kconfig logic to drm/dri1

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > Move the DRI1 section from drm/Kconfig to a new Kconfig > file that lives in the dri1/ directory. > This isolates more of the DRI1 functionality. > > Signed-off-by: Sam Ravnborg > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier

Re: [PATCH v1 09/11] drm/savage: Move the savage driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez Canillas I wonder if we should just squash patches 03/11 to 09/11 into a single patch.

Re: [PATCH v1 08/11] drm/via: Move the via driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > Used the opportunity to rename the file to via.c to match the > name of the driver. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez

Re: [PATCH v1 07/11] drm/sis: Move the sis driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH v1 06/11] drm/mga: Move the mga driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH v1 06/11] drm/mga: Move the mga driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH v1 05/11] drm/i810: Move the i810 driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH v1 04/11] drm/r128: Move the r128 driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas Ditto here and other patches. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux

Re: [PATCH v1 03/11] drm/tdfx: Move the tdfx driver to drm/dri1/

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg > Suggested-by: Javier Martinez Canillas I believe these should be chronological and so the order inverted. Reviewed-by: Javier Martinez Canillas -- Best

Re: [PATCH v1 02/11] drm: Rename CONFIG_DRM_LEGACY to CONFIG_DRM_DRI1

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote: > The rename is done to make it more obvious what is DRI1 drivers > and what is other type of legacy. > > Signed-off-by: Sam Ravnborg > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH v1 01/11] drm: rename DRIVER_LEGACY to DRIVER_DRI1

2022-07-17 Thread Javier Martinez Canillas
Hello Sam, Thanks a lot for working on this patch-set. On 7/16/22 20:17, Sam Ravnborg wrote: > "legacy" is a general term - be specific and use the term dri1. > The first step is to rename DRIVER_LEGACY to DRIVER_DRI1. > > Suggested-by: Javier Martinez Canillas IIRC it was Thomas who

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-17 Thread kernel test robot
config: loongarch-randconfig-s052-20220715 (https://download.01.org/0day-ci/archive/20220717/202207172035.mterdlaw-...@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

[Bug 201957] amdgpu: ring gfx timeout

2022-07-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #82 from Danil (s48g...@gmail.com) --- Afteer using this PC for few days with AMD Vega 8 (integrated) as main GPU I see no freezes at all. (before in 2021 it was freeze every 10-20 mins so I had to use Nvidia as main GPU) (works with

Re: [PATCH 6/8] dt-bindings: backlight: Update Lee Jones' email address

2022-07-17 Thread Pavel Machek
Hi! > Going forward, I'll be using my kernel.org for upstream work. > Acked-by: Pavel Machek Let me know if you want to take it through the LED tree. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-17 Thread Pavel Machek
Hi! > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-07-17 Thread Sakari Ailus
Folks, > Laurent Pinchart (6): > dt-bindings: media: Add macros for video interface bus types > dt-bindings: Use new video interface bus type macros in examples > ARM: dts: freescale: Use new media bus type macros > ARM: dts: omap: Use new media bus type macros > ARM: dts: renesas: Use