Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Marco Felsch
Hi Adam, sorry for the delay. On 22-08-02, Adam Ford wrote: ... > > > I think that the most important one is the blanking calc. Can you try to > > > revert "drm/bridge: adv7511: Repair bus_flags and bus_format" and check > > > if you can get a output still? Also something to try would be to

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Adam Ford
On Tue, Aug 2, 2022 at 8:51 AM Adam Ford wrote: > > On Tue, Aug 2, 2022 at 7:13 AM Adam Ford wrote: > > > > On Tue, Aug 2, 2022 at 3:08 AM Marco Felsch wrote: > > > > > > Hi Adam, Fabio, > > > > > > On 22-08-01, Adam Ford wrote: > > > > On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > >

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Kevin Brace
Hi Thomas, I am honestly surprised of the e-mail back and forth regarding the mainlining of OpenChrome DRM, but let me state my position. Considering the age of the hardware I am dealing with (i.e., pre-OpenGL 2.x generation 3D engine), I do not anticipate being able to run OpenChrome on

Re: [PATCH 1/7] drm/i915/guc: Add a helper for log buffer size

2022-08-02 Thread John Harrison
On 8/2/2022 10:37, Teres Alexis, Alan Previn wrote: Something minor in comments, so conditional R-B (please fix on the way in or reply to correct me): Reviewed-by: Alan Previn On Wed, 2022-07-27 at 19:20 -0700, Harrison, John C wrote: From: Alan Previn Add a helper to get GuC log buffer

Re: [Intel-gfx] [PATCH 4/7] drm/i915/guc: Record CTB info in error logs

2022-08-02 Thread John Harrison
On 8/2/2022 11:27, Teres Alexis, Alan Previn wrote: One minor NIT (though i hope it could be fixed otw in as it adds a bit of ease-of-log-readibility). That said, everything else looks good. Reviewed-by: Alan Previn On Wed, 2022-07-27 at 19:20 -0700, john.c.harri...@intel.com wrote: From:

Re: [Intel-gfx] [PATCH 5/7] drm/i915/guc: Use streaming loads to speed up dumping the guc log

2022-08-02 Thread John Harrison
On 8/2/2022 11:48, Teres Alexis, Alan Previn wrote: One concern below. Else, nice, simple yet good optimization here. :) In the interest of quicker progression, I will provide a conditional R-B if you can either fix the issue raised below on the way in or provide a reason why that's not an

[PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const()

2022-08-02 Thread Douglas Anderson
As of the commit 1de452a0edda ("regulator: core: Allow drivers to define their init data as const") we no longer need to do copying of regulator bulk data from initdata to something dynamic. Let's take advantage of that. In addition to saving some code, this also moves us to using ARRAY_SIZE() to

[PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling

2022-08-02 Thread Douglas Anderson
The dsi_phy_driver_probe() function has a "goto fail" for no reason. Change it to just always return directly when it sees an error. Make this simpler by leveraging dev_err_probe() which is designed to make code like this shorter / simpler. Signed-off-by: Douglas Anderson --- Changes in v3: -

[PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load

2022-08-02 Thread Douglas Anderson
As of commit 6eabfc018e8d ("regulator: core: Allow specifying an initial load w/ the bulk API") we can now specify the initial load in the bulk data rather than having to manually call regulator_set_load() on each regulator. Let's use it. Signed-off-by: Douglas Anderson --- Changes in v3: -

[PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660

2022-08-02 Thread Douglas Anderson
1 regulators is specified listed but the number 2 is specified. This presumably means we try to get a regulator with no name. Fix it. Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") Signed-off-by: Douglas Anderson --- (no changes since v2) Changes in v2: - ("Fix number of

[PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator

2022-08-02 Thread Douglas Anderson
As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually doing anything useful. Let's remove it. It should be

[PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg

2022-08-02 Thread Douglas Anderson
3 regulators are specified listed but the number 2 is specified. Fix it. Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") Signed-off-by: Douglas Anderson --- (no changes since v2) Changes in v2: - ("Fix number of regulators for msm8996_dsi_cfg") new for v2.

[PATCH v3 0/6] drm/msm/dsi regulator improvements

2022-08-02 Thread Douglas Anderson
The main goal of this series is to make a small dent in cleaning up the way we deal with regulator loads for DSI drivers. As of v3 of this series, the regulator API improvements needed for the later patches in the series are merged into mainline. Thus this series only contains the DSI changes

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gt: document TLB cache invalidation functions

2022-08-02 Thread Niranjana Vishwanathapura
On Fri, Jul 29, 2022 at 09:03:55AM +0200, Mauro Carvalho Chehab wrote: Add a description for the TLB cache invalidation algorithm and for the related kAPI functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Move TLB invalidation to its own file

2022-08-02 Thread Niranjana Vishwanathapura
On Fri, Jul 29, 2022 at 09:03:54AM +0200, Mauro Carvalho Chehab wrote: From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. And looks like, 1. Rename intel_gt_invalidate_tlb() to intel_gt_invalidate_tlb_full() 2.

Re: [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected

2022-08-02 Thread Lyude Paul
On Tue, 2022-07-05 at 08:45 +, Lin, Wayne wrote: > [Public] > > > > > -Original Message- > > From: Lyude Paul > > Sent: Wednesday, June 8, 2022 3:30 AM > > To: dri-devel@lists.freedesktop.org; nouv...@lists.freedesktop.org; amd- > > g...@lists.freedesktop.org > > Cc: Lin, Wayne ;

Re: [RESEND RFC 04/18] drm/display/dp_mst: Call them time slots, not VCPI slots

2022-08-02 Thread Lyude Paul
On Wed, 2022-06-15 at 04:28 +, Lin, Wayne wrote: > [Public] > > Thank you Lyude for addressing this! > > VCPI is also a confusing naming to me at first glance since it stands for > Virtual Channel Payload Identification which is just an ID number ( we can >  look up these payload IDs In

[PATCH] dma-buf: Use dma_fence_unwrap_for_each when importing fences

2022-08-02 Thread Jason Ekstrand
Ever since 68129f431faa ("dma-buf: warn about containers in dma_resv object"), dma_resv_add_shared_fence will warn if you attempt to add a container fence. While most drivers were fine, fences can also be added to a dma_resv via the recently added DMA_BUF_IOCTL_IMPORT_SYNC_FILE. Use

Re: [Intel-gfx] [PATCH 7/7] drm/i915/guc: Reduce spam from error capture

2022-08-02 Thread Teres Alexis, Alan Previn
Reviewed-by: Alan Previn On Wed, 2022-07-27 at 19:20 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Some debug code got left in when the GuC based register save for error > capture was added. Remove that. > > Signed-off-by: John Harrison > --- >

Re: [Intel-gfx] [PATCH 5/7] drm/i915/guc: Use streaming loads to speed up dumping the guc log

2022-08-02 Thread Teres Alexis, Alan Previn
One concern below. Else, nice, simple yet good optimization here. :) In the interest of quicker progression, I will provide a conditional R-B if you can either fix the issue raised below on the way in or provide a reason why that's not an issue: Reviewed-by: Alan Previn On Wed, 2022-07-27 at

Re: [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface

2022-08-02 Thread Rob Clark
On Tue, Aug 2, 2022 at 12:02 AM Dmitry Baryshkov wrote: > > On 30/07/2022 12:17, Akhil P Oommen wrote: > > > > Some clients like adreno gpu driver would like to ensure that its gdsc > > is collapsed at hardware during a gpu reset sequence. This is because it > > has a votable gdsc which could be

Re: [Intel-gfx] [PATCH 4/7] drm/i915/guc: Record CTB info in error logs

2022-08-02 Thread Teres Alexis, Alan Previn
One minor NIT (though i hope it could be fixed otw in as it adds a bit of ease-of-log-readibility). That said, everything else looks good. Reviewed-by: Alan Previn On Wed, 2022-07-27 at 19:20 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > When debugging GuC communication

Re: [PATCH drm-misc-next v7 0/5] drm: rename CMA helpers to DMA helpers

2022-08-02 Thread Sam Ravnborg
Hi Danilo, On Tue, Aug 02, 2022 at 02:04:00AM +0200, Danilo Krummrich wrote: > This patch series renames all CMA helpers to DMA helpers - considering the > hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA > helpers seems to be more applicable. > > Additionally, commit

Re: [PATCH drm-misc-next v7 1/5] drm/fb: remove unused includes of drm_fb_cma_helper.h

2022-08-02 Thread Sam Ravnborg
Hi Danilo, On Tue, Aug 02, 2022 at 02:04:01AM +0200, Danilo Krummrich wrote: > Quite a lot of drivers include the drm_fb_cma_helper.h header file > without actually making use of it's provided API, hence remove those > includes. > > Suggested-by: Sam Ravnborg > Signed-off-by: Danilo Krummrich

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Kevin Brace
Hi Sam, Regarding DRI1 era uAPI, I believe I am handling the matter similar to how Radeon DRM header (include/uapi/drm/radeon_drm.h) handled the matter. The header still contains old DRI1 uAPI calls, and it then adds new KMS generation uAPI calls. At this point, using drm_invalid_op() for

Re: [Intel-gfx] [PATCH 2/7] drm/i915/guc: Fix capture size warning and bump the size

2022-08-02 Thread Teres Alexis, Alan Previn
Straight forward change - LGTM. Reviewed-by: Alan Previn On Wed, 2022-07-27 at 19:20 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > There was a size check to warn if the GuC error state capture buffer > allocation would be too small to fit a reasonable amount of capture >

Re: [PATCH 1/7] drm/i915/guc: Add a helper for log buffer size

2022-08-02 Thread Teres Alexis, Alan Previn
Something minor in comments, so conditional R-B (please fix on the way in or reply to correct me): Reviewed-by: Alan Previn On Wed, 2022-07-27 at 19:20 -0700, Harrison, John C wrote: > From: Alan Previn > > Add a helper to get GuC log buffer size. > > Signed-off-by: Alan Previn >

Re: [PATCH 3/3] drm/amd/display: Fix static declaration follows non-static declaration compiler warn

2022-08-02 Thread Rodrigo Siqueira Jordao
On 2022-08-01 09:52, Imre Deak wrote: Fix the drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:951:13: error: static declaration of ‘get_min_max_dc_plane_scaling’ follows non-static declaration 951 | static void get_min_max_dc_plane_scaling(struct drm_device *dev,

Re: [PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c

2022-08-02 Thread Rodrigo Siqueira Jordao
On 2022-08-01 09:52, Imre Deak wrote: Fix compiler warnings like the following triggered by '-Wmissing-prototypes': CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.o drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous

Re: [PATCH v2 01/29] ACPI: video: Add acpi_video_backlight_use_native() helper

2022-08-02 Thread Daniel Dadap
On 8/2/22 06:31, Hans de Goede wrote: Hi Daniel, On 7/21/22 23:30, Daniel Dadap wrote: On 7/21/22 16:24, Daniel Dadap wrote: On 7/12/22 14:38, Hans de Goede wrote: ATM on x86 laptops where we want userspace to use the acpi_video backlight device we often register both the GPU's native

Re: [PATCH v2 1/3] drm/amd/display: make variables static

2022-08-02 Thread Rodrigo Siqueira Jordao
On 2022-08-02 09:31, André Almeida wrote: Às 22:06 de 29/07/22, Magali Lemes escreveu: As "dcn3_1_soc", "dcn3_15_soc", and "dcn3_16_soc" are not used outside of their corresponding "dcn3*_fpu.c", make them static and remove their extern declaration. Fixes: 26f4712aedbd ("drm/amd/display:

Re: [PATCH] drm/amd/display: remove DML Makefile duplicate lines

2022-08-02 Thread Rodrigo Siqueira Jordao
On 2022-08-02 09:05, Harry Wentland wrote: On 2022-08-02 08:04, Magali Lemes wrote: There are two identical CFLAGS entries for "display_mode_vba_20.o", so remove one of them. Also, as there's already an entry for "display_mode_lib.o" CFLAGS, regardless of CONFIG_DRM_AMD_DC_DCN being defined

Re: [PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-02 Thread Sharma, Shashank
On 8/2/2022 5:58 PM, Michel Dänzer wrote: On 2022-08-02 15:55, Shashank Sharma wrote: This patch adds: - A new input parameter "flags" in the amdgpu_ctx_create2 call. - Some new flags defining workload type hints. - Some change in the caller function of amdgpu_ctx_create2, to accomodate this

Re: [PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-02 Thread Michel Dänzer
On 2022-08-02 15:55, Shashank Sharma wrote: > This patch adds: > - A new input parameter "flags" in the amdgpu_ctx_create2 call. > - Some new flags defining workload type hints. > - Some change in the caller function of amdgpu_ctx_create2, to > accomodate this new parameter. > > The idea is to

[PATCH v4 15/15] drm/msm/gem: Convert to lockdep assert

2022-08-02 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h index 3c6add51d13b..c4844cf3a585 100644 ---

[PATCH v4 09/15] drm/gem: Add LRU/shrinker helper

2022-08-02 Thread Rob Clark
From: Rob Clark Add a simple LRU helper to assist with driver's shrinker implementation. It handles tracking the number of backing pages associated with a given LRU, and provides a helper to implement shrinker_scan. A driver can use multiple LRU instances to track objects in various states, for

[PATCH v4 14/15] drm/msm/gem: Add msm_gem_assert_locked()

2022-08-02 Thread Rob Clark
From: Rob Clark All use of msm_gem_is_locked() is just for WARN_ON()s, so extract out into an msm_gem_assert_locked() patch. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 36 +-- drivers/gpu/drm/msm/msm_gem.h | 8 +++- 2 files changed, 25

[PATCH v4 12/15] drm/msm/gem: Consolidate shrinker trace

2022-08-02 Thread Rob Clark
From: Rob Clark Combine separate trace events for purge vs evict into one. When we add support for purging/evicting active buffers we'll just add more info into this one trace event, rather than adding a bunch more events. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_shrinker.c |

[PATCH v4 11/15] drm/msm/gem: Unpin buffers earlier

2022-08-02 Thread Rob Clark
From: Rob Clark We've already attached the fences, so obj->resv (which shrinker checks) tells us whether they are still active. So we can unpin sooner, before we drop the queue lock. This also avoids the need to grab the obj lock in the retire path, avoiding potential for lock contention

[PATCH v4 13/15] drm/msm/gem: Evict active GEM objects when necessary

2022-08-02 Thread Rob Clark
From: Rob Clark If we are under enough memory pressure, we should stall waiting for active buffers to become idle in order to evict. v2: Check for __GFP_ATOMIC before blocking Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_shrinker.c | 70 +-

[PATCH v4 10/15] drm/msm/gem: Convert to using drm_gem_lru

2022-08-02 Thread Rob Clark
From: Rob Clark This converts over to use the shared GEM LRU/shrinker helpers. Note that it means we are no longer tracking purgeable or willneed buffers that are active separately. But the most recently pinned buffers should be at the tail of the various LRUs, and the shrinker is already

[PATCH v4 08/15] drm/msm/gem: Remove active refcnt

2022-08-02 Thread Rob Clark
From: Rob Clark At this point the pinned refcnt is sufficient, and the shrinker is already prepared to encounter objects which are still active according to fences attached to the resv. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c| 45 ++--

[PATCH v4 06/15] drm/msm/gem: Rename to pin/unpin_pages

2022-08-02 Thread Rob Clark
From: Rob Clark Since that is what these fxns actually do.. they are getting *pinned* pages (as opposed to cases where we need pages, but don't need them pinned, like CPU mappings). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 18 +-

[PATCH v4 04/15] drm/msm/gem: Check for active in shrinker path

2022-08-02 Thread Rob Clark
From: Rob Clark Currently in our shrinker path we shouldn't be encountering anything that is active, but this will change in subsequent patches. So check if there are unsignaled fences. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 10 ++

[PATCH v4 03/15] drm/msm: Split out idr_lock

2022-08-02 Thread Rob Clark
From: Rob Clark Otherwise if we hit reclaim pinning objects in the submit path, we'll be blocking retire_worker trying to free a submit. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- drivers/gpu/drm/msm/msm_gem_submit.c | 10 --

[PATCH v4 07/15] drm/msm/gem: Consolidate pin/unpin paths

2022-08-02 Thread Rob Clark
From: Rob Clark Avoid having multiple spots where we increment/decrement pin_count (and associated LRU updating) Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH v4 05/15] drm/msm/gem: Rename update_inactive

2022-08-02 Thread Rob Clark
From: Rob Clark Really what this is doing is updating various LRU lists. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c

[PATCH v4 02/15] drm/msm: Small submit cleanup

2022-08-02 Thread Rob Clark
From: Rob Clark Move more initialization into submit_create(). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c

[PATCH v4 01/15] drm/msm: Reorder lock vs submit alloc

2022-08-02 Thread Rob Clark
From: Rob Clark This lets us drop the NORETRY. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index

[PATCH v4 00/15] drm+msm: Shrinker and LRU rework

2022-08-02 Thread Rob Clark
From: Rob Clark Unchanged other than small update in 09/15 original description below: This is mostly motivated by getting drm/msm to pass an i-g-t shrinker test that I've been working on. In particular the test creates and cycles between more GEM buffers than what will fit in RAM to force

Re: [PATCH drm-misc-next v7 2/5] drm/fb: rename FB CMA helpers to FB DMA helpers

2022-08-02 Thread Liviu Dudau
On Tue, Aug 02, 2022 at 02:04:02AM +0200, Danilo Krummrich wrote: > Rename "FB CMA" helpers to "FB DMA" helpers - considering the hierarchy > of APIs (mm/cma -> dma -> fb dma) calling them "FB DMA" seems to be > more applicable. > > Besides that, commit e57924d4ae80 ("drm/doc: Task to rename CMA

Re: [PATCH 1/2] drm: Fix vblank refcount during modeset

2022-08-02 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - General] I found out that elsewhere in the drm code (e.g. in drm_atomic_helper.c) expects drm_vblank_get() to fail as part of normal operation. So this patch doesn't seem appropriate anymore and it seems more appropriate to hunt down all the unchecked calls for

Re: [PATCH] drm/drm_edid: Refactor HFVSDB parsing for DSC1.2

2022-08-02 Thread Jani Nikula
On Fri, 22 Jul 2022, Ankit Nautiyal wrote: > DSC capabilities are given in bytes 11-13 of VSDB (i.e. bytes 8-10 of > SCDS). Since minimum length of Data block is 7, all bytes greater than 7 > must be read only after checking the length of the data block. > > This patch adds check for data block

Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-02 Thread Brian Starkey
Hi Olivier, Some comments below as I mentioned off-list. One additional point: some devices need to know if a buffer is protected, so that they can configure registers appropriately to make use of that protected buffer. There was previously a discussion about adding a flag to a dma_buf to

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-08-02 Thread Jani Nikula
On Wed, 27 Jul 2022, Matthieu CHARETTE wrote: > Loading an EDID using drm.edid_firmware parameter makes resume to fail > after firmware cache is being cleaned. This is because edid_load() use a > temporary device to request the firmware. This cause the EDID firmware > not to be cached from

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-02 Thread Thomas Zimmermann
Hi Am 02.08.22 um 15:58 schrieb Jani Nikula: On Fri, 29 Jul 2022, Maxime Ripard wrote: Multiple drivers (meson, vc4) define the analog TV 525-lines and 625-lines modes in the drivers. Since those modes are fairly standards, and that we'll need to use them in more places in the future, let's

Re: [PATCH v15 03/11] drm/edid: Add cea_sad helpers for freq/length

2022-08-02 Thread Jani Nikula
On Wed, 27 Jul 2022, Bo-Chen Chen wrote: > From: Guillaume Ranquet > > This patch adds two helper functions that extract the frequency and word > length from a struct cea_sad. > > For these helper functions new defines are added that help translate the > 'freq' and 'byte2' fields into real

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-02 Thread Jani Nikula
On Fri, 29 Jul 2022, Maxime Ripard wrote: > Multiple drivers (meson, vc4) define the analog TV 525-lines and 625-lines > modes in the drivers. > > Since those modes are fairly standards, and that we'll need to use them in > more places in the future, let's move the meson definition into the >

[PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-02 Thread Shashank Sharma
This patch adds: - A new input parameter "flags" in the amdgpu_ctx_create2 call. - Some new flags defining workload type hints. - Some change in the caller function of amdgpu_ctx_create2, to accomodate this new parameter. The idea is to pass the workload hints while context creation, so that

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Adam Ford
On Tue, Aug 2, 2022 at 7:13 AM Adam Ford wrote: > > On Tue, Aug 2, 2022 at 3:08 AM Marco Felsch wrote: > > > > Hi Adam, Fabio, > > > > On 22-08-01, Adam Ford wrote: > > > On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > > > > > > > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > > >

Re: [PATCH] drm/amd/display: remove DML Makefile duplicate lines

2022-08-02 Thread André Almeida
Às 09:04 de 02/08/22, Magali Lemes escreveu: > There are two identical CFLAGS entries for "display_mode_vba_20.o", so > remove one of them. Also, as there's already an entry for > "display_mode_lib.o" CFLAGS, regardless of CONFIG_DRM_AMD_DC_DCN being > defined or not, remove the one entry between

Re: [PATCH v2 1/3] drm/amd/display: make variables static

2022-08-02 Thread André Almeida
Às 22:06 de 29/07/22, Magali Lemes escreveu: > As "dcn3_1_soc", "dcn3_15_soc", and "dcn3_16_soc" are not used outside > of their corresponding "dcn3*_fpu.c", make them static and remove their > extern declaration. > > Fixes: 26f4712aedbd ("drm/amd/display: move FPU related code from dcn31 to

Re: [PATCH] drm/amd/display: remove DML Makefile duplicate lines

2022-08-02 Thread Harry Wentland
On 2022-08-02 08:04, Magali Lemes wrote: > There are two identical CFLAGS entries for "display_mode_vba_20.o", so > remove one of them. Also, as there's already an entry for > "display_mode_lib.o" CFLAGS, regardless of CONFIG_DRM_AMD_DC_DCN being > defined or not, remove the one entry between

Re: [Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister

2022-08-02 Thread Gwan-gyeong Mun
Hi Jani, Ville and Imre, If there are no problems after reviewing this patch series, could you please merge it? Many thanks, G.G. On 7/22/22 3:51 PM, Andrzej Hajda wrote: Hi Jani, Ville, Arun, This patchset is replacement of patch "drm/i915/display: disable HPD workers before display

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-02 Thread ayaka
Sorry, the previous one contains html data. > On Aug 2, 2022, at 3:33 PM, Tomasz Figa wrote: > > On Mon, Aug 1, 2022 at 8:43 PM ayaka wrote: >> Sent from my iPad On Aug 1, 2022, at 5:46 PM, Tomasz Figa wrote: >>> CAUTION: Email originated externally, do not click links or open >>>

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-02 Thread ayaka
Sent from my iPad > On Aug 2, 2022, at 3:33 PM, Tomasz Figa wrote: > > On Mon, Aug 1, 2022 at 8:43 PM ayaka wrote: >> >> >> >> Sent from my iPad >> On Aug 1, 2022, at 5:46 PM, Tomasz Figa wrote: >>> >>> CAUTION: Email originated externally, do not click links or open >>>

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Adam Ford
On Tue, Aug 2, 2022 at 3:08 AM Marco Felsch wrote: > > Hi Adam, Fabio, > > On 22-08-01, Adam Ford wrote: > > On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > > > > > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > > > > > > > I managed to get my HDMI output working. I had the lanes

[PATCH] drm/amd/display: remove DML Makefile duplicate lines

2022-08-02 Thread Magali Lemes
There are two identical CFLAGS entries for "display_mode_vba_20.o", so remove one of them. Also, as there's already an entry for "display_mode_lib.o" CFLAGS, regardless of CONFIG_DRM_AMD_DC_DCN being defined or not, remove the one entry between CONFIG_DRM_AMD_DC_DCN ifdef guards. Signed-off-by:

[PATCH] drm/gem: Fix GEM handle release errors

2022-08-02 Thread Jeffy Chen
Currently we are assuming a one to one mapping between dmabuf and handle when releasing GEM handles. But that is not always true, since we would create extra handles for the GEM obj in cases like gem_open() and getfb{,2}(). A similar issue was reported at:

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Thomas Zimmermann
Hi Am 02.08.22 um 05:45 schrieb Kevin Brace: Hi Thomas, I hope I am comprehending this right. Yes, I am adding 3 new uAPI calls, not 6 of them. Correspondingly, there are 3 new structs added. That's understood. While I may drop one (unmap uAPI), I personally do not wish to drop the other

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

2022-08-02 Thread Marek Vasut
On 8/1/22 18:32, Rob Herring wrote: On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, document a DT property to select this swap in DT. This can be useful on hardware where such swap happens. We should ensure

Re: [PATCH v2 01/29] ACPI: video: Add acpi_video_backlight_use_native() helper

2022-08-02 Thread Hans de Goede
Hi Daniel, On 7/21/22 23:30, Daniel Dadap wrote: > > On 7/21/22 16:24, Daniel Dadap wrote: >> >> On 7/12/22 14:38, Hans de Goede wrote: >>> ATM on x86 laptops where we want userspace to use the acpi_video backlight >>> device we often register both the GPU's native backlight device and >>>

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Sam Ravnborg
Hi Kevin, > > OpenChrome DDX carries lots of legacy code. > > https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_drm.h?h=main=dc661c59257e855cd9b29c14b91a8ee2d9b86ccb > > There is a requirement to use the same via_drm.h with both DDX and DRM. > Hence, I need to keep a

Re: [PATCH drm-misc-next v7 1/5] drm/fb: remove unused includes of drm_fb_cma_helper.h

2022-08-02 Thread Laurent Pinchart
Hi Danilo, Thank you for the patch. On Tue, Aug 02, 2022 at 02:04:01AM +0200, Danilo Krummrich wrote: > Quite a lot of drivers include the drm_fb_cma_helper.h header file > without actually making use of it's provided API, hence remove those > includes. > > Suggested-by: Sam Ravnborg >

Re: [PATCH v1 08/35] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-08-02 Thread Thomas Zimmermann
Hi Maxime Am 29.07.22 um 18:34 schrieb Maxime Ripard: drm_connector_pick_cmdline_mode() is in charge of finding a proper drm_display_mode from the definition we got in the video= command line argument. Let's add some unit tests to make sure we're not getting any regressions there.

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Marco Felsch
Hi Adam, Fabio, On 22-08-01, Adam Ford wrote: > On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > > > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > > > > > I managed to get my HDMI output working. I had the lanes set to 2 > > > instead of 4. Once I switched to 4-lanes, the monitor

Re: [Intel-gfx] [PATCH v2 09/21] drm/i915/guc: Define CTB based TLB invalidation routines

2022-08-02 Thread Mauro Carvalho Chehab
On Thu, 14 Jul 2022 16:06:28 +0200 Michal Wajdeczko wrote: > On 14.07.2022 14:06, Mauro Carvalho Chehab wrote: > > From: Prathap Kumar Valsan > > > > Add routines to interface with GuC firmware for TLB invalidation. > > > > Signed-off-by: Prathap Kumar Valsan > > Cc: Bruce Chang > > Cc:

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-02 Thread Tomasz Figa
On Mon, Aug 1, 2022 at 8:43 PM ayaka wrote: > > > > Sent from my iPad > > > On Aug 1, 2022, at 5:46 PM, Tomasz Figa wrote: > > > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > >> On Mon,

Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-02 Thread Dmitry Baryshkov
On 30/07/2022 12:17, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen --- drivers/clk/qcom/gpucc-sc7280.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/qcom/gpucc-sc7280.c

Re: [PATCH v3 5/8] drm/msm/a6xx: Ensure CX collapse during gpu recovery

2022-08-02 Thread Dmitry Baryshkov
On 30/07/2022 12:40, Akhil P Oommen wrote: Because there could be transient votes from other drivers/tz/hyp which may keep the cx gdsc enabled, we should poll until cx gdsc collapses. We can use the reset framework to poll for cx gdsc collapse from gpucc clk driver. This feature requires

Re: [PATCH 2/5] clk: qcom: Allow custom reset ops

2022-08-02 Thread Dmitry Baryshkov
On 30/07/2022 12:17, Akhil P Oommen wrote: Add support to allow soc specific clk drivers to specify a custom reset operation. A consumer-driver of the reset framework can call "reset_control_reset()" api to trigger this. Signed-off-by: Akhil P Oommen --- drivers/clk/qcom/reset.c | 6 ++

Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-02 Thread Dmitry Baryshkov
On 30/07/2022 12:17, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen --- drivers/clk/qcom/gpucc-sc7280.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/qcom/gpucc-sc7280.c

Re: [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface

2022-08-02 Thread Dmitry Baryshkov
On 30/07/2022 12:17, Akhil P Oommen wrote: Some clients like adreno gpu driver would like to ensure that its gdsc is collapsed at hardware during a gpu reset sequence. This is because it has a votable gdsc which could be ON due to a vote from another subsystem like tz, hyp etc or due to an

Re: [PATCH] drm/msm/gpu: Drop qos request if devm_devfreq_add_device() fails

2022-08-02 Thread Dmitry Baryshkov
On 08/07/2022 19:26, Bjorn Andersson wrote: In the event that devm_devfreq_add_device() fails the device's qos freq list is left referencing df->idle_freq and df->boost_freq. Attempting to initialize devfreq again after a probe deferral will then cause invalid memory accesses in

Re: [PATCH v2] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-02 Thread Dmitry Baryshkov
On 01/08/2022 23:13, Kuogee Hsieh wrote: Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded