Re: [Linaro-mm-sig] Re: DMA-buf and uncached system memory

2022-08-09 Thread Christian König
Am 09.08.22 um 16:46 schrieb Daniel Vetter: On Mon, Jul 04, 2022 at 03:48:03PM +0200, Christian König wrote: Hi Daniel, Am 25.06.22 um 00:02 schrieb Daniel Vetter: On Thu, Jun 23, 2022 at 01:32:18PM +0200, Christian König wrote: Am 23.06.22 um 13:27 schrieb Daniel Stone: [SNIP] If it's

RE: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge rpm on mmap mappings

2022-08-09 Thread Gupta, Anshuman
> -Original Message- > From: Vivi, Rodrigo > Sent: Tuesday, August 9, 2022 8:36 PM > To: Gupta, Anshuman > Cc: intel-...@lists.freedesktop.org; dan...@ffwll.ch; Wilson, Chris P > ; dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge

Re: [Linaro-mm-sig] Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-09 Thread Chen Jeffy
Hi Christian, On 8/9 星期二 18:18, Christian König wrote: Hi Jeffy, Am 09.08.22 um 12:02 schrieb Chen Jeffy: Hi Christian, On 8/9 星期二 17:08, Christian König wrote: Hi Jeffy, Am 09.08.22 um 09:55 schrieb Christian König: [SNIP] So we are allowing GEM object to have multiple handles, and

[PATCH v4 1/2] dt-bindings: panel-simple-dsi: add Tianma TL057FVXP01

2022-08-09 Thread Julian Braha
Adds the bindings for the Tianma TL057FVXP01 DSI panel, found on the Motorola Moto G6. Signed-off-by: Julian Braha --- v4: Fixed makefile entry. v3: Fixed kconfig dependencies. v2: Fixed accidental whitespace deletion. --- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++

[PATCH 6/7] drm/msm/dp: Don't enable HPD interrupts for edp

2022-08-09 Thread Bjorn Andersson
Most instances where HPD interrupts are masked and unmasked are guareded by the presence of an EDP panel being connected, but not all. Extend this to cover the last few places, as HPD interrupt handling is not used for the EDP case. Signed-off-by: Bjorn Andersson ---

[PATCH 5/7] drm/msm/dp: Implement hpd_notify()

2022-08-09 Thread Bjorn Andersson
The DisplayPort controller's hot-plug mechanism is based on pinmuxing a physical signal no a GPIO pin into the controller. This is not always possible, either because there aren't dedicated GPIOs available or because the hot-plug signal is a virtual notification, in cases such as USB Type-C. For

[PATCH 7/7] drm/msm/dp: HPD handling relates to next_bridge

2022-08-09 Thread Bjorn Andersson
The DisplayPort controller's internal HPD interrupt handling is used for cases where the HPD signal is connected to a GPIO which is pinmuxed into the DisplayPort controller. Most of the logic for enabling and disabling the HPD-related interrupts is conditioned on the presence of an EDP panel, but

[PATCH 4/7] drm/msm/dp: Add SDM845 DisplayPort instance

2022-08-09 Thread Bjorn Andersson
The Qualcomm SDM845 platform has a single DisplayPort controller, with the same design as SC7180, so add support for this by reusing the SC7180 definition. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-09 Thread Bjorn Andersson
Add compatibles for the DisplayPort and Embedded DisplayPort blocks in Qualcomm SDM845 and SC8280XP platforms. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 3/7] drm/msm/dp: Add DP and EDP compatibles for SC8280XP

2022-08-09 Thread Bjorn Andersson
The SC8280XP platform has four DisplayPort controllers, per MDSS instance, all with widebus support. The first two are defined to be DisplayPort only, while the latter pair (of each instance) can be either DisplayPort or Embedded DisplayPort. The two sets are tied to the possible compatibels.

[PATCH 2/7] drm/msm/dp: Stop using DP id as index in desc

2022-08-09 Thread Bjorn Andersson
In the SC8280XP platform there are two identical MDSS instances, each with the same set of DisplayPort instances, at different addresses. By not relying on the index to define the instance id it's possible to describe them both in the same table and hence have a single compatible. While at it,

[PATCH 0/7] drm/msm/dp: Support for external displays

2022-08-09 Thread Bjorn Andersson
Introduce support for DisplayPort on SDM845 and SC8280XP, followed by introduction of drm_bridge based HPD handling. The version of these patches are restarted, as the previous drm_connector_oob_hotplug_event()-based approach was abandoned and this only barely resembles that effort. In this

RE: [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected

2022-08-09 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, August 3, 2022 6:12 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > nouv...@lists.freedesktop.org; amd-...@lists.freedesktop.org > Cc: Ville Syrjälä ; Zuo, Jerry > ; Jani Nikula ; Imre Deak > ; Daniel Vetter ;

Re: [PATCH] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-09 13:44:50) > dp_bridge_disable() is the first step toward tearing down main link. > Its major function is to start transmitting idle pattern to replace > video stream. This patch will check hpd_state to make sure main link > is enabled before commit changes of main

[PATCH] drm/i915/guc/slpc: Allow SLPC to use efficient frequency

2022-08-09 Thread Vinay Belgaumkar
Host Turbo operates at efficient frequency when GT is not idle unless the user or workload has forced it to a higher level. Replicate the same behavior in SLPC by allowing the algorithm to use efficient frequency. We had disabled it during boot due to concerns that it might break kernel ABI for

[Bug 216277] X11 doesn't wait for amdgpu driver to be up

2022-08-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216277 --- Comment #7 from dark_syl...@yahoo.com.ar --- Adding amdgpu to initramfs seems to have workarounded the problem. I have not experienced this problem after it. I can also visibly see the boot process is slightly different (splash becomes

[RFC v3] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions

2022-08-09 Thread Lyude Paul
There's another kind of situation where we could potentially race with nonblocking modesets and MST, especially if we were to only use the locking provided by atomic modesetting: * Display 1 begins as enabled on DP-1 in SST mode * Display 1 switches to MST mode, exposes one sink in MST mode *

Re: [PATCH v2 1/3] drm/dp_mst: add passthrough_aux to struct drm_dp_mst_port

2022-08-09 Thread Lyude Paul
Ah yes of course! Probably should have asked when I gave the r-b :). Also, just so patchwork actually catches it I will say the magic incantation: Reviewed-by: Lyude Paul Do we want to merge just this patch to drm-misc-next, or do you want to merge the whole series through there? If you'd

Re: [PATCH] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-09 Thread Abhinav Kumar
On 8/9/2022 1:44 PM, Kuogee Hsieh wrote: dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-09 Thread Abhinav Kumar
Hi Laurent Thanks for the response. On 8/9/2022 12:40 PM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533 bridge tries to dynamically switch lanes based on the mode by detaching and attaching the mipi dsi

Re: New subsystem for acceleration devices

2022-08-09 Thread Oded Gabbay
On Sun, Aug 7, 2022 at 9:50 AM Oded Gabbay wrote: > > On Fri, Aug 5, 2022 at 6:03 AM Dave Airlie wrote: > > > > On Thu, 4 Aug 2022 at 17:44, Oded Gabbay wrote: > > > > > > On Thu, Aug 4, 2022 at 2:54 AM Dave Airlie wrote: > > > > > > > > On Thu, 4 Aug 2022 at 06:21, Oded Gabbay wrote: > > > >

[PATCH] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-09 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to

Re: [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface

2022-08-09 Thread Bjorn Andersson
On Sat 30 Jul 04:17 CDT 2022, Akhil P Oommen wrote: > > Some clients like adreno gpu driver would like to ensure that its gdsc > is collapsed at hardware during a gpu reset sequence. This is because it > has a votable gdsc which could be ON due to a vote from another subsystem > like tz, hyp etc

Re: [PATCH 3/3] drm/bridge: tc358767: disable main link PHYs on main link disable

2022-08-09 Thread Marek Vasut
On 7/6/22 15:42, Robert Foss wrote: On Wed, 6 Jul 2022 at 15:28, Lucas Stach wrote: Disable the main link PHYs and put them into reset when the main link is disabled. When the PHYs stay enabled while the rest of the DP link circuits are disabled there is some noise on the data lanes, which

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-09 Thread Florian Fainelli
Hallo Stefan, On 8/9/22 13:16, Stefan Wahren wrote: Hi Florian, Am 05.08.22 um 01:11 schrieb Florian Fainelli: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-09 Thread Stefan Wahren
Hi Florian, Am 05.08.22 um 01:11 schrieb Florian Fainelli: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm. That power domain is shared with the VEC

Re: [PATCH v3 1/2] dt-bindings: panel-simple-dsi: add Tianma TL057FVXP01

2022-08-09 Thread Rob Herring
On Mon, 08 Aug 2022 17:37:25 -0400, Julian Braha wrote: > Adds the bindings for the Tianma TL057FVXP01 DSI panel, > found on the Motorola Moto G6. > > Signed-off-by: Julian Braha > --- > v3: > Fixed kconfig dependencies. > > v2: > Fixed accidental whitespace deletion. > --- >

Re: [PATCH 3/3] dt-bindings: display: simple-framebuffer: Drop Bartlomiej Zolnierkiewicz

2022-08-09 Thread Rob Herring
On Mon, 08 Aug 2022 13:15:26 +0300, Krzysztof Kozlowski wrote: > Bartlomiej's Samsung email address is not working since around last > year and there was no follow up patch take over of the drivers, so drop > the email from maintainers. > > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by:

Re: [PATCH v16 1/8] dt-bindings: mediatek,dp: Add Display Port binding

2022-08-09 Thread Rob Herring
On Fri, 05 Aug 2022 18:14:52 +0800, Bo-Chen Chen wrote: > From: Markus Schneider-Pargmann > > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The controller

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-09 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: > adv7533 bridge tries to dynamically switch lanes based on the > mode by detaching and attaching the mipi dsi device. > > This approach is incorrect because as per the DSI spec the > number of

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-08-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #38 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Harald Judt from comment #36) > Maybe these are also relevant, they occur right after resuming, before all > those other messages: > [drm] Fence fallback timer expired on

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-08-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #37 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- Hmm. I get the impression that those are /probably/ collateral damage from the underlying issue of something not initializing properly during resume from S4. -- You

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-09 Thread Florian Fainelli
On 8/4/22 16:11, Florian Fainelli wrote: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm. That power domain is shared with the VEC block, so even if

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-08-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #36 from Harald Judt (h.j...@gmx.at) --- Maybe these are also relevant, they occur right after resuming, before all those other messages: [drm] Fence fallback timer expired on ring sdma0 [drm] Fence fallback timer expired on ring

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-08-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #35 from Harald Judt (h.j...@gmx.at) --- I have not had time yet to try any patches, but here are more detailed dmesg messages when things get awry after resuming from hibernation and vt-switching (see symptoms described above). Maybe

Re: [PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-08-09 Thread Daniel Vetter
On Tue, Jul 05, 2022 at 01:33:51PM +0200, Christian König wrote: > Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: > > Use ww_acquire_fini() in the error code paths. Otherwise lockdep > > thinks that lock is held when lock's memory is freed after the > > drm_gem_lock_reservations() error. The

Re: [PATCH v7 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-08-09 Thread Daniel Vetter
On Thu, Jun 30, 2022 at 11:04:04PM +0300, Dmitry Osipenko wrote: > Use ww_acquire_fini() in the error code paths. Otherwise lockdep > thinks that lock is held when lock's memory is freed after the > drm_gem_lock_reservations() error. The ww_acquire_context needs to be > annotated as "released",

Re: [PATCH v7 1/2] drm/shmem-helper: Add missing vunmap on error

2022-08-09 Thread Daniel Vetter
On Thu, Jun 30, 2022 at 11:00:57PM +0300, Dmitry Osipenko wrote: > The vmapping of dma-buf may succeed, but DRM SHMEM rejects the IOMEM > mapping, and thus, drm_gem_shmem_vmap_locked() should unvmap the IOMEM > before erroring out. > > Cc: sta...@vger.kernel.org > Fixes: 49a3f51dfeee ("drm/gem:

Re: [PATCH v7 2/2] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table()

2022-08-09 Thread Daniel Vetter
On Thu, Jun 30, 2022 at 11:00:58PM +0300, Dmitry Osipenko wrote: > drm_gem_shmem_get_sg_table() never returns NULL on error, but a ERR_PTR. > Correct the doc comment which says that it returns NULL on error. > > Acked-by: Thomas Zimmermann > Signed-off-by: Dmitry Osipenko > --- >

Re: [PATCH 0/1] [RFC] drm/fourcc: Add new unsigned R16_UINT/RG1616_UINT formats

2022-08-09 Thread Jason Ekstrand
On Fri, 2022-07-15 at 11:20 +0100, Dennis Tsiang wrote: > On 30/06/2022 08:47, Pekka Paalanen wrote: > > On Wed, 29 Jun 2022 14:53:49 + > > Simon Ser wrote: > > > > > On Wednesday, June 29th, 2022 at 16:46, Dennis Tsiang > > > wrote: > > > > > > > Thanks for your comments. This is not

Re: tiny drm driver for NOKIA-5110 LCD

2022-08-09 Thread Andy Shevchenko
On Tue, Aug 9, 2022 at 6:14 PM Aliliche Larbi wrote: > > Good morning sir, > > I am developing a linux driver for the nokia 5110 lcd(monochrome), > I would like to know if I can use the drm API or tiny drm for this lcd. > I'm writing to you because I saw your commit in /staging/fbtft/TODO > where

Re: [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-09 Thread Daniel Vetter
[Catching up on mails] Did you see the feedback form Steven from tracing side of things? Does this version have that taken into account already? I think once we have that and acks from dyndbg maintainers then I think we should just land this and polish from there? Maybe some acks from drm

Re: [PATCH v2 1/3] drm/dp_mst: add passthrough_aux to struct drm_dp_mst_port

2022-08-09 Thread Hamza Mahfooz
Hey Lyude, On 2022-08-05 17:17, Lyude Paul wrote: lgtm! Any chance you can apply this to drm-misc-next? Reviewed-by: Lyude Paul On Fri, 2022-08-05 at 17:13 -0400, Hamza Mahfooz wrote: Currently, there is no way to identify if DSC pass-through can be enabled and what aux DSC pass-through

Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge rpm on mmap mappings

2022-08-09 Thread Rodrigo Vivi
On Mon, Aug 08, 2022 at 04:05:55PM +0530, Anshuman Gupta wrote: > As per PCIe Spec Section 5.3, > When a Type 1 Function associated with a Switch/Root > Port (a “virtual bridge”) is in a non-D0 power state, > it will emulate the behavior of a conventional PCI bridge > in its handling of Memory,

Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2022-08-09 Thread Daniel Vetter
On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > The DRM fbdev emulation layer does not support pushing back > > changes to fb_var_screeninfo to KMS. > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > >

Re: DMA-buf and uncached system memory

2022-08-09 Thread Rob Clark
On Mon, Feb 15, 2021 at 12:58 AM Christian König wrote: > > Hi guys, > > we are currently working an Freesync and direct scan out from system > memory on AMD APUs in A+A laptops. > > On problem we stumbled over is that our display hardware needs to scan > out from uncached system memory and we

Re: [Linaro-mm-sig] Re: DMA-buf and uncached system memory

2022-08-09 Thread Daniel Vetter
On Mon, Jul 04, 2022 at 03:48:03PM +0200, Christian König wrote: > Hi Daniel, > > Am 25.06.22 um 00:02 schrieb Daniel Vetter: > > On Thu, Jun 23, 2022 at 01:32:18PM +0200, Christian König wrote: > > > Am 23.06.22 um 13:27 schrieb Daniel Stone: > > > > [SNIP] > > > > If it's really your belief

Re: [RFC PATCH 3/5] drm/amdgpu: Allow explicit sync for VM ops.

2022-08-09 Thread Daniel Vetter
[Back from vacations and work change and out sick and absolutely everything else going wrong] On Mon, Jul 04, 2022 at 03:37:43PM +0200, Christian König wrote: > Hey Daniel, > > Am 26.06.22 um 00:45 schrieb Daniel Vetter: > > [SNIP] > > I think we should highlight a bit more that for explicitly

Re: New subsystem for acceleration devices

2022-08-09 Thread Jason Gunthorpe
On Tue, Aug 09, 2022 at 02:46:36PM +0200, Arnd Bergmann wrote: > On Tue, Aug 9, 2022 at 2:18 PM Jason Gunthorpe wrote: > > On Tue, Aug 09, 2022 at 10:32:27AM +0200, Arnd Bergmann wrote: > > > On Tue, Aug 9, 2022 at 10:04 AM Christoph Hellwig > > > wrote: > > > > > > I think for devices with

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-09 Thread Olivier Masse
Hi Brian, > > + > > + rmem->ops = _dma_ops; > > + pr_info("Reserved memory: DMA buf secure pool %s at > > %pa, size %ld MiB\n", > > + secure_data[secure_data_count].name, > > + >base, (unsigned long)rmem->size / > > SZ_1M); > > nit:

Re: [PATCH] drivers:gpu:drm:amd:amdgpu:amdgpu_cs.c:fix a potential use-after-free

2022-08-09 Thread Christian König
Am 28.07.22 um 14:12 schrieb Wentao_Liang: in line 1535, "dma_fence_put(fence);" drop the reference to fence and may cause fence to be released. However, fence is used subsequently in line 1542 "fence->error". This may result in an use-after-free bug. It can be fixed by recording fence->error

Re: [PATCH v7 07/13] mfd: mt6370: Add MediaTek MT6370 support

2022-08-09 Thread Lee Jones
On Fri, 05 Aug 2022, ChiaEn Wu wrote: > From: ChiYuan Huang > > This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a > SubPMIC consisting of a single cell battery charger with ADC monitoring, > RGB LEDs, dual channel flashlight, WLED backlight driver, display bias > voltage

Re: [PATCH v7 06/13] dt-bindings: mfd: Add MediaTek MT6370

2022-08-09 Thread Lee Jones
On Fri, 05 Aug 2022, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add MediaTek MT6370 binding documentation. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: ChiYuan Huang > Signed-off-by: ChiaEn Wu > --- > .../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 >

Re: New subsystem for acceleration devices

2022-08-09 Thread Arnd Bergmann
On Tue, Aug 9, 2022 at 2:18 PM Jason Gunthorpe wrote: > On Tue, Aug 09, 2022 at 10:32:27AM +0200, Arnd Bergmann wrote: > > On Tue, Aug 9, 2022 at 10:04 AM Christoph Hellwig > > wrote: > > > > I think for devices with hardware MMU contexts you actually want to > > bind the context to a

Re: New subsystem for acceleration devices

2022-08-09 Thread Jason Gunthorpe
On Mon, Aug 08, 2022 at 11:26:11PM +0300, Oded Gabbay wrote: > So if you want a common uAPI and a common userspace library to use it, > you need to expose the same device character files for every device, > regardless of the driver. e.g. you need all devices to be called > /dev/accelX and not

Re: [Linaro-mm-sig] [PATCH v2 2/5] drm/gem: Take reservation lock for vmap/vunmap operations

2022-08-09 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: The new common dma-buf locking convention will require buffer importers to hold the reservation lock around mapping operations. Make DRM GEM core to take the lock around the vmapping operations and update QXL and i915 drivers to use the locked

Re: New subsystem for acceleration devices

2022-08-09 Thread Jason Gunthorpe
On Tue, Aug 09, 2022 at 10:32:27AM +0200, Arnd Bergmann wrote: > On Tue, Aug 9, 2022 at 10:04 AM Christoph Hellwig wrote: > > On Tue, Aug 09, 2022 at 08:23:27AM +0200, Greg Kroah-Hartman wrote: > > > > This is different from the number of FDs pointing at the struct file. > > > > Userpsace can

Re: [Linaro-mm-sig] [PATCH v2 1/5] dma-buf: Add _unlocked postfix to function names

2022-08-09 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: Add _unlocked postfix to the dma-buf API function names in a preparation to move all non-dynamic dma-buf users over to the dynamic locking specification. This patch only renames API functions, preparing drivers to the common locking convention. Later

Re: [PATCH v5] drm/i915: stop using swiotlb

2022-08-09 Thread Tvrtko Ursulin
On 08/08/2022 16:48, Hellstrom, Thomas wrote: Hi, [back from vacation] On Tue, 2022-07-26 at 16:39 +0100, Robert Beckett wrote: Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace

Re: [PATCH v2 11/39] drm/i915: i915_gem_ttm_pm.c: fix kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:11:59AM +0100, Mauro Carvalho Chehab wrote: > The documentation for the flags field is missing there. It sounds > that some last-time change converted some bools into flags, but > the kernel-doc change didn't follow it. > > Fix those warnings: > >

Re: [Intel-gfx] [PATCH v2 35/39] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:23AM +0100, Mauro Carvalho Chehab wrote: > There are other files with kernel-doc markups: > > $ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/) > >kernel-doc-files > $ for i in $(cat kernel-doc-files); do if [ "$(git grep $i >

Re: [Linaro-mm-sig] Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-09 Thread Christian König
Hi Jeffy, Am 09.08.22 um 12:02 schrieb Chen Jeffy: Hi Christian, On 8/9 星期二 17:08, Christian König wrote: Hi Jeffy, Am 09.08.22 um 09:55 schrieb Christian König: [SNIP] So we are allowing GEM object to have multiple handles, and GEM object could have at most one dma-buf, doesn't that

Re: [PATCH v2 39/39] drm/i915: add GuC functions to the documentation

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:27AM +0100, Mauro Carvalho Chehab wrote: > Currently, functions inside GuC aren't presented as part of the > GuC documentation. > > Add them. > > Signed-off-by: Mauro Carvalho Chehab could be squashed to the other guc patch, but anyways: Reviewed-by: Rodrigo Vivi

Re: [PATCH v2 31/39] docs: gpu: i915.rst: GuC: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:19AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GuC kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi >

Re: [Intel-gfx] [PATCH v2 38/39] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:26AM +0100, Mauro Carvalho Chehab wrote: > The intel_gt_pm.h file contains some convenient macros to be used > in GT code in order to get/put runtime PM references and for > checking them. > > Add descriptions based on the ones at intel_wakeref.h and >

Re: [PATCH v2 36/39] drm/i915 i915_gem_object_types.h: document struct i915_lut_handle

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:24AM +0100, Mauro Carvalho Chehab wrote: > commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr") > added a rbtree list to allow searching for obj/ctx. > > Document it. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To

Re: [Intel-gfx] [PATCH v2 37/39] drm/i915: document struct drm_i915_gem_object

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:25AM +0100, Mauro Carvalho Chehab wrote: > This is a large struct used to describe gem objects. It is > currently partially documented. Finish its documentation, filling > the gaps from git logs. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi >

Re: [Intel-gfx] [PATCH v2 33/39] docs: gpu: i915.rst: PM: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:21AM +0100, Mauro Carvalho Chehab wrote: > Both intel_runtime_pm.h and intel_pm.c contains kAPI for > runtime PM. So, add them to the documentation. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large

Re: [Intel-gfx] [PATCH v2 34/39] docs: gpu: i915.rst: GEM/TTM: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:22AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GEM/TTM kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo

Re: [Linaro-mm-sig] Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-09 Thread Chen Jeffy
Hi Christian, On 8/9 星期二 17:08, Christian König wrote: Hi Jeffy, Am 09.08.22 um 09:55 schrieb Christian König: [SNIP] So we are allowing GEM object to have multiple handles, and GEM object could have at most one dma-buf, doesn't that means that dma-buf could map to multiple handles?

Re: [Intel-gfx] [PATCH v2 30/39] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:18AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GT kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid

Re: [Intel-gfx] [PATCH v2 19/39] drm/i915: i915_gem_region.h: fix i915_gem_apply_to_region_ops doc

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:07AM +0100, Mauro Carvalho Chehab wrote: > The kernel-doc markup for i915_gem_apply_to_region_ops() has some > issues: > > 1. The field should be marked as @process_obj; > 2. The callback parameters aren't document properly, as sphinx >will consider them to be

Re: [Intel-gfx] [PATCH v2 29/39] docs: gpu: i915.rst: display: add kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:17AM +0100, Mauro Carvalho Chehab wrote: > There are several documented kAPI at the display side that > aren't currently part of the docs. Add them, as this allows > identifying issues with badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab same here,

Re: [PATCH v3 2/2] drm/tidss: Add support for AM625 DSS

2022-08-09 Thread Tomi Valkeinen
On 09/08/2022 12:21, Aradhya Bhatia wrote: Hi Tomi, On 09-Aug-22 12:01, Tomi Valkeinen wrote: On 09/08/2022 09:08, Aradhya Bhatia wrote: Hi Tomi, On 28-Jul-22 17:34, Tomi Valkeinen wrote: On 27/06/2022 18:12, Aradhya Bhatia wrote: Add support for the DSS IP on TI's new AM625 SoC in the

Re: [PATCH v2 32/39] docs: gpu: i915.rst: GVT: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:20AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GVT kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab I haven't checked if these

[PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-08-09 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in

Re: [Intel-gfx] [PATCH v2 18/39] drm/i915: intel_pm.c: fix some ascii artwork at kernel-doc

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:06AM +0100, Mauro Carvalho Chehab wrote: > Preserving ascii artwork on kernel-docs is tricky, as it needs > to respect both the Sphinx rules and be properly parsed by > kernel-doc script. > > The Sphinx syntax require code-blocks, which is: > > :: > >

Re: [PATCH v5 6/6] drm/ttm: Switch to using the new res callback

2022-08-09 Thread Christian König
Am 09.08.22 um 11:22 schrieb Arunpravin Paneer Selvam: Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) We need to move parts of this patch earlier or the i915 will

Re: [Intel-gfx] [PATCH v2 15/39] drm/i915: intel_dp_link_training.c: fix kernel-doc markup

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:03AM +0100, Mauro Carvalho Chehab wrote: > The return code table is not properly marked, causing warnings > and being badly parsed by Sphinx: > > Documentation/gpu/i915:130: > ./drivers/gpu/drm/i915/display/intel_dp_link_training.c:183: WARNING: Block > quote

Re: [PATCH 4/8] drm/tidss: Add support for Dual Link LVDS Bus Format

2022-08-09 Thread Tomi Valkeinen
On 09/08/2022 12:06, Aradhya Bhatia wrote: Even in DT, the dss port (for OLDI) connects to the panel port's endpoint directly. Even in cases of dual link or cloning, it's only a singular remote-to-endpoint connection between the (OLDI) VP and the panel port. Hence the requirement of the

[PATCH v5 3/6] drm/amdgpu: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from backend drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 38 +++

[PATCH v5 4/6] drm/i915: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. v3: move the bits that are specific to buddy_man (Matthew) v4: consider the block size /range (Matthew) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam

[PATCH v5 5/6] drm/nouveau: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching the start offset from struct ttm_resource. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/nouveau/nouveau_mem.c | 29 +++

[PATCH v5 6/6] drm/ttm: Switch to using the new res callback

2022-08-09 Thread Arunpravin Paneer Selvam
Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 45

[PATCH v5 2/6] drm/ttm: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback functions to ttm range manager fetching start offset from drm mm range allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/ttm/ttm_range_manager.c | 33 + 1 file

[PATCH v5 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-09 Thread Arunpravin Paneer Selvam
We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename "intersect" to "intersects" (Matthew) v4: move !place check to the

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Takashi Iwai
On Tue, 09 Aug 2022 11:13:46 +0200, Thomas Zimmermann wrote: > > Hi > > Am 09.08.22 um 11:03 schrieb Takashi Iwai: > > On Tue, 09 Aug 2022 09:41:19 +0200, > > Thomas Zimmermann wrote: > >> > >> Hi > >> > >> Am 09.08.22 um 09:15 schrieb Takashi Iwai: > >>> On Tue, 09 Aug 2022 09:13:16 +0200, >

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Thomas Zimmermann
Hi Am 09.08.22 um 11:03 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:41:19 +0200, Thomas Zimmermann wrote: Hi Am 09.08.22 um 09:15 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:13:16 +0200, Thomas Zimmermann wrote: Hi Am 04.08.22 um 09:58 schrieb Takashi Iwai: At both suspend and

Re: [Linaro-mm-sig] Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-09 Thread Christian König
Hi Jeffy, Am 09.08.22 um 09:55 schrieb Christian König: [SNIP] So we are allowing GEM object to have multiple handles, and GEM object could have at most one dma-buf, doesn't that means that dma-buf could map to multiple handles? No, at least not for the same GEM file private. That's

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Takashi Iwai
On Tue, 09 Aug 2022 09:41:19 +0200, Thomas Zimmermann wrote: > > Hi > > Am 09.08.22 um 09:15 schrieb Takashi Iwai: > > On Tue, 09 Aug 2022 09:13:16 +0200, > > Thomas Zimmermann wrote: > >> > >> Hi > >> > >> Am 04.08.22 um 09:58 schrieb Takashi Iwai: > >>> At both suspend and disconnect, we

Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-09 Thread Chen Jeffy
Hi Christian, On 8/9 星期二 15:55, Christian König wrote: Am 09.08.22 um 03:28 schrieb Chen Jeffy: Hi Christian, On 8/9 星期二 2:03, Christian König wrote: Hi Jeffy, Am 08.08.22 um 05:51 schrieb Chen Jeffy: Hi Christian, Thanks for your reply, and sorry i didn't make it clear. On 8/8 星期一 0:52,

Re: New subsystem for acceleration devices

2022-08-09 Thread Greg Kroah-Hartman
On Tue, Aug 09, 2022 at 01:04:15AM -0700, Christoph Hellwig wrote: > On Tue, Aug 09, 2022 at 08:23:27AM +0200, Greg Kroah-Hartman wrote: > > Based on the number of drivers that I see submitted weekly that try to > > restrict their open call to just one user by using atomic variables or > > other

Re: New subsystem for acceleration devices

2022-08-09 Thread Arnd Bergmann
On Tue, Aug 9, 2022 at 10:04 AM Christoph Hellwig wrote: > On Tue, Aug 09, 2022 at 08:23:27AM +0200, Greg Kroah-Hartman wrote: > > > This is different from the number of FDs pointing at the struct file. > > > Userpsace can open a HW state and point a lot of FDs at it, that is > > > userspace's

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

2022-08-09 Thread Gwan-gyeong Mun
On 8/4/22 12:06 PM, Andi Shyti wrote: Hi Jani, It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source

Re: [PATCH v2 2/6] drm/ttm: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
On 8/8/2022 5:00 PM, Christian König wrote: Am 25.07.22 um 13:42 schrieb Arunpravin Paneer Selvam: Implemented a new intersect and compatible callback functions to ttm range manager fetching start offset from drm mm range allocator. Signed-off-by: Christian König Signed-off-by:

Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-09 Thread Christian König
Am 09.08.22 um 03:28 schrieb Chen Jeffy: Hi Christian, On 8/9 星期二 2:03, Christian König wrote: Hi Jeffy, Am 08.08.22 um 05:51 schrieb Chen Jeffy: Hi Christian, Thanks for your reply, and sorry i didn't make it clear. On 8/8 星期一 0:52, Christian König wrote: Am 03.08.22 um 10:32 schrieb

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Thomas Zimmermann
Hi Am 09.08.22 um 09:15 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:13:16 +0200, Thomas Zimmermann wrote: Hi Am 04.08.22 um 09:58 schrieb Takashi Iwai: At both suspend and disconnect, we should rather cancel the pending URBs immediately. For the suspend case, the display will be turned

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Takashi Iwai
On Tue, 09 Aug 2022 09:13:16 +0200, Thomas Zimmermann wrote: > > Hi > > Am 04.08.22 um 09:58 schrieb Takashi Iwai: > > At both suspend and disconnect, we should rather cancel the pending > > URBs immediately. For the suspend case, the display will be turned > > off, so it makes no sense to

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Thomas Zimmermann
Hi Am 04.08.22 um 09:58 schrieb Takashi Iwai: At both suspend and disconnect, we should rather cancel the pending URBs immediately. For the suspend case, the display will be turned off, so it makes no sense to process the rendering. And for the disconnect case, the device may be no longer

Re: [EXT] Re: [PATCH 2/3] dt-bindings: reserved-memory: add linaro,secure-heap

2022-08-09 Thread Olivier Masse
Hi Brian, It was part of a discussion during a Devicetree evolution meeting with Bill Mills from Linaro. I've done some modification to OPTEE OS and OPTEE TEST to support dma buf: OPTEE OS https://github.com/OP-TEE/optee_os/commit/eb108a04369fbfaf60c03c0e00bbe9489a761c69

  1   2   >