[PATCH v4 1/7] drm/msm: Remove unnecessary pm_runtime_get/put

2022-08-17 Thread Akhil P Oommen
We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/msm_ringbuffer.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v4 4/7] drm/msm: Fix cx collapse issue during recovery

2022-08-17 Thread Akhil P Oommen
There are some hardware logic under CX domain. For a successful recovery, we should ensure cx headswitch collapses to ensure all the stale states are cleard out. This is especially true to for a6xx family where we can GMU co-processor. Currently, cx doesn't collapse due to a devlink between gpu

[PATCH v4 3/7] drm/msm: Correct pm_runtime votes in recover worker

2022-08-17 Thread Akhil P Oommen
In the scenario where there is one a single submit which is hung, gpu is power collapsed when it is retired. Because of this, by the time we call reover(), gpu state would be already clear. Fix this by correctly managing the pm runtime votes. Signed-off-by: Akhil P Oommen --- (no changes since

[PATCH v2 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface

2022-08-17 Thread Akhil P Oommen
Some clients like adreno gpu driver would like to ensure that its gdsc is collapsed at hardware during a gpu reset sequence. This is because it has a votable gdsc which could be ON due to a vote from another subsystem like tz, hyp etc or due to an internal hardware signal. To allow this, gpucc

[PATCH v2 5/5] arm64: dts: qcom: sc7280: Add Reset support for gpu

2022-08-17 Thread Akhil P Oommen
Add support for Reset using GPUCC driver for GPU. This helps to ensure that GPU state is reset by making sure that CX head switch is collapsed. Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v4 7/7] drm/msm/a6xx: Handle GMU prepare-slumber hfi failure

2022-08-17 Thread Akhil P Oommen
When prepare-slumber hfi fails, we should follow a6xx_gmu_force_off() sequence. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c

[PATCH v4 5/7] drm/msm/a6xx: Ensure CX collapse during gpu recovery

2022-08-17 Thread Akhil P Oommen
Because there could be transient votes from other drivers/tz/hyp which may keep the cx gdsc enabled, we should poll until cx gdsc collapses. We can use the reset framework to poll for cx gdsc collapse from gpucc clk driver. This feature requires support from the platform's gpucc driver.

[PATCH v4 6/7] drm/msm/a6xx: Improve gpu recovery sequence

2022-08-17 Thread Akhil P Oommen
We can do a few more things to improve our chance at a successful gpu recovery, especially during a hangcheck timeout: 1. Halt CP and GMU core 2. Do RBBM GBIF HALT sequence 3. Do a soft reset of GPU core Signed-off-by: Akhil P Oommen --- (no changes since v1)

[PATCH v4 0/7] Improve GPU Recovery

2022-08-17 Thread Akhil P Oommen
Recently, I debugged a few device crashes which occured during recovery after a hangcheck timeout. It looks like there are a few things we can do to improve our chance at a successful gpu recovery. First one is to ensure that CX GDSC collapses which clears the internal states in gpu's CX

[PATCH v2 1/5] dt-bindings: clk: qcom: Support gpu cx gdsc reset

2022-08-17 Thread Akhil P Oommen
Add necessary definitions in gpucc bindings to ensure gpu cx gdsc collapse through 'reset' framework for SC7280. Signed-off-by: Akhil P Oommen Acked-by: Krzysztof Kozlowski --- (no changes since v1) include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v2 4/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-17 Thread Akhil P Oommen
Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen --- Changes in v2: - Minor update to use the updated custom reset ops implementation drivers/clk/qcom/gpucc-sc7280.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v4 2/7] drm/msm: Take single rpm refcount on behalf of all submits

2022-08-17 Thread Akhil P Oommen
Instead of separate refcount for each submit, take single rpm refcount on behalf of all the submits. This makes it easier to drop the rpm refcount during recovery in an upcoming patch. Signed-off-by: Akhil P Oommen --- (no changes since v3) Changes in v3: - New patch

[PATCH v2 3/5] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-08-17 Thread Akhil P Oommen
Add a reset op compatible function to poll for gdsc collapse. Signed-off-by: Akhil P Oommen --- Changes in v2: - Minor update to function prototype drivers/clk/qcom/gdsc.c | 23 +++ drivers/clk/qcom/gdsc.h | 7 +++ 2 files changed, 26 insertions(+), 4 deletions(-)

Re: [PATCH] drm/bridge: ps8640: Add double reset T4 and T5 to power-on sequence

2022-08-17 Thread Hsin-Yi Wang
On Thu, Aug 18, 2022 at 11:19 AM Rock Chiu wrote: > > How does T4/T5 impact the real case? We talked previously the T4/T5 > shouldn't cause user impact. > Do we have testing data from ODM? > Please leave comments below the previous comment's headline. I'm confused. The reason I upstreamed this

[PATCH -next] drm/amd/display: remove unneeded semicolon

2022-08-17 Thread Yang Li
Semicolon is not required after curly braces. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1918 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pull] amdgpu, amdkfd drm-fixes-6.0

2022-08-17 Thread Alex Deucher
Hi Dave, Daniel, A bit bigger than normal, but this is several weeks of fixes since I was out of the office and then digging out once I got back. Mainly fixes for new IPs that were added in 6.0. The following changes since commit 5493ee1919eae4f49d62276cf5986b7f7c7aa8f6: Merge tag

Re: [PATCH] drm/bridge: ps8640: Add double reset T4 and T5 to power-on sequence

2022-08-17 Thread Hsin-Yi Wang
On Thu, Aug 18, 2022 at 6:54 AM Doug Anderson wrote: > > Hi, > > On Mon, Aug 15, 2022 at 2:39 AM Hsin-Yi Wang wrote: > > > > The double reset power-on sequence is a workaround for the hardware > > flaw in some chip that SPI Clock output glitch and cause internal MPU > > unable to read firmware

Re: build failure of next-20220817 for amdgpu

2022-08-17 Thread Randy Dunlap
On 8/17/22 19:01, Alex Deucher wrote: > On Wed, Aug 17, 2022 at 6:03 PM Sudip Mukherjee (Codethink) > wrote: >> >> Hi All, >> >> Not sure if it has been reported, build of next-20220817 fails with the >> error: >> >> ERROR: modpost: "cpu

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-17 Thread Kees Cook
On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: > Hi Kees, > > would you mind taking a look at this patch? Hi! Thanks for the heads-up! > > Thanks, > Andi > > On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gyeong Mun wrote: > > It moves overflows_type utility macro into overflow

Re: [PATCH -next] drm/bridge: Add missing clk_disable_unprepare() in analogix_dp_resume()

2022-08-17 Thread Brian Norris
On Wed, Aug 17, 2022 at 01:34:13PM -0700, Brian Norris wrote: > On Mon, Aug 15, 2022 at 11:46 PM Zhang Zekun wrote: > > > > Add the missing clk_disable_unprepare() before return from > > analogix_dp_resume() in the error handling case. > > > > Fixes: 211f276ed3d9 ("drm: bridge: analogix/dp: add

Re: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46

2022-08-17 Thread Doug Anderson
Hi, On Sun, Aug 14, 2022 at 11:46 PM Maxime Ripard wrote: > > On Fri, Jul 29, 2022 at 12:57:40PM -0700, Doug Anderson wrote: > > Hi, > > > > On Fri, Jul 29, 2022 at 9:41 AM Maxime Ripard wrote: > > > > > > On Fri, Jul 29, 2022 at 07:50:20AM -0700, Doug Anderson wrote: > > > > On Fri, Jul 29,

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Noralf Trønnes
Den 17.08.2022 15.11, skrev Noralf Trønnes: > > > Den 17.08.2022 13.46, skrev Maxime Ripard: >> On Tue, Aug 16, 2022 at 09:35:24PM +0200, Noralf Trønnes wrote: >>> Den 16.08.2022 11.49, skrev Maxime Ripard: On Tue, Aug 16, 2022 at 11:42:20AM +0200, Noralf Trønnes wrote: > Den

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-08-17 Thread Dmitry Osipenko
On 8/18/22 01:57, Dmitry Osipenko wrote: > On 8/15/22 18:54, Dmitry Osipenko wrote: >> On 8/15/22 17:57, Dmitry Osipenko wrote: >>> On 8/15/22 16:53, Christian König wrote: Am 15.08.22 um 15:45 schrieb Dmitry Osipenko: > [SNIP] >> Well that comment sounds like KVM is doing the right

[PATCH 1/3] drm: Don't reserve minors for control nodes

2022-08-17 Thread Michał Winiarski
Control nodes are no longer with us. While we still need to preserve render nodes numbering, there's no need to reserve the range formerly used for control. Let's repurpose it to be used by primary and remove control remains from the code entirely. References: commit 0d49f303e8a7 ("drm: remove

[PATCH 3/3] drm: Use mutex for minors

2022-08-17 Thread Michał Winiarski
Operating on drm minor is not done in IRQ context, which means that we could safely downgrade to regular non-irq spinlock. But we can also go further and drop the idr_preload tricks by just using a mutex. Signed-off-by: Michał Winiarski --- drivers/gpu/drm/drm_drv.c | 31

[PATCH 0/3] drm: Use full allocated minor range for DRM

2022-08-17 Thread Michał Winiarski
64 DRM device nodes is not enough for everyone. Upgrade it to 512K (which definitely is more than enough). Additionally - one minor tweak around minor IDR locking. Michał Winiarski (3): drm: Don't reserve minors for control nodes drm: Expand max DRM device number to full MINORBITS drm: Use

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-17 Thread Andi Shyti
Hi Kees, would you mind taking a look at this patch? Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gyeong Mun wrote: > It moves overflows_type utility macro into overflow header from i915_utils > header. The overflows_type can be used to catch the truncation between data > types.

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-08-17 Thread Dmitry Osipenko
On 8/15/22 18:54, Dmitry Osipenko wrote: > On 8/15/22 17:57, Dmitry Osipenko wrote: >> On 8/15/22 16:53, Christian König wrote: >>> Am 15.08.22 um 15:45 schrieb Dmitry Osipenko: [SNIP] > Well that comment sounds like KVM is doing the right thing, so I'm > wondering what exactly is

Re: [PATCH] drm/bridge: ps8640: Add double reset T4 and T5 to power-on sequence

2022-08-17 Thread Doug Anderson
Hi, On Mon, Aug 15, 2022 at 2:39 AM Hsin-Yi Wang wrote: > > The double reset power-on sequence is a workaround for the hardware > flaw in some chip that SPI Clock output glitch and cause internal MPU > unable to read firmware correctly. The sequence is suggested in ps8640 > application note. > >

Re: [PATCH v1 1/1] kfd: fixed memleak about release topology

2022-08-17 Thread Felix Kuehling
Am 2022-07-15 um 04:07 schrieb ZhiJie.zhang: memleak will happend that reload module due to ignore kfree when release topology Signed-off-by: ZhiJie.zhang --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] drm/ttm: prevent grabbing page references

2022-08-17 Thread Dmitry Osipenko
On 8/15/22 16:08, Christian König wrote: > TTM owns the pages it uses for backing buffer objects with system > memory. Because of this it is absolutely illegal to mess around with > the reference count of those pages. > > So make sure that nobody ever tries to grab an extra reference on > pages

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-17 Thread Stephen Rothwell
failure. > > > > > > > > I will be happy to test any patch or provide any extra log if needed. > > > > > > I have reverted that commit in today's linux-next. > > > > I have removed that revert. Sudip, can you recheck when linux-next is > > released, please? > > The build failure is not seen with next-20220817. Excellent, thanks. -- Cheers, Stephen Rothwell pgpQG482fU9Uv.pgp Description: OpenPGP digital signature

Re: [PATCH 1/6] drm/ttm: Add usage to ttm_validate_buffer.

2022-08-17 Thread Felix Kuehling
Am 2022-08-12 um 21:27 schrieb Bas Nieuwenhuizen: This way callsites can choose between READ/BOOKKEEP reservations. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +++--

build failure of next-20220817 for amdgpu

2022-08-17 Thread Sudip Mukherjee (Codethink)
Hi All, Not sure if it has been reported, build of next-20220817 fails with the error: ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Trying to do a git bisect to find out the offending commit. I will be happy to test any patch or provide any

[PATCH v2 2/2] drm/cmdline-parser: Use assert when needed

2022-08-17 Thread Michał Winiarski
Expecting to observe a specific value, when the function responsible for setting the value has failed will lead to extra noise in test output. Use assert when the situation calls for it. Also - very small tidying up around the changed areas (whitespace). v2: Leave out the locals (drm_connector is

[PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-17 Thread Michał Winiarski
Negative tests can be expressed as a single parameterized test case, which highlights that we're following the same test logic (passing invalid cmdline and expecting drm_mode_parse_command_line_for_connector to fail), which improves readability. v2: s/negative/invalid to be consistent with other

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-17 Thread Mikhail Gavrilov
On Wed, Aug 17, 2022 at 11:43 PM Maíra Canal wrote: > > Hi Mikhail, > > Looks like 45ecaea738830b9d521c93520c8f201359dcbd95 ("drm/sched: Partial > revert of 'drm/sched: Keep s_fence->parent pointer'") introduced the > error. Try reverting it and check if the use-after-free still happens. Thanks,

Re: [PATCH] drm/msm/dsi: Set panel orientation when directly connected

2022-08-17 Thread Doug Anderson
Hi, On Wed, Jul 20, 2022 at 3:42 PM Doug Anderson wrote: > > Hi, > > On Wed, Jul 20, 2022 at 1:46 PM Rob Clark wrote: > > > > On Fri, Jul 8, 2022 at 8:25 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote: > > > > > > > > Set the panel

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-17 Thread Sudip Mukherjee
> pass-through during mode validation") > > > And, reverting that commit has fixed the build failure. > > > > > > I will be happy to test any patch or provide any extra log if needed. > > > > I have reverted that commit in today's linux-next. > > I have removed that revert. Sudip, can you recheck when linux-next is > released, please? The build failure is not seen with next-20220817. -- Regards Sudip

Re: [PATCH v2 01/29] ACPI: video: Add acpi_video_backlight_use_native() helper

2022-08-17 Thread Daniel Dadap
On 8/17/22 10:05 AM, Hans de Goede wrote: Hi Daniel, On 8/2/22 18:49, Daniel Dadap wrote: On 8/2/22 06:31, Hans de Goede wrote: Hi Daniel, On 7/21/22 23:30, Daniel Dadap wrote: On 7/21/22 16:24, Daniel Dadap wrote: On 7/12/22 14:38, Hans de Goede wrote: ATM on x86 laptops where we want

[RFC v4 17/17] drm/display/dp_mst: Move all payload info into the atomic state

2022-08-17 Thread Lyude Paul
Now that we've finally gotten rid of the non-atomic MST users leftover in the kernel, we can finally get rid of all of the legacy payload code we have and move as much as possible into the MST atomic state structs. The main purpose of this is to make the MST code a lot less confusing to work on,

[RFC v4 16/17] drm/radeon: Drop legacy MST support

2022-08-17 Thread Lyude Paul
Right now, radeon is technically the only non-atomic driver still making use of the MST helpers - and thus the final user of all of the legacy MST helpers. Originally I was going to look into seeing if we could move legacy MST into the radeon driver itself, however: * SI and CIK both can use

[RFC v4 09/17] drm/display/dp_mst: Don't open code modeset checks for releasing time slots

2022-08-17 Thread Lyude Paul
I'm not sure why, but at the time I originally wrote the find/release time slot helpers I thought we should avoid keeping modeset tracking out of the MST helpers. In retrospect though there's no actual good reason to do this, and the logic has ended up being identical across all the drivers using

[RFC v4 15/17] drm/display/dp_mst: Maintain time slot allocations when deleting payloads

2022-08-17 Thread Lyude Paul
Currently, we set drm_dp_atomic_payload->time_slots to 0 in order to indicate that we're about to delete a payload in the current atomic state. Since we're going to be dropping all of the legacy code for handling the payload table however, we need to be able to ensure that we still keep track of

[RFC v4 14/17] drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work

2022-08-17 Thread Lyude Paul
We want to start cutting down on all of the places that we use port validation, so that ports may be removed from the topology as quickly as possible to minimize the number of errors we run into as a result of being out of sync with the current topology status. This isn't a very typical scenario

[RFC v4 13/17] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions

2022-08-17 Thread Lyude Paul
There's another kind of situation where we could potentially race with nonblocking modesets and MST, especially if we were to only use the locking provided by atomic modesetting: * Display 1 begins as enabled on DP-1 in SST mode * Display 1 switches to MST mode, exposes one sink in MST mode *

[RFC v4 11/17] drm/nouveau/kms: Cache DP encoders in nouveau_connector

2022-08-17 Thread Lyude Paul
Post-NV50, the only kind of encoder you'll find for DP connectors on Nvidia GPUs are SORs (serial output resources). Because SORs have fixed associations with their connectors, we can correctly assume that any DP connector on a nvidia GPU will have exactly one SOR encoder routed to it for

[RFC v4 10/17] drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots()

2022-08-17 Thread Lyude Paul
Currently with the MST helpers we avoid releasing payloads _and_ avoid pulling in the MST state if there aren't any actual payload changes. While we want to keep the first step, we need to now make sure that we're always pulling in the MST state on all modesets that can modify payloads - even if

[RFC v4 06/17] drm/display/dp_mst: Add some missing kdocs for atomic MST structs

2022-08-17 Thread Lyude Paul
Since we're about to start adding some stuff here, we may as well fill in any missing documentation that we forgot to write. Signed-off-by: Lyude Paul Cc: Wayne Lin Cc: Ville Syrjälä Cc: Fangzhi Zuo Cc: Jani Nikula Cc: Imre Deak Cc: Daniel Vetter Cc: Sean Paul Acked-by: Jani Nikula ---

[RFC v4 12/17] drm/nouveau/kms: Pull mst state in for all modesets

2022-08-17 Thread Lyude Paul
Since we're going to be relying on atomic locking for payloads now (and the MST mgr needs to track CRTCs), pull in the topology state for all modesets in nv50_msto_atomic_check(). Signed-off-by: Lyude Paul Acked-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- 1 file

[RFC v4 08/17] drm/display/dp_mst: Add nonblocking helpers for DP MST

2022-08-17 Thread Lyude Paul
As Daniel Vetter pointed out, if we only use the atomic modesetting locks with MST it's technically possible for a driver with non-blocking modesets to race when it comes to MST displays - as we make the mistake of not doing our own CRTC commit tracking in the topology_state object. This could

[RFC v4 07/17] drm/display/dp_mst: Add helper for finding payloads in atomic MST state

2022-08-17 Thread Lyude Paul
We already open-code this quite often, and will be iterating through payloads even more once we've moved all of the payload tracking into the atomic state. So, let's add a helper for doing this. Signed-off-by: Lyude Paul Cc: Wayne Lin Cc: Ville Syrjälä Cc: Fangzhi Zuo Cc: Jani Nikula Cc:

[RFC v4 05/17] drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots()

2022-08-17 Thread Lyude Paul
For some reason we mention returning 0 if "slots have been added back to drm_dp_mst_topology_state->avail_slots". This is totally misleading, avail_slots is simply for figuring out the total number of slots available in total on the topology and has no relation to the current payload allocations.

[RFC v4 04/17] drm/display/dp_mst: Call them time slots, not VCPI slots

2022-08-17 Thread Lyude Paul
VCPI is only sort of the correct term here, originally the majority of this code simply referred to timeslots vaguely as "slots" - and since I started working on it and adding atomic functionality, the name "VCPI slots" has been used to represent time slots. Now that we actually have consistent

[RFC v4 03/17] drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation

2022-08-17 Thread Lyude Paul
In retrospect, the name I chose for this originally is confusing, as there's a lot more info in here then just the VCPI. This really should be called a payload. Let's make it more obvious that this is meant to be related to the atomic state and is about payloads by renaming it to

[RFC v4 01/17] drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table)

2022-08-17 Thread Lyude Paul
Just to make this more clear to outside contributors that these are DC-specific structs, as this also threw me into a loop a number of times before I figured out the purpose of this. Signed-off-by: Lyude Paul Cc: Wayne Lin Cc: Fangzhi Zuo Acked-by: Jani Nikula ---

[RFC v4 02/17] drm/amdgpu/dm/mst: Rename get_payload_table()

2022-08-17 Thread Lyude Paul
This function isn't too confusing if you see the comment around the call-site for it, but if you don't then it's not at all obvious this is meant to copy DRM's payload table over to DC's internal state structs. Seeing this function before finding that comment definitely threw me into a loop a few

[RFC v4 00/17] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only

2022-08-17 Thread Lyude Paul
For quite a while we've been carrying around a lot of legacy modesetting code in the MST helpers that has been rather annoying to keep around, and very often gets in the way of trying to implement additional functionality in MST such as fallback link rate retraining, dynamic BPC management and DSC

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-17 Thread Maíra Canal
On 8/17/22 14:44, Mikhail Gavrilov wrote: On Wed, Aug 17, 2022 at 9:08 PM Melissa Wen wrote: Hi Mikhail, IIUC, you got this second user-after-free by applying the first version of Maíra's patch, right? So, that version was adding another unbalanced unlock to the cs ioctl flow, but it was

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Lyude Paul
Adding Mark Pearson from Lenovo to this, Mark for reference the original patch is here: https://patchwork.freedesktop.org/patch/497807/?series=107312=1 Comments from me down below On Wed, 2022-08-17 at 09:02 +0800, Kai-Heng Feng wrote: > On Wed, Aug 17, 2022 at 2:24 AM Lyude Paul wrote: > > >

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-17 Thread Mikhail Gavrilov
On Wed, Aug 17, 2022 at 9:08 PM Melissa Wen wrote: > > Hi Mikhail, > > IIUC, you got this second user-after-free by applying the first version > of Maíra's patch, right? So, that version was adding another unbalanced > unlock to the cs ioctl flow, but it was solved in the latest version, > that

Re: [PATCH v2 16/29] ACPI: video: Add Nvidia WMI EC brightness control detection

2022-08-17 Thread Daniel Dadap
On 8/17/22 7:22 AM, Hans de Goede wrote: Hi Daniel, On 7/15/22 13:59, Hans de Goede wrote: Hi Daniel, On 7/12/22 22:13, Daniel Dadap wrote: Thanks, Hans: On 7/12/22 14:38, Hans de Goede wrote: On some new laptop designs a new Nvidia specific WMI interface is present which gives info about

Re: [PATCH v2 4/7] regulator: core: Allow specifying an initial load w/ the bulk API

2022-08-17 Thread Yongqin Liu
Hi, Douglas On Wed, 17 Aug 2022 at 22:26, Doug Anderson wrote: > > Hi, > > On Tue, Aug 16, 2022 at 5:58 AM Yongqin Liu wrote: > > > > HI, Douglas > > > > With this change, I get one kernel panic with my hikey960 > > android-mainline based Android build, > > if it's reverted, then the build

[linux-next:master] BUILD SUCCESS WITH WARNING 95d10484d66e54d5c01e36389e9318221fb8f60b

2022-08-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 95d10484d66e54d5c01e36389e9318221fb8f60b Add linux-next specific files for 20220817 Warning reports: https://lore.kernel.org/linux-doc/202208162058.7appivkl-...@intel.com https

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-17 Thread Lucas Stach
Am Mittwoch, dem 17.08.2022 um 10:29 -0400 schrieb Nicolas Dufresne: > Hi Folks, > > Le mardi 16 août 2022 à 11:20 +, Olivier Masse a écrit : > > Hi Brian, > > > > > > On ven., 2022-08-12 at 17:39 +0100, Brian Starkey wrote: > > > Caution: EXT Ema > > > > > [...] > > > > > > >

[PATCH 3/4] vfio_pci: Do not open code pci_try_reset_function()

2022-08-17 Thread Jason Gunthorpe
FLR triggered by an emulated config space write should not behave differently from a FLR triggered by VFIO_DEVICE_RESET, currently the config space path misses the power management. Consolidate all the call sites to invoke a single function. Signed-off-by: Jason Gunthorpe ---

[PATCH 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-08-17 Thread Jason Gunthorpe
dma-buf has become a way to safely acquire a handle to non-struct page memory that can still have lifetime controlled by the exporter. Notably RDMA can now import dma-buf FDs and build them into MRs which allows for PCI P2P operations. Extend this to allow vfio-pci to export MMIO memory from PCI

[PATCH 2/4] vfio: Add vfio_device_get()

2022-08-17 Thread Jason Gunthorpe
To increment a reference the caller already holds. Export vfio_device_put() to pair with it. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 3 ++- include/linux/vfio.h | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/vfio_main.c

[PATCH 0/4] Allow MMIO regions to be exported through dma-buf

2022-08-17 Thread Jason Gunthorpe
dma-buf has become a way to safely acquire a handle to non-struct page memory that can still have lifetime controlled by the exporter. Notably RDMA can now import dma-buf FDs and build them into MRs which allows for PCI P2P operations. Extend this to allow vfio-pci to export MMIO memory from PCI

[PATCH 1/4] dma-buf: Add dma_buf_try_get()

2022-08-17 Thread Jason Gunthorpe
Used to increment the refcount of the dma buf's struct file, only if the refcount is not zero. Useful to allow the struct file's lifetime to control the lifetime of the dmabuf while still letting the driver to keep track of created dmabufs. Signed-off-by: Jason Gunthorpe ---

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-17 Thread Melissa Wen
On 08/17, Mikhail Gavrilov wrote: > On Mon, Aug 15, 2022 at 3:37 PM Mikhail Gavrilov > wrote: > > > > Thanks, I tested this patch. > > But with this patch use-after-free problem happening in another place: > > Does anyone have an idea why the second use-after-free happened? > From the trace I

Re: [PATCH v2 01/29] ACPI: video: Add acpi_video_backlight_use_native() helper

2022-08-17 Thread Hans de Goede
Hi Daniel, On 8/2/22 18:49, Daniel Dadap wrote: > On 8/2/22 06:31, Hans de Goede wrote: >> Hi Daniel, >> >> On 7/21/22 23:30, Daniel Dadap wrote: >>> On 7/21/22 16:24, Daniel Dadap wrote: On 7/12/22 14:38, Hans de Goede wrote: > ATM on x86 laptops where we want userspace to use the

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-17 Thread Olivier Masse
+Cyrille Hi Nicolas, On mer., 2022-08-17 at 10:29 -0400, Nicolas Dufresne wrote: > Caution: EXT Email > > Hi Folks, > > Le mardi 16 août 2022 à 11:20 +, Olivier Masse a écrit : > > Hi Brian, > > > > > > On ven., 2022-08-12 at 17:39 +0100, Brian Starkey wrote: > > > Caution: EXT Ema > > >

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-17 Thread Nicolas Dufresne
Hi Folks, Le mardi 16 août 2022 à 11:20 +, Olivier Masse a écrit : > Hi Brian, > > > On ven., 2022-08-12 at 17:39 +0100, Brian Starkey wrote: > > Caution: EXT Ema > > [...] > > > > Interesting, that's not how the devices I've worked on operated. > > > > Are you saying that you have to

Re: [PATCH v2 4/7] regulator: core: Allow specifying an initial load w/ the bulk API

2022-08-17 Thread Doug Anderson
Hi, On Tue, Aug 16, 2022 at 5:58 AM Yongqin Liu wrote: > > HI, Douglas > > With this change, I get one kernel panic with my hikey960 > android-mainline based Android build, > if it's reverted, then the build could boot to the home screen successfully. > From the log information I shared here,

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-17 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Aug 17, 2022 at 3:15 PM Maxime Ripard wrote: > On Wed, Aug 17, 2022 at 10:51:55AM +0200, Geert Uytterhoeven wrote: > > On Wed, Aug 17, 2022 at 9:54 AM Maxime Ripard wrote: > > > On Tue, Aug 16, 2022 at 05:00:38PM +0200, Geert Uytterhoeven wrote: > > > > On Tue, Aug 16, 2022

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Aug 17, 2022 at 3:19 PM Maxime Ripard wrote: > On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > > On Wed, Aug 17, 2022

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-17 Thread Brian Starkey
On Tue, Aug 16, 2022 at 11:20:50AM +, Olivier Masse wrote: > On ven., 2022-08-12 at 17:39 +0100, Brian Starkey wrote: > > On Mon, Aug 08, 2022 at 02:39:53PM +, Olivier Masse wrote: > > > On ven., 2022-08-05 at 16:41 +0100, Brian Starkey wrote: > > > > On Fri, Aug 05, 2022 at 03:53:28PM

Re: [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-08-17 Thread Rob Clark
On Wed, Aug 17, 2022 at 2:57 AM Christian König wrote: > > > > Am 16.08.22 um 19:29 schrieb Rob Clark: > > On Tue, Aug 16, 2022 at 9:51 AM Christian König > > wrote: > >> Am 16.08.22 um 16:26 schrieb Rob Clark: > >>> On Tue, Aug 16, 2022 at 1:27 AM Christian König > >>> wrote: > Am

[PATCH 2/3] drm: rcar-du: Fix r8a779a0 color issue.

2022-08-17 Thread Tomi Valkeinen
From: Tomi Valkeinen The rcar DU driver on r8a779a0 has a bug causing some specific colors getting converted to transparent colors, which then (usually) show as black pixels on the screen. The reason seems to be that the driver sets PnMR_SPIM_ALP bit in PnMR.SPIM field, which is an illegal

[PATCH 1/3] drm: rcar-du: remove unnecessary include

2022-08-17 Thread Tomi Valkeinen
From: Tomi Valkeinen rcar_du_regs.h is not needed by rcar_du_drv.c so drop the include. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Maxime Ripard
On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wrote: > > > > On Wed, Aug 17,

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-17 Thread Maxime Ripard
On Wed, Aug 17, 2022 at 10:51:55AM +0200, Geert Uytterhoeven wrote: > On Wed, Aug 17, 2022 at 9:54 AM Maxime Ripard wrote: > > On Tue, Aug 16, 2022 at 05:00:38PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Aug 16, 2022 at 3:26 PM Maxime Ripard wrote: > > > > On Fri, Aug 12, 2022 at 03:18:58PM

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Noralf Trønnes
Den 17.08.2022 13.46, skrev Maxime Ripard: > On Tue, Aug 16, 2022 at 09:35:24PM +0200, Noralf Trønnes wrote: >> Den 16.08.2022 11.49, skrev Maxime Ripard: >>> On Tue, Aug 16, 2022 at 11:42:20AM +0200, Noralf Trønnes wrote: Den 16.08.2022 10.26, skrev Maxime Ripard: > Hi, > > On

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wrote: > > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > > On Tue, Aug 16, 2022

Re: [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-08-17 Thread Hans de Goede
Hi, On 7/20/22 18:46, Alex Deucher wrote: > On Wed, Jul 20, 2022 at 12:44 PM Alex Deucher wrote: >> >> On Tue, Jul 12, 2022 at 3:39 PM Hans de Goede wrote: >>> >>> Before this commit when we want userspace to use the acpi_video backlight >>> device we register both the GPU's native backlight

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Ville Syrjälä
On Wed, Aug 17, 2022 at 08:15:58PM +0800, Kai-Heng Feng wrote: > On Wed, Aug 17, 2022 at 7:59 PM Ville Syrjälä > wrote: > > [snipped] > > > I had a quick trawl through some Windows stuff for this and > > it does seem to do a few extra checks: > > - platform must be TGL-H (nothing else has the

Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h

2022-08-17 Thread Marc Zyngier
On Tue, 16 Aug 2022 18:28:04 +0100, Robin Murphy wrote: > > The iommu-dma layer is now mostly encapsulated by iommu_dma_ops, with > only a couple more public interfaces left pertaining to MSI integration. > Since these depend on the main IOMMU API header anyway, move their > declarations there,

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 7:59 PM Ville Syrjälä wrote: [snipped] > I had a quick trawl through some Windows stuff for this and > it does seem to do a few extra checks: > - platform must be TGL-H (nothing else has the DPin stuff I guess) > - OpRegion header must indicate dGPU presence Is the dGPU

Re: [PATCH] drm/radeon: add a force flush to delay work when radeon

2022-08-17 Thread Christian König
Am 17.08.22 um 09:31 schrieb 李真能: 在 2022/8/15 21:12, Christian König 写道: Am 15.08.22 um 09:34 schrieb 李真能: 在 2022/8/12 18:55, Christian König 写道: Am 11.08.22 um 09:25 schrieb Zhenneng Li: Although radeon card fence and wait for gpu to finish processing current batch rings, there is still a

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Maxime Ripard
On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > > > > On Tue, Aug 16,

Re: [PATCH] drm/i915: Fix all occurences of the "the the" typo

2022-08-17 Thread Jani Nikula
On Tue, 16 Aug 2022, Bo Liu wrote: > There is an unexpected word "the" in the file i915_irq.c, > fix it. > > Signed-off-by: Bo Liu Thanks for the patch, pushed to drm-intel-next. BR, Jani. > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-08-17 Thread Christian König
Am 16.08.22 um 19:29 schrieb Rob Clark: On Tue, Aug 16, 2022 at 9:51 AM Christian König wrote: Am 16.08.22 um 16:26 schrieb Rob Clark: On Tue, Aug 16, 2022 at 1:27 AM Christian König wrote: Am 15.08.22 um 23:15 schrieb Rob Clark: From: Rob Clark This is a fairly narrowly focused

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wrote: > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > > > Either you

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-17 Thread Maxime Ripard
On Tue, Aug 16, 2022 at 05:00:38PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, Aug 16, 2022 at 3:26 PM Maxime Ripard wrote: > > On Fri, Aug 12, 2022 at 03:18:58PM +0200, Geert Uytterhoeven wrote: > > > On Fri, Jul 29, 2022 at 6:35 PM Maxime Ripard wrote: > > > > Multiple drivers

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Maxime Ripard
On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > > Either you have to add them here (e.g. "hd720p50" and > > > > > > >

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Geert Uytterhoeven
Hi Maxime, On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > Either you have to add them here (e.g. "hd720p50" and "hd720p60"), > > > > > > or > > > > > > handle them through "@". The latter would impact

Re: [PATCH] drm/i915: Fix random -ENOSPC eviction errors due to locked vma objects

2022-08-17 Thread Thomas Hellström
On Wed, 2022-08-17 at 09:55 +0300, Sviatoslav Peleshko wrote: > The i915_gem_object_trylock we had in the grab_vma() makes it return > false > when the vma->obj is already locked. In this case we'll skip this vma > during eviction, and eventually might be forced to return -ENOSPC > even > though

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Geert Uytterhoeven
On Wed, Aug 17, 2022 at 9:31 AM Geert Uytterhoeven wrote: > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > > Either you have to add them here (e.g. "hd720p50" and > > > > > > > "hd720p60"), or > > > > > >

Re: [PATCH] drm/radeon: add a force flush to delay work when radeon

2022-08-17 Thread 李真能
在 2022/8/15 21:12, Christian König 写道: Am 15.08.22 um 09:34 schrieb 李真能: 在 2022/8/12 18:55, Christian König 写道: Am 11.08.22 um 09:25 schrieb Zhenneng Li: Although radeon card fence and wait for gpu to finish processing current batch rings, there is still a corner case that radeon lockup

  1   2   >