[PATCH] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188

2022-09-22 Thread xinlei.lee
From: xinlei lee Add dt-binding documentation of dpi for MediaTek MT8188 SoC. Signed-off-by: xinlei lee --- Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-22 Thread Dixit, Ashutosh
On Thu, 22 Sep 2022 19:51:45 -0700, Dixit, Ashutosh wrote: > > On Thu, 22 Sep 2022 00:13:00 -0700, Gupta, Anshuman wrote: > > > > Hi Anshuman, > > > > +static ssize_t > > > +hwm_power1_max_interval_store(struct device *dev, > > > + struct device_attribute *attr, > > > +

Re: [PATCH v1] drivers/amd/kv_dpm: check the return value of amdgpu_kv_smc_bapm_enable

2022-09-22 Thread Lazar, Lijo
On 9/23/2022 1:36 AM, Li Zhong wrote: Check the return value of amdgpu_kv_smc_bapm_enable() and log the error when it fails. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-22 Thread Dixit, Ashutosh
On Thu, 22 Sep 2022 00:13:00 -0700, Gupta, Anshuman wrote: > Hi Anshuman, > > +static ssize_t > > +hwm_power1_max_interval_store(struct device *dev, > > + struct device_attribute *attr, > > + const char *buf, size_t count) > > +{ > > + struct

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-22 Thread Dixit, Ashutosh
On Thu, 22 Sep 2022 00:08:46 -0700, Gupta, Anshuman wrote: > Hi Anshuman, > On 9/21/2022 8:23 PM, Nilawar, Badal wrote: > > > > On 21-09-2022 17:15, Gupta, Anshuman wrote: > >> > >>> +static int > >>> +hwm_power_read(struct hwm_drvdata *ddat, u32 attr, int chan, long *val) > >>> +{ > >>> +   

[Bug 216516] s2ram freezes screen (Ryzen-5650U incl. Radeon GPU)

2022-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216516 --- Comment #1 from kolAflash (kolafl...@kolahilft.de) --- Created attachment 301849 --> https://bugzilla.kernel.org/attachment.cgi?id=301849=edit kernel log: v5.18-rc7 and v5.18-rc7-1-g7123d39dc24d -- You may reply to this email to add a

[Bug 216516] New: s2ram freezes screen (Ryzen-5650U incl. Radeon GPU)

2022-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216516 Bug ID: 216516 Summary: s2ram freezes screen (Ryzen-5650U incl. Radeon GPU) Product: Drivers Version: 2.5 Kernel Version: 6.0-rc6 Hardware: AMD OS: Linux

Re: [PATCH 01/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Feng Tang
Thanks Hyeonggon for looping in me. On Thu, Sep 22, 2022 at 07:12:21PM +0800, Hyeonggon Yoo wrote: > On Wed, Sep 21, 2022 at 08:10:02PM -0700, Kees Cook wrote: > > In the effort to help the compiler reason about buffer sizes, the > > __alloc_size attribute was added to allocators. This improves

[GIT PULL] mediatek drm next for 6.1

2022-09-22 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Drop of_gpio header 2. Remove the unneeded result Regards, Chun-Kuang. The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868: Linux 6.0-rc1 (2022-08-14 15:50:18 -0700) are available in the Git repository at:

[PATCH] drm/bridge: anx7625: Notify audio framework of connector status changes

2022-09-22 Thread Nícolas F . R . A . Prado
We already have anx7625_audio_update_connector_status() to notify the audio framework when HDMI is (dis)connected, but up until now this function was only called during the callback setup. Add a call for it to the HPD change handling logic. A couple functions needed to be hoisted as part of this.

Re: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-22 Thread Sean Anderson
On 9/20/22 7:05 PM, Sean Anderson wrote: > > > On 9/20/22 6:49 PM, Leo Li wrote: >> >> >>> -Original Message- >>> From: Sean Anderson >>> Sent: Tuesday, September 20, 2022 11:21 AM >>> To: Robin Murphy ; Oleksij Rempel >>> ; Pengutronix Kernel Team >>> ; linux-...@vger.kernel.org;

RE: [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host

2022-09-22 Thread Michael Kelley (LINUX)
From: Saurabh Sengar Sent: Monday, September 12, 2022 8:33 AM > > Existing code is causing a race condition where dirt_needed value is > already set by the host and gets overwritten with default value. Remove > this default setting of dirt_needed, to avoid overwriting the value > received in

[PATCH 6/7] drm/i915/guc: define media GT GuC send regs

2022-09-22 Thread Daniele Ceraolo Spurio
The media GT shares the G-unit with the root GT, so a second set of communication registers is required for the media GuC. Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 14 ++

[PATCH 1/7] drm/i915/huc: only load HuC on GTs that have VCS engines

2022-09-22 Thread Daniele Ceraolo Spurio
On MTL the primary GT doesn't have any media capabilities, so no video engines and no HuC. We must therefore skip the HuC fetch and load on that specific case. Given that other multi-GT platforms might have HuC on the primary GT, we can't just check for that and it is easier to instead check for

[PATCH 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-09-22 Thread Daniele Ceraolo Spurio
From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size of WOPCM is 4MB with lower 2MB for SA Media and upper 2MB for GCD/GT. +=+===> ++ <== WOPCM TOP

[PATCH 4/7] drm/i915/guc: Add GuC deprivilege feature to MTL

2022-09-22 Thread Daniele Ceraolo Spurio
From: Stuart Summers MTL supports GuC deprivilege. Add the feature flag to this platform. Signed-off-by: Stuart Summers Cc: Radhakrishna Sripada Cc: John Harrison Cc: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/7] drm/i915/uc: fetch uc firmwares for each GT

2022-09-22 Thread Daniele Ceraolo Spurio
The FW binaries are independently loaded on each GT. On MTL, the memory is shared so we could potentially re-use a single allocation, but on discrete multi-gt platforms we are going to need independent copies, so it is easier to do the same on MTL as well, given that the amount of duplicated

[PATCH 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-09-22 Thread Daniele Ceraolo Spurio
Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked because we didn't have a case where 2 FWs would be loaded on the same GGTT at the same time. On MTL, however, this can happend if both GTs are reset at

[PATCH 7/7] drm/i915/guc: handle interrupts from media GuC

2022-09-22 Thread Daniele Ceraolo Spurio
The render and media GuCs share the same interrupt enable register, so we can no longer disable interrupts when we disable communication for one of the GuCs as this would impact the other GuC. Instead, we keep the interrupts always enabled in HW and use a variable in the GuC structure to determine

[PATCH 0/7] drm/i915: prepare for uC loading on MTL

2022-09-22 Thread Daniele Ceraolo Spurio
The introduction of the media GT brings a few changes for GuC/HuC. The main difference between the 2 GTs is that only the media one has the HuC, while both have the GuC. Also, the fact that both GTs use the same G-unit and GGTT means we now have parallel interrupt/communication paths. Lastly,

Re: [PATCH 00/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Kees Cook
On Thu, Sep 22, 2022 at 11:05:47PM +0200, Vlastimil Babka wrote: > On 9/22/22 17:55, Kees Cook wrote: > > On Thu, Sep 22, 2022 at 09:10:56AM +0200, Christian König wrote: > > [...] > > > So when this patch set is about to clean up this use case it should > > > probably > > > also take care to

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Enable compute scheduling on DG2

2022-09-22 Thread Umesh Nerlige Ramappa
On Thu, Sep 22, 2022 at 01:12:09PM -0700, john.c.harri...@intel.com wrote: From: John Harrison DG2 has issues. To work around one of these the GuC must schedule apps in an exclusive manner across both RCS and CCS. That is, if a context from app X is running on RCS then all CCS engines must sit

[PATCH] drm/i915: Remove unused function parameter

2022-09-22 Thread Niranjana Vishwanathapura
The function parameter 'exclude' in funciton i915_sw_fence_await_reservation() is not used. Remove it. Reviewed-by: Tvrtko Ursulin Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++--- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 +-

Re: [PATCH 00/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Vlastimil Babka
On 9/22/22 17:55, Kees Cook wrote: > On Thu, Sep 22, 2022 at 09:10:56AM +0200, Christian König wrote: >> Am 22.09.22 um 05:10 schrieb Kees Cook: >> > Hi, >> > >> > This series fixes up the cases where callers of ksize() use it to >> > opportunistically grow their buffer sizes, which can run afoul

Re: [PATCH v2 08/33] drm/connector: Rename drm_mode_create_tv_properties

2022-09-22 Thread Lyude Paul
For nouveau: Reviewed-by: Lyude Paul On Thu, 2022-09-22 at 16:25 +0200, Maxime Ripard wrote: > drm_mode_create_tv_properties(), among other things, will create the > "mode" property that stores the analog TV mode that connector is > supposed to output. > > However, that property is getting

Re: [PATCH v2 06/33] drm/connector: Rename legacy TV property

2022-09-22 Thread Lyude Paul
nouveau changes: Reviewed-by: Lyude Paul On Thu, 2022-09-22 at 16:25 +0200, Maxime Ripard wrote: > The current tv_mode has driver-specific values that don't allow to > easily share code using it, either at the userspace or kernel level. > > Since we're going to introduce a new, generic,

[PATCH] drm: Remove redundant assignments to variable count

2022-09-22 Thread Colin Ian King
The variable count is assigned a value but it is never read. The assignment is redundant and can be removed. Cleans up two clang scan build warnings: warning: Value stored to 'count' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_crtc_helper.c | 2 --

[PATCH 1/1] drm/i915/guc: Enable compute scheduling on DG2

2022-09-22 Thread John . C . Harrison
From: John Harrison DG2 has issues. To work around one of these the GuC must schedule apps in an exclusive manner across both RCS and CCS. That is, if a context from app X is running on RCS then all CCS engines must sit idle even if there are contexts from apps Y, Z, ... waiting to run. A

[PATCH 0/1] DG2 fix for CCS starvation

2022-09-22 Thread John . C . Harrison
From: John Harrison Enable CCS/RCS arbitration scheduling in GuC to prevent CCS starvation on DG2. Signed-off-by: John Harrison John Harrison (1): drm/i915/guc: Enable compute scheduling on DG2 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 1 +

Re: [PATCH v2 06/10] drm/msm/dp: fix aux-bus EP lifetime

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 5:36 AM, Doug Anderson wrote: Hi, On Tue, Sep 13, 2022 at 9:58 AM Johan Hovold wrote: Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is

Re: [Freedreno] [PATCH v2 01/10] drm/msm: fix use-after-free on probe deferral

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: The bridge counter was never reset when tearing down the DRM device so that stale pointers to deallocated structures would be accessed on the next tear down (e.g. after a second late bind deferral). Given enough bridges and a few probe deferrals this

Re: [Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh ---

Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh ---

Re: [Freedreno] [PATCH v2 07/10] drm/msm/dp: fix bridge lifetime

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is deferred. This can lead resource leaks or failure to bind

Re: [PATCH v2 08/10] drm/msm/hdmi: fix IRQ lifetime

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is deferred. This is specifically true for the HDMI IRQ,

Re: [PATCH v2 04/10] drm/msm/hdmi: fix memory corruption with too many bridges

2022-09-22 Thread Dmitry Baryshkov
On 13/09/2022 11:53, Johan Hovold wrote: Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge") Cc: sta...@vger.kernel.org # 3.12

Re: [PATCH v2 03/10] drm/msm/dsi: fix memory corruption with too many bridges

2022-09-22 Thread Dmitry Baryshkov
On 13/09/2022 11:53, Johan Hovold wrote: Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") Cc: sta...@vger.kernel.org

Re: [PATCH v2 02/10] drm/msm/dp: fix memory corruption with too many bridges

2022-09-22 Thread Dmitry Baryshkov
On 13/09/2022 11:53, Johan Hovold wrote: Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable")

Re: [Freedreno] [PATCH v2 05/10] drm/msm/dp: fix IRQ lifetime

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is deferred. This is specifically true for the DP IRQ, which

Re: [Freedreno] [PATCH v2 04/10] drm/msm/hdmi: fix memory corruption with too many bridges

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge") Cc: sta...@vger.kernel.org #

Re: [PATCH v2 03/10] drm/msm/dsi: fix memory corruption with too many bridges

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") Cc:

Re: [Freedreno] [PATCH v2 02/10] drm/msm/dp: fix memory corruption with too many bridges

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable")

[PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-22 Thread Nathan Chancellor
When booting with clang's kernel control flow integrity series [1], there are numerous violations when accessing the files under /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0: $ cd /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0 $ grep . * id:0 punit_req_freq_mhz:350

Re: [Freedreno] [PATCH v2 01/10] drm/msm: fix use-after-free on probe deferral

2022-09-22 Thread Kuogee Hsieh
On 9/13/2022 1:53 AM, Johan Hovold wrote: The bridge counter was never reset when tearing down the DRM device so that stale pointers to deallocated structures would be accessed on the next tear down (e.g. after a second late bind deferral). Given enough bridges and a few probe deferrals this

Re: [PATCH 02/12] skbuff: Proactively round up to kmalloc bucket size

2022-09-22 Thread Jakub Kicinski
On Wed, 21 Sep 2022 20:10:03 -0700 Kees Cook wrote: > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 974e7138..4fe4c7544c1d 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -427,14 +427,15 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t > gfp_mask, >

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-22 Thread Konstantin Ryabitsev
On Thu, Sep 22, 2022 at 02:51:00PM +0200, Krzysztof Kozlowski wrote: > Thanks for explanation! Probably your patches are perfectly fine and > should apply, although I must admit diffstat is often useful. Krzysztof: The patches should indeed apply without problems and there's a fix for the

Re: [PATCH v1 1/4] drm/msm/mdp5: stop overriding drvdata

2022-09-22 Thread Luca Weiss
Hi Dmitry, On Montag, 20. Juni 2022 23:30:51 CEST Dmitry Baryshkov wrote: > The rest of the code expects that master's device drvdata is the > struct msm_drm_private instance. Do not override the mdp5's drvdata. > > Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components") >

Re: [PATCH 4/4] drm/bridge: lt8912b: clarify lvds output status

2022-09-22 Thread Adrien Grassein
Le jeu. 22 sept. 2022 à 14:43, Philippe Schenker a écrit : > > From: Francesco Dolcini > > Add comments on the lt8912_write_lvds_config() config to document the > current settings and to make it clear that this is a hardcoded > configuration not relevant for the HDMI output (could be removed

Re: [PATCH 3/4] drm/bridge: lt8912b: fix corrupted image output

2022-09-22 Thread Adrien Grassein
Le jeu. 22 sept. 2022 à 14:43, Philippe Schenker a écrit : > > From: Francesco Dolcini > > Correct I2C address for the register list in lt8912_write_lvds_config(), > these registers are on the first I2C address (0x48), the current > function is just writing garbage to the wrong registers and

Re: [PATCH 2/4] drm/bridge: lt8912b: set hdmi or dvi mode

2022-09-22 Thread Adrien Grassein
Le jeu. 22 sept. 2022 à 14:43, Philippe Schenker a écrit : > > From: Philippe Schenker > > The Lontium LT8912 does have a setting for DVI or HDMI. This patch reads > from EDID what the display needs and sets it accordingly. > > Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI

Re: [PATCH 1/4] drm/bridge: lt8912b: add vsync hsync

2022-09-22 Thread Adrien Grassein
Le jeu. 22 sept. 2022 à 14:43, Philippe Schenker a écrit : > > From: Philippe Schenker > > Currently the bridge driver does not take care whether or not the display > needs positive/negative vertical/horizontal syncs. Pass these two flags > to the bridge from the EDID that was read out from the

[pull] drm/msm: drm-msm-next-2022-09-22 for v6.1

2022-09-22 Thread Rob Clark
Hi Dave & Daniel, Here is the main drm/msm pull for v6.1, description below and in tag. The following changes since commit 1c23f9e627a7b412978b4e852793c5e3c3efc555: Linux 6.0-rc2 (2022-08-21 17:32:54 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git

Re: [PATCH 4/5] drm/msm/dpu: add support for SM8450

2022-09-22 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-msm-add-support-for-SM8450/20220922-193223 base

Re: [PATCH v4 00/15] Tidy up vfio_device life cycle

2022-09-22 Thread Alex Williamson
On Wed, 21 Sep 2022 18:43:46 +0800 Kevin Tian wrote: > The idea is to let vfio core manage the vfio_device life cycle instead > of duplicating the logic cross drivers. Besides cleaner code in driver > side this also allows adding struct device to vfio_device as the first > step toward adding

Re: [PATCH 11/12] slab: Remove __malloc attribute from realloc functions

2022-09-22 Thread Miguel Ojeda
On Thu, Sep 22, 2022 at 5:56 PM Kees Cook wrote: > > I wasn't sure if this "composite macro" was sane there, especially since > it would be using __malloc before it was defined, etc. Would you prefer > I move it? Hmm... On one hand, they end up being attributes, so it could make sense to have

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-22 Thread Niranjana Vishwanathapura
On Thu, Sep 22, 2022 at 05:18:28PM +0100, Matthew Auld wrote: On 22/09/2022 09:09, Tvrtko Ursulin wrote: On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose

Re: [PATCH] drm/i915: Improve debug print in vm_fault_ttm

2022-09-22 Thread Matthew Auld
On 22/09/2022 13:09, Nirmoy Das wrote: Print the error code returned by __i915_ttm_migrate() for better debuggability. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1

Re: [RFC PATCH v3] media: mediatek: vcodec: support stateless AV1 decoder

2022-09-22 Thread Daniel Almeida
Hi Xiaoyong. Comments below (other code removed for brevity) +/** + * struct vdec_av1_slice_slot - slot info need save in global instance + * @frame_info: frame info for each slot + * @timestamp: time stamp info + */ +struct vdec_av1_slice_slot { + struct vdec_av1_slice_frame_info

Re: [Intel-gfx] [PATCH] drm/i915: Improve debug print in vm_fault_ttm

2022-09-22 Thread kernel test robot
Hi Nirmoy, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Nirmoy-Das/drm-i915-Improve-debug-print-in-vm_fault_ttm/20220922-201041 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-22 Thread Stefan Wahren
Hi Marc, Am 22.09.22 um 16:54 schrieb Marc Kleine-Budde: Hello, I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, using Debian's v5.19 kernel (Debian's v5.18 was working flawless). | [0.00] Booting Linux on physical CPU 0x00 [0x410fd034] | [0.00]

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-22 Thread Matthew Auld
On 22/09/2022 09:09, Tvrtko Ursulin wrote: On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be

Re: [PATCH v4] drm/sched: Add FIFO sched policy to run queue v3

2022-09-22 Thread Andrey Grodzovsky
On 2022-09-22 11:03, Luben Tuikov wrote: The title of this patch has "v3", but "v4" in the title prefix. If you're using "-v" to git-format-patch, please remove the "v3" from the title. Inlined: On 2022-09-21 14:28, Andrey Grodzovsky wrote: When many entities competing for same run queue on

RE: [PATCH 2/5] drm/simpledrm: Use drm_atomic_get_new_plane_state()

2022-09-22 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, September 22, 2022 9:10 AM >To: javi...@redhat.com; airl...@linux.ie; dan...@ffwll.ch >Cc: Thomas Zimmermann ; dri- >de...@lists.freedesktop.org >Subject: [PATCH 2/5] drm/simpledrm: Use

Re: [PATCH 07/12] igb: Proactively round up to kmalloc bucket size

2022-09-22 Thread Kees Cook
On Thu, Sep 22, 2022 at 03:56:54PM +, Ruhl, Michael J wrote: > >From: dri-devel On Behalf Of Kees > >Cook > [...] > >diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > >b/drivers/net/ethernet/intel/igb/igb_main.c > >index 2796e81d2726..4d70ee5b0f79 100644 > >---

[PATCH -next 1/2] drm/rockchip: vop: fix PM usage counter unbalance in vop ops

2022-09-22 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. We fix it by replacing it with the newest pm_runtime_resume_and_get to keep usage counter balanced. Fixes:5e570373c015b ("drm/rockchip: vop: Enable pm domain

[PATCH 0/4] drm/bridge: lt8912b: Fix corrupt display output due to wrong bridge config

2022-09-22 Thread Philippe Schenker
From: Philippe Schenker This patch-set fixes the lt8912b driver that currently does not take care whether or not the attached display has postiive or negative syncs and or reports on EDID if it needs HDMI mode or DVI. This series addresses also an issue where the LVDS startup sequence was

[PATCH -next 2/2] drm/rockchip: fix PM usage counter unbalance in poweron

2022-09-22 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. We fix it by replacing it with the newest pm_runtime_resume_and_get to keep usage counter balanced. Fixes:34cc0aa254560 ("drm/rockchip: Add support for Rockchip

[PATCH 3/4] drm/bridge: lt8912b: fix corrupted image output

2022-09-22 Thread Philippe Schenker
From: Francesco Dolcini Correct I2C address for the register list in lt8912_write_lvds_config(), these registers are on the first I2C address (0x48), the current function is just writing garbage to the wrong registers and this creates multiple issues (artifacts and output completely corrupted)

[PATCH 1/4] drm/bridge: lt8912b: add vsync hsync

2022-09-22 Thread Philippe Schenker
From: Philippe Schenker Currently the bridge driver does not take care whether or not the display needs positive/negative vertical/horizontal syncs. Pass these two flags to the bridge from the EDID that was read out from the display. Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to

[PATCH] gpu: host1x: use DEFINE_SHOW_ATTRIBUTE to simplify host1x_debug/host1x_debug_all

2022-09-22 Thread Liu Shixin
Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code. No functional change. Signed-off-by: Liu Shixin --- drivers/gpu/host1x/debug.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c

[PATCH] drm/msm/dpu: use DEFINE_SHOW_ATTRIBUTE to simplify dpu_regset32

2022-09-22 Thread Liu Shixin
Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code. No functional change. Signed-off-by: Liu Shixin --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

[PATCH] dma-buf: Add __init annotation to module init func

2022-09-22 Thread Xiu Jianfeng
Add missing __init annotation to module init func. Signed-off-by: Xiu Jianfeng --- drivers/dma-buf/heaps/cma_heap.c| 2 +- drivers/dma-buf/heaps/system_heap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/heaps/cma_heap.c

[PATCH 2/4] drm/bridge: lt8912b: set hdmi or dvi mode

2022-09-22 Thread Philippe Schenker
From: Philippe Schenker The Lontium LT8912 does have a setting for DVI or HDMI. This patch reads from EDID what the display needs and sets it accordingly. Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Signed-off-by: Philippe Schenker ---

[PATCH -next 0/2] fix PM usage counter unbalance

2022-09-22 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. We fix it by replacing it with the newest pm_runtime_resume_and_get to keep usage counter balanced. Zhang Qilong (2): drm/rockchip: vop: fix PM usage counter

[PATCH 4/4] drm/bridge: lt8912b: clarify lvds output status

2022-09-22 Thread Philippe Schenker
From: Francesco Dolcini Add comments on the lt8912_write_lvds_config() config to document the current settings and to make it clear that this is a hardcoded configuration not relevant for the HDMI output (could be removed without affecting the HDMI port). No changes on the actual register

Re: [PATCH 03/12] net: ipa: Proactively round up to kmalloc bucket size

2022-09-22 Thread Kees Cook
On Thu, Sep 22, 2022 at 08:45:19AM -0500, Alex Elder wrote: > On 9/21/22 10:10 PM, Kees Cook wrote: > > Instead of discovering the kmalloc bucket size _after_ allocation, round > > up proactively so the allocation is explicitly made for the full size, > > allowing the compiler to correctly reason

RE: [PATCH 07/12] igb: Proactively round up to kmalloc bucket size

2022-09-22 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Kees Cook >Sent: Wednesday, September 21, 2022 11:10 PM >To: Vlastimil Babka >Cc: linux-wirel...@vger.kernel.org; Jacob Shin ; >l...@lists.linux.dev; dri-devel@lists.freedesktop.org; linux...@kvack.org; >Eric Dumazet ; Nguyen, Anthony

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-22 Thread Iddamsetty, Aravind
On 22-09-2022 19:26, Lucas De Marchi wrote: > On Wed, Sep 21, 2022 at 12:00:38PM +0530, Iddamsetty, Aravind wrote: >> replying here for earlier comments too. >> >> On 21-09-2022 01:35, Lucas De Marchi wrote: >>> On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote: On Tue, Sep

Re: [PATCH 11/12] slab: Remove __malloc attribute from realloc functions

2022-09-22 Thread Kees Cook
On Thu, Sep 22, 2022 at 11:23:46AM +0200, Miguel Ojeda wrote: > On Thu, Sep 22, 2022 at 5:10 AM Kees Cook wrote: > > > > -#ifdef __alloc_size__ > > -# define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > > -#else > > -# define __alloc_size(x, ...) __malloc > > -#endif > >

Re: [PATCH 00/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Kees Cook
On Thu, Sep 22, 2022 at 09:10:56AM +0200, Christian König wrote: > Am 22.09.22 um 05:10 schrieb Kees Cook: > > Hi, > > > > This series fixes up the cases where callers of ksize() use it to > > opportunistically grow their buffer sizes, which can run afoul of the > > __alloc_size hinting that

Re: [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 02:14, Bjorn Andersson wrote: > On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: >> On 19/09/2022 23:18, Bjorn Andersson wrote: >>> On Sat, Sep 17, 2022 at 06:03:27PM +0100, Krzysztof Kozlowski wrote: On 16/09/2022 21:00, Bjorn Andersson wrote: > From:

Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 17:16, Konrad Dybcio wrote: >> >> How about bringing them closer to common GPIOs: >> panel-reset-gpios >> ? >> >>> +description: Display panel reset pin >>> + >>> + treset-gpios: >> >> touch-reset-gpios >> > I can do that. I will however wait with resending in case somebody has

Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel

2022-09-22 Thread Konrad Dybcio
On 22.09.2022 17:11, Krzysztof Kozlowski wrote: > On 22/09/2022 15:58, Konrad Dybcio wrote: >> Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2 >> Compact smartphones. >> >> Signed-off-by: Konrad Dybcio > > Thank you for your patch. There is something to

Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 15:58, Konrad Dybcio wrote: > Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2 > Compact smartphones. > > Signed-off-by: Konrad Dybcio Thank you for your patch. There is something to discuss/improve. > + > + reg: true > + > + backlight: true > + > +

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-22 Thread Maxime Ripard
Hi, On Thu, Sep 22, 2022 at 04:54:48PM +0200, Marc Kleine-Budde wrote: > Hello, > > I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, > using Debian's v5.19 kernel (Debian's v5.18 was working flawless). > > | [0.00] Booting Linux on physical CPU 0x00

Re: [PATCH v4] drm/sched: Add FIFO sched policy to run queue v3

2022-09-22 Thread Luben Tuikov
The title of this patch has "v3", but "v4" in the title prefix. If you're using "-v" to git-format-patch, please remove the "v3" from the title. Inlined: On 2022-09-21 14:28, Andrey Grodzovsky wrote: > When many entities competing for same run queue on > the same scheduler When many entities

Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-22 Thread Marc Kleine-Budde
Hello, I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, using Debian's v5.19 kernel (Debian's v5.18 was working flawless). | [0.00] Booting Linux on physical CPU 0x00 [0x410fd034]

Re: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Alex Deucher
Applied. Thanks! On Thu, Sep 22, 2022 at 2:49 AM Christian König wrote: > > Am 22.09.22 um 06:17 schrieb Li Zhong: > > amdgpu_bo_kmap() returns error when fails to map buffer object. Add the > > error check and propagate the error. > > > > Signed-off-by: Li Zhong > > We usually use "r" as

Re: [PATCH v2 00/33] drm: Analog TV Improvements

2022-09-22 Thread Maxime Ripard
Hi, On Thu, Sep 22, 2022 at 04:25:17PM +0200, Maxime Ripard wrote: > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the >

[PATCH v2 33/33] drm/sun4i: tv: Convert to the new TV mode property

2022-09-22 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the sun4i TV driver to leverage those new features. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index 74ff5ad6a8b9..833742cee745 100644 ---

[PATCH v2 32/33] drm/vc4: vec: Add support for more analog TV standards

2022-09-22 Thread Maxime Ripard
From: Mateusz Kwiatkowski Add support for the following composite output modes (all of them are somewhat more obscure than the previously defined ones): - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to 4.43361875 MHz (the PAL subcarrier frequency). Never used for

[PATCH v2 31/33] drm/vc4: vec: Convert to the new TV mode property

2022-09-22 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the vc4 VEC driver to leverage those new features. We've added some backward compatibility to support the old TV mode property and translate it into the new TV norm property. Signed-off-by: Maxime Ripard diff --git

[PATCH v2 30/33] drm/vc4: vec: Check for VEC output constraints

2022-09-22 Thread Maxime Ripard
From: Mateusz Kwiatkowski The VEC can accept pretty much any relatively reasonable mode, but still has a bunch of constraints to meet. Let's create an atomic_check() implementation that will make sure we don't end up accepting a non-functional mode. Signed-off-by: Mateusz Kwiatkowski

[PATCH v2 29/33] drm/vc4: vec: Use TV Reset implementation

2022-09-22 Thread Maxime Ripard
The analog TV properties created by the drm_mode_create_tv_properties() are not properly initialised at reset. Let's switch our implementation to call drm_atomic_helper_connector_tv_reset(). Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/vc4/vc4_vec.c

[PATCH v2 28/33] drm/vc4: vec: Fix definition of PAL-M mode

2022-09-22 Thread Maxime Ripard
From: Mateusz Kwiatkowski PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings. This commit makes the driver actually use the proper VEC preset for this mode instead of just changing PAL subcarrier frequency.

[PATCH v2 25/33] drm/modes: Introduce more named modes

2022-09-22 Thread Maxime Ripard
Now that we can easily extend the named modes list, let's add a few more analog TV modes that were used in the wild, and some unit tests to make sure it works as intended. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index

[PATCH v2 26/33] drm/atomic-helper: Add a TV properties reset helper

2022-09-22 Thread Maxime Ripard
The drm_tv_create_properties() function will create a bunch of properties, but it's up to each and every driver using that function to properly reset the state of these properties leading to inconsistent behaviours. Let's create a helper that will take care of it. Reviewed-by: Noralf Trønnes

[PATCH v2 27/33] drm/atomic-helper: Add an analog TV atomic_check implementation

2022-09-22 Thread Maxime Ripard
The analog TV connector drivers share some atomic_check logic, and the new TV standard property have created a bunch of new constraints that needs to be shared across drivers too. Let's create an atomic_check helper for those use cases. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard

[PATCH v2 24/33] drm/modes: Properly generate a drm_display_mode from a named mode

2022-09-22 Thread Maxime Ripard
The framework will get the drm_display_mode from the drm_cmdline_mode it got by parsing the video command line argument by calling drm_connector_pick_cmdline_mode(). The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode() function. In the case of the named modes though,

[PATCH v2 23/33] drm/modes: Introduce the tv_mode property as a command-line option

2022-09-22 Thread Maxime Ripard
Our new tv mode option allows to specify the TV mode from a property. However, it can still be useful, for example to avoid any boot time artifact, to set that property directly from the kernel command line. Let's add some code to allow it, and some unit tests to exercise that code.

  1   2   3   >