Re: [PATCH AUTOSEL 5.19 07/16] drm/amdgpu: use dirty framebuffer helper

2022-10-19 Thread Eric Biggers
On Wed, Sep 21, 2022 at 11:53:23AM -0400, Sasha Levin wrote: > From: Hamza Mahfooz > > [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ] > > Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use > drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs >

[PATCH v2 01/16] drm/vmwgfx: Write the driver id registers

2022-10-19 Thread Zack Rusin
From: Zack Rusin Driver id registers are a new mechanism in the svga device to hint to the device which driver is running. This should not change device behavior in any way, but might be convenient to work-around specific bugs in guest drivers. Signed-off-by: Zack Rusin Reviewed-by: Martin

[PATCH v2 11/16] drm/vmwgfx: Remove vmwgfx_hashtab

2022-10-19 Thread Zack Rusin
From: Maaz Mombasawala The vmwgfx driver has migrated from using the hashtable in vmwgfx_hashtab to the linux/hashtable implementation. Remove the vmwgfx_hashtab from the driver. Signed-off-by: Maaz Mombasawala Reviewed-by: Martin Krastev Reviewed-by: Zack Rusin Signed-off-by: Zack Rusin

[PATCH v2 06/16] drm/vmwgfx: Clean up cursor mobs

2022-10-19 Thread Zack Rusin
From: Michael Banack Clean up the cursor mob path by moving ownership of the mobs into the plane_state, and just leaving a cache of unused mobs in the plane itself. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 441

[PATCH v2 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-19 Thread Zack Rusin
From: Zack Rusin Instead of using vmwgfx specific framebuffer implementation use the drm fb helpers. There's no change in functionality, the only difference is a reduction in the amount of code inside the vmwgfx module. drm fb helpers do not deal correctly with changes in crtc preferred mode at

[PATCH v2 04/16] drm/vmwgfx: Remove ttm object hashtable

2022-10-19 Thread Zack Rusin
From: Maaz Mombasawala The object_hash hashtable for ttm objects is not being used. Remove it and perform refactoring in ttm_object init function. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by: Martin Krastev Signed-off-by: Zack Rusin ---

[PATCH v2 02/16] drm/vmwgfx: Fix frame-size warning in vmw_mksstat_add_ioctl

2022-10-19 Thread Zack Rusin
From: Martin Krastev Function vmw_mksstat_add_ioctl allocates three big arrays on stack. That triggers frame-size [-Wframe-larger-than=] warning. Refactor that function to use kmalloc_array instead. Signed-off-by: Martin Krastev Reviewed-by: Zack Rusin Reviewed-by: Maaz Mombasawala

[PATCH v2 12/16] drm/vmwgfx: Do not allow invalid bpp's for dumb buffers

2022-10-19 Thread Zack Rusin
From: Zack Rusin Dumb buffers allow a very limited set of formats. Basically everything apart from 1, 2 and 4 is expected to return an error. Make vmwgfx follow those guidelines. This fixes igt's dumb_buffer invalid_bpp test on vmwgfx. Signed-off-by: Zack Rusin Reviewed-by: Martin Krastev

[PATCH v2 16/16] drm/vmwgfx: Optimize initial sizes of cotables

2022-10-19 Thread Zack Rusin
From: Zack Rusin It's important to get the initial size of cotables right because otherwise every app needs to start with a synchronous cotable resize. This has an measurable impact on system wide performance but is not relevant for long running single full screen apps for which the cotable

[PATCH v2 08/16] drm/vmwgfx: Support cursor surfaces with mob cursor

2022-10-19 Thread Zack Rusin
From: Michael Banack Add support for cursor surfaces when using mob cursors. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 78 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 1 + 2 files changed, 50 insertions(+), 29

[PATCH v2 05/16] drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.

2022-10-19 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenence burden. As part of this effort, refactor the res_ht hashtable used for resource validation during execbuf execution to use linux/hashtable implementation. This also refactors

[PATCH v2 07/16] drm/vmwgfx: Start diffing new mob cursors against old ones

2022-10-19 Thread Zack Rusin
From: Michael Banack Avoid making the SVGA device do extra work if the new cursor image matches the old one. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 95 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 12 ++-- 2

[PATCH v2 14/16] drm/vmwgfx: Remove explicit and broken vblank handling

2022-10-19 Thread Zack Rusin
From: Zack Rusin The explicit vblank handling was never finished. The driver never had the full implementation of vblank and what was there is emulated by DRM when the driver doesn't pretend to be implementing it itself. Let DRM handle the vblank emulation and stop pretending the driver is

[PATCH v2 09/16] drm/vmwgfx: Diff cursors when using cmds

2022-10-19 Thread Zack Rusin
From: Michael Banack Extend the cursor diffing support to support the command-path. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 120 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 + 2 files changed, 62

[PATCH v2 10/16] drm/vmwgfx: Refactor ttm reference object hashtable to use linux/hashtable.

2022-10-19 Thread Zack Rusin
From: Maaz Mombasawala This is part of an effort to move from the vmwgfx_open_hash hashtable to linux/hashtable implementation. Refactor the ref_hash hashtable, used for fast lookup of reference objects associated with a ttm file. This also exposed a problem related to inconsistently using

[PATCH v2 03/16] drm/vmwgfx: Refactor resource manager's hashtable to use linux/hashtable implementation.

2022-10-19 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenance burden. Refactor cmdbuf resource manager to use linux/hashtable.h implementation as part of this effort. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by:

[PATCH v2 15/16] drm/vmwgfx: Add a mksstat counter for cotable resizes

2022-10-19 Thread Zack Rusin
From: Zack Rusin There's been a lot of cotable resizes on startup which we can track by adding a mks stat to measure both the invocation count and time spent doing cotable resizes. This is only used if kernel is configured with CONFIG_DRM_VMWGFX_MKSSTATS The stats are collected on the host size

[PATCH v2 00/16] drm/vmwgfx: fb, cursors and hashtable refactor

2022-10-19 Thread Zack Rusin
From: Zack Rusin v2: Fix LKP and sparse reported issues This is a bit larger series than usual but these are all connected in various ways. The most important changes around everything is centered include: - finally getting rid of vmwgfx_hashtab and porting the driver to linux/hashtable -

Re: [drm/gem] 79e2cf2e7a: WARNING:at_drivers/gpu/drm/drm_gem.c:#drm_gem_vunmap

2022-10-19 Thread Dmitry Osipenko
On 10/20/22 06:23, kernel test robot wrote: > Greeting, > > FYI, we noticed WARNING:at_drivers/gpu/drm/drm_gem.c:#drm_gem_vunmap due to > commit (built with clang-14): > > commit: 79e2cf2e7a193473dfb0da3b9b869682b43dc60f ("drm/gem: Take reservation > lock for vmap/vunmap operations") >

[PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-19 Thread Vinay Belgaumkar
Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if GuC is already requesting the same. v2: Add the tracing back, and check requested freq in the worker

Re: [PATCH v2] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-19 Thread Belgaumkar, Vinay
On 10/19/2022 4:05 PM, Vinay Belgaumkar wrote: Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if GuC is already requesting the same. v2: Add the

[PATCH 2/2] drm/rockchip: dsi: Force synchronous probe

2022-10-19 Thread Brian Norris
We can't safely probe a dual-DSI display asynchronously (driver_async_probe='*' or driver_async_probe='dw-mipi-dsi-rockchip' cmdline), because dw_mipi_dsi_rockchip_find_second() pokes one DSI device's drvdata from the other device without any locking. Request synchronous probe, at least until

[PATCH 1/2] drm/rockchip: dsi: Clean up 'usage_mode' when failing to attach

2022-10-19 Thread Brian Norris
If we fail to attach the first time (especially: EPROBE_DEFER), we fail to clean up 'usage_mode', and thus will fail to attach on any subsequent attempts, with "dsi controller already in use". Re-set to DW_DSI_USAGE_IDLE on attach failure. This is especially common to hit when enabling

Re: [PATCH 2/4] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-19 Thread Dixit, Ashutosh
On Wed, 19 Oct 2022 07:58:13 -0700, Rodrigo Vivi wrote: > > On Tue, Oct 18, 2022 at 10:20:41PM -0700, Ashutosh Dixit wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c > > b/drivers/gpu/drm/i915/gt/intel_rps.c > > index df21258976d86..5a743ae4dd11e 100644 > > ---

Re: [PATCH 1/4] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-19 Thread Dixit, Ashutosh
On Wed, 19 Oct 2022 08:06:26 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Tue, Oct 18, 2022 at 10:20:40PM -0700, Ashutosh Dixit wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > > index 36d95b79022c0..a7a0129d0e3fc 100644 > > ---

Re: [PATCH 3/3] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-19 Thread Dixit, Ashutosh
On Mon, 17 Oct 2022 13:12:33 -0700, Dixit, Ashutosh wrote: > > On Fri, 14 Oct 2022 20:26:18 -0700, Ashutosh Dixit wrote: > > > > From: Badal Nilawar > > Hi Badal, > > One question below. > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > >

Re: [PATCH 3/4] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-19 Thread Dixit, Ashutosh
On Wed, 19 Oct 2022 00:51:45 -0700, Jani Nikula wrote: > > On Tue, 18 Oct 2022, Ashutosh Dixit wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.h > > b/drivers/gpu/drm/i915/gt/intel_rc6.h > > index b6fea71afc223..3105bc72c096b 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_rc6.h > > +++

[PATCH 1/5] drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf

2022-10-19 Thread Ashutosh Dixit
Instead of masks/shifts settle on REG_FIELD_GET as the standard way to extract reg fields. This allows future patches touching this code to also consistently use REG_FIELD_GET and friends. Suggested-by: Rodrigo Vivi Signed-off-by: Ashutosh Dixit ---

[PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-19 Thread Ashutosh Dixit
From: Badal Nilawar Add support for C6 residency and C state type for MTL SAMedia. Also add mtl_drpc. v2: Fixed review comments (Ashutosh) v3: Sort registers and fix whitespace errors in intel_gt_regs.h (Matt R) Remove MTL_CC_SHIFT (Ashutosh) Adapt to RC6 residency register code

[PATCH 4/5] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-19 Thread Ashutosh Dixit
Previously RC6 residency functions directly accepted RC6 residency register MMIO offsets (there are four RC6 residency registers). This worked but required an assumption on the residency register layout so was not future proof. Therefore change RC6 residency functions to accept RC6 residency

[PATCH 2/5] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-19 Thread Ashutosh Dixit
From: Don Hiatt On GEN12+ use GEN12_RPSTAT register to get actual resolved GT freq. GEN12_RPSTAT does not require a forcewake and will return 0 freq if GT is in RC6. v2: - Fixed review comments(Ashutosh) - Added function intel_rps_read_rpstat_fw to read RPSTAT without forcewake,

[PATCH 3/5] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-19 Thread Ashutosh Dixit
From: Badal Nilawar Update CAGF functions for MTL to get actual resolved frequency of 3D and SAMedia. v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) Move MTL branches in cagf functions to top (MattR) Fix commit message (Andi) v3: Added comment about registers not needing

[PATCH 0/5] i915: CAGF and RC6 changes for MTL

2022-10-19 Thread Ashutosh Dixit
This series includes the code changes to get CAGF, RC State and C6 Residency of MTL. v3: Included "Use GEN12 RPSTAT register" patch v4: - Rebased - Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it v5: - Included "drm/i915/gt: Change RC6

[PATCH v2] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-19 Thread Vinay Belgaumkar
Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if GuC is already requesting the same. v2: Add the tracing back, and check requested freq in the worker

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-19 Thread Belgaumkar, Vinay
On 10/19/2022 2:12 PM, Belgaumkar, Vinay wrote: On 10/19/2022 12:40 AM, Tvrtko Ursulin wrote: On 18/10/2022 23:15, Vinay Belgaumkar wrote: Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full

[PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR

2022-10-19 Thread Matt Roper
A misplaced closing parenthesis caused the groupid/instanceid values to be considered part of the ternary operator's condition instead of being OR'd into the resulting value. Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering") Reported-by: kernel test robot Signed-off-by: Matt Roper

[PATCH v1] drm: rockchip: remove rockchip_drm_framebuffer_init() function

2022-10-19 Thread Johan Jonker
The function rockchip_drm_framebuffer_init() was in use in the rockchip_drm_fbdev.c file, but that is now replaced by a generic fbdev setup. Reduce the image size by removing the rockchip_drm_framebuffer_init() and sub function rockchip_fb_alloc() and cleanup the rockchip_drm_fb.h header file.

Re: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

2022-10-19 Thread Lyude Paul
Gotcha, I'll take another look at this tomorrow On Mon, 2022-10-17 at 03:09 +, Lin, Wayne wrote: > [Public] > > > > > -Original Message- > > From: Lyude Paul > > Sent: Thursday, October 6, 2022 3:37 AM > > To: Siqueira, Rodrigo ; dri- > > de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-19 Thread Belgaumkar, Vinay
On 10/19/2022 12:40 AM, Tvrtko Ursulin wrote: On 18/10/2022 23:15, Vinay Belgaumkar wrote: Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if GuC is

Re: [PATCH] Make xilinxfb_release() return void

2022-10-19 Thread Uwe Kleine-König
Hello, I failed to add a proper subject prefix. "fbdev: xilinxfb: " would have been a good choice. I can resend, but I wouldn't say no if you are willing to fixup while applying this patch :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König|

Re: [PATCH 15/15] drm/edid: convert to device specific logging

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:49PM +0300, Jani Nikula wrote: > Convert to drm_kms_dbg/drm_err where possible, and unify the rest of the > debugs to DRM_DEBUG_KMS. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 105 ++--- > 1 file changed, 50

Re: [PATCH 14/15] drm/edid/firmware: convert to drm device specific logging

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:48PM +0300, Jani Nikula wrote: > Conform to device specific logging. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid_load.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid_load.c

Re: [PATCH 13/15] drm/edid: move edid load declarations to internal header

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:47PM +0300, Jani Nikula wrote: > The EDID loader is internal to drm, not for drivers. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_crtc_internal.h | 11 +++ > drivers/gpu/drm/drm_edid_load.c | 5 +++-- >

Re: [PATCH 11/15] drm/edid/firmware: rename drm_load_edid_firmware() to drm_edid_load_firmware()

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:45PM +0300, Jani Nikula wrote: > Follow the usual naming convention by file name. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 10 +- > drivers/gpu/drm/drm_edid_load.c | 2 +- >

Re: [PATCH 09/15] drm/edid: detach debugfs EDID override from EDID property update

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:43PM +0300, Jani Nikula wrote: > Having the EDID override debugfs directly update the EDID property is > problematic. The update is partial only. The driver has no way of > knowing it's been updated. Mode list is not updated. It's an > inconsistent state. > > Detach

Re: [PATCH 06/15] drm/edid: rename drm_add_override_edid_modes() to drm_edid_override_connector_update()

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:40PM +0300, Jani Nikula wrote: > Follow the naming of both EDID override functions as well as > drm_edid_connector_update(). This also matches better what the function > does; a combination of EDID property update and add modes. Indeed it > should later be converted

Re: [PATCH 12/15] drm/edid: use struct drm_edid for override/firmware EDID

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:46PM +0300, Jani Nikula wrote: > There's a lot going on here, but the main thing is switching the > firmware EDID loader to use struct drm_edid. Unfortunately, it's > difficult to reasonably split to smaller pieces. > > Convert the EDID loader to struct drm_edid.

Re: [PATCH 10/15] drm/edid/firmware: drop redundant connector_name variable/parameter

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:44PM +0300, Jani Nikula wrote: > Stop passing around something that's readily available in > connector->name. > > Signed-off-by: Jani Nikula Weird. Did we not have a connector in there at some point or something? Shrug. Reviewed-by: Ville Syrjälä > --- >

Re: [PATCH 08/15] drm/edid: add function for checking drm_edid validity

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:42PM +0300, Jani Nikula wrote: > We've lacked a function for immutable validity check on drm_edid. Add > one. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 30 ++ > include/drm/drm_edid.h | 1 + > 2 files

Re: [PATCH 07/15] drm/edid: split drm_edid block count helper

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:41PM +0300, Jani Nikula wrote: > Split the drm_edid block count helper to a base version that reports the > block count indicated by EDID contents, and another on top that limits > the block count based on size allocated for the EDID. > > Signed-off-by: Jani Nikula

Re: [PATCH 05/15] drm/edid: abstract debugfs override EDID show better

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:39PM +0300, Jani Nikula wrote: > Add a function to dump the override EDID in debugfs. This hides the > override EDID management better in drm_edid.c. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_crtc_internal.h | 4 +++-

Re: [PATCH 04/15] drm/edid: debug log EDID override set/reset

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:38PM +0300, Jani Nikula wrote: > It's useful debugging information to know if and when an override EDID > was set or reset. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 6 ++ > 1 file changed, 6 insertions(+)

Re: [PATCH 02/15] drm/i915/hdmi: stop using connector->override_edid

2022-10-19 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:36PM +0300, Jani Nikula wrote: > The connector->override_edid flag is strictly for EDID override debugfs > management, and drivers have no business using it. > > The check for override_edid was added in commit 301906290553 ("drm/i915: > Ignore TMDS clock limit for

Re: [PATCH] drm/amdkfd: Fix memory leak in kfd_mem_dmamap_userptr()

2022-10-19 Thread Felix Kuehling
On 2022-10-17 21:27, Rafael Mendonca wrote: If the number of pages from the userptr BO differs from the SG BO then the allocated memory for the SG table doesn't get freed before returning -EINVAL, which may lead to a memory leak in some error paths. Fix this by checking the number of pages

Re: [Intel-gfx] [PATCH 01/15] drm/i915/hdmi: do dual mode detect only if connected

2022-10-19 Thread Ville Syrjälä
On Thu, Oct 13, 2022 at 10:24:54PM +0300, Ville Syrjälä wrote: > On Thu, Oct 13, 2022 at 09:41:21PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote: > > > For normal connector detect, there's really no point in trying dual mode > > > detect if the

[pull] amdgpu drm-fixes-6.1

2022-10-19 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.1. Mostly fixes for new IPs or features added in 6.1. The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v4 12/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-19 Thread Niranjana Vishwanathapura
On Wed, Oct 19, 2022 at 04:20:49PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not

Re: [PATCH 01/15] drm/i915/hdmi: do dual mode detect only if connected

2022-10-19 Thread Ville Syrjälä
On Fri, Oct 14, 2022 at 11:14:43AM +0300, Jani Nikula wrote: > On Thu, 13 Oct 2022, Ville Syrjälä wrote: > > On Thu, Oct 13, 2022 at 09:41:21PM +0300, Ville Syrjälä wrote: > >> On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote: > >> > For normal connector detect, there's really no point

Re: [PATCH v4 13/17] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-10-19 Thread Niranjana Vishwanathapura
On Wed, Oct 19, 2022 at 05:07:31PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM.

Re: [PATCH] drm/bridge: ps8640: Add back the 50 ms mystery delay after HPD

2022-10-19 Thread Doug Anderson
Hi, On Wed, Oct 19, 2022 at 11:18 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2022-10-17 12:18:51) > > Back in commit 826cff3f7ebb ("drm/bridge: parade-ps8640: Enable > > runtime power management") we removed a mysterious 50 ms delay because > > "Parade's support [couldn't] explain what

Re: [PATCH] drm/bridge: ps8640: Add back the 50 ms mystery delay after HPD

2022-10-19 Thread Stephen Boyd
Quoting Douglas Anderson (2022-10-17 12:18:51) > Back in commit 826cff3f7ebb ("drm/bridge: parade-ps8640: Enable > runtime power management") we removed a mysterious 50 ms delay because > "Parade's support [couldn't] explain what the delay [was] for". > > While I'm always a fan of removing

Re: [PATCH v4 14/17] drm/i915/vm_bind: Expose i915_request_await_bind()

2022-10-19 Thread Niranjana Vishwanathapura
On Wed, Oct 19, 2022 at 05:09:32PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. Reviewed-by: Andi Shyti Signed-off-by:

Re: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-19 Thread Eric Farman
On Wed, 2022-10-19 at 14:15 -0300, Jason Gunthorpe wrote: > On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote: > > >  /* > >   * Initialize a vfio_device so it can be registered to vfio core. > > - * > > - * Only vfio-ccw driver should call this interface. > >   */ > >  int

Re: [PATCH 14/17] ARM: omap1: remove dead code

2022-10-19 Thread Aaro Koskinen
Hi, On Wed, Oct 19, 2022 at 05:03:36PM +0200, Arnd Bergmann wrote: > drivers/usb/phy/phy-isp1301-omap.c | 91 +- This driver and config option ISP1301_OMAP can be deleted altogether as there are no users after H2/H3 boards are gone. A.

Re: [PATCH] ACPI: PCI: Fix device reference counting in acpi_get_pci_dev()

2022-10-19 Thread Ville Syrjälä
On Wed, Oct 19, 2022 at 11:53:26AM -0500, Bjorn Helgaas wrote: > On Wed, Oct 19, 2022 at 11:54:42AM +0300, Ville Syrjälä wrote: > > On Tue, Oct 18, 2022 at 07:34:03PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Commit 63f534b8bad9 ("ACPI: PCI: Rework

Re: [PATCH] drm: tests: Fix a buffer overflow in format_helper_test

2022-10-19 Thread José Expósito
On Wed, Oct 19, 2022 at 03:32:40PM +0800, David Gow wrote: > The xrgb2101010 format conversion test (unlike for other formats) does > an endianness conversion on the results. However, it always converts > TEST_BUF_SIZE 32-bit integers, which results in reading from (and > writing to) more memory

[PATCH] gpu: host1x: Avoid trying to use GART on Tegra20

2022-10-19 Thread Robin Murphy
Since commit c7e3ca515e78 ("iommu/tegra: gart: Do not register with bus") quite some time ago, the GART driver has effectively disabled itself to avoid issues with the GPU driver expecting it to work in ways that it doesn't. As of commit 57365a04c921 ("iommu: Move bus setup to IOMMU device

Re: [PATCH v1 0/7] vfio-ccw parent rework

2022-10-19 Thread Jason Gunthorpe
On Wed, Oct 19, 2022 at 06:21:28PM +0200, Eric Farman wrote: > This series attempts to address the oddities/shortcomings of vfio-ccw, such > that vfio-ccw can use the same helpers as everyone else, and the tricks that > were implemented by the other drivers can be removed. It is built on 6.1-rc1,

Re: [PATCH v1 7/7] vfio: Remove vfio_free_device

2022-10-19 Thread Jason Gunthorpe
On Wed, Oct 19, 2022 at 06:21:35PM +0200, Eric Farman wrote: > With the "mess" sorted out, we should be able to inline the > vfio_free_device call introduced by commit cb9ff3f3b84c > ("vfio: Add helpers for unifying vfio_device life cycle") > and remove them from driver release callbacks. > >

Re: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-19 Thread Jason Gunthorpe
On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote: > /* > * Initialize a vfio_device so it can be registered to vfio core. > - * > - * Only vfio-ccw driver should call this interface. > */ > int vfio_init_device(struct vfio_device *device, struct device *dev, >

Re: [RFC PATCH v5 5/6] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2022-10-19 Thread Aradhya Bhatia
Hi Tomi On 12-Oct-22 17:59, Tomi Valkeinen wrote: On 28/09/2022 20:52, Aradhya Bhatia wrote: The ctrl mmr module of the AM625 is different from the AM65X SoC. Thus the ctrl mmr registers that supported the OLDI TX power have become different in AM625 SoC. Add IO CTRL support and control the

Re: [PATCH 5/6] drm/radeon: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Christian König
Am 19.10.22 um 17:27 schrieb Somalapuram Amaranath: Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- drivers/gpu/drm/radeon/radeon_object.c | 4 ++-- drivers/gpu/drm/radeon/radeon_trace.h | 2

Re: [PATCH 4/6] drm/nouveau: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Christian König
Am 19.10.22 um 17:27 schrieb Somalapuram Amaranath: Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath I'm not an expert for nouveau so it might be possible that we better use bo->base.size instead of bo->resource->size at some places. But that can be

Re: [PATCH 3/6] drm/i915: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Christian König
Am 19.10.22 um 17:27 schrieb Somalapuram Amaranath: Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath Acked-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- drivers/gpu/drm/i915/i915_scatterlist.c | 4 ++--

Re: [PATCH 2/6] drm/amd: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Christian König
Am 19.10.22 um 17:27 schrieb Somalapuram Amaranath: Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-

Re: [PATCH 1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-19 Thread Christian König
Am 19.10.22 um 17:27 schrieb Somalapuram Amaranath: Change ttm_resource structure from num_pages to size_t size in bytes. When you remove the num_pages field (instead of adding the size additionally) you need to change all drivers in one patch. Otherwise the build would break in between

Re: [PATCH 05/16] drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.

2022-10-19 Thread Intel
Hi, Zack, On 10/19/22 18:32, Zack Rusin wrote: On Wed, 2022-10-19 at 12:21 +0200, Thomas Hellström (Intel) wrote: ⚠ External Email On 10/17/22 21:54, Zack Rusin wrote: From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenence

Re: [PATCH 05/16] drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.

2022-10-19 Thread Zack Rusin
On Wed, 2022-10-19 at 12:21 +0200, Thomas Hellström (Intel) wrote: > ⚠ External Email > > On 10/17/22 21:54, Zack Rusin wrote: > > From: Maaz Mombasawala > > > > Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable > > to reduce maintenence burden. > > As part of this

[PATCH v1 0/7] vfio-ccw parent rework

2022-10-19 Thread Eric Farman
Hi all, There have been discussions and attempts [1][2] to rework the vfio-ccw device lifecycle to better align with the needs/expectations of vfio and mdev. While those languished, commit cb9ff3f3b84c ("vfio: Add helpers for unifying vfio_device life cycle") implemented a couple of tricks that

[PATCH v1 5/7] vfio/ccw: remove release completion

2022-10-19 Thread Eric Farman
There's enough separation between the parent and private structs now, that it is fine to remove the release completion hack. Signed-off-by: Eric Farman --- drivers/s390/cio/vfio_ccw_ops.c | 14 +- drivers/s390/cio/vfio_ccw_private.h | 3 --- 2 files changed, 1 insertion(+), 16

[PATCH v1 3/7] vfio/ccw: move private initialization to callback

2022-10-19 Thread Eric Farman
There's already a device initialization callback that is used to initialize the release completion workaround. Move the other elements of the vfio_ccw_private struct that require distinct initialization over to that routine. Signed-off-by: Eric Farman --- drivers/s390/cio/vfio_ccw_drv.c |

[PATCH v1 7/7] vfio: Remove vfio_free_device

2022-10-19 Thread Eric Farman
With the "mess" sorted out, we should be able to inline the vfio_free_device call introduced by commit cb9ff3f3b84c ("vfio: Add helpers for unifying vfio_device life cycle") and remove them from driver release callbacks. Signed-off-by: Eric Farman --- drivers/gpu/drm/i915/gvt/kvmgt.c | 1

[PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle

2022-10-19 Thread Eric Farman
Now that the mdev parent data is split out into its own struct, it is safe to move the remaining private data to follow the mdev probe/remove lifecycle. The mdev parent data will remain where it is, and follow the subchannel and the css driver interfaces. Signed-off-by: Eric Farman ---

[PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-19 Thread Eric Farman
Now that we have a reasonable separation of structs that follow the subchannel and mdev lifecycles, there's no reason we can't call the official vfio_alloc_device routine for our private data, and behave like everyone else. Signed-off-by: Eric Farman --- drivers/s390/cio/vfio_ccw_drv.c | 29

[PATCH v1 1/7] vfio/ccw: create a parent struct

2022-10-19 Thread Eric Farman
Move the stuff associated with the mdev parent (and thus the subchannel struct) into its own struct, and leave the rest in the existing private structure. The subchannel will point to the parent, and the parent will point to the private, for the areas where one or both are needed. Further

[PATCH v1 2/7] vfio/ccw: remove private->sch

2022-10-19 Thread Eric Farman
These places all rely on the ability to jump from a private struct back to the subchannel struct. Rather than keeping a copy in our back pocket, let's use the relationship provided by the vfio_device embedded within the private. Signed-off-by: Eric Farman --- drivers/s390/cio/vfio_ccw_chp.c

[PATCH 00/30] ARM: pxa: remove all unused boards

2022-10-19 Thread Arnd Bergmann
From: Arnd Bergmann Most of the legacy PXA board files were marked as unused in linux-5.19 and can get removed in linux-6.2. There is support for pxa250/pxa270/pxa300 using devicetree already, which supports a number of boards, but progress on converting the remaining ones has stalled over the

Re: [PATCH v4 13/17] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-10-19 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti

Re: [PATCH v4 14/17] drm/i915/vm_bind: Expose i915_request_await_bind()

2022-10-19 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. Reviewed-by: Andi Shyti Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 8

Re: [PATCH] drm: tests: Fix a buffer overflow in format_helper_test

2022-10-19 Thread Javier Martinez Canillas
On 10/19/22 13:36, Maíra Canal wrote: > [cc Javier] > > Hi David, > > On 10/19/22 04:32, David Gow wrote: >> The xrgb2101010 format conversion test (unlike for other formats) does >> an endianness conversion on the results. However, it always converts >> TEST_BUF_SIZE 32-bit integers, which

Re: [PATCH v2 36/37] arm64: dts: zynqmp: Add ports for the DisplayPort subsystem

2022-10-19 Thread Laurent Pinchart
Hi Michal, I plan to send a pull request for the series soon. Patches 01/37 to 35/37 will go through the DRM tree. How would you like to handle this patch and the next ? They depend on the DT binding changes in 01/37. On Thu, Sep 29, 2022 at 01:47:18AM +0300, Laurent Pinchart wrote: > The DPSUB

[PATCH 00/30] ARM: pxa: remove all unused boards

2022-10-19 Thread Arnd Bergmann
From: Arnd Bergmann Most of the legacy PXA board files were marked as unused in linux-5.19 and can get removed in linux-6.2. There is support for pxa250/pxa270/pxa300 using devicetree already, which supports a number of boards, but progress on converting the remaining ones has stalled over the

Re: [PATCH] drm/connector: Set DDC pointer in drmm_connector_init

2022-10-19 Thread Thomas Zimmermann
Am 19.10.22 um 16:34 schrieb Maxime Ripard: Commit 35a3b82f1bdd ("drm/connector: Introduce drmm_connector_init") introduced the function drmm_connector_init() with a parameter for an optional ddc pointer to the i2c controller used to access the DDC bus. However, the underlying call to

Re: [PATCH v3 2/4] dt-bindings: display: add new bus-format property for panel-dpi

2022-10-19 Thread Dave Stevenson
Hi Laurent On Sun, 16 Oct 2022 at 02:33, Laurent Pinchart wrote: > > Hello, > > On Fri, Oct 14, 2022 at 03:08:49PM +0100, Dave Stevenson wrote: > > On Thu, 13 Oct 2022 at 13:58, Francesco Dolcini wrote: > > > On Tue, Jun 28, 2022 at 08:18:36PM +0200, Max Krummenacher wrote: > > > > From: Max

[PATCH 6/6] drm/vmwgfx: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c| 6 +++--- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 2 +-

[PATCH 5/6] drm/radeon: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- drivers/gpu/drm/radeon/radeon_object.c | 4 ++-- drivers/gpu/drm/radeon/radeon_trace.h | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++-- 4 files

[PATCH 4/6] drm/nouveau: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo0039.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo5039.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo74c1.c | 2 +-

[PATCH 3/6] drm/i915: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- drivers/gpu/drm/i915/i915_scatterlist.c | 4 ++-- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 12 ++--

[PATCH 2/6] drm/amd: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 4 ++--

[PATCH 1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Change ttm_resource structure from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/ttm/ttm_bo.c| 4 ++-- drivers/gpu/drm/ttm/ttm_bo_util.c | 6 +++--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++--

  1   2   >