Re: [PATCH] drm_bridge: register content protect property

2022-11-01 Thread 胡俊光

Re: [Intel-gfx] [PULL] drm-intel-next

2022-11-01 Thread Ville Syrjälä
On Tue, Nov 01, 2022 at 10:29:24PM +, Vivi, Rodrigo wrote: > On Sat, 2022-10-29 at 02:41 +0300, Ville Syrjälä wrote: > > On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > > > Hi Dave and Daniel, > > > > > > Here goes the first chunk of drm-intel-next targeting 6.2 > > > > > >

Re: [PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-01 Thread Hillf Danton
On 1 Nov 2022 15:33:10 -0700 Rob Clark > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -500,6 +500,21 @@ static void hangcheck_timer_reset(struct msm_gpu *gpu) > round_jiffies_up(jiffies + > msecs_to_jiffies(priv->hangcheck_period))); > } >

Re: [PATCH v2] dma-buf: fix racing conflict of dma_heap_add()

2022-11-01 Thread T.J. Mercier
On Mon, Oct 31, 2022 at 7:53 AM Dawei Li wrote: > > Racing conflict could be: > task A task B > list_for_each_entry > strcmp(h->name)) >list_for_each_entry >strcmp(h->name) > kzallockzalloc > ..

Re: [PATCH] drm: bridge: samsung-dsim: Add i.MX8M Plus support

2022-11-01 Thread Marcel Ziswiler
Hi Marek On Sun, 2022-10-16 at 00:07 +0200, Marek Vasut wrote: > Add extras to support i.MX8M Plus. The main change is the removal of > HS/VS/DE signal inversion in the LCDIFv3-DSIM glue logic, otherwise > the implementation of this IP in i.MX8M Plus is very much compatible > with the i.MX8M

[PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-01 Thread John . C . Harrison
From: John Harrison At the end of each test, IGT does a drop caches call via sysfs with special flags set. One of the possible paths waits for idle with an infinite timeout. That causes problems for debugging issues when CI catches a "can't go idle" test failure. Best case, the CI system times

Re: [PATCH] drm/radeon: Replace kmap() with kmap_local_page()

2022-11-01 Thread Kees Cook
On Wed, Nov 02, 2022 at 12:11:53AM +0100, Fabio M. De Francesco wrote: > On lunedì 17 ottobre 2022 18:52:10 CET Alex Deucher wrote: > > Applied. Thanks! > > Many thanks to you! > > However, about a week ago, I received a report saying that this patch is "Not > Applicable". > > That email was

Re: [RESEND PATCH] drm/amd/amdgpu: Replace kmap() with kmap_local_page()

2022-11-01 Thread Fabio M. De Francesco
On lunedì 17 ottobre 2022 18:53:24 CET Alex Deucher wrote: > Applied. Thanks! > The same report about which I just wrote in my previous email to you is also referring to this patch which later changed status to "Not Applicable". It points to

Re: [PATCH] drm/radeon: Replace kmap() with kmap_local_page()

2022-11-01 Thread Fabio M. De Francesco
On lunedì 17 ottobre 2022 18:52:10 CET Alex Deucher wrote: > Applied. Thanks! Many thanks to you! However, about a week ago, I received a report saying that this patch is "Not Applicable". That email was also referring to another patch, for which I'll reply in its own thread. That report

Re: [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

2022-11-01 Thread Kees Cook
On Sat, Oct 29, 2022 at 11:01:38AM +0300, Gwan-gyeong Mun wrote: > > > On 10/29/22 10:32 AM, Kees Cook wrote: > > On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote: > > > Hi Kees, > > > > Hi! :) > > > > > I've updated to v5 with the last comment of Nathan. > > > Could you please

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Kees Cook
On Tue, Nov 01, 2022 at 06:09:16PM -0400, Alex Deucher wrote: > On Tue, Nov 1, 2022 at 5:54 PM Kees Cook wrote: > > Does the ROM always only have a single byte there? This seems unlikely > > given the member "ucFakeEDIDLength" (and the code below). > > I'm not sure. I'm mostly concerned about

[PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-01 Thread Rob Clark
From: Rob Clark If the hangcheck timer expires, check if the fw's position in the cmdstream has advanced (changed) since last timer expiration, and allow it up to three additional "extensions" to it's alotted time. The intention is to continue to catch "shader stuck in a loop" type hangs

[PATCH v2 1/2] drm/msm/adreno: Simplify read64/write64 helpers

2022-11-01 Thread Rob Clark
From: Rob Clark The _HI reg is always following the _LO reg, so no need to pass these offsets seprately. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 3 +-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c |

[PATCH v2 0/2] drm/msm: Improved hang detection

2022-11-01 Thread Rob Clark
From: Rob Clark Try to detect when submit jobs are making forward progress and give them a bit more time. Rob Clark (2): drm/msm/adreno: Simplify read64/write64 helpers drm/msm: Hangcheck progress detection drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 3 +-

Re: [Intel-gfx] [PULL] drm-intel-next

2022-11-01 Thread Vivi, Rodrigo
On Sat, 2022-10-29 at 02:41 +0300, Ville Syrjälä wrote: > On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Here goes the first chunk of drm-intel-next targeting 6.2 > > > > The highlight goes to Ville with many display related clean-up > > and

Re: [PATCH 2/2] drm/msm: Hangcheck progress detection

2022-11-01 Thread Rob Clark
On Tue, Nov 1, 2022 at 12:54 PM Akhil P Oommen wrote: > > On 11/1/2022 4:24 AM, Rob Clark wrote: > > From: Rob Clark > > > > If the hangcheck timer expires, check if the fw's position in the > > cmdstream has advanced (changed) since last timer expiration, and > > allow it up to three additional

Re: [PATCH] drm/panel/panel-sitronix-st7701: Remove panel on DSI attach failure

2022-11-01 Thread Linus Walleij
On Sat, Oct 15, 2022 at 1:11 AM Marek Vasut wrote: > In case mipi_dsi_attach() fails, call drm_panel_remove() to avoid memory leak. > > Fixes: 849b2e3ff9698 ("drm/panel: Add Sitronix ST7701 panel driver") > Signed-off-by: Marek Vasut Patch applied, fixed up some complaints from checkpatch.

Re: [PATCH] drm/panel/panel-sitronix-st7701: Clean up CMDnBKx selection

2022-11-01 Thread Linus Walleij
On Sat, Oct 15, 2022 at 1:10 AM Marek Vasut wrote: > There are two command register files, CMD1 and CMD2, where only the CMD2 > contains additional register sub-files BK0..3 . Pull the register file > selection call into separate function instead of duplicating it all over > the driver. The

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Alex Deucher
On Tue, Nov 1, 2022 at 5:54 PM Kees Cook wrote: > > On Tue, Nov 01, 2022 at 10:42:14AM -0400, Alex Deucher wrote: > > On Fri, Oct 28, 2022 at 11:32 PM Paulo Miguel Almeida > > wrote: > > > > > > One-element arrays are deprecated, and we are replacing them with > > > flexible array members

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Kees Cook
On Tue, Nov 01, 2022 at 10:42:14AM -0400, Alex Deucher wrote: > On Fri, Oct 28, 2022 at 11:32 PM Paulo Miguel Almeida > wrote: > > > > One-element arrays are deprecated, and we are replacing them with > > flexible array members instead. So, replace one-element array with > > flexible-array member

[PATCH] drm/msm: Remove exclusive-fence hack

2022-11-01 Thread Rob Clark
From: Rob Clark The workaround was initially necessary due to dma_resv having only a single exclusive fence slot, yet whe don't necessarily know what order the gpu scheduler will schedule jobs. Unfortunately this workaround also has the result of forcing implicit sync, even when userspace does

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Introduce Wa_18017747507

2022-11-01 Thread Matt Roper
On Mon, Oct 31, 2022 at 06:15:09AM -0700, Wayne Boyer wrote: > WA 18017747507 applies to all DG2 skus. > > BSpec: 56035, 46121, 68173 > > Signed-off-by: Wayne Boyer > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++ > drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ > 2 files

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Alex Deucher
On Tue, Nov 1, 2022 at 5:14 PM Paulo Miguel Almeida wrote: > > On Tue, Nov 01, 2022 at 10:42:14AM -0400, Alex Deucher wrote: > > On Fri, Oct 28, 2022 at 11:32 PM Paulo Miguel Almeida > > wrote: > > > > > > One-element arrays are deprecated, and we are replacing them with > > > flexible array

[PATCH 15/30] video: fbdev: omapfb: Use kstrtobool() instead of strtobool()

2022-11-01 Thread Christophe JAILLET
strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file () Signed-off-by: Christophe JAILLET --- This patch

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Paulo Miguel Almeida
On Tue, Nov 01, 2022 at 10:42:14AM -0400, Alex Deucher wrote: > On Fri, Oct 28, 2022 at 11:32 PM Paulo Miguel Almeida > wrote: > > > > One-element arrays are deprecated, and we are replacing them with > > flexible array members instead. So, replace one-element array with > > flexible-array member

Re: Try to address the DMA-buf coherency problem

2022-11-01 Thread Nicolas Dufresne
Le mardi 01 novembre 2022 à 18:40 +0100, Christian König a écrit : > Am 28.10.22 um 20:47 schrieb Daniel Stone: > > Hi Christian, > > > > On Fri, 28 Oct 2022 at 18:50, Christian König > > wrote: > > > Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: > > > > Though, its not generically possible to

Re: [PATCH 1/2] drm/msm/adreno: Simplify read64/write64 helpers

2022-11-01 Thread Akhil P Oommen
On 11/1/2022 4:24 AM, Rob Clark wrote: From: Rob Clark The _HI reg is always following the _LO reg, so no need to pass these offsets seprately. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 3 +-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 27

Re: [PATCH 2/2] drm/msm: Hangcheck progress detection

2022-11-01 Thread Akhil P Oommen
On 11/1/2022 4:24 AM, Rob Clark wrote: From: Rob Clark If the hangcheck timer expires, check if the fw's position in the cmdstream has advanced (changed) since last timer expiration, and allow it up to three additional "extensions" to it's alotted time. The intention is to continue to catch

Re: [PULL] drm-intel-gt-next

2022-11-01 Thread Dave Airlie
On Mon, 31 Oct 2022 at 21:07, Joonas Lahtinen wrote: > > Hi Dave & Daniel, > > Here goes first drm-intel-gt-next pull req towards 6.2. > > We have a fix for #6222 (kernel memory corruption issue) and fix for > display regression after resume. A missing W/A for Gen12 iGPUs and > extension of

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 1 Nov 2022 14:17:26 -0300 Isabella Basso wrote: > Hi, Mauro, > > > Am 01/11/2022 um 9:33 AM schrieb Mauro Carvalho Chehab > > : > > > > Hi Isabella, > > > > On Mon, 19 Sep 2022 17:43:19 -0300 > > Isabella Basso wrote: > > > >>> Do you want to _require_ KUnit be built as a module,

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start

2022-11-01 Thread Christian König
Hi Mikhail, Am 30.10.22 um 23:05 schrieb Mikhail Gavrilov: On Wed, Oct 26, 2022 at 12:29 PM Christian König wrote: Attached is the original test patch rebased on current amd-staging-drm-next. Can you test if this is enough to make sure that the games start without crashing by fetching the

Re: Try to address the DMA-buf coherency problem

2022-11-01 Thread Christian König
Am 28.10.22 um 20:47 schrieb Daniel Stone: Hi Christian, On Fri, 28 Oct 2022 at 18:50, Christian König wrote: Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: Though, its not generically possible to reverse these roles. If you want to do so, you endup having to do like Android (gralloc) and

Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 10:37:14PM +0800, Yi Liu wrote: > > @@ -784,12 +791,6 @@ static struct file *vfio_device_open(struct > > vfio_device *device) > > struct file *filep; > > int ret; > > - mutex_lock(>group->group_lock); > > - ret = vfio_device_assign_container(device); > > -

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-01 Thread Jessica Zhang
On 10/31/2022 5:11 PM, Dmitry Baryshkov wrote: Hi, On 01/11/2022 01:24, Jessica Zhang wrote: On 10/29/2022 5:08 AM, Dmitry Baryshkov wrote: On 29/10/2022 01:59, Jessica Zhang wrote: Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for drm_plane. In addition, add support for

Re: [PATCH v2] drm: lcdif: change burst size to 256B

2022-11-01 Thread Marek Vasut
On 11/1/22 17:46, Marco Felsch wrote: If a axi bus master with a higher priority do a lot of memory access FIFO underruns can be inspected. Increase the burst size to 256B to avoid such underruns and to improve the memory access efficiency. Fixes: 9db35bb349a0 ("drm: lcdif: Add support for

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Isabella Basso
Hi, Mauro, > Am 01/11/2022 um 9:33 AM schrieb Mauro Carvalho Chehab > : > > Hi Isabella, > > On Mon, 19 Sep 2022 17:43:19 -0300 > Isabella Basso wrote: > >>> Do you want to _require_ KUnit be built as a module, rather than built-in >>> here? >> >> I’ll change the comment and the warning

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
On 22-11-01, Marek Vasut wrote: > On 11/1/22 17:51, Marco Felsch wrote: > > On 22-11-01, Marek Vasut wrote: > > > On 11/1/22 17:06, Marco Felsch wrote: > > > > > > Hi, > > > > > > > > > Also I understood the thresholds in such a way, that the FIFO > > > > > > watermark > > > > > > must be

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 17:51, Marco Felsch wrote: On 22-11-01, Marek Vasut wrote: On 11/1/22 17:06, Marco Felsch wrote: Hi, Also I understood the thresholds in such a way, that the FIFO watermark must be higher but there is no place left when it is set to 3/3. In such case this means that the PANIC will

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-01 Thread John Harrison
On 11/1/2022 02:58, Tvrtko Ursulin wrote: On 31/10/2022 18:30, John Harrison wrote: On 10/31/2022 05:51, Tvrtko Ursulin wrote: On 31/10/2022 10:09, Tvrtko Ursulin wrote: On 28/10/2022 20:46, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
On 22-11-01, Marek Vasut wrote: > On 11/1/22 17:06, Marco Felsch wrote: > > Hi, > > > > > Also I understood the thresholds in such a way, that the FIFO watermark > > > > must be higher but there is no place left when it is set to 3/3. In such > > > > case this means that the PANIC will never

[PATCH v2] drm: lcdif: change burst size to 256B

2022-11-01 Thread Marco Felsch
If a axi bus master with a higher priority do a lot of memory access FIFO underruns can be inspected. Increase the burst size to 256B to avoid such underruns and to improve the memory access efficiency. Fixes: 9db35bb349a0 ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off-by: Marco

[PATCH RFC] drm/i915: allow running mock selftests via Kunit

2022-11-01 Thread Mauro Carvalho Chehab
The mock selftests don't require any hardware to run. They can easily run via kunit with qemu or bare metal. Add support for it. With this change, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \

[PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible

2022-11-01 Thread Luca Weiss
Document the compatible for the wled block found in PMI8950. Signed-off-by: Luca Weiss --- Changes since v2: * New patch Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 17:06, Marco Felsch wrote: Hi, Also I understood the thresholds in such a way, that the FIFO watermark must be higher but there is no place left when it is set to 3/3. In such case this means that the PANIC will never left once it was entered. I think this part is wrong. Consider

Re: [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-11-01 Thread Nilawar, Badal
Hi Matt, On 01-11-2022 20:47, Matt Roper wrote: On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: This workaround is added for Media Tile of MTL A step. It is to help pcode workaround which handles the hardware bug seen on CXL splitter during package C2/C3 transitins due to MC6

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Alex Deucher
On Tue, Nov 1, 2022 at 11:42 AM Filip Moc wrote: > > Hello Alex, > > thank you for your response. > > Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 > seems to work the best in my case. > > I added a dmi based quirk table. So far with support only for display 0 > to make it

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
On 22-11-01, Marek Vasut wrote: > On 11/1/22 15:04, Marco Felsch wrote: > > Hi Marek, Liu, > > Hi, > > [...] > > > > > > Also IMHO the threshold should be taken wisely to not enter panic > > > > > mode > > > > > to early to not block others from the bus e.g. the GPU. > > > > > > > > As far as

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Filip Moc
Hello Alex, thank you for your response. Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 seems to work the best in my case. I added a dmi based quirk table. So far with support only for display 0 to make it simple. Support for more displays in quirk table can be added later

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Filip Moc
Hello Harry, thank you for your response. > amdgpu.backlight_min=2:-1 almost :-) Array elements in module parameters are separated by commas not colons. So for cmdline it should look like this: amdgpu.backlight_min=2,-1 Though you can just drop the ,-1 relying on kernel leaving the rest of

Re: [PATCH] video: fbdev: omapfb: remove redundant variable checksum

2022-11-01 Thread Helge Deller
On 11/1/22 11:29, Colin Ian King wrote: Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed. Signed-off-by: Colin Ian King applied. Thanks! Helge --- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --

Re: [PATCH v1 1/2] fbdev: ssd1307fb: Drop optional dependency

2022-11-01 Thread Helge Deller
On 11/1/22 16:09, Andy Shevchenko wrote: Only a single out of three devices need a PWM, so from driver it's optional. Moreover it's a single driver in the entire kernel that currently selects PWM. Unfortunately this selection is a root cause of the circular dependencies when we want to enable

[PATCH v2] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge, the LCDIFv3 becomes susceptible to FIFO underflows, these lead to nasty flicker of the image on the panel, or image being shifted by half frame horizontally every second frame. The flicker can be easily triggered by running

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 15:04, Marco Felsch wrote: Hi Marek, Liu, Hi, [...] Also IMHO the threshold should be taken wisely to not enter panic mode to early to not block others from the bus e.g. the GPU. As far as I understand the PANIC0_THRES, both thresholds are really watermarks in the FIFO,

Re: [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-11-01 Thread Matt Roper
On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: > This workaround is added for Media Tile of MTL A step. It is to help > pcode workaround which handles the hardware bug seen on CXL splitter > during package C2/C3 transitins due to MC6 entry/exit. As a part of > workaround pcode

[PATCH v1 2/2] fbdev: ssd1307fb: Drop duplicate NULL checks for PWM APIs

2022-11-01 Thread Andy Shevchenko
pwm_disable() and pwm_put() are NULL-aware, no need to duplicate the check in the caller. Signed-off-by: Andy Shevchenko --- drivers/video/fbdev/ssd1307fb.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c

[PATCH v1 1/2] fbdev: ssd1307fb: Drop optional dependency

2022-11-01 Thread Andy Shevchenko
Only a single out of three devices need a PWM, so from driver it's optional. Moreover it's a single driver in the entire kernel that currently selects PWM. Unfortunately this selection is a root cause of the circular dependencies when we want to enable optional PWM for some other drivers that

Re: [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-01 Thread Doug Anderson
Hi, On Mon, Oct 31, 2022 at 5:15 PM Dmitry Baryshkov wrote: > > On 01/11/2022 03:08, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 31, 2022 at 2:11 PM Kuogee Hsieh > > wrote: > >> > >> Hi Dmitry, > >> > >> > >> Link rate is advertised by sink, but adjusted (reduced the link rate) > >> by

Re: [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: These functions don't really assign anything anymore, they just increment some refcounts and do a sanity check. Call them vfio_group_[un]use_container() Signed-off-by: Jason Gunthorpe --- drivers/vfio/container.c | 14 ++

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Alex Deucher
On Fri, Oct 28, 2022 at 11:32 PM Paulo Miguel Almeida wrote: > > One-element arrays are deprecated, and we are replacing them with > flexible array members instead. So, replace one-element array with > flexible-array member in struct _ATOM_FAKE_EDID_PATCH_RECORD and > refactor the rest of the

Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: The only thing this function does is assert the group has an assigned container and incrs refcounts. The overall model we have is that once a conatiner_users refcount is typo. s/conatiner_users/container_users incremented it cannot be de-assigned

Re: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: This error unwind is getting complicated. Move all the code into two pair'd function. The functions should be called when the open_count == 1 after incrementing/before decrementing. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 95

Re: [PATCH] drm/radeon: Use a local mutex for bind/unbind protection

2022-11-01 Thread Alex Deucher
On Mon, Oct 31, 2022 at 2:49 AM Takashi Iwai wrote: > > We used drm_modeset_lock_all() for protecting the audio component > bind/unbind operations against the notification, but it seems leading > to kernel WARNING and Oops. Moreover, the use of > drm_modeset_lock_all() is rather an overkill only

Re: [PATCH] drm/amd/display (gcc13): fix enum mismatch

2022-11-01 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 31, 2022 at 9:59 AM Harry Wentland wrote: > > On 2022-10-31 07:42, Jiri Slaby (SUSE) wrote: > > rn_vbios_smu_set_dcn_low_power_state() produces a valid warning with > > gcc-13: > > > >

Re: [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-01 Thread Eric Farman
On Tue, 2022-11-01 at 09:08 +, Tian, Kevin wrote: > > From: Eric Farman > > Sent: Thursday, October 20, 2022 12:22 AM > > > > @@ -101,15 +101,20 @@ static int vfio_ccw_mdev_probe(struct > > mdev_device *mdev) > >  { > > struct subchannel *sch = to_subchannel(mdev->dev.parent); > >    

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Daniel Latypov
On Tue, Nov 1, 2022, 6:53 AM Mauro Carvalho Chehab wrote: > > Ah, the selection is in kunit.ko itself. kunit.filter_glob, set from > > kunit.py with > > > > positional arguments: > > filter_glob Filter which KUnit test suites/tests run at > > boot-time, e.g. list* or list*.*del_test

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
Hi Marek, Liu, On 22-10-28, Liu Ying wrote: > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > > On 10/27/22 19:47, Marco Felsch wrote: > > > On 22-10-27, Liu Ying wrote: > > > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > > > > On 10/27/22 07:45, Liu Ying wrote: > > > > > >

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 1 Nov 2022 15:16:02 +0200 Petri Latvala wrote: > On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote: > > On Tue, 20 Sep 2022 11:18:25 +0300 > > Petri Latvala wrote: > > > > > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > > > As the DRM selftests

Re: [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-01 Thread kernel test robot
Hi Stanislav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm/drm-next linus/master v6.1-rc3 next-20221101] [cannot apply to drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH] drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid

2022-11-01 Thread Philipp Zabel
On Di, 2022-09-13 at 13:55 -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, >  struct drm_display_mode *mode); > > The

Re: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

2022-11-01 Thread Philipp Zabel
On So, 2022-10-09 at 10:35 +0800, Liu Ying wrote: > A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file > by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"), > so remove it. > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") >

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Petri Latvala
On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote: > On Tue, 20 Sep 2022 11:18:25 +0300 > Petri Latvala wrote: > > > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > > As the DRM selftests are now using KUnit [1], update IGT tests as well. > > > > > > [1]

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-11-01 Thread jim . cromie
On Tue, Nov 1, 2022 at 2:52 AM Ville Syrjälä wrote: > > On Mon, Oct 31, 2022 at 08:20:54PM -0400, Jason Baron wrote: > > > > > > On 10/31/22 6:11 PM, jim.cro...@gmail.com wrote: > > > On Mon, Oct 31, 2022 at 7:07 AM Ville Syrjälä > > > wrote: > > >> On Sun, Oct 30, 2022 at 08:42:52AM -0600,

Re: [PATCH 09/10] vfio: Make vfio_container optionally compiled

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:41:56AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > if VFIO > > +config VFIO_CONTAINER > > + bool "Support for the VFIO container /dev/vfio/vfio" > > + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 ||

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-11-01 Thread Yi Liu
On 2022/11/1 19:41, Jason Gunthorpe wrote: On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: On 2022/11/1 07:24, Jason Gunthorpe wrote: On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: There is something wrong with the test suite that it isn't covering the above, I'm going to

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 20 Sep 2022 11:18:25 +0300 Petri Latvala wrote: > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > As the DRM selftests are now using KUnit [1], update IGT tests as well. > > > > [1] - > > https://lore.kernel.org/all/20220708203052.236290-1-maira.ca...@usp.br/ > > >

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-11-01 Thread Yi Liu
On 2022/11/1 12:21, Nicolin Chen wrote: On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: On 2022/11/1 07:24, Jason Gunthorpe wrote: On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: There is something wrong with the test suite that it isn't covering the above, I'm going to look

RE: [v7] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-01 Thread Kalyan Thota
>-Original Message- >From: Marijn Suijten >Sent: Tuesday, November 1, 2022 5:13 PM >To: Kalyan Thota (QUIC) >Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org;

Re: [PATCH 08/10] vfio-iommufd: Support iommufd for emulated VFIO devices

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:37:39AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and > > consist of all the mdev drivers. > > > > Like the physical drivers, support

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Mon, 19 Sep 2022 17:25:38 -0700 Daniel Latypov wrote: > On Mon, Sep 19, 2022 at 1:43 PM Isabella Basso wrote: > > >> +* "(K)TAP version XX" should be the first line on all > > >> (sub)tests as per > > >> +* > > >>

Re: [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > menuconfig VFIO > > tristate "VFIO Non-Privileged userspace driver framework" > > select IOMMU_API > > + depends on IOMMUFD || !IOMMUFD > > Out

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
Hi Isabella, On Mon, 19 Sep 2022 17:43:19 -0300 Isabella Basso wrote: > > Do you want to _require_ KUnit be built as a module, rather than built-in > > here? > > I’ll change the comment and the warning in v3 to clarify this. When do you intend to submit v3? Regards, Mauro

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Thu, 1 Sep 2022 14:37:06 +0800 David Gow wrote: > On Mon, Aug 29, 2022 at 8:10 AM Isabella Basso wrote: > > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1]

Re: [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:52:23AM +, Tian, Kevin wrote: > > IOMMU_CAP_ENFORCE_CACHE_COHERENCY we know what the > > iommu_domain will be > > capable of without having to create it. Use this to compute > > it's worth noting that the prerequisite is that vfio always enforces > cache coherency

Re: [PATCH v8 12/15] drm/msm/disp/dpu: get timing engine status from intf status register

2022-11-01 Thread Marijn Suijten
On 2022-10-12 17:32:36, Vinod Polimera wrote: > Timing gen status can be read reliablly from intf status Typo. "reliably read from the intf status register..." > register rather than from the timing gen control register, > which will readback as "0" after disable though the timing > gen is still

Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:38:47AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:17 AM > > > > +err_container: > > + vfio_device_unassign_container(device); > > err_module_put: > > device->kvm = NULL; > > err_module_put should be moved after

Re: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:33:30AM +, Tian, Kevin wrote: > > + /* > > +* Here we pass the KVM pointer with the group under the read lock. > > Now the read lock is replaced by mutex. Let's correct it when moving this > piece of code. Done, thanks Jason

Re: [PATCH] drm/msm/disp/dpu1: register crtc color management to first crtc in the list

2022-11-01 Thread Marijn Suijten
On 2022-11-01 03:59:21, Kalyan Thota wrote: > This patch does the following: Don't self-reference "this patch": https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > 1) Registers crtc color management to the first crtc in the list and > attach to an

Re: [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 02:19:04AM -0700, Nicolin Chen wrote: > On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > > > From: Jason Gunthorpe > > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > > > menuconfig VFIO > > > tristate "VFIO Non-Privileged userspace driver

Re: [v7] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-01 Thread Marijn Suijten
On 2022-11-01 03:57:05, Kalyan Thota wrote: > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: > On 2022/11/1 07:24, Jason Gunthorpe wrote: > > On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: > > > > There is something wrong with the test suite that it isn't covering > > > > the above, I'm going to look into that today. > > >

[PATCH AUTOSEL 5.10 13/14] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-11-01 Thread Sasha Levin
From: Danijel Slivka [ Upstream commit 65f8682b9aaae20c2cdee993e6fe52374ad513c9 ] For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to

[PATCH AUTOSEL 5.15 17/19] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-11-01 Thread Sasha Levin
From: Danijel Slivka [ Upstream commit 65f8682b9aaae20c2cdee993e6fe52374ad513c9 ] For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to

[PATCH AUTOSEL 6.0 30/34] drm/amdgpu: dequeue mes scheduler during fini

2022-11-01 Thread Sasha Levin
From: YuBiao Wang [ Upstream commit 2abe92c7adc9c0397ba51bf74909b85bc0fff84b ] [Why] If mes is not dequeued during fini, mes will be in an uncleaned state during reload, then mes couldn't receive some commands which leads to reload failure. [How] Perform MES dequeue via MMIO after all the

[PATCH AUTOSEL 6.0 29/34] drm/amdgpu: Program GC registers through RLCG interface in gfx_v11/gmc_v11

2022-11-01 Thread Sasha Levin
From: Yifan Zha [ Upstream commit 97a3d6090f5c2a165dc88bda05c1dcf9f08bf886 ] [Why] L1 blocks most of GC registers accessing by MMIO. [How] Use RLCG interface to program GC registers under SRIOV VF in full access time. Signed-off-by: Yifan Zha Reviewed-by: Hawking Zhang Acked-by: Alex

[PATCH AUTOSEL 6.0 28/34] drm/amdkfd: Fix type of reset_type parameter in hqd_destroy() callback

2022-11-01 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit e688ba3e276422aa88eae7a54186a95320836081 ] When booting a kernel compiled with CONFIG_CFI_CLANG on a machine with an RX 6700 XT, there is a CFI failure in kfd_destroy_mqd_cp(): [ 12.894543] CFI failure at kfd_destroy_mqd_cp+0x2a/0x40 [amdgpu]

[PATCH AUTOSEL 6.0 27/34] drm/amd/pm: skip loading pptable from driver on secure board for smu_v13_0_10

2022-11-01 Thread Sasha Levin
From: Kenneth Feng [ Upstream commit f700486cd1f2bf381671d1c2c7dc9000db10c50e ] skip loading pptable from driver on secure board since it's loaded from psp. Signed-off-by: Kenneth Feng Reviewed-by: Guan Yu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.0 26/34] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-11-01 Thread Sasha Levin
From: Danijel Slivka [ Upstream commit 65f8682b9aaae20c2cdee993e6fe52374ad513c9 ] For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to

[PATCH AUTOSEL 6.0 20/34] drm/vc4: hdmi: Check the HSM rate at runtime_resume

2022-11-01 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 4190e8bbcbc77a9c36724681801cedc5229e7fc2 ] If our HSM clock has not been properly initialized, any register access will silently lock up the system. Let's check that this can't happen by adding a check for the rate before any register access, and error out

[PATCH] drm/bridge: it6505: handle HDCP request

2022-11-01 Thread Hsin-Yi Wang
it6505 supports HDCP 1.3, but current implementation lacks the update of HDCP status through drm_hdcp_update_content_protection(). it6505 default enables the HDCP. If user set it to undesired then the driver will stop HDCP. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/ite-it6505.c |

RE: [PATCH v8 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-11-01 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, October 27, 2022 11:11 PM > To: Vinod Polimera ; Vinod Polimera (QUIC) > ; dri-devel@lists.freedesktop.org; linux-arm- > m...@vger.kernel.org; freedr...@lists.freedesktop.org; > devicet...@vger.kernel.org > Cc:

  1   2   >