Re: [PATCH v2] dt-bindings: display: mediatek: Compatible list cleanup

2023-03-02 Thread Yassine Oudjana
On Thu, Mar 2 2023 at 05:08:30 PM +01:00:00, AngeloGioacchino Del Regno wrote: Il 02/03/23 15:12, Yassine Oudjana ha scritto: From: Yassine Oudjana Several DT bindings of MediaTek display blocks make unnecessary use of "oneOf" and "items". Remove them and replace them with enums where

Re: [PATCH v2] dt-bindings: display: mediatek: Compatible list cleanup

2023-03-02 Thread Krzysztof Kozlowski
On 02/03/2023 17:08, AngeloGioacchino Del Regno wrote: > Il 02/03/23 15:12, Yassine Oudjana ha scritto: >> From: Yassine Oudjana >> >> Several DT bindings of MediaTek display blocks make unnecessary use of >> "oneOf" and "items". Remove them and replace them with enums where >> necessary. >>

Re: [PATCH v6] drm/virtio: Add option to disable KMS support

2023-03-02 Thread Gerd Hoffmann
On Thu, Mar 02, 2023 at 03:35:06PM -0800, Rob Clark wrote: > From: Rob Clark > > Add a build option to disable modesetting support. This is useful in > cases where the guest only needs to use the GPU in a headless mode, or > (such as in the CrOS usage) window surfaces are proxied to a host >

[PATCH] Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-02 Thread Somalapuram Amaranath
Change the ttm_place structure member fpfn, lpfn, mem_type to res_start, res_end, res_type. Change the unsigned to u64. Fix the dependence in all the DRM drivers and clean up PAGE_SHIFT operation. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 11 +-

Re: [PATCH] drm/i915/gvt: Make use of idr_find and idr_for_each_entry in dmabuf

2023-03-02 Thread Zhenyu Wang
On 2023.03.02 19:53:18 +0800, Cai Huoqing wrote: > This patch uses the already existing IDR mechanism to simplify > and improve the dmabuf code. > > Using 'vgpu.object_idr' directly instead of 'dmabuf_obj_list_head' > or 'dmabuf.list', because the dmabuf_obj can be found by 'idr_find' > or

[PATCH v2 5/7] drm/i915/display: Fill in native_420 field

2023-03-02 Thread Suraj Kandpal
Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. ---v2 -adding native_422 field as 0 [Vandita] -filling in second_line_bpg_offset, second_line_offset_adj and nsl_bpg_offset in vds_cfg when native_420

Re: [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-02 Thread Rodrigo Vivi
On Thu, Mar 02, 2023 at 03:53:37PM -0800, Rob Clark wrote: > From: Rob Clark > missing some wording here... > v2: rebase > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/i915/i915_request.c | 20 > 1 file changed, 20 insertions(+) > > diff --git

Re: [PATCH v6 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-03-02 Thread Teres Alexis, Alan Previn
On Mon, 2023-02-27 at 18:21 -0800, Teres Alexis, Alan Previn wrote: > Add helper functions into a new file for heci-packet-submission. > The helpers will handle generating the MTL GSC-CS Memory-Header > and submission of the Heci-Cmd-Packet instructions to the engine. > > alan:snip > +int >

[PATCH v9 12/15] drm/msm: Add deadline based boost support

2023-03-02 Thread Rob Clark
From: Rob Clark Track the nearest deadline on a fence timeline and set a timer to expire shortly before to trigger boost if the fence has not yet been signaled. v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fence.c | 74 +

[PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-02 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644 ---

[PATCH v9 14/15] drm/msm/atomic: Switch to vblank_start helper

2023-03-02 Thread Rob Clark
From: Rob Clark Drop our custom thing and switch to drm_crtc_next_vblank_start() for calculating the time of the start of the next vblank period. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 --- drivers/gpu/drm/msm/msm_atomic.c| 8 +---

[PATCH v9 13/15] drm/msm: Add wait-boost support

2023-03-02 Thread Rob Clark
From: Rob Clark Add a way for various userspace waits to signal urgency. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 12 drivers/gpu/drm/msm/msm_gem.c | 5 + include/uapi/drm/msm_drm.h| 14 -- 3 files changed, 25 insertions(+), 6 deletions(-)

[PATCH v9 10/15] drm/vblank: Add helper to get next vblank time

2023-03-02 Thread Rob Clark
From: Rob Clark Will be used in the next commit to set a deadline on fences that an atomic update is waiting on. v2: Calculate time at *start* of vblank period, not end v3: Fix kbuild complaints Signed-off-by: Rob Clark Reviewed-by: Mario Kleiner --- drivers/gpu/drm/drm_vblank.c | 53

[PATCH v9 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-02 Thread Rob Clark
From: Rob Clark For an atomic commit updating a single CRTC (ie. a pageflip) calculate the next vblank time, and inform the fence(s) of that deadline. v2: Comment typo fix (danvet) Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark ---

[PATCH v9 09/15] drm/syncobj: Add deadline support for syncobj waits

2023-03-02 Thread Rob Clark
From: Rob Clark Add a new flag to let userspace provide a deadline as a hint for syncobj and timeline waits. This gives a hint to the driver signaling the backing fences about how soon userspace needs it to compete work, so it can addjust GPU frequency accordingly. An immediate deadline can be

[PATCH v9 08/15] drm/scheduler: Add fence deadline support

2023-03-02 Thread Rob Clark
As the finished fence is the one that is exposed to userspace, and therefore the one that other operations, like atomic update, would block on, we need to propagate the deadline from from the finished fence to the actual hw fence. v2: Split into drm_sched_fence_set_parent() (ckoenig) v3: Ensure a

[PATCH v9 07/15] dma-buf/sw_sync: Add fence deadline support

2023-03-02 Thread Rob Clark
From: Rob Clark This consists of simply storing the most recent deadline, and adding an ioctl to retrieve the deadline. This can be used in conjunction with the SET_DEADLINE ioctl on a fence fd for testing. Ie. create various sw_sync fences, merge them into a fence-array, set deadline on the

[PATCH v9 06/15] dma-buf/sync_file: Add SET_DEADLINE ioctl

2023-03-02 Thread Rob Clark
From: Rob Clark The initial purpose is for igt tests, but this would also be useful for compositors that wait until close to vblank deadline to make decisions about which frame to show. The igt tests can be found at:

[PATCH v9 05/15] dma-buf/sync_file: Surface sync-file uABI

2023-03-02 Thread Rob Clark
From: Rob Clark We had all of the internal driver APIs, but not the all important userspace uABI, in the dma-buf doc. Fix that. And re-arrange the comments slightly as otherwise the comments for the ioctl nr defines would not show up. v2: Fix docs build warning coming from newly including the

[PATCH v9 04/15] dma-buf/dma-resv: Add a way to set fence deadline

2023-03-02 Thread Rob Clark
From: Rob Clark Add a way to set a deadline on remaining resv fences according to the requested usage. Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/dma-buf/dma-resv.c | 22 ++ include/linux/dma-resv.h | 2 ++ 2 files changed, 24 insertions(+) diff

[PATCH v9 03/15] dma-buf/fence-chain: Add fence deadline support

2023-03-02 Thread Rob Clark
From: Rob Clark Propagate the deadline to all the fences in the chain. v2: Use dma_fence_chain_contained [Tvrtko] Signed-off-by: Rob Clark Reviewed-by: Christian König for this one. --- drivers/dma-buf/dma-fence-chain.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v9 02/15] dma-buf/fence-array: Add fence deadline support

2023-03-02 Thread Rob Clark
From: Rob Clark Propagate the deadline to all the fences in the array. Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/dma-buf/dma-fence-array.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c

[PATCH v9 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-02 Thread Rob Clark
From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is to aid the fence signaler in making power management decisions, like boosting frequency as the deadline approaches and awareness of missing

[PATCH v9 00/15] dma-fence: Deadline awareness

2023-03-02 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To

Re: [git pull] drm-next-fixes for 6.3-rc1

2023-03-02 Thread pr-tracker-bot
The pull request you sent on Fri, 3 Mar 2023 09:07:58 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2023-03-03-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2eb29d59ddf02e39774abfb60b2030b0b7e27c1f Thank you! -- Deet-doot-dot, I am a bot.

[PATCH v6] drm/virtio: Add option to disable KMS support

2023-03-02 Thread Rob Clark
From: Rob Clark Add a build option to disable modesetting support. This is useful in cases where the guest only needs to use the GPU in a headless mode, or (such as in the CrOS usage) window surfaces are proxied to a host compositor. As the modesetting ioctls are a big surface area for

Re: [PATCH v5] drm/virtio: Add option to disable KMS support

2023-03-02 Thread Rob Clark
On Wed, Mar 1, 2023 at 11:25 PM Gerd Hoffmann wrote: > > On Thu, Mar 02, 2023 at 12:39:33AM +0300, Dmitry Osipenko wrote: > > On 3/1/23 21:54, Rob Clark wrote: > > > /* virtgpu_display.c */ > > > +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS) > > > int virtio_gpu_modeset_init(struct virtio_gpu_device

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-03-02 Thread Bjorn Andersson
On Wed, Mar 01, 2023 at 02:58:50PM +0100, Johan Hovold wrote: > On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > > On Tue, Jan 17, 2023 at

[git pull] drm-next-fixes for 6.3-rc1

2023-03-02 Thread Dave Airlie
Hi Linus, This is the fixes for the last couple of weeks on top of the drm-next, I don't think this contains any next content it should be all fixes. amdgpu and i915 mostly, the amdgpu ones are bigger because it's two weeks in one. hopefully this week I got the subject line right. Dave.

[Bug 217110] GPU Lockup on Radeon Pitcairn - VAAPI related

2023-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217110 --- Comment #3 from Ed Martin (edman...@edman007.com) --- Thanks, reported here https://gitlab.freedesktop.org/drm/amd/-/issues/2440 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the

RE: [PATCH] drm/i915: Set wedged if enable guc communication failed

2023-03-02 Thread Dong, Zhanjun
Thanks Jani. Updated patch sent, let me know if you have any comments. Regards, Zhanjun > -Original Message- > From: Jani Nikula > Sent: February 27, 2023 6:30 AM > To: Dong, Zhanjun ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Dong, Zhanjun > Subject:

[PATCH] drm/i915: Set wedged if enable guc communication failed

2023-03-02 Thread Zhanjun Dong
Add err code check for enable_communication on resume path. When resume failed, we can no longer use the GPU, marking the GPU as wedged. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7 ++- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 9 +++-- 2 files changed, 13

Re: [PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-03-02 Thread Jessica Zhang
On 3/1/2023 2:13 AM, Marijn Suijten wrote: On 2023-03-01 11:08:16, Marijn Suijten wrote: On 2023-02-21 10:42:55, Jessica Zhang wrote: Now that the TE setup has been moved to prepare_for_kickoff(), we have not prepare_commit() callbacks left. This makes dpu_encoder_prepare_commit()

[PATCH 12/17] udmabuf: remove MODULE_LICENSE in non-modules

2023-03-02 Thread Nick Alcock
Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it

[PATCH 00/17] MODULE_LICENSE removals, sixth tranche

2023-03-02 Thread Nick Alcock
This series, based on current modules-next, is part of a treewide cleanup suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from files/objects that are not tristate. Due to recent changes to kbuild, these uses are now problematic. See the commit logs for more details. (The

[PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-02 Thread Arthur Grillo
Extend the existing test cases to test the conversion from XRGB to monochromatic. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c

Re: [PATCH 05/22] drm/atmel-hlcdc: Use GEM DMA fbdev emulation

2023-03-02 Thread Sam Ravnborg
On Wed, Mar 01, 2023 at 04:30:44PM +0100, Thomas Zimmermann wrote: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg > --- >

Re: [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-02 Thread Dmitry Baryshkov
On Thu, 2 Mar 2023 at 20:41, Kuogee Hsieh wrote: > > > On 3/1/2023 1:15 PM, Dmitry Baryshkov wrote: > > On 01/03/2023 18:57, Kuogee Hsieh wrote: > >> > >> On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: > >>> On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh > >>> wrote: > There is a reboot/suspend

Re: [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-02 Thread Kuogee Hsieh
On 3/1/2023 1:15 PM, Dmitry Baryshkov wrote: On 01/03/2023 18:57, Kuogee Hsieh wrote: On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since

[PATCH v2] dt-bindings: display: mediatek: Compatible list cleanup

2023-03-02 Thread Yassine Oudjana
From: Yassine Oudjana Several DT bindings of MediaTek display blocks make unnecessary use of "oneOf" and "items". Remove them and replace them with enums where necessary. Signed-off-by: Yassine Oudjana --- Changes since v1: - Leave enums with 1 element as they are.

[PATCH] dt-bindings: display: mediatek: Compatible list cleanup

2023-03-02 Thread Yassine Oudjana
From: Yassine Oudjana Several DT bindings of MediaTek display blocks make unnecessary use of "oneOf" and "items", and have some enums with only 1 element. Remove unnecessary "oneOf" and "items", and replace enums that have 1 element with "const". Signed-off-by: Yassine Oudjana ---

[PATCH] gpu: amd/pm: mark symbols static where possible for smu11

2023-03-02 Thread Jeff Pang
I get one warning when building kernel with -Werror=missing-prototypes : drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1600:5: error: no previous prototype for ‘vangogh_set_apu_thermal_limit’ [-Werror=missing-prototypes] int vangogh_set_apu_thermal_limit(struct smu_context *smu,

Re: [PATCH] drm/edid: fix info leak when failing to get panel id

2023-03-02 Thread Doug Anderson
Hi, On Wed, Mar 1, 2023 at 11:49 PM Johan Hovold wrote: > > Make sure to clear the transfer buffer before fetching the EDID to > avoid leaking slab data to the logs on errors that leave the buffer > unchanged. > > Fixes: 69c7717c20cc ("drm/edid: Dump the EDID when drm_edid_get_panel_id() > has

Re: [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first

2023-03-02 Thread Dmitry Baryshkov
On Thu, 2 Mar 2023 at 19:26, Doug Anderson wrote: > > Hi, > > On Mon, Feb 27, 2023 at 5:24 PM Dmitry Baryshkov > wrote: > > > > On 28/02/2023 02:26, Doug Anderson wrote: > > > Hi, > > > > > > On Wed, Feb 1, 2023 at 1:51 AM Dave Stevenson > > > wrote: > > >> > > >> On Tue, 31 Jan 2023 at 22:22,

Re: [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first

2023-03-02 Thread Doug Anderson
Hi, On Mon, Feb 27, 2023 at 5:24 PM Dmitry Baryshkov wrote: > > On 28/02/2023 02:26, Doug Anderson wrote: > > Hi, > > > > On Wed, Feb 1, 2023 at 1:51 AM Dave Stevenson > > wrote: > >> > >> On Tue, 31 Jan 2023 at 22:22, Douglas Anderson > >> wrote: > >>> > >>> Set the "pre_enable_prev_first"

Re: [Intel-gfx] [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread kernel test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-tests-Suballocator-test/20230302-163704 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-02 Thread Sam Ravnborg
Hi Rob. > .../bindings/display/bridge/analogix,anx7625.yaml | 2 +- > .../bindings/display/bridge/anx6345.yaml | 2 +- > .../bindings/display/bridge/lontium,lt8912b.yaml | 2 +- > .../bindings/display/bridge/nxp,ptn3460.yaml | 2 +- > .../bindings/display/bridge/ps8640.yaml

Re: [Intel-gfx] [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread kernel test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-tests-Suballocator-test/20230302-163704 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link

Re: [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-02 Thread Dmitry Baryshkov
On 02/03/2023 18:33, Vinod Polimera wrote: For the PSR to kick in, self_refresh_aware has to be set. Initialize it based on the PSR support for the eDP interface. Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

RE: [PATCH v13 00/13] Add PSR support for eDP

2023-03-02 Thread Vinod Polimera
> -Original Message- > From: Doug Anderson > Sent: Thursday, March 2, 2023 2:02 AM > To: Vinod Polimera (QUIC) > Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org;

Re: [PATCH] drm/amd/display: Simplify same effect if/else blocks

2023-03-02 Thread Harry Wentland
On 3/1/23 15:21, Deepak R Varma wrote: > On Mon, Jan 23, 2023 at 12:23:19AM +0530, Deepak R Varma wrote: >> On Sun, Jan 15, 2023 at 12:52:10PM -0800, Joe Perches wrote: >>> On Sun, 2023-01-15 at 15:30 +0530, Deepak R Varma wrote: The if / else block code has same effect irrespective of the

[PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-02 Thread Vinod Polimera
For the PSR to kick in, self_refresh_aware has to be set. Initialize it based on the PSR support for the eDP interface. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c

[PATCH v14 13/14] drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable during self refresh

2023-03-02 Thread Vinod Polimera
Populate the enocder software structure to reflect the updated crtc appropriately during crtc enable/disable for a new commit while taking care of the self refresh transitions when crtc disable is triggered from the drm self refresh library. Signed-off-by: Vinod Polimera ---

[PATCH v14 12/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2023-03-02 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

[PATCH v14 11/14] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions

2023-03-02 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10

[PATCH v14 10/14] drm/msm/dp: use the eDP bridge ops to validate eDP modes

2023-03-02 Thread Vinod Polimera
The eDP and DP interfaces shared the bridge operations and the eDP specific changes were implemented under is_edp check. To add psr support for eDP, we started using a new set of eDP bridge ops. We are moving the eDP specific code in the dp_bridge_mode_valid function to a new eDP function,

[PATCH v14 09/14] drm/msm/dp: Add basic PSR support for eDP

2023-03-02 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

[PATCH v14 08/14] drm/msm/dp: use atomic callbacks for DP bridge ops

2023-03-02 Thread Vinod Polimera
Use atomic variants for DP bridge callback functions so that the atomic state can be accessed in the interface drivers. The atomic state will help the driver find out if the display is in self refresh state. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry

[PATCH v14 06/14] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled

2023-03-02 Thread Vinod Polimera
There can be a race between timing gen disable and vblank irq. The wait post timing gen disable may return early but intf disable sequence might not be completed. Ensure that, intf status is disabled before we retire the function. Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

[PATCH v14 07/14] drm/msm/disp/dpu: reset the datapath after timing engine disable

2023-03-02 Thread Vinod Polimera
Reset the datapath after disabling the timing gen, such that it can start on a clean slate when the intf is enabled back. This was a recommended sequence from the DPU HW programming guide. Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

[PATCH v14 04/14] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources

2023-03-02 Thread Vinod Polimera
According to KMS documentation, The driver must not release any shared resources if active is set to false but enable still true. Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset") Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

[PATCH v14 05/14] drm/msm/disp/dpu: get timing engine status from intf status register

2023-03-02 Thread Vinod Polimera
Recommended way of reading the interface timing gen status is via status register. Timing gen status register will give a reliable status of the interface especially during ON/OFF transitions. This support was added from DPU version 5.0.0. Signed-off-by: Vinod Polimera Reviewed-by: Dmitry

[PATCH v14 03/14] drm/bridge: add psr support for panel bridge callbacks

2023-03-02 Thread Vinod Polimera
This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Daniel Vetter ---

[PATCH v14 02/14] drm/bridge: use atomic enable/disable callbacks for panel bridge

2023-03-02 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov Reviewed-by: Daniel Vetter ---

[PATCH v14 01/14] drm: add helper functions to retrieve old and new crtc

2023-03-02 Thread Vinod Polimera
Add new helper functions, drm_atomic_get_old_crtc_for_encoder and drm_atomic_get_new_crtc_for_encoder to retrieve the corresponding crtc for the encoder. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Douglas Anderson Reviewed-by: Daniel Vetter ---

[PATCH v14 00/14] Add PSR support for eDP

2023-03-02 Thread Vinod Polimera
Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set_psr. - Move dp functions to bridge code.

Re: [PATCH v2] dt-bindings: display: mediatek: Compatible list cleanup

2023-03-02 Thread AngeloGioacchino Del Regno
Il 02/03/23 15:12, Yassine Oudjana ha scritto: From: Yassine Oudjana Several DT bindings of MediaTek display blocks make unnecessary use of "oneOf" and "items". Remove them and replace them with enums where necessary. Signed-off-by: Yassine Oudjana --- Changes since v1: - Leave enums with 1

Re: [PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

2023-03-02 Thread Christian König
Am 02.03.23 um 15:35 schrieb Simon Ser: drm_gem_map_dma_buf() requires drm_gem_object_funcs.get_sg_table to be implemented, or else WARNs. Allow drivers to leave this hook unimplemented to implement purely local DMA-BUFs (ie, DMA-BUFs which cannot be imported anywhere else but the device which

Re: [PATCH v3] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-02 Thread Andi Shyti
Hi Janusz, On Thu, Mar 02, 2023 at 01:08:20PM +0100, Janusz Krzysztofik wrote: > Users reported oopses on list corruptions when using i915 perf with a > number of concurrently running graphics applications. Root cause analysis > pointed at an issue in barrier processing code -- a race among perf

Re: [PATCH v2 2/2] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Thomas Zimmermann
Am 02.03.23 um 15:35 schrieb Simon Ser: We don't populate drm_driver.gem_prime_import_sg_table so only DMA-BUFs exported from our own device can be imported. We don't populate drm_gem_object_funcs.get_sg_table so DMA-BUFs cannot be imported into another device. Still, this is useful to

Re: [PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

2023-03-02 Thread Thomas Zimmermann
Hi Am 02.03.23 um 16:03 schrieb Thomas Zimmermann: Hi Am 02.03.23 um 15:35 schrieb Simon Ser: drm_gem_map_dma_buf() requires drm_gem_object_funcs.get_sg_table to be implemented, or else WARNs. Allow drivers to leave this hook unimplemented to implement purely local DMA-BUFs (ie, DMA-BUFs

Re: [PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

2023-03-02 Thread Thomas Zimmermann
Hi Am 02.03.23 um 15:35 schrieb Simon Ser: drm_gem_map_dma_buf() requires drm_gem_object_funcs.get_sg_table to be implemented, or else WARNs. Allow drivers to leave this hook unimplemented to implement purely local DMA-BUFs (ie, DMA-BUFs which cannot be imported anywhere else but the device

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Simon Ser
On Thursday, March 2nd, 2023 at 14:45, Christian König wrote: > Am 02.03.23 um 14:37 schrieb Simon Ser: > > > On Thursday, March 2nd, 2023 at 14:21, Christian König > > christian.koe...@amd.com wrote: > > > > > Am 02.03.23 um 11:14 schrieb Simon Ser: > > > > > > > On Thursday, March 2nd,

[PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

2023-03-02 Thread Simon Ser
drm_gem_map_dma_buf() requires drm_gem_object_funcs.get_sg_table to be implemented, or else WARNs. Allow drivers to leave this hook unimplemented to implement purely local DMA-BUFs (ie, DMA-BUFs which cannot be imported anywhere else but the device which allocated them). In that case, reject

[PATCH v2 2/2] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Simon Ser
We don't populate drm_driver.gem_prime_import_sg_table so only DMA-BUFs exported from our own device can be imported. We don't populate drm_gem_object_funcs.get_sg_table so DMA-BUFs cannot be imported into another device. Still, this is useful to user-space to share buffers between processes and

Re: [PATCH] dt-bindings: display: mediatek: Compatible list cleanup

2023-03-02 Thread Krzysztof Kozlowski
On 02/03/2023 14:35, Yassine Oudjana wrote: > From: Yassine Oudjana > > Several DT bindings of MediaTek display blocks make unnecessary use of > "oneOf" and "items", and have some enums with only 1 element. Remove > unnecessary "oneOf" and "items", and replace enums that have 1 element > with

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Christian König
Am 02.03.23 um 14:37 schrieb Simon Ser: On Thursday, March 2nd, 2023 at 14:21, Christian König wrote: Am 02.03.23 um 11:14 schrieb Simon Ser: On Thursday, March 2nd, 2023 at 08:11, Christian König christian.koe...@amd.com wrote: Am 01.03.23 um 23:29 schrieb Simon Ser: We don't

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Simon Ser
On Thursday, March 2nd, 2023 at 14:21, Christian König wrote: > Am 02.03.23 um 11:14 schrieb Simon Ser: > > > On Thursday, March 2nd, 2023 at 08:11, Christian König > > christian.koe...@amd.com wrote: > > > > > Am 01.03.23 um 23:29 schrieb Simon Ser: > > > > > > > We don't populate

Re: [PATCH] drm/i915/gvt: Make use of idr_find and idr_for_each_entry in dmabuf

2023-03-02 Thread Cai Huoqing
On 02 3月 23 19:53:18, Cai Huoqing wrote: > This patch uses the already existing IDR mechanism to simplify > and improve the dmabuf code. > > Using 'vgpu.object_idr' directly instead of 'dmabuf_obj_list_head' > or 'dmabuf.list', because the dmabuf_obj can be found by 'idr_find' > or

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Christian König
Am 02.03.23 um 11:14 schrieb Simon Ser: On Thursday, March 2nd, 2023 at 08:11, Christian König wrote: Am 01.03.23 um 23:29 schrieb Simon Ser: We don't populate gem_prime_import_sg_table so only DMA-BUFs exported from our own device can be imported. Still, this is useful to user-space. But

Re: [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread Christian König
Am 02.03.23 um 09:34 schrieb Thomas Hellström: Add a suballocator test to get some test coverage for the new drm suballocator, and perform some basic timing (elapsed time). Signed-off-by: Thomas Hellström Nice, I haven't had time to go over it in all detail but it looks pretty

[PATCH] drm/nouveau/nvfw/acr: set wpr_generic_header_dump storage-class-specifier to static

2023-03-02 Thread Tom Rix
gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous prototype for ‘wpr_generic_header_dump’ [-Werror=missing-prototypes] 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, | ^~~ wpr_generic_header_dump is only used in acr.c,

[PATCH] drm/rockchip: vop2: add polarity flags to RGB output

2023-03-02 Thread Gerald Loacker
Use h/v-sync and pixel clock polarity flags for RGB output. For all other outputs this is already implemented. Signed-off-by: Gerald Loacker --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

[PATCH v3] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-02 Thread Janusz Krzysztofik
Users reported oopses on list corruptions when using i915 perf with a number of concurrently running graphics applications. Root cause analysis pointed at an issue in barrier processing code -- a race among perf open / close replacing active barriers with perf requests on kernel context and

Re: gud: set PATH connector property

2023-03-02 Thread Simon Ser
On Tuesday, February 28th, 2023 at 16:16, Peter Stuge wrote: > Simon Ser wrote: > > > > > Would it be possible to set the PATH connector property based on the > > > > USB port used by gud? > > > > > > Sadly not really easily. > > > > > > The physical topology underneath each host controller

[PATCH] dma-buf/dma-buf.c: add a blank line between the two adjoining functions

2023-03-02 Thread suijingfeng
Signed-off-by: suijingfeng <15330273...@189.cn> --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 757c0fb77a6c..45d56aa4319c 100644 --- a/drivers/dma-buf/dma-buf.c +++

[PATCH] drm/i915/gvt: Make use of idr_find and idr_for_each_entry in dmabuf

2023-03-02 Thread Cai Huoqing
This patch uses the already existing IDR mechanism to simplify and improve the dmabuf code. Using 'vgpu.object_idr' directly instead of 'dmabuf_obj_list_head' or 'dmabuf.list', because the dmabuf_obj can be found by 'idr_find' or 'idr_for_each_entry'. Signed-off-by: Cai Huoqing ---

Re: gud: set PATH connector property

2023-03-02 Thread Simon Ser
On Wednesday, March 1st, 2023 at 19:07, Noralf Trønnes wrote: > > Would it be possible to set the PATH connector property based on the > > USB port used by gud? > > > > This would give user-space a persistent identifier for the connector: > > if the user plugs in a USB display on a given port,

Re: [PATCH v2] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-02 Thread Janusz Krzysztofik
Hi Andy, Thanks for review. On Thursday, 2 March 2023 01:42:05 CET Andi Shyti wrote: > Hi Janusz, > > On Sat, Feb 25, 2023 at 11:12:18PM +0100, Janusz Krzysztofik wrote: > > Users reported oopses on list corruptions when using i915 perf with a > > number of concurrently running graphics

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Simon Ser
On Thursday, March 2nd, 2023 at 09:07, Thomas Zimmermann wrote: > Am 01.03.23 um 23:29 schrieb Simon Ser: > > > We don't populate gem_prime_import_sg_table so only DMA-BUFs > > exported from our own device can be imported. Still, this is useful > > to user-space. > > VRAM helpers don't really

Re: [PATCH v2] MAINTAINERS: Add myself as maintainer for DRM Panels drivers

2023-03-02 Thread Neil Armstrong
On 02/03/2023 11:29, Neil Armstrong wrote: Hi, On Wed, 01 Mar 2023 10:47:35 +0100, Neil Armstrong wrote: Add myself as co-maintainer for DRM Panel Drivers in order to help reviewing and getting new panels drivers merged, and Remove Thierry as he suggested since he wasn't active for a while.

Re: [PATCH v2] MAINTAINERS: Add myself as maintainer for DRM Panels drivers

2023-03-02 Thread Neil Armstrong
Hi, On Wed, 01 Mar 2023 10:47:35 +0100, Neil Armstrong wrote: > Add myself as co-maintainer for DRM Panel Drivers in order to help > reviewing and getting new panels drivers merged, and Remove Thierry > as he suggested since he wasn't active for a while. > > Thanks Thierry for all your work! >

Re: [PATCH 1/2] habanalabs: unify err log of hw-fini failure in dirty state

2023-03-02 Thread Stanislaw Gruszka
On Thu, Mar 02, 2023 at 11:15:16AM +0200, Oded Gabbay wrote: > From: Dafna Hirschfeld > > print more informative message when failing in dirty state > > Signed-off-by: Dafna Hirschfeld > Reviewed-by: Oded Gabbay > Signed-off-by: Oded Gabbay Reviewed-by: Stanislaw Gruszka > ---

Re: [PATCH 2/2] habanalabs: use scnprintf() in print_device_in_use_info()

2023-03-02 Thread Stanislaw Gruszka
On Thu, Mar 02, 2023 at 11:15:17AM +0200, Oded Gabbay wrote: > From: Tomer Tayar > > compose_device_in_use_info() was added to handle the snprintf() return > value in a single place. > However, the buffer size in print_device_in_use_info() is set such that > it would be enough for the max

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-02 Thread Simon Ser
On Thursday, March 2nd, 2023 at 08:11, Christian König wrote: > Am 01.03.23 um 23:29 schrieb Simon Ser: > > > We don't populate gem_prime_import_sg_table so only DMA-BUFs > > exported from our own device can be imported. Still, this is useful > > to user-space. > > But what happens if one of

RE: [PATCH] gpu: amd/pm: mark symbols static where possible for smu11

2023-03-02 Thread Quan, Evan
[AMD Official Use Only - General] Thanks. But I think there was already a patch from Kun Liu to address this issue. https://lists.freedesktop.org/archives/amd-gfx/2023-March/090029.html BR Evan > -Original Message- > From: Jeff Pang > Sent: Thursday, March 2, 2023 5:16 PM > To: Quan,

[PATCH 2/2] habanalabs: use scnprintf() in print_device_in_use_info()

2023-03-02 Thread Oded Gabbay
From: Tomer Tayar compose_device_in_use_info() was added to handle the snprintf() return value in a single place. However, the buffer size in print_device_in_use_info() is set such that it would be enough for the max possible print, so compose_device_in_use_info() is not really needed. Moreover,

[PATCH 1/2] habanalabs: unify err log of hw-fini failure in dirty state

2023-03-02 Thread Oded Gabbay
From: Dafna Hirschfeld print more informative message when failing in dirty state Signed-off-by: Dafna Hirschfeld Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread Thomas Hellström
Add a suballocator test to get some test coverage for the new drm suballocator, and perform some basic timing (elapsed time). Signed-off-by: Thomas Hellström --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/tests/Makefile| 3 +-

[PATCHv4 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-03-02 Thread Arun R Murthy
Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer. For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping

  1   2   >