Re: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-06 Thread Hogander, Jouni
On Tue, 2023-11-07 at 05:01 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Monday, November 6, 2023 1:33 PM > > To: dri-devel@lists.freedesktop.org; Manna, Animesh > > ; intel-...@lists.freedesktop.org > > Cc: Murthy, Arun R ; Nikula, Jani >

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mika Westerberg
On Tue, Nov 07, 2023 at 07:45:26AM +0200, Mika Westerberg wrote: > Hi, > > On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > > Tangentially related; the link speed is currently symmetric but there are > > > two

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/7/23 03:07, Alex Deucher wrote: On Mon, Nov 6, 2023 at 4:20 PM Abhinav Singh wrote: On 11/7/23 00:25, Alex Deucher wrote: Applied. This matches what we already do in the other clear state headers. Alex On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh wrote: sparse static analysis

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mika Westerberg
Hi, On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > Tangentially related; the link speed is currently symmetric but there are > > two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may > >

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Evan Preston
Hi Huacai, On 2023-11-07 Tue 09:49am, Huacai Chen wrote: > Hi, Evan, > > On Tue, Nov 7, 2023 at 4:32 AM Evan Preston wrote: > > > > Hi Huacai, > > > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > > > > > > > On 06.11.23 04:15,

[PATCH] nouveau: use an rwlock for the event lock.

2023-11-06 Thread Dave Airlie
From: Dave Airlie This allows it to break the following circular locking dependency. Aug 10 07:01:29 dg1test kernel: == Aug 10 07:01:29 dg1test kernel: WARNING: possible circular locking dependency detected Aug 10 07:01:29 dg1test kernel:

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-06 Thread Lazar, Lijo
On 11/1/2023 1:36 PM, Aravind Iddamsetty wrote: On 30/10/23 20:41, Lazar, Lijo wrote: On 10/30/2023 11:49 AM, Aravind Iddamsetty wrote: On 26/10/23 15:34, Lazar, Lijo wrote: Hi Lijo, Thank you for your comments. On 10/23/2023 8:59 PM, Alex Deucher wrote: On Fri, Oct 20, 2023 at

RE: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-06 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Monday, November 6, 2023 1:33 PM > To: dri-devel@lists.freedesktop.org; Manna, Animesh > ; intel-...@lists.freedesktop.org > Cc: Murthy, Arun R ; Nikula, Jani > > Subject: Re: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Lazar, Lijo
On 11/7/2023 1:47 AM, Hunter Chasens wrote: Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens ---

Re: [PATCH v2 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-06 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/mm-gup-Introduce-pin_user_pages_fd-for-pinning-shmem-hugetlbfs-file-pages-v2/20231106-141954 base: https

[PATCH] drm/sched: Don't disturb the entity when in RR-mode scheduling

2023-11-06 Thread Luben Tuikov
Don't call drm_sched_select_entity() in drm_sched_run_job_queue(). In fact, rename __drm_sched_run_job_queue() to just drm_sched_run_job_queue(), and let it do just that, schedule the work item for execution. The problem is that drm_sched_run_job_queue() calls drm_sched_select_entity() to

Re: [PATCH v2 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-06 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/mm-gup-Introduce-pin_user_pages_fd-for-pinning-shmem-hugetlbfs-file-pages-v2/20231106-141954 base: https

Re: [PATCH 0/5] Some drm scheduler internal renames

2023-11-06 Thread Luben Tuikov
On 2023-11-06 07:41, Tvrtko Ursulin wrote: > > On 05/11/2023 01:51, Luben Tuikov wrote: >> On 2023-11-02 06:55, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> I found some of the naming a bit incosistent and unclear so just a small >>> attempt to clarify and tidy some of them. See what

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Willem de Bruijn
> > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is that > > > > it somehow implies that I have an option of passing or not passing it > > > > for an individual system call. > > > > If we know that we're going to use dmabuf with the socket, maybe we > > > > should move this

[git pull] drm next + fixes for 6.7-rc1

2023-11-06 Thread Dave Airlie
Hi Linus, Geert pointed out I missed the renesas reworks in my main pull, so this pull contains the renesas next work for atomic conversion and DT support. It also contains a bunch of amdgpu and some small ssd13xx fixes. I'm going to be travelling from tomorrow, I should in theory have access to

Re: [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-11-06 Thread Dmitry Baryshkov
On Sat, 7 Oct 2023 at 01:55, Kuogee Hsieh wrote: > > The purpose of this patch series is to incorporate pm runtime framework > into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel > driver during system probe time. During incorporating procedure, original > customized pm

[PATCH v2] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

2023-11-06 Thread xiazhengqiao
For the "starry, 2081101qfh032011-53g" panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G MIPI-DSI panel") Signed-off-by: xiazhengqiao Reviewed-by:

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Huacai Chen
Hi, Evan, On Tue, Nov 7, 2023 at 4:32 AM Evan Preston wrote: > > Hi Huacai, > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > > > > > On 06.11.23 04:15, Huacai Chen wrote: > > > > Hi, Jaak and Evan, > > > > > > > > On Mon, Nov 6, 2023

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/6/23 5:20 PM, Mina Almasry wrote: > The user is free to modify or delete flow steering rules outside of the > lifetime of the socket. Technically it's possible for the user to > reconfigure flow steering while the socket is simultaneously receiving, > and the result will be packets switching

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 4:08 PM Willem de Bruijn > wrote: > > > > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry > > > wrote: > > > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev > >

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Stanislav Fomichev wrote: > On 11/06, Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry > > > wrote: > > > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev > > > > wrote: > > > > >

[PATCH] drm/msm/dp: call dp_display_get_next_bridge() during probe

2023-11-06 Thread Dmitry Baryshkov
The funcion dp_display_get_next_bridge() can return -EPROBE_DEFER if the next bridge is not (yet) available. However returning -EPROBE_DEFER from msm_dp_modeset_init() is not ideal. This leads to -EPROBE return from component_bind, which can easily result in -EPROBE_DEFR loops. Signed-off-by:

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Bagas Sanjaya
On Mon, Nov 06, 2023 at 03:17:39PM -0500, Hunter Chasens wrote: > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > index 517b9fb4624c..81b8ceb26890 100644 > --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > @@ -989,12

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 4:16 PM David Ahern wrote: > > On 11/5/23 7:44 PM, Mina Almasry wrote: > > diff --git a/net/core/datagram.c b/net/core/datagram.c > > index 176eb5834746..cdd4fb129968 100644 > > --- a/net/core/datagram.c > > +++ b/net/core/datagram.c > > @@ -425,6 +425,9 @@ static int

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 4:08 PM Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > > > > > On 11/06, Mina Almasry wrote: > >

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/5/23 7:44 PM, Mina Almasry wrote: > diff --git a/net/core/datagram.c b/net/core/datagram.c > index 176eb5834746..cdd4fb129968 100644 > --- a/net/core/datagram.c > +++ b/net/core/datagram.c > @@ -425,6 +425,9 @@ static int __skb_datagram_iter(const struct sk_buff *skb, > int offset, >

[PATCH v5 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-06 Thread Imre Deak
Add helpers drivers can use to calculate the BW allocation overhead - due to SSC, FEC, DSC and data alignment on symbol cycles - and the channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On 128b/132b links the FEC overhead is part of the coding efficiency, so not accounted for in

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Willem de Bruijn wrote: > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > > > > > On 11/06, Mina Almasry wrote: > > > > > On Mon, Nov 6,

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Bagas Sanjaya
On 07/11/2023 02:41, Jani Nikula wrote: > On Mon, 06 Nov 2023, Hunter Chasens wrote: >> When running `make htmldocs` the following warnings are given. >> >> ``` >> Documentation/gpu/rfc/i915_scheduler.rst:138: WARNING: >> Unknown directive type "c:namespace-push". >> >> .. c:namespace-push:: rfc

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Bagas Sanjaya
On 06/11/2023 17:31, Jani Nikula wrote: > On Mon, 06 Nov 2023, Bagas Sanjaya wrote: >> On Sat, Nov 04, 2023 at 09:47:08AM -0400, Hunter Chasens wrote: >>> diff --git a/Documentation/gpu/rfc/i915_scheduler.rst >>> b/Documentation/gpu/rfc/i915_scheduler.rst >>> index c237ebc024cd..23ba7006929b

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Willem de Bruijn
On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > > > On 11/06, Mina Almasry wrote: > > > > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev > > > > wrote: >

Re: [PATCH v5 1/4] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing

2023-11-06 Thread Hsin-Yi Wang
On Mon, Nov 6, 2023 at 4:00 PM Hsin-Yi Wang wrote: > > According to decoding edid and datahseet: > - Rename AUO 0x235c B116XTN02 to B116XTN02.3 > - Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of > auo_b116xak01: T3=200, T12=500, T7_max = 50. > > Fixes: 3db2420422a5

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 3:37 PM David Ahern wrote: > > On 11/6/23 3:18 PM, Mina Almasry wrote: > >> @@ -991,7 +993,7 @@ struct sk_buff { > >> #if IS_ENABLED(CONFIG_IP_SCTP) > >> __u8csum_not_inet:1; > >> #endif > >> - > >> +__u8

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Willem de Bruijn
On Mon, Nov 6, 2023 at 3:55 PM David Ahern wrote: > > On 11/6/23 4:32 PM, Stanislav Fomichev wrote: > >> The concise notification API returns tokens as a range for > >> compression, encoding as two 32-bit unsigned integers start + length. > >> It allows for even further batching by returning

[PATCH v5 4/4] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v4->v5: remove

[PATCH v5 1/4] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing

2023-11-06 Thread Hsin-Yi Wang
According to decoding edid and datahseet: - Rename AUO 0x235c B116XTN02 to B116XTN02.3 - Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of auo_b116xak01: T3=200, T12=500, T7_max = 50. Fixes: 3db2420422a5 ("drm/panel-edp: Add AUO B116XTN02, BOE NT116WHM-N21,836X2, NV116WHM-N49

[PATCH v5 3/4] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: fix coding

[PATCH v5 2/4] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: seperate fixes patch --- drivers/gpu/drm/panel/panel-edp.c | 51 +++ 1 file changed, 51 insertions(+) diff --git

[PATCH v5 0/4] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
This series contains 3 patches: 1. Add a few new generic edp panels. 2. Support a new quirk to override the mode read from edid 3. Only add hard-coded mode if both edid and hard-coded modes presents. v1:

[PATCH 1/2] drm/i915/guc: Fix for potential false positives in GuC hang selftest

2023-11-06 Thread John . C . Harrison
From: John Harrison Noticed that the hangcheck selftest is submitting a non-preemptoble spinner. That means that even if the GuC does not die, the heartbeat will still kick in and trigger a reset. Which is rather defeating the purpose of the test - to verify that the heartbeat will kick in if

[PATCH 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-06 Thread John . C . Harrison
From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is working. Signed-off-by: John Harrison ---

[PATCH 0/2] Selftest for FAST_REQUEST feature

2023-11-06 Thread John . C . Harrison
From: John Harrison Add a selftest to verify that the FAST_REQUEST mechanism (getting errors back from fire-and-forget H2G commands) is functional. Also fix up a potential false positive in the GuC hang selftest. Signed-off-by: John Harrison John Harrison (2): drm/i915/guc: Fix for

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > On 11/06, Mina Almasry wrote: > > > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > > > > > > > On 11/06, Mina Almasry wrote: > > > > > On Mon, Nov 6, 2023 at

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread David Ahern
On 11/6/23 4:32 PM, Stanislav Fomichev wrote: >> The concise notification API returns tokens as a range for >> compression, encoding as two 32-bit unsigned integers start + length. >> It allows for even further batching by returning multiple such ranges >> in a single call. > > Tangential: should

Re: linux-next: manual merge of the amdgpu tree with Linus' tree

2023-11-06 Thread Stephen Rothwell
Hi all, On Mon, 6 Nov 2023 09:48:55 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c > > between commit: > > 18bf400530ca ("drm/amdgpu: Use pci_get_base_class() to reduce duplicated > code") >

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-06 Thread David Ahern
On 11/5/23 7:44 PM, Mina Almasry wrote: > diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h > index 78cbb040af94..b93243c2a640 100644 > --- a/include/net/page_pool/helpers.h > +++ b/include/net/page_pool/helpers.h > @@ -111,6 +112,45 @@ page_pool_iov_binding(const

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Dmitry Baryshkov
On Tue, 7 Nov 2023 at 01:30, Abhinav Kumar wrote: > > > > On 11/6/2023 2:11 PM, Dmitry Baryshkov wrote: > > On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar > > wrote: > >> > >> Sorry for the delay in getting back on this. There was quite a bit of > >> history digging I had to do myself to give a

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-06 Thread David Ahern
On 11/5/23 7:44 PM, Mina Almasry wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index eeeda849115c..1c351c138a5b 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -843,6 +843,9 @@ struct netdev_dmabuf_binding { > }; > > #ifdef

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/6/23 3:18 PM, Mina Almasry wrote: >> @@ -991,7 +993,7 @@ struct sk_buff { >> #if IS_ENABLED(CONFIG_IP_SCTP) >> __u8csum_not_inet:1; >> #endif >> - >> +__u8devmem:1; >> #if defined(CONFIG_NET_SCHED) ||

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Stanislav Fomichev
On Mon, Nov 6, 2023 at 2:56 PM Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 2:34 PM Stanislav Fomichev wrote: > > > > On 11/06, Willem de Bruijn wrote: > > > > > IMHO, we need a better UAPI to receive the tokens and give them back > > > > > to > > > > > the kernel. CMSG +

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Abhinav Kumar
On 11/6/2023 2:11 PM, Dmitry Baryshkov wrote: On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar wrote: Sorry for the delay in getting back on this. There was quite a bit of history digging I had to do myself to give a certain response. On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote: On sc7280

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > On 11/06, Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > > > > > On 11/06, Mina Almasry wrote: > > > > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > > > > > > > On 11/6/23 11:47 AM,

Re: [syzbot] [dri?] kernel BUG in vmf_insert_pfn_prot (2)

2023-11-06 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:d2f51b3516da Merge tag 'rtc-6.7' of git://git.kernel.org/p.. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=1422ebef68 kernel config:

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Kaiyuan Zhang
> > But there is still always 1 dmabuf to 1 socket association (on rx), right? > In practice yes, but my understanding is that such association is only enforced by NIC features such as flow steering. So why not have a separate control channel action to say: this socket fd > is supposed to receive

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > > > On 11/06, Mina Almasry wrote: > > > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > > > > > On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > > > > > On 11/05, Mina Almasry wrote: > > > >

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Willem de Bruijn
On Mon, Nov 6, 2023 at 2:34 PM Stanislav Fomichev wrote: > > On 11/06, Willem de Bruijn wrote: > > > > IMHO, we need a better UAPI to receive the tokens and give them back to > > > > the kernel. CMSG + setsockopt(SO_DEVMEM_DONTNEED) get the job done, > > > > but look dated and hacky :-( > > > > >

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Stanislav Fomichev
On 11/06, Willem de Bruijn wrote: > > > IMHO, we need a better UAPI to receive the tokens and give them back to > > > the kernel. CMSG + setsockopt(SO_DEVMEM_DONTNEED) get the job done, > > > but look dated and hacky :-( > > > > > > We should either do some kind of user/kernel shared memory queue

Re: [PATCH v4 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-06 Thread Imre Deak
On Mon, Nov 06, 2023 at 11:31:51PM +0200, Ville Syrjälä wrote: > On Mon, Oct 30, 2023 at 05:58:22PM +0200, Imre Deak wrote: > > Add helpers drivers can use to calculate the BW allocation overhead - > > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > > channel coding efficiency

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > On 11/06, Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > > > On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > > > > On 11/05, Mina Almasry wrote: > > > >> For device memory TCP, we expect the skb

Re: [PATCH v4 2/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Dmitry Baryshkov
On Mon, 6 Nov 2023 at 23:03, Hsin-Yi Wang wrote: > > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > > Signed-off-by: Hsin-Yi

Re: [PATCH v3 1/3] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Dmitry Baryshkov
On Mon, 6 Nov 2023 at 22:27, Hsin-Yi Wang wrote: > > Add a few generic edp panels used by mt8186 chromebooks. > Besides, modify the following panel: > - AUO 0x235c B116XTN02 renamed to B116XTN02.3. > - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According > to the datasheet: T3=200,

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Dmitry Baryshkov
On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar wrote: > > Sorry for the delay in getting back on this. There was quite a bit of > history digging I had to do myself to give a certain response. > > > On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote: > > On sc7280 there are two clk bits for WB2: control

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > > > On 11/05, Mina Almasry wrote: > > >> For device memory TCP, we expect the skb headers to be available in host > > >> memory for access, and we expect the

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Alex Deucher
On Mon, Nov 6, 2023 at 4:20 PM Abhinav Singh wrote: > > On 11/7/23 00:25, Alex Deucher wrote: > > Applied. This matches what we already do in the other clear state headers. > > > > Alex > > > > On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh > > wrote: > >> > >> sparse static analysis tools

Re: [PATCH v4 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-06 Thread Ville Syrjälä
On Mon, Oct 30, 2023 at 05:58:22PM +0200, Imre Deak wrote: > Add helpers drivers can use to calculate the BW allocation overhead - > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On > 128b/132b links the FEC

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/7/23 00:25, Alex Deucher wrote: Applied. This matches what we already do in the other clear state headers. Alex On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh wrote: sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Stanislav Fomichev
On 11/06, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 10:44 AM Stanislav Fomichev wrote: > > > > On 11/05, Mina Almasry wrote: > > > In tcp_recvmsg_locked(), detect if the skb being received by the user > > > is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM > > > flag -

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Willem de Bruijn
> > IMHO, we need a better UAPI to receive the tokens and give them back to > > the kernel. CMSG + setsockopt(SO_DEVMEM_DONTNEED) get the job done, > > but look dated and hacky :-( > > > > We should either do some kind of user/kernel shared memory queue to > > receive/return the tokens (similar to

Re: [PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Doug Anderson
Hi, On Mon, Nov 6, 2023 at 1:03 PM Hsin-Yi Wang wrote: > > @@ -622,7 +627,7 @@ static int panel_edp_get_modes(struct drm_panel *panel, > * and no modes (the generic edp-panel case) because it will clobber > * the display_info that was already set by drm_add_edid_modes(). >

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Randy Dunlap
On 11/6/23 12:17, Hunter Chasens wrote: > Resolves Sphinx unexpected indentation warning when compiling > documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds > a literal block to keep vertical formatting of the > example power state list. > > Signed-off-by: Hunter Chasens

[PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v3->v4: don't skip read

[PATCH v4 2/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v3->v4: no change

[PATCH v4 1/3] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Besides, modify the following panel: - AUO 0x235c B116XTN02 renamed to B116XTN02.3. - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According to the datasheet: T3=200, T12=500, T7_max = 50. Signed-off-by: Hsin-Yi Wang

[PATCH v4 0/3] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
This series contains 3 patches: 1. Add a few new generic edp panels. 2. Support a new quirk to override the mode read from edid 3. Only add hard-coded mode if both edid and hard-coded modes presents. v1:

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-06 Thread Stanislav Fomichev
On 11/05, Mina Almasry wrote: > Implement a memory provider that allocates dmabuf devmem page_pool_iovs. > > Support of PP_FLAG_DMA_MAP and PP_FLAG_DMA_SYNC_DEV is omitted for > simplicity. > > The provider receives a reference to the struct netdev_dmabuf_binding > via the pool->mp_priv pointer.

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/05, Mina Almasry wrote: > For device memory TCP, we expect the skb headers to be available in host > memory for access, and we expect the skb frags to be in device memory > and unaccessible to the host. We expect there to be no mixing and > matching of device memory frags (unaccessible) with

Re: [RFC PATCH v2 05/17] drm/vkms: Avoid reading beyond LUT array

2023-11-06 Thread Harry Wentland
On 2023-10-30 09:29, Pekka Paalanen wrote: > On Thu, 19 Oct 2023 17:21:21 -0400 > Harry Wentland wrote: > >> When the floor LUT index (drm_fixp2int(lut_index) is the last >> index of the array the ceil LUT index will point to an entry >> beyond the array. Make sure we guard against it and use

Re: [PATCH v3 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
On Mon, Nov 6, 2023 at 12:33 PM Doug Anderson wrote: > > Hi, > > On Mon, Nov 6, 2023 at 12:27 PM Hsin-Yi Wang wrote: > > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c > > b/drivers/gpu/drm/panel/panel-edp.c > > index 0fb439b5efb1..54dbbdf62ec0 100644 > > ---

Re: [PATCH v3 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Doug Anderson
Hi, On Mon, Nov 6, 2023 at 12:27 PM Hsin-Yi Wang wrote: > > diff --git a/drivers/gpu/drm/panel/panel-edp.c > b/drivers/gpu/drm/panel/panel-edp.c > index 0fb439b5efb1..54dbbdf62ec0 100644 > --- a/drivers/gpu/drm/panel/panel-edp.c > +++ b/drivers/gpu/drm/panel/panel-edp.c > @@ -594,8 +594,20 @@

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Evan Preston
Hi Huacai, On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > > > On 06.11.23 04:15, Huacai Chen wrote: > > > Hi, Jaak and Evan, > > > > > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja wrote: > > >> > > >> On 05.11.23 14:40, Huacai Chen

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > > On 11/05, Mina Almasry wrote: > >> For device memory TCP, we expect the skb headers to be available in host > >> memory for access, and we expect the skb frags to be in device memory > >> and

[PATCH v3 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v2->v3: if hard-coded

[PATCH v3 2/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v2->v3: no change.

[PATCH v3 1/3] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Besides, modify the following panel: - AUO 0x235c B116XTN02 renamed to B116XTN02.3. - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According to the datasheet: T3=200, T12=500, T7_max = 50. Signed-off-by: Hsin-Yi Wang

[PATCH v3 0/3] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
This series contains 3 patches: 1. Add a few new generic edp panels. 2. Support a new quirk to override the mode read from edid 3. Only add hard-coded mode if both edid and hard-coded modes presents. v1:

[PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Hunter Chasens
Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Randy Dunlap
On 11/6/23 11:06, Hunter Chasens wrote: > First, apologies to Jani Nikula. I accedently top posted on the other thread. > My email client is giving me a hard time. The following works and, if > everyone agrees, I'll send out a v2. > > * E.g.:: > * > * S: 19Mhz * > * 0: 615Mhz > * 1:

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Jonathan Corbet
Jani Nikula writes: > Looks like this is because namespacing was introduced in Sphinx 3.1 > [1]. With earlier Sphinx, you get a warning about the namespace > directives. > > However, with newer Sphinx, you get the warning mentioned in commit > f6757dfcfde7 ("drm/doc: fix duplicate declaration

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-11-06 Thread Aradhya Bhatia
Hi Sam, Thank you for the suggestion! On 06-Nov-23 18:08, Sam Ravnborg wrote: > Hi Aradhya, > > On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya Bhatia wrote: >> With new connector model, tc358767 will not create the connector, when >> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Hunter Chasens wrote: > When running `make htmldocs` the following warnings are given. > > ``` > Documentation/gpu/rfc/i915_scheduler.rst:138: WARNING: > Unknown directive type "c:namespace-push". > > .. c:namespace-push:: rfc > Documentation/gpu/rfc/i915_scheduler.rst:143:

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Hsin-Yi Wang
On Mon, Nov 6, 2023 at 8:21 AM Doug Anderson wrote: > > Hi, > > On Mon, Nov 6, 2023 at 12:06 AM Maxime Ripard wrote: > > > > On Thu, Nov 02, 2023 at 07:33:48AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Wed, Nov 1, 2023 at 11:31 PM Dmitry Baryshkov > > > wrote: > > > > > > > > On Wed,

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > On 11/05, Mina Almasry wrote: >> For device memory TCP, we expect the skb headers to be available in host >> memory for access, and we expect the skb frags to be in device memory >> and unaccessible to the host. We expect there to be no mixing and

Re: [PATCH v4 00/32] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-11-06 Thread Melissa Wen
On 10/06, Sebastian Wick wrote: > On Thu, Oct 05, 2023 at 04:14:55PM -0100, Melissa Wen wrote: > > Hello, > > > > Just another iteration for AMD driver-specific color properties. > > Basically, addressing comments from the previous version. > > > > Recap: this series extends the current KMS

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 10:44 AM Stanislav Fomichev wrote: > > On 11/05, Mina Almasry wrote: > > In tcp_recvmsg_locked(), detect if the skb being received by the user > > is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM > > flag - pass it to tcp_recvmsg_devmem() for custom

Re: drm/panel: panel-simple power-off sequencing

2023-11-06 Thread Doug Anderson
Hi, On Fri, Oct 27, 2023 at 7:31 AM Doug Anderson wrote: > > I guess, in summary, I'm hoping you'll look again and find that this > really is a backlight enable. If not, I'd probably advocate for a > per-panel boolean. Circling back, I'm curious what ended up happening here. Did you decide that

Re: [PATCH v2 2/3] drm/amdgpu: Add flag to disable implicit sync for GEM operations.

2023-11-06 Thread Christian König
Am 06.11.23 um 16:47 schrieb Tatsuyuki Ishi: On Nov 6, 2023, at 22:44, Christian König wrote: Am 02.11.23 um 15:04 schrieb Tatsuyuki Ishi: In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. Until now,

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Hunter Chasens
First, apologies to Jani Nikula. I accedently top posted on the other thread. My email client is giving me a hard time. The following works and, if everyone agrees, I'll send out a v2. * E.g.:: * * S: 19Mhz * * 0: 615Mhz * 1: 800Mhz * 2: 888Mhz * 3: 1000Mhz

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Lukas Wunner
On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > Tangentially related; the link speed is currently symmetric but there are > two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may > be asymmetric in the future. So we may need to keep that in mind on any >

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Alex Deucher
Applied. This matches what we already do in the other clear state headers. Alex On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh wrote: > > sparse static analysis tools generate a warning with this message > "Using plain integer as NULL pointer". In this case this warning is > being shown because

Re: [PATCH v4 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

2023-11-06 Thread Melissa Wen
On 11/02, Joshua Ashton wrote: > Also, Melissa, you cannot do: > > if (!plane_state->color_mgmt_changed) > return 0; > > in amdgpu_dm_plane_set_color_properties. > > The allocation for dc_plane_state could be new and zero'ed so it needs to be > set every time. (Until AMDGPU

  1   2   3   >