Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Thomas Zimmermann
Hi Am 27.11.23 um 17:25 schrieb Alyssa Ross: Thomas Zimmermann writes: Invoke drm_plane_helper_funcs.end_fb_access before drm_atomic_helper_commit_hw_done(). The latter function hands over ownership of the plane state to the following commit, which might free it. Releasing resources in

Re: [PATCH] drm: lcdif: Switch to drmm_mode_config_init

2023-11-27 Thread Thomas Zimmermann
Am 27.11.23 um 22:26 schrieb Marek Vasut: Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP

Re: [PATCH v2] drm/mxsfb: Switch to drmm_mode_config_init

2023-11-27 Thread Thomas Zimmermann
Am 27.11.23 um 22:25 schrieb Marek Vasut: Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Vignesh Raman
On 28/11/23 12:21, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: Hi Mani, On 28/11/23 10:44, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add

Re: [PATCH 01/14] arch/powerpc: Remove legacy DRM drivers from default configs

2023-11-27 Thread Cai Huoqing
On 22 11月 23 13:09:30, Thomas Zimmermann wrote: > DRM drivers for user-space modesetting have been removed. Do not > select the respective options in the default configs. > > Signed-off-by: Thomas Zimmermann > Fixes: a276afc19eec ("drm: Remove some obsolete drm pciids(tdfx, mga, i810, > savage,

[bug report] backlight: mp3309c: Add support for MPS MP3309C

2023-11-27 Thread Dan Carpenter
Hello Flavio Suligoi, The patch 2e914516a58c: "backlight: mp3309c: Add support for MPS MP3309C" from Nov 16, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/video/backlight/mp3309c.c:277 pm3309c_parse_dt_node() error: uninitialized symbol

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Manivannan Sadhasivam
On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: > Hi Mani, > > On 28/11/23 10:44, Manivannan Sadhasivam wrote: > > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > > > to acquire bus lock")

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Vignesh Raman
Hi Mani, On 28/11/23 10:44, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock") has added an argument to acquire bus lock in pci_enable_link_state, but

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Manivannan Sadhasivam
On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > to acquire bus lock") has added an argument to acquire bus lock > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > without this argument, resulting

[PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Vignesh Raman
Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock") has added an argument to acquire bus lock in pci_enable_link_state, but qcom_pcie_enable_aspm calls it without this argument, resulting in below build error. drivers/pci/controller/dwc/pcie-qcom.c:973:9:

[PATCH v2] drm/exynos: fix a wrong error checking

2023-11-27 Thread Inki Dae
Fix a wrong error checking in exynos_drm_dma.c module. In the exynos_drm_register_dma function, both arm_iommu_create_mapping() and iommu_get_domain_for_dev() functions are expected to return NULL as an error. However, the error checking is performed using the statement if(IS_ERR(mapping)),

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-27 Thread Paz Zcharya
On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > On 21.11.2023 13:06, Andrzej Hajda wrote: > > On 18.11.2023 00:01, Paz Zcharya wrote: > > > On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: > > > > On Sun, Nov 05, 2023 at 05:27:03PM +, Paz Zcharya wrote: > > > > > > Hi

Re: [v3 3/3] drm/bridge: it6505: Add audio support

2023-11-27 Thread Chen-Yu Tsai
On Tue, Nov 21, 2023 at 8:54 PM AngeloGioacchino Del Regno wrote: > > Il 30/07/23 20:08, Jiaxin Yu ha scritto: > > Add audio support for it6505 > > > > 1. Bridge to hdmi-codec to support audio feature. At the same time, > > the function of automatically detecting audio is removed. > > 2. It

Re: [PATCH] drm/msm/mdp4: flush vblank event on disable

2023-11-27 Thread Abhinav Kumar
On 11/27/2023 3:17 PM, Dmitry Baryshkov wrote: On Tue, 28 Nov 2023 at 00:00, Abhinav Kumar wrote: On 11/27/2023 1:54 PM, Dmitry Baryshkov wrote: Flush queued events when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's

Re: [PATCH] drm/msm/dpu: Capture dpu snapshot when frame_done_timer timeouts

2023-11-27 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 03:12, Paloma Arellano wrote: > > Trigger a devcoredump to dump dpu registers and capture the drm atomic > state when the frame_done_timer timeouts. > > Signed-off-by: Paloma Arellano > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 +++-- > 1 file

Re: [GIT PULL] exynos-drm-fixes

2023-11-27 Thread Inki Dae
Hi Dave, 2023년 11월 24일 (금) 오전 10:14, Dave Airlie 님이 작성: > On Tue, 21 Nov 2023 at 09:00, Inki Dae wrote: > > > > Hi Dave and Daniel, > > > >Two fixups - fixing a potential error pointer dereference and wrong > >error checking. > Hi Inki, > > This fails to build on arm32, and it seems one

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-27 Thread Paz Zcharya
On Wed, Nov 22, 2023 at 02:26:55PM +0100, Andrzej Hajda wrote: > > > On 21.11.2023 13:06, Andrzej Hajda wrote: > > On 18.11.2023 00:01, Paz Zcharya wrote: > > > On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: > > > > On Sun, Nov 05, 2023 at 05:27:03PM +, Paz Zcharya wrote: > >

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()

2023-11-27 Thread Doug Anderson
Hi, On Thu, Nov 23, 2023 at 9:54 AM Uwe Kleine-König wrote: > > pm_runtime_resume_and_get() already drops the runtime PM usage counter > in the error case. So a call to pm_runtime_put_sync() can be dropped. > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 6

[PATCH] drm/msm/dpu: Capture dpu snapshot when frame_done_timer timeouts

2023-11-27 Thread Paloma Arellano
Trigger a devcoredump to dump dpu registers and capture the drm atomic state when the frame_done_timer timeouts. Signed-off-by: Paloma Arellano --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/bridge: ti-sn65dsi86: Associate PWM device to auxiliary device

2023-11-27 Thread Doug Anderson
Hi, On Mon, Nov 27, 2023 at 2:15 AM Uwe Kleine-König wrote: > > It's the ti_sn65dsi86.pwm auxiliary driver that creates the pwmchip, so > let the auxiliary device be the parent of the pwm device. > > Note that getting a reference to the ti-sn65dsi86's pwm using pwm_get() > isn't affected by this

Re: [PATCH 0/3] Revert panel fixes and original buggy patch

2023-11-27 Thread Laurent Pinchart
On Tue, Nov 28, 2023 at 12:36:15AM +0100, Linus Walleij wrote: > On Tue, Nov 28, 2023 at 12:25 AM Laurent Pinchart wrote: > > On Tue, Nov 28, 2023 at 12:10:18AM +0100, Linus Walleij wrote: > > > This series reverts the attempts to fix the bug that went > > > into v6.7-rc1 in commit 199cf07ebd2b >

Re: [PATCH 0/3] Revert panel fixes and original buggy patch

2023-11-27 Thread Linus Walleij
On Tue, Nov 28, 2023 at 12:25 AM Laurent Pinchart wrote: > On Tue, Nov 28, 2023 at 12:10:18AM +0100, Linus Walleij wrote: > > This series reverts the attempts to fix the bug that went > > into v6.7-rc1 in commit 199cf07ebd2b > > "drm/bridge: panel: Add a device link between drm device and panel

Re: [PATCH 0/3] Revert panel fixes and original buggy patch

2023-11-27 Thread Laurent Pinchart
, 27 deletions(-) > --- > base-commit: 95ba893c9f4feb836ddce627efd0bb6af6667031 > change-id: 20231127-revert-panel-fix-e4da3e11e7a4 -- Regards, Laurent Pinchart

Re: Radeon regression in 6.6 kernel

2023-11-27 Thread Phillip Susi
Alex Deucher writes: >> In that case those are the already known problems with the scheduler >> changes, aren't they? > > Yes. Those changes went into 6.7 though, not 6.6 AFAIK. Maybe I'm > misunderstanding what the original report was actually testing. If it > was 6.7, then try reverting: >

Re: [PATCH] drm/msm/mdp4: flush vblank event on disable

2023-11-27 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 00:00, Abhinav Kumar wrote: > > > > On 11/27/2023 1:54 PM, Dmitry Baryshkov wrote: > > Flush queued events when disabling the crtc. This avoids timeouts when > > we come back and wait for dependencies (like the previous frame's > > flip_done). > > > > Fixes: c8afe684c95c

[PATCH 1/3] Revert "driver core: Export device_is_dependent() to modules"

2023-11-27 Thread Linus Walleij
This reverts commit 1d5e8f4bf06da86b71cc9169110d1a0e1e7af337. Greg says: "why exactly is this needed? Nothing outside of the driver core should be needing this function, it shouldn't be public at all (I missed that before.) So please, revert it for now, let's figure out why DRM thinks this is

[PATCH 2/3] Revert "drm/bridge: panel: Check device dependency before managing device link"

2023-11-27 Thread Linus Walleij
This reverts commit 39d5b6a64ace77d0c11c398d272218df5f939abb. This patch was causing build errors by using an unexported function from the device core, which Greg questions the saneness in exporting. Link:

[PATCH 3/3] Revert "drm/bridge: panel: Add a device link between drm device and panel device"

2023-11-27 Thread Linus Walleij
This reverts commit 199cf07ebd2b0d41185ac79b895547d45610b681. This patch creates bugs on devices where the DRM device is the ancestor of the panel devices. Attempts to fix this have failed because it leads to using device core functionality which is questionable. Reported-by: Linus Walleij

[PATCH 0/3] Revert panel fixes and original buggy patch

2023-11-27 Thread Linus Walleij
1 - drivers/gpu/drm/bridge/panel.c | 26 -- 2 files changed, 27 deletions(-) --- base-commit: 95ba893c9f4feb836ddce627efd0bb6af6667031 change-id: 20231127-revert-panel-fix-e4da3e11e7a4 Best regards, -- Linus Walleij

Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-27 Thread Linus Walleij
On Mon, Nov 27, 2023 at 7:20 PM Greg KH wrote: [Maxime] > > So, a committer just applied this to drm-misc-fixes without your > > approval. That was me, mea culpa. I learned a lesson. Or two. > Wait, why exactly is this needed? Nothing outside of the driver core > should be needing this

Re: [PATCH v2] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-11-27 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Nov 23, 2023 at 3:22 AM Christian König wrote: > > Am 23.11.23 um 02:22 schrieb Lu Yao: > > For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init > > 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func > > 'amdgpu_debugfs_regs_didt_read/write',

Re: [PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-27 Thread Linus Walleij
On Mon, Nov 27, 2023 at 5:29 PM Maxime Ripard wrote: > On Mon, Nov 27, 2023 at 05:03:53PM +0100, Linus Walleij wrote: > > > Liu Ying (2): > > > driver core: Export device_is_dependent() to modules > > > drm/bridge: panel: Check device dependency before managing device link > > > > I just

Re: [PATCH] drm/msm/mdp4: flush vblank event on disable

2023-11-27 Thread Abhinav Kumar
On 11/27/2023 1:54 PM, Dmitry Baryshkov wrote: Flush queued events when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") Signed-off-by: Dmitry Baryshkov

[PATCH] drm/msm/mdp4: flush vblank event on disable

2023-11-27 Thread Dmitry Baryshkov
Flush queued events when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 9

Re: [PATCH v6 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-11-27 Thread Rodrigo Vivi
On Tue, Nov 14, 2023 at 07:52:29AM -0800, Alan Previn wrote: > If we are at the end of suspend or very early in resume > its possible an async fence signal (via rcu_call) is triggered > to free_engines which could lead us to the execution of > the context destruction worker (after a prior worker

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-27 Thread Dave Airlie
On Tue, 28 Nov 2023 at 06:48, Timur Tabi wrote: > > On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > > rpc->size = sizeof(*rpc); > > - rpc->numEntries = 1; > > - rpc->entries[0].nameOffset = offsetof(typeof(*rpc), entries[1]); > > - rpc->entries[0].type = 1; > > -

[PATCH] drm: lcdif: Switch to drmm_mode_config_init

2023-11-27 Thread Marek Vasut
Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc:

[PATCH v2] drm/mxsfb: Switch to drmm_mode_config_init

2023-11-27 Thread Marek Vasut
Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc:

Re: [PATCH 14/14] drm: Remove Kconfig option for legacy support (CONFIG_DRM_LEGACY)

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > Remove CONFIG_DRM_LEGACY from Kconfig. Nothing depends on the option. > > Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher > --- > drivers/gpu/drm/Kconfig | 21 - > 1 file changed, 21 deletions(-) > >

Re: [PATCH 13/14] char/agp: Remove frontend code

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > The AGP subsystem supports a user-space interface via /dev/agpgart. It > is only enabled with DRM support for mode setting in user space. (i.e., > CONFIG_DRM_LEGACY). All of that DRM code has been removed and the option > will go away.

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-27 Thread Dmitry Baryshkov
On Mon, 27 Nov 2023 at 22:52, Rob Clark wrote: > > On Tue, Nov 21, 2023 at 5:14 AM Dmitry Baryshkov > wrote: > > > > On Tue, 21 Nov 2023 at 04:26, Rob Clark wrote: > > > > > > On Wed, Nov 15, 2023 at 11:33 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On Wed, 15 Nov 2023 at 20:46, Dipam

Re: [PATCH 12/14] drm: Remove source code for non-KMS drivers

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > Remove all remaining source code for non-KMS drivers. These drivers > have been removed in v6.3 and won't comeback. > > Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher

Re: [PATCH 11/14] drm: Remove locking for legacy ioctls and DRM_UNLOCKED

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > Modern DRM drivers acquire ioctl locks by themselves. Legacy ioctls > for user-space mode setting used to acquire drm_global_mutex. After > removing the ioctl entry points, also remove the locking code. The only > legacy ioctl without

Re: [PATCH 10/14] drm: Remove support for legacy drivers

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > Remove all hooks and calls into code for user-space mode setting from > the DRM core. Without the drivers and ioctl entry points, none of this > is required any longer. > > Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher >

Re: [PATCH 09/14] drm: Remove the legacy DRM_IOCTL_MODESET_CTL ioctl

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > DRM drivers with user-space mode setting have been removed in Linux > v6.3. [1] Now remove the ioctl entry points for these drivers. Invoking > any of the ioctl ops will unconditionally return -EINVAL to user space. > > Invoking

Re: [PATCH 08/14] drm: Remove entry points for legacy ioctls

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > DRM drivers with user-space mode setting have been removed in Linux > v6.3. [1] Now remove the ioctl entry points for these drivers. Invoking > any of the ioctl ops will unconditionally return -EINVAL to user space. > This has already

Re: [PATCH 05/14] accel: Include

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > One of the source files includes via , > which will be removed. Include drm_auth.h directly. > > Signed-off-by: Thomas Zimmermann > Cc: Oded Gabbay Acked-by: Alex Deucher > --- > drivers/accel/drm_accel.c | 1 + > 1 file changed,

Re: [PATCH 03/14] drm: Include

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > One of the source files includes via , > which will be removed. Include drm_auth.h directly. > > Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher > --- > drivers/gpu/drm/drm_pci.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 01/14] arch/powerpc: Remove legacy DRM drivers from default configs

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > DRM drivers for user-space modesetting have been removed. Do not > select the respective options in the default configs. > > Signed-off-by: Thomas Zimmermann > Fixes: a276afc19eec ("drm: Remove some obsolete drm pciids(tdfx, mga, i810,

Re: [PATCH 02/14] drm: Fix TODO list mentioning non-KMS drivers

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > Non-KMS drivers have been removed from DRM. Update the TODO list > accordingly. > > Signed-off-by: Thomas Zimmermann > Fixes: a276afc19eec ("drm: Remove some obsolete drm pciids(tdfx, mga, i810, > savage, r128, sis, via)") > Cc: Cai

Re: [PATCH 07/14] drm/radeon: Do not include

2023-11-27 Thread Alex Deucher
On Wed, Nov 22, 2023 at 7:25 AM Thomas Zimmermann wrote: > > Including is not required by radeon. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedesktop.org Acked-by: Alex Deucher > --- >

Re: [PATCH] drm/amd/pm: fix a memleak in aldebaran_tables_init

2023-11-27 Thread Alex Deucher
Applied. Thanks! On Thu, Nov 23, 2023 at 3:08 AM Dinghao Liu wrote: > > When kzalloc() for smu_table->ecc_table fails, we should free > the previously allocated resources to prevent memleak. > > Fixes: edd794208555 ("drm/amd/pm: add message smu to get ecc_table v2") > Signed-off-by: Dinghao Liu

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-27 Thread Rob Clark
On Tue, Nov 21, 2023 at 5:14 AM Dmitry Baryshkov wrote: > > On Tue, 21 Nov 2023 at 04:26, Rob Clark wrote: > > > > On Wed, Nov 15, 2023 at 11:33 AM Dmitry Baryshkov > > wrote: > > > > > > On Wed, 15 Nov 2023 at 20:46, Dipam Turkar wrote: > > > > > > > > They are not outdated, my bad. I went

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-27 Thread Timur Tabi
On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > rpc->size = sizeof(*rpc); > - rpc->numEntries = 1; > - rpc->entries[0].nameOffset = offsetof(typeof(*rpc), entries[1]); > - rpc->entries[0].type = 1; > - rpc->entries[0].data = 0; > -

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915/gt: Dont wait forever when idling in suspend

2023-11-27 Thread Rodrigo Vivi
On Tue, Nov 14, 2023 at 08:22:27AM -0800, Alan Previn wrote: > When suspending, add a timeout when calling > intel_gt_pm_wait_for_idle else if we have a leaked > wakeref (which would be indicative of a bug elsewhere > in the driver), driver will at exit the suspend-resume > cycle, after the kernel

Re: [PATCH v2 1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-27 Thread Rodrigo Vivi
On Wed, Nov 22, 2023 at 12:30:03PM -0800, Alan Previn wrote: > Add missing tag for "Wa_14019159160 - Case 2" (for existing > PXP code that ensures run alone mode bit is set to allow > PxP-decryption. > > v2: - Fix WA id number (John Harrison). > - Improve comments and code to be specific >

[PATCH v3 1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-27 Thread Alan Previn
Add missing tag for "Wa_14019159160 - Case 2" (for existing PXP code that ensures run alone mode bit is set to allow PxP-decryption. v3: - Check targeted platforms using IP_VAL. (John Harrison) v2: - Fix WA id number (John Harrison). - Improve comments and code to be specific for

Re: [Nouveau] [PATCH] nouveau/gsp/r535: remove a stray unlock in r535_gsp_rpc_send()

2023-11-27 Thread Timur Tabi
On Mon, 2023-11-27 at 15:56 +0300, Dan Carpenter wrote: > This unlock doesn't belong here and it leads to a double unlock in > the caller, r535_gsp_rpc_push(). > > Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP- > RM") > Signed-off-by: Dan Carpenter Nice catch!

Re: [PATCH v5] Documentation/gpu: VM_BIND locking document

2023-11-27 Thread Danilo Krummrich
On 11/22/23 08:49, Thomas Hellström wrote: On 11/21/23 14:56, Boris Brezillon wrote: On Tue, 21 Nov 2023 11:40:46 +0100 Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes

Re: [Intel-xe] [PATCH v5] Documentation/gpu: VM_BIND locking document

2023-11-27 Thread Rodrigo Vivi
On Tue, Nov 21, 2023 at 11:40:46AM +0100, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions, evicton and for

[PATCH v3 16/17] drm/v3d: Create a CPU job extension for the reset performance query job

2023-11-27 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A reset performance query job is a job that resets the performance queries by resetting the values of the perfmons. Moreover, we also reset the syncobjs related to the availability of the query. So, create a user

[PATCH v3 15/17] drm/v3d: Create a CPU job extension to copy timestamp query to a buffer

2023-11-27 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A copy timestamp query job is a job that copy the complete or partial result of a query to a buffer. As V3D doesn't provide any mechanism to obtain a timestamp from the GPU, it is a job that needs CPU intervention.

[PATCH v3 14/17] drm/v3d: Create a CPU job extension for the reset timestamp job

2023-11-27 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A reset timestamp job is a job that resets the timestamp queries based on the value offset of the first query. As V3D doesn't provide any mechanism to obtain a timestamp from the GPU, it is a job that needs CPU

[PATCH v3 17/17] drm/v3d: Create a CPU job extension for the copy performance query job

2023-11-27 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A copy performance query job is a job that copy the complete or partial result of a query to a buffer. In order to copy the result of a performance query to a buffer, we need to get the values from the performance

[PATCH v3 13/17] drm/v3d: Create a CPU job extension for the timestamp query job

2023-11-27 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A timestamp query job is a job that calculates the query timestamp and updates the query availability by signaling a syncobj. As V3D doesn't provide any mechanism to obtain a timestamp from the GPU, it is a job

[PATCH v3 12/17] drm/v3d: Create a CPU job extension for a indirect CSD job

2023-11-27 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. An indirect CSD job is a job that, when executed in the queue, will map the indirect buffer, read the dispatch parameters, and submit a regular dispatch. Therefore, it is a job that needs CPU intervention. So,

[PATCH v3 10/17] drm/v3d: Detach the CSD job BO setup

2023-11-27 Thread Maíra Canal
From: Melissa Wen Detach CSD job setup from CSD submission ioctl to reuse it in CPU submission ioctl for indirect CSD job. Signed-off-by: Melissa Wen Co-developed-by: Maíra Canal Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_submit.c | 68 1 file

[PATCH v3 11/17] drm/v3d: Enable BO mapping

2023-11-27 Thread Maíra Canal
For the indirect CSD CPU job, we will need to access the internal contents of the BO with the dispatch parameters. Therefore, create methods to allow the mapping and unmapping of the BO. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_bo.c | 18 ++

[PATCH v3 09/17] drm/v3d: Create tracepoints to track the CPU job

2023-11-27 Thread Maíra Canal
Create tracepoints to track the three major events of a CPU job lifetime: 1. Submission of a `v3d_submit_cpu` IOCTL 2. Beginning of the execution of a CPU job 3. Ending of the execution of a CPU job Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_sched.c | 4 +++

[PATCH v3 07/17] drm/v3d: Add a CPU job submission

2023-11-27 Thread Maíra Canal
From: Melissa Wen Create a new type of job, a CPU job. A CPU job is a type of job that performs operations that requires CPU intervention. The overall idea is to use user extensions to enable different types of CPU job, allowing the CPU job to perform different operations according to the type

[PATCH v3 08/17] drm/v3d: Use v3d_get_extensions() to parse CPU job data

2023-11-27 Thread Maíra Canal
Currently, v3d_get_extensions() only parses multisync data and assigns it to the `struct v3d_submit_ext`. But, to implement the CPU job with user extensions, we want v3d_get_extensions() to be able to parse CPU job data and assign it to the `struct v3d_cpu_job`. Therefore, allow the function

[PATCH v3 06/17] drm/v3d: Decouple job allocation from job initiation

2023-11-27 Thread Maíra Canal
We want to allow the IOCTLs to allocate the job without initiating it. This will be useful for the CPU job submission IOCTL, as the CPU job has the need to use information from the user extensions. Currently, the user extensions are parsed before the job allocation, making it impossible to fill

[PATCH v3 00/17] drm/v3d: Introduce CPU jobs

2023-11-27 Thread Maíra Canal
This patchset implements the basic infrastructure for a new type of V3D job, a CPU job. A CPU job is a job that requires CPU intervention. It would be nice to perform this operations on the kernel space as we can attach multiple in/out syncobjs to it. Why we want a CPU job on the kernel?

[PATCH v3 05/17] drm/v3d: Don't allow two multisync extensions in the same job

2023-11-27 Thread Maíra Canal
Currently, two multisync extensions can be added to the same job and only the last multisync extension will be used. To avoid this vulnerability, don't allow two multisync extensions in the same job. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_submit.c | 5 + 1 file changed, 5

[PATCH v3 03/17] drm/v3d: Detach job submissions IOCTLs to a new specific file

2023-11-27 Thread Maíra Canal
From: Melissa Wen We will include a new job submission type, the CPU job submission. For readability and maintability, separate the job submission IOCTLs and related operations from v3d_gem.c. Minor fix in the CSD submission kernel doc: CSD (texture formatting) -> CSD (compute shader).

[PATCH v3 04/17] drm/v3d: Simplify job refcount handling

2023-11-27 Thread Maíra Canal
From: Melissa Wen Instead of checking if the job is NULL every time we call the function, check it inside the function. Signed-off-by: Melissa Wen Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_submit.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v3 02/17] drm/v3d: Move wait BO ioctl to the v3d_bo file

2023-11-27 Thread Maíra Canal
From: Melissa Wen IOCTLs related to BO operations reside on the file v3d_bo.c. The wait BO ioctl is the only IOCTL regarding BOs that is placed in a different file. So, move it to the v3d_bo.c file. Signed-off-by: Melissa Wen Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_bo.c | 33

[PATCH v3 01/17] drm/v3d: Remove unused function header

2023-11-27 Thread Maíra Canal
From: Melissa Wen v3d_mmu_get_offset header was added but the function was never defined. Just remove it. Signed-off-by: Melissa Wen Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.h

Re: [PATCH 2/2] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2023-11-27 Thread Christian König
Am 27.11.23 um 17:47 schrieb Bhardwaj, Rajneesh: [AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: Monday, November 27, 2023 10:53 AM To: Christian König ; jani.nik...@linux.intel.com; kher...@redhat.com; d...@redhat.com;

Re: [PATCH] Replace ioremap_cache() with memremap()

2023-11-27 Thread Nischala Yelchuri
Wei, this is one of the Hyper-V code improvement tasks that Michael Kelley identified. Using memremap() is the right thing to do here. Abhinav Singh (cc'ed) also tried to fix this earlier as there are sparse warnings with ioremap_cache(). On Sun, Nov 12, 2023 at 11:12:33PM +, Wei Liu wrote:

Re: [PATCH 04/12] dt-bindings: display: msm: sm8450-mdss: Allow 3 interconnects

2023-11-27 Thread Rob Herring
On Sat, 25 Nov 2023 15:17:32 +0100, Konrad Dybcio wrote: > In addition to MDP01, the cpu-cfg interconnect is also necessary. > Allow it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 03/12] dt-bindings: display: msm: qcm2290-mdss: Allow 2 interconnects

2023-11-27 Thread Rob Herring
On Sat, 25 Nov 2023 15:17:31 +0100, Konrad Dybcio wrote: > In addition to MDP0, the cpu-cfg interconnect is also necessary. > Allow it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-27 Thread Greg KH
On Mon, Nov 27, 2023 at 05:38:13PM +0100, Maxime Ripard wrote: > Greg, Rafael, > > On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > > Export device_is_dependent() since the drm_kms_helper module is starting > > to use it. > > > > Signed-off-by: Liu Ying > > --- > > v2: > > * Newly

Re: [PATCH] dt-bindings: display: mediatek: dsi: remove Xinlei's mail

2023-11-27 Thread Rob Herring
On Thu, 23 Nov 2023 14:49:27 +0100, Michael Walle wrote: > Xinlei Lee's mail is bouncing: > > : host mailgw02.mediatek.com[216.200.240.185] said: > 550 Relaying mail to xinlei@mediatek.com is not allowed (in reply to > RCPT TO command) > > Remove it. > > Signed-off-by: Michael

Re: [PATCH drm-misc-next 4/5] drm/gpuvm: fall back to drm_exec_lock_obj()

2023-11-27 Thread Danilo Krummrich
Hi, On 11/27/23 14:52, Christian König wrote: Am 25.11.23 um 00:40 schrieb Danilo Krummrich: Hi Christian, do you think it makes sense to handle this in drm_exec_prepare_obj() or even dma_resv_reserve_fences() even? IIRC for drm_exec the discussion has gone a bit back and forth between

Re: [PATCH] dt-bindings: mxsfb: Remove power-domains requirements for i.MX7D

2023-11-27 Thread Conor Dooley
- power-domains >- if: >properties: > compatible: >contains: > enum: >- fsl,imx6sl-lcdif > - - fsl,imx6sx-lcdif >- fsl,imx8mm-lcdif >- fsl,imx8mn-lcdif >

Re: [PATCH 1/2] dt-bindings: display: bridge: samsung-dsim: Add i.MX7D support

2023-11-27 Thread Conor Dooley
On Mon, Nov 27, 2023 at 05:12:28PM +0100, Roland Hieber wrote: > From: Philipp Zabel > > Add support for the "fsl,imx7d-mipi-dsim" compatible used on i.MX7D. > > Signed-off-by: Philipp Zabel > Signed-off-by: Roland Hieber Acked-by: Conor Dooley Cheers, Conor. > --- >

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix check in dma_resv_add_fence

2023-11-27 Thread Intel
On 11/27/23 14:24, Christian König wrote: Ping? Can I get an rb or acked-by for that? Thanks, Christian. Am 15.11.23 um 10:30 schrieb Christian König: It's valid to add the same fence multiple times to a dma-resv object and we shouldn't need one extra slot for each. Signed-off-by:

RE: [PATCH 2/2] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2023-11-27 Thread Bhardwaj, Rajneesh
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: Monday, November 27, 2023 10:53 AM To: Christian König ; jani.nik...@linux.intel.com; kher...@redhat.com; d...@redhat.com; za...@vmware.com; Olsak, Marek ;

Re: [PATCH v9 07/12] clk: meson: add vclk driver

2023-11-27 Thread Jerome Brunet
On Mon 27 Nov 2023 at 17:14, Neil Armstrong wrote: > On 24/11/2023 15:41, Jerome Brunet wrote: >> On Fri 24 Nov 2023 at 09:41, Neil Armstrong >> wrote: >> >>> The VCLK and VCLK_DIV clocks have supplementary bits. >>> >>> The VCLK has a "SOFT RESET" bit to toggle after the whole >>> VCLK

Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-27 Thread Maxime Ripard
Greg, Rafael, On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > Export device_is_dependent() since the drm_kms_helper module is starting > to use it. > > Signed-off-by: Liu Ying > --- > v2: > * Newly introduced as needed by patch 2. > > drivers/base/core.c | 1 + > 1 file changed, 1

Re: [PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-27 Thread Maxime Ripard
On Mon, Nov 27, 2023 at 05:03:53PM +0100, Linus Walleij wrote: > On Mon, Nov 27, 2023 at 6:10 AM Liu Ying wrote: > > > This series aims to check panel device dependency upon DRM device before > > managing device link between them. It fixes eariler patches in v6.7-rc1 > > which tried to manage

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Alyssa Ross
Thomas Zimmermann writes: > Invoke drm_plane_helper_funcs.end_fb_access before > drm_atomic_helper_commit_hw_done(). The latter function hands over > ownership of the plane state to the following commit, which might > free it. Releasing resources in end_fb_access then operates on undefined >

Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2023-11-27 Thread Eric Farman
On Wed, 2023-11-22 at 13:48 +0100, Christian Brauner wrote: > Ever since the evenfd type was introduced back in 2007 in commit s/evenfd/eventfd/ > e1ad7468c77d ("signal/timer/event: eventfd core") the > eventfd_signal() > function only ever passed 1 as a value for @n. There's no point in >

Re: [PATCH v9 07/12] clk: meson: add vclk driver

2023-11-27 Thread Neil Armstrong
On 24/11/2023 15:41, Jerome Brunet wrote: On Fri 24 Nov 2023 at 09:41, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK has a "SOFT RESET" bit to toggle after the whole VCLK sub-tree rate has been set, this is implemented in the gate enable callback. The

[PATCH 2/2] ARM: dts: imx7: add MIPI-DSI support

2023-11-27 Thread Roland Hieber
From: Marco Felsch This adds the device tree support for the MIPI-DSI block. The block can be used as encoder for the parallel signals coming from the lcdif block. Signed-off-by: Marco Felsch Signed-off-by: Roland Hieber --- arch/arm/boot/dts/nxp/imx/imx7s.dtsi | 46

[PATCH 1/2] dt-bindings: display: bridge: samsung-dsim: Add i.MX7D support

2023-11-27 Thread Roland Hieber
From: Philipp Zabel Add support for the "fsl,imx7d-mipi-dsim" compatible used on i.MX7D. Signed-off-by: Philipp Zabel Signed-off-by: Roland Hieber --- .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 0/2] ARM: dts: imx7: add MIPI-DSI support

2023-11-27 Thread Roland Hieber
| 46 ++ 2 files changed, 49 insertions(+), 1 deletion(-) --- base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab change-id: 20231127-b4-imx7-mipi-dsi-801372e24f13 Best regards, -- Roland Hieber, Pengutronix e.K. | r...@pengutronix.de | Steuerwalder Str. 21

[PATCH] drm/sched: Partial revert of "Qualify drm_sched_wakeup() by drm_sched_entity_is_ready()"

2023-11-27 Thread Bert Karwatzki
Commit f3123c2590005c, in combination with the use of work queues by the GPU scheduler, leads to random lock-ups of the GUI. This is a partial revert of of commit f3123c2590005c since drm_sched_wakeup() still needs its entity argument to pass it to drm_sched_can_queue(). Link:

Re: [PATCH] drm/bridge: panel: Check device dependency before managing device link

2023-11-27 Thread Linus Walleij
On Mon, Nov 27, 2023 at 2:36 PM Ville Syrjälä wrote: > > + panel_bridge->is_independent = !device_is_dependent(drm_dev->dev, > > + panel->dev); > > This broke the build. Looks like device_is_dependent() is not even exported. > ERROR:

  1   2   3   >