Re: [PATCH 1/6] drm/nouveau: convert to using is_hdmi and has_audio from display info

2024-01-14 Thread Jani Nikula
On Sun, 14 Jan 2024, Ilia Mirkin wrote: > On Fri, Jan 12, 2024 at 11:50 AM Jani Nikula wrote: >> >> Prefer the parsed results for is_hdmi and has_audio in display info over >> calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), >> respectively. >> >> Conveniently, this also removes

[git pull] drm fixes for 6.8-rc1

2024-01-14 Thread Dave Airlie
Hi Linus, Hopefully you get your power back at some point, this is just a wrap up of fixes from the last few days. It has the proper fix to the i915/xe collision, we can clean up what you did later once rc1 lands. Otherwise it's a few other i915, a v3d, rockchip and a nouveau fix to make GSP

[PATCH v3] drm: Check output polling initialized before disabling

2024-01-14 Thread Shradha Gupta
In drm_kms_helper_poll_disable() check if output polling support is initialized before disabling polling. If not flag this as a warning. Additionally in drm_mode_config_helper_suspend() and drm_mode_config_helper_resume() calls, that re the callers of these functions, avoid invoking them if

Re: [PATCH AUTOSEL 4.14 3/6] drm/crtc: Fix uninit-value bug in drm_mode_setcrtc

2024-01-14 Thread Sasha Levin
On Tue, Dec 19, 2023 at 10:44:02AM +0200, Jani Nikula wrote: On Mon, 18 Dec 2023, Sasha Levin wrote: From: Ziqi Zhao [ Upstream commit 3823119b9c2b5f9e9b760336f75bc989b805cde6 ] The connector_set contains uninitialized values when allocated with kmalloc_array. However, in the "out" branch,

Re: [pull] amdgpu, amdkfd drm-fixes-6.8

2024-01-14 Thread Dave Airlie
/home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c:548:24: error: arithmetic between different enumeration types ('const enum dc_link_rate' and 'const enum dc_lane_count') [-Werror,-Wenum-enum-conversion]

[PATCH] drm/amd/display: remove kernel-doc misuses in dmub_replay.c

2024-01-14 Thread Randy Dunlap
Change non-kernel-doc comments from "/**" to common "/*" to prevent kernel-doc warnings: dmub_replay.c:262: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Set REPLAY power optimization flags and coasting vtotal.

Re: [git pull] drm for 6.8

2024-01-14 Thread Dave Airlie
On Sat, 13 Jan 2024 at 05:33, Linus Torvalds wrote: > > On Wed, 10 Jan 2024 at 11:49, Dave Airlie wrote: > > > > Let me know if there are any issues, > > Your testing is seriously lacking. > > This doesn't even build. The reason seems to be that commit > b49e894c3fd8 ("drm/i915: Replace custom

[PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device

2024-01-14 Thread Andy Shevchenko
We have a temporary variable to keep pointer to struct device. Utilise it inside the ->probe() implementation. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/hx8357.c

[PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-14 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Include mod_devicetable.h explicitly to replace the dropped of.h which included mod_devicetable.h indirectly. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 14 --

[PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-14 Thread Andy Shevchenko
Move OF table near to the user. While at it, drop comma at terminator entry. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/video/backlight/hx8357.c

[PATCH v1 3/4] backlight: hx8357: Make use of dev_err_probe()

2024-01-14 Thread Andy Shevchenko
Simplify the error handling in probe function by switching from dev_err() to dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/video/backlight/hx8357.c

[PATCH v1 0/4] backlight: hx8357: Clean up and make OF-independent

2024-01-14 Thread Andy Shevchenko
A few ad-hoc cleanups and one patch to make driver OF-independent. Andy Shevchenko (4): backlight: hx8357: Make use of device properties backlight: hx8357: Move OF table closer to its consumer backlight: hx8357: Make use of dev_err_probe() backlight: hx8357: Utilise temporary variable for

[PATCH] drm/i915/guc: Remove usage of the deprecated ida_simple_xx() API

2024-01-14 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_range() is inclusive. So a -1 has been added when needed. Signed-off-by: Christophe JAILLET ---

[PATCH] drm/amdgpu: Remove usage of the deprecated ida_simple_xx() API

2024-01-14 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_range() is inclusive. So a -1 has been added when needed. Signed-off-by: Christophe JAILLET ---

[PATCH] drm/xe/guc: Remove usage of the deprecated ida_simple_xx() API

2024-01-14 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_max() is inclusive. So a -1 has been added when needed. Signed-off-by: Christophe JAILLET ---

[PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference

2024-01-14 Thread Andy Shevchenko
The "im" pins are optional. Add missing check in the hx8357_probe(). Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/642e1230-3358-4006-a17f-3f297897ae74@moroto.mountain Fixes: 7d84a63a39b7 ("backlight: hx8357: Convert to agnostic GPIO API") Signed-off-by: Andy Shevchenko ---

Re: [PATCH AUTOSEL 6.1 5/5] nouveau: fix disp disabling with GSP

2024-01-14 Thread Sasha Levin
On Tue, Jan 09, 2024 at 06:51:25AM +1000, David Airlie wrote: NAK for backporting this to anything, it is just a fix for 6.7 Dropped it from everywhere, thanks! -- Thanks, Sasha

[PATCH v4 1/1] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

2024-01-14 Thread Dipam Turkar
Introduce unit tests for the drm_mode_create_dvi_i_properties() function to ensure the proper creation of DVI-I specific connector properties and success if called multiple times. Signed-off-by: Dipam Turkar --- drivers/gpu/drm/tests/drm_connector_test.c | 58 ++ 1 file