Re: [PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-15 Thread Samuel Thibault
Hello, Helge Deller, le ven. 15 mars 2024 10:35:40 +0100, a ecrit: > You should have marked this patch with "v2"... The actual changes were exactly the same. > On 3/13/24 17:59, Samuel Thibault wrote: > > This remains relatively simple by just enlarging integers. > > I like the patch, but I

[PATCHv2] fbcon: Increase maximum font width x height to 64 x 128

2024-03-15 Thread Samuel Thibault
By using bitmaps we actually support whatever size we would want, but the console currently limits fonts to 64x128 (which gives 60x16 text on 4k screens), so we don't need more for now, and we can easily increase later. Signed-off-by: Samuel Thibault --- Difference from v1: - use a bitmap

[PATCH 5/6] drm: zynqmp_dp: Optionally ignore DPCD errors

2024-03-15 Thread Sean Anderson
When testing, it's convenient to be able to ignore DPCD errors if there is test equipment which can't emulate a DPRX connected to the output. Add some (currently-unused) options to ignore these errors and just reconfigure our internal registers as we usually would. Signed-off-by: Sean Anderson

[PATCH 3/6] drm: zynqmp_dp: Add locking

2024-03-15 Thread Sean Anderson
Add some locking, since none is provided by the drm subsystem. This will prevent the IRQ/workers/bridge API calls from stepping on each other's toes. Signed-off-by: Sean Anderson --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 59 +++- 1 file changed, 42 insertions(+), 17

[PATCH 2/6] drm: zynqmp_dp: Adjust training values per-lane

2024-03-15 Thread Sean Anderson
The feedback we get from the DPRX is per-lane. Make changes using this information, instead of picking the maximum values from all lanes. This results in more-consistent training on marginal links. Signed-off-by: Sean Anderson --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 23 ---

[PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-15 Thread Sean Anderson
Add a debugfs interface for exercising the various test modes supported by the DisplayPort controller. This allows performing compliance testing, or performing signal integrity measurements on a failing link. At the moment, we do not support sink-driven link quality testing, although such support

[PATCH 4/6] drm: zynqmp_dp: Split off several helper functions

2024-03-15 Thread Sean Anderson
In preparation for supporting compliance testing, split off several helper functions. No functional change intended. Signed-off-by: Sean Anderson --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 49 +--- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git

[PATCH 1/6] drm: zynqmp_dp: Downgrade log level for aux retries message

2024-03-15 Thread Sean Anderson
Enable this message for verbose debugging only as it is otherwise printed after every AUX message, quickly filling the log buffer. Signed-off-by: Sean Anderson --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/6] drm: zynqmp_dp: Misc. patches and debugfs support

2024-03-15 Thread Sean Anderson
This series adds debugfs support for the zynqmp_dp driver. The intent is to enable compliance testing or to help debug signal-integrity issues. The first three patches are general improvements (and could be applied independently), while the last three add debugfs support. Sean Anderson (6):

Re: [PATCH] drm/nouveau/dp: Fix incorrect return code in r535_dp_aux_xfer()

2024-03-15 Thread David Airlie
Reviewed-by: Dave Airlie On Sat, Mar 16, 2024 at 7:21 AM Lyude Paul wrote: > > I've recently been seeing some unexplained GSP errors on my RTX 6000 from > failed aux transactions: > > [ 132.915867] nouveau :1f:00.0: gsp: cli:0xc1d2 obj:0x0073 > ctrl cmd:0x00731341 failed:

Re: [PATCH v2 1/4] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-15 Thread Guenter Roeck
On Fri, Mar 15, 2024 at 2:37 PM Douglas Anderson wrote: > > As documented in the description of the transfer() function of > "struct drm_dp_aux", the transfer() function can be called at any time > regardless of the state of the DP port. Specifically if the kernel has > the DP AUX character

Re: [PATCH RFC v3 00/12] drm/msm: generate register header files

2024-03-15 Thread Dmitry Baryshkov
/gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28193 > > > > Signed-off-by: Dmitry Baryshkov > > --- > > Changes in v3: > > - Split XML and git rm patches in hope to pass ML limitations > > - Link to v2: > > https://lore.kernel.org/r/20240315-fd-xml-shi

[PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-15 Thread Douglas Anderson
This is a no-op change to just fix a typo in the name of a static function. Signed-off-by: Douglas Anderson --- Changes in v2: - ("Fix typo in static function (ststus => status)") new for v2. drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 2/4] drm/msm/dp: Account for the timeout in wait_hpd_asserted() callback

2024-03-15 Thread Douglas Anderson
The DP wait_hpd_asserted() callback is passed a timeout which indicates how long we should wait for HPD. This timeout was being ignored in the MSM DP implementation and instead a hardcoded 500 ms timeout was used. Fix it to use the proper timeout. As part of this we move the hardcoded 500 ms

[PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-15 Thread Douglas Anderson
Before the introduction of the wait_hpd_asserted() callback in commit 841d742f094e ("drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux") the API between panel drivers and DP AUX bus drivers was that it was up to the AUX bus driver to wait for HPD in the transfer() function. Now

[PATCH v2 1/4] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-15 Thread Douglas Anderson
As documented in the description of the transfer() function of "struct drm_dp_aux", the transfer() function can be called at any time regardless of the state of the DP port. Specifically if the kernel has the DP AUX character device enabled and userspace accesses "/dev/drm_dp_auxN" directly then

[PATCH v2 0/4] drm/msm/dp: Improve DP AUX transfer vs. HPD interactions

2024-03-15 Thread Douglas Anderson
The main goal of this patch series is to avoid problems running "fwupd" on Qualcomm devices. Right now several of the plugins used with fwupd try talking over all DP AUX busses and this results in a very long timeout on Qualcomm devices. As part of fixing this, I noticed a case where the MSM DP

[PATCH] drm/nouveau/dp: Fix incorrect return code in r535_dp_aux_xfer()

2024-03-15 Thread Lyude Paul
I've recently been seeing some unexplained GSP errors on my RTX 6000 from failed aux transactions: [ 132.915867] nouveau :1f:00.0: gsp: cli:0xc1d2 obj:0x0073 ctrl cmd:0x00731341 failed: 0x While the cause of these is not yet clear, these messages made me notice that the

Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2024-03-15 Thread kernel test robot
Hi Jeffrey, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.8 next-20240315] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH RFC v3 00/12] drm/msm: generate register header files

2024-03-15 Thread Rob Clark
the next iteration. > > [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28193 > > Signed-off-by: Dmitry Baryshkov > --- > Changes in v3: > - Split XML and git rm patches in hope to pass ML limitations > - Link to v2: > https://lore.kernel.org/r/20240315-fd-xml-shipped

Re: Proposal to add CRIU support to DRM render nodes

2024-03-15 Thread Tvrtko Ursulin
On 15/03/2024 02:33, Felix Kuehling wrote: On 2024-03-12 5:45, Tvrtko Ursulin wrote: On 11/03/2024 14:48, Tvrtko Ursulin wrote: Hi Felix, On 06/12/2023 21:23, Felix Kuehling wrote: Executive Summary: We need to add CRIU support to DRM render nodes in order to maintain CRIU support for

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 06:36:19PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 16:15, Mark Brown wrote: > > On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > > > > In the register. You only need to reset the gain to -40dB at the start > > > > of the ramp. > > > Sorry but

Re: [PATCH v10 1/9] drm/panic: Add drm panic locking

2024-03-15 Thread Jocelyn Falempe
On 15/03/2024 16:28, John Ogness wrote: On 2024-03-15, Jocelyn Falempe wrote: +static inline int drm_panic_trylock(struct drm_device *dev, unsigned long *flags) +{ + return raw_spin_trylock_irqsave(>mode_config.panic_lock, *flags); +} [...] +static inline unsigned long

[drm-misc:topic/rust-drm 8/18] error[E0599]: no method named `revoke` found for opaque type `impl PinInit>` in the current scope

2024-03-15 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc topic/rust-drm head: 42abbd1bc1f3362a9adee3d05e54518de90f2205 commit: 5aad7a29ba6037a224c3f8ff36bfb2c82a5d3f4d [8/18] rust: add revocable objects config: x86_64-randconfig-r113-20240315 (https://download.01.org/0day-ci/archive/20240316

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Alexandre Mergnat
On 15/03/2024 16:15, Mark Brown wrote: On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: On 15/03/2024 15:30, Mark Brown wrote: Let me know, when you change de gain to do a ramp down (start from user gain to gain=-40db), next time for the ramp up, how/where do you find

Re: Time for drm-ci-next?

2024-03-15 Thread Rob Clark
On Fri, Mar 15, 2024 at 2:28 AM Jani Nikula wrote: > > On Thu, 14 Mar 2024, Rob Clark wrote: > > When we first merged drm/ci I was unsure if it would need it's own > > -next branch. But after using it for a couple releases, a few times > > I've found myself wanting to backmerge drm/ci changes

[PATCH 2/2] drm/amd/display: Move PRIMARY plane zpos higher

2024-03-15 Thread sunpeng.li
From: Leo Li [Why] Compositors have different ways of assigning surfaces to DRM planes for render offloading. It may decide between various strategies: overlay, underlay, or a mix of both One way for compositors to implement the underlay strategy is to assign a higher zpos to the DRM_PRIMARY

[PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-03-15 Thread sunpeng.li
From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory), to the other (output encoder). Each DCN pipe has the ability to blend in a cursor early on in the pipeline. In other words, there are no

[PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-03-15 Thread sunpeng.li
From: Leo Li These patches aim to make the amdgpgu KMS driver play nicer with compositors when building multi-plane scanout configurations. They do so by: 1. Making cursor behavior more sensible. 2. Allowing placement of DRM OVERLAY planes underneath the PRIMARY plane for 'underlay'

Re: [PATCH] drm/i915/gt: Report full vm address range

2024-03-15 Thread Andi Shyti
Hi Nirmoy, > > In Mesa we've been relying on I915_CONTEXT_PARAM_GTT_SIZE so as long as > > that is adjusted by the kernel > > What do you mean by adjusted by, should it be a aligned size? > > I915_CONTEXT_PARAM_GTT_SIZE ioctl is returning vm->total which is > adjusted(reduced by a page). > >

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-03-15 Thread Ville Syrjälä
On Wed, Feb 28, 2024 at 10:12:28AM +, Simon Ser wrote: > On Tuesday, February 27th, 2024 at 20:35, Ville Syrjala > wrote: > > > From: Ville Syrjälä > > > > Add a new immutable plane property by which a plane can advertise > > a handful of recommended plane sizes. This would be mostly

[PATCH 05/10] drivers: use new capable_any functionality

2024-03-15 Thread Christian Göttsche
Use the new added capable_any function in appropriate cases, where a task is required to have any of two capabilities. Reorder CAP_SYS_ADMIN last. Signed-off-by: Christian Göttsche Acked-by: Alexander Gordeev (s390 portion) --- v4: Additional usage in kfd_ioctl() v3: rename to

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-15 Thread Johan Hovold
On Thu, Mar 14, 2024 at 09:30:57AM -0700, Abhinav Kumar wrote: > On 3/14/2024 8:38 AM, Johan Hovold wrote: > > On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote: > > Perhaps I'm missing something in the race that you are trying to > > describe (and which I've asked you to describe in

Re: [PATCH 1/3] accel/qaic: Add bootlog debugfs

2024-03-15 Thread Jeffrey Hugo
On 3/14/2024 5:41 AM, Jacek Lawrynowicz wrote: Hi, On 11.03.2024 17:58, Jeffrey Hugo wrote: During the boot process of AIC100, the bootloaders (PBL and SBL) log messages to device RAM. During SBL, if the host opens the QAIC_LOGGING channel, SBL will offload the contents of the log buffer to

Re: [PATCH v10 1/9] drm/panic: Add drm panic locking

2024-03-15 Thread John Ogness
On 2024-03-15, Jocelyn Falempe wrote: > +static inline int drm_panic_trylock(struct drm_device *dev, unsigned long > *flags) > +{ > + return raw_spin_trylock_irqsave(>mode_config.panic_lock, *flags); > +} [...] > +static inline unsigned long drm_panic_lock(struct drm_device *dev) > +{ > +

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-03-15 Thread Alexandre Mergnat
On 15/03/2024 15:38, Mark Brown wrote: On Tue, Mar 12, 2024 at 09:58:05AM +0100, Alexandre Mergnat wrote: I'm a bit lost for mixer-test and pcm-test. Currently, I cross-compile the alsa lib project to be able to build the tests and put it on my board. I can execute it, but I still have 2

Re: [PATCH v2 8/8] drm: xlnx: Intoduce TPG CRTC driver

2024-03-15 Thread Maxime Ripard
On Thu, Mar 14, 2024 at 07:43:30PM +, Klymenko, Anatoliy wrote: > > > +/* > > > +- > > > + > > > + * DRM CRTC > > > + */ > > > + > > > +static enum drm_mode_status xlnx_tpg_crtc_mode_valid(struct drm_crtc > > *crtc, >

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 15:30, Mark Brown wrote: > > > Let me know, when you change de gain to do a ramp down (start from user > > > gain > > > to gain=-40db), next time for the ramp up, how/where do you find the user > > > gain ? > >

[PATCH v10 9/9] drm/ast: Add drm_panic support

2024-03-15 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v7 * Use drm_for_each_primary_visible_plane() v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() (Thomas Zimmermann) v9: * Revert to using get_scanout_buffer() (Sima)

[PATCH v10 4/9] drm/panic: Add debugfs entry to test without triggering panic.

2024-03-15 Thread Jocelyn Falempe
Add a debugfs file, so you can test drm_panic without freezing your machine. This is unsafe, and should be enabled only for developer or tester. To display the drm_panic screen on the device 0: echo 1 > /sys/kernel/debug/dri/0/drm_panic_plane_0 v9: * Create a debugfs file for each plane in the

[PATCH v10 8/9] drm/imx: Add drm_panic support

2024-03-15 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v7: * use drm_panic_gem_get_scanout_buffer() helper v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() v9: * Revert to using get_scanout_buffer() (Sima) *

[PATCH v10 6/9] drm/simpledrm: Add drm_panic support

2024-03-15 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v8: * Replace get_scanout_buffer() with drm_panic_set_buffer() (Thomas Zimmermann) v9: * Revert to using get_scanout_buffer() (Sima) * move get_scanout_buffer() to plane

[PATCH v10 7/9] drm/mgag200: Add drm_panic support

2024-03-15 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) v7: * use drm_for_each_primary_visible_plane() v8: * Replace get_scanout_buffer() logic with

[PATCH v10 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

2024-03-15 Thread Jocelyn Falempe
This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() (Thomas Zimmermann) v9: * go back to get_scanout_buffer() * move get_scanout_buffer() to plane helper functions Signed-off-by:

[PATCH v10 3/9] drm/panic: Add support for color format conversion

2024-03-15 Thread Jocelyn Falempe
Add support for the following formats: DRM_FORMAT_RGB565 DRM_FORMAT_RGBA5551 DRM_FORMAT_XRGB1555 DRM_FORMAT_ARGB1555 DRM_FORMAT_RGB888 DRM_FORMAT_XRGB DRM_FORMAT_ARGB DRM_FORMAT_XBGR DRM_FORMAT_XRGB2101010 DRM_FORMAT_ARGB2101010 v10: * move and simplify the functions from the drm

[PATCH v10 2/9] drm/panic: Add a drm panic handler

2024-03-15 Thread Jocelyn Falempe
This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis)

[PATCH v10 1/9] drm/panic: Add drm panic locking

2024-03-15 Thread Jocelyn Falempe
From: Daniel Vetter Rough sketch for the locking of drm panic printing code. The upshot of this approach is that we can pretty much entirely rely on the atomic commit flow, with the pair of raw_spin_lock/unlock providing any barriers we need, without having to create really big critical sections

[PATCH v10 0/9] drm/panic: Add a drm panic handler

2024-03-15 Thread Jocelyn Falempe
This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT/fbcon in the kernel: https://www.reddit.com/r/linux/comments/10eccv9/config_vtn_in_2023/ Fbcon

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Alexandre Mergnat
On 15/03/2024 15:30, Mark Brown wrote: On Fri, Mar 15, 2024 at 12:01:12PM +0100, Alexandre Mergnat wrote: On 13/03/2024 18:23, Mark Brown wrote: On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: Actually you must save the values because the gain selected by the user will

Re: [PATCH 05/10] drivers: use new capable_any functionality

2024-03-15 Thread Felix Kuehling
On 2024-03-15 7:37, Christian Göttsche wrote: Use the new added capable_any function in appropriate cases, where a task is required to have any of two capabilities. Reorder CAP_SYS_ADMIN last. Signed-off-by: Christian Göttsche Acked-by: Alexander Gordeev (s390 portion) Acked-by: Felix

[PATCH 0/2] drm: Add DRM managed workqueues

2024-03-15 Thread Jeffrey Hugo
Based on work at https://lore.kernel.org/dri-devel/20230118032413.6496-1-jiash...@iscas.ac.cn/ The API in the origional work seemed to have two issues: 1. The output parameter was not correctly defined 2. The allocating functions did not return the allocated object like the other drmm functions

[PATCH 2/2] accel/qaic: Use drmm_alloc_workqueue()

2024-03-15 Thread Jeffrey Hugo
Now that drmm_alloc_workqueue() exists, we can stop open coding our own implementation. Signed-off-by: Jeffrey Hugo Reviewed-by: Carl Vanderlip Reviewed-by: Pranjal Ramajor Asha Kanojiya --- drivers/accel/qaic/qaic_drv.c | 30 -- 1 file changed, 4 insertions(+), 26

[PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2024-03-15 Thread Jeffrey Hugo
From: Jiasheng Jiang Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers that provide managed workqueue cleanup. The workqueue will be destroyed with the final reference of the DRM device. Signed-off-by: Jiasheng Jiang Reviewed-by: Daniel Vetter [jhugo: fix API to

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-03-15 Thread Mark Brown
On Tue, Mar 12, 2024 at 09:58:05AM +0100, Alexandre Mergnat wrote: > I'm a bit lost for mixer-test and pcm-test. > Currently, I cross-compile the alsa lib project to be able to build the > tests and put it on my board. > I can execute it, but I still have 2 issues: > 1) I've a lot of missing

Re: [PATCH] drm/sched: fix null-ptr-deref in init entity

2024-03-15 Thread Christian König
Am 15.03.24 um 15:12 schrieb Alex Deucher: On Fri, Mar 15, 2024 at 10:12 AM Christian König wrote: Am 15.03.24 um 03:39 schrieb vitaly.pros...@amd.com: From: Vitaly Prosyak The bug can be triggered by sending an amdgpu_cs_wait_ioctl to the AMDGPU DRM driver on any ASICs with valid context.

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 12:01:12PM +0100, Alexandre Mergnat wrote: > On 13/03/2024 18:23, Mark Brown wrote: > > On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > > > Actually you must save the values because the gain selected by the user > > > will > > > be override to do a

Re: [PATCH] drm/sched: fix null-ptr-deref in init entity

2024-03-15 Thread Alex Deucher
On Fri, Mar 15, 2024 at 10:12 AM Christian König wrote: > > Am 15.03.24 um 03:39 schrieb vitaly.pros...@amd.com: > > From: Vitaly Prosyak > > > > The bug can be triggered by sending an amdgpu_cs_wait_ioctl > > to the AMDGPU DRM driver on any ASICs with valid context. > > The bug was reported by

Re: [PATCH] drm/sched: fix null-ptr-deref in init entity

2024-03-15 Thread Christian König
Am 15.03.24 um 03:39 schrieb vitaly.pros...@amd.com: From: Vitaly Prosyak The bug can be triggered by sending an amdgpu_cs_wait_ioctl to the AMDGPU DRM driver on any ASICs with valid context. The bug was reported by Joonkyo Jung . For example the following code: static void

Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Khatri, Sunil
On 3/15/2024 6:45 PM, Alex Deucher wrote: On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote: Add all the IP's version information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri This looks great. Reviewed-by: Alex Deucher Thanks Alex ---

Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Alex Deucher
On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote: > > Add all the IP's version information on a SOC to the > devcoredump. > > Signed-off-by: Sunil Khatri This looks great. Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++ > 1 file

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-03-15 Thread Maxime Ripard
On Sun, 10 Mar 2024 14:21:11 +0100, Frank Oltmanns wrote: > The Allwinner SoC's typically have an upper and lower limit for their > clocks' rates. Up until now, support for that has been implemented > separately for each clock type. > > Implement that functionality in the sunxi-ng's common part

Re: [PATCH] drm/atmel-hlcdc: Release CRTC commit when destroying plane state

2024-03-15 Thread Pierre-Louis Dourneau
On 3/12/24, Pierre-Louis Dourneau wrote: > On 3/8/24, ludovic.desroc...@microchip.com > wrote: > > This patch fixes the memory leak but introduces a crash on my side when > > exiting a graphics app using the Microchip graphics library. > > We've tried to reproduce your crash with

RE: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Khatri, Sunil
[AMD Official Use Only - General] Hello Alex Added the information directly from the ip_version and also added names for each ip so the version information makes more sense to the user. Below is the output in devcoredump now: IP Information SOC Family: 143 SOC Revision id: 0 SOC External

[PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Sunil Khatri
Add all the IP's version information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c

Re: [PATCH v4 09/11] drm/ci: rockchip: Refactor existing rockchip jobs

2024-03-15 Thread Helen Koike
On 15/03/2024 08:18, Vignesh Raman wrote: Hi Helen, On 07/03/24 19:32, Helen Koike wrote: On 06/03/2024 00:06, Vignesh Raman wrote: For rockchip rk3288 and rk3399, the display driver is rockchip. Currently, in drm-ci for rockchip, only the display driver is tested. Refactor the existing

Re: [PATCH v4 03/11] drm/ci: uprev IGT and update testlist

2024-03-15 Thread Helen Koike
On 15/03/2024 08:12, Vignesh Raman wrote: Hi Helen, On 07/03/24 19:05, Helen Koike wrote: On 06/03/2024 00:06, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific

[PATCH RFC v3 08/12] drm/msm: import gen_header.py script from Mesa

2024-03-15 Thread Dmitry Baryshkov
Import the gen_headers.py script from Mesa, commit FIXME. This script will be used to generate MSM register files on the fly during compilation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/gen_header.py | 958 1 file changed, 958 insertions(+)

[PATCH RFC v3 09/12] drm/msm: generate headers on the fly

2024-03-15 Thread Dmitry Baryshkov
Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual synchronization step. Existing headers will be removed in the following commits (split away to ease reviews). Signed-off-by: Dmitry Baryshkov ---

[PATCH RFC v3 03/12] drm/msm/dsi: drop mmss_cc.xml.h

2024-03-15 Thread Dmitry Baryshkov
The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/mmss_cc.xml.h | 131

[PATCH RFC v3 02/12] drm/msm/hdmi: drop qfprom.xml.h

2024-03-15 Thread Dmitry Baryshkov
The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61

[PATCH RFC v3 04/12] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-15 Thread Dmitry Baryshkov
The msm_gpummu.c implementation is used only on A2xx and it is tied to the A2xx registers. Rename the source file accordingly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 +-

[PATCH RFC v3 01/12] drm/msm/mdp5: add writeback block bases

2024-03-15 Thread Dmitry Baryshkov
In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++ 1 file

[PATCH RFC v3 00/12] drm/msm: generate register header files

2024-03-15 Thread Dmitry Baryshkov
Baryshkov --- Changes in v3: - Split XML and git rm patches in hope to pass ML limitations - Link to v2: https://lore.kernel.org/r/20240315-fd-xml-shipped-v2-0-7cd68ecc4...@linaro.org Changes in v2: - Removed the _shipped files, always generating the headers (Masahiro Yamada) - Replaced headergen2

Re: [PATCH 10/14] parisc: Add support for suppressing warning backtraces

2024-03-15 Thread Helge Deller
On 3/12/24 18:03, Guenter Roeck wrote: Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both

Re: [PATCH v4 03/11] drm/ci: uprev IGT and update testlist

2024-03-15 Thread Dmitry Baryshkov
On Wed, 6 Mar 2024 at 05:08, Vignesh Raman wrote: > > Uprev IGT and add amd, v3d, vc4 and vgem specific > tests to testlist. Have testlist.txt per driver > and include a base testlist so that the driver > specific tests will run only on those hardware. > Also add testlists to the MAINTAINERS

Re: [PATCH] gpu: host1x: Do not setup DMA for virtual devices

2024-03-15 Thread Jon Hunter
On 14/03/2024 15:49, Thierry Reding wrote: From: Thierry Reding The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up DMA masks for the virtual devices, but we currently

Re: [PATCH v4 00/11] drm/ci: Add support for GPU and display testing

2024-03-15 Thread Vignesh Raman
Hi Helen, On 07/03/24 19:32, Helen Koike wrote: On 06/03/2024 00:06, Vignesh Raman wrote: Some ARM SOCs have a separate display controller and GPU, each with different drivers. For mediatek mt8173, the GPU driver is powervr, and the display driver is mediatek. In the case of mediatek mt8183,

Re: [PATCH v4 09/11] drm/ci: rockchip: Refactor existing rockchip jobs

2024-03-15 Thread Vignesh Raman
Hi Helen, On 07/03/24 19:32, Helen Koike wrote: On 06/03/2024 00:06, Vignesh Raman wrote: For rockchip rk3288 and rk3399, the display driver is rockchip. Currently, in drm-ci for rockchip, only the display driver is tested. Refactor the existing rockchip jobs so that gpu driver testing jobs

Re: [PATCH v4 05/11] drm/ci: mediatek: Refactor existing mediatek jobs

2024-03-15 Thread Vignesh Raman
Hi Helen, On 07/03/24 19:32, Helen Koike wrote: On 06/03/2024 00:06, Vignesh Raman wrote: For mediatek mt8173 and mt8183, the display driver is mediatek. Currently, in drm-ci for mediatek, only the display driver is tested. Refactor the existing mediatek jobs so that gpu driver testing jobs

Re: [PATCH v4 03/11] drm/ci: uprev IGT and update testlist

2024-03-15 Thread Vignesh Raman
Hi Helen, On 07/03/24 19:05, Helen Koike wrote: On 06/03/2024 00:06, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run only on those hardware. Also add

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Alexandre Mergnat
On 13/03/2024 18:23, Mark Brown wrote: On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: On 26/02/2024 17:09, Mark Brown wrote: + case MT6357_ZCD_CON2: + regmap_read(priv->regmap, MT6357_ZCD_CON2, ); + priv->ana_gain[ANALOG_VOLUME_HPOUTL]

Re: [PATCH] drm/tests: Build KMS helpers when DRM_KUNIT_TEST_HELPERS is enabled

2024-03-15 Thread Maxime Ripard
On Wed, 13 Mar 2024 15:21:42 +0100, Karolina Stolarek wrote: > Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers") > introduced a dependency on CRTC helpers in KUnit test helpers. > Select the former when building KUnit test helpers to avoid > linker errors. > > Applied to

Re: [PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-15 Thread Helge Deller
You should have marked this patch with "v2"... On 3/13/24 17:59, Samuel Thibault wrote: This remains relatively simple by just enlarging integers. I like the patch, but I still see some u32... drivers/video/fbdev/vt8623fb.c: info->pixmap.blit_x = (bpp == 4) ? (1 << (8 - 1)) :

Re: Time for drm-ci-next?

2024-03-15 Thread Jani Nikula
On Thu, 14 Mar 2024, Rob Clark wrote: > When we first merged drm/ci I was unsure if it would need it's own > -next branch. But after using it for a couple releases, a few times > I've found myself wanting to backmerge drm/ci changes without > necessarily backmerging all of drm-misc-next. > > So,

Re: [PATCH] mediatek: dsi: Correct calculation formula of PHY Timing

2024-03-15 Thread AngeloGioacchino Del Regno
Il 15/03/24 08:29, Shuijing Li ha scritto: This patch correct calculation formula of PHY timing. Make actual phy timing more accurate. More accurate in which cases? By how much? On which SoC(s)? I agree about those changes if those are improving the PHY timing, but can you please document

[PATCH][next] drm/nouveau/gr/gf100: Remove second semicolon

2024-03-15 Thread Colin Ian King
There is a statement with two semicolons. Remove the second one, it is redundant. Signed-off-by: Colin Ian King --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c

Re: [PATCH] fbdev/mb862xxfb: Fix defined but not used error

2024-03-15 Thread Helge Deller
On 2/29/24 12:50, Michael Ellerman wrote: socrates_gc_mode is defined at the top-level but then only used inside an #ifdef CONFIG_FB_MB862XX_LIME, leading to an error with some configs: drivers/video/fbdev/mb862xx/mb862xxfbdrv.c:36:31: error: ‘socrates_gc_mode’ defined but not used 36

Re: [PATCH v2] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-15 Thread Helge Deller
On 3/5/24 14:51, Roman Smirnov wrote: The expression htotal * vtotal can have a zero value on overflow. I'm not sure if thos always results in zero in kernel on overflow. Might be architecture-depended too, but let's assume it can become zero, It is necessary to prevent division by zero

Re: [PATCH v2] fbdev: uvesafb: Convert sprintf/snprintf to sysfs_emit

2024-03-15 Thread Helge Deller
On 3/14/24 10:58, Li Zhijian wrote: Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit().

[PATCH v1 1/1] drm/mediatek/ dp: Adjust bandwidth limit for DP

2024-03-15 Thread Liankun Yang
By adjusting the order of link training and relocating it to HPD, link training can identify the usability of each lane in the current link. It also supports handling signal instability and weakness due to environmental issues, enabling the acquisition of a stable bandwidth for the current link.

Re: [PATCH v9 20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-15 Thread Ville Syrjälä
On Mon, Mar 11, 2024 at 03:49:48PM +0100, Maxime Ripard wrote: > Infoframes in KMS is usually handled by a bunch of low-level helpers > that require quite some boilerplate for drivers. This leads to > discrepancies with how drivers generate them, and which are actually > sent. > > Now that we

[drm-misc:topic/rust-drm 5/18] warning: unresolved link to `RawDeviceId::to_rawid`

2024-03-15 Thread kernel test robot
.01.org/0day-ci/archive/20240315/202403151651.nhmv8q3a-...@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240315/202403151651.nhmv8q3a

Re: [PATCH v9 14/27] drm/connector: hdmi: Compute bpc and format automatically

2024-03-15 Thread Ville Syrjälä
On Mon, Mar 11, 2024 at 03:49:42PM +0100, Maxime Ripard wrote: > Now that we have all the infrastructure needed, we can add some code > that will, for a given connector state and mode, compute the best output > format and bpc. > > The algorithm is equivalent to the one already found in i915 and

[PATCH] mediatek: dsi: Correct calculation formula of PHY Timing

2024-03-15 Thread Shuijing Li
This patch correct calculation formula of PHY timing. Make actual phy timing more accurate. Signed-off-by: Shuijing Li --- drivers/gpu/drm/mediatek/mtk_dsi.c | 33 +++--- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c