Re: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Bhardwaj, Rajneesh
On 3/22/2024 11:29 AM, Ruhl, Michael J wrote: -Original Message- From: dri-devel On Behalf Of Rajneesh Bhardwaj Sent: Friday, March 22, 2024 3:08 AM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: felix.kuehl...@amd.com; alexander.deuc...@amd.com;

Re: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Bhardwaj, Rajneesh
On 3/22/2024 9:15 AM, Christian König wrote: Am 22.03.24 um 08:07 schrieb Rajneesh Bhardwaj: This change allows TTM to be flexible to honor NUMA localized allocations which can result in significant performance improvement on a multi socket NUMA system. On GFXIP 9.4.3 based AMD APUs, we see

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-22 Thread Jakub Kicinski
On Fri, 22 Mar 2024 10:40:26 -0700 Mina Almasry wrote: > Other designs for this hugepage use case are possible, I'm just > describing Jakub's idea for it as a potential use-case for these > hooks. I made it ops because I had 4 different implementations with different recycling algorithms. I

[PATCH v4 15/16] drm/msm: drop A6xx GMU header

2024-03-22 Thread Dmitry Baryshkov
Now as the headers are generated during the build step, drop pre-generated copies of the Adreno A6xx GMU header. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h | 422 -- 1 file changed, 422 deletions(-) diff --git

[PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-22 Thread Dmitry Baryshkov
Import the gen_headers.py script from Mesa, commit FIXME. This script will be used to generate MSM register files on the fly during compilation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/gen_header.py | 957 1 file changed, 957 insertions(+)

[PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-22 Thread Dmitry Baryshkov
Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual synchronization step. Existing headers will be removed in the following commits (split away to ease reviews). Signed-off-by: Dmitry Baryshkov ---

[PATCH v4 03/16] drm/msm/dsi: drop mmss_cc.xml.h

2024-03-22 Thread Dmitry Baryshkov
The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/mmss_cc.xml.h | 131

[PATCH v4 04/16] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-22 Thread Dmitry Baryshkov
The msm_gpummu.c implementation is used only on A2xx and it is tied to the A2xx registers. Rename the source file accordingly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 +-

[PATCH v4 02/16] drm/msm/hdmi: drop qfprom.xml.h

2024-03-22 Thread Dmitry Baryshkov
The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61

[PATCH v4 01/16] drm/msm/mdp5: add writeback block bases

2024-03-22 Thread Dmitry Baryshkov
In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++ 1 file

[PATCH v4 00/16] drm/msm: generate register header files

2024-03-22 Thread Dmitry Baryshkov
Currently display-related register headers are generated from XML files shipped withing Mesa source tree. This is not fully optimal: it requires multi-stage process of the changes first being landed to Mesa and only then synced to the kernel tree. Move original XML files to the kernel tree and

[PATCH 4/4] WIP: rust/drm/kms: Add ShadowPlaneState

2024-03-22 Thread Lyude Paul
Signed-off-by: Lyude Paul --- drivers/gpu/drm/rvkms/plane.rs | 7 +++- rust/bindings/bindings_helper.h | 2 + rust/kernel/drm/kms.rs | 1 + rust/kernel/drm/kms/gem_atomic_helper.rs | 48 4 files changed, 56 insertions(+), 2

[PATCH 3/4] rust/drm/kms: Extract PlaneState into IntoPlaneState

2024-03-22 Thread Lyude Paul
DRM actually has a number of helpers that wrap drm_plane_state, one of which is actually needed by VKMS - drm_shadow_plane_state. So, let's start preparing to write bindings for this by first extracting PlaneState into the IntoPlaneState trait - which all DRM structs which wrap drm_plane_state

[PATCH 2/4] WIP: drm: Introduce rvkms

2024-03-22 Thread Lyude Paul
This introduces a work in progress port of the VKMS driver to rust to provide a user of the kernel's new rust bindings for KMS drivers! This driver is very incomplete, I'm not even sure if it loads right now without crashing (but it did at one point, and I'll be checking very soon!). Squash into

[PATCH 1/4] WIP: rust: Add basic KMS bindings

2024-03-22 Thread Lyude Paul
Signed-off-by: Lyude Paul --- rust/bindings/bindings_helper.h | 4 + rust/helpers.c | 17 ++ rust/kernel/drm/device.rs| 2 + rust/kernel/drm/drv.rs | 115 +++-- rust/kernel/drm/kms.rs | 146 +++ rust/kernel/drm/kms/connector.rs |

[RFC WIP 0/4] Rust bindings for KMS + RVKMS

2024-03-22 Thread Lyude Paul
Hi everyone! I mentioned a little while ago that I've been working on porting vkms over to rust so that we could come up with a set of rust KMS bindings for the nova driver to be able to have a modesetting driver written in rust. This driver currently doesn't really do much, but it does load and

[PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-22 Thread Rob Clark
From: Rob Clark virtgpu "vram" GEM objects do not implement obj->get_sg_table(). But they also don't use drm_gem_map_dma_buf(). In fact they may not even have guest visible pages. But it is perfectly fine to export and share with other virtual devices. Reported-by: Dominik Behr Fixes:

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-22 Thread Sean Anderson
On 3/22/24 14:09, Tomi Valkeinen wrote: > On 22/03/2024 18:18, Sean Anderson wrote: >> On 3/22/24 01:32, Tomi Valkeinen wrote: >>> On 21/03/2024 21:17, Sean Anderson wrote: On 3/21/24 15:08, Tomi Valkeinen wrote: > On 21/03/2024 20:01, Sean Anderson wrote: >> On 3/21/24 13:25, Tomi

Re: [PATCH] drm/i915/hwmon: Fix potential UAF on driver unbind

2024-03-22 Thread Ville Syrjälä
On Fri, Mar 22, 2024 at 07:54:03PM +0100, Janusz Krzysztofik wrote: > Hwmon is registered as a managed resource of i915. Its functionality > depends of availability of i915 uncore. Instead of polluting all code with this junk I think either fixing the devm stuff, or just getting rid of it if

RE: [PATCH v3 7/9] drm/atomic-helper: Add select_output_bus_format callback

2024-03-22 Thread Klymenko, Anatoliy
Hi Maxime, Thank you for the review. > -Original Message- > From: Maxime Ripard > Sent: Friday, March 22, 2024 2:45 AM > To: Klymenko, Anatoliy > Cc: Laurent Pinchart ; Maarten Lankhorst > ; Thomas Zimmermann > ; David Airlie ; Daniel Vetter > ; Simek, Michal ; Andrzej Hajda > ; Neil

RE: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-22 Thread Klymenko, Anatoliy
Hi Krzysztof, Thanks a lot for the review. > -Original Message- > From: Krzysztof Kozlowski > Sent: Thursday, March 21, 2024 10:59 PM > To: Klymenko, Anatoliy ; Laurent Pinchart > ; Maarten Lankhorst > ; Maxime Ripard ; > Thomas Zimmermann ; David Airlie > ; Daniel Vetter ; Simek,

[PATCH v2 0/2] drm: Add DRM managed workqueues

2024-03-22 Thread Jeffrey Hugo
Based on work at https://lore.kernel.org/dri-devel/20230118032413.6496-1-jiash...@iscas.ac.cn/ The API in the origional work seemed to have two issues: 1. The output parameter was not correctly defined 2. The allocating functions did not return the allocated object like the other drmm functions

[PATCH v2 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2024-03-22 Thread Jeffrey Hugo
From: Jiasheng Jiang Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers that provide managed workqueue cleanup. The workqueue will be destroyed with the final reference of the DRM device. Signed-off-by: Jiasheng Jiang Reviewed-by: Daniel Vetter [jhugo: fix API to

[PATCH v2 2/2] accel/qaic: Use drmm_alloc_workqueue()

2024-03-22 Thread Jeffrey Hugo
Now that drmm_alloc_workqueue() exists, we can stop open coding our own implementation. Signed-off-by: Jeffrey Hugo Reviewed-by: Carl Vanderlip Reviewed-by: Pranjal Ramajor Asha Kanojiya --- drivers/accel/qaic/qaic_drv.c | 30 -- 1 file changed, 4 insertions(+), 26

Re: [PATCH] Fix duplicate C declaration warnings

2024-03-22 Thread Amogh
On Thu, 2024-03-21 at 17:37 +0200, Jani Nikula wrote: > Please paste the warnings here. > > BR, > Jani. > Here are the warnings I got: /home/amogh/Linux_Kernel_Workspace/linux-next/Documentation/gpu/drm- kms:360: ./drivers/gpu/drm/drm_fourcc.c:344: WARNING: Duplicate C declaration, also

[PATCH] drm/i915/hwmon: Fix potential UAF on driver unbind

2024-03-22 Thread Janusz Krzysztofik
Hwmon is registered as a managed resource of i915. Its functionality depends of availability of i915 uncore. On i915 unbind, we now block i915 access to hwmon, but leave i915 uncore still available to hwmon. Since uncore structures may be freed before hwmon is actually unregistered, that may

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/23 02:16, Andy Shevchenko wrote: On Sat, Mar 23, 2024 at 02:12:14AM +0800, Sui Jingfeng wrote: On 2024/3/23 02:05, Andy Shevchenko wrote: Besides that, the kernel project rule is "we do not add the dead (unused) code". This rule is good an correct and I admit. But the

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-22 Thread Andy Shevchenko
On Sat, Mar 23, 2024 at 02:12:14AM +0800, Sui Jingfeng wrote: > On 2024/3/23 02:05, Andy Shevchenko wrote: > > Besides that, the kernel project rule is "we do not add > > the dead (unused) code". > > This rule is good an correct and I admit. > > But the problem is that it is chicken-and-egg

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/23 02:05, Andy Shevchenko wrote: Besides that, the kernel project rule is "we do not add the dead (unused) code". This rule is good an correct and I admit. But the problem is that it is chicken-and-egg problem, it probably have at least two user now. it's possible that it

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-22 Thread Tomi Valkeinen
On 22/03/2024 18:18, Sean Anderson wrote: On 3/22/24 01:32, Tomi Valkeinen wrote: On 21/03/2024 21:17, Sean Anderson wrote: On 3/21/24 15:08, Tomi Valkeinen wrote: On 21/03/2024 20:01, Sean Anderson wrote: On 3/21/24 13:25, Tomi Valkeinen wrote: On 21/03/2024 17:52, Sean Anderson wrote: On

Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-22 Thread Conor Dooley
On Fri, Mar 22, 2024 at 06:59:18AM +0100, Krzysztof Kozlowski wrote: > On 21/03/2024 21:43, Anatoliy Klymenko wrote: > > diff --git a/include/dt-bindings/media/media-bus-format.h > > b/include/dt-bindings/media/media-bus-format.h > > new file mode 100644 > > index ..60fc6e11dabc > >

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-22 Thread Andy Shevchenko
On Sat, Mar 23, 2024 at 01:43:56AM +0800, Sui Jingfeng wrote: > On 2024/3/23 00:14, Andy Shevchenko wrote: > > On Fri, Mar 22, 2024 at 05:00:05PM +0800, Sui Jingfeng wrote: > > > On 2024/3/21 04:28, Andy Shevchenko wrote: ... > > > > > > > By replacing it with device_get_match_data() and

[PATCH v2 1/3] accel/qaic: Add bootlog debugfs

2024-03-22 Thread Jeffrey Hugo
During the boot process of AIC100, the bootloaders (PBL and SBL) log messages to device RAM. During SBL, if the host opens the QAIC_LOGGING channel, SBL will offload the contents of the log buffer to the host, and stream any new messages that SBL logs. This log of the boot process can be very

[PATCH v2 3/3] accel/qaic: Add fifo queued debugfs

2024-03-22 Thread Jeffrey Hugo
When debugging functional issues with workload input processing, it is useful to know if requests are backing up in the fifo, or perhaps getting stuck elsewhere. To answer the question of how many requests are in the fifo, implement a "queued" debugfs entry per-dbc that returns the number of

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-22 Thread Mina Almasry
On Sun, Mar 17, 2024 at 7:03 PM Christoph Hellwig wrote: > > On Mon, Mar 04, 2024 at 06:01:37PM -0800, Mina Almasry wrote: > > From: Jakub Kicinski > > > > The page providers which try to reuse the same pages will > > need to hold onto the ref, even if page gets released from > > the pool - as

[PATCH v2 2/3] accel/qaic: Add fifo size debugfs

2024-03-22 Thread Jeffrey Hugo
Each DMA Bridge Channel (dbc) has a unique configured fifo size which is specified by the userspace client of that dbc. Since the fifo is circular, it is useful to know the configured size when debugging issues. Add a per-dbc subdirectory in debugfs and in each subdirectory add a fifo_size entry

[PATCH v2 0/3] accel/qaic: Add debugfs entries

2024-03-22 Thread Jeffrey Hugo
Add 3 debugfs entries that can be useful in debugging a variety of issues. bootlog - output the device bootloader log fifo_size - output the configured dbc fifo size queued - output how many requests are queued in the dbc fifo Bootlog is unique to the device, where as fifo_size/queued is

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/23 00:14, Andy Shevchenko wrote: On Fri, Mar 22, 2024 at 05:00:05PM +0800, Sui Jingfeng wrote: On 2024/3/21 04:28, Andy Shevchenko wrote: ... By replacing it with device_get_match_data() and creating a software graph that mimics the OF graph, everything else works fine,

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-22 Thread Mina Almasry
Hi Christoph, Sorry for the late reply, I've been out for a few days. On Mon, Mar 18, 2024 at 4:22 PM Christoph Hellwig wrote: > > On Sun, Mar 17, 2024 at 07:49:43PM -0700, David Wei wrote: > > I'm working on a similar proposal for zero copy Rx but to host memory > > and depend on this memory

[PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-22 Thread Christian Hewitt
Increase the timeout value to prevent system logs on Amlogic boards flooding with power transition warnings: [ 13.047638] panfrost ffe4.gpu: shader power transition timeout [ 13.048674] panfrost ffe4.gpu: l2 power transition timeout [ 13.937324] panfrost ffe4.gpu: shader power

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-22 Thread Sean Anderson
On 3/22/24 01:32, Tomi Valkeinen wrote: > On 21/03/2024 21:17, Sean Anderson wrote: >> On 3/21/24 15:08, Tomi Valkeinen wrote: >>> On 21/03/2024 20:01, Sean Anderson wrote: On 3/21/24 13:25, Tomi Valkeinen wrote: > On 21/03/2024 17:52, Sean Anderson wrote: >> On 3/20/24 02:53, Tomi

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-22 Thread Andy Shevchenko
On Fri, Mar 22, 2024 at 05:00:05PM +0800, Sui Jingfeng wrote: > On 2024/3/21 04:28, Andy Shevchenko wrote: ... > > > > > By replacing it with device_get_match_data() and creating a software > > > > > graph that mimics the OF graph, everything else works fine, except > > > > > that > > > > >

[GIT PULL] fbdev fixes and cleanups for v6.9-rc1 (v2)

2024-03-22 Thread Helge Deller
Hi Linus, Yesterday's fbdev tree showed one small compiler warning which has been fixed in this pull request. So, please pull the latest fixes and cleanups for the fbdev drivers for kernel 6.9-rc1. Beside the typical bunch of smaller fixes, the Linux console now allows fonts up to a size of 64

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-03-22 Thread Devarsh Thakkar
Hi Maxime, On 14/03/24 20:04, Maxime Ripard wrote: > Hi, > > On Wed, Feb 14, 2024 at 09:17:12PM +0530, Devarsh Thakkar wrote: >> On 13/02/24 19:34, Maxime Ripard wrote: >>> On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote: On 26/01/24 17:45, Maxime Ripard wrote: > Hi,

RE: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Rajneesh Bhardwaj >Sent: Friday, March 22, 2024 3:08 AM >To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org >Cc: felix.kuehl...@amd.com; alexander.deuc...@amd.com; >christian.koe...@amd.com; Rajneesh Bhardwaj >; Joe

Re: [PATCH] drm/panel: replace utf multiply with an ascii x

2024-03-22 Thread Jessica Zhang
On 3/22/2024 5:03 AM, Prasad Pandit wrote: From: Prasad Pandit Replace unicode multiplication character with an ascii x. It helps Kconfig parsers to read file without error. Hi Prasad, Seems that this also happens in 2 other Kconfig entries. Can you replace those as well? Thanks,

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-22 Thread Sean Anderson
On 3/22/24 01:50, Tomi Valkeinen wrote: > On 21/03/2024 17:33, Sean Anderson wrote: >> On 3/20/24 02:05, Randy Dunlap wrote: >>> >>> >>> On 3/19/24 22:42, Tomi Valkeinen wrote: On 20/03/2024 00:51, Sean Anderson wrote: > Fix a few errors in the kerneldoc. Mostly this addresses

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Abel Vesa
On 24-03-22 09:30:21, Bjorn Andersson wrote: > On Fri, Mar 22, 2024 at 03:22:22PM +0200, Abel Vesa wrote: > > Instead of relying on different compatibles for eDP and DP, lookup > > the panel node in devicetree to figure out the connector type and > > then pass on that information to the PHY.

Re: [PATCH] accel/qaic: Add Sahara implementation for firmware loading

2024-03-22 Thread Bjorn Andersson
On Thu, Mar 21, 2024 at 09:49:17PM -0600, Jeffrey Hugo wrote: > The AIC100 secondary bootloader uses the Sahara protocol for two > purposes - loading the runtime firmware images from the host, and > offloading crashdumps to the host. The crashdump functionality is only > invoked when the AIC100

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/22 20:31, Maxime Ripard wrote: On Fri, Mar 22, 2024 at 07:13:54PM +0800, Sui Jingfeng wrote: Hi, On 2024/3/22 18:31, Maxime Ripard wrote: Which default config are you talking about? This compiles fine with all drm-misc defconfig, x86 defconfig and allmodconfig. The

[PATCH v10 8/9] drm/ttm/tests: Add TODO file

2024-03-22 Thread Karolina Stolarek
List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO

[PATCH v10 9/9] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

2024-03-22 Thread Karolina Stolarek
BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Share bo2's resv object with bo1 to fix the issue. Fixes: 995279d280d1 ("drm/ttm/tests: Add tests for ttm_bo functions") Signed-off-by: Karolina Stolarek ---

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Bjorn Andersson
On Fri, Mar 22, 2024 at 03:22:22PM +0200, Abel Vesa wrote: > Instead of relying on different compatibles for eDP and DP, lookup > the panel node in devicetree to figure out the connector type and > then pass on that information to the PHY. External DP is not described > in DT, therefore, assume

[PATCH v10 7/9] drm/ttm/tests: Add tests for ttm_tt_populate

2024-03-22 Thread Karolina Stolarek
Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 119

[PATCH v10 4/9] drm/ttm/tests: Add tests with mock resource managers

2024-03-22 Thread Karolina Stolarek
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig

[PATCH v10 6/9] drm/ttm/tests: Add eviction testing

2024-03-22 Thread Karolina Stolarek
Add tests for ttm_bo_validate that focus on BO eviction and swapout. Update device funcs definition with eviction-related callbacks. Add alternative funcs where evict_flags() routes eviction to a domain that can't allocate resources (dubbed "busy manager" in the tests). Extract the common path of

[PATCH v10 2/9] drm/ttm/tests: Use an init function from the helpers lib

2024-03-22 Thread Karolina Stolarek
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 +

[PATCH v10 5/9] drm/ttm/tests: Add test cases dependent on fence signaling

2024-03-22 Thread Karolina Stolarek
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 305 ++ 1 file

[PATCH v10 3/9] drm/ttm/tests: Test simple BO creation and validation

2024-03-22 Thread Karolina Stolarek
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek ---

[PATCH v10 1/9] drm/ttm/tests: Set DMA mask in KUnit device

2024-03-22 Thread Karolina Stolarek
In commit d393acce7b3f ("drm/tests: Switch to kunit devices"), DRM test helpers migrated away from using a dummy platform driver in favour of KUnit device. This means that DMA masks for the device are not set but are required by ttm_pool_alloc tests. Set the DMA mask for coherent mappings to

[PATCH v10 0/9] Improve test coverage of TTM

2024-03-22 Thread Karolina Stolarek
Introduce tests for ttm_bo_validate()/ttm_bo_init_validate() that exercise simple BO placement as well as eviction (including the case where the evict domain also requires eviction to fit the incoming buffer). Prepare KUnit helpers to handle such scenarios and add a mock VRAM manager. This series

Re: [PATCH v5 12/13] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-22 Thread Maxime Ripard
On Fri, Mar 22, 2024 at 07:40:52AM +0100, Thomas Zimmermann wrote: > Hi > > Am 21.03.24 um 15:09 schrieb Maxime Ripard: > > Hi, > > > > On Wed, Mar 20, 2024 at 10:34:17AM +0100, Thomas Zimmermann wrote: > > > +/** > > > + * drm_connector_helper_detect_ctx - Read EDID and detect connector > > >

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Johan Hovold
On Fri, Mar 22, 2024 at 04:15:23PM +0200, Abel Vesa wrote: > On 24-03-22 15:38:03, Dmitry Baryshkov wrote: > > On Fri, 22 Mar 2024 at 15:36, Abel Vesa wrote: > > > On 24-03-22 15:30:54, Dmitry Baryshkov wrote: > > > > On Fri, 22 Mar 2024 at 15:22, Abel Vesa wrote: > > > > > +static int

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Abel Vesa
On 24-03-22 15:38:03, Dmitry Baryshkov wrote: > On Fri, 22 Mar 2024 at 15:36, Abel Vesa wrote: > > > > On 24-03-22 15:30:54, Dmitry Baryshkov wrote: > > > On Fri, 22 Mar 2024 at 15:22, Abel Vesa wrote: > > > > > > > > Instead of relying on different compatibles for eDP and DP, lookup > > > > the

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-22 Thread Huacai Chen
On Thu, Mar 21, 2024 at 4:55 AM Jaak Ristioja wrote: > > Hi Huacai, > > On 19.03.24 16:16, Huacai Chen wrote: > > Hi, Jaak, > > > > On Mon, Mar 18, 2024 at 11:42 PM Jaak Ristioja wrote: > >> > >> Hi Huacai, > >> > >> Uh, no, sorry, I did not get to test such changes. From what Thomas > >> wrote

Re: [PATCH v2] backlight: lp8788: Drop support for platform data

2024-03-22 Thread Daniel Thompson
On Thu, Mar 14, 2024 at 12:35:28PM +0100, Uwe Kleine-König wrote: > The backlight driver supports getting passed platform data. However this > isn't used. This allows to remove quite some dead code from the driver > because bl->pdata is always NULL, and so bl->mode is always >

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Dmitry Baryshkov
On Fri, 22 Mar 2024 at 15:36, Abel Vesa wrote: > > On 24-03-22 15:30:54, Dmitry Baryshkov wrote: > > On Fri, 22 Mar 2024 at 15:22, Abel Vesa wrote: > > > > > > Instead of relying on different compatibles for eDP and DP, lookup > > > the panel node in devicetree to figure out the connector type

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Abel Vesa
On 24-03-22 15:30:54, Dmitry Baryshkov wrote: > On Fri, 22 Mar 2024 at 15:22, Abel Vesa wrote: > > > > Instead of relying on different compatibles for eDP and DP, lookup > > the panel node in devicetree to figure out the connector type and > > then pass on that information to the PHY. External DP

Re: [PATCH v3 2/2] drm/msm/dp: Add support for the X1E80100

2024-03-22 Thread Dmitry Baryshkov
On Fri, 22 Mar 2024 at 15:22, Abel Vesa wrote: > > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set based on the presence of the panel node in DT. > > Signed-off-by: Abel Vesa Reviewed-by: Dmitry

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Dmitry Baryshkov
On Fri, 22 Mar 2024 at 15:22, Abel Vesa wrote: > > Instead of relying on different compatibles for eDP and DP, lookup > the panel node in devicetree to figure out the connector type and > then pass on that information to the PHY. External DP is not described Nit: External DP doesn't have a panel

[PATCH v3 2/2] drm/msm/dp: Add support for the X1E80100

2024-03-22 Thread Abel Vesa
Add the X1E80100 DP descs and compatible. This platform will be using a single compatible for both eDP and DP mode. The actual mode will be set based on the presence of the panel node in DT. Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + 1 file changed, 9

[PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Abel Vesa
Instead of relying on different compatibles for eDP and DP, lookup the panel node in devicetree to figure out the connector type and then pass on that information to the PHY. External DP is not described in DT, therefore, assume it's eDP if panel node is present. Signed-off-by: Abel Vesa ---

[PATCH v3 0/2] drm/msm/dp: Rework the eDP/DP modes and add support for X1E80100

2024-03-22 Thread Abel Vesa
Since this new platform supports both DP and eDP, it's the perfect time to drop the dual compatible (eDP and DP) and figure out a different way to specify the mode. After some off-list discussion, one suggested way was to add a 'is-edp' property to the controller node, but that approach has been

Re: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Christian König
Am 22.03.24 um 08:07 schrieb Rajneesh Bhardwaj: This change allows TTM to be flexible to honor NUMA localized allocations which can result in significant performance improvement on a multi socket NUMA system. On GFXIP 9.4.3 based AMD APUs, we see manyfold benefits of this change resulting not

[PATCH] [RESEND] drm/imagination: avoid -Woverflow warning

2024-03-22 Thread Arnd Bergmann
From: Arnd Bergmann The array size calculation in pvr_vm_mips_fini() appears to be incorrect based on taking the size of the pointer rather than the size of the array, which manifests as a warning about signed integer overflow: In file included from include/linux/kernel.h:16,

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Maxime Ripard
On Fri, Mar 22, 2024 at 07:13:54PM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/3/22 18:31, Maxime Ripard wrote: > > Which default config are you talking about? This compiles fine with all > > drm-misc defconfig, x86 defconfig and allmodconfig. > > The drm_hdmi_avi_infoframe_colorimetry()

[PATCH] drm/panel: replace utf multiply with an ascii x

2024-03-22 Thread Prasad Pandit
From: Prasad Pandit Replace unicode multiplication character with an ascii x. It helps Kconfig parsers to read file without error. Fixes: 25205087df1f ("drm/panel: Add driver for JDI LPM102A188A") Signed-off-by: Prasad Pandit --- drivers/gpu/drm/panel/Kconfig | 2 +- 1 file changed, 1

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Jani Nikula
On Fri, 22 Mar 2024, Maxime Ripard wrote: > On Fri, Mar 22, 2024 at 11:22:14AM +0200, Jani Nikula wrote: >> On Fri, 22 Mar 2024, Sui Jingfeng wrote: >> > Hi, >> > >> > >> > On 2024/3/21 23:29, Maxime Ripard wrote: >> >> Infoframes in KMS is usually handled by a bunch of low-level helpers >> >>

Re: [next] drm/gma500: Fix spelling mistake "patter" -> "pattern"

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/15 00:35, Colin Ian King wrote: There is a spelling mistake in a DRM_DEBUG_KMS message. Fix it. Signed-off-by: Colin Ian King Reviewed-by:Sui Jingfeng -- Best regards, Sui

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/22 17:22, Jani Nikula wrote: On Fri, 22 Mar 2024, Sui Jingfeng wrote: Hi, On 2024/3/21 23:29, Maxime Ripard wrote: Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/22 18:31, Maxime Ripard wrote: Which default config are you talking about? This compiles fine with all drm-misc defconfig, x86 defconfig and allmodconfig. The drm_hdmi_avi_infoframe_colorimetry() function is belong to the drm_display_helper.ko kernel module, it get called from

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Maxime Ripard
On Fri, Mar 22, 2024 at 11:22:14AM +0200, Jani Nikula wrote: > On Fri, 22 Mar 2024, Sui Jingfeng wrote: > > Hi, > > > > > > On 2024/3/21 23:29, Maxime Ripard wrote: > >> Infoframes in KMS is usually handled by a bunch of low-level helpers > >> that require quite some boilerplate for drivers. This

Re: [PATCH v4 03/14] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane"

2024-03-22 Thread Shawn Sung
Hi Angelo, On Fri, Mar 22, 2024 at 4:46 PM AngeloGioacchino Del Regno < angelogioacchino.delre...@collabora.com> wrote: > Il 22/03/24 02:27, Shawn Sung ha scritto: > > From: Hsiao Chien Sung > > > > Rename all "mtk_drm_plane" to "mtk_plane": > > - To align the naming rule > > - To reduce the

[PATCH] drm/stm: dsi: relax mode_valid clock tolerance

2024-03-22 Thread Sean Nyekjaer
When using the DSI interface via DSI2LVDS bridge, it seems a bit harsh to reguire the requested and the actual px clock to be within 50Hz. A typical LVDS display requires the px clock to be within +-10%. In case for HDMI .5% tolerance is required. Fixes: e01356d18273 ("drm/stm: dsi: provide the

Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

2024-03-22 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Framebuffer I/O on the Sparc Sbus requires read/write helpers for > I/O memory. Select FB_IOMEM_FOPS accordingly. > > Reported-by: Nick Bowler > Closes: > https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4fae...@draconx.ca/ > Signed-off-by: Thomas

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Maxime Ripard
Hi, On Fri, Mar 22, 2024 at 05:53:07AM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/3/21 23:29, Maxime Ripard wrote: > > Infoframes in KMS is usually handled by a bunch of low-level helpers > > that require quite some boilerplate for drivers. This leads to > > discrepancies with how drivers

Re: STM32 DSI controller driver: mode_valid clock tolerance

2024-03-22 Thread Maxime Ripard
On Thu, Mar 21, 2024 at 09:47:18AM +0100, Sean Nyekjaer wrote: > >> If HDMI is requiring a tolerance of 50 Hz, would it be better to do > >> the check in the HDMI bridge driver? > > > > Judging from the code, it would be hard to do because the clock that > > generates the pixel clock isn't

Re: [PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank

2024-03-22 Thread Greg KH
On Tue, Mar 19, 2024 at 10:37:24AM +0100, Thomas Zimmermann wrote: > The field fb_blank in struct backlight_properties is deprecated and > should not be used. Don't output its value in the driver's debug print. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Dan Carpenter Acked-by: Greg

Re: [PATCH v3 7/9] drm/atomic-helper: Add select_output_bus_format callback

2024-03-22 Thread Maxime Ripard
On Thu, Mar 21, 2024 at 01:43:45PM -0700, Anatoliy Klymenko wrote: > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 2dafc39a27cb..f2e12a3c4e5f 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -1055,3

Re: [PATCH v6 07/14] drm/mediatek: Support alpha blending in display driver

2024-03-22 Thread 胡俊光

Re: [PATCH v6 10/14] drm/mediatek: Support "None" alpha blending in OVL

2024-03-22 Thread 胡俊光

Re: [PATCH v6 09/14] drm/mediatek: Support "Pre-multiplied" alpha blending in Mixer

2024-03-22 Thread 胡俊光

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Jani Nikula
On Fri, 22 Mar 2024, Sui Jingfeng wrote: > Hi, > > > On 2024/3/21 23:29, Maxime Ripard wrote: >> Infoframes in KMS is usually handled by a bunch of low-level helpers >> that require quite some boilerplate for drivers. This leads to >> discrepancies with how drivers generate them, and which are

[PATCH v5 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +++-

[PATCH v5 14/14] drm/mediatek: Rename mtk_ddp_comp functions

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename functions of mtk_ddp_comp: - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 45 ++---

[PATCH v5 12/14] drm/mediatek: Rename files "mtk_drm_gem.h" to "mtk_gem.h"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.h to mtk_gem.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +-

[PATCH v5 06/14] drm/mediatek: Rename files "mtk_drm_crtc.h" to "mtk_crtc.h"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.h to mtk_crtc.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/{mtk_drm_crtc.h => mtk_crtc.h} | 0 drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +-

[PATCH v5 04/14] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_gem" to "mtk_gem": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +--

[PATCH v5 01/14] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_crtc" to "mtk_crtc" due to the following benefits: - Lower the matches when searching the native drm_crtc* codes - Reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung ---

[PATCH v5 05/14] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_hdmi" to "mtk_hdmi": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++--- 1 file changed, 7

  1   2   >