Re: [PATCH] drm/amdkfd: return negative error code in svm_ioctl()

2024-03-25 Thread Su Hui
On 2024/3/25 22:09, Philip Yang wrote: On 2024-03-25 02:31, Su Hui wrote: Good catch, ioctl should return -errno. I will apply it to drm-next. Reviewed-by: Philip Yang --- Ps: When I try to compile this file, there is a error : drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:28:10: fatal error:

linux-next: build warnings after merge of the drm-misc tree

2024-03-25 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced these warnings: include/uapi/drm/panthor_drm.h:344: warning: Function parameter or struct member 'core_features' not described in 'drm_panthor_gpu_info' include/uapi/drm/panthor_drm.h:344: warning: Function

Re: [PATCH v2 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2024-03-25 Thread Guenter Roeck
On 3/25/24 18:09, Maíra Canal wrote: On 3/25/24 16:24, Guenter Roeck wrote: Hi, On Mon, Mar 25, 2024 at 04:05:06PM -0300, Maíra Canal wrote: Hi Guenter, On 3/25/24 14:52, Guenter Roeck wrote: The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger

linux-next: build warning after merge of the drm-misc tree

2024-03-25 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: Documentation/ABI/testing/sysfs-driver-panfrost-profiling:2: ERROR: Unexpected indentation. Introduced by commit b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with

Re: [PATCH v2] Fix duplicate C declaration warnings

2024-03-25 Thread Akira Yokosawa
Hello. Let me chime in. On Mon, 25 Mar 2024 13:03:10 +0530, Amogh Cheluvaraj wrote: [...] > After further introspection of the file drivers/gpu/drm/drm_fourcc.c, I > found that the warning is caused by having the same name for both the > struct and the function as in "const struct drm_format_info

Re: [PATCH 1/2] drm/panel: Remove redundant checks in multiple panels

2024-03-25 Thread Emilio Mendoza Reyes
Hi, I'd like to first thank you for your time and for looking at my patch. On Monday, March 25, 2024 8:21:20 PM EDT Doug Anderson wrote: > Aside from the formatting issues (several lines start with an extra > "-" and there is the PGP stuff), there are a few high-level issues > here: Yeah so sorry

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-25 Thread Rob Clark
This is actually a bit concerning.. importing a host page backed buffer without guest mapping into a passthru device probably doesn't work and should be rejected earlier. I do think we should relax the restriction (either taking my patch or reverting the commit it fixes) until we work this out

Re: [PATCH v2 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2024-03-25 Thread Maíra Canal
On 3/25/24 16:24, Guenter Roeck wrote: Hi, On Mon, Mar 25, 2024 at 04:05:06PM -0300, Maíra Canal wrote: Hi Guenter, On 3/25/24 14:52, Guenter Roeck wrote: The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad

Re: [RFC PATCH net-next v6 00/15] Device Memory TCP

2024-03-25 Thread Mina Almasry
On Tue, Mar 5, 2024 at 11:38 AM Mina Almasry wrote: > > On Tue, Mar 5, 2024 at 4:54 AM Yunsheng Lin wrote: > > > > On 2024/3/5 10:01, Mina Almasry wrote: > > > > ... > > > > > > > > Perf - page-pool benchmark: > > > --- > > > > > > bench_page_pool_simple.ko tests with and

Re: [PATCH 1/2] drm/panel: Remove redundant checks in multiple panels

2024-03-25 Thread Doug Anderson
Hi, On Sat, Mar 23, 2024 at 7:05 PM Emilio Mendoza Reyes wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > From: Emilio Mendoza Reyes > > The patch ("drm/panel: Check for already prepared/enabled in drm_panel") > moved checking for (en/dis)abled and [un]prepared panels before

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-25 Thread Dominik Behr
It also fixes importing virtgpu blobs into real hardware, for instance amdgpu for DRI_PRIME rendering. On Fri, Mar 22, 2024 at 2:48 PM Rob Clark wrote: > > From: Rob Clark > > virtgpu "vram" GEM objects do not implement obj->get_sg_table(). But > they also don't use drm_gem_map_dma_buf(). In

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-25 Thread Dominik Behr
It also fixes importing virtgpu blobs into real hardware, for instance amdgpu for DRI_PRIME rendering. On Fri, Mar 22, 2024 at 2:48 PM Rob Clark wrote: > From: Rob Clark > > virtgpu "vram" GEM objects do not implement obj->get_sg_table(). But > they also don't use drm_gem_map_dma_buf(). In

Re: [PATCH 3/3] drm-panel: If drm_panel_dp_aux_backlight() fails, don't fail panel probe

2024-03-25 Thread Hsin-Yi Wang
On Mon, Mar 25, 2024 at 2:57 PM Douglas Anderson wrote: > > If we're using the AUX channel for eDP backlight and it fails to probe > for some reason, let's _not_ fail the panel probe. > > At least one case where we could fail to init the backlight is because > of a dead or physically missing

Re: [PATCH 2/3] drm/panel-edp: If we fail to powerup/get EDID, use conservative timings

2024-03-25 Thread Hsin-Yi Wang
On Mon, Mar 25, 2024 at 2:57 PM Douglas Anderson wrote: > > If at boot we fail to power up the eDP panel (most often happens if > the eDP panel never asserts HPD to us) or if we are unable to read the > EDID at bootup to figure out the panel's ID then let's use the > conservative eDP panel

Re: [PATCH 1/3] drm/panel-edp: Abstract out function to set conservative timings

2024-03-25 Thread Hsin-Yi Wang
On Mon, Mar 25, 2024 at 2:56 PM Douglas Anderson wrote: > > If we're using the generic "edp-panel" compatible string and we fail > to detect an eDP panel then we fall back to conservative timings for > powering up and powering down the panel. Abstract out the function for > setting these timings

linux-next: manual merge of the drm-misc tree with Linus' tree

2024-03-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: MAINTAINERS between commits: 35df039b26ac ("dt-bindings: gpu: Rename img,powervr to img,powervr-rogue") 796da8ca7e05 ("dt-bindings: gpu: Add PowerVR Series5 SGX GPUs") from Linus' tree and commit: 3f9ba0c01125

Re: [PATCH 4/8] media: platform: ti: use for_each_endpoint_of_node()

2024-03-25 Thread Kuninori Morimoto
Hi Dan > > We already have for_each_endpoint_of_node(), don't use > > of_graph_get_next_endpoint() directly. Replace it. > > > > Signed-off-by: Kuninori Morimoto > > --- (snip) > > - for (i = 0; ; i++) { > > + for_each_endpoint_of_node(dev->of_node, endpoint) { > > struct

Re: [PATCH] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-03-25 Thread Nirmoy Das
Hi Andi, I have too many questions :) I think the patch makes sense but need more context, see below: On 3/25/2024 2:40 PM, Andi Shyti wrote: To enable partial memory mapping of GPU virtual memory, it's necessary to introduce an offset to the object's memory (obj->mm.pages) scatterlist. This

Re: [PATCH] drm/panel-edp: Add AUO B120XAN01.0

2024-03-25 Thread Doug Anderson
Hi, On Mon, Mar 25, 2024 at 5:59 AM Pin-yen Lin wrote: > > Add support for the AUO B120XAN01.0 panel. > > Signed-off-by: Pin-yen Lin > --- > > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) Looks fine. Reviewed-by: Douglas Anderson Applied to drm-misc-next:

Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-03-25 Thread Laurent Pinchart
Hi Tommaso, On Mon, Mar 25, 2024 at 10:48:56PM +0100, Tommaso Merciai wrote: > Hi Adam, Lucas, > Thanks for this series. > > This series make HDMI work on evk. > All is working properly on my side. > > Tested on: Linux imx8mp-lpddr4-evk 6.9.0-rc1. > Hope this help. > > Tested-by: Tommaso

[PATCH 0/3] drm-panel: Don't make failures quite so fatal

2024-03-25 Thread Douglas Anderson
This patch series is born out of the observation that after several Chromebooks transitioned over to the generic "edp-panel" compatible string that we received a number of in-the-field reports of the primary graphics device for the Chromebook not coming up. The current belief is that these

[PATCH 3/3] drm-panel: If drm_panel_dp_aux_backlight() fails, don't fail panel probe

2024-03-25 Thread Douglas Anderson
If we're using the AUX channel for eDP backlight and it fails to probe for some reason, let's _not_ fail the panel probe. At least one case where we could fail to init the backlight is because of a dead or physically missing panel. As talked about in detail in the earlier patch in this series,

[PATCH 2/3] drm/panel-edp: If we fail to powerup/get EDID, use conservative timings

2024-03-25 Thread Douglas Anderson
If at boot we fail to power up the eDP panel (most often happens if the eDP panel never asserts HPD to us) or if we are unable to read the EDID at bootup to figure out the panel's ID then let's use the conservative eDP panel powerup/powerdown timings but _not_ fail the probe. It might seem

[PATCH 1/3] drm/panel-edp: Abstract out function to set conservative timings

2024-03-25 Thread Douglas Anderson
If we're using the generic "edp-panel" compatible string and we fail to detect an eDP panel then we fall back to conservative timings for powering up and powering down the panel. Abstract out the function for setting these timings so it can be used in future patches. No functional change

Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-03-25 Thread Tommaso Merciai
Hi Adam, Lucas, Thanks for this series. This series make HDMI work on evk. All is working properly on my side. Tested on: Linux imx8mp-lpddr4-evk 6.9.0-rc1. Hope this help. Tested-by: Tommaso Merciai Thanks & Regards, Tommaso On Sat, Feb 03, 2024 at 10:52:40AM -0600, Adam Ford wrote: > The

Re: [PATCH] drm/msm: Add newlines to some debug prints

2024-03-25 Thread Abhinav Kumar
On 3/25/2024 2:08 PM, Stephen Boyd wrote: These debug prints are missing newlines, leading to multiple messages being printed on one line and hard to read logs. Add newlines to have the debug prints on separate lines. The DBG macro used to add a newline, but I missed that while migrating to

Re: [PATCH] drm/msm: Add newlines to some debug prints

2024-03-25 Thread Dmitry Baryshkov
On Mon, 25 Mar 2024 at 23:08, Stephen Boyd wrote: > > These debug prints are missing newlines, leading to multiple messages > being printed on one line and hard to read logs. Add newlines to have > the debug prints on separate lines. The DBG macro used to add a newline, > but I missed that while

[PATCH] drm/msm: Add newlines to some debug prints

2024-03-25 Thread Stephen Boyd
These debug prints are missing newlines, leading to multiple messages being printed on one line and hard to read logs. Add newlines to have the debug prints on separate lines. The DBG macro used to add a newline, but I missed that while migrating to drm_dbg wrappers. Fixes: 7cb017db1896

Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

2024-03-25 Thread Thomas Zimmermann
Merged into drm-misc-fixes. Am 22.03.24 um 09:29 schrieb Thomas Zimmermann: Framebuffer I/O on the Sparc Sbus requires read/write helpers for I/O memory. Select FB_IOMEM_FOPS accordingly. Reported-by: Nick Bowler Closes:

[PATCH v6 11/13] drm/ast: Use drm_connector_helper_get_modes()

2024-03-25 Thread Thomas Zimmermann
The .get_modes() code for VGA and SIL164 connectors does not depend on either type of connector. Replace the driver code with the common helper drm_connector_helper_get_modes(). It reads EDID data via DDC and updates the connector's EDID property. Signed-off-by: Thomas Zimmermann Reviewed-by:

[PATCH v6 02/13] drm/ast: Fail probing if DDC channel could not be initialized

2024-03-25 Thread Thomas Zimmermann
Expect the hardware to provide a DDC channel. Fail probing if its initialization fails. Failing to initialize the DDC indicates a larger problem, so there's no point in continuing. v4: * give a rational in the commit message Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson

[PATCH v6 04/13] drm/ast: Allocate instance of struct ast_i2c_chan with managed helpers

2024-03-25 Thread Thomas Zimmermann
Replace kzalloc() with drmm_kzalloc() and thereby put the release of the I2C instance into a separate action. Avoids explicit error roll- back in ast_i2c_chan_create(). No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Reviewed-by: Jocelyn Falempe ---

[PATCH v6 06/13] drm/ast: Rename struct ast_i2c_chan to struct ast_ddc

2024-03-25 Thread Thomas Zimmermann
The struct struct ast_i2c_chan represents the Display Data Channel (DDC); I2C is the underlying bus. Rename the structure, the variables and the helper ast_i2c_create() to ddc-like terms. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Reviewed-by: Jocelyn

[PATCH v6 05/13] drm/ast: Move DDC code to ast_ddc.{c,h}

2024-03-25 Thread Thomas Zimmermann
Rename ast_i2c.c to ast_ddc.c and move its interface into the new header ast_ddc.h. Update all include statements as necessary and change the adapter name to 'AST DDC bus'. This avoids including I2C headers in the driver's main header file, which doesn't need them. Renaming files to _ddc

[PATCH v6 12/13] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-25 Thread Thomas Zimmermann
Implement polling for VGA and SIL164 connectors. Set the flag DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the monitor cable. Implement struct drm_connector_helper_funcs.detect_ctx for each type of connector by testing for EDID data. The helper drm_connector_helper_detect_ctx()

[PATCH v6 08/13] drm/ast: Store AST device in struct ast_ddc

2024-03-25 Thread Thomas Zimmermann
The DDC code needs the AST device. Store a pointer in struct ast_ddc and avoid internal upcasts. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_ddc.c | 10 +-

[PATCH v6 13/13] drm/ast: Automatically clean up poll helper

2024-03-25 Thread Thomas Zimmermann
Automatically clean up the conncetor-poll thread as part of the DRM device release. The new helper drmm_kms_helper_poll_init() provides a shared implementation for all drivers. v6: - fix kernel doc comment (Sui, kernel test robot) Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe

[PATCH v6 03/13] drm/ast: Remove struct ast_{vga,sil165}_connector

2024-03-25 Thread Thomas Zimmermann
Both, struct ast_vga_connector and struct ast_sil164_connector, are now wrappers around struct drm_connector. Remove them. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.h | 24 ++--

[PATCH v6 01/13] drm/ast: Include where necessary

2024-03-25 Thread Thomas Zimmermann
Include to get of_property_read_u32() in the source files that need it. Avoids the proxy include via . Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 1 + drivers/gpu/drm/ast/ast_main.c | 1 + 2 files changed, 2

[PATCH v6 09/13] drm/ast: Rename struct i2c_algo_bit_data callbacks and their parameters

2024-03-25 Thread Thomas Zimmermann
Align the names of the algo-bit helpers with ast's convention of using an ast prefix plus the struct's name plus the callback's name for such function symbols. Change the parameter names of these helpers to 'data' and 'state', as used in the declaration of struct i2c_algo_bit_data. No functional

[PATCH v6 07/13] drm/ast: Pass AST device to ast_ddc_create()

2024-03-25 Thread Thomas Zimmermann
The DDC code needs the AST device. Pass it to ast_ddc_create() and avoid an internal upcast. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_ddc.c | 3 ++-

[PATCH v6 10/13] drm/ast: Acquire I/O-register lock in DDC code

2024-03-25 Thread Thomas Zimmermann
The modeset lock protects the DDC code from concurrent modeset operations, which use the same registers. Move that code from the connector helpers into the DDC helpers .pre_xfer() and .post_xfer(). Both, .pre_xfer() and .post_xfer(), enclose the transfer of data blocks over the I2C channel in the

[PATCH v6 00/13] drm/ast: Detect connector status for VGA and SIL164

2024-03-25 Thread Thomas Zimmermann
Detect the status of the VGA or SIL164 conenctor by polling the DDC channel. Update the status at runtime and flip the BMC status as well. Patches 1 adds a missing include statement that will be required to make later patches compile. Patches 2 and 3 simplify the VGA and SIL164 connectors, such

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Add GameForce Chi

2024-03-25 Thread Conor Dooley
On Mon, Mar 25, 2024 at 08:49:58AM -0500, Chris Morgan wrote: > From: Chris Morgan > > The GameForce Chi is a handheld gaming device from GameForce powered > by the Rockchip RK3326 SoC. > > Signed-off-by: Chris Morgan Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH v2 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2024-03-25 Thread Guenter Roeck
Hi, On Mon, Mar 25, 2024 at 04:05:06PM -0300, Maíra Canal wrote: > Hi Guenter, > > On 3/25/24 14:52, Guenter Roeck wrote: > > The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests > > intentionally trigger warning backtraces by providing bad parameters to > > the tested

Re: [PATCH v2 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2024-03-25 Thread Maíra Canal
Hi Guenter, On 3/25/24 14:52, Guenter Roeck wrote: The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace.

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Miguel Ojeda
On Mon, Mar 25, 2024 at 3:25 PM Hans de Goede wrote: > > +Cc: Bentiss, Jiri Cc'ing Andy and Geert as well who recently became the maintainers/reviewers of auxdisplay, in case they are interested in these threads (one of the initial solutions discussed in a past thread a while ago was to extend

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/25/24 5:48 PM, Werner Sembach wrote: > Hi Benjamin, > > Am 25.03.24 um 16:56 schrieb Benjamin Tissoires: >> On Mar 25 2024, Hans de Goede wrote: >>> +Cc: Bentiss, Jiri >>> >>> Hi Werner, >>> >>> On 3/20/24 12:16 PM, Werner Sembach wrote: Hi Hans and the others, Am

Re: [PATCH v2 3/3] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Boris Brezillon
On Mon, 25 Mar 2024 17:24:17 + Liviu Dudau wrote: > On Mon, Mar 25, 2024 at 02:57:05PM +0100, Boris Brezillon wrote: > > panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() > > has been called, which is always the case when our panthor_xxx_unplug() > > helpers are

Re: [PATCH v2 2/3] drm/panthor: Fix ordering in _irq_suspend()

2024-03-25 Thread Boris Brezillon
On Mon, 25 Mar 2024 17:16:16 + Liviu Dudau wrote: > On Mon, Mar 25, 2024 at 02:57:04PM +0100, Boris Brezillon wrote: > > Make sure we set suspended=true last to avoid generating an irq storm > > in the unlikely case where an IRQ happens between the suspended=true > > assignment and the

Re: [RESEND PATCH] dt-bindings: display: sony,td4353-jdi: allow width-mm and height-mm

2024-03-25 Thread Krzysztof Kozlowski
On 25/03/2024 15:33, Rob Herring wrote: > On Mon, 25 Mar 2024 11:32:27 +0100, Krzysztof Kozlowski wrote: >> Allow width and height properties from panel-common.yaml, already used >> on some boards: >> >> sdm845-sony-xperia-tama-apollo.dtb: panel@0: 'height-mm', 'width-mm' do >> not match any of

[PATCH v2 09/14] loongarch: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 08/14] arm64: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 14/14] powerpc: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 11/14] s390: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 13/14] riscv: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 10/14] parisc: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 12/14] sh: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 07/14] x86: Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and

[PATCH v2 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2024-03-25 Thread Guenter Roeck
The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace. Suppress the backtraces to avoid clogging the kernel

[PATCH v2 06/14] net: kunit: Suppress lock warning noise at end of dev_addr_lists tests

2024-03-25 Thread Guenter Roeck
dev_addr_lists_test generates lock warning noise at the end of tests if lock debugging is enabled. There are two sets of warnings. WARNING: CPU: 0 PID: 689 at kernel/locking/mutex.c:923 __mutex_unlock_slowpath.constprop.0+0x13c/0x368 DEBUG_LOCKS_WARN_ON(__owner_task(owner) != __get_current())

[PATCH v2 01/14] bug/kunit: Core support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Some unit tests intentionally trigger warning backtraces by passing bad parameters to API functions. Such unit tests typically check the return value from those calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful for

[PATCH v2 04/14] kunit: Add documentation for warning backtrace suppression API

2024-03-25 Thread Guenter Roeck
Document API functions for suppressing warning backtraces. Tested-by: Linux Kernel Functional Testing Acked-by: Dan Carpenter Reviewed-by: Kees Cook Signed-off-by: Guenter Roeck --- - Rebased to v6.9-rc1 - Added Tested-by:, Acked-by:, and Reviewed-by: tags

[PATCH v2 02/14] kunit: bug: Count suppressed warning backtraces

2024-03-25 Thread Guenter Roeck
Count suppressed warning backtraces to enable code which suppresses warning backtraces to check if the expected backtrace(s) have been observed. Using atomics for the backtrace count resulted in build errors on some architectures due to include file recursion, so use a plain integer for now.

[PATCH v2 03/14] kunit: Add test cases for backtrace warning suppression

2024-03-25 Thread Guenter Roeck
Add unit tests to verify that warning backtrace suppression works. If backtrace suppression does _not_ work, the unit tests will likely trigger unsuppressed backtraces, which should actually help to get the affected architectures / platforms fixed. Tested-by: Linux Kernel Functional Testing

[PATCH v2 00/14] Add support for suppressing warning backtraces

2024-03-25 Thread Guenter Roeck
Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor

Re: [PATCH 03/12] drm/display: Make DisplayPort AUX Chardev Kconfig name consistent

2024-03-25 Thread Lucas De Marchi
On Mon, Mar 25, 2024 at 01:52:05PM +0100, Maxime Ripard wrote: While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort-AUX chardev interface uses DRM_DP_AUX_BUS. ^^^wrong copy & paste here, Otherwise for patches 1-5:

Re: [PATCH v2 3/3] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Liviu Dudau
On Mon, Mar 25, 2024 at 02:57:05PM +0100, Boris Brezillon wrote: > panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() > has been called, which is always the case when our panthor_xxx_unplug() > helpers are called. Fix that by introducing a panthor_xxx_unplug() helper > that

Re: [PATCH v2 2/3] drm/panthor: Fix ordering in _irq_suspend()

2024-03-25 Thread Liviu Dudau
On Mon, Mar 25, 2024 at 02:57:04PM +0100, Boris Brezillon wrote: > Make sure we set suspended=true last to avoid generating an irq storm > in the unlikely case where an IRQ happens between the suspended=true > assignment and the _INT_MASK update. > > v2: > - New patch > > Reported-by: Steven

Re: Future handling of complex RGB devices on Linux v3

2024-03-25 Thread Werner Sembach
Hi Hans, Am 25.03.24 um 15:18 schrieb Hans de Goede: Hi Werner, On 3/19/24 4:18 PM, Werner Sembach wrote: Hi Hans, Am 18.03.24 um 12:11 schrieb Hans de Goede: Hi Werner, Sorry for the late reply. np On 2/22/24 2:14 PM, Werner Sembach wrote: Hi, Thanks everyone for the exhaustive

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Werner Sembach
Hi Benjamin, Am 25.03.24 um 16:56 schrieb Benjamin Tissoires: On Mar 25 2024, Hans de Goede wrote: +Cc: Bentiss, Jiri Hi Werner, On 3/20/24 12:16 PM, Werner Sembach wrote: Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive

Re: [PATCH] drm/panel: replace utf multiply with an ascii x

2024-03-25 Thread Jessica Zhang
On 3/23/2024 12:40 AM, Prasad Pandit wrote: On Fri, 22 Mar 2024 at 20:54, Jessica Zhang wrote: Seems that this also happens in 2 other Kconfig entries. Can you replace those as well? * Yes, I've sent a revised patch. Acked, thanks! Thank you. --- - Prasad

Re: [PATCH v1] drm/panel: replace utf multiply with an ascii x

2024-03-25 Thread Jessica Zhang
On 3/23/2024 12:39 AM, Prasad Pandit wrote: From: Prasad Pandit Replace unicode multiplication character with an ascii x. It helps Kconfig parsers to read file without error. Hi Prasad, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Fixes: 25205087df1f ("drm/panel: Add driver for

Re: [PATCH] drm/panfrost: Only display fdinfo's engine and cycle tags when profiling is on

2024-03-25 Thread Steven Price
On 16/03/2024 23:13, Adrián Larumbe wrote: > If job accounting is disabled, then both fdinfo's drm-engine and drm-cycle > key values will remain immutable. In that case, it makes more sense not to > display them at all to avoid confusing user space profiling tools. > > Signed-off-by: Adrián

[PATCH net-next v4 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

2024-03-25 Thread Julien Panis
This patch introduces a member and the related accessors which can be used to store descriptor specific additional information. This member can store, for instance, an ID to differentiate a skb TX buffer type from a xdpf TX buffer type. Signed-off-by: Julien Panis ---

[PATCH net-next v4 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-03-25 Thread Julien Panis
This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW Ethernet driver. The following features are implemented: - NETDEV_XDP_ACT_BASIC (XDP_PASS, XDP_TX, XDP_DROP, XDP_ABORTED) - NETDEV_XDP_ACT_REDIRECT (XDP_REDIRECT) - NETDEV_XDP_ACT_NDO_XMIT (ndo_xdp_xmit callback) The page pool memory

[PATCH net-next v4 1/3] net: ethernet: ti: Add accessors for struct k3_cppi_desc_pool members

2024-03-25 Thread Julien Panis
This patch adds accessors for desc_size and cpumem members. They may be used, for instance, to compute a descriptor index. Signed-off-by: Julien Panis --- drivers/net/ethernet/ti/k3-cppi-desc-pool.c | 12 drivers/net/ethernet/ti/k3-cppi-desc-pool.h | 2 ++ 2 files changed, 14

[PATCH net-next v4 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

2024-03-25 Thread Julien Panis
This patch adds XDP support to TI AM65 CPSW Ethernet driver. The following features are implemented: NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT. Zero-copy and non-linear XDP buffer supports are NOT implemented. Besides, the page pool memory model is used to get

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Benjamin Tissoires
On Mar 25 2024, Hans de Goede wrote: > +Cc: Bentiss, Jiri > > Hi Werner, > > On 3/20/24 12:16 PM, Werner Sembach wrote: > > Hi Hans and the others, > > > > Am 22.02.24 um 14:14 schrieb Werner Sembach: > >> Hi, > >> > >> Thanks everyone for the exhaustive feedback. And at least this thread is a

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:04 +0100 Louis Chauvet wrote: > Re-introduce a line-by-line composition algorithm for each pixel format. > This allows more performance by not requiring an indirection per pixel > read. This patch is focused on readability of the code. > > Line-by-line composition was

Re: [PATCH v2 2/3] drm/panthor: Fix ordering in _irq_suspend()

2024-03-25 Thread Steven Price
On 25/03/2024 13:57, Boris Brezillon wrote: > Make sure we set suspended=true last to avoid generating an irq storm > in the unlikely case where an IRQ happens between the suspended=true > assignment and the _INT_MASK update. > > v2: > - New patch > > Reported-by: Steven Price > Signed-off-by:

Re: [PATCH] drm/i915: Delete stray .rej file

2024-03-25 Thread Jani Nikula
On Mon, 25 Mar 2024, Lucas De Marchi wrote: > drivers/gpu/drm/i915/gt/intel_workarounds.c.rej was incorrectly added to > the tree after solving a conflict. Remove it. > > Fixes: 326e30e4624c ("drm/i915: Drop dead code for pvc") > Reported-by: Stephen Rothwell > Closes:

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-25 Thread Pekka Paalanen
On Mon, 25 Mar 2024 11:15:13 -0300 Maíra Canal wrote: > On 3/13/24 14:45, Louis Chauvet wrote: > > Re-introduce a line-by-line composition algorithm for each pixel format. > > This allows more performance by not requiring an indirection per pixel > > read. This patch is focused on readability of

Re: [PATCH 00/12] drm/display: Convert helpers Kconfig symbols to depends on

2024-03-25 Thread Maxime Ripard
Hi, On Mon, Mar 25, 2024 at 04:13:50PM +0200, Jani Nikula wrote: > On Mon, 25 Mar 2024, Maxime Ripard wrote: > > Jani recently pointed out that the Kconfig symbols are a bit difficult > > to work with at the moment when they depend on each other, and that > > using depends on would be a better

[PATCH] drm/i915: Delete stray .rej file

2024-03-25 Thread Lucas De Marchi
drivers/gpu/drm/i915/gt/intel_workarounds.c.rej was incorrectly added to the tree after solving a conflict. Remove it. Fixes: 326e30e4624c ("drm/i915: Drop dead code for pvc") Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/r/20240325083435.4f970...@canb.auug.org.au Cc: Jani Nikula

Re: [PATCH v4] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-03-25 Thread Rob Herring
On Mon, 18 Mar 2024 11:10:13 +0530, Dharma Balasubiramani wrote: > Convert the atmel,lcdc bindings to DT schema. > Changes during conversion: add missing clocks and clock-names properties. > > Signed-off-by: Dharma Balasubiramani > --- > This patch converts the existing lcdc display text

Re: [PATCH v2] dt-bindings: display: samsung,exynos5-dp: convert to DT Schema

2024-03-25 Thread Rob Herring
On Wed, 13 Mar 2024 19:28:55 +0100, Krzysztof Kozlowski wrote: > Convert Samsung Exynos5250/5420 SoC Display Port Controller bindings to > DT schema with a change: add power-domains, already used in DTS. > > This Display Port controller is actually variant of Analogix Display > Port bridge,

Re: [PATCH v5 14/16] drm/vkms: Create KUnit tests for YUV conversions

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. Signed-off-by: Arthur Grillo

Re: [RESEND PATCH] dt-bindings: display: sony,td4353-jdi: allow width-mm and height-mm

2024-03-25 Thread Rob Herring
On Mon, 25 Mar 2024 11:32:27 +0100, Krzysztof Kozlowski wrote: > Allow width and height properties from panel-common.yaml, already used > on some boards: > > sdm845-sony-xperia-tama-apollo.dtb: panel@0: 'height-mm', 'width-mm' do not > match any of the regexes: 'pinctrl-[0-9]+' > > Acked-by:

Re: [PATCH 00/12] drm/display: Convert helpers Kconfig symbols to depends on

2024-03-25 Thread Jani Nikula
| 13 +++-- > drivers/gpu/drm/xlnx/Kconfig | 8 +-- > include/drm/display/drm_dp_helper.h | 2 +- > 26 files changed, 155 insertions(+), 141 deletions(-) > --- > base-commit: 5e842d55bad7794823a50f24fd645b58f2ef93ab > change-id: 20240325-kms-kconfig-helpers-f94991bdd6fa > > Best regards, -- Jani Nikula, Intel

Re: [PATCH v5 11/16] drm/vkms: Add YUV support

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: From: Arthur Grillo Add support to the YUV formats bellow: - NV12/NV16/NV24 - NV21/NV61/NV42 - YUV420/YUV422/YUV444 - YVU420/YVU422/YVU444 The conversion from yuv to rgb is done with fixed-point arithmetic, using 32.32 floats and the drm_fixed helpers.

In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
+Cc: Bentiss, Jiri Hi Werner, On 3/20/24 12:16 PM, Werner Sembach wrote: > Hi Hans and the others, > > Am 22.02.24 um 14:14 schrieb Werner Sembach: >> Hi, >> >> Thanks everyone for the exhaustive feedback. And at least this thread is a >> good comprehesive reference for the future ^^. >> >> To

Re: Future handling of complex RGB devices on Linux v3

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/19/24 4:18 PM, Werner Sembach wrote: > Hi Hans, > > Am 18.03.24 um 12:11 schrieb Hans de Goede: >> Hi Werner, >> >> Sorry for the late reply. > np >> >> On 2/22/24 2:14 PM, Werner Sembach wrote: >>> Hi, >>> >>> Thanks everyone for the exhaustive feedback. And at least this thread

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. This patch is focused on readability of the code. Line-by-line composition was introduced by [1] but

Re: [drm-tip:drm-tip 4/11] drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c:105:73: error: '.bin' directive output may be truncated writing 4 bytes into a region of size between 2 and 31

2024-03-25 Thread Doug Anderson
Hi, On Sat, Mar 23, 2024 at 10:15 AM kernel test robot wrote: > > tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip > head: 657dd8fcd2f1d1205c6f98fdb8b60915228991d1 > commit: 0885186926a13c697d78f5af03f32445414b6ad5 [4/11] Merge remote-tracking > branch 'drm-misc/drm-misc-next' into

Re: [PATCH] drm/amdkfd: return negative error code in svm_ioctl()

2024-03-25 Thread Philip Yang
On 2024-03-25 02:31, Su Hui wrote: svm_ioctl() should return negative error code in default case. Fixes: 42de677f7999 ("drm/amdkfd: register svm range") Signed-off-by: Su Hui Good catch, ioctl should return -errno. I will apply it to drm-next.

Re: [PATCH v5 09/16] drm/vkms: Introduce pixel_read_direction enum

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: The pixel_read_direction enum is useful to describe the reading direction in a plane. It avoids using the rotation property of DRM, which not practical to know the direction of reading. This patch also introduce two helpers, one to compute the

Re: [PATCH v5 06/16] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: As the pixel_read and pixel_write function should never modify the input buffer, mark those pointers const. Signed-off-by: Louis Chauvet Reviewed-by: Maíra Canal Best Regards, - Maíra --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++--

Re: [PATCH v5 05/16] drm/vkms: Add dummy pixel_read/pixel_write callbacks to avoid NULL pointers

2024-03-25 Thread Maíra Canal
On 3/13/24 14:44, Louis Chauvet wrote: Introduce two callbacks which does nothing. They are used in replacement of NULL and it avoid kernel OOPS if this NULL is called. If those callback are used, it means that there is a mismatch between what formats are announced by atomic_check and what is

[PATCH v2 3/3] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Boris Brezillon
panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() has been called, which is always the case when our panthor_xxx_unplug() helpers are called. Fix that by introducing a panthor_xxx_unplug() helper that does what panthor_xxx_irq_suspend() except it does it unconditionally.

  1   2   >