[pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-01 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. The following changes since commit e67572cd2204894179d89bd7b984072f19313b03: Linux 6.9-rc6 (2024-04-28 13:47:24 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.9-2024-05-01 for you to fetch

Re: [PATCH] drm/amd/display: Add MSF panel to DPCD 0x317 patch list

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 8, 2024 at 8:58 PM wrote: > > From: Tobias Jakobi > > This 8.4 inch panel is integrated in the Ayaneo Kun handheld > device. The panel resolution is 2560×1600, i.e. it has > portrait dimensions. > > Decoding the EDID shows: > Manufacturer: MSF > Model: 4099 >

Re: [PATCH] drm/amd/display: Remove duplicate dcn401/dcn401_clk_mgr.h header

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 24, 2024 at 11:42 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c: > dcn401/dcn401_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8885 >

Re: [PATCH] drm/amd/display: Remove duplicate spl/dc_spl_types.h header

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 24, 2024 at 9:52 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/inc/hw/transform.h: spl/dc_spl_types.h is > included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8884 > Signed-off-by: Jiapeng

Re: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Sun, Apr 28, 2024 at 9:32 PM Zhou, Bob wrote: > > [Public] > > Reviewed-by: Bob Zhou > > Regards, > Bob > > -Original Message- > From: Dan Carpenter > Sent: 2024年4月28日 20:57 > To: Zhou, Bob > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David

[pull] amdgpu, amdkfd drm-next-6.10

2024-04-26 Thread Alex Deucher
fix - Enable SQ watchpoint for gfx10 Alex Deucher (5): drm/amdkfd: demote unsupported device messages to dev_info drm/amdgpu/mes11: print MES opcodes rather than numbers drm/amdgpu/sdma5.2: use legacy HDP flush

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-04-24 Thread Alex Deucher
of restore worker - SVM fix Alex Deucher (1): drm/amdgpu/sdma5.2: use legacy HDP flush for SDMA2/3 Felix Kuehling (3): drm/amdkfd: Fix eviction fence handling drm/amdgpu: Update BO eviction priorities drm/amdkfd: Fix

Re: [PATCH] drm/amdgpu: Fixup bad vram size on gmc v6 and v7

2024-04-23 Thread Alex Deucher
On Tue, Apr 23, 2024 at 10:30 PM Qiang Ma wrote: > > On Mon, 22 Apr 2024 16:47:36 +0200 > Christian König wrote: > > > Am 22.04.24 um 16:40 schrieb Alex Deucher: > > > On Mon, Apr 22, 2024 at 9:00 AM Christian König > > > wrote: > > >> Am 22.04.

Re: [PATCH] drm/amdgpu: Fixup bad vram size on gmc v6 and v7

2024-04-22 Thread Alex Deucher
On Mon, Apr 22, 2024 at 9:00 AM Christian König wrote: > > Am 22.04.24 um 14:33 schrieb Qiang Ma: > > On Mon, 22 Apr 2024 11:40:26 +0200 > > Christian König wrote: > > > >> Am 22.04.24 um 07:26 schrieb Qiang Ma: > >>> Some boards(like Oland PRO: 0x1002:0x6613) seem to have > >>> garbage in the

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-19 Thread Alex Deucher
- DMABuf import handling fix radeon: - Silence UBSAN warnings related to flexible arrays Ahmad Rehman (1): drm/amdgpu: Skip the coredump collection on reset during driver reload Alex Deucher (4): drm/amdgpu/gfx11

Re: [PATCH] drm/amd/display: Remove duplicate dcn32/dcn32_clk_mgr.h header

2024-04-19 Thread Alex Deucher
Reviewed-by: Alex Deucher And applied. Thanks! Alex On Thu, Apr 18, 2024 at 10:37 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c: > dcn32/dcn32_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-18 Thread Alex Deucher
you just picked a random patch and opened a CVE. Alex > > -邮件原件----- > 发件人: Alex Deucher [mailto:alexdeuc...@gmail.com] > 发送时间: 2024年4月18日 9:58 > 收件人: wangzhu > 抄送: Greg KH ; harry.wentl...@amd.com; > sunpeng...@amd.com; rodrigo.sique...@amd.com; alexander.deuc...@amd.co

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-17 Thread Alex Deucher
rface with the HW through > > the GPINT mailbox resulting in a system hang. > > > > [How] > > Add dc_wake_and_execute_gpint() to wrap the wake, execute, sleep > > sequence. > > > > If the GPINT executes successfully then DMCUB will be put back into > > sl

[pull] amdgpu, amdkfd, radeon drm-fixes-6.9

2024-04-17 Thread Alex Deucher
ial UAF in VA IOCTL - Fix visible VRAM handling during faults amdkfd: - Fix memory leak in create_process failure radeon: - Silence UBSAN warnings from variable sized arrays ---- Alex Deucher (3): Revert "drm/amd/display: f

Re: [PATCH] drm/amdgpu: Add missing space to DRM_WARN() message

2024-04-15 Thread Alex Deucher
On Mon, Apr 15, 2024 at 4:40 AM Thorsten Blum wrote: > > s/,please/, please/ > > Signed-off-by: Thorsten Blum Reviewed-by: Alex Deucher And applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-13 Thread Alex Deucher
- Properly clean up workqueue during module unload - Fix memory leak process create failure - Range check CP bad op exception targets to avoid reporting invalid exceptions to userspace radeon: - Misc code cleanups Alex Deucher (2

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-12 Thread Alex Deucher
On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: > > On Fri, 12 Apr 2024 10:28:52 -0400 > Leo Li wrote: > > > On 2024-04-12 04:03, Pekka Paalanen wrote: > > > On Thu, 11 Apr 2024 16:33:57 -0400 > > > Leo Li wrote: > > > > > ... > > > >> That begs the question of what can be nailed down

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-04-10 Thread Alex Deucher
13.0.10 fix - VCN partition fix - GFX11 fixes - DWB fixes - Plane handling fix - FAMS fix - DCN 3.1.6 fix - VSC SDP fixes - OLED panel fix - GFX 11.5 fix amdkfd: - GPU reset fixes Alex Deucher (1): drm/amdgpu: always force full

Re: [PATCH -next] drm/amd/display: delete the redundant initialization in dcn3_51_soc

2024-04-08 Thread Alex Deucher
Acked-by: Alex Deucher Applied. Thanks, Alex On Mon, Apr 8, 2024 at 3:45 AM Xiang Yang wrote: > > the dram_clock_change_latency_us in dcn3_51_soc is initialized twice, so > delete one of them. > > Signed-off-by: Xiang Yang > --- > drivers/gpu/drm/amd/display/dc/dml/dc

Re: [PATCH v2] drm/radeon/radeon_display: Decrease the size of allocated memory

2024-04-08 Thread Alex Deucher
On Mon, Apr 1, 2024 at 8:35 AM Christian König wrote: > > Am 30.03.24 um 17:34 schrieb Erick Archer: > > This is an effort to get rid of all multiplications from allocation > > functions in order to prevent integer overflows [1] [2]. > > > > In this case, the memory allocated to store

Re: [PATCH] drm/amdgpu: add IP's FW information to devcoredump

2024-03-27 Thread Alex Deucher
tr atom_context->date Either way, Reviewed-by: Alex Deucher > --- > .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 122 ++ > 1 file changed, 122 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c > b/drivers/gpu/drm/amd/amdgpu/

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-03-27 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. Mostly fixes for new IPs added in 6.9. The following changes since commit 4cece764965020c22cff7665b18a012006359095: Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 11:41 PM Qiang Ma wrote: > > On Thu, 14 Mar 2024 14:40:40 + > "Deucher, Alexander" wrote: > > > [Public] > > > > > -Original Message- > > > From: Qiang Ma > > > Sent: Wednesday, March 13, 2024 2:18 AM > > > To: Deucher, Alexander ; Koenig, > > > Christian ;

Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote: > > dump the bios binary in the devcoredump. > > Signed-off-by: Sunil Khatri > --- > .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++ > 1 file changed, 20 insertions(+) > > diff --git

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: > > On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin > wrote: > > > > Hi Alex, > > > > On 3/26/2024 7:08 PM, Alex Deucher wrote: > > > On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: > > Hi Alex, > > On 3/26/2024 7:08 PM, Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam > > wrote: > >> Add clear page support in vram memory region. > >>

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Alex Deucher
On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: > > Add clear page support in vram memory region. > > v1(Christian): > - Dont handle clear page as TTM flag since when moving the BO back > in from GTT again we don't need that. > - Make a specialized version of

Re: [PATCH] drm/amdgpu: fix deadlock while reading mqd from debugfs

2024-03-24 Thread Alex Deucher
On Sat, Mar 23, 2024 at 4:47 PM Sharma, Shashank wrote: > > > On 23/03/2024 15:52, Johannes Weiner wrote: > > On Thu, Mar 14, 2024 at 01:09:57PM -0400, Johannes Weiner wrote: > >> Hello, > >> > >> On Fri, Mar 08, 2024 at 12:32:33PM +0100, Christian König wrote: > >>> Am 07.03.24 um 23:07 schrieb

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-03-21 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. Fairly big because it's about 3 weeks of fixes. The following changes since commit 119b225f01e4d3ce974cd3b4d982c76a380c796d: Merge tag 'amd-drm-next-6.9-2024-03-08-1' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2024-03-11 13:32:12 +1000) are

Re: [PATCH] drm/amdgpu: fix function implicit declaration error

2024-03-21 Thread Alex Deucher
Acked-by: Alex Deucher On Thu, Mar 21, 2024 at 2:14 PM Sunil Khatri wrote: > > when CONFIG_DEV_COREDUMP is not defined in that case > when amdgpu_coredump() is called it does not find it's > definition and the build fails. > > This happens as the header

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: > > Am 19.03.24 um 15:26 schrieb Alex Deucher: > > On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: > >> Refactor the code so debugfs and devcoredump can reuse > >> the common informat

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
een sysfs, debugfs > and devcoredump. > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_devinfo.c | 15

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
and devcoredump can reuse > >>> the common information and avoid unnecessary copy of it. > >>> > >>> created a new file which would be the right place to > >>> hold functions which will be used between sysfs, debugfs > >>> and devcoredump. >

Re: [PATCH] drm/sched: fix null-ptr-deref in init entity

2024-03-15 Thread Alex Deucher
05150] RIP: 0033:0x77b1a94f > > [ +0.003647] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 > > 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 > > <41> 89 c0 3d 00 f0 ff ff 77 1f 48 8b 44 24 18 64 48 2b 04 25 28 00 > > [ +0.019097]

Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Alex Deucher
On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote: > > Add all the IP's version information on a SOC to the > devcoredump. > > Signed-off-by: Sunil Khatri This looks great. Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 12:16 PM Khatri, Sunil wrote: > > > On 3/14/2024 8:12 PM, Alex Deucher wrote: > > On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: > >> > >> On 3/14/2024 1:58 AM, Alex Deucher wrote: > >>> On Tue, Mar 12, 2024 at 8:41 AM

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: > > > On 3/14/2024 1:58 AM, Alex Deucher wrote: > > On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: > >> Add all the IP's information on a SOC to the > >> devcoredump. > >> > >> Signed-of

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 2:10 AM Sharma, Shashank wrote: > > > On 14/03/2024 06:58, Khatri, Sunil wrote: > > > > On 3/14/2024 2:06 AM, Alex Deucher wrote: > >> On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri > >> wrote: > >>> Add firmware version i

Re: [PATCH AUTOSEL 5.15 3/5] drm/amdgpu: Enable gpu reset for S3 abort cases on Raven series

2024-03-13 Thread Alex Deucher
ges involved were also > backported, this should probably not be applied to older kernel > branches. I'm speculating it may be related to the removal of AMD IOMMUv2. > We should get confirmation from Prike, but I think he tested this on older kernels as well. Alex > Regards, >Felix > &

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-13 Thread Alex Deucher
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote: > > Add firmware version information of each > IP and each instance where applicable. > Is there a way we can share some common code with devcoredump, debugfs, and the info IOCTL? All three places need to query this information and the same

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-13 Thread Alex Deucher
On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: > > Add all the IP's information on a SOC to the > devcoredump. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git

Re: [PATCH v2 13/16] drm/ttm: make ttm_pool.h self-contained

2024-03-08 Thread Alex Deucher
re.kernel.org/oe-kbuild-all/202403072259.eec2vf1x-...@intel.com/ > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > include/drm/ttm/ttm_pool.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/drm/ttm/ttm_pool.h b/include/drm/ttm/ttm_poo

Re: [PATCH v2 10/16] drm/ttm: make ttm_caching.h self-contained

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote: > > Include for pgprot_t. > > Cc: Christian Koenig > Cc: Huang Rui > Acked-by: Thomas Zimmermann > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > include/drm/ttm/ttm_caching.h | 2 ++ >

Re: [PATCH v2 02/16] drm: add missing header guards to drm_crtc_helper_internal.h

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote: > > Including the file twice can lead to errors. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 5 + > 1 file changed, 5 insertions(+) > > d

Re: [PATCH v2 03/16] drm/encoder: improve drm_encoder_slave.h kernel-doc

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:08 AM Jani Nikula wrote: > > Document structs drm_encoder_slave_funcs, drm_encoder_slave, and > drm_i2c_encoder_driver. > > v2: Actually document the structs instead of just silencing kernel-doc > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deuch

Re: [PATCH v2 01/16] drm: add missing header guards to drm_crtc_internal.h

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:03 AM Jani Nikula wrote: > > Including the file twice can lead to errors. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_crtc_internal.h | 5 + > 1 file changed, 5 insertions(+) > > d

[pull] amdgpu, amdkfd drm-next-6.9

2024-03-08 Thread Alex Deucher
update - NBIF 6.3.1 support - VPE 6.1.1 support amdkfd: - Misc fixes and cleanups - GFX10.1 trap fixes Alex Deucher (2): drm/amd/display: handle range offsets in VRR ranges drm/amdgpu: add VPE 6.1.1 discovery support

Re: [PATCH 2/2] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Alex Deucher
On Thu, Mar 7, 2024 at 3:42 PM Khatri, Sunil wrote: > > > On 3/8/2024 12:44 AM, Alex Deucher wrote: > > On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote: > >> Add page fault information to the devcoredump. > >> > >> Output of devcoredump: > >&g

Re: [PATCH 2/2] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Alex Deucher
On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote: > > Add page fault information to the devcoredump. > > Output of devcoredump: > AMDGPU Device Coredump > version: 1 > kernel: 6.7.0-amd-staging-drm-next > module: amdgpu > time: 29.725011811 > process_name: soft_recovery_p PID: 1720 >

Re: [PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-07 Thread Alex Deucher
On Wed, Mar 6, 2024 at 1:43 PM Jani Nikula wrote: > > Include for u8. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher Do you want me to pick this up? Otherwise, feel free to take it via whatever tree makes sense. Alex > --- > include/drm/amd_asic_type.h | 3 +++ &g

[pull] amdgpu drm-fixes-6.8

2024-03-07 Thread Alex Deucher
) amd-drm-fixes-6.8-2024-03-07: amdgpu: - SMU14 fix - Fix possible NULL pointer - VRR fix - pwm fix Alex Deucher (1): drm/amd/display: handle range offsets in VRR ranges Li Ma (1): drm/amd/swsmu: modify the gfx activity

Re: [PATCH] Removed redundant @ symbol to fix kernel-doc warnings in -next repo

2024-03-06 Thread Alex Deucher
Fixed up patch title prefix and applied. Thanks! Alex On Tue, Mar 5, 2024 at 10:48 PM R SUNDAR wrote: > > For linux-next repository. > > ./drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured > comments found > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:132: warning:

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:42 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:59 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:45 PM, Alex Deucher wrote: > >>> On Wed, Mar 6, 2024 at 11:06 AM Kha

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:45 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:07 PM, Christian König wrote: > >>> Am 06.03.24 um 16:13 schr

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:07 PM, Christian König wrote: > > Am 06.03.24 um 16:13 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 8:34 PM, Christian König wrote: > >>> Am 06.03.24 um 15:29 schrieb Alex D

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > > > > On 3/6/2024 8:34 PM, Christian König wrote: > > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > > >> On Wed, Mar 6, 2024 at 8:04 AM

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > On 3/6/2024 8:34 PM, Christian König wrote: > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > >> On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > >>> > >>> On 3/6/2024 6:12 PM, Ch

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > > > On 3/6/2024 6:12 PM, Christian König wrote: > > Am 06.03.24 um 11:40 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 3:37 PM, Christian König wrote: > >>> Am 06.03.24 um 10:04 schrieb Sunil Khatri: > When an page fault interrupt is

[pull] amdgpu, amdkfd, radeon drm-next-6.9

2024-03-01 Thread Alex Deucher
- Revert freesync video amdkfd: - Misc cleanups - Error handling fixes radeon: - use RMW accessors for pci config registers Alex Deucher (3): Revert "drm/amd/pm: resolve reboot exception for si oland" Rever

Re: [PATCH] drm/amdgpu: remove misleading amdgpu_pmops_runtime_idle() comment

2024-02-29 Thread Alex Deucher
Applied. Thanks! On Thu, Feb 29, 2024 at 1:11 PM Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > After 4020c2280233 ("drm/amdgpu: don't runtime suspend if there are > displays attached (v3)"), "ret" is unconditionally set later before being > used, so there's point in initializing it and the

Re: [PATCH] drm/amd/display: check dc_link before dereferencing

2024-02-29 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 27, 2024 at 2:08 PM Melissa Wen wrote: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6683 > amdgpu_dm_connector_funcs_force() > warn: variable dereferenced before check 'dc_link' (see line 6663) > > Fixes: 967176179215 ("drm/amd/display: fix

[pull] amdgpu drm-fixes-6.8

2024-02-29 Thread Alex Deucher
- Suspend/resume fix - SI PM fix - eDP fix Alex Deucher (1): Revert "drm/amd/pm: resolve reboot exception for si oland" Ma Jun (1): drm/amdgpu/pm: Fix the power1_min_cap value Prike Liang (1): drm/amdgpu:

[pull] amdgpu drm-fixes-6.8

2024-02-22 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit b401b621758e46812da61fa58a67c3fd8d91de0d: Linux 6.8-rc5 (2024-02-18 12:56:25 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.8-2024-02-22 for you to fetch

Re: [PATCH] drm/amd/display: Add prefix to functions inside dnc10_cm_common.h

2024-02-21 Thread Alex Deucher
On Wed, Feb 21, 2024 at 2:31 PM Joao Paulo Pereira da Silva wrote: > > While debugging with ftrace, it's useful to create filters to search > within the codebase. However, since some function names lack prefixes, > creating a good filter may become more difficult. > > Because of this, add prefix

Re: [PATCH 0/3] drm/amdgpu: Use KMEM_CACHE instead of kmem_cache_create

2024-02-21 Thread Alex Deucher
Applied. Thanks! On Wed, Feb 21, 2024 at 6:08 AM Christian König wrote: > > Am 21.02.24 um 10:59 schrieb Kunwu Chan: > > For where the cache name and the structure name match. > > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create > > to simplify the creation of SLAB caches. > >

Re: Running ttm_device_test leads to list_add corruption. prev->next should be next (ffffffffc05cd428), but was 6b6b6b6b6b6b6b6b. (prev=ffffa0b1a5c034f0) (kernel 6.7.5)

2024-02-21 Thread Alex Deucher
fig attached. > > Thanks for that. > > As long as nobody comes up with an approach how to run the test even > when other drivers want to interact with TTM the attached patch is my > best idea. > > It basically disabled compiling the TTM tests as long as neither > compil

[pull] amdgpu, amdkfd, radeon drm-next-6.9

2024-02-19 Thread Alex Deucher
- MMHUB 3.3 updates - Suspend/resume fixes - DMUB updates amdkfd: - Trap handler enhancements - Fix cache size reporting - Relocate the trap handler radeon: - fix typo in print statement Alex Deucher (1): drm/amdgpu/psp

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Alex Deucher
On Mon, Feb 19, 2024 at 10:19 AM Christian König wrote: > > Am 16.02.24 um 19:37 schrieb Alex Deucher: > > On Fri, Feb 16, 2024 at 10:42 AM Christian König > > wrote: > >> Am 16.02.24 um 16:12 schrieb Mario Limonciello: > >>> On 2/16/2024 09:05, Harry Went

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Alex Deucher
On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: > > Am 16.02.24 um 16:12 schrieb Mario Limonciello: > > On 2/16/2024 09:05, Harry Wentland wrote: > >> > >> > >> On 2024-02-16 09:47, Christian König wrote: > >>> Am 16.02.24 um 15:42 schrieb Mario Limonciello: > On 2/16/2024 08:38,

Re: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

2024-02-16 Thread Alex Deucher
t; > bits that PCI core might need to touch. RMW accessors already have support > > > for proper locking for a selected set of registers > > > (LNKCTL2 is not yet among them but likely will be in the future) to avoid > > > losing > > > concurrent updates. > >

Re: [PATCH] drm/amd/display: Fix memory leak in dm_sw_fini()

2024-02-16 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 12, 2024 at 8:08 PM Armin Wolf wrote: > > After destroying dmub_srv, the memory associated with it is > not freed, causing a memory leak: > > unreferenced object 0x896302b45800 (size 1024): > comm "(udev-worker)", pid 222, jiffies 4294894636 > hex dump

[pull v2] amdgpu, amdkfd drm-fixes-6.8

2024-02-15 Thread Alex Deucher
Hi Dave, Daniel, Same PR as earlier today, but drop the panel power saving debugging patches for now at Harry's request. The following changes since commit 841c35169323cd833294798e58b9bf63fa4fa1de: Linux 6.8-rc4 (2024-02-11 12:18:13 -0800) are available in the Git repository at:

[pull] amdgpu, amdkfd drm-fixes-6.8

2024-02-15 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit 841c35169323cd833294798e58b9bf63fa4fa1de: Linux 6.8-rc4 (2024-02-11 12:18:13 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.8-2024-02-15 for you to fetch

Re: [PATCH 0/6 V4] fdinfo shared stats

2024-02-15 Thread Alex Deucher
On Thu, Feb 15, 2024 at 9:18 AM Christian König wrote: > > Am 12.02.24 um 22:04 schrieb Alex Deucher: > > We had a request to add shared buffer stats to fdinfo for amdgpu and > > while implementing that, Christian mentioned that just looking at > > the GEM handle count d

[PATCH 4/6] drm/amdgpu: add shared fdinfo stats

2024-02-12 Thread Alex Deucher
Add shared stats. Useful for seeing shared memory. v2: take dma-buf into account as well v3: use the new gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c

[PATCH 6/6] drm/xe: Update shared stats to use the new gem helper

2024-02-12 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/xe/xe_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

2024-02-12 Thread Alex Deucher
: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Tvrtko Ursulin (v1) Signed-off-by: Alex Deucher --- include/drm/drm_gem.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h index 369505447acd

[PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

2024-02-12 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Tvrtko Ursulin Signed-off-by: Alex Deucher --- drivers/gpu/drm/i915/i915_drm_client.c | 2 +- 1 file changed, 1

[PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

2024-02-12 Thread Alex Deucher
Clarify the documentation in preparation for updated helpers which check the handle count as well as whether a dma-buf has been attached. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Tvrtko Ursulin Signed-off-by: Alex Deucher

[PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

2024-02-12 Thread Alex Deucher
-by: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/drm_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index 8c87287c3e16..638ffaf5 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -913,7

[PATCH 0/6 V4] fdinfo shared stats

2024-02-12 Thread Alex Deucher
from a GPU top perspective, but it's more correct if you actually want to see shared buffers. After further discussions, add a helper and update all fdinfo implementations to use that helper for consistency. v4: switch drm_gem_object_is_shared_for_memory_stats() to an inline function Alex Deucher

[pull] amdgpu, amdkfd, radeon drm-next-6.9

2024-02-09 Thread Alex Deucher
userspace: https://github.com/Umio-Yasuno/libdrm-amdgpu-sys-rs/tree/input_power Alex Deucher (8): drm/amdgpu: add new INFO IOCTL query for input power drm/amdgpu: move kiq_reg_write_reg_wait() out of amdgpu_virt.c drm

Re: [PATCH] drm/amd/display: fix NULL checks for adev->dm.dc in amdgpu_dm_fini()

2024-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 6, 2024 at 11:51 AM Nikita Zhandarovich wrote: > > Since 'adev->dm.dc' in amdgpu_dm_fini() might turn out to be NULL > before the call to dc_enable_dmub_notifications(), check > beforehand to ensure there will not be a possible NULL-ptr-deref > there. > >

Re: [PATCH] drm/radeon/ni: Fix wrong firmware size logging in ni_init_microcode()

2024-02-09 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 6, 2024 at 11:48 AM Nikita Zhandarovich wrote: > > Clean up a typo in pr_err() erroneously printing NI MC 'rdev->mc_fw->size' > during SMC firmware load. Log 'rdev->smc_fw->size' instead. > > Found by Linux Verification Center (linuxtesting.org) with static >

[pull] amdgpu drm-fixes-6.8

2024-02-08 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit d0399da9fb5f8e3d897b9776bffee2d3bfe20210: drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL (2024-02-06 12:47:43 +1000) are available in the Git repository at:

Re: [PATCH] drm/amd/display: Increase frame-larger-than for all display_mode_vba files

2024-02-06 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 5, 2024 at 5:08 PM Nathan Chancellor wrote: > > After a recent change in LLVM, allmodconfig (which has CONFIG_KCSAN=y > and CONFIG_WERROR=y enabled) has a few new instances of > -Wframe-larger-than for the mode support and system configuration > functions: > > >

Re: [PATCH] drm/amd/display: Simplify the calculation of variables

2024-02-02 Thread Alex Deucher
On Fri, Feb 2, 2024 at 10:13 AM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c:236:49-51: WARNING !A || A > && B is equivalent to !A || B. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8169 > Signed-off-by: Jiapeng Chong

[pull] amdgpu, amdkfd drm-fixes-6.8

2024-02-01 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit 41bccc98fb7931d63d03f326a746ac4d429c1dd3: Linux 6.8-rc2 (2024-01-28 17:01:12 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.8-2024-02-01 for you to fetch

[PATCH 6/6] drm/xe: Update shared stats to use the new gem helper

2024-01-30 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/xe/xe_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

2024-01-30 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/i915/i915_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

2024-01-30 Thread Alex Deucher
/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/drm_gem.c | 16 include/drm/drm_gem.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 44a948b80ee1..71b5f628d828

[PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

2024-01-30 Thread Alex Deucher
Clarify the documentaiton in preparation for updated helpers which check the handle count as well as whether a dma-buf has been attached. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- Documentation/gpu/drm-usage-stats.rst

[PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

2024-01-30 Thread Alex Deucher
Show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem). v2: switch to gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Rob Clark (v1) Signed-off-by: Alex Deucher Cc: Rob Clark

[PATCH 4/6] drm/amdgpu: add shared fdinfo stats

2024-01-30 Thread Alex Deucher
Add shared stats. Useful for seeing shared memory. v2: take dma-buf into account as well v3: use the new gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c

[PATCH 0/6 V3] fdinfo shared stats

2024-01-30 Thread Alex Deucher
from a GPU top perspective, but it's more correct if you actually want to see shared buffers. After further discussions, add a helper and update all fdinfo implementations to use that helper for consistency. Alex Deucher (6): Documentation/gpu: Update documentation on drm-shared-* drm: add

[pull] amdgpu drm-fixes-6.8

2024-01-25 Thread Alex Deucher
Misc fixes ---- Alex Deucher (2): drm/amdgpu/gfx10: set UNORD_DISPATCH in compute MQDs drm/amdgpu/gfx11: set UNORD_DISPATCH in compute MQDs Alvin Lee (1): drm/amd/display: Add Replay IPS register for DMUB command table ChunTao Tso (1):

[pull] amdgpu, amdkfd drm-fixes-6.8

2024-01-18 Thread Alex Deucher
Hi Dave, Sima, New fixes for 6.8, on top of the fixes I sent last week and fixed up on Monday. The following changes since commit d7643fe6fb76edb1f2f1497bf5e8b8f4774b5129: drm/amd/display: Avoid enum conversion warning (2024-01-15 18:35:07 -0500) are available in the Git repository at:

Re: [PATCH] drm/radeon: remove dead code in ni_mc_load_microcode()

2024-01-18 Thread Alex Deucher
On Thu, Jan 18, 2024 at 3:52 AM Nikita Zhandarovich wrote: > > Inside the if block with (running == 0), the checks for 'running' > possibly being non-zero are redundant. Remove them altogether. > > This change is similar to the one authored by Heinrich Schuchardt > in commit > ddbbd3be9679

[pull] amdgpu, amdkfd drm-fixes-6.8

2024-01-15 Thread Alex Deucher
fix - SR-IOV fix - Add missing fw release for fiji - GFX 11.5 fix - Debugging module parameter fix - SMU 13.0.6 fixes - Fix new clang warning amdkfd: - Fix lockdep warnings - Fix sparse __rcu warnings - HMM fix - SVM fix Alex Deucher

[pull] amdgpu, amdkfd drm-fixes-6.8

2024-01-15 Thread Alex Deucher
is in this PR - HMM fix - SVM fix Alex Deucher (4): drm/amdgpu: fix avg vs input power reporting on smu7 drm/amdgpu: fall back to INPUT power for AVG power via INFO IOCTL drm/amdgpu/pm: clarify debugfs pm output

  1   2   3   4   5   6   7   8   9   10   >