Re: [PATCH] mach64: detect the dot clock divider correctly on sparc

2018-10-08 Thread Bartlomiej Zolnierkiewicz
/* >> * PLL Divider Q: >> Index: linux-stable/drivers/video/fbdev/aty/mach64_ct.c >> === >> --- linux-stable.orig/drivers/video/fbdev/aty/mach64_ct.c2018-08-13 >> 21:12:

Re: [PATCH] mach64: detect the dot clock divider correctly on sparc

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 10/08/2018 07:56 AM, David Miller wrote: > From: Ville Syrjälä > Date: Fri, 24 Aug 2018 14:58:52 +0300 > >> But yeah, given the V2CLK thing /5 seems like a perfectly good >> value to use here. > > Patch applied. Fine with me if you also need it in sparc tree.

Re: [PATCH 1/3] mach64: fix display corruption on big endian machines

2018-10-08 Thread Bartlomiej Zolnierkiewicz
t;> "le32_to_cpu". >> >> The patch also enables (hardware or software) bit triple only if the image >> is monochrome (image->depth). If we want to blit full-color image, we >> shouldn't use the triple code. > > Makes sense. > Reviewed-by: Ville Sy

Re: [PATCH 2/3] mach64: fix image corruption due to reading accelerator registers

2018-10-08 Thread Bartlomiej Zolnierkiewicz
image->depth) { >> case 1: >> @@ -370,12 +371,11 @@ void atyfb_imageblit(struct fb_info *inf >> mix = FRGD_MIX_D_XOR_S | BKGD_MIX_D; >> } >> >> -wait_for_fifo(6, par); >> - aty_st_le32(DP_WRITE_MASK, 0x, par); >

Re: [PATCH 3/3] mach64: optimize wait_for_fifo

2018-10-08 Thread Bartlomiej Zolnierkiewicz
t;> +fifo_space = 16 - fls(aty_ld_le32(FIFO_STAT, par) & 0x); > > I don't recall off hand which way this register works, but based > on the existing code this looks correct. > > Reviewed-by: Ville Syrjälä Patch queued for 4.20, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] atyfb: fix debugging printks

2018-10-08 Thread Bartlomiej Zolnierkiewicz
; output on sparc). > > Signed-off-by: Mikulas Patocka Patch queued for 4.20, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://li

Re: [PATCH v2 1/1] atmel_lcdfb: support native-mode display-timings

2018-10-08 Thread Bartlomiej Zolnierkiewicz
tive-mode. > > As a nice side-effect this fixes a memory leak where the > data used for timings and the display_np was not freed. > > Signed-off-by: Sam Ravnborg > Cc: Nicolas Ferre > Cc: Bartlomiej Zolnierkiewicz > Cc: Alexandre Belloni Patch queued for 4.20, thanks.

Re: [PATCH] fbdev: Convert to using %pOFn instead of device_node.name

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/28/2018 03:52 AM, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kerne

Re: [PATCH 1/2] fbdev: sbuslib: use checked version of put_user()

2018-10-08 Thread Bartlomiej Zolnierkiewicz
hanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] fbdev: sbuslib: integer overflow in sbusfb_ioctl_helper()

2018-10-08 Thread Bartlomiej Zolnierkiewicz
gt; @@ -171,7 +171,7 @@ int sbusfb_ioctl_helper(unsigned long cmd, unsigned long > arg, > get_user(ublue, &c->blue)) > return -EFAULT; > > - if (index + count > cmap->len) > + if (index > cmap->len || count > cmap->

Re: [PATCH v4] video: fbdev: omapfb: lcd_ams_delta: use GPIO lookup table

2018-10-08 Thread Bartlomiej Zolnierkiewicz
while respective GPIO > lookup table is initialized by a board init code. > > Signed-off-by: Janusz Krzysztofik > Reviewed-by: Linus Walleij Patch queued for 4.20, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___

Re: [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code

2018-10-08 Thread Bartlomiej Zolnierkiewicz
t; = > 1 warning generated. > > Remove the parentheses and while we're at it, clean up the commented > code, which has been here since the beginning of git history. > > Link: https://github.com/ClangBuiltLinux/linux/issues/118 > S

Re: [PATCH] fbdev: fix broken menu dependencies

2018-10-08 Thread Bartlomiej Zolnierkiewicz
video: clps711x: Add new Cirrus Logic CLPS711X > framebuffer driver") > > Signed-off-by: Randy Dunlap > Cc: Ezequiel Garcia > Cc: Daniel Vetter > Cc: Alexander Shiyan > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.

Re: [PATCH -next] pxa168fb: remove set but not used variables 'mi'

2018-10-08 Thread Bartlomiej Zolnierkiewicz
-Wunused-but-set-variable] > > Signed-off-by: YueHaibing Patch queued for 4.20, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: arcfb: mark expected switch fall-through

2018-10-08 Thread Bartlomiej Zolnierkiewicz
h queued for 4.20, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] video: fbdev: remove dead old CLPS711x LCD support driver

2018-10-08 Thread Bartlomiej Zolnierkiewicz
t has been dead for over 2 years now. Please note that the new CLPS711x LCD support driver (enabled by the FB_CLPS711X config option) is still available in the kernel tree. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |7 drivers/video/fbdev/Makefile |1

[PATCH] video: fbdev: remove redundant 'default n' from Kconfig-s

2018-10-08 Thread Bartlomiej Zolnierkiewicz
n With this change, neither of these will generate a '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). That might make it clearer to people that a bare 'default n' is redundant. ... Signed-off-by: Bartlomiej Zolnier

[GIT PULL] fbdev changes for v4.20

2018-10-31 Thread Bartlomiej Zolnierkiewicz
regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit 0238df646e6224016a45505d2c111a24669ebe21: Linux 4.19-rc7 (2018-10-07 17:26:02 +0200) are available in the git repository at: https://github.com/bzolnier/linux.git tags

Re: [PATCH] MAINTAINERS: make omapfb orphan

2018-06-08 Thread Bartlomiej Zolnierkiewicz
by omapfb which are not supported by > omapdrm, so we're not there yet. > > Signed-off-by: Tomi Valkeinen Thank you for your work on omapfb, patch queued for 4.18. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH] video/omap: add module license tags

2018-06-08 Thread Bartlomiej Zolnierkiewicz
e, > since Imre is working at Intel these days. > > Fixes: 81c44c2b2ce3 ("video/omap: fix modular build") > Cc: Imre Deak > Signed-off-by: Arnd Bergmann Patch queued for 4.18 (with minor fixups, interdiff below), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sa

Re: [PATCH] fb_omap: add gpiolib dependency

2018-06-08 Thread Bartlomiej Zolnierkiewicz
ction-declaration] > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit > declaration of function 'of_node_put'; did you mean 'node_s

Re: [PATCH 2/3] goldfish: Enable ACPI-based enumeration for goldfish framebuffer

2018-06-08 Thread Bartlomiej Zolnierkiewicz
this patch also depends on commit af33cac. ditto for commit af33ac also commits should be described with the following format: tag with the first 12 characters of the SHA-1 ID, and the one line summary, i.e.: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()") Best regards, --

Re: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

2018-06-08 Thread Bartlomiej Zolnierkiewicz
me. > > Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42 please drop your local Change-Id from the upstream kernel submissions > Signed-off-by: Christoffer Dall > Signed-off-by: Peter Maydell your S-o-b line is also needed Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge

2018-06-13 Thread Bartlomiej Zolnierkiewicz
Biesheuvel > > Bartlomiej, could you please take these via the fbdev tree for v4.19? Sure, I will queue it after the current merge window. > Peter already gave his ack but Sinan dropped it (presumably because of > the split in v2) Peter, can I (re)add your ACK to V2 patches? Best

[GIT PULL] fbdev changes for v4.18

2018-06-14 Thread Bartlomiej Zolnierkiewicz
arkus Elfring, Andy Shevchenko, Colin Ian King) Andy Shevchenko (1): video: fbdev: pxafb: Convert to use match_string() helper Arnd Bergmann (2): video/omap: add module license tags fb_omap2: add gpiolib dependency Bartlomiej Zolnie

Re: [PATCH 57/61] video: fbdev: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 19, 2018 04:06:27 PM Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz

Re: [PATCH 58/61] video: fbdev: omap2: omapfb: displays: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 19, 2018 04:06:28 PM Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz

Re: [PATCH] video: fbdev: sh_mobile_meram: Drop SUPERH platform dependency

2018-04-24 Thread Bartlomiej Zolnierkiewicz
are set for > these platforms, the SUPERH dependency can be dropped. > > Signed-off-by: Geert Uytterhoeven Patch queued for 4.18 (w/ Laurent's & Simon's ACKs), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

2018-04-25 Thread Bartlomiej Zolnierkiewicz
On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote: > Em Mon, 23 Apr 2018 14:47:28 +0200 > Bartlomiej Zolnierkiewicz escreveu: > > > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > > Add stubs for omapfb_dss.h, in the case it is inclu

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

2018-04-25 Thread Bartlomiej Zolnierkiewicz
On Monday, April 23, 2018 05:11:14 PM Tomi Valkeinen wrote: > On 23/04/18 16:56, Bartlomiej Zolnierkiewicz wrote: > > > Ideally we should be able to build both drivers in the same kernel > > (especially as modules). > > > > I was hoping that it could be fixe

Re: [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two functions

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH] video: sh_mobile_meram: Delete an error message for a failed memory allocation in sh_mobile_meram_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH] video: auo_k190x: Delete an error message for a failed memory allocation in auok190x_common_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two functions

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung

Re: [PATCH 2/4] video: sm501fb: Improve a size determination in sm501fb_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Hand applied and queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung

Re: [PATCH 2/3] video: omap: Improve a size determination in omapfb_do_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung

[PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Bartlomiej Zolnierkiewicz
uot;video: auo_k190x: add driver for AUO-K1901 variant") They never had any in-kernel user so just remove them (since they are platform drivers they need corresponding platform devices to be registered by kernel and it has never happened). Cc: Heiko Stübner Signed-off-by: Bartlomiej Zolnierkie

[PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
both upstream (v4.18) I will apply patch #3 to fbdev tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (3): video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support drm: shmobile: remove unused MERAM support vide

[PATCH 1/3] video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Since commit a521422ea4ae ("ARM: shmobile: mackerel: Remove Legacy C board code") MERAM functionality is unused. Remove it. Cc: Simon Horman Cc: Laurent Pinchart Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig| 1 - dri

[PATCH 2/3] drm: shmobile: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Since commit a521422ea4ae ("ARM: shmobile: mackerel: Remove Legacy C board code") MERAM functionality is unused. Remove it. Cc: Simon Horman Cc: Laurent Pinchart Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/gpu/drm/shmobile/Kconfig | 1

[PATCH 3/3] video: fbdev: remove unused sh_mobile_meram driver

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Since commit a521422ea4ae ("ARM: shmobile: mackerel: Remove Legacy C board code") MERAM functionality is unused. Remove it. Cc: Simon Horman Cc: Laurent Pinchart Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig | 12 - dri

[PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Bartlomiej Zolnierkiewicz
t even compile. Cc: Tomi Valkeinen Cc: Laurent Pinchart Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/omap2/omapfb/dss/Kconfig | 13 drivers/video/fbdev/omap2/omapfb/dss/Makefile |1 drivers/video/fbdev/omap2/omapfb/dss/core.c |6 drivers/video/fbdev/omap2/omapfb/dss/

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 08:47:14 PM Aaro Koskinen wrote: > Hi, > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > > > The RFBI driver has not

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 09:25:37 PM Aaro Koskinen wrote: > Hi, > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > > > The RFBI driver has not

Re: [PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF

2018-05-04 Thread Bartlomiej Zolnierkiewicz
> > source "drivers/video/fbdev/omap2/omapfb/Kconfig" > > > > > > Hi, > > This patch certainly fixes the build errors that I have been seeing in > linux-next for several days now, so: > > Acked-by: Randy Dunlap >

Re: [PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF

2018-05-04 Thread Bartlomiej Zolnierkiewicz
On Friday, May 04, 2018 07:59:06 AM Mauro Carvalho Chehab wrote: > Em Fri, 04 May 2018 12:48:46 +0200 > Bartlomiej Zolnierkiewicz escreveu: > > > On Thursday, May 03, 2018 08:48:56 AM Randy Dunlap wrote: > > > On 04/20/2018 04:25 AM, Anders Roxell wrote: > > &

Re: [PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF

2018-05-04 Thread Bartlomiej Zolnierkiewicz
On Friday, May 04, 2018 09:45:26 AM Mauro Carvalho Chehab wrote: > Em Fri, 04 May 2018 13:05:17 +0200 > Bartlomiej Zolnierkiewicz escreveu: > > > On Friday, May 04, 2018 07:59:06 AM Mauro Carvalho Chehab wrote: > > > Em Fri, 04 May 2018 12:48:46 +0200 > > > Ba

Re: [PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-05-14 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 05:07:41 PM Heiko Stuebner wrote: > Am Freitag, 27. April 2018, 13:04:24 CEST schrieb Bartlomiej Zolnierkiewicz: > > auo_k1900fb and auo_k1901fb drivers have been introduced six > > years ago by following commits: > > > > commit 2c8304d3125b (

Re: [PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

2018-05-14 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 02:09:31 PM Daniel Vetter wrote: > On Fri, Apr 27, 2018 at 1:36 PM, Laurent Pinchart > wrote: > > Hi Bartlomiej, > > > > On Friday, 27 April 2018 14:21:42 EEST Bartlomiej Zolnierkiewicz wrote: > >> Hi, > >> > >> This p

Re: [PATCH 14/18] fbdev: modedb.c: fix a kernel-doc markup

2018-05-15 Thread Bartlomiej Zolnierkiewicz
ing. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://li

Re: [PATCH v2 11/11] docs: fix broken references with multiple hints

2018-05-15 Thread Bartlomiej Zolnierkiewicz
Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz # for fbdev part Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedes

Re: [PATCH] video: fbdev: fix spelling mistake: "frambuffer" -> "framebuffer"

2018-05-15 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 09:37:42 AM Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error messages > > Signed-off-by: Colin Ian King Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland

Re: [PATCH] video: fbdev: nvidia: fix spelling mistake: "scaleing" -> "scaling"

2018-05-15 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 08, 2018 11:36:19 PM Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in module parameter description text > > Signed-off-by: Colin Ian King Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&

Re: [REGRESSION PATCH] fbdev: fbmem: behave better with small rotated displays and many CPUs

2018-11-26 Thread Bartlomiej Zolnierkiewicz
On 11/26/2018 03:16 PM, Peter Rosin wrote: > Ping?! Hi, Thank you for your patch, it will be considered for 4.21 (as it is not a recent regression + I'm busy with other things currently). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electroni

Re: [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon

2018-08-10 Thread Bartlomiej Zolnierkiewicz
ded to your tree for merging into 4.19, > patch 3 can go in in the 4.20 cycle if you prefer delaying it till then. Patches 1-3 queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___

Re: [PATCH] Documentation/fb: corrections for fbcon.txt

2018-08-10 Thread Bartlomiej Zolnierkiewicz
On Tuesday, August 07, 2018 09:27:52 AM Randy Dunlap wrote: > From: Randy Dunlap > > Fix grammar, spacing, indentation, and Kconfig menu locations > in fbcon.txt. > > Signed-off-by: Randy Dunlap Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sam

Re: [PATCH v3] fbcon: Do not takeover the console from atomic context

2018-08-10 Thread Bartlomiej Zolnierkiewicz
le] int i; ^ I fixed this while applying the patch. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL] fbdev changes for v4.19

2018-08-23 Thread Bartlomiej Zolnierkiewicz
details. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit 334bb8972a131e604a741e9b284d8867190c723e: console: dummycon: export dummycon_[un]register_output_notifier (2018-06-29 11:46:19 +0200) are available in the

Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

2018-09-03 Thread Bartlomiej Zolnierkiewicz
: document fbdev remove > functions" or similar) that would be great. > > Only thing we need for merging now is the ack from Bartlomiej. For the whole patchset: Acked-by: Bartlomiej Zolnierkiewicz > -Daniel > > > - propagate return value in

Re: [REGRESSION] boot-screen override by "34db50e55656 efifb: Copy the ACPI BGRT"

2018-09-03 Thread Bartlomiej Zolnierkiewicz
... +static void efifb_show_boot_graphics(struct fb_info *info) ... +#else +static inline void efifb_show_boot_graphics(struct fb_info *info) {} +#endif > Can we either provide an option to disable this feature, or revert the commit? Hans? Best regards, -- Bartlomie

Re: [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c

2018-06-18 Thread Bartlomiej Zolnierkiewicz
On Friday, June 15, 2018 04:47:03 PM Roman Kiryanov wrote: > Hi, > > could you please confirm you received our patches? Thank you. Hi, Yes, they are in my inbox waiting for their turn (I'll start queuing patches for v4.19 later this week). Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge

2018-06-22 Thread Bartlomiej Zolnierkiewicz
On Friday, June 22, 2018 09:54:22 AM Ard Biesheuvel wrote: > On 13 June 2018 at 18:08, Bartlomiej Zolnierkiewicz > wrote: > > On Wednesday, June 13, 2018 05:45:48 PM Ard Biesheuvel wrote: > >> On 18 May 2018 at 16:17, Sinan Kaya wrote: > >> > A host bridge is all

Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge

2018-06-22 Thread Bartlomiej Zolnierkiewicz
On Friday, June 22, 2018 12:07:48 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, June 22, 2018 09:54:22 AM Ard Biesheuvel wrote: > > On 13 June 2018 at 18:08, Bartlomiej Zolnierkiewicz > > wrote: > > > On Wednesday, June 13, 2018 05:45:48 PM Ard Biesheuvel wrote: > &

Re: [PATCH V2 1/2] efi/fb: Simplify fixup code to prefer struct resource

2018-06-22 Thread Bartlomiej Zolnierkiewicz
t; > Signed-off-by: Sinan Kaya > > Reviewed-by: Ard Biesheuvel Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.fr

Re: [PATCH v4 0/3] console/fbcon: Add support for deferred console takeover

2018-06-27 Thread Bartlomiej Zolnierkiewicz
ll increase testing by gpu drivers a lot, instead of a suprise when > the fbdev pull lands in upstream. > > Bart, is that ok with you? Not really, since there are efifb changes in the queue which depend on this series I would really prefer to merge all patches through fbdev tree. Also

Re: [PATCH v5 0/3] console/fbcon: Add support for deferred console takeover

2018-06-28 Thread Bartlomiej Zolnierkiewicz
drivers/video/fbdev/core/fbcon.c | 83 include/linux/console.h | 5 +++ kernel/printk/printk.c | 1 + 6 files changed, 166 insertions(+), 8 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH] console: dummycon: export dummycon_[un]register_output_notifier

2018-06-29 Thread Bartlomiej Zolnierkiewicz
phen Rothwell > Reported-by: Stephen Rothwell > Signed-off-by: Hans de Goede Applied to fbdev-for-next, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list

Re: [PATCH v5 0/3] console/fbcon: Add support for deferred console takeover

2018-06-29 Thread Bartlomiej Zolnierkiewicz
Hi Gustavo, On Thursday, June 28, 2018 07:44:38 PM Gustavo Padovan wrote: > Hi Bartlomiej, > > On Thu, 2018-06-28 at 15:50 +0200, Bartlomiej Zolnierkiewicz wrote: > > On Thursday, June 28, 2018 11:03:48 AM Hans de Goede wrote: > > > Hi All, > > > > >

Re: [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size

2018-07-02 Thread Bartlomiej Zolnierkiewicz
b/drivers/firmware/efi/efi-bgrt.c > >> index 50793fda7819..b22ccfb0c991 100644 > >> --- a/drivers/firmware/efi/efi-bgrt.c > >> +++ b/drivers/firmware/efi/efi-bgrt.c > >> @@ -20,7 +20,7 @@ > >> #include > >> struct acpi_table_bgrt bgrt_tab

Re: [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c

2018-07-03 Thread Bartlomiej Zolnierkiewicz
On Friday, June 08, 2018 12:10:58 PM r...@google.com wrote: > From: Roman Kiryanov > > Address issues pointed by checkpatch.pl > > Signed-off-by: Roman Kiryanov Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland

Re: [PATCH v2 2/3] video: fbdev: Enable ACPI-based enumeration for goldfishfb

2018-07-03 Thread Bartlomiej Zolnierkiewicz
On Friday, June 08, 2018 12:10:59 PM r...@google.com wrote: > From: Yu Ning > > Add an ACPI id to make goldfish framebuffer to support ACPI enumeration. > > Signed-off-by: Yu Ning > Signed-off-by: Roman Kiryanov Patch queued for 4.19, thanks. Best regards, -- Bartlom

Re: [PATCH v2 3/3] video: fbdev: Set pixclock = 0 in goldfishfb

2018-07-03 Thread Bartlomiej Zolnierkiewicz
-by: Christoffer Dall > Signed-off-by: Peter Maydell > Signed-off-by: Roman Kiryanov Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-de

Re: [PATCH] omapfb: encoder-tpd12s015: fix error return code

2018-07-03 Thread Bartlomiej Zolnierkiewicz
On Sunday, June 10, 2018 04:24:13 PM Julia Lawall wrote: > Return an error code on failure. > > Problem found using Coccinelle. > > Signed-off-by: Julia Lawall Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

2018-07-03 Thread Bartlomiej Zolnierkiewicz
ered_fb--; > fb_cleanup_device(fb_info); > event.info = fb_info; > @@ -1860,6 +1870,9 @@ int unlink_framebuffer(struct fb_info *f > device_destroy(fb_class, MKDEV(FB_MAJOR, i)); > fb_info->dev = NULL; > } > +

Re: [PATCH 18/21] udlfb: allow reallocating the framebuffer

2018-07-03 Thread Bartlomiej Zolnierkiewicz
_fb; [...] > > 1196 if (info->screen_base) { > > 1197 memcpy(new_fb, old_fb, old_len); > > > 1198 dlfb_deferred_vfree(dlfb, > > > info->screen_base); > > 1199

Re: [PATCH] video: fbdev: simplefb: Stop including

2018-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday, June 19, 2018 07:22:21 PM Geert Uytterhoeven wrote: > Simplefb is not a clock provider, but it uses of_clk_get_parent_count(), > so it can just include instead. > > Signed-off-by: Geert Uytterhoeven Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkie

Re: [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size

2018-07-03 Thread Bartlomiej Zolnierkiewicz
On Monday, July 02, 2018 02:02:47 PM Ard Biesheuvel wrote: > On 2 July 2018 at 13:57, Bartlomiej Zolnierkiewicz > wrote: > > On Monday, July 02, 2018 01:46:09 PM Ard Biesheuvel wrote: > >> On 2 July 2018 at 13:26, Hans de Goede wrote: > >> > Bartlomiej, > >

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

2018-07-04 Thread Bartlomiej Zolnierkiewicz
On Tuesday, July 03, 2018 01:18:57 PM Mikulas Patocka wrote: > > On Tue, 3 Jul 2018, Bartlomiej Zolnierkiewicz wrote: > > > > > Hi, > > > > On Sunday, June 03, 2018 11:46:29 AM Mikulas Patocka wrote: > > > I have a USB display adapter using the udlfb

no handling of fbdev patches till 20.12

2018-11-30 Thread Bartlomiej Zolnierkiewicz
Hi, I will be traveling / busy with other things / without access to my development setup till 20.12. When I'm back I will handle the rest of pending v4.21 changes, sorry for the inconvenience. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung El

Re: [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag

2018-09-10 Thread Bartlomiej Zolnierkiewicz
o the > usual 3-phase removal. > > Cc: Ben Skeggs > Cc: Bartlomiej Zolnierkiewicz > Cc: Greg Kroah-Hartman > Cc: Hans de Goede > Cc: Daniel Vetter > Cc: Alexander Kapshuk > Cc: Kees Cook > Cc: Thierry Reding > Cc: David Lechner > Cc: nouv...@lists.freed

Re: [PATCH 3/4] fbdev: Add FBINFO_HIDE_SMEM_START flag

2018-09-10 Thread Bartlomiej Zolnierkiewicz
nient. > > Hence instead just stop the leak in the ioctl, to keep fb mmap working > as-is. A second patch will set this flag for all drm drivers. > > Cc: Bartlomiej Zolnierkiewicz > Cc: Kees Cook > Cc: Daniel Vetter > Cc: linux-fb...@vger.kernel.org > Signed-

Re: [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag

2018-09-11 Thread Bartlomiej Zolnierkiewicz
On 09/11/2018 09:42 AM, Daniel Vetter wrote: > On Mon, Sep 10, 2018 at 02:48:43PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> On 08/22/2018 10:54 AM, Daniel Vetter wrote: >>> This was only added for the drm's fbdev emulation support, so that it >>

Re: [PATCH v2 02/24] drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap()

2018-09-13 Thread Bartlomiej Zolnierkiewicz
write combined noncached page, so lets > use ioremap_wc() instead. > > _PAGE_WRITETHRU is also platform specific flag. Use ioremap_wt() > instead. > > Signed-off-by: Christophe Leroy After reading patch #1 this one LGTM. Acked-by: Bartlomiej Zolnierkiewicz > --- >

Re: [PATCH] pxa168fb: prepare the clock

2018-09-26 Thread Bartlomiej Zolnierkiewicz
c int pxa168fb_remove(struct platform_device *pdev) > dma_free_wc(fbi->dev, PAGE_ALIGN(info->fix.smem_len), > info->screen_base, info->fix.smem_start); > > - clk_disable(fbi->clk); > + clk_disable_unprepare(fbi->clk); > > framebuffer_release(info); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] fbdev/omapfb: fix omapfb_memory_read infoleak

2018-09-26 Thread Bartlomiej Zolnierkiewicz
y, mr->w, mr->h); > > if (r > 0) { > - if (copy_to_user(mr->buffer, buf, mr->buffer_size)) > + if (copy_to_user(mr->buffer, buf, r)) > r = -EFAULT; > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] efifb: BGRT: Add nobgrt option

2018-09-26 Thread Bartlomiej Zolnierkiewicz
: David Herrmann >> Reported-by: David Herrmann >> Signed-off-by: Hans de Goede >> --- >> drivers/video/fbdev/efifb.c | 6 ++ >> 1 file changed, 6 insertions(+) > > Reviewed-by: David Herrmann Patch queued for 4.19, thanks. Best regards, --

Re: uvesafb: Fix URLs in the documentation

2018-09-26 Thread Bartlomiej Zolnierkiewicz
Randy Dunlap Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video/fbdev/stifb: Fix spelling mistake in fall-through annotation

2018-09-26 Thread Bartlomiej Zolnierkiewicz
itch") > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL] fbdev fixes for v4.19-rc7

2018-10-02 Thread Bartlomiej Zolnierkiewicz
Hi Greg, Please pull fbdev fixes for v4.19-rc7 (please see the signed tag description for details). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84: Linux 4.19-rc5 (

no handling of fbdev patches till 23.07

2018-07-13 Thread Bartlomiej Zolnierkiewicz
Hi, I will be traveling / busy with other things / without access to my development setup till 23.07. When I'm back I will handle the rest of pending v4.19 changes, sorry for the inconvenience. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung El

Re: [PATCH] fbdev: Distinguish between interlaced and progressive modes

2018-07-24 Thread Bartlomiej Zolnierkiewicz
ariant of 1920x1080 since the loop > matching the modes does not take the difference between interlaced and > progressive modes into account. > > In short, without the patch, progressive 1920x1080 cannot be chosen as a > mode_option parameter since fb_find_mode (falsely) thinks interla

Re: [PATCH v2 1/2] dt-bindings: display: add devicetree bindings for pxa300-gcu

2018-07-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday, July 04, 2018 09:35:01 PM Daniel Mack wrote: > This patch adds the binding documentation for the pxa300 gcu. > > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsun

Re: [PATCH v2 2/2] video: fbdev: pxa3xx_gcu: add devicetree bindings

2018-07-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday, July 04, 2018 09:35:02 PM Daniel Mack wrote: > Add a device tree match table for this hardware graphics acceleration > driver so it can be used by pxa3xx boards booted with a devicetree. > > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -

Re: [PATCH 2/4] video: fbdev: pxafb: switch to devm_* API

2018-07-24 Thread Bartlomiej Zolnierkiewicz
On Sunday, June 24, 2018 05:38:15 PM Daniel Mack wrote: > This helps us clean up the probe() and remove() implementations. > > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsun

Re: [PATCH 1/4] video: fbdev: pxafb: clear allocated memory for video modes

2018-07-24 Thread Bartlomiej Zolnierkiewicz
gt; > Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion) > Reviewed-by: Robert Jarzmik > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH 3/4] video: fbdev: pxafb: handle errors from pxafb_init_fbinfo() correctly

2018-07-24 Thread Bartlomiej Zolnierkiewicz
. > > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] video: fbdev: pxafb: Add support for lcd-supply regulator

2018-07-24 Thread Bartlomiej Zolnierkiewicz
; > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] video: fbdev: pxafb: clear allocated memory for video modes

2018-07-24 Thread Bartlomiej Zolnierkiewicz
On Monday, July 09, 2018 07:12:50 AM Daniel Mack wrote: > Hi Bartlomiej, Hi, > Should I resend with Robert's Reviewed-bys again? I'd like to get this > merged for 4.19 if possible. No need for resend, I added Robert's tags while applying your patches. Bes

Re: [PATCH] video: fbdev: fsl-diu-fb: Remove VLA usage

2018-07-24 Thread Bartlomiej Zolnierkiewicz
Timur Tabi Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

<    1   2   3   4   5   6   7   >