Re: [PATCH] drm/vc4: Allow using more than 256MB of CMA memory.

sure the memory used by the tile binner (still have to look at what a tile binner is :-)) does not cross a 256MB. So, not sure my review has a real value here, but Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > > Signed-off-by: Eric Anholt <e...@anholt.n

Re: [PATCH 6/6] drm: mali-dp: Add writeback connector

On Fri, 25 Nov 2016 16:49:04 + Brian Starkey wrote: > +static int > +malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, > +struct drm_crtc_state *crtc_state, > +struct drm_connector_state *conn_state) >

Re: [PATCH 2/6] drm: writeback: Add out-fences for writeback connectors

On Fri, 25 Nov 2016 16:49:00 + Brian Starkey wrote: > Add the OUT_FENCE_PTR property to writeback connectors, to enable > userspace to get a fence which will signal once the writeback is > complete. It is not allowed to request an out-fence without a > framebuffer

Re: [PATCH 1/6] drm: Add writeback connector type

On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index b5c6a8e..6bbd93f 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -86,6 +86,7 @@

Re: [PATCH 1/6] drm: Add writeback connector type

On Wed, 19 Apr 2017 10:51:23 +0100 Brian Starkey <brian.star...@arm.com> wrote: > On Tue, Apr 18, 2017 at 09:57:17PM +0200, Boris Brezillon wrote: > >Hi Brian, > > > >On Tue, 18 Apr 2017 18:34:43 +0100 > >Brian Starkey <brian.star...@arm.com> wrote: &g

Re: [PATCH] drm/atmel-hlcdc: Rework the fbdev creation logic

On Thu, 2 Mar 2017 17:04:51 +0100 Richard Genoud <richard.gen...@gmail.com> wrote: > On 28/11/2016 16:01, Boris Brezillon wrote: > > Now that we wait for DRM panels to be available before registering the > > DRM device (returning -EPROBE_DEFER if the panel has not bee

[PATCH] drm/atmel-hlcdc: Fix suspend/resume implementation

-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 33 -- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 31 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 8 --- 3 files chang

Re: [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

On Fri, 14 Apr 2017 11:20:52 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > The HDMI driver is currently enabling all clks and probe time and keep > > the power-domain connected to the HDMI enc

Re: [PATCH] drm: atmel-hlcdc: Uninitialized return in atmel_hlcdc_create_outputs()

es: ebc944613567 ("drm: convert drivers to use > drm_of_find_panel_or_bridge") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> Daniel, should I directly apply this patch to drm-misc-next-fixes or

Re: [PATCH 1/6] drm: Add writeback connector type

Hi Brian, On Tue, 18 Apr 2017 18:34:43 +0100 Brian Starkey wrote: > >> @@ -214,6 +214,19 @@ struct drm_connector_state { > >>struct drm_encoder *best_encoder; > >> > >>struct drm_atomic_state *state; > >> + > >> + /** > >> + * @writeback_job: Writeback job for

Re: [PATCH] drm/atmel-hlcdc : constify drm_plane_helper_funcs and drm_plane_funcs.

On Mon, 3 Jul 2017 21:53:54 +0530 Arvind Yadav wrote: > drm_plane_helper_funcs and drm_plane_funcsare not supposed to change > at runtime. All functions working with drm_plane_helper_funcs and > drm_plane_funcs work with const. So mark the non-const structs as const.

Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers

On Thu, 3 Aug 2017 14:10:50 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > On Thu, 3 Aug 2017 14:58:20 +0300 > Cihangir Akturk <cakt...@gmail.com> wrote: > > > drm_*_reference() and drm_*_unreference() functions are just > > compatibility al

Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.

c() > being called, but it started causing kmalloc issues once we > double-freed the new BO label array. > > Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary > stats") > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by:

Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload.

; Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c

Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

and > support bridges.") > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/v

Re: [PATCH 2/2] drm/vc4: Add exec flags to allow forcing a specific X/Y tile walk order.

) > + positive_x = true; > + if (args->flags & VC4_SUBMIT_CL_RCL_ORDER_INCREASING_Y) > + positive_y = true; > + } Are you sure you want the default value of positive_x/y to be false? It seems to me that before this patch

Re: [PATCH v5 3/6] drm/vc4: Delay DSI host registration until the panel has probed.

d in. > > Signed-off-by: Eric Anholt <e...@anholt.net> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> (v1) Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 38 ++

Re: [PATCH 1/2] drm/vc4: Demote user-accessible DRM_ERROR paths to DRM_DEBUG.

> > Signed-off-by: Eric Anholt <e...@anholt.net> > Fixes: 83753117f1de ("drm/vc4: Add get/set tiling ioctls.") Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_bo.c | 14 +++--- > drivers/gpu/drm/

Re: [PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

On Tue, 18 Jul 2017 14:05:05 -0700 Eric Anholt wrote: > The incoming mode might have a missing vrefresh field if it came from > drmModeSetCrtc(), which the kernel is supposed to calculate using > drm_mode_vrefresh(). We could either use that or the adjusted_mode's > original

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

Hi all, Sorry to enter the discussion so late in the review process. Eric, I'm replying here because this is where the initial discussion happened, but I actually reviewed v5 of your patchset. On Tue, 18 Jul 2017 13:13:04 -0700 Eric Anholt wrote: > Archit Taneja

Re: [PATCH v3 07/22] drm/atmel-hlcdc: Use drm_gem_fb_create()

Le Sun, 13 Aug 2017 15:31:50 +0200, Noralf Trønnes <nor...@tronnes.org> a écrit : > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. > > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> > Signed-

Re: [PATCH 08/16] drm/atmel-hlcdec: Use for_each_new_connector_in_state

On Wed, 12 Jul 2017 10:13:36 +0200 Maarten Lankhorst <maarten.lankho...@linux.intel.com> wrote: > for_each_obj_in_state is about to be removed, so use the new iterator > macros. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Boris Brez

Re: [PATCH 06/41] drm/atmel-hlcdc: Use .dumb_map_offset and .dumb_destroy defaults

Le Sun, 23 Jul 2017 21:16:22 +0200, Noralf Trønnes <nor...@tronnes.org> a écrit : > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> > Signed-

Re: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified

Le Mon, 3 Jul 2017 22:59:36 +0200, Peter Rosin <p...@axentia.se> a écrit : > On 2017-07-03 14:02, Boris Brezillon wrote: > > On Mon, 3 Jul 2017 13:53:28 +0200 > > Peter Rosin <p...@axentia.se> wrote: > > > >> On 2017-07-03 13:31, Boris Brezillon w

Re: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified

On Mon, 3 Jul 2017 11:42:10 +0200 Peter Rosin wrote: > At init and if the gamma_lut property is ever removed, the clut > registers must be programmed with a default gamma ramp instead of > being left in some unknown state. > > Fixes: 364a7bf574eb ("drm: atmel-hlcdc: add

Re: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified

On Mon, 3 Jul 2017 13:53:28 +0200 Peter Rosin <p...@axentia.se> wrote: > On 2017-07-03 13:31, Boris Brezillon wrote: > > On Mon, 3 Jul 2017 11:42:10 +0200 > > Peter Rosin <p...@axentia.se> wrote: > > > >> At init and if the gamma_lut property is

Re: [PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

Le Fri, 04 Aug 2017 14:15:56 -0700, Eric Anholt <e...@anholt.net> a écrit : > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > On Tue, 18 Jul 2017 14:05:05 -0700 > > Eric Anholt <e...@anholt.net> wrote: > > > >> The incoming

Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers

ility functions to use > the new APIs. > > Signed-off-by: Cihangir Akturk <cakt...@gmail.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 > 1 file changed, 4 insertions(+), 4 d

Re: [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.

; > v2: Drop "dev" argument. > > Signed-off-by: Eric Anholt <e...@anholt.net> > Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/d

Re: [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.

On Thu, 11 May 2017 11:31:24 -0700 Eric Anholt <e...@anholt.net> wrote: > Another 100 lines of boilerplate gone, while allowing for bridges to > be connected in the display chain. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.b

Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

able/disable) goes away. > > v2: Fix build with CONFIG_DRM=m, drop "dev" argument that should just > be the panel's dev, move kerneldoc up a level and document > _remove(). > > Signed-off-by: Eric Anholt <e...@anholt.net> > Acked-by: Daniel Vetter

Re: [PATCH v2 4/7] drm/mediatek: Use the panel-bridge helper.

l API > (enable should be when you do things that require the link to be > brought up), but there may be issues here. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > > Note that I

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

On Thu, 11 May 2017 11:31:26 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone. Bridges aren't supported yet, > but will be trivial to add later. > > Signed-off-by: Eric Anholt > --- > [...] > @@ -1082,28 +993,13 @@ int ltdc_load(struct

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

> though. Nice. > > Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> A few comments below (no need to address them, those are just minor things that can be fixed later on, or things I'm not comfortable

Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

On Thu, 11 May 2017 11:31:27 -0700 Eric Anholt <e...@anholt.net> wrote: > drm_encoder_cleanup() finishes with memsetting it to 0, already. > > Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > ---

Re: [PATCH] drm: More links for gamma support helpers

t already explains this > properly. > > Cc: Peter Rosin <p...@axentia.se> > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> &g

Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending().

Le Wed, 21 Jun 2017 11:50:02 -0700, Eric Anholt <e...@anholt.net> a écrit : > It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic > drm_atomic_helper_commit() behavior") > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon &

Re: [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode.

ff-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_kms.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4

Re: [PATCH 1/4] drm/vc4: Hook up plane prepare_fb to lookup dma-buf reservations.

On Wed, 21 Jun 2017 11:49:59 -0700 Eric Anholt <e...@anholt.net> wrote: > This way drm_atomic_helper_wait_for_fences() will actually do > something. The vc4_seqno_cb has been doing the fence waits on V3D > manually, so far. > > Signed-off-by: Eric Anholt <e...@anholt.

Re: [PATCH 11/11] drm: remove unused and redundant callbacks

On Thu, 22 Jun 2017 08:37:55 +0200 Daniel Vetter wrote: > On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > [auto build test ERROR on drm/drm-next] > > [also build test ERROR on next-20170621] > > [cannot apply to v4.12-rc6] > > [if your

Re: [PATCH 3/4] drm/vc4: Use the atomic state's commit workqueue.

ff-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> And with this rework, you also fix the leak I introduced in commit 34c8ea400ff6 ("drm/vc4: Mimic drm_atomic_helper_commit() behavior").

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On Thu, 22 Jun 2017 13:47:43 +0530 Archit Taneja wrote: > On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: > > 2017-06-20 19:31 GMT+02:00 Eric Anholt : > >> Archit Taneja writes: > >> > >>> On 06/16/2017 08:13 PM, Eric Anholt

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On Thu, 22 Jun 2017 14:29:07 +0200 Andrzej Hajda <a.ha...@samsung.com> wrote: > On 22.06.2017 11:23, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 13:47:43 +0530 > > Archit Taneja <arch...@codeaurora.org> wrote: > > > >> On 06/22/2017 01:20 PM, Benjami

Re: [PATCH v5 0/2] drm: atmel-hlcdc: clut support

On Thu, 22 Jun 2017 07:03:09 +0200 Peter Rosin wrote: > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. Applied to drm-misc-next. Thanks, Boris > > Changes since v4: > > - Added .clut_offset for overlay2 at 0xe00 for sama5d4

[PATCH] drm/vc4: Fix VBLANK handling in crtc->enable() path

When we are enabling a CRTC, drm_crtc_vblank_get() is called before drm_crtc_vblank_on(), which is not supposed to happen (hence the WARN_ON() in the code). To solve the problem, we delay the 'update display list' operation after the CRTC is actually enabled. Signed-off-by: Boris Brezillon

Re: [PATCH v3 0/3] drm: atmel-hlcdc: clut support

Le Mon, 19 Jun 2017 09:44:23 +0200, Peter Rosin a écrit : > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. > > I have now tested patch 1 with the below program (modeset.c > adapted from https://github.com/dvdhrm/docs/tree/master/drm-howto

Re: [PATCH v3 2/3] drm/fb-cma-helper: expose more of fb cma guts

Le Mon, 19 Jun 2017 09:44:25 +0200, Peter Rosin a écrit : > DRM drivers supporting clut may want a convenient way to only use > non-default .gamma_set and .gamma_get ops in the drm_fb_helper_funcs > in order to avoid the following > > /* >* The driver really

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On Fri, 23 Jun 2017 09:22:15 +0200 Andrzej Hajda <a.ha...@samsung.com> wrote: > On 22.06.2017 15:34, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 15:16:47 +0200 > > Andrzej Hajda <a.ha...@samsung.com> wrote: > > > >> On 22.06.2017 14:41, Boris Brezi

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On Thu, 22 Jun 2017 15:16:47 +0200 Andrzej Hajda <a.ha...@samsung.com> wrote: > On 22.06.2017 14:41, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 14:29:07 +0200 > > Andrzej Hajda <a.ha...@samsung.com> wrote: > > > >> On 22.06.2017 11:23, Boris Brezi

Re: [PATCH v5 0/2] drm: Introduce writeback connectors

Hi Liviu, On Mon, 15 May 2017 18:20:55 +0100 Liviu Dudau <liviu.du...@arm.com> wrote: > Hi, > > This is v5 of the writeback connector series. Boris Brezillon thought > that having to explicitly instantiate an encoder when using > drm_writeback_connector > is a bi

Re: [PATCH v5 0/2] drm: Introduce writeback connectors

On Tue, 23 May 2017 15:38:42 +0100 Liviu Dudau <liviu.du...@arm.com> wrote: > On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote: > > Hi Liviu, > > Hi Boris, > > > > > On Mon, 15 May 2017 18:20:55 +0100 > > Liviu Dudau &l

Re: [PATCH 13/37] drm: better document how to send out the crtc disable event

On Wed, 24 May 2017 16:51:48 +0200 Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > The kernel doc explained what needs to happen, but not how to most > easily accomplish that using the functions. Fix that. > > Cc: Boris Brezillon <boris.brezil...@free-electrons.com>

Re: [PATCH 17/37] drm/atmel: Drop drm_vblank_cleanup

misplace malidp hunk (Liviu). > > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

Hi Philippe, Le Tue, 30 May 2017 16:55:42 +, Philippe CORNU a écrit : > Hi Eric, > > I took your patch for the panel-bridge and it works perfectly in both > DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-) I still don't understand how it can

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

Hi Archit, Le Wed, 31 May 2017 13:31:16 +0530, Archit Taneja <arch...@codeaurora.org> a écrit : > Hi Boris, > > On 05/31/2017 11:56 AM, Boris Brezillon wrote: > > Hi Philippe, > > > > Le Tue, 30 May 2017 16:55:42 +, > > Philippe CORNU <philippe.

Re: [PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback

se Abreu <joab...@synopsys.com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> > Cc: David Airlie <airl...@linux.ie> > --- > drivers/gpu/drm/atmel-hl

Re: [PATCH] drm/vc4: Mark the device as active when enabling runtime PM.

t> > Fixes: 553c942f8b2c ("drm/vc4: Allow using more than 256MB of CMA memory.") Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/v

[PATCH 2/7] drm/vc4: Fix vblank handling

-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gpu/drm/vc4/vc4_crtc.c | 80 ++ 1 file changed, 57 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index d86c8c

[PATCH 1/7] drm: Add drm_atomic_helper_wait_for_flip_done()

Add an helper to wait for all page flips of an atomic state to be done. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gpu/drm/drm_atomic_helper.c | 30 ++ include/drm/drm_atomic_helper.h | 3 +++ 2 files changed, 33 inse

[PATCH 5/7] drm/vc4: Add support for the TXP (transposer) block

passed. In order to make things work, we have to detect when the TXP is enabled, avoid enabling the PV when this is the case, and generate fake VBLANK events when the TXP is done writing the frame back to memory. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers

[PATCH 4/7] drm/vc4: Use drm_atomic_helper_wait_for_flip_done()

' problem that can arise when the CRTC is configured in oneshot mode (only a single frame is generated and the CRTC is immediately paused after this frame). Note that this oneshot mode will be used for the writeback connector feature. Signed-off-by: Boris Brezillon <boris.brezil...@f

[PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

The VC4 KMS driver is implementing its own ->atomic_commit() but there are a few generic helpers we can use instead of open-coding the logic. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gpu/drm/vc4/vc4_kms.c | 38 -

[PATCH 6/7] dt-bindings: Document the VC4 TXP module nodes.

These are part of the vc4 display pipeline. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,b

[PATCH 0/7] drm/vc4: Add writeback support to the VC4 driver

/tree/master Boris Brezillon (7): drm: Add drm_atomic_helper_wait_for_flip_done() drm/vc4: Fix vblank handling drm/vc4: Mimic drm_atomic_helper_commit() behavior drm/vc4: Use drm_atomic_helper_wait_for_flip_done() drm/vc4: Add support for the TXP (transposer) block dt-bindings: Document

[PATCH 7/7] ARM: dts: bcm283x: Add Transposer block

The transposer block is allowing one to write the result of the VC4 composition back to memory. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/boot/dts/bcm283x.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi

[PATCH 1/2] drm/bridge: Add Cadence DSI driver

Add a driver for Cadence DPI -> DSI bridge. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gpu/drm/bridge/Kconfig|7 + drivers/gpu/drm/bridge/Makefile |1 + drivers/gpu/drm/bridge/cdns-dsi.c | 1087 +

[PATCH 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

Document the bindings used for the Cadence DSI bridge. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- .../bindings/display/bridge/cdns,dsi.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bi

Re: [PATCH v5 0/3] drm/mali-dp: Add support for memory writeback engine

back connectors" series [1] > > This version updates the Mali DP code to remove the bespoke encoder used > with the drm_writeback_connector and instead rely on the builtin one from > the v5 series. > > v4 series can be found here [2]. Whole series is Reviewed-by: Boris Brezillo

[PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

Document the bindings used for the Cadence DSI bridge. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- .../bindings/display/bridge/cdns,dsi.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bi

[PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

Add a driver for Cadence DPI -> DSI bridge. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - rebase on v4.12-rc1 and adapt to driver to the drm_bridge API changes - return the correct error when devm_clk_get(sysclk) fails - add missin

Re: [PATCH 1/2] drm/bridge: Add Cadence DSI driver

ed to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-Add-Cadence-DSI-driver/20170602-162006 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > for-

Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

On Sat, 3 Jun 2017 23:43:17 +0530 Archit Taneja <arch...@codeaurora.org> wrote: > Hi, > > On 06/02/2017 05:34 PM, Boris Brezillon wrote: > > Document the bindings used for the Cadence DSI bridge. > > > > Signed-off-by: Boris Brezillon &l

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

Hi Archit, On Mon, 5 Jun 2017 21:06:20 +0530 Archit Taneja wrote: > Hi, > > When pushing to drm-misc-next, I got a minor merge conflict when dim tried > to rebuild drm-tip. > > The reason for the conflict was because the following commit was present > in drm-tip but

Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

On Tue, 6 Jun 2017 16:30:15 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > On 02/06/17 15:04, Boris Brezillon wrote: > > > +enum cdns_dsi_output_type { > > + CDNS_DSI_PANEL = 0, > > + CDNS_DSI_BRIDGE = 1, > > +}; > > Just my opinion,

Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

On Tue, 6 Jun 2017 16:01:45 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > On 06/06/17 15:37, Boris Brezillon wrote: > > Hi Tomi, > > > > On Tue, 6 Jun 2017 15:30:26 +0300 > > Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > >

Re: [PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

+Gustavo On Tue, 06 Jun 2017 13:27:09 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > The VC4 KMS driver is implementing its own ->atomic_commit() but there > > are a few generic helpers we can use

Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

On Thu, 15 Jun 2017 11:24:13 +0200 Peter Rosin wrote: > From: Peter Rosin > > Remove the layer. Duh. It was present in the datasheet I had. Just downloaded last version of the datasheet and it's no longer there. Nicolas, there's still a reference to OVR2

Re: Color lookup support for the atmel-hlcdc driver

On Thu, 15 Jun 2017 13:47:35 +0200 Peter Rosin <p...@axentia.se> wrote: > On 2017-06-15 12:15, Boris Brezillon wrote: > > On Thu, 15 Jun 2017 11:54:29 +0200 > > Peter Rosin <p...@axentia.se> wrote: > > > >> On 2017-06-13 17:30, Boris Brezillon wrote

Re: Color lookup support for the atmel-hlcdc driver

On Thu, 15 Jun 2017 11:54:29 +0200 Peter Rosin <p...@axentia.se> wrote: > On 2017-06-13 17:30, Boris Brezillon wrote: > > Hi Peter, > > > > On Tue, 13 Jun 2017 16:34:25 +0200 > > Peter Rosin <p...@axentia.se> wrote: > > > >> Hi! > >&

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Le Sat, 17 Jun 2017 00:46:12 +0200, Peter Rosin a écrit : > Hm, it's probably too late to do it here. Planes have already been > enabled and the engine may have started to fetch data and do the > composition. You could do that in ->update_plane() [1], and make it

Re: [PATCH 2/7] drm/vc4: Fix vblank handling

On Thu, 15 Jun 2017 16:30:58 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > There are two problems related to VBLANK handling in the current CRTC > > driver: > > > > * VBLANK events

[PATCH v2] drm/vc4: Send a VBLANK event when disabling a CRTC

VBLANK events are missed when the CRTC is being disabled because the driver does not wait till the end of the frame before stopping the HVS and PV blocks. In this case, we should explicitly issue a VBLANK event if there's one waiting. Signed-off-by: Boris Brezillon <boris.brezil...@f

Re: [PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

On Thu, 15 Jun 2017 16:33:11 -0700 Eric Anholt <e...@anholt.net> wrote: > Eric Anholt <e...@anholt.net> writes: > > > [ Unknown signature status ] > > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > >> On Tue, 06 Jun 20

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hi Peter, On Fri, 16 Jun 2017 11:12:25 +0200 Peter Rosin wrote: > All layers of chips support this, the only variable is the base address > of the lookup table in the register map. > > Signed-off-by: Peter Rosin > --- >

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hi Peter, On Fri, 16 Jun 2017 17:54:04 +0200 Peter Rosin <p...@axentia.se> wrote: > On 2017-06-16 12:01, Boris Brezillon wrote: > > Hi Peter, > > > > On Fri, 16 Jun 2017 11:12:25 +0200 > > Peter Rosin <p...@axentia.se> wrote: > > > >&g

Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

On Tue, 13 Jun 2017 11:02:47 +0200 Andrzej Hajda <a.ha...@samsung.com> wrote: > Hi, > > Just spotted this thread. > > On 06.06.2017 14:58, Tomi Valkeinen wrote: > > On 06/06/17 15:48, Boris Brezillon wrote: > > > >> Okay. Thanks for the clarif

Re: [PATCH v3 0/3] drm: atmel-hlcdc: clut support

+Alexandre and Nicolas Hi Peter, Can you please Cc at91 maintainers next time? On Mon, 19 Jun 2017 09:44:23 +0200 Peter Rosin wrote: > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. > > I have now tested patch 1 with the below program

Re: [PATCH 2/2] drm/vc4: Add get/set tiling ioctls.

Hi Eric, On Wed, 7 Jun 2017 17:13:36 -0700 Eric Anholt wrote: > This allows mesa to set the tiling format for a BO and have that > tiling format be respected by mesa on the other side of an > import/export (and by vc4 scanout in the kernel), without defining a > protocol to

Re: [PATCH 1/2] drm/vc4: Add T-format scanout support.

fail to do so for untiled buffers already. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_plane.c | 31 +++ > drivers/gpu/drm/vc4/vc4_regs.h |

Re: Color lookup support for the atmel-hlcdc driver

Hi Peter, On Tue, 13 Jun 2017 16:34:25 +0200 Peter Rosin wrote: > Hi! > > I need color lookup support for the atmel-hlcdc driver, and had a peek > at the code. I also looked at the drivers/gpu/drm/stm driver and came > up with the below diff. It compiles, but I have not booted

Re: [PATCH 1/6] drm: Add writeback connector type

On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: > +/** > + * drm_writeback_connector_init - Initialize a writeback connector and its > properties > + * @dev: DRM device > + * @wb_connector: Writeback connector to initialize > + * @funcs: Connector funcs vtable > +

[PATCH] drm/atmel-hlcdc: Fix output initialization

the atmel_hlcdc_rgb_output allocation after the panel/bridge detection to avoid useless allocations. Reported-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge") Signed-off-by: Boris Brezillon <boris.brezil...

Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

Hi Tomi, On Tue, 6 Jun 2017 15:30:26 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > On 02/06/17 15:04, Boris Brezillon wrote: > > Document the bindings used for the Cadence DSI bridge. > > > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.

Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

On Tue, 6 Jun 2017 15:40:25 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > On 06/06/17 12:35, Boris Brezillon wrote: > > On Sat, 3 Jun 2017 23:43:17 +0530 > > Archit Taneja <arch...@codeaurora.org> wrote: > > > >> Hi, > >>

[PATCH] drm/atmel-hlcdc: Fix panel registration

Attach the panel-bridge created by drm_panel_bridge_add() to the parallel RGB encoder. Fixes: 96160a8071b2 ("drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.") Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gpu/drm/atmel-hlcdc/atme

Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

Hi Archit, On Sun, 4 Jun 2017 00:20:06 +0530 Archit Taneja wrote: > > + > > +#define DPHY_CFG0 0x1b0 > > +#define DPHY_C_RSTBBIT(20) > > +#define DPHY_D_RSTB(x) ((x) << 16) > > +#define DPHY_TIF_FORCE_WRITE

Re: [PATCH 5/7] drm/vc4: Add support for the TXP (transposer) block

Hi Brian, Le Mon, 5 Jun 2017 12:25:50 +0100, Brian Starkey a écrit : > Hi Boris, > > I can't speak for the HW-specific details, but the writeback part > looks pretty good (and familiar ;-) to me. There certainly seems to be > some scope for code-sharing there, but I

Re: [PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

On Tue, 06 Jun 2017 13:27:09 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > The VC4 KMS driver is implementing its own ->atomic_commit() but there > > are a few generic helpers we can use

Re: [PATCH 4/7] drm/vc4: Use drm_atomic_helper_wait_for_flip_done()

On Tue, 06 Jun 2017 13:24:33 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > Replace the drm_atomic_helper_wait_for_vblanks() with a call to > > drm_atomic_helper_wait_for_flip_done(). This allows bet

Re: [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable()

-- > drivers/gpu/drm/arm/malidp_crtc.c | 5 +++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 +++-- For atmel-hlcdc: Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> ___ dri-devel mailing list dri-devel@

<    2   3   4   5   6   7   8   9   10   11   >