[Adding Sam, who is helping to review/collect panel-simple patches]
On Tue, May 7, 2019 at 12:27 PM Sébastien Szymanski
wrote:
>
> This patch adds support for the Armadeus ST0700 Adapt. It comes with a
> Santek ST0700I5Y-RBSLW 7.0" WVGA (800x480) TFT and an adapter board so
> that it can be
On Wed, Jun 26, 2019 at 7:21 AM Robert Chiras wrote:
>
> Add dt-bindings documentation for Raydium RM67191 DSI panel.
>
> Signed-off-by: Robert Chiras
> Reviewed-by: Sam Ravnborg
Reviewed-by: Fabio Estevam
___
dri-devel mailing
Hi Robert,
On Wed, Jun 26, 2019 at 7:21 AM Robert Chiras wrote:
>
> This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> protocol).
>
> Signed-off-by: Robert Chiras
> Reviewed-by: Sam Ravnborg
Looks good to me:
Reviewed-by: Fabio Estevam
Thanks
Hi Lucas,
On Thu, Jun 27, 2019 at 11:44 AM Lucas Stach wrote:
>
> When something goes wrong in the GPU init after the cmdbuf suballocator
> has been constructed, we fail to destory it properly. This causes havok
s/destory/destroy
> later when the GPU is unbound due to a module unload or
Hi Sam,
On Mon, Apr 1, 2019 at 3:24 PM Sam Ravnborg wrote:
> panel-simple support for VXT VL050-8048NT-C01 panel - Fabio Estevam
>
Any chance to get this one to kernel 5.2?
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
Hi Guido,
On Wed, Jul 31, 2019 at 11:35 AM Guido Günther wrote:
> The idea is to have
>
> "%sabling platform clocks", enable ? "en" : "dis");
>
> depending whether clocks are enabled/disabled.
Yes, I understood the idea, but this would print:
ensabling or dissabling :-)
> > Same here.
Hi Jonathan,
On Tue, Sep 3, 2019 at 4:25 PM Jonathan Marek wrote:
>
> Hi,
>
> I tried this and it works with patches 4+5 from Rob's series and
> changing gpummu to use sg_phys(sg) instead of sg->dma_address
> (dma_address isn't set now that dma_map_sg isn't used).
Thanks for testing it. I
Hi Rob,
On Tue, Sep 3, 2019 at 9:12 PM Rob Clark wrote:
> In the mean time, it is a bit ugly, but I guess something like this should
> work:
Yes, this works on a i.MX53 board, thanks:
Tested-by: Fabio Estevam
Is this something you could submit for 5.3?
Hi,
I am getting the following crash when booting the adreno driver on
i.MX53 running a 5.3-rc6 kernel.
Such error does not happen with 5.2 though.
Before I start running a bisect, I am wondering if anyone has any
ideas about this issue.
Thanks,
Fabio Estevam
[2.083249] 8<--- cut h
commit 141db5703c887f46957615cd6616ca28fe4691e0 (HEAD)
Author: Fabio Estevam
Date: Mon Sep 2 14:58:18 2019 -0300
Revert "drm/msm: stop abusing dma_map/unmap for cache"
This reverts commit 0036bc73ccbe7e600a3468bf8e8879b122252274.
commit fa5b1f620f2984c254877d6049214c39c24c8207
Author: Fab
d.
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 048c8be426f3..73c79f1614c1 100644
--- a/drivers/gpu/drm/
On Wed, Jul 31, 2019 at 1:40 PM Jernej Škrabec wrote:
> > Yes, I understood the idea, but this would print:
> >
> > ensabling or dissabling :-)
>
> No, it wouldn't. That extra "s" is part of "%s", e.g. part of format
> specifier.
Ops, you are right. Sorry about that!
t is ipuv3-crtc.o that is built via imxdrm-objs, not
imx-ipuv3-crtc.o.
Apart from that:
Reviewed-by: Fabio Estevam
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sébastien,
On Mon, Jul 29, 2019 at 11:14 AM Sébastien Szymanski
wrote:
> config DRM_MXSFB
> - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller"
> + tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller"
This IP is also found on i.MX6SL, i.MX7D, i.MX7S, i.MX8M,
Hi Sam,
On Mon, Jul 29, 2019 at 11:37 AM Sam Ravnborg wrote:
> Could we throw a COMPILE_TEST in the mix so we get better build
> coverage too?
There is no architecture dependency to build this driver, so we
already have build coverage for it.
Regards,
Fabio E
Improve the help text for DRM_ANALOGIX_ANX78XX by adding the missing
"power" word.
After this change the help text matches with the ANX7814
product description from the Analogix website:
https://www.analogix.com/en/products/convertersbridges/anx7814
Signed-off-by: Fabio Estevam
--
Hi Guido,
Thanks for your work on this driver!
On Wed, Jul 24, 2019 at 12:52 PM Guido Günther wrote:
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/imx-nwl/Kconfig
> @@ -0,0 +1,15 @@
> +config DRM_IMX_NWL_DSI
> + tristate "Support for Northwest Logic MIPI DSI Host controller"
> +
There is no need for brackets for a single line inside the 'if' block,
so remove the unneeded brackets.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Fix typo in commit log
drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
There is no need for brackets when for a single line inside
the 'if' block, so remove the unneeded brackets.
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
b
Hi Rob,
On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo wrote:
>
> On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam wrote:
> >
> > Booting the adreno driver on a imx53 board leads to the following
> > error message:
> >
> > adreno 3000.gpu: [drm:adreno_gpu_
Hi Jordan,
On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse wrote:
> I'm good with this. This really should only be around for
> compatibility with downstream device tree files which should mean nothing for
> I.MX5.
May I resend it with your Reviewed-by tag?
Thanks
d.
Signed-off-by: Fabio Estevam
Reviewed-by: Jeffrey Hugo
Reviewed-by: Jordan Crouse
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 07
d.
Signed-off-by: Fabio Estevam
Reviewed-by: Jeffrey Hugo
Reviewed-by: Jordan Crouse
---
Trying once again :-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
b/drivers/gpu/drm/msm/adreno/ad
d.
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 0783e4b5486a..5d7bdb4c83cc 100644
--- a/drivers/gpu/drm/
On Wed, Oct 23, 2019 at 11:16 AM Adam Ford wrote:
> What is the plan to address the regression for 5.4? I wasn't sure if
> we're going to apply the i.mx fixes or temporarily revert the
> offending patch, or something else. (or maybe nothing at all)
Yes, I do see the regression on a imx53 board
Hi Adrian,
On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu
wrote:
Some nitpicks:
> +
> +config DRM_IMX_MIPI_DSI
> + tristate "Freescale i.MX DRM MIPI DSI"
This text seems too generic as there are i.MX SoCs that use different
MIPI DSI IP.
Maybe "Freescale i.MX6 DRM MIPI DSI" instead?
>
Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
> Control: 10c5387d Table: 70004019 DAC: 0051
> Process swapper/0 (pid: 1, stack limit = 0x(ptrval))
>
> Signed-off-by: Rob Clark
> Fixes: 3de433c5b38a ("drm/msm: Use the correct dma_sync calls
Hi Rob,
On Tue, Oct 8, 2019 at 8:08 PM Rob Clark wrote:
> afaict this should be at least in v5.4-rc2.. am I missing something?
You are right, it is in 5.4-rc indeed, sorry.
It is 5.3.x stable that has this commit missing, but I guess it will
be backported at some point.
Thanks!
Hi Rob,
On Tue, Dec 10, 2019 at 8:12 PM Fabio Estevam wrote:
>
> Booting the adreno driver on a imx53 board leads to the following
> error message:
>
> adreno 3000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU
> powerlevels
>
> As the "qcom,gpu-pw
The hardcoded '12' means the number of elements in the
adv7511_csc_ycbcr_to_rgb[] array, so use the ARRAY_SIZE() macro
to let the code less error prone.
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 16
1 file changed, 8 insertions(+), 8
ean Cross
> Cc: Shawn Guo
> Cc: Fabio Estevam
The freescale.com domain is gone for quite some time.
Please use nxp.com instead or feste...@gmail.com.
Otherwise the patch looks good.
Thanks
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
vreresh is
> correct?
>
> Cc: Fabio Estevam
> Cc: Sam Ravnborg
> Cc: Thierry Reding
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/pa
Hi Laurent,
On Mon, Mar 9, 2020 at 4:53 PM Laurent Pinchart
wrote:
> config DRM_MXSFB
> - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller"
> + tristate "i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB LCD controller"
Can't we just make it simpler and write: tristate "i.MX eLCDIF
:
Warning (unit_address_vs_reg): /example-0/dsi: node has a reg or ranges
property, but no unit name
Fix it by removing the unneeded 'reg' property.
Signed-off-by: Fabio Estevam
---
.../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml| 1 -
1 file changed, 1 deletion(-)
:
Warning (unit_address_vs_reg): /example-0/dsi: node has a reg or ranges
property, but no unit name
Fix it by removing the unneeded 'reg' property.
Fixes: 52120e8c7ae3 ("dt-bindings: display: fix panel warnings")
Signed-off-by: Fabio Estevam
---
.../devicetree/bindings/display/panel/
On Mon, Mar 30, 2020 at 8:35 AM Adrian Ratiu wrote:
> +panel@0 {
> +compatible = "sharp,ls032b3sx01";
> +reg = <0>;
> +reset-gpios = < 8 GPIO_ACTIVE_LOW>;
> +ports {
> +port@0 {
There is a unit address here without a
Hi Adrian,
On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu wrote:
>
> This adds support for the Synopsis DesignWare MIPI DSI v1.01 host
> controller which is embedded in i.MX 6 SoCs.
>
> Based on following patches, but updated/extended to work with existing
> support found in the kernel:
>
> - drm:
bisecting this yet, but just checking if anyone has
any ideas first.
Thanks,
Fabio Estevam
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Lubomir,
On Wed, May 13, 2020 at 12:08 PM Lubomir Rintel wrote:
> /* Get Clocks: */
> - gpu->clk_reg = devm_clk_get(>dev, "reg");
> + gpu->clk_reg = devm_clk_get_optional(>dev, "reg");
> DBG("clk_reg: %p", gpu->clk_reg);
> if (IS_ERR(gpu->clk_reg))
> -
On Wed, May 13, 2020 at 12:08 PM Lubomir Rintel wrote:
>
> There might be good reasons why the getting a clock failed. To treat the
> clocks as optional we're specifically only interested in ignoring -ENOENT,
> and devm_clk_get_optional() does just that.
>
> Signed-off-by: Lubomir Rintel
> ---
>
On Wed, May 13, 2020 at 2:09 PM Fabio Estevam wrote:
> The binding doc Documentation/devicetree/bindings/gpu/vivante,gc.yaml
> says that only the 'reg' clock could be optional, the others are
> required.
arch/arm/boot/dts/dove.dtsi only uses the 'core' clock.
arch/arm/boot/dts/stm32m
On Fri, Mar 20, 2020 at 3:49 PM Guido Günther wrote:
>
> The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 SoCs.
>
> Signed-off-by: Guido Günther
> Tested-by: Robert Chiras
> Reviewed-by: Rob Herring
> Acked-by: Sam Ravnborg
Revie
rem 5 devkit using mxsfb.
>
> Signed-off-by: Guido Günther
> Co-developed-by: Robert Chiras
> Signed-off-by: Robert Chiras
> Tested-by: Robert Chiras
> Tested-by: Martin Kepplinger
Reviewed-by: Fabio Estevam
___
dri-devel mailing
Hi Stefan,
On Tue, Sep 8, 2020 at 9:56 AM Stefan Agner wrote:
>
> The lcdif IP does not support a framebuffer pitch (stride) other than
> framebuffer width. Check for equality and reject the framebuffer
> otherwise.
>
> This prevents a distorted picture when using 640x800 and running the
> Mesa
ADMA
[1.721418] mxsfb 3032.lcd-controller: [drm:mxsfb_probe]
*ERROR* failed to attach bridge: -517
[1.730422] mxsfb 3032.lcd-controller: Cannot connect bridge: -517
Any ideas as to what I am missing?
Thanks,
Fabio Estevam
___
dri-devel
On Mon, Sep 14, 2020 at 10:52 AM Fabio Estevam wrote:
>
> Hi Martin and Guido,
>
> I am trying to get MIPI DSI panel to work on an imx8mq-evk board.
>
> Here are the changes I did against linux-next 20200914 following what
> was done on imx8mq-librem5-devkit.dts:
>
not select CONFIG_PM_SLEEP.
Reported-by: Olof's autobuilder
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c
b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index
Hi Lucas,
On Mon, Aug 24, 2020 at 8:02 AM Lucas Stach wrote:
>
> The drm scheduler currently expects that the stop/start sequence is always
> executed in the timeout handling, as the job at the head of the hardware
> execution list is always removed from the ring mirror before the driver
>
Hi Alexandre,
On Thu, Sep 24, 2020 at 5:16 PM Alexandru Gagniuc wrote:
> + ret = regulator_enable(sii902x->cvcc12);
> + if (ret < 0) {
> + dev_err(dev, "Failed to enable cvcc12 supply: %d\n", ret);
> + regulator_disable(sii902x->iovcc);
> +
Hi Guido,
On Mon, Sep 21, 2020 at 1:56 PM Guido Günther wrote:
>
> We need to reset both for the panel to show an image.
There is a typo in "resets" in the Subject line.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
"", line 45, column 3
Remove the double occurrence to fix this problem.
Fixes: 13871279ff5c ("arm64: dts: allwinner: h6: Fix Cedrus IOMMU usage")
Signed-off-by: Fabio Estevam
---
.../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 3 ---
1 file changed, 3 deletions
Pass the sysreg unit name to fix the following warning seen with
'make dt_binding_check':
Warning (unit_address_vs_reg): /example-0/sysreg: node has a reg or ranges
property, but no unit name
Signed-off-by: Fabio Estevam
---
.../bindings/display/panel/arm,versatile-tft-panel.yaml | 2
On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote:
>
> The LogicPD Type28 display used by several Logic PD products has not
> worked since v5.5.
Maybe you could tell which commit exactly and then put a Fixes tag?
___
dri-devel mailing list
copied for a new driver.
This IP is also present on i.MX7ULP, which is 32-bit, but not supported yet.
Thanks for taking care of this.
Reviewed-by: Fabio Estevam
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Add an entry for the "mxsfb-drm" driver, so that the test utilities
work with the mxsfb driver without passing the -M argument.
Signed-off-by: Fabio Estevam
---
tests/util/kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/kms.c b/tests/util/kms.c
index 08
Hi Oliver,
On Fri, Jan 8, 2021 at 7:24 PM Oliver Graute wrote:
>
> On 19/12/20, Oliver Graute wrote:
> > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD
> > to panel-simple.
> >
> > The panel spec from Variscite can be found at:
> >
Hi Oliver,
On Sun, Jan 10, 2021 at 12:35 PM Oliver Graute wrote:
> the first two errors are gone. But I still get this:
>
> [ 42.387107] mxsfb 21c8000.lcdif: Cannot connect bridge: -517
>
> The panel is still off perhaps I miss something else.
Some suggestions:
- Take a look at
On Sun, Jan 10, 2021 at 5:09 PM Oliver Graute wrote:
> here the schematics and my dts. The board is using a LVDS connector for
> the display.
The schematics shows the GKTW70SDAD1SD panel in the J4 connector, not
the LVDS J7 connector.
>
Hi Phillip,
On Tue, Jan 19, 2021 at 11:08 AM Philipp Zabel wrote:
>
> Only planes that are displayed via the Display Processor (DP) path
> support color space conversion. Limit formats on planes that are
> shown via the direct Display Controller (DC) path to RGB.
>
> Reported
Hi Jani,
On Thu, Jan 21, 2021 at 8:22 AM Jani Nikula wrote:
> Sean, Rob, or anyone with an arm toolchain for msm available, could I
> trouble you to build test this please?
I tried to build after applying your patch:
CC drivers/gpu/drm/msm/dp/dp_ctrl.o
drivers/gpu/drm/msm/dp/dp_ctrl.c:
On Thu, Jan 21, 2021 at 9:10 AM Jani Nikula wrote:
> Kinda catch-22 because next has dropped current drm-intel-next because
> it doesn't build because of the issue this patch fixes. ;)
Ok, so I built drm-intel-next and I was able to reproduce the buid
error as reported by Stephen.
Applied this
Hi Oleksij,
On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel wrote:
>
> At some point PWM cell count was changed, but it didn't triggered any
It changed in this commit:
commit fa28d8212ede9c533ae87a737571a9d3b3eebb29
Author: Uwe Kleine-König
Date: Fri Jul 10 07:19:37 2020 +0200
ARM: dts:
On Thu, Jan 21, 2021 at 8:41 AM Jani Nikula wrote:
> On top of what? Current drm-tip?
It was on top of next-20210121.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Sat, Jan 16, 2021 at 9:49 AM Oliver Graute wrote:
> > power-supply = <_touch_3v3> is not correct, as the reg_touch_3v3
> > does not power the LCD.
>
> yes, but how is the LCD correctly powered then?
J4 is powered by VCC_5V and VCC_3V#.
> [7.795980] pwm-backlight backlight: supply power
Hi Oliver,
On Mon, Jan 25, 2021 at 6:29 PM Oliver Graute wrote:
> Ok I fixed the pin conflict with regulator-gpio and added a 5V
> regulator node in my dts file. Now the display is working fine!
That's good news :-)
> I'll post the dts files soon and check if there is something to
> improve
l+0xa4/0x1b0
Fix the problem by calling drm_atomic_helper_shutdown() conditionally.
Cc:
Fixes: 9d5cbf5fe46e ("drm/msm: add shutdown support for display
platform_driver")
Suggested-by: Rob Clark
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/msm/msm_drv.c | 3 ++-
1 file changed, 2
Hi Rob,
On Tue, Jan 19, 2021 at 1:40 PM Rob Clark wrote:
> > I suppose we should do the drm_atomic_helper_shutdown() conditionally?
This suggestion works, thanks. I will submit a patch shortly.
Thanks
___
dri-devel mailing list
0
Fix the problem by calling drm_atomic_helper_shutdown() conditionally.
Cc:
Fixes: 9d5cbf5fe46e ("drm/msm: add shutdown support for display
platform_driver")
Suggested-by: Rob Clark
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Explain in the commit log that the problem happens
317743] LR is at commit_tail+0xa4/0x1b0
Fix the problem by calling drm_mode_config_helper_suspend/resume()
conditionally.
Cc:
Fixes: ca8199f13498 ("drm/msm/dpu: ensure device suspend happens during PM
sleep")
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Newly introduce
0
Fix the problem by calling drm_atomic_helper_shutdown() conditionally.
Cc:
Fixes: 9d5cbf5fe46e ("drm/msm: add shutdown support for display
platform_driver")
Suggested-by: Rob Clark
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Explain in the commit log that the problem happens
nimum fix so that it can reach upstream and also stable-trees
(5.4 and 5.10)?
I am glad to work on a more generic solution that would also fix the
suspend/resume case. Just need some more guidance on that as I am not
familiar with this area.
Thanks,
F
Adding some more folks in case anyone has any suggestions to fix this
reboot hang.
Thanks
On Tue, Jan 12, 2021 at 5:07 PM Fabio Estevam wrote:
>
> Hi,
>
> I have noticed that on an imx53-qsb, it is no longer possible to
> reboot the system as it fails like this:
>
> Req
On Mon, Jan 18, 2021 at 6:44 PM Fabio Estevam wrote:
>
> Adding some more folks in case anyone has any suggestions to fix this
> reboot hang.
Not sure if this is a valid fix, but the change below makes reboot
works correctly.
kmscube still works.
--- a/drivers/gpu/drm/msm/msm_atomi
nit!
exitcode=0x
[ 25.678331] ---[ end Kernel panic - not syncing: Attempted to kill
init! exitcode=0x ]---
It happens on 5.4 as well as 5.11-rc2.
Any ideas?
Thanks,
Fabio Estevam
___
dri-devel mailing list
dri-devel@lists.freedesktop.
Hi Oliver,
On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute wrote:
> I would prefer mine, because I got a wrong colored penguin on bootup
> with yours :-)
I have originally passed .bpc = 8, but looking at the panel datasheet,
this should be:
.bpc = 6 instead.
In your patch, you pass the timing
Hi Rob,
Any comments on this series, please?
On Tue, Jan 19, 2021 at 8:15 PM Fabio Estevam wrote:
>
> Issuing a 'reboot' command in i.MX5 leads to the following flow:
>
> [ 24.557742] [] (msm_atomic_commit_tail) from []
> (commit_tail+0xa4/0x1b0)
> [ 24.566349] []
Hi Jagan,
On Thu, Jun 24, 2021 at 9:32 AM Jagan Teki wrote:
> > I had a brief look at the exynos driver, and I think it should be turned
> > into a DRM bridge as part of this rework to be used with the i.MX8MM.
> >
> > Is there someone from Samsung who could assist, at least to test the
> >
Hi Jagan/Laurent,
On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart
wrote:
> Looking at the register set, it seems to match the Exynos 5433,
> supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage
> that driver instead of adding a new one for the same IP core ?
Yes. there was an
Hi Arnd,
On Tue, Mar 23, 2021 at 10:05 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> When CONFIG_OF is disabled, building with 'make W=1' produces warnings
> about out of bounds array access:
>
> drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop':
>
The retrieval of driver data can be a bit simplified by using
device_get_match_data(), so switch to it.
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/imx/dcss/dcss-dev.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-dev.c
b/drivers
eb02007f 5401 (f9400285)
[ 66.874525] ---[ end trace 20dedb2a3229fec8 ]---
Fixes: 9d5cbf5fe46e ("drm/msm: add shutdown support for display
platform_driver")
Signed-off-by: Dmitry Baryshkov
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/msm/msm_drv.c | 4
1 file changed, 4
317743] LR is at commit_tail+0xa4/0x1b0
Fix the problem by calling drm_mode_config_helper_suspend/resume()
only when priv->kms is available.
Fixes: ca8199f13498 ("drm/msm/dpu: ensure device suspend happens during PM
sleep")
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/msm/msm_dr
Hi Rob,
On Fri, Mar 19, 2021 at 11:44 AM Rob Clark wrote:
> I think that might not help if something fails to probe due to (for
> example) a missing dependency, so !priv->kms is probably a better
> check to cover both cases. But the 2nd patch makes a good point, that
> the suspend/resume path
On Fri, Mar 19, 2021 at 12:13 PM Fabio Estevam wrote:
> Thanks for the feedback.
> I will follow the same approach for fixing the suspend/resume path then.
>
> Let me test it and then I will re-submit Dmitry's patch and the one
> for suspend/resume as part of a patch series.
This
eb02007f 5401 (f9400285)
[ 66.874525] ---[ end trace 20dedb2a3229fec8 ]---
Fixes: 9d5cbf5fe46e ("drm/msm: add shutdown support for display
platform_driver")
Signed-off-by: Dmitry Baryshkov
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None, only added freedr...@lists.freedesktop
317743] LR is at commit_tail+0xa4/0x1b0
Fix the problem by calling drm_mode_config_helper_suspend/resume()
only when priv->kms is available.
Fixes: ca8199f13498 ("drm/msm/dpu: ensure device suspend happens during PM
sleep")
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
Hi Dmitry,
On Mon, Mar 1, 2021 at 6:41 PM Dmitry Baryshkov
wrote:
> diff --git a/drivers/gpu/drm/msm/msm_atomic.c
> b/drivers/gpu/drm/msm/msm_atomic.c
> index 6a326761dc4a..2fd0cf6421ad 100644
> --- a/drivers/gpu/drm/msm/msm_atomic.c
> +++ b/drivers/gpu/drm/msm/msm_atomic.c
> @@ -207,7 +207,12
.height = 86,
> + },
> + .delay = {
> + .prepare = 20 + 20 + 10 + 10,
Adding the datasheet label like Marco suggested make it clearer where
these numbers come from : /* T0 + T2 + T3 + T4 */
Glad you got it working on your imx6ul boar
Gentle ping...
On Fri, Jan 29, 2021 at 8:09 AM Fabio Estevam wrote:
>
> Hi Rob,
>
> Any comments on this series, please?
>
> On Tue, Jan 19, 2021 at 8:15 PM Fabio Estevam wrote:
> >
> > Issuing a 'reboot' command in i.MX5 leads to the followi
On Wed, Sep 15, 2021 at 5:41 PM Philip Chen wrote:
> As regmap_read() should always read 1 byte at a time, should I just do:
> regmap_read(map, PAGE0_SWAUX_RDATA, (unsigned int*)(buf + i))
There is also regmap_bulk_read() if you need to read more data.
Hi Abhinav,
On Thu, Sep 16, 2021 at 1:15 PM wrote:
>
> Hi Fabio
>
> Thanks for confirming.
>
> Although I have no issues with your change, I am curious why even msm is
> probing and/or binding.
> Your device tree should not be having any mdp/dpu nodes then.
The i.MX53 does have the following
Hi Abhinav,
On Wed, Sep 15, 2021 at 11:22 PM wrote:
> Are you not using DPU or are you not using mdp4/mdp5 as well? Even if
> you are using any of mdps, kms should
> not be NULL. Hence wanted to check the test case.
I am running i.MX53, which is an NXP SoC, not Qualcomm's.
It does not use
t
use the DPU controller.
Cc: sta...@vger.kernel.org
Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/msm/msm_drv.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.
Hi Salah,
On Tue, Jul 13, 2021 at 10:33 AM Salah Triki wrote:
>
> Use swap() instead of implementing it since it makes code more clean.
s/more clean/cleaner
> Signed-off-by: Salah Triki
> ---
> drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++-
> 1 file changed, 2 insertions(+), 5
On Sun, Oct 10, 2021 at 12:39 PM Fabio Estevam wrote:
>
> Hi,
>
> I am getting the lockdep warning below on a imx6q-sabred running 5.14.9.
>
> Haven't debugged this yet, but just wanted to report in case someone
> has any suggestions.
git bisect shows that the guil
Hi,
I am getting the lockdep warning below on a imx6q-sabred running 5.14.9.
Haven't debugged this yet, but just wanted to report in case someone
has any suggestions.
Thanks,
Fabio Estevam
[4.913294] imx-drm display-subsystem: bound imx-ipuv3-crtc.2 (ops
ipu_crtc_ops)
[4.921640] imx
dsi83:
Switch to atomic operations").
Tested on a imx6sx-udoo-neo board.
Suggested-by: Marek Vasut
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/g
mx6sx-udoo-neo board.
Suggested-by: Marek Vasut
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/i2c/tda998x_drv.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index adaa985af87e..d9
xit+0x18c/0x210
[ 23.505106] ---[ end trace 86572327287ca501 ]---
I haven't managed to fix this yet, but if you have any suggestions,
please let me know.
Thanks,
Fabio Estevam
dsi83:
Switch to atomic operations").
Tested on a imx6sx-udoo-neo board.
Suggested-by: Marek Vasut
Signed-off-by: Fabio Estevam
Reviewed-by: Laurent Pinchart
---
Changes since v1:
- Move .atomic_duplicate_state,.atomic_destroy_state .atomic_reset from
patch 2/2 to 1/2. (Laurent)
drivers/g
301 - 400 of 525 matches
Mail list logo
