Re: [PATCH v5] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-20 Thread Geert Uytterhoeven
ze aligned because of it need mmap (Thomas) > - Adding fixes tag (Thomas) > > Fixes: aa15c677cc34 ("drm/fb-helper: Fix vertical damage clipping") > > Signed-off-by: Sui Jingfeng > Reviewed-by: Thomas Zimmermann > Tested-by: Geert Uytterhoeven Thanks for the update!

[PATCH] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-04-18 Thread Geert Uytterhoeven
/fb-helper: fix input validation gaps in check_var") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/drm_fb_helper.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 64458982be40c4

Re: [PATCH v2 0/5] drm: shmobile: Fixes and enhancements

2023-04-18 Thread Geert Uytterhoeven
Hi Laurent, On Tue, Apr 18, 2023 at 9:49 AM Laurent Pinchart wrote: > On Mon, Apr 17, 2023 at 03:40:20PM +0200, Geert Uytterhoeven wrote: > > Currently, there are two drivers for the LCD controller on Renesas > > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > >

[PATCH v2 2/5] drm: shmobile: Add support for DRM_FORMAT_XRGB8888

2023-04-17 Thread Geert Uytterhoeven
DRM_FORMAT_XRGB aka XR24 is the modus francus of DRM, and should be supported by all drivers. The handling for DRM_FORMAT_XRGB is similar to DRM_FORMAT_ARGB, just ignore the alpha channel. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent

[PATCH v2 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-04-17 Thread Geert Uytterhoeven
), and by widening the dependency range to ARCH_RENESAS (for ARM). Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by, - Drop dependency on ARM, reword. This driver was disabled on SuperH in commit c66de8cc2ea62941 ("drm/shmobile

[PATCH v2 0/5] drm: shmobile: Fixes and enhancements

2023-04-17 Thread Geert Uytterhoeven
...@glider.be Geert Uytterhoeven (5): drm: shmobile: Use %p4cc to print fourcc codes drm: shmobile: Add support for DRM_FORMAT_XRGB drm: shmobile: Switch to drm_crtc_init_with_planes() drm: shmobile: Add missing call to drm_fbdev_generic_setup() drm: shmobile: Make DRM_SHMOBILE visible

[PATCH v2 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-04-17 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by. --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 30 +-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/shmobile

[PATCH v2 4/5] drm: shmobile: Add missing call to drm_fbdev_generic_setup()

2023-04-17 Thread Geert Uytterhoeven
Set up generic fbdev emulation, to enable support for the Linux console. Use 16 as the preferred depth, as that is a good compromise between colorfulness and resource utilization, and the default of the fbdev driver. Suggested-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven Reviewed

[PATCH v2 1/5] drm: shmobile: Use %p4cc to print fourcc codes

2023-04-17 Thread Geert Uytterhoeven
Replace the printing of hexadecimal fourcc format codes by pretty-printed format names, using the "%p4cc" format specifier. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann --- v2: - Add Reviewed-by. --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- drive

Re: [PATCH v3] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-17 Thread Geert Uytterhoeven
ch break the trigger condition of this bug by shrinking the shadow > buffer size to sizes->surface_height * buffer->fb->pitches[0]. > > Fixes: '8fbc9af55de0 ("drm/fbdev-generic: Set screen size to size of GEM > buffer")' > > Signed-off-by: Sui Jingfeng Thanks,

Re: [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Geert Uytterhoeven
return -EFAULT; > > + /* only for kernel-internal use */ > > + var.activate &= ~FB_ACTIVATE_KD_TEXT; > > console_lock(); > > lock_fb_info(info); > > ret = fbcon_modechange_possible(info, ); Perhaps FB_ACTIVATE_KD_TEXT

Re: [PATCH 2/2] drm: Spelling s/randevouz/rendez-vouz/

2023-04-11 Thread Geert Uytterhoeven
Hi Marc, On Tue, Apr 11, 2023 at 12:49 PM Marc Dionne wrote: > On Tue, Apr 11, 2023 at 7:44 AM Geert Uytterhoeven > wrote: > > > > Fix a misspelling of "rendez-vouz". > > > > Signed-off-by: Geert Uytterhoeven > > --- a/include/drm/task_

[PATCH v2 2/2] drm: Spelling s/randevouz/rendez-vous/

2023-04-11 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vous". Signed-off-by: Geert Uytterhoeven --- v2: - s/vouz/vous/. --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h index 217c1cf21c1ab7d5..f6e6ed

[PATCH v2 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h | 2 +- 4 files changed, 4 insertions(+), 4

Re: [PATCH v3 28/65] clk: renesas: r9a06g032: Add a determine_rate hook

2023-04-11 Thread Geert Uytterhoeven
s an oversight, then we are at least explicit about our > behavior now and it can be further refined down the line. > > Signed-off-by: Maxime Ripard LGTM, so Reviewed-by: Geert Uytterhoeven But I do not have the hardware. > --- a/drivers/clk/renesas/r9a06g032-clocks.c > +++ b/driver

[PATCH 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h | 2 +- 4 files changed, 4 insertions(+), 4

[PATCH 2/2] drm: Spelling s/randevouz/rendez-vouz/

2023-04-11 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vouz". Signed-off-by: Geert Uytterhoeven --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h index 217c1cf21c1ab7d5..59ead429acb2afb0 100644 --- a/i

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-11 Thread Geert Uytterhoeven
ighning the checks in the core, > > because that's realistically really all that will ever happen. > > > > Reported-by: syzbot+20dcf81733d43ddff...@syzkaller.appspotmail.com > > Link: > > https://syzkaller.appspot.com/bug?id=c5faf983bfa4a607de530cd3bb008888bf06cefc > &

Re: [PATCH v2 08/19] arch/m68k: Implement with generic helpers

2023-04-11 Thread Geert Uytterhoeven
On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: > Replace the architecture's fb_is_primary_device() with the generic > one from . No functional changes. > > v2: > * provide empty fb_pgprotect() on non-MMU systems > > Signed-off-by: Thomas Zimmermann >

Re: [PATCH v2 07/19] arch/m68k: Merge variants of fb_pgprotect() into single function

2023-04-11 Thread Geert Uytterhoeven
h the switch to . > > Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical peo

Re: [PATCH v2 01/19] fbdev: Prepare generic architecture helpers

2023-04-11 Thread Geert Uytterhoeven
unsigned long off) Does this affect any noMMU platforms that relied on fb_pgprotect() doing nothing before? Perhaps the body below should be protected by "#ifdef CONFIG_MMU"? > +{ > + vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); Sho

Re: [PATCH 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-04-10 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Apr 5, 2023 at 6:02 AM Laurent Pinchart wrote: > On Fri, Mar 31, 2023 at 04:48:11PM +0200, Geert Uytterhoeven wrote: > > The LCD Controller supported by the drm-shmob driver is not only present > > on SuperH SH-Mobile SoCs, but also on Renesas ARM SH/R-Mobile

Re: [PATCH 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-04-10 Thread Geert Uytterhoeven
Hi Laurent, Thanks for your comments! On Wed, Apr 5, 2023 at 5:59 AM Laurent Pinchart wrote: > On Fri, Mar 31, 2023 at 04:48:09PM +0200, Geert Uytterhoeven wrote: > > The SH-Mobile DRM driver uses the legacy drm_crtc_init(), which > > advertizes only the formats in safe_modeset_

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Apr 4, 2023 at 5:55 PM Daniel Vetter wrote: > On Tue, 4 Apr 2023 at 16:51, Geert Uytterhoeven wrote: > > On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > > > On Tue, Ap

Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter wrote: > On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > > The DRM fbdev emulation layer does not support pushing back > > > changes

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
CC linux-fbdev On Tue, Apr 4, 2023 at 4:41 PM Thomas Zimmermann wrote: > Am 04.04.23 um 16:19 schrieb Daniel Vetter: > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > >> On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > >

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
CC linux-fbdev On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter > > > w

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
8) This is a bug in the vkmsdrmfb driver and/or DRM helpers. The message was added to make sure the individual drivers are fixed. Perhaps it should be changed to BUG() instead, so dmesg output cannot be drown? > Fixes: 6c11df58fd1a ("fbmem: Check virtual screen sizes in fb_set_var()") > Cc:

Re: [PATCH v2] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-04 Thread Geert Uytterhoeven
ce at virtual address > 0074 Thanks, this fixes a crash seen with the ssd130x DRM driver. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with

Re: [PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-04-03 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Apr 3, 2023 at 3:14 PM Thomas Zimmermann wrote: > Am 31.03.23 um 16:48 schrieb Geert Uytterhoeven: > > Currently, there are two drivers for the LCD controller on Renesas > > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > >1. sh_mobile_lc

[PATCH 1/5] drm: shmobile: Use %p4cc to print fourcc codes

2023-03-31 Thread Geert Uytterhoeven
Replace the printing of hexadecimal fourcc format codes by pretty-printed format names, using the "%p4cc" format specifier. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- drivers/gpu/drm/shmobile/shmob_drm_kms.c | 4 ++-- 2 files changed, 4

[PATCH 4/5] drm: shmobile: Add missing call to drm_fbdev_generic_setup()

2023-03-31 Thread Geert Uytterhoeven
Set up generic fbdev emulation, to enable support for the Linux console. Use 16 as the preferred depth, as that is a good compromise between colorfulness and resource utilization, and the default of the fbdev driver. Suggested-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven --- drivers

[PATCH 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-03-31 Thread Geert Uytterhoeven
The LCD Controller supported by the drm-shmob driver is not only present on SuperH SH-Mobile SoCs, but also on Renesas ARM SH/R-Mobile SoCs. Make its option visible, so the user can enable support for it. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/Kconfig | 2 +- 1 file

[PATCH 2/5] drm: shmobile: Add support for DRM_FORMAT_XRGB8888

2023-03-31 Thread Geert Uytterhoeven
DRM_FORMAT_XRGB aka XR24 is the modus francus of DRM, and should be supported by all drivers. The handling for DRM_FORMAT_XRGB is similar to DRM_FORMAT_ARGB, just ignore the alpha channel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 1

[PATCH 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-03-31 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 30 +-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 08dc1428aa16caf0..11dd2bc803e7cb62

[PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-03-31 Thread Geert Uytterhoeven
Armadillo-800-EVA development board, using a temporary platform-enablement patch[1]. Thanks for your comments! [1] https://lore.kernel.org/r/c03d4edbd650836bf6a96504df82338ec6d800ff.1680272980.git.geert+rene...@glider.be Geert Uytterhoeven (5): drm: shmobile: Use %p4cc to print fourcc codes

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-21 Thread Geert Uytterhoeven
Hi Randy, On Tue, Mar 21, 2023 at 4:10 PM Randy Dunlap wrote: > On 3/21/23 00:34, Geert Uytterhoeven wrote: > > On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap wrote: > >> On 3/20/23 01:21, Geert Uytterhoeven wrote: > >>> Below is the list of build error/wa

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-21 Thread Geert Uytterhoeven
Hi Randy, On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap wrote: > On 3/20/23 01:21, Geert Uytterhoeven wrote: > > Below is the list of build error/warning regressions/improvements in > > v6.3-rc3[1] compared to v6.2[2]. > > > > Summarized: > > - build errors:

[PATCH v2] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2023-03-20 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven Reviewed-by: Russell King (Oracle) --- Compile-tested only. v2: - Add Reviewed-by. --- drivers/gpu/drm/armada/armada_overlay.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/

Re: [PATCH 39/51] video: fbdev: sh_mobile_lcdcfb: Convert to platform remove callback returning void

2023-03-19 Thread Geert Uytterhoeven
ro in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal convers

Re: [PATCH v2] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-16 Thread Geert Uytterhoeven
; > + dst_pitch = DIV_ROUND_UP(drm_rect_width(clip) * bpp, 8); I know I'm a bit late to the party, but here's actually a helper for that: dst_pitch = drm_format_info_min_pitch(info, 0, drm_rect_width(clip)); > + } > > return dst_pitch * drm_rect_height(clip);

Re: [PATCH v3 35/38] video: handle HAS_IOPORT dependencies

2023-03-15 Thread Geert Uytterhoeven
G_PCI. So: depends on FB && !SPARC32 depends on ATARI || HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH v2 001/101] lib: Add option iterator

2023-03-10 Thread Geert Uytterhoeven
gt; create mode 100644 lib/cmdline_iter.c Just wondering, is there any code that can be shared with/reused from the existing lib/cmdline.c? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH v2 000/101] fbdev: Fix memory leak in option parsing

2023-03-10 Thread Geert Uytterhoeven
spect > video= settings in any configuration. > > v2: > * use kstrdup()/kfree() for video strings (Geert, Timur) > * fix iterator docs (Randy) > * update iterator interface Thanks for the update, this looks much better! Gr{oetje,eeting}s,

Re: [PATCH v2 061/101] fbdev/ps3fb: Duplicate video-mode option string

2023-03-10 Thread Geert Uytterhoeven
_debug(" -> %s:%d\n", __func__, __LINE__); > ps3_system_bus_driver_unregister(_driver); > + kfree(mode_option_buf); > pr_debug(" <- %s:%d\n", __func__, __LINE__); > } Gr{oetje,eeting}s, Geert -- Geert Uyt

Re: [PATCH 00/99] fbdev: Fix memory leak in option parsing

2023-03-07 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Mar 7, 2023 at 9:23 AM Thomas Zimmermann wrote: > Am 07.03.23 um 08:53 schrieb Geert Uytterhoeven: > > On Mon, Mar 6, 2023 at 5:00 PM Thomas Zimmermann > > wrote: > >> Introduce struct option_iter and helpers to parse command-line > >> optio

Re: [PATCH 00/99] fbdev: Fix memory leak in option parsing

2023-03-07 Thread Geert Uytterhoeven
that drivers don't refer directly > to the option string's memory. The option iterator then replaces manual > parsing loops based on strsep(","). Thanks for your series! Unfortunately I cannot say I'm thrilled about this: you are replacing a single small dynamic memory leak by 36 lar

Re: [PATCH 11/99] fbdev/aty: Duplicate video-mode option string

2023-03-06 Thread Geert Uytterhoeven
ret=%d\n", ret)) > + continue; > + if (WARN(ret >= sizeof(mode_option_buf), "aty128fb: > option too long\n")) > + continue; > + mode_option = mode_option_buf;

[PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-06 Thread Geert Uytterhoeven
es: 100d7ef6995d1f86 ("drm/msm/dpu: add support for SM8450") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/

Re: Build regressions/improvements in v6.3-rc1

2023-03-06 Thread Geert Uytterhoeven
On Mon, 6 Mar 2023, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.3-rc1[1] compared to v6.2[2]. Summarized: - build errors: +9/-14 - build warnings: +4/-1447 Happy fixing! ;-) Thanks to the linux-next team for providing the build service

Re: [PATCH 2/3] drm: rcar-du: lvds: Move LVDS enable code to separate code section

2023-02-14 Thread Geert Uytterhoeven
> Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking t

Re: [Intel-gfx] [PATCH v3 2/2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-02-07 Thread Geert Uytterhoeven
t Pinchart Signed-off-by: Dmitry Baryshkov Thanks for your patch! This gets rids of the warning splats on e.g. Renesas Koelsch and Salvator-XS, so Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux b

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 11:02 AM Geert Uytterhoeven wrote: > On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong > wrote: > > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > > wrote: > > >>

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong wrote: > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > wrote: > >> On 10/01/2023 08:57, Laurentiu Palcu wrote: > >>> On Mon, Jan 09, 2023 at 10:2

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
On Tue, Jan 10, 2023 at 11:20 AM Geert Uytterhoeven wrote: > On Tue, Jan 10, 2023 at 8:07 AM Laurentiu Palcu > wrote: > > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > > > It

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
t me test it locally before posting. Is this fix available? Do you have a lore link? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

Re: remove arch/sh

2023-02-03 Thread Geert Uytterhoeven
sh: sh for 32 bit, sh64 for 64 bit <<<<<<<<<<<<<<< > - sparc: sparc32 for 32 bit, sparc64 for 64 bit No, support for sh64 was removed in commit 37744feebc086908 ("sh: remove sh5 support") in v5.8. Gr{oetje,eeting}s,

Re: [PATCH 01/22] gpu/drm: remove the shmobile drm driver

2023-02-03 Thread Geert Uytterhoeven
my list... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: remove arch/sh

2023-02-03 Thread Geert Uytterhoeven
is done by next week. > > We're still discussing among SuperH developer community whether there will be > a second > maintainer, so please bear with us a few more days. I will collect patches in > the > meantime. Thanks a lot! If you need any help with process, setup, ... d

Re: [PATCH] tree-wide: trivial: s/ a SPI/ an SPI/

2023-02-03 Thread Geert Uytterhoeven
nt letter S, but the S is pronounced with its > letter name, "es."). While I agree with your pronunciation, I believe the SPI maintainer (which you forgot to CC) pronounces it in James Bond-style, i.e. rhymes with "spy" ;-) Gr{oetje,eeting}s, Geert -

Re: UBSAN: shift-out-of-bounds in fbcon_set_font

2023-01-26 Thread Geert Uytterhoeven
d max_font_height (128), but fbcon has stricter limits. fbcon_set_font() should reject fonts with width > 32 or height > 32. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

[PATCH] drivers: Restore alignment and newline in Makefile

2023-01-24 Thread Geert Uytterhoeven
The introduction of drivers/accel/ broke alignment, and removed the newline at the end of the file. Fix all of that. Fixes: 35b137630f08d913 ("accel/ivpu: Introduce a new DRM driver for Intel VPU") Signed-off-by: Geert Uytterhoeven --- drivers/Makefile | 2 +- 1 file changed, 1 inser

Re: [PATCH/RFC 0/3] Atari DRM driver

2023-01-23 Thread Geert Uytterhoeven
Hi Adrian, On Mon, Jan 23, 2023 at 4:09 PM John Paul Adrian Glaubitz wrote: > On 11/25/22 21:31, Geert Uytterhoeven wrote: > > This RFC patch series adds a DRM driver for the good old Atari > > ST/TT/Falcon hardware. It was developed and tested (only) on the ARAnyM > >

Re: [PATCH v2 2/7] drm: rcar-du: lvds: Add runtime PM

2023-01-23 Thread Geert Uytterhoeven
ency but a runtime-dependency, with runtime PM support the > suspend/resume handler will never be called. While technically that is correct, you'll have a hard time getting here with CONFIG_PM=n, as both ARCH_RCAR_GEN2 and ARCH_RCAR_GEN3 do select PM. Gr{oetje,eeting}s,

Re: [PATCH v3 4/7] drm: rcar-du: lvds: Fix stop sequence

2023-01-23 Thread Geert Uytterhoeven
a comment explaining why there are multiple register writes, to avoid an over-zealous janitor "optimizing" the code later. > > rcar_lvds_write(lvds, LVDCR0, 0); > rcar_lvds_write(lvds, LVDCR1, 0); Gr{oetje,eeting}s, Geert -- Geert Uytterhoe

Re: remove arch/sh

2023-01-17 Thread Geert Uytterhoeven
Hi Rob, On Wed, Jan 18, 2023 at 5:50 AM Rob Landley wrote: > On 1/17/23 14:26, Geert Uytterhoeven wrote: > > On Tue, Jan 17, 2023 at 8:01 PM Rob Landley wrote: > >> I'm lazy and mostly test each new sh4 build under qemu -M r2d because it's > >> really convenient: ne

Re: remove arch/sh

2023-01-17 Thread Geert Uytterhoeven
e hardest part is clock and interrupt-controller support. Unfortunately I no longer have access to the (remote) Migo-R. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call mys

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-17 Thread Geert Uytterhoeven
e two lines. The idiom is to set rcdu->info based on of_device_get_match_data() first, and override based on of_device_get_match_data() when needed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: [PATCH 2/6] drm: rcar-du: lvds: Add reset control

2023-01-17 Thread Geert Uytterhoeven
;rstc); return dev_err_probe(...); > + } > + > drm_bridge_add(>bridge); > > return 0; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations wi

Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros

2023-01-16 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: >

Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros

2023-01-16 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > Geert, could you please take this in your tree for v6.3 ? The two > &g

Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros

2023-01-16 Thread Geert Uytterhoeven
1:14:09AM +0300, Laurent Pinchart wrote: > > Now that a header exists with macros for the media interface bus-type > > values, replace hardcoding numerical constants with the corresponding > > macros in the DT sources. > > > > Signed-off-by: Laurent Pinchart Reviewed-by:

Re: [PATCH v4] arch: rename all internal names __xchg to __arch_xchg

2023-01-16 Thread Geert Uytterhoeven
v4: adjusted indentation (Heiko) > arch/m68k/include/asm/cmpxchg.h | 6 +++--- Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tech

Re: [PATCH 02/22] usb: remove the dead USB_OHCI_SH option

2023-01-13 Thread Geert Uytterhoeven
g USB_OHCI_EXYNOS > tristate "OHCI support for Samsung S5P/Exynos SoC Series" > depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.o

Re: [PATCH 19/22] fbdev: remove sh7760fb

2023-01-13 Thread Geert Uytterhoeven
OMPILE_TEST Nit: this part should be a separate patch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talki

Re: [PATCH 16/22] spi: remove spi-sh-sci

2023-01-13 Thread Geert Uytterhoeven
help > - SPI driver for SuperH SCI blocks. This driver uses the Serial Communications Interface (SCI, cfr. drivers/tty/serial/sh-sci.c) in SPI mode. Hence in theory it could be used on a variety of Renesas ARM SoCs, and even on RZ/Five. Again, no DT support. Gr{oetje,eeting}s,

Re: [PATCH 13/22] pinctrl: remove renesas sh controllers

2023-01-13 Thread Geert Uytterhoeven
Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "progra

Re: [PATCH 11/22] mtd/nand: remove sh_flctl

2023-01-13 Thread Geert Uytterhoeven
upport > - for NAND Flash using FLCTL. FTR, this hardware block is also present on the ARM-based SH-Mobile AG5 and R-Mobile A1 SoCs. Again, no DT support. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In

Re: [PATCH 10/22] input: remove sh_keysc

2023-01-13 Thread Geert Uytterhoeven
ased SH-Mobile AG5, and R-Mobile A1 and APE6 SoCs. Again, no DT support. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hac

Re: remove arch/sh

2023-01-13 Thread Geert Uytterhoeven
It's a bit disappointing that people keep hammering on it. It works fine for > me. Indeed. The main issue is not the lack of people sending patches and fixes, but those patches never being applied by the maintainers. Perhaps someone is willing to stand up to take over maintainership? Thanks! Gr{oe

Re: [PATCH 01/22] gpu/drm: remove the shmobile drm driver

2023-01-13 Thread Geert Uytterhoeven
ittle bit on this, ARCH_SHMOBILE used to be set for the > ARM-based shmobile SoCs too, until > > commit 08e735233ea29b17bfec8e4cb302e799d9f920b8 > Author: Geert Uytterhoeven > Date: Tue Aug 28 17:10:10 2018 +0200 > > ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol &g

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-10 Thread Geert Uytterhoeven
ed it to commit 92d755d8f13b6791 ("drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement") in drm-misc/for-linux-next. As I do not have any displays connected, I do not know what is the full impact. Gr{oetje,eeting}s, Geert -- G

Re: [PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-09 Thread Geert Uytterhoeven
This time with the new linux-mips mailing list address... On Mon, Jan 9, 2023 at 11:01 AM Geert Uytterhoeven wrote: > > Hi Xurui, > > On Thu, Jan 5, 2023 at 10:45 AM xurui wrote: > > drivers/video/fbdev/g364fb.c:202:4: error: cast to pointer from integer of > > dif

Re: [PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-09 Thread Geert Uytterhoeven
egisters. Probably it should use writel() instead. [1] mips64-linux-gnuabi64-gcc version 10.3.0 (Ubuntu 10.3.0-1ubuntu1) jazz_defconfig + CONFIG_64BIT=y Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

Re: [PATCH v2] arch: rename all internal names __xchg to __arch_xchg

2023-01-02 Thread Geert Uytterhoeven
On Thu, Dec 29, 2022 at 12:34 PM Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Geert Uytterhoeven
to answer: > > 1. Name of the helper, __xchg follows kernel conventions, > but for me Rust names are also OK. Before I realized the missing "&", I wondered how this is different from swap(), so naming is important. https://elixir.bootlin.com/linux/latest/source/incl

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-20 Thread Geert Uytterhoeven
Hi Hans, On Tue, Dec 20, 2022 at 10:22 AM Hans Verkuil wrote: > On 20/12/2022 10:09, Geert Uytterhoeven wrote: > > On Tue, Dec 20, 2022 at 10:01 AM Hans Verkuil > > wrote: > >> On 19/12/2022 22:47, Laurent Pinchart wrote: > >>> (CC'ing Sakari and Hans)

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-20 Thread Geert Uytterhoeven
ghest memory address. So that means big endian? > If I am not mistaken, DRM uses the CPU order. So that explains the difference > in naming. I don't think we should hide that difference. And V4L2 has been > quite consistent in following memory ordering in the naming (except po

Re: [PATCH] fbdev: omapfb: avoid stack overflow warning

2022-12-16 Thread Geert Uytterhoeven
if (!stats) { > + seq_printf(s, "out of memory\n"); I guess this is futile? No need to increase kernel size for OOM messages. > + return; > + } > > spin_lock_irqsave(>irq_stats_lock, flags); Gr{oetje,eeting}s,

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-12-15 Thread Geert Uytterhoeven
ray3_size(logo_lines, new_cols, 2)); So how can this turn out to be uninitialized later below? scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)); What am I missing? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyo

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Geert Uytterhoeven
Hi Guillaume, On Wed, Dec 14, 2022 at 3:16 PM Guillaume Tucker wrote: > On 14/12/2022 15:03, Geert Uytterhoeven wrote: > > On Wed, Dec 14, 2022 at 1:54 PM Guillaume Tucker > > wrote: > >> On 14/12/2022 11:06, Geert Uytterhoeven wrote: > >>> On Tue, Dec 1

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Geert Uytterhoeven
, Jonas Karlman > , > | Jernej Skrabec > > which doesn't mention him at all. Right. I noticed the email because my name was in the body (it's part of the git repo name). The "Re: renesas/master bisection" in the subject immediately triggered my interest. Gr{oet

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Geert Uytterhoeven
Hi Guillaume, On Wed, Dec 14, 2022 at 1:54 PM Guillaume Tucker wrote: > On 14/12/2022 11:06, Geert Uytterhoeven wrote: > > On Tue, Dec 13, 2022 at 5:58 PM Mark Brown wrote: > >> On Tue, Dec 13, 2022 at 05:56:30AM -0800, KernelCI bot wrote: > >> The KernelCI bise

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Geert Uytterhoeven
| #3 [__libc_start_main+0xe8] > | #4 [+0xd5361974] > | #5 [[ 36.162851] Console: switching to colour frame buffer > device 300x100>+0xd5361974] > | Subtest short-buffer-wakeup failed. > > Unfortunately we don't have current results from mainline or -next. Gr{o

Re: [PATCH 5/7] media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-06 Thread Geert Uytterhoeven
mt2 = 0; > + break; > + } > + > + vsp1_rpf_write(rpf, dlb, VI6_RPF_EXT_INFMT0, ext_infmt0); > + vsp1_rpf_write(rpf, dlb, VI6_RPF_EXT_INFMT1, ext_infmt1); > + vsp1_rpf_write(rpf, dlb

Re: [PATCH v5 5/7] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-12-06 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Dec 6, 2022 at 2:45 PM Tomi Valkeinen wrote: > On 05/12/2022 12:10, Geert Uytterhoeven wrote: > > On Thu, Dec 1, 2022 at 10:56 AM Tomi Valkeinen > > wrote: > >> > >> Add DT nodes needed for the mini DP connector. The DP is driven by > >&g

Re: [PATCH v5 5/7] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-12-05 Thread Geert Uytterhoeven
-by: Laurent Pinchart (same comments as v2) Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v6.3, with the mini-dp-con node moved up. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In p

Re: [PATCH v5 3/7] clk: renesas: r8a779g0: Add display related clocks

2022-12-05 Thread Geert Uytterhoeven
art Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-clk-for-v6.3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

Re: [PATCH linux-next v3] fbdev: use sysfs_emit() to instead of scnprintf()

2022-12-05 Thread Geert Uytterhoeven
gt; Signed-off-by: ye xingchen > --- > v2 -> v3 > Fix the mistakes in v2. Indeed, that's usually what a v3 does ;-) It would help if you listed the actual changes instead. But "b4 diff 202212051631391777...@zte.com.cn" doesn't show any? Thanks! Gr{oetje,eeting}s,

Re: [PATCH v2 5/7] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-12-01 Thread Geert Uytterhoeven
viewed-by: Laurent Pinchart Thanks for your patch! Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v6.3, with the mini-dp-con node moved up. > --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi >

<    2   3   4   5   6   7   8   9   10   11   >