[PATCH v7 05/15] drm/exynos: add Exynos5433 decon driver

On 2015년 06월 22일 20:41, Varka Bhadram wrote: > Hi, > > On 06/22/2015 04:46 PM, Inki Dae wrote: > >> From: Joonyoung Shim >> >> DECON(Display and Enhancement Controller) is new IP replacing FIMD in >> Exynos5433. This patch adds Exynos5433 decon driver.

[PATCH v6 15/15] ARM: dts: rename the clock of MIPI DSI 'pll_clk' to 'sclk_mipi'

+ Krzysztof On 2015년 06월 22일 18:10, Inki Dae wrote: > On 2015년 06월 12일 21:59, Hyungwon Hwang wrote: >> The clock which was named as 'pll_clk' is actually not the clock source >> of PLL in MIPI DSI. This patch fixes this disagreement. > > Mr. Kukjin

[PATCH v7 05/15] drm/exynos: add Exynos5433 decon driver

-off-by: Inki Dae --- .../devicetree/bindings/video/exynos5433-decon.txt | 65 ++ drivers/gpu/drm/exynos/Kconfig |6 + drivers/gpu/drm/exynos/Makefile|1 + drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 660 drivers/gpu/drm

[PATCH v6 15/15] ARM: dts: rename the clock of MIPI DSI 'pll_clk' to 'sclk_mipi'

his patch to mainline through drm-next. Thanks, Inki Dae > > Signed-off-by: Hyungwon Hwang > --- > Changes before: > - Refer https://patchwork.kernel.org/patch/6191811 > Changes for v6: > - None > > arch/arm/boot/dts/exynos4.dtsi | 2 +- > 1 file changed, 1 insertio

[PATCH v10 00/17] drm/exynos: atomic modesetting support

On 2015년 06월 17일 23:33, Gustavo Padovan wrote: > Hi Inki, > > 2015-06-17 Inki Dae : > >> Hi Gustavo, >> >> On 2015년 06월 17일 05:35, Gustavo Padovan wrote: >>> HI Inki, >>> >>> 2015-06-15 Inki Dae : >>> >>>

[PATCH] drm/exynos: do not wait for vblank at atomic operation

waiting there is really unnecessary because page flip operation does already it. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fb.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index 789db6f

[PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj

On 2015년 06월 19일 14:46, Krzysztof Kozlowski wrote: > 2015-06-19 14:28 GMT+09:00 Inki Dae : >> On 2015년 06월 19일 14:23, Krzysztof Kozlowski wrote: >>> The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in >>> 2a3098ff6c21 (

[PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj

#x27;exynos_drm_gem_obj' may be mapped to multiple > user-space VMAs so 'vma' field does not look useful anyway. Krzysztof, The vma member would be removed by below patch, http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html Thanks, Inki Dae > > Signed-off

[PATCH v10 00/17] drm/exynos: atomic modesetting support

On 2015년 06월 17일 23:33, Gustavo Padovan wrote: > Hi Inki, > > 2015-06-17 Inki Dae : > >> Hi Gustavo, >> >> On 2015년 06월 17일 05:35, Gustavo Padovan wrote: >>> HI Inki, >>> >>> 2015-06-15 Inki Dae : >>> >>>

[PATCH v10 00/17] drm/exynos: atomic modesetting support

Hi Gustavo, On 2015년 06월 17일 05:35, Gustavo Padovan wrote: > HI Inki, > > 2015-06-15 Inki Dae : > >> Hi Gustavo, >> >> On 2015년 06월 02일 00:04, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Hi, >>> >

[PATCH v10 00/17] drm/exynos: atomic modesetting support

# modetest -M exynos -v -s 31 at 29:720x1280 -s 23 at 21:640x480 setting mode 720x1280-60Hz at XR24 on connectors 31, crtc 29 setting mode 640x480-75Hz at XR24 on connectors 23, crtc 21 freq: 60.18Hz freq: 49.09Hz I can see 60Hz for FIMD and 49Hz for vidi. Thanks, Inki Dae > > > G

[PATCH] drm/exynos: fimd: fix page fault issue with iommu

273034] [] (__handle_domain_irq) from [] (gic_handle_irq+0x30/0x68) [ 35.281366] [] (gic_handle_irq) from [] (__irq_svc+0x40/0x74) Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drive

[PATCH 2/2] drm/exynos: ipp: validate a GEM handle with multiple planes

On 2015년 06월 09일 12:45, Hyungwon Hwang wrote: > FIMC & GSC driver can calculate the offset of planes. So there are > use cases which IPP receives just one GEM handle of an image with > multiple plane. This patch extends ipp_validate_mem_node() to validate > this case. Applie

[PATCH 1/2] drm/exynos: ipp: fix wrong index referencing a config element

On 2015년 06월 09일 12:45, Hyungwon Hwang wrote: > Config depends on the opreation. So it must be referenced by an > operation id, not a property id. Applied. Thanks, Inki Dae > > Signed-off-by: Hyungwon Hwang > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 3 +-- &g

[PATCH v3] drm/exynos: dsi: check whether dsi is enabled before sending data

zed, but DSI is still turning down. To prevent it, > DSI must be set by disabled before starting to be turned down, and > exynos_dsi_host_transfer() must check whether DSI is enabled or not. Applied. Thanks, Inki Dae > > Kernel dump: > [ 4721.351448] Unhandled fault: synchronous

[PATCH 1/3] drm/exynos: consolidate driver/device initialization code

development. Applied all patches Thanks, Inki Dae > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 221 > +++ > drivers/gpu/drm/exynos/exynos_drm_drv.h | 17 --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c |

[PATCH v2] drm/exynos: add error messages if clks failed to get enabled

On 2015년 06월 04일 05:17, Gustavo Padovan wrote: > From: Gustavo Padovan > > Check error and call DRM_ERROR if clk_prepare_enable() fails. Applied. Thanks, Inki Dae > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/exy

[PATCH v10 00/17] drm/exynos: atomic modesetting support

On 2015년 06월 10일 20:38, Marek Szyprowski wrote: > Hello, > > On 2015-06-10 12:59, Inki Dae wrote: >> Hi Marek, >> >> On 2015년 06월 10일 19:03, Marek Szyprowski wrote: >>> Hello, >>> >>> On 2015-06-01 17:04, Gustavo Padovan wrote: &g

[PATCH v10 00/17] drm/exynos: atomic modesetting support

00 0x1000>; interrupt-parent = <&combiner>; interrupts = <5 2>; clock-names = "sysmmu", "master"; clocks = <&clock CLK_SMMU_FIMD0>, <&clock CLK_FIMD0>; power-domains = <&pd_lcd0>; #iommu-cells = <0>; }; in exynos4412-trats2.dts file: fimd at 11c0 { status = "okay"; iommu-reserved-mapping = <0x4000 0x4000 0x4000>; }; Is that all? You would need to share exact guide about iommu enabling to other people so that they can test atomic feature with iommu. Thanks, Inki Dae > >> (...) > > Best regards

[PATCH 9/9] drm/exynos: unify exynos_drm_plane names with drm core

On 2015년 06월 10일 19:42, Inki Dae wrote: > Hi Gustavo, > > On 2015년 06월 09일 23:27, Gustavo Padovan wrote: >> Hi Inki and Joonyoung, >> >> Any comments on this series? > > As you may know, I'm reviewing and testing iommu support patch series >

[PATCH 9/9] drm/exynos: unify exynos_drm_plane names with drm core

akes DMA device more sensitive so it seems that hided issues happen with iommu support. In this time, let's have more reviews. Look like that now atomic features aren't safe yet. Thanks, Inki Dae > > 2015-06-03 Gustavo Padovan : > >> From: Gustavo Padovan >> >>

[PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable()

eries to exynos-drm-next. However, this patch especially above codes is required for more clean-up. Even though decon_enable function never return error number, I think its internal codes should be considered for some exception cases to check where an error occurred at. So could you post the clean

[PATCH] drm/exynos: add a dependency on FB_S3C to DECON driver

This patch makes one of Linux framebuffer and DRM CRTC drivers to be enabled. Display controllers, FIMD and DECON, can be controlled by Linux framebuffer or DRM CRTC drivers so only one of them should be enabled. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/Kconfig |2 +- 1 file

[PATCH] drm/exynos: vidi: remove unused varables

This patch removes unnsed varables in vidi_disable function. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index abe4ee0..16dc68c

[PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable()

On 2015년 06월 02일 23:19, Javier Martinez Canillas wrote: > Hello Gustavo, > > On Tue, Jun 2, 2015 at 4:06 PM, Gustavo Padovan > wrote: >> Hi Inki, >> >> 2015-06-02 Inki Dae : >> >>> Hi, >>> >>> On 2015년 06월 02일 00:04,

[PATCH v10 02/17] drm/exynos: use adjusted_mode of crtc_state instead of mode

n the patch "drm/exynos: atomic phase 1 : add .mode_set_nofb() > callback" and except a patch 17/17 from this merge, i think clean up > patches like it need to more review after merge atomic patchset. Thanks Joonyoung. Got it. I will merge this patch series to my local repository

[PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable()

fix all errors and check your patch with checkpatch.pl before posting it. Thanks, Inki Dae total: 62 errors, 0 warnings, 410 lines checked > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 87 > ++ > drivers

[PATCH v7 12/13] drm/exynos: atomic dpms support

Hi Gustavo, On 2015년 05월 28일 05:27, Gustavo Padovan wrote: > Hi Inki, > > 2015-05-27 Inki Dae : > >> Hi Gustavo, >> >> On 2015년 05월 23일 00:40, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Run dpms operations thr

[PATCH v7 12/13] drm/exynos: atomic dpms support

atomic_flush callback to enable global dma like commit callback did. Is there any reason that you don't use atomic_begin and atomic_flush callbacks? atomic relevant codes I looked into do as follows, atomic_begin(); atomic_update(); /* this will call win_commit callback to set a overl

[PATCH v6 11/12] drm/exynos: atomic dpms support

> -static void exynos_drm_crtc_prepare(struct drm_crtc *crtc) > -{ > - /* drm framework doesn't check NULL. */ > + if (exynos_crtc->ops->win_commit) > + exynos_crtc->ops->win_commit(exynos_crtc, exynos_plane->zpos); > + > + if (exynos_crtc->ops->commit) > + exynos_crtc->ops->commit(exynos_crtc); crtc commit already was called by mode_set_nofb callback as soon as it disables crtc and encoder devices so I think unnecessary. Please see the drm_atomic_helper_commit_modeset_disable function. <--snip--> Thanks, Inki Dae

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

AGE_SHIFT; > - g2d_userptr->npages = npages; > - > - pages = drm_calloc_large(npages, sizeof(struct page *)); The declaration to pages isn't needed anymore because you removed it. > - if (!pages) { > - DRM_ERROR("failed to allocate pages.\n"); > - ret = -ENOMEM; > + vec = g2d_userptr->vec = frame_vector_create(npages); I think you can use g2d_userptr->vec so it seems that vec isn't needed. > + if (!vec) > goto err_free; > - } > > - down_read(¤t->mm->mmap_sem); > - vma = find_vma(current->mm, userptr); For vma, ditto. Thanks, Inki Dae [--SNIP--]

[PATCH 2/2] drm/exynos: 'win' is always unsigned

On 2015년 05월 12일 03:04, Tobias Jakobi wrote: > Hey Inki, > > Inki Dae wrote: >> On 2015년 05월 06일 21:10, Tobias Jakobi wrote: >>> The index for the hardware layer is always >=0. Previous >>> code that also used -1 as special index is now gone. &g

[RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops

rm_crtc.h:24: + const struct exynos_drm_crtc_ops *ops, I modified and merged all patches. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > New patch. > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- > drivers

[PATCH 2/2] drm/exynos: 'win' is always unsigned

pu/drm/exynos/exynos_mixer.c:336: +static void mixer_cfg_layer(struct mixer_context *ctx, unsigned int win, bool enable) Please check coding style with checkpath.pl before posting it next time. I modified and merged them. Thanks, Inki Dae > > Signed-off-by: Tobias Jakobi > --- > dr

drm/exynos: Add atomic modesetting support

2015-05-09 21:13 GMT+09:00 Tobias Jakobi : > Hello Inki, > > > Inki Dae wrote: >> Hi, >> >> 2015-05-09 6:51 GMT+09:00 Tobias Jakobi : >>> Hello, >>> >>> I've tested this on my Hardkernel Odroid-X2 (connected via HDMI to a >>>

drm/exynos: Add atomic modesetting support

FIMD and HDMI or FIMD, HDMI and VIDI together? For this, dts file for X2 should contain their device nodes and also should be configurated though menuconfig. > > Kernel log is 'clean', so the series works fine for me. > > You can add my > Tested-by: Tobias Jakobi So you

drm/exynos: Add atomic modesetting support

will move them to exynos-drm-next if the issue is resolved. Thanks, Inki Dae > > 2015-04-30 Gustavo Padovan : > >> Hi, >> >> Here goes the full support for atomic modesetting on exynos. I've >> split the patches in the various phases of atomic support. >>

[PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 21:43 GMT+09:00 Krzysztof Kozlowski : > 2015-05-04 20:34 GMT+09:00 Daniel Stone : >> Hi, >> >> On 4 May 2015 at 08:43, Inki Dae wrote: >>> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>>> Selecting CONFIG_FB_S3C disables CONFIG_D

[PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 20:34 GMT+09:00 Daniel Stone : > Hi, > > On 4 May 2015 at 08:43, Inki Dae wrote: >> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >>> error: >> >> No

[PATCH] drm/exynos: mixer: Constify platform_device_id

On 2015년 05월 02일 00:56, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- > 1 file

[PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

enable(struct exynos_drm_crtc *crtc, bool enable); > +#else > +static inline void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool > enable) {}; > +#endif So above codes are unnecessary. It's really not good to add #ifdef ~ #endif. Thanks, Inki Dae > > #endif /* _EXYNOS_DRM_FIMD_H_ */ >

[RFC] drm/exynos: rework layer blending setup

Hi Tobias, To make patch files, you could use below command, #git format-patch --cover-letter from..to With this command, a cover file will be created and you could describe what this patch series mean in the cover file. Thanks, Inki Dae On 2015년 04월 30일 23:56, Tobias Jakobi wrote

[PATCH v3] drm/exynos: mixer: cleanup pixelformat handling

t; Also add handling of RGB565 and XRGB1555 to the switch statement and > exit early if the plane has an unsupported pf. Applied. Thanks, Inki Dae > > Partially based on 'drm/exynos: enable/disable blend based on pixel > format' by Gustavo Padovan . > > v2: Use the sho

[PATCH v2 1/4] drm/exynos: fb: use drm_format_num_planes to get buffer count

explicit memory locations (which is then called NV12M). > > This distinction doesn't exist for DRM. A bi-planar format always > explicitly comes with the information about its two planes (even > if these planes should be contiguous). > For all patches, Applied. Thanks, Inki Da

[PATCH v2 2/2] drm/exynos: remove unused 'activated' field from exynos_drm_plane

' because I was >> wondering what the difference between 'enabled' and 'activated' was. >> Grepping than revealed that nothing was using that field. I didn't check any >> other fields. >> > > Actually i don't know about act

[PATCH v5 04/12] drm/exynos: dsi: rename pll_clk to sclk_clk

sclk_mipi"); As I mentioned before, this patch makes existing device tree to be broken so this cannot be merged even though you posted an another patch which resolves the dt broken issue. That is because each patch shouldn't incur any problem on working. So it'd be better to

[PATCH] drm/exynos: fimd: fix buffer size calculation

xup had already been posted by Daniel Stone, https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next Thanks, Inki Dae > > Signed-off by: Marek Szyprowski > CC: stable at vger.kernel.org # v4.0+ > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- &

[GIT PULL] exynos-drm-next

these features are not only safe enough but also aren't tested yet. So for them, I'd like to have enough times for the reviews. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 1d8ac08d498d579aae36221a80b4b724b2f52f39: Merg

[PATCH] drm/exynos: use drm_plane_force_disable

; +drm_plane_force_disable(plane); >> } > > Which tree did you based this code? I've removed all this code in atomic. > These two pieces of code makes no sense in atomic modesetting, disable would > be called from the drm atomic core there. Mr. Gustavo, C

[PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

On 2015년 04월 08일 03:39, Gustavo Padovan wrote: > Hi Inki, > > 2015-04-07 Inki Dae : > >> On 2015년 04월 07일 00:44, Inki Dae wrote: >>> 2015-04-06 19:46 GMT+09:00 Inki Dae : >>>> On 2015년 04월 04일 03:09, Gustavo Padovan wrote: >

[PATCH 1/2] drm/exynos: use src_x and src_y instead of fb_x and fb_y

On 2015년 04월 07일 15:59, Joonyoung Shim wrote: > It's more reasonable to use src_x and src_y to represent source as > counterpart of destination(crtc). Already we are using src_width and > src_height for width and height of source. 1 thourgh 2, Applied. Thanks, Inki Dae >

[PATCH v2 1/3] drm/exynos: fix typos in hdmi and mixer

On 2015년 04월 07일 08:14, Tobias Jakobi wrote: > Use the correct spelling for 'progressive'. 1 through 3, Applied. Thanks, Inki Dae > > Reviewed-by: Gustavo Padovan > Signed-off-by: Tobias Jakobi > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2

[PATCH] drm/exynos: dsi: remove the empty mode_valid callback

On 2015년 04월 02일 18:52, Hyungwon Hwang wrote: > Because the helper function which calls this callback checks whether > it is registered or not. It is not necessary if it does nothing. > So it would be better to remove the function for clarity. Applied. Thanks, Inki Dae > >

[PATCH] drm/exynos: fimd: check whether exynos_drm_crtc_create succeed or not

On 2015년 04월 01일 13:14, Hyungwon Hwang wrote: >>From the commit "drm/exynos: fix the execution order in FIMD > initialization" (598285bfdce46d7c47632a2ba4b980f60be4a677), the error > checking code is removed improperly. This patch fix the regression. Applied. Thanks,

[RFT PATCHv2] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

reason for this suggested Andrzej Hajda: the DP clock was disabled. > This clock is required by Display Port and is enabled by bootloader. > However when FIMD driver probing was deferred, the display power domain > was turned off. This effectively reset the value of DP clock enable >

[PATCH v4 6/8] drm/exynos: dsi: add support for Exynos5433

On 2015년 04월 07일 20:57, Hyungwon Hwang wrote: > This patch adds support for Exynos5433 mipi dsi. With this and other dsi relevant patches, display doesn't work - the screen is flickered and booting is halted. I think there is something you missed. Check it out again. Thanks,

[PATCH v4 5/8] drm/exynos: dsi: generalize register setting and clock control

use macro, last is to generalize register setting. Separate them into three patches. Thanks, Inki Dae > > Signed-off-by: Hyungwon Hwang > --- > Changes for v3: > - Separated from the patch "drm/exynos: dsi: add support for Exynos5433 SoC" > in version 2. > >

[PATCH v4 4/8] drm/exynos: dsi: rename pll_clk to sclk_clk

> return -EPROBE_DEFER; > } > > - dsi->pll_clk = devm_clk_get(dev, "pll_clk"); > - if (IS_ERR(dsi->pll_clk)) { > - dev_info(dev, "failed to get dsi pll input clock\n"); > - ret = PTR_ERR(dsi->pll_clk); > + dsi->sclk_clk = devm_clk_get(dev, "sclk_mipi"); You changed only clock name of driver so with this patch, dsi driver wouldn't work because device tree still has 'pll_clk' as clock name. And you should also consider backward compatibility because existing dtb has 'pll_clk' which cannot be changed. The change of clock name, pll_clk ->sclk_mipi, seems reasonable to me. Thanks, Inki Dae > + if (IS_ERR(dsi->sclk_clk)) { > + dev_info(dev, "failed to get dsi sclk clock\n"); > + ret = PTR_ERR(dsi->sclk_clk); > goto err_del_component; > } > > -- > 1.9.1 > >

[PATCH] drm/exynos/ipp: Validate buffer enqueue requests

on invalid buffers > (wiht no valid gem object handle i.e.). > Add some basic checks to rule out those potential issues. Applied. Thanks, Inki Dae > > Signed-off-by: Beata Michalska > [mszyprow: rebased onto v4.0-rc1 and adapted to recent ipp changes] > Signed-off-by: Marek

[PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

On 2015년 04월 07일 16:06, Inki Dae wrote: > On 2015년 04월 07일 00:44, Inki Dae wrote: >> 2015-04-06 19:46 GMT+09:00 Inki Dae : >>> On 2015년 04월 04일 03:09, Gustavo Padovan wrote: >>>> From: Gustavo Padovan >>>> >>>> Hi, >>

[PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

On 2015년 04월 07일 00:44, Inki Dae wrote: > 2015-04-06 19:46 GMT+09:00 Inki Dae : >> On 2015년 04월 04일 03:09, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>> Here goes the full support for atomic modesetting on ex

[PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

2015-04-06 19:46 GMT+09:00 Inki Dae : > On 2015년 04월 04일 03:09, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Hi, >> >> Here goes the full support for atomic modesetting on exynos. I've >> split the patches in the various phases of atomic

[PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

pm pm_runtime_work> After that, I tested it again without FIMD and the booting is ok. So I guess that this atomic feature has a bug to FIMD driver. Thanks, Inki Dae > > Gustavo > --- > > Gustavo Padovan (11): > drm/exynos: atomic phase 1: use drm_plane_helper_upd

[PATCH -v4 0/8] drm/exynos: clean up patches (preparing for atomic)

> v4 rebases on top of Daniel Stone patch, currently only applied to > exynos-drm-fixes Applied. Thanks, Inki Dae > > Gustavo Padovan (7): > drm/exynos: fimd: fix alpha setting for XR24 pixel format > drm/exynos: remove unused exynos_crtc->win_enable() callback >

[PATCH -v3 11/11] drm/exynos: atomic dpms support

ble callback isn't required for second argument so the build is failed like below, drivers/gpu/drm/exynos/exynos_hdmi.c: In function 'hdmi_dpms': drivers/gpu/drm/exynos/exynos_hdmi.c:2131:4: error: too many arguments to function 

[PATCH v3 1/8] drm/exynos: add Exynos5433 decon driver

do it ASAP. Thanks, Inki Dae [1] [PATCH -v4 0/8] drm/exynos: clean up patches (preparing for atomic) [2] [PATCH -v2 00/10] drm/exynos: Add atomic modesetting support On 2015년 03월 26일 20:15, Hyungwon Hwang wrote: > From: Joonyoung Shim > > DECON(Display and Enhancement Controlle

[PATCH -v4 5/8] drm/exynos: make zpos property immutable

lity of the existing application which uses set_property ioctl to be broken. Didn't you check my comment? http://www.spinics.net/lists/dri-devel/msg78852.html To other Exynos guys, Is there no any case that the hardware overlay should be configurable? If no case,

next trees

Hi Dave, In case of exynos DRM, There are a new driver - mic - , new feature support - atomic modeset/pageflip, and some cleanup for next. I'll have pull request ASAP. thanks, Inki Dae 2015년 4월 1일 수요일, Dave Airlie님이 작성한 메시지: > Hey, > > so outstand

[PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

Hello Javier, 2015-03-27 20:08 GMT+09:00 Javier Martinez Canillas : > Hello Inki, > > On Fri, Mar 27, 2015 at 2:47 AM, Inki Dae wrote: >> >> Right, this is not documented but if you have ever checked exynos drm >> driver tree, then I think you could know how we use

[PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

Hi Daniel, On 2015년 03월 26일 23:48, Daniel Stone wrote: > Hi Inki, > > On Thu, 26 Mar, 2015 at 2:32 PM, Inki Dae wrote: >> Applied. > > Thanks very much. > >> Could you use right prefix of the subject like below when you post patch? >> &g

[PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

On 2015년 03월 27일 09:15, Tobias Jakobi wrote: > Inki Dae wrote: >> Hello Javier, >> >> Applied. >> >> Could you use right prefix of the subject like below when you post patch? >> >> 'drm/exynos: ...', not 'drm: Exynos: ...' &

[PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

Hello Javier, Applied. Could you use right prefix of the subject like below when you post patch? 'drm/exynos: ...', not 'drm: Exynos: ...' Your email will be filtered from my mailbox if you don't use the right prefix so I couldn't check and take care of your patc

[PATCH v2 3/6] drm/exynos: mic: add MIC driver

bled: > + mutex_unlock(&mic_mutex); > +} > + > +struct drm_bridge_funcs mic_bridge_funcs = { > + .disable = mic_disable, > + .post_disable = mic_post_disable, > + .pre_enable = mic_pre_enable, > + .enable = mic_enable, > +}; > + > +int exynos_mic_probe(stru

[GIT PULL] exynos-drm-fixes

ve unnecessary file not used and fix trivial issues. Plese, kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 046d669c62f37323ef0329c41d83a03c06b2087d: [PATCH] drm/mm: Fix support 4 GiB and larger ranges (2015-03-16 06:28:50 +1000) are availa

[PATCH 2/2] drm/exynos: fix the initialization order in FIMD

[] > (gic_handle_irq+0x64/0x6c) > [1.956165] [] (gic_handle_irq) from [] > (__irq_svc+0x40/0x74) > [1.963626] Exception stack(0xee901f98 to 0xee901fe0) > [1.968661] 1f80: > 0000 > [1.976823] 1fa0: ee901fe8

[PATCH 1/2] drm/exynos: add more condition to check iommu support

nel_init_freeable+0x1d4/0x278) > [1.510787] [] (kernel_init_freeable) from [] > (kernel_init+0xc/0xe8) > [1.518859] [] (kernel_init) from [] > (ret_from_fork+0x14/0x24) > [1.526406] Code: e3130004 1a1e e3a06000 eacf (e7f001f2) > [1.532505] ---[ end trace

[PATCH 0/7] drm/exynos: clean ups

On 2015년 03월 13일 03:45, Gustavo Padovan wrote: > 2015-03-12 Inki Dae : > >> On 2015년 02월 19일 22:22, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>> Here goes some clean ups to the exynos drivers. The

[PATCH 0/7] drm/exynos: clean ups

vice 'omapdrm'...failed. trying to open device 'exynos'...success. testing 100x100 at XR24 overlay plane 25 testing 100x100 at XR24 overlay plane 26 Still no screen. Thanks, Inki Dae > > > Gustavo Padovan (6): > drm/exynos: remove unused exynos_crtc->wi

[PATCH 4/7] drm/exynos: make zpos property immutable

bout leaving warning message 'the hardware overlay cannot be changed to another anymore' when the set_property ioctl is requested by user-space, and returning just 0? Thanks, Inki Dae > }; > > static void exynos_plane_attach_zpos_property(struct drm_plane *pla

[PATCH 2/5] drm/exynos: use correct fb width/height

On 2015년 03월 07일 06:23, Rob Clark wrote: > Signed-off-by: Rob Clark Signed-off-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exyno

[v3] libdrm: improvements to userspace exynos component

et by ALPHA_REG(0x618) */ + /* Global Color and Alpha: Set by ALPHA_REG(0x618) */ for all patches - 1 though 17, Signed-off-by : Inki Dae Thanks, Inki Dae > > > With best wishes, > Tobias > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sa

[PATCH v3 14/17] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR

RGB order) AlphaValue [7:0] Global alpha value So right comment would be "Global Color and Global Alpha". Thanks, Inki Dae > G2D_COEFF_MODE_GB_COLOR, > /* (1-SRC alpha)/DST Alpha */ > G2D_COEFF_MODE_DISJOINT_S, >

[v3] libdrm: improvements to userspace exynos component

ons please speak up. >> I doubt you're going to hear anything from Inki Dae. > Despite that it might sound a bit rude, I sincerely hope that you're > wrong on this one. I'm would assume that the lack of reply from Inki was > due to being him busy, rather than ignoring yo

[PATCH] drm/exynos: Check for NULL dereference of crtc

On 2015년 03월 06일 23:04, Charles Keepax wrote: > On Fri, Mar 06, 2015 at 10:13:42PM +0900, Inki Dae wrote: >> On 2015년 02월 18일 02:14, Charles Keepax wrote: >>> The commit "drm/exynos: remove exynos_plane_dpms" (d9ea6256) removed the >>> use of the en

[PATCH] drm/exynos: fix typo config name correctly.

This patch fixes DRM_EXYNOS7DECON to DRM_EXYNOS7_DECON. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index a5e7461..0a67803 100644 --- a/drivers

[PATCH] drm/exynos: Check for NULL dereference of crtc

it's strange. plane->funcs->destroy() is called prior to crtc->funcs->destroy() so it should be exynos_crtc is not NULL. However, it seems there is any corner case we didn't catch up. Applied. Thanks, Inki Dae > Arndale: > > [1.673479] Unable to handle kernel NULL

[patch] drm/exynos: IS_ERR() vs NULL bug

On 2015년 02월 20일 19:54, Dan Carpenter wrote: > of_iomap() doesn't return error pointers, it returns NULL on error. Applied. Thanks, Inki Dae > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c > b/drivers/gpu/drm/exy

[PATCH] drm/exynos: remove unused files

On 2015년 02월 18일 20:17, Andrzej Hajda wrote: > These files are not used anymore. Applied. Thanks, Inki Dae > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_connector.c | 245 > -- > drivers/gpu/drm/exynos/exynos_

[PATCH 2/2] drm/exynos: decon: Add support for DECON-EXT

_ext_porchs[MODE_1920_1080_24]; >>> + >>> + decon_ext_set_timing(mode, my_mode); >>> + } >>> + >> >> I guess these ugly ifs could be replaced by simple loop: >> for (i = 0; i < ARRAY_SIZE(decon_ext_porchs); ++i) { >> if (mode->hdisplay != decon_ext_porchs[i].hdisplay || ...) >> continue; >> decon_ext_set_timing(mode, &decon_ext_porchs[i]); >> break; >> } > Ok, Though the number of checks is the same, your code at least looks better. > :) > >> Anyway I have doubts if commit should modify crtc.base.mode I guess >> better place for it can be in *_fixup callback. > Inki? What is your suggestion? Agree with Andrzej. The fixup callback would be a right place to find a valid mode. By the way, what if mode->hdisplay/vdisplay/vrefresh are not supported for all DECON_EXT modes? Thanks, Inki Dae

drm/exynos: DRM_EXYNOS7DECON?

ght. It's my mistake. That is just typo so it should be DRM_EXYNOS7_DECON instead of DRM_EXYNOS7DECON. It would be fixed at RC1. Thanks for report, Inki Dae > > > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc

[GIT PULL] exynos-drm-next for 3.20

- Add a new display controller dirver, DECON which is a new display controller of Exynos7 SoC. This device is much different from FIMD of Exynos4 and Exynos4 SoC series. Kindly let me know if there is any problem. Thanks, Inki Dae The following changes since c

[PATCH 4/4] drm/exynos: fix NULL pointer reference

On 2015년 02월 05일 16:11, Joonyoung Shim wrote: > There is a case called disable_plane callback function even if > plane->crtc is NULL from exynos_drm_encoder_disable and it will cause > NULL pointer reference error. Applied. (patch 1 though 4) Thanks, Inki Dae > > Signed

[PATCH V4] drm/exynos: Add DECON driver

, Inki Dae On 2015년 02월 11일 19:43, Ajay kumar wrote: > ping. > > On Thu, Feb 5, 2015 at 9:24 PM, Ajay Kumar > wrote: >> This patch is based on exynos-drm-next branch of Inki Dae's tree at: >> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exyno

[PATCH -v2 10/14] drm/exynos: atomic phase 1: add atomic_begin()/atomic_flush()

On 2015년 02월 10일 02:07, Gustavo Padovan wrote: > 2015-02-09 Daniel Stone : > >> Hi Inki, >> >> On 9 February 2015 at 14:53, Inki Dae wrote: >>> I'm merging this patch series but I found two issues. One is already >>> pointed out. >>

[PATCH -v2 10/14] drm/exynos: atomic phase 1: add atomic_begin()/atomic_flush()

(__device_release_driver+0x70/0xc4) [ 230.987615] [] (__device_release_driver) from [] (device_release_driver+0x1c/0x28) [ 230.996904] [] (device_release_driver) from [] (unbind_store+0x78/0xf8) [ 231.005240] [] (unbind_store) from [] (kernfs_fop_write+0xb8/0x19c) [ 231.013223] [] (kernfs_fop_write) from [] (vfs_write+0xa0/0x1ac) [ 231.020946] [] (vfs_write) from [] (SyS_write+0x44/0x9c) [ 231.027983] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x34) [ 231.035523] ---[ end trace 954377a3aab4ab59 ]--- [ 231.042414] lcd0-power-domain: Power-off latency exceeded, new value 201333 ns This warning would mean a fb object leak and while I have a review, I couldn't find why it causes the leak. However, I'd like to merge this patch series this time and fix this issue at RC for phase 3. Thanks, Inki Dae

[PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

On 2015년 02월 09일 19:57, Sylwester Nawrocki wrote: > On 07/02/15 12:53, Inki Dae wrote: >> This patch fixes the issue that the try to get a phy object is failed >> to enable mipi phy. >> >> System and power management unit registers should be controlled by >>

[PATCH 4/4] ARM: dts: exynos5420: use pmureg device node to enable mipi phy

This patch removes mipi phy relevant properties from dsim device node and makes the pmureg device node to be used instead to enable mipi phy. Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos5420.dtsi |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 3/4] ARM: dts: exynos3250: use pmureg device node to enable mipi phy

This patch removes mipi phy relevant properties from dsim device node and makes the pmureg device node to be used instead to enable mipi phy. Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos3250.dtsi |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 2/4] ARM: dts: exynos4: use pmureg device node to enable mipi phy

This patch removes mipi phy relevant properties from dsim device node and makes the pmureg device node to be used instead to enable mipi phy. Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos4.dtsi |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

... }; ... }; With above, we will find below message while booting, can't request region for resource [mem 0x10020710-0x10020717] Signed-off-by: Inki Dae --- .../devicetree/bindings/video/exynos_dsim.txt |9 ++-- drivers/gpu/drm/exyn

<    4   5   6   7   8   9   10   11   12   13   >