Hi Daniel -
On Thu, 07 Jun 2012, Daniel Vetter daniel.vet...@ffwll.ch wrote:
I've done an audit of everything which is being set up between the
place where drm_pci_agp_init is called currently and where the
driver's -load function is called. Nothing seems to depend upon
dev-agp being set up
On Thu, 07 Jun 2012, Daniel Vetter daniel.vet...@ffwll.ch wrote:
To be able to directly set up the intel-gtt code from drm/i915 and
avoid setting up the fake-agp driver we need to prepare a few things:
- pass both the bridge and gpu pci_dev to the probe function and add
code to handle the
On Fri, 08 Jun 2012, Daniel Vetter daniel.vet...@ffwll.ch wrote:
There's the neat little problem that some systems die if vga decoding
isn't decoded anywhere, because linux disabled that pci device.
Atm we solve that problem by simple not calling pci_disable_device at
driver unregister time
On Thu, 07 Jun 2012, Daniel Vetter daniel.vet...@ffwll.ch wrote:
We need it for all things ums (which essentially only means up to
gen5) and to support b0rked XvMC userspace on gen3.
Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_dma.c | 21
).
On the series and the fixes to it, with the disclaimer that I don't have
much experience with drm/i915/gtt yet:
Reviewed-by: Jani Nikula jani.nik...@linux.intel.com
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org
drm_lastclose at the
right places in the error paths for all callers of drm_fill_in_dev.
v2: Fixup the error-path confusion in drm_usb.c, noticed by Jani
Nikula.
You could just claim you planted it there for me. ;)
On the series,
Reviewed-by: Jani Nikula jani.nik...@linux.intel.com
Signed-Off
://bugzilla.kernel.org/show_bug.cgi?id=45881
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_crt.c | 36 +---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915
On Mon, 13 Aug 2012, Daniel Vetter dan...@ffwll.ch wrote:
On Sun, Aug 12, 2012 at 11:49:22PM -0400, George Spelvin wrote:
(Bringing this back to the mailing lists after a bit of uninteresting private
conversation.)
Honestly, I think we need a way to force disable gmbus with a module
Hi, this series addresses the EDID related memory leaks [1] by removing
raw_edid altogether. Applies on drm-fixes. Please review.
BR,
Jani.
[1] http://mid.gmane.org/20120811165118.gb18...@n2100.arm.linux.org.uk
Jani Nikula (4):
drm/i915: fix EDID memory leak in SDVO
drm/ast: fix EDID memory
The EDID returned by drm_get_edid() was never freed.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/ast/ast_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7282c08..866e9d4
and
dangling pointers.
Remove the raw_edid field, and fix drivers as necessary.
Reported-by: Russell King li...@arm.linux.org.uk
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_edid.c|3 ---
drivers/gpu/drm/drm_edid_load.c | 23
The EDID returned by drm_get_edid() was never freed.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_sdvo.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
b/drivers/gpu/drm/i915/intel_sdvo.c
index
The EDID returned by drm_get_edid() was never freed.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/exynos/exynos_hdmi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/gma500/psb_intel_sdvo.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c
b/drivers/gpu/drm/gma500/psb_intel_sdvo.c
index a453d94..d35f93b 100644
--- a/drivers/gpu
On Thu, 16 Aug 2012, Jerome Glisse j.gli...@gmail.com wrote:
On Thu, Aug 16, 2012 at 11:13 AM, Jani Nikula
jani.nik...@linux.intel.com wrote:
There's a bug [1] where the faster GMBUS transmissions fail with some
CRTs, and the fix [2] is to fallback to GPIO bit-banging upon errors. As
noted
On Fri, 17 Aug 2012, Damien Lespiau damien.lesp...@gmail.com wrote:
From: Damien Lespiau damien.lesp...@intel.com
Signed-off-by: Damien Lespiau damien.lesp...@intel.com
Reviewed-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_modes.c |3 ---
include/drm/drm_crtc.h
Another reference to raw_edid field of struct drm_display_info was added in
gma500 while the whole field was being removed, causing build
failure. Remove the hopefully last references to raw_edid.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Jani Nikula jani.nik...@intel.com
here instead of trying to limp along.
Hi Grant, please try v3.6-rc6 that does exactly that with:
commit 28dcc2d60cb570d9f549c329b2f51400553412a1
Author: Jani Nikula jani.nik...@intel.com
Date: Mon Sep 3 16:25:12 2012 +0300
drm/i915: do not expose a dysfunctional backlight interface
On Tue, 18 Sep 2012, Daniel Vetter daniel.vet...@ffwll.ch wrote:
+#ifdef CONFIG_LOCKDEP
+struct lockdep_map console_lock_dep_map = {
+ .name = console_lock
+};
+#endif
static?
BR,
Jani.
___
dri-devel mailing list
On Wed, 19 Sep 2012, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Wed, 19 Sep 2012 11:12:41 +1000, Dave Airlie airl...@gmail.com wrote:
From: Dave Airlie airl...@redhat.com
We hit this a lot with i915 and although we'd like to engineer things to hit
it a lot less, this commit at least
On Tue, 18 Sep 2012, Adam Jackson a...@redhat.com wrote:
v2: Fix parenthesis mismatch, spotted by Jani Nikula
Tested-by: Takashi Iwai ti...@suse.de
Signed-off-by: Adam Jackson a...@redhat.com
---
drivers/gpu/drm/i915/intel_dp.c | 25 -
1 files changed, 20
On Thu, 27 Sep 2012, Seung-Woo Kim sw0312@samsung.com wrote:
Increasing ref counts of both dma-buf and gem for imported dma-buf come from
gem
makes memory leak. release function of dma-buf cannot be called because
f_count
of dma-buf increased by importing gem and gem ref count cannot be
On Fri, 05 Oct 2012, taiten...@gmail.com taiten...@gmail.com wrote:
I found a potential bug for i915 regarding to ELD parsing.
I was trying to monitor ELD by watching /proc/asound/card0/eld#3.0
and I realized that the ELD might failed to read from HDMI when AC
power is not plugged. This
On Fri, 28 Sep 2012, Ian Pilcher arequip...@gmail.com wrote:
Add the ability for users to define their own EDID quirks via a
module parameter or sysfs attribute.
Hi Ian -
IMHO this patch should be chopped up to smaller pieces. For example,
change the edid_quirk_list format first (if you must),
pushing the patches. I can
merely offer my review comments and opinions to hopefully make those
decisions easier for others. Patches that attract review probably have a
better chance of getting pushed than patches that nobody cares about.
BR,
Jani.
On Oct 9, 2012 7:10 AM, Jani Nikula jani.nik
On Fri, 12 Oct 2012, Rob Clark rob.cl...@linaro.org wrote:
From: Rob Clark r...@ti.com
Nitpick: no commit message, and subject fails to mention
drm_connector_attach_property - drm_object_attach_property. Regardless,
for this patch,
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off
On Fri, 12 Oct 2012, Rob Clark rob.cl...@linaro.org wrote:
From: Rob Clark r...@ti.com
Replace references to and remove the connector property fxns, which
have been superseded with the more general object property fxns:
fxns? meh.
For this patch,
Reviewed-by: Jani Nikula jani.nik
,
Jani.
Jani Nikula (1):
drm/i915/lvds: move fitting mode from intel_lvds_connector to
intel_panel
Yuly Novikov (2):
drm/i915/dp: allow configuring eDP panel fitting scaling mode
drm/i915/dp: change eDP default scaling mode to respect aspect ratio
drivers/gpu/drm/i915/intel_dp.c
Prepare for supporting scaling mode configuration also in eDP.
Includes a drive-by-removal of an outdated comment about fitting mode.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_drv.h |1 +
drivers/gpu/drm/i915/intel_lvds.c | 24
From: Yuly Novikov ynovi...@chromium.org
LVDS allowed changing panel fitting scaling mode, while eDP didn't. Copied
relevant code from LVDS to eDP.
Signed-off-by: Yuly Novikov ynovi...@chromium.org
[Jani: use fitting mode in intel_panel, remove default mode change]
Signed-off-by: Jani Nikula
From: Yuly Novikov ynovi...@chromium.org
Signed-off-by: Yuly Novikov ynovi...@chromium.org
[Jani: ripped this change separate from the scaling mode change support]
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c |4 ++--
1 file changed, 2 insertions(+), 2
Author: Jani Nikula jani.nik...@intel.com
Date: Wed Sep 26 18:43:10 2012 +0300
drm/i915: use adjusted_mode instead of mode for checking the 6bpc force
flag
commit 0c96c65b48fba3ffe9822a554cbc0cd610765cd5 upstream.
The dithering introduced in
commit
On Tue, 30 Oct 2012, Jani Nikula jani.nik...@intel.com wrote:
Hi Ted -
On Tue, 30 Oct 2012, Theodore Ts'o ty...@mit.edu wrote:
I recently upgraded to 3.6.3, and my Lenovo X230 has stopped being able
to work with an HP ZR30w 30 2560x1600 display. I saw the following
messages in the dmesg
On Tue, 13 Nov 2012, Andy Gross andy.gr...@ti.com wrote:
Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a
refill engine.
Signed-off-by: Andy Gross andy.gr...@ti.com
---
drivers/staging/omapdrm/omap_dmm_tiler.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
On Thu, 22 Nov 2012, Henrik Rydberg rydb...@euromail.se wrote:
Yeah, the utter lack of a vbt fits very nicely, thanks for checking,
I've merged the patch into drm-intel-fixes and will forward it for
inclusion into 3.7 rsn.
Great, thanks. One thing about that patch: if we would ever encounter
On Thu, 06 Dec 2012, Tim Gardner tim.gard...@canonical.com wrote:
smatch warning:
drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function puts
500 bytes on stack
Refactor so that saved_mode and saved_hwmode are dynamically allocated as
opposed
to being automatic
On Fri, 07 Dec 2012, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula jani.nik...@linux.intel.com
wrote:
On Thu, 06 Dec 2012, Tim Gardner tim.gard...@canonical.com wrote:
+ if (!saved_mode) {
+ pr_err(i915: Could not allocate saved
variables. 500 bytes seems like it could run the potential
for blowing
the kernel stack.
Reviewed-by: Jani Nikula jani.nik...@intel.com
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: David Airlie airl...@linux.ie
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Tim Gardner tim.gard
On Fri, 07 Dec 2012, Sachin Kamat sachin.ka...@linaro.org wrote:
drm/drm_edid.h was included twice.
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/i915/intel_modes.c |1 -
1 files changed, 0 insertions(+), 1
choose to do anything about the two nitpicks
below or not,
Reviewed-by: Jani Nikula jani.nik...@intel.com
Cc: Dave Airlie airl...@redhat.com
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
drivers/gpu/drm/drm_mm.c | 42
list-map is struct drm_local_map *, not struct drm_map_list *.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_gem.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 24efae4..6337edd 100644
/
The patch is good. connector-display_info.raw_edid is gone since
commit 451023dc32d4542c21b52ad1692e6e01cb75b099
Author: Jani Nikula jani.nik...@intel.com
Date: Wed Aug 15 09:32:39 2012 +
drm: remove the raw_edid field from struct drm_display_info
BR,
Jani.
For now, please drop
Hi Laurent -
On Mon, 17 Dec 2012, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote:
Hi Tomi,
I finally have time to work on a v3 :-)
On Friday 23 November 2012 16:51:37 Tomi Valkeinen wrote:
On 2012-11-22 23:45, Laurent Pinchart wrote:
From: Laurent Pinchart
Hi Laurent -
On Tue, 18 Dec 2012, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote:
Hi Jani,
On Monday 17 December 2012 18:53:37 Jani Nikula wrote:
I can see the need for a framework for DSI panels and such (in fact Tomi
and I have talked about it like 2-3 years ago already
On Mon, 24 Dec 2012, John zendhet...@gmail.com wrote:
On launchpad they requested to report this bug upstream. Please let me know
if any information is missing.
Please file a bug on DRM/Intel at [1]. Please reference your mail and
the launchpad bug, no need to attach all the info there again.
On Thu, 10 Jan 2013, Inki Dae inki@samsung.com wrote:
2013/1/10 Laurent Pinchart laurent.pinch...@ideasonboard.com:
Hi Vikas,
Thank you for the patch.
On Friday 04 January 2013 10:24:04 Vikas Sajjan wrote:
On 3 January 2013 16:29, Tomasz Figa t.f...@samsung.com wrote:
On Wednesday 02
On Mon, 14 Jan 2013, Jiri Slaby jsl...@suse.cz wrote:
On 01/14/2013 01:56 PM, Rafael J. Wysocki wrote:
On Monday, January 14, 2013 11:11:52 AM Jiri Slaby wrote:
Hi,
since friday's -next (the last known to be working is the last monday's)
I cannot resume from suspend. The last thing I see
On Wed, 16 Jan 2013, Lucas Stach d...@lynxeye.de wrote:
Am Mittwoch, den 16.01.2013, 16:23 +0100 schrieb Thierry Reding:
On Wed, Jan 16, 2013 at 03:36:41PM +0100, Lucas Stach wrote:
[...]
@@ -705,7 +705,7 @@ static int standard_timing_level(struct edid *edid)
* monitors fill with ascii
On Fri, 11 Jan 2013, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote:
Would anyone be interested in meeting at the FOSDEM to discuss the Common
Display Framework ? There will be a CDF meeting at the ELC at the end of
February, the FOSDEM would be a good venue for European developers.
On Thu, 24 Jan 2013, Su, Xuemin xuemin...@intel.com wrote:
On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote:
}
+ /* some buggy driver may return NULL here, which may cause panic */
+ BUG_ON(!fb);
I fail to see the benefit of this compared to just letting it oops
On Thu, 24 Jan 2013, Sean Paul seanp...@chromium.org wrote:
+static int ptn3460_power_up(struct ptn3460_platform_data *pd)
+{
+ int ret;
+
+ if (pd-gpio_pd_n 0)
+ gpio_set_value(pd-gpio_pd_n, 1);
Hi Sean, just a random thing that caught my eye: last I checked 0 is a
On Mon, 28 Jan 2013, Sedat Dilek sedat.di...@gmail.com wrote:
...
static struct intel_quirk intel_quirks[] = {
/* HP Mini needs pipe A force quirk (LP: #322104) */
{ 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
...
}
Triple - which value is what?
I guess you figured it out,
Hi Florian, all -
First, thanks for your work on adding the bugzilla comments when patches
referencing bugs get merged. I find it useful.
Recently however there was a comment about a commit referencing a commit
referencing the bug report. Turns out the comment was missing one level
of
On Wed, 30 Jan 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
While old platforms had 3 transcoders and 3 pipes (1:1), HSW has 4
transcoders and 3 pipes. To avoid future mistakes transcoders must be used
here instead of pipes even though it is working right now by coincidence.
On Wed, 30 Jan 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
From: Shobhit Kumar shobhit.ku...@intel.com
Signed-off-by: Sateesh Kavuri sateesh.kav...@intel.com
v2: Modified and corrected the structures to be more in line for
kernel coding guidelines and rebased the code on Paulo's DP
On Wed, 30 Jan 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
drm_i915_private is getting bigger and bigger when adding new vbt stuff.
So, the better way of getting drm_i915_private organized is to create an
special structure for vbt stuff.
Reviewed-by: Jani Nikula jani.nik...@intel.com
On Wed, 30 Jan 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
From: Shobhit Kumar shobhit.ku...@intel.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
v2: reuse of just created is_edp_psr and put it at right place.
A couple of nitpicks below, but either way,
Reviewed-by: Jani
On Wed, 30 Jan 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
From: Shobhit Kumar shobhit.ku...@intel.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
v2: Created aux_clock_divider function to avoid duplicated code.
Bikeshed, that could be a prep patch, but I won't insist on it.
and bikeshedding below, but regardless,
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com
---
drivers/gpu/drm/i915/i915_reg.h | 24 ++
drivers/gpu/drm/i915/intel_ddi.c | 6 +-
drivers/gpu/drm/i915/intel_dp.c | 172
On Wed, 30 Jan 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
PSR must be enabled after transcoder and port are running.
And it is only available for HSW.
v2: move enable/disable to intel_ddi
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off-by: Rodrigo Vivi rodrigo.v
On Wed, 06 Feb 2013, Tomi Valkeinen tomi.valkei...@ti.com wrote:
6. Miscellaneous
- If the OMAP3 DSS driver is used as a model for the DSI support
implementation, Daniel Vetter requested the DSI bus lock semaphore to be
killed as it prevents lockdep from working correctly
On Fri, 08 Feb 2013, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote:
If the -M parameter is specific, modetest will use the requested device
name instead of trying its builtin list of device names.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
) {
+fprintf(stderr, no device found.\n, module);
I should sleep before sending patches... Sorry for the noise, v3 will fix
that.
If you fix that bit, you can slam my
Reviewed-by: Jani Nikula jani.nik...@intel.com
on the series.
___
dri
list-map is struct drm_local_map *, not struct drm_map_list *.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
Found this small snippet laying around, I guess it fell between the cracks.
---
drivers/gpu/drm/drm_gem.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, 29 Jan 2013, Daniel Vetter daniel.vet...@ffwll.ch wrote:
On Mon, Jan 14, 2013 at 3:37 PM, Paul Menzel
paulepan...@users.sourceforge.net wrote:
Am Montag, den 14.01.2013, 11:06 +0100 schrieb Daniel Vetter:
This reverts commit 6f33814bd4d9cfe76033a31b1c0c76c960cd8e4b.
The quirk cause a
On Tue, 26 Feb 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
Adding Enable and Disable PSR functionalities. This includes setting the
PSR configuration over AUX, sending SDP VSC DIP over the eDP PIPE config,
enabling PSR in the sink via DPCD register and finally enabling PSR on
the host.
On Wed, 06 Mar 2013, Daniel Vetter daniel.vet...@ffwll.ch wrote:
On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung ble...@chromium.org wrote:
I'm working on touch devices Chromium OS, and I've noticed a
regression between 3.8 and 3.9-rc1, which was posted yesterday.
The hardware in question is a
Hi, please find some review comments inline.
BR,
Jani.
On Sat, 23 Mar 2013, Dylan Semler dylan.sem...@gmail.com wrote:
There is at least one monitor that doesn't report its native resolution
in its EDID block. This enhancement extends the EDID quirk logic to
make monitors like this just
On Mon, 25 Mar 2013, Dylan Semler dylan.sem...@gmail.com wrote:
On Mon, Mar 25, 2013 at 9:41 AM, Jani Nikula jani.nik...@linux.intel.com
wrote:
Hi, please find some review comments inline.
You make some good points, thanks.
On Sat, 23 Mar 2013, Dylan Semler dylan.sem...@gmail.com wrote
On Wed, 03 Apr 2013, Dylan Semler dylan.sem...@gmail.com wrote:
Version 3 was Acked by Daniel Vetter[1]. Any chance ajax can give his
comments?
[1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html
FWIW,
Reviewed-by: Jani Nikula jani.nik...@intel.com
On Fri, 03 May 2013, Daniel Vetter dan...@ffwll.ch wrote:
On Fri, May 03, 2013 at 11:17:42AM +0200, dl...@gmx.de wrote:
From: Jan-Simon Möller dl...@gmx.de
Description:
intel_gmbus_is_forced_bit is no extern as its body is right below.
Likewise for intel_gmbus_is_port_valid.
This fixes a
On Wed, 08 May 2013, Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Wed, May 08, 2013 at 05:03:31PM +0100, Damien Lespiau wrote:
+static const char *connector_status_str(enum drm_connector_status status)
+{
+switch (status) {
+case connector_status_connected:
+
On Thu, 25 Jul 2013, Sedat Dilek sedat.di...@gmail.com wrote:
On Thu, Jul 25, 2013 at 12:02 PM, Sedat Dilek sedat.di...@gmail.com wrote:
On Thu, Jul 25, 2013 at 11:44 AM, Jani Nikula
jani.nik...@linux.intel.com wrote:
On Thu, 25 Jul 2013, Sedat Dilek sedat.di...@gmail.com wrote:
On Thu, Jul
From: Shobhit Kumar shobhit.ku...@intel.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_crtc.c |2 ++
include/uapi/drm/drm_mode.h |2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm
to disable the ACPI backlight interface. acpi_backlight=DTRT? ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, 10 Sep 2013, Matthew Garrett matthew.garr...@nebula.com wrote:
On Tue, 2013-09-10 at 16:53 +0300, Jani Nikula wrote:
I think the parameter Does the ACPI backlight interface work or not
belongs to the ACPI video driver.
That depends on how Windows 8 works. If Windows 8 policy
, if we tell the BIOS we're Windows 8 to use the tested BIOS code
paths, what guarantees do we have of UEFI+CSM or legacy boots working?
BR,
Jani.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=47941#c96
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 11 Sep 2013, Matthew Garrett matthew.garr...@nebula.com wrote:
On Wed, 2013-09-11 at 11:45 +0300, Jani Nikula wrote:
Before plunging forward, have you observed any difference between the
boot modes? We have reports [1] that the backlight behaviour is
different with UEFI vs. UEFI+CSM
.
+EXPORT_SYMBOL(acpi_video_verify_backlight_support);
+
/*
* Use acpi_backlight=vendor/video to force that backlight switching
* is processed by vendor specific acpi drivers or video.ko driver.
--
1.8.4.12.g2ea3df6
--
Jani Nikula, Intel Open Source Technology Center
On Tue, 24 Sep 2013, Dan Carpenter dan.carpen...@oracle.com wrote:
The | operation has higher precedence than ?: so the macro always
returns GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Reviewed-by: Jani Nikula jani.nik...@intel.com
Introduced
in thinkpad-acpi module;
2 Remove unnecessary function acpi_video_unregister introduced in
patch 2/3 as pointed out by Jani Nikula.
v2:
v1 has the subject of Rework ACPI video driver and is posted here:
http://lkml.org/lkml/2013/9/9/74
Since the objective is really to fix Win8
On Wed, 25 Sep 2013, Jörg Otte jrg.o...@gmail.com wrote:
2013/9/25 Jani Nikula jani.nik...@linux.intel.com:
On Wed, 25 Sep 2013, Aaron Lu aaron...@intel.com wrote:
On Wed, Sep 25, 2013 at 10:29:37AM +0200, Jörg Otte wrote:
Backlight can't be modified with this patch set - neither
On Fri, 27 Sep 2013, Patrik Jakobsson patrik.r.jakobs...@gmail.com wrote:
+#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
Hi, while at it, you should probably let backlight be built as module:
#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
Cheers,
Jani.
--
Jani Nikula, Intel Open Source Technology
Detailed cap info at address 80h is not available with DPCD ver
1.0. Whether such devices exist in the wild I don't know, but there
should be no harm done in having the defines for downstream port 0 in
address 05h.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
include/drm/drm_dp_helper.h
We haven't read the downstream port caps for DPCD 1.0, so don't use
them.
v2: use defines for DPCD 1.0 downstream port types
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff
We have some code duplication related to EDID duplication. Add a helper.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_edid.c | 12
include/drm/drm_crtc.h |1 +
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
index 4400330..26e089f 100644
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 95a3159..aed9d67 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
None of the DP DPCD helpers need to modify the DPCD.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_dp_helper.c | 16
include/drm/drm_dp_helper.h | 16
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu
On Sat, 28 Sep 2013, Alex Deucher alexdeuc...@gmail.com wrote:
Return -ENOMEM if the allocation fails.
Signed-off-by: Alex Deucher alexander.deuc...@amd.com
Reviewed-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/drm_edid.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
v2: duplicate intel_connector-edid, not uninitialized edid (Dave Airlie).
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
in early boot. An alternative would be to
use request_firmware_nowait(), but that seems like it could get messy.
I don't know if that fits in with what you're doing, or whether you'd
like to do that, but it's something to think about while at it.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology
-by: Chris Wilson ch...@chris-wilson.co.uk
Cc: Ville Syrjälä ville.syrj...@linux.intel.com
Cc: Jani Nikula jani.nik...@linux.intel.com
---
drivers/gpu/drm/drm_edid_load.c | 108
+++
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu
the end of the fwdata (Ville)
v4: Restore the lost parenthesis (Jani)
Thanks, looks good,
Jani.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Cc: Ville Syrjälä ville.syrj...@linux.intel.com
Cc: Jani Nikula jani.nik...@linux.intel.com
Reviewed-by: Jani Nikula jani.nik...@linux.intel.com
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
include/drm/drm_dp_helper.h |7 +++
1 file changed, 7 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index ae8dbfb..fdf58fa 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm
It's not really needed, rather just adds another place to hold
intermediate values that could go wrong, and it's not clear that the
training pattern set or training lane set should be written at this
point at all.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/radeon/atombios_dp.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atombios_dp.c
b/drivers/gpu/drm/radeon/atombios_dp.c
index 0088541..fb3ae07 100644
--- a/drivers/gpu/drm
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http
://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
1 - 100 of 5152 matches
Mail list logo
