All users of drm_bridge_get_edid() have been converted to use
drm_bridge_edid_read(). Remove drm_bridge_get_edid().
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_bridge.c | 28 ++--
include/drm/drm_bridge.h | 2 --
2 files changed, 2 insertions(+), 28 deletions
Prefer using the struct drm_edid based functions.
Not ideal, should use source physical address from connector info.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/meson/meson_encoder_hdmi.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu
If EDID read fails, clear the EDID property.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Prefer using the struct drm_edid based functions.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/ti-tfp410.c | 16
1 file changed, 8 insertions(+), 8
If EDID read fails, clear the EDID property.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/simple-bridge.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Prefer using the struct drm_edid based functions.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 10 +-
1 file changed, 5 insertions(+), 5
Prefer using the struct drm_edid based functions.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/simple-bridge.c | 16
1 file changed, 8 insertions(+), 8
Prefer using the struct drm_edid based functions.
Cc: Adrien Grassein
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 8
1 file changed, 4
If EDID read fails, clear the EDID property.
Cc: Adrien Grassein
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +-
1 file changed, 1 insertion
Prefer using the struct drm_edid based functions.
cc: Adrien Grassein
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 12 ++--
1 file changed
Prefer using the struct drm_edid based functions.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 12 ++--
1 file changed, 6 insertions(+), 6
Prefer using the struct drm_edid based functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_bridge_connector.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/drm_bridge_connector.c
b/drivers/gpu/drm/drm_bridge_connector.c
index
Add new struct drm_edid based ->edid_read hook and
drm_bridge_edid_read() function to call the hook.
v2: Include drm/drm_edid.h
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_bridge.c | 46 +++-
include/drm/drm_bridge.h | 33 ++
patches towards the end of the series, but I just wanted to get the
series out the door now.
BR,
Jani.
Jani Nikula (39):
drm/bridge: add ->edid_read hook and drm_bridge_edid_read()
drm/bridge: switch to drm_bridge_read_edid()
drm/bridge: chrontel-ch7033: switch to drm_bridge_read_e
On Sat, 23 Dec 2023, Dario Binacchi wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi
> Reviewed-by: Jani Nikula
Thanks for the patch, pushed to drm-misc-next.
BR,
Jani.
>
> ---
>
> Chang
@
> #include
> #include
> #include
> +#include
Unnecessary.
Other than that,
Reviewed-by: Jani Nikula
> #include
>
> #include "drm_crtc_internal.h"
> @@ -6989,28 +6990,6 @@ int drm_add_modes_noedid(struct drm_connector
> *connector,
> }
i915/i915_perf.c| 39 -
2 files changed, 35 insertions(+), 6 deletions(-)
--
Jani Nikula, Intel
On Fri, 22 Dec 2023, Dmitry Baryshkov wrote:
> On Thu, 26 Oct 2023 at 12:40, Jani Nikula wrote:
>>
>> Add new struct drm_edid based ->edid_read hook and
>> drm_bridge_edid_read() function to call the hook.
>>
>> Signed-off-by: Jani Nikula
>>
On Fri, 22 Dec 2023, Jani Nikula wrote:
> On Fri, 22 Dec 2023, Neil Armstrong wrote:
>> On 19/12/2023 13:15, Jani Nikula wrote:
>>> On Tue, 14 Nov 2023, Jani Nikula wrote:
>>>> On Thu, 26 Oct 2023, Jani Nikula wrote:
>>>>> This is just the first
;drm-xe drm-xe-next-fixes"
>
> "drm-misc drm-misc-next"
> "drm-intel drm-intel-next"
> "drm-intel drm-intel-gt-next"
> + "drm-xe drm-xe-next b6e1b7081768"
>
> "drm-intel topic/core-for-CI"
> "drm-misc topic/i915-ttm"
--
Jani Nikula, Intel
On Fri, 22 Dec 2023, Neil Armstrong wrote:
> On 19/12/2023 13:15, Jani Nikula wrote:
>> On Tue, 14 Nov 2023, Jani Nikula wrote:
>>> On Thu, 26 Oct 2023, Jani Nikula wrote:
>>>> This is just the first two patches of a lengthy series that I'm not
>>>
4 files changed, 57 insertions(+), 6 deletions(-)
--
Jani Nikula, Intel
On Tue, 19 Dec 2023, Jani Nikula wrote:
> hdmi-codec.h does not appear to directly need drm/drm_edid.h for
> anything. Remove it.
>
> There are some files that get drm/edid.h by proxy; include it where
> needed.
>
> v2-v4: Fix build (kernel test robot )
>
>
On Tue, 14 Nov 2023, Jani Nikula wrote:
> On Thu, 26 Oct 2023, Jani Nikula wrote:
>> This is just the first two patches of a lengthy series that I'm not
>> really sure how to proceed with. Basically the series converts all of
>> drm/bridge to the new struct drm_edid
On Tue, 12 Dec 2023, Jani Nikula wrote:
> Including drm_edid.h from nouveau_connector.h causes the rebuild of 15
> files when drm_edid.h is modified, while there are only a few files that
> actually need to include drm_edid.h.
Ping?
>
> Signed-off-by: Jani Nikula
> ---
On Tue, 12 Dec 2023, Jani Nikula wrote:
> Reduce the need for rebuilds when drm_edid.h is modified by including it
> only where needed.
Ping?
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 -
> drivers/gpu/drm/hisilicon/hibmc
hdmi-codec.h does not appear to directly need drm/drm_edid.h for
anything. Remove it.
There are some files that get drm/edid.h by proxy; include it where
needed.
v2-v4: Fix build (kernel test robot )
Signed-off-by: Jani Nikula
---
I'm pretty sure I haven't compiled everything
controlling
this. They are for debug and test purposes only. See the relevant igt
tests for how they're used in testing [1].
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/igt-gpu-tools
--
Jani Nikula, Intel
al(&set, &ctx);
>
> @@ -709,7 +710,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,
> drm_framebuffer_put(fb);
>
> if (connector_set) {
> - for (i = 0; i < crtc_req->count_connectors; i++) {
> + for (i = 0; i < num_connectors; i++) {
> if (connector_set[i])
> drm_connector_put(connector_set[i]);
> }
--
Jani Nikula, Intel
On Tue, 12 Dec 2023, Jani Nikula wrote:
> __packed is preferred over __attribute__((packed)).
>
> Signed-off-by: Jani Nikula
Pushed both to drm-misc-next with Simon's irc r-b.
Thanks,
Jani.
> ---
> include/drm/drm_edid.h | 32
> 1 file
hdmi-codec.h does not appear to directly need drm/drm_edid.h for
anything. Remove it.
There are some files that get drm/edid.h by proxy; include it where
needed.
v2-v3: Fix build (kernel test robot )
Signed-off-by: Jani Nikula
---
I'm pretty sure I haven't compiled everything
DL+ tiled plane stride when the POT stride is smaller than the original
- Fix eDP 1.4 rate select method link configuration
----
Jani Nikula (1):
drm/i915/edp: don't write to DP_LINK_BW_SET when using rate select
Tvrtko Ursulin
Reduce the need for rebuilds when drm_edid.h is modified by including it
only where needed.
v2: Fix build (kernel test robot )
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/tegra/drm.h| 2 +-
drivers/gpu/drm/tegra/output.c | 1 +
drivers/gpu/drm/tegra/sor.c| 1 +
3 files changed, 3
On Tue, 12 Dec 2023, Randy Dunlap wrote:
> Correct spellos reported by codespell.
> Fix some grammar (as 's' to a few words).
>
> Signed-off-by: Randy Dunlap
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas
On Tue, 12 Dec 2023, Randy Dunlap wrote:
> Fix spelling problems as identified by codespell.
>
> Signed-off-by: Randy Dunlap
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
Reviewed-by: Jani Nikul
On Tue, 12 Dec 2023, Randy Dunlap wrote:
> Correct spelling mistakes that were identified by codespell.
>
> Signed-off-by: Randy Dunlap
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
Reviewed-by: Jani N
hdmi-codec.h does not appear to directly need drm/drm_edid.h for
anything. Remove it.
There are some files that get drm/edid.h by proxy; include it where
needed.
v2: Fix build (kernel test robot )
Signed-off-by: Jani Nikula
---
I'm pretty sure I haven't compiled everything
There's no need to include either linux/hdmi.h or drm/drm_mode.h. They
can be removed by using forward declarations.
While at it, group the forward declarations together, and remove the
unnecessary ones.
Signed-off-by: Jani Nikula
---
include/drm/drm_edid.h | 12 +---
1 file chang
hdmi-codec.h does not appear to need drm/drm_edid.h for anything. Remove
it.
Signed-off-by: Jani Nikula
---
I'm pretty sure I haven't compiled everything that might implicitly
depend on the include. However, the right thing to do is to include
drm_edid.h where needed, not from somew
Reduce the need for rebuilds when drm_edid.h is modified by including it
only where needed.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 -
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a
Reduce the need for rebuilds when drm_edid.h is modified by including it
only where needed.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/tegra/drm.h| 2 +-
drivers/gpu/drm/tegra/output.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/drm.h b
Including drm_edid.h from nouveau_connector.h causes the rebuild of 15
files when drm_edid.h is modified, while there are only a few files that
actually need to include drm_edid.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/nouveau/dispnv50/head.c | 1 +
drivers/gpu/drm/nouveau
Including drm_edid.h from radeon_mode.h causes the rebuild of more than
a hundred files when drm_edid.h is modified, while there are only a
handful of files that actually need to include drm_edid.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
drivers/gpu/drm
Including drm_edid.h from amdgpu_mode.h causes the rebuild of literally
hundreds of files when drm_edid.h is modified, while there are only a
handful of files that actually need to include drm_edid.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 2
__packed is preferred over __attribute__((packed)).
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_ioc32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
index 129e2b91dbfe..e6b5b06de148 100644
--- a/drivers
__packed is preferred over __attribute__((packed)).
Signed-off-by: Jani Nikula
---
include/drm/drm_edid.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 518d1b8106c7..54cc6f04a708
On Fri, 08 Dec 2023, Ville Syrjälä wrote:
> On Thu, Dec 07, 2023 at 11:38:21AM +0200, Jani Nikula wrote:
>> When the separate add modes call was added back in commit c533b5167c7e
>> ("drm/edid: add separate drm_edid_connector_add_modes()")
("Exported object not initialised to zero!\n");
> err = -EINVAL;
> goto out;
> }
--
Jani Nikula, Intel
b9c2b ("drm/crtc: Fix uninit-value bug in drm_mode_setcrtc")
Cc: syzbot+4fad2e57beb6397ab...@syzkaller.appspotmail.com
Cc: Ziqi Zhao
Cc: Maxime Ripard
Cc: Maarten Lankhorst
Cc: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c | 3 +--
1 file changed, 1 ins
> @@ -892,7 +893,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,
> drm_framebuffer_put(fb);
>
> if (connector_set) {
> - for (i = 0; i < crtc_req->count_connectors; i++) {
> + for (i = 0; i < num_connectors; i++) {
> if (connector_set[i])
> drm_connector_put(connector_set[i]);
> }
--
Jani Nikula, Intel
er-CRITICAL: Failed
> assertion: allocated || reserved
> [ 43.974477][ T447]
> [ 43.987691][ T447] (api_intel_bb:857) intel_batchbuffer-CRITICAL: Can't
> get offset, allocated: 0, reserved: 0
> [ 43.987706][ T447]
>
>
> The kernel config and materials to reproduce are available at:
> https://download.01.org/0day-ci/archive/20231207/202312071643.321205c6-oliver.s...@intel.com
--
Jani Nikula, Intel
rm_universal_plane_alloc(struct drm_device *dev,
> *
> * Returns:
> * Pointer to new plane, or ERR_PTR on failure.
> + *
> + * Panics:
> + * If @dev or @funcs are NULL.
> */
> #define drm_universal_plane_alloc(dev, type, member, possible_crtcs, funcs,
> formats, \
> format_count, format_modifiers, plane_type,
> name, ...) \
--
Jani Nikula, Intel
On Wed, 06 Dec 2023, Dario Binacchi wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi
Reviewed-by: Jani Nikula
> ---
>
> drivers/gpu/drm/drm_debugfs.c | 4
> 1 file changed, 4 delet
On Thu, 07 Dec 2023, bbaa wrote:
> Hello everyone,
>
> drm_edid_override_connector_update seem return a incorrect value.
You seem to have posted this twice; already replied at
https://lore.kernel.org/r/87jzpq1go5@intel.com
--
Jani Nikula, Intel
houldn't have to ever care about overrides, at all. Drivers
shouldn't really use connector->edid_blob_ptr directly either.
Please report and get that fixed downstream.
BR,
Jani.
--
Jani Nikula, Intel
f+29b34d89-8658-4910-966a-c772f320e...@bbaa.fun
Fixes: c533b5167c7e ("drm/edid: add separate drm_edid_connector_add_modes()")
Cc: # v6.3+
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_
rs/gpu/drm/i915/display/intel_sdvo.c| 8 +++-
drivers/gpu/drm/i915/display/intel_tv.c | 8 +++-
drivers/gpu/drm/i915/display/vlv_dsi.c | 18 +-
13 files changed, 104 insertions(+), 8 deletions(-)
--
Jani Nikula, Intel
.1 Specs - 2.12.3.6.5 Square Pattern
> [2]: DP2.1 PHY CTS specs - 4.3 UHBR Source Transmitter Equalization
>
> Cc: Jani Nikula
> Cc: Imre Deak
> Cc: Lee Shawn C
> Signed-off-by: Khaled Almahallawy
Thanks for the patch, pushed to drm-misc-next.
BR,
Jani.
> ---
> i
,7 +3,7 @@
> * Copyright © 2019 Intel Corporation
> */
>
> -#include
> +#include
>
> #include "i915_reg.h"
> #include "intel_ddi.h"
--
Jani Nikula, Intel
t;
> Signed-off-by: Hans de Goede
Acked-by: Jani Nikula
> ---
> Note this applies on top of Andy's recent GPIO rework series which
> has just landed in drm-intel-next
> ---
> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 17 ++---
> drivers/gpu/drm/i915/d
{planes,vrr}_{enabling,disabling}()
drivers/gpu/drm/i915/display/intel_display.c | 12 ++++
1 file changed, 12 insertions(+)
--
Jani Nikula, Intel
-
3 files changed, 46 insertions(+), 24 deletions(-)
--
Jani Nikula, Intel
On Thu, 30 Nov 2023, Javier Martinez Canillas wrote:
> Maxime Ripard writes:
>
>> Hi,
>>
>> On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote:
>>> On Wed, 29 Nov 2023, Hamza Mahfooz wrote:
>>> > Cc: Nathan Chancellor
>>> >
&g
On Wed, 29 Nov 2023, Hamza Mahfooz wrote:
> Cc: Nathan Chancellor
>
> On 11/29/23 13:12, Jani Nikula wrote:
>> At least the i915 and amd drivers enable a bunch more compiler warnings
>> than the kernel defaults.
>>
>> Extend the W=1 warnings to the entire
: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: Alex Deucher
Cc: Christian König
Cc: Pan, Xinhui
Cc: Karol Herbst
Cc: Lyude Paul
Cc: Danilo Krummrich
Cc: Rob Clark
Cc: Abhinav Kumar
Cc: Dmitry Baryshkov
Cc: Sean Paul
Cc: Marijn Suijten
Signed-off-by: Jani Nikula
u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
Jani Nikula, Intel
On Wed, 29 Nov 2023, Andy Shevchenko wrote:
> The driver uses math.h and not util_macros.h.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
ake_scanline(const struct
> intel_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
Jani Nikula, Intel
On Wed, 29 Nov 2023, Maxime Ripard wrote:
> On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote:
>> On Wed, 29 Nov 2023, Maxime Ripard wrote:
>> > Hi Ville,
>> >
>> > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote:
>> >>
On Wed, 29 Nov 2023, Maxime Ripard wrote:
> Hi Ville,
>
> On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote:
>> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote:
>> > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote:
>> > >
. Since this patch is just for CI, please do not CC linux-pci as it
>> causes
>> confusion.
>
> Sure, thank you.
>
> Jani, is this fix required for topic/core-for-CI ?
Done. Please double check drm-tip works for you now.
BR,
Jani.
>
> Regards,
> Vignesh
--
Jani Nikula, Intel
> struct ida *connector_ida =
> &drm_connector_enum_list[connector_type].ida;
>
> + if (!dev || !connector || !funcs)
> + return -EINVAL;
> +
> WARN_ON(drm_drv_uses_atomic_modeset(dev) &&
> (!funcs->atomic_destroy_state ||
>!funcs->atomic_duplicate_state));
--
Jani Nikula, Intel
On Sun, 26 Nov 2023, Rahul Rameshbabu wrote:
> Dump the iir value in hex when the interrupt is unexpected.
>
> Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9652#note_2178501
> Cc: Jani Nikula
> Signed-off-by: Rahul Rameshbabu
> Reviewed-by: Chaitanya Kumar Borah
P
or linux-pci is what happened with [1].
We've been running CI with that for months now to avoid lockdep splats,
and it's obviously in everyone's best interest to get a fix upstream.
David, Bjorn?
BR,
Jani.
[1]
https://lore.kernel.org/all/20230321233849.3408339-1-david.e@linux.intel.com/
>
> - Mani
>
>> Regards,
>> Vignesh
--
Jani Nikula, Intel
bug in the dim script that we need to
>>> fix.
>>
>> It would be very useful for you to explain what happened here so we
>> improve the tooling or doc and can try to make sure it doesn't happen
>> again
>>
>> Maxime
>
> There is no problem with the tooling--I just forced the commit in.
Wait what?
What do you mean by forcing the commit in? Bypass dim?
If yes, please *never* do that when you're dealing with dim managed
branches. That's part of the deal for getting commit access, along with
following all the other maintainer tools documentation.
BR,
Jani.
--
Jani Nikula, Intel
There's already a related drm_printer. Use it to preserve the context
instead of a separate pr_err().
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 6 +++---
drivers/gpu/drm/i915/selftests/i915_active.c| 4 ++--
2 files changed, 5 insertions(
Prefer the device specific debug printer.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 3 ++-
drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c| 3 ++-
drivers/gpu/drm/i915/gt/intel_reset.c | 3 ++-
drivers/gpu/drm/i915/gt
Use the existing drm printer infrastructure instead of local macros.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/display/drm_dp_helper.c | 17 +---
.../drm/i915/display/intel_crtc_state_dump.c | 5 ++--
drivers/gpu/drm/i915/display/intel_display.c | 27
Prefer the device specific debug printer.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_mode_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_config.c
b/drivers/gpu/drm/drm_mode_config.c
index 8525ef851540..48fd2d67f352 100644
--- a
Prefer the device specific debug printer.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 23 +++
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
We've lacked a device specific debug printer. Add one. Take category
into account too.
__builtin_return_address(0) is inaccurate here, so don't use it. If
necessary, we can later pass __func__ to drm_dbg_printer() by wrapping
it inside a macro.
Signed-off-by: Jani Nikula
---
drive
Avoid forward declarations in subsequent changes, but separate this
movement to an independent change.
Signed-off-by: Jani Nikula
---
include/drm/drm_print.h | 190
1 file changed, 95 insertions(+), 95 deletions(-)
diff --git a/include/drm/drm_print.h b
With few users for drm_err_printer(), it's still feasible to convert it
to be device specific. Use drm_err() under the hood.
While at it, make the prefix optional.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 7 ++-
drivers/gpu/drm/i9
Make drm_err_printer() drm device specific, and add drm device specific
drm_dbg_printer(). Switch code over to use them.
Jani Nikula (8):
drm/print: make drm_err_printer() device specific by using drm_err()
drm/print: move enum drm_debug_category etc. earlier in drm_print.h
drm/print: add
PBN / MTP_TU size calculation for UHBR rates
drm/i915/dp: Report a rounded-down value as the maximum data rate
drm/i915/dp: Simplify intel_dp_max_data_rate()
drm/i915/dp: Reuse intel_dp_{max,effective}_data_rate in
intel_link_compute_m_n()
Jani Nikula (22):
drm/i915: drop gt/i
iles changed, 9 insertions(+), 22 deletions(-)
--
Jani Nikula, Intel
On Wed, 22 Nov 2023, Thomas Zimmermann wrote:
> One of the source files includes via ,
> which will be removed. Include drm_auth.h directly.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvr
nal(struct eventfd_ctx *ctx)
> {
> - return eventfd_signal_mask(ctx, n, 0);
> + return eventfd_signal_mask(ctx, 1, 0);
> }
> EXPORT_SYMBOL_GPL(eventfd_signal);
>
--
Jani Nikula, Intel
t
mentioned.
If it's i915, please see [1] on how to file a bug.
Thanks,
Jani.
[1] https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html
>
>
> Kind regards,
>
> Paul
--
Jani Nikula, Intel
> struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> const struct drm_display_mode *adjusted_mode =
> &crtc_state->hw.adjusted_mode;
> - u8 entry_setup_frames;
> + int entry_setup_frames;
>
> /*
>* Current PSR panels don't work reliably with VRR enabled
--
Jani Nikula, Intel
On Fri, 17 Nov 2023, Andy Shevchenko wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in t
On Tue, 21 Nov 2023, Bert Karwatzki wrote:
> As this simple patch fixes the problem
Please use git send-email to send patches. Evolution botched up the
whitespace here.
BR,
Jani.
--
Jani Nikula, Intel
ook like it does
> anything sensible. All other drivers for sure should be
> rejecting vscan>1 outright. Which driver is this?
>
> Is there an actual usecase where nouveau needs this (and does
> it even work?) or could we just rip out the whole thing and
> reject vscan>1 globally?
I thought the whole thing seemed familiar [1].
BR,
Jani.
[1] https://lore.kernel.org/r/20230802174746.2256-1-astraj...@yahoo.com
>
>>
>> return DIV_ROUND_CLOSEST_ULL(mul_u32_u32(num, 1000), den);
>> }
>> --
>> 2.25.1
--
Jani Nikula, Intel
On Mon, 20 Nov 2023, Heiner Kallweit wrote:
> v4:
> - more ack and review tags
Please do not send new versions just to record the acks and
reviews. They should be added while applying the patches.
Thanks,
Jani.
--
Jani Nikula, Intel
On Mon, 20 Nov 2023, Imre Deak wrote:
> On Mon, Nov 20, 2023 at 02:31:34PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Imre Deak wrote:
>> > This is v2 of [1], with the following changes:
>> > - Store the pbn_div value in fixed point format.
>> &
.
>
> [1] https://lore.kernel.org/all/20231113201110.510724-1-imre.d...@intel.com
>
> Cc: Arun R Murthy
> Cc: Jani Nikula
> Cc: Lyude Paul
>
> Imre Deak (11):
> drm/dp_mst: Store the MST PBN divider value in fixed point format
> drm/dp_mst: Fix PBN divider calcula
re reference, check_mul_overflow() is the way to handle this.
> + return -EINVAL;
Just so there's no confusion: NAK.
I'd be surprised if there were even a single place in the kernel where
someone checks drm_mode_vrefresh() for a negative error return.
This function must succeed.
Please change the types as needed instead.
BR,
Jani.
> den *= mode->vscan;
> + }
>
> return DIV_ROUND_CLOSEST_ULL(mul_u32_u32(num, 1000), den);
> }
--
Jani Nikula, Intel
Closes:
> https://lore.kernel.org/oe-kbuild-all/20230610.h0m6ydi5-...@intel.com/
> Cc: Andi Shyti
> Cc: Aravind Iddamsetty
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drm_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
y: Tvrtko Ursulin
> Fixes: e4ae85e364fc ("drm/i915: Add ability for tracking buffer objects per
> client")
> Cc: Aravind Iddamsetty
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/20230104.8tlhvxui-...@intel.com/
Re
rintk() also handle a NULL drm device pointer. The printed output is
> identical to if drm->dev had been NULL.
>
> Signed-off-by: Luben Tuikov
Reviewed-by: Jani Nikula
> ---
> include/drm/drm_print.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
901 - 1000 of 3574 matches
Mail list logo
