Re: [Mesa-dev] Time to update GSoC/EVoC ideas page

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 2:15 AM, Nicolai Hähnle wrote: > Hi Rob, > > On 19.01.2017 23:32, Rob Clark wrote: > >> Just a friendly reminder that now would be a good time to update the >> wiki page for GSoC/EVoC ideas: >> >> https://www.x.org/wiki/SummerOfCodeIdeas/ >> >> There

[PATCH v2 9/9] drm/i915: Add render decompression support

2017-01-09 Thread Jason Ekstrand
Widawsky > > v2: Deal with display workarounds 0390, 0531, 1125 (Paulo) > > Cc: Paulo Zanoni > Cc: Vandana Kannan > Cc: Daniel Vetter > Cc: Ben Widawsky > Cc: Jason Ekstrand > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_reg.h | 23 ++

Re: [PATCH v2 9/9] drm/i915: Add render decompression support

2017-02-28 Thread Jason Ekstrand
owing people: > * Vandana Kannan <vandana.kan...@intel.com> > * Daniel Vetter <dan...@ffwll.ch> > * Ben Widawsky <b...@bwidawsk.net> > > v2: Deal with display workarounds 0390, 0531, 1125 (Paulo) > > Cc: Paulo Zanoni <paulo.r.zan...@intel.com> &

[PATCH] glx/dri3: Use four buffers until X driver supports async flips

2014-09-29 Thread Jason Ekstrand
-by: Jason Ekstrand On Mon, Sep 29, 2014 at 12:25 PM, Matt Turner wrote: > Cc'ing people who might be able to review. > -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140929/61490c5a/attachment-0001.html>

Re: [PATCH v2 9/9] drm/i915: Add render decompression support

2017-01-11 Thread Jason Ekstrand
On Tue, Jan 10, 2017 at 9:04 AM, Ville Syrjälä < ville.syrj...@linux.intel.com> wrote: > On Mon, Jan 09, 2017 at 11:20:57AM -0800, Jason Ekstrand wrote: > > On Thu, Jan 5, 2017 at 7:14 AM, <ville.syrj...@linux.intel.com> wrote: > > > > > From: Ville Sy

Re: [PATCH v2 9/9] drm/i915: Add render decompression support

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 1:49 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Tue, Jan 10, 2017 at 9:04 AM, Ville Syrjälä < > ville.syrj...@linux.intel.com> wrote: > >> On Mon, Jan 09, 2017 at 11:20:57AM -0800, Jason Ekstrand wrote: >> > On Thu,

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jason Ekstrand
On Fri, Mar 24, 2017 at 2:16 PM, Jose Fonseca wrote: > On 24/03/17 20:08, Kristian Høgsberg wrote: > >> On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca >> wrote: >> >>> On 24/03/17 19:10, Kristian Høgsberg wrote: >>> On Fri, Mar 24, 2017 at

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-17 Thread Jason Ekstrand
On March 16, 2017 5:41:24 PM Emil Velikov wrote: On 17 March 2017 at 00:21, Dylan Baker wrote: Hi Emil, Quoting Emil Velikov (2017-03-16 16:35:33) While I can see you're impressed by Meson, I would kindly urge you to not use it here. As you

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-20 Thread Jason Ekstrand
On Mon, Mar 20, 2017 at 2:28 PM, Timothy Arceri wrote: > > > On 21/03/17 06:39, Emil Velikov wrote: > >> On 20 March 2017 at 18:30, Matt Turner wrote: >> >>> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >>> wrote: >>>

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Jason Ekstrand
On Tue, Mar 21, 2017 at 11:56 AM, Emil Velikov wrote: > On 21 March 2017 at 18:06, Matt Turner wrote: > > On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov > wrote: > >> On 21 March 2017 at 15:57, Matt Turner

Re: Vulkan WSI+VK_KHR_display for KMS/DRM?

2017-04-10 Thread Jason Ekstrand
On April 10, 2017 12:29:12 PM Chad Versace <chadvers...@chromium.org> wrote: On Tue 04 Apr 2017, Keith Packard wrote: Jason Ekstrand <ja...@jlekstrand.net> writes: > Interesting question. To my knowledge, no one has actually implemented the > Vulkan WSI direct-to-displ

Re: Vulkan WSI+VK_KHR_display for KMS/DRM?

2017-04-05 Thread Jason Ekstrand
On Mon, Apr 3, 2017 at 12:56 PM, Keith Packard wrote: > Chad Versace writes: > > > The real path forward should be implemented on top of > > VK_KHX_external_memory. If you want to start experimenting now with > > Vulkan+KMS, you may want to look at >

Re: [repost] drm sync objects cleaned up

2017-04-18 Thread Jason Ekstrand
A few thoughts (from the anv perspective) that I put on IRC but may be better in a mail. In no particular order: 1. Having the fd exported from a syncobj be a valid sync_file seems like a fairly pointless feature to me. If we can make things more sane by throwing that out, I'm all for it. 2.

Re: [PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

2017-08-02 Thread Jason Ekstrand
Drp... replied to an old patch. The userspace mesa patches to produce Y_TILED_CCS surfaces have been reviewed for a couple of weeks now. So long as kmscube counts as userspace, I think this should be good to land. Acked-by: Jason Ekstrand <ja...@jlekstrand.net> On Tue, Aug 1, 2017 at 9

Re: [PATCH] i915: Add support for drm syncobjs

2017-08-03 Thread Jason Ekstrand
On Thu, Aug 3, 2017 at 10:00 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-07-05 22:15:09) > > On Wed, Jul 5, 2017 at 2:13 PM, Jason Ekstrand <ja...@jlekstrand.net> > wrote: > > > > This commit adds support for

Re: [PATCH] i915: Add support for drm syncobjs

2017-08-03 Thread Jason Ekstrand
On Thu, Aug 3, 2017 at 11:15 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-08-03 19:06:02) > > I'm not concerned about what happens to racy clients. They get what > they get. > > What concerns me is what happens if somehow the fence i

[PATCH 4/7] drm/syncobj: add sync obj wait interface. (v8)

2017-08-15 Thread Jason Ekstrand
: Dave Airlie <airl...@redhat.com> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> Acked-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/

[PATCH 7/7] drm/syncobj: Allow wait for submit and signal behavior (v5)

2017-08-15 Thread Jason Ekstrand
tra layer of callbacks Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Dave Airlie <airl...@redhat.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/drm_syncobj.c | 252 +

[PATCH 6/7] drm/syncobj: Add a callback mechanism for replace_fence (v2)

2017-08-15 Thread Jason Ekstrand
there is no callback list, it spends a very short amount of time inside the lock. v2: - Don't lock in drm_syncobj_fence_get. We only really need to lock around fence_replace to make the callback work. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_syn

[PATCH 1/7] drm/syncobj: Rename fence_get to find_fence

2017-08-15 Thread Jason Ekstrand
The function has far more in common with drm_syncobj_find than with any in the get/put functions. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Acked-by: Christian König <christian.koe...@amd.com> (v1) --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/d

Re: [PATCH 0/9] drm/syncobj: Add full-featured wait support (v2)

2017-08-13 Thread Jason Ekstrand
original approach with v3 of the last patch. Regards, Christian. Am 12.08.2017 um 00:39 schrieb Jason Ekstrand: This series does the same thing as my earlier series in that it adds a sync object wait interface complete with WAIT_FOR_SUBMIT flag. While the uapi remains unchanged, the guts lo

[PATCH libdrm] drm: Pull new modifier uapi into drm_fourcc and drm_mode

2017-08-14 Thread Jason Ekstrand
Cc: Daniel Stone --- include/drm/drm_fourcc.h | 31 ++ include/drm/drm_mode.h | 50 2 files changed, 81 insertions(+) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index

Re: [PATCH] drm/syncobj: Allow wait for submit and signal behavior (v2)

2017-08-10 Thread Jason Ekstrand
On Thu, Aug 10, 2017 at 5:26 AM, Christian König <deathsim...@vodafone.de> wrote: > Am 10.08.2017 um 01:53 schrieb Jason Ekstrand: > > On Wed, Aug 9, 2017 at 3:41 PM, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: > >> Quoting Chris Wilson (2017-08-09 18:57:44)

Re: [PATCH] drm/syncobj: Allow wait for submit and signal behavior (v2)

2017-08-10 Thread Jason Ekstrand
On Thu, Aug 10, 2017 at 4:00 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-08-10 00:53:00) > > On Wed, Aug 9, 2017 at 3:41 PM, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: > > However, this installs the proxy into

[PATCH] drm/syncobj: Allow wait for submit and signal behavior (v2)

2017-08-09 Thread Jason Ekstrand
and wait-any cases Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Dave Airlie <airl...@redhat.com> --- I realized today (this is what happens when you sleep) that it takes almost no work to make the wait-any path also handle wait-all. By unifying the two, I deleted over a h

[PATCH 6/9] drm/syncobj: Add a reset ioctl

2017-08-11 Thread Jason Ekstrand
This just resets the dma_fence to NULL so it looks like it's never been signaled. This will be useful once we add the new wait API for allowing wait on "submit and signal" behavior. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_internal.h | 2 ++

[PATCH 8/9] dma-buf/dma-fence: Add a mechanism for proxy fences

2017-08-11 Thread Jason Ekstrand
e used with care as it is the responsibility of proxy fences creator to ensure that it eventually gets assigned a real fence so it gets signaled. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/dma-buf/Makefile | 4 +- drivers/dma-buf/d

[PATCH 7/9] dma-buf/dma-fence: Signal all callbacks from dma_fence_release()

2017-08-11 Thread Jason Ekstrand
From: Chris Wilson This is an illegal scenario, to free the fence whilst there are pending callbacks. Currently, we emit a WARN and then cast aside the callbacks leaving them dangling. Alternatively, we could set an error on the fence and then signal fence so that any

[PATCH 9/9] drm/syncobj: Allow wait for submit and signal behavior (v4)

2017-08-11 Thread Jason Ekstrand
and wait-any cases v3: - Unify the timeout == 0 case a bit with the timeout > 0 case - use wait_event_interruptible_timeout v4: - Use proxy fence Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Dave Airlie <airl...@redhat.com> --- drivers/gpu/drm/drm

[PATCH 0/9] drm/syncobj: Add full-featured wait support (v2)

2017-08-11 Thread Jason Ekstrand
m for proxy fences Dave Airlie (1): drm/syncobj: add sync obj wait interface. (v8) Jason Ekstrand (6): drm/syncobj: Rename fence_get to find_fence drm/syncobj: Add a race-free drm_syncobj_fence_get helper i915: Add support for drm syncobjs dma-buf/dma-fence: Allow wait_any_timeout withou

[PATCH 2/9] drm/syncobj: Add a race-free drm_syncobj_fence_get helper

2017-08-11 Thread Jason Ekstrand
t more than just get a reference in drm_syncobj_fence_get should we wish to do so. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_syncobj.c | 12 +--- include/drm/drm_syncobj.h | 6 +- 2 files changed, 14 insertions(+), 4 deletions(-) diff --g

[PATCH 1/9] drm/syncobj: Rename fence_get to find_fence

2017-08-11 Thread Jason Ekstrand
The function has far more in common with drm_syncobj_find than with any in the get/put functions. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 10 +- include/drm/drm_syn

Re: [PATCH 3/9] i915: Add support for drm syncobjs

2017-08-13 Thread Jason Ekstrand
We now have reviewed userspace for this: https://lists.freedesktop.org/archives/mesa-dev/2017-August/166200.html On Fri, Aug 11, 2017 at 3:39 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > This commit adds support for waiting on or signaling DRM syncobjs as > part of execbuf.

Re: [PATCH 0/9] drm/syncobj: Add full-featured wait support (v2)

2017-08-13 Thread Jason Ekstrand
On August 13, 2017 4:14:45 PM Jason Ekstrand <ja...@jlekstrand.net> wrote: On August 13, 2017 8:52:21 AM Christian König <christian.koe...@amd.com> wrote: Am 13.08.2017 um 17:26 schrieb Jason Ekstrand: On August 13, 2017 6:19:53 AM Christian König <christian.koe...@amd.com>

Re: [PATCH 0/9] drm/syncobj: Add full-featured wait support (v2)

2017-08-14 Thread Jason Ekstrand
On Mon, Aug 14, 2017 at 12:36 AM, Christian König <christian.koe...@amd.com> wrote: > Am 14.08.2017 um 01:14 schrieb Jason Ekstrand: > >> On August 13, 2017 8:52:21 AM Christian König <christian.koe...@amd.com> >> wrote: >> >> Am 13.08.2017 um 17:26 sch

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-11 Thread Jason Ekstrand
On Tue, Jul 11, 2017 at 12:17 AM, Christian König <deathsim...@vodafone.de> wrote: > Am 11.07.2017 um 04:36 schrieb Michel Dänzer: > >> On 11/07/17 06:09 AM, Jason Ekstrand wrote: >> >>> On Mon, Jul 10, 2017 at 9:15 AM, Christian König >>> <deathsim..

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-11 Thread Jason Ekstrand
On Tue, Jul 11, 2017 at 12:22 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Jul 10, 2017 at 02:09:42PM -0700, Jason Ekstrand wrote: > > On Mon, Jul 10, 2017 at 9:15 AM, Christian König < > deathsim...@vodafone.de> > > wrote: > > > > >

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-10 Thread Jason Ekstrand
> > Alex Bin Xie > > *From:* amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org > <amd-gfx-boun...@lists.freedesktop.org>] *On Behalf Of *Jason Ekstrand > *Sent:* Monday, July 10, 2017 11:53 AM > *To:* Christian König <deathsim...@vodafone.de> <deathsim...@vodafone.de

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-10 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 6:04 PM, Dave Airlie wrote: > From: Dave Airlie > > This interface will allow sync object to be used to back > Vulkan fences. This API is pretty much the vulkan fence waiting > API, and I've ported the code from amdgpu. > > v2:

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-10 Thread Jason Ekstrand
On Mon, Jul 10, 2017 at 8:45 AM, Christian König <deathsim...@vodafone.de> wrote: > Am 10.07.2017 um 17:28 schrieb Jason Ekstrand: > > On Wed, Jul 5, 2017 at 6:04 PM, Dave Airlie <airl...@gmail.com> wrote: > >> From: Dave Airlie <airl...@redhat.com> >>

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-10 Thread Jason Ekstrand
On Mon, Jul 10, 2017 at 9:15 AM, Christian König <deathsim...@vodafone.de> wrote: > Am 10.07.2017 um 17:52 schrieb Jason Ekstrand: > > On Mon, Jul 10, 2017 at 8:45 AM, Christian König <deathsim...@vodafone.de> > wrote: > >> Am 10.07.2017 um 17:28 schrieb Jason Ek

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-12 Thread Jason Ekstrand
On Wed, Jul 12, 2017 at 1:39 AM, Dave Airlie <airl...@gmail.com> wrote: > On 12 July 2017 at 17:39, Christian König <deathsim...@vodafone.de> wrote: > > Am 11.07.2017 um 17:43 schrieb Jason Ekstrand: > > > > On Tue, Jul 11, 2017 at 12:17 AM, Christian König <

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-12 Thread Jason Ekstrand
On Wed, Jul 12, 2017 at 9:45 AM, Christian König <deathsim...@vodafone.de> wrote: > Am 12.07.2017 um 17:53 schrieb Jason Ekstrand: > > [SNIP] > > >> Is that easier than just waiting in the kernel, I'm not sure how >> optimised we need this path to be. >> &

Re: [PATCH] i915: Add support for drm syncobjs

2017-07-05 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 10:37 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-07-05 18:21:22) > > This commit adds support for waiting on or signaling DRM syncobjs as > > part of execbuf. It does so by hijacking the currently unused

[PATCH] i915: Add support for drm syncobjs

2017-07-05 Thread Jason Ekstrand
This commit adds support for waiting on or signaling DRM syncobjs as part of execbuf. It does so by hijacking the currently unused cliprects pointer to instead point to an array of i915_gem_exec_fence structs which containe a DRM syncobj and a flags parameter which specifies whether to wait on it

[PATCH] i915: Add support for drm syncobjs

2017-07-05 Thread Jason Ekstrand
This commit adds support for waiting on or signaling DRM syncobjs as part of execbuf. It does so by hijacking the currently unused cliprects pointer to instead point to an array of i915_gem_exec_fence structs which containe a DRM syncobj and a flags parameter which specifies whether to wait on it

Re: [PATCH] i915: Add support for drm syncobjs

2017-07-05 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 2:13 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > This commit adds support for waiting on or signaling DRM syncobjs as > part of execbuf. It does so by hijacking the currently unused cliprects > pointer to instead point to an array of i915_gem_exe

Re: [Intel-gfx] [PATCH] drm: Remove unused drm_file parameter to drm_syncobj_replace_fence()

2017-07-05 Thread Jason Ekstrand
rm_syncobj *syncobj, >struct dma_fence *fence) > { > - struct dma_fence *old_fence = NULL; > + struct dma_fence *old_fence; > This change looks unrelated. Valid, but unrelated. :-) Having worked through your i915 syncobj

Re: [PATCH] i915: Add support for drm syncobjs

2017-07-05 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 11:42 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-07-05 19:32:21) > > On Wed, Jul 5, 2017 at 10:37 AM, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: > > > > Quoting Jason Ekstrand (2017-07-05

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v7)

2017-08-04 Thread Jason Ekstrand
I'm working on a VK_KHR_external_fence implementation based on this and have found some issues. :-) On Mon, Jul 17, 2017 at 11:44 PM, Dave Airlie wrote: > From: Dave Airlie > > This interface will allow sync object to be used to back > Vulkan fences. This

[PATCH 6/9] dma-buf/dma-fence: Allow wait_any_timeout without default_wait

2017-08-08 Thread Jason Ekstrand
-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/dma-buf/dma-fence.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 57da14c..1218692 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -

[PATCH 5/9] drm/syncobj: add sync obj wait interface. (v8)

2017-08-08 Thread Jason Ekstrand
: Dave Airlie <airl...@redhat.com> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 142 + include/uapi/drm/drm.h | 12 +++

[PATCH 4/9] i915: Add support for drm syncobjs

2017-08-08 Thread Jason Ekstrand
- Do all allocation in gem_execbuffer2 - Pack the flags in the bottom 2 bits of the drm_syncobj* v4: - Prevent a potential race on syncobj->fence Testcase: igt/gem_exec_fence/syncobj* Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Reviewed-by: Chris Wilson <ch...@chris-

[PATCH 1/9] drm/syncobj: Rename fence_get to find_fence

2017-08-08 Thread Jason Ekstrand
The function has far more in common with drm_syncobj_find than with any in the get/put functions. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 10 +- include/drm/drm_syn

[PATCH 0/9] drm/syncobj: Add full-featured wait support

2017-08-08 Thread Jason Ekstrand
;ch...@chris-wilson.co.uk> Cc: Dave Airlie <airl...@redhat.com> Dave Airlie (1): drm/syncobj: add sync obj wait interface. (v8) Jason Ekstrand (8): drm/syncobj: Rename fence_get to find_fence drm/syncobj: Lock around drm_syncobj::fence drm/syncobj: Remove file_private from replace_fence

[PATCH 2/9] drm/syncobj: Lock around drm_syncobj::fence

2017-08-08 Thread Jason Ekstrand
ere the one thread gets the syncobj->fence pointer and when it calls dma_fence_get() on it. If this happens, then the reference may be dropped before we get a chance to get a new one. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_sy

[PATCH 9/9] drm/syncobj: Allow wait for submit and signal behavior

2017-08-08 Thread Jason Ekstrand
a WAIT_FOR_SUBMIT flag to DRM_IOCTL_SYNCOBJ_WAIT which instructs the IOCTL to wait for the syncobj to have a non-null fence and then wait on the fence. Combined with DRM_IOCTL_SYNCOBJ_RESET, you can easily get the Vulkan behavior. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/g

[PATCH 8/9] drm/syncobj: Add a callback mechanism for replace_fence

2017-08-08 Thread Jason Ekstrand
there is no callback list, it spends a very short amount of time inside the lock. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_syncobj.c | 51 ++- include/drm/drm_syncobj.h | 33 +++- 2

[PATCH 7/9] drm/syncobj: Add a reset ioctl

2017-08-08 Thread Jason Ekstrand
This just resets the dma_fence to NULL so it looks like it's never been signaled. This will be useful once we add the new wait API for allowing wait on "submit and signal" behavior. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_internal.h | 2 ++

[PATCH 3/9] drm/syncobj: Remove file_private from replace_fence

2017-08-08 Thread Jason Ekstrand
It's completely unused. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +-- drivers/gpu/drm/drm_syncobj.c | 5 ++--- include/drm/drm_syncobj.h | 3 +-- 3 files changed, 4 insertions(+), 7 deletions(-) diff

[PATCH] drm/i915: Update from drm-next

2017-08-09 Thread Jason Ekstrand
--- include/drm/i915_drm.h | 61 ++ 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 5ebe046..c26bf7c 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -412,6

Re: [PATCH] drm/syncobj: Allow wait for submit and signal behavior (v2)

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 2:31 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-08-09 18:00:54) > > +static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj > **syncobjs, > > +

Re: [PATCH] drm/syncobj: Allow wait for submit and signal behavior (v2)

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 11:25 AM, Christian König <deathsim...@vodafone.de> wrote: > Am 09.08.2017 um 19:57 schrieb Chris Wilson: > >> Quoting Jason Ekstrand (2017-08-09 18:00:54) >> >>> Vulkan VkFence semantics require that the application be able to perform

Re: [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Jason Ekstrand
e vgem fence as both are handles in an idr (the fence here is not > a sync-file fd like in most other drivers). The main benefit for syncobj > is that it allows to create channels between objects and drivers by > virtue of its persistence beyond the vgem fence itself. > > Signed

Re: [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 6:23 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-08-10 02:02:43) > > On Wed, Aug 9, 2017 at 12:03 PM, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: > > > > To further facilitate GEM t

[PATCH v3 9/9] drm/syncobj: Allow wait for submit and signal behavior (v3)

2017-08-09 Thread Jason Ekstrand
and wait-any cases v3: - Unify the timeout == 0 case a bit with the timeout > 0 case - use wait_event_interruptible_timeout Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Dave Airlie <airl...@redhat.com> --- drivers/gpu/drm/drm_

Re: [PATCH] drm/syncobj: Allow wait for submit and signal behavior (v2)

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 3:41 PM, Chris Wilson wrote: > Quoting Chris Wilson (2017-08-09 18:57:44) > > So we are taking a snapshot here. It looks like this could have been > > done using a dma_fence_array + dma_fence_proxy for capturing the future > > fence. > > A quick

Re: [PATCH 2/9] drm/syncobj: Lock around drm_syncobj::fence

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 2:21 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Jason Ekstrand (2017-08-08 23:46:02) > > The atomic exchange operation we were doing before in replace_fence was > > sufficient for the case where it raced with itself. However, i

[PATCH] i915,drm/fourcc: Improve the CCS modifier documentation

2017-08-18 Thread Jason Ekstrand
g to fully describe it is premature. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Ben Widawsky <b...@bwidawsk.net> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- include/uapi/drm/drm_fourcc.h | 35 ++- 1 file changed, 22 insertio

Re: [PATCH] drm/i915: Fix integer overflow tests

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 2:56 AM, Imre Deak wrote: > On Thu, Aug 17, 2017 at 12:50:37PM +0300, Dan Carpenter wrote: > > On Thu, Aug 17, 2017 at 12:37:00PM +0300, Imre Deak wrote: > > > On Thu, Aug 17, 2017 at 09:23:10AM +0300, Dan Carpenter wrote: > > > > There are some

Re: [PATCH 1/5] drm: introduce sync objects

2017-05-09 Thread Jason Ekstrand
On Mon, May 8, 2017 at 7:26 PM, Dave Airlie wrote: > On 4 May 2017 at 18:16, Chris Wilson wrote: > > On Wed, Apr 26, 2017 at 01:28:29PM +1000, Dave Airlie wrote: > >> +#include > > > > I wonder if Daniel has already split everything used here into

Re: [rfc] drm sync objects (search for spock)

2017-05-09 Thread Jason Ekstrand
On Wed, Apr 26, 2017 at 7:57 AM, Christian König wrote: > Am 26.04.2017 um 11:57 schrieb Dave Airlie: > >> On 26 April 2017 at 18:45, Christian König >> wrote: >> >>> Am 26.04.2017 um 05:28 schrieb Dave Airlie: >>> Okay I've gone around the

Re: [PATCH 1/5] drm: introduce sync objects (v3)

2017-05-24 Thread Jason Ekstrand
I can't really review for all of the kernel details (though the seem ok to me) so this mostly applies to the API: Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> On Wed, May 24, 2017 at 12:06 AM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com

Re: [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v3)

2017-05-24 Thread Jason Ekstrand
On Wed, May 24, 2017 at 10:25 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Wed, May 24, 2017 at 12:06 AM, Dave Airlie <airl...@gmail.com> wrote: > >> From: Dave Airlie <airl...@redhat.com> >> >> This interface will allow sync object to be used to

Re: [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v3)

2017-05-24 Thread Jason Ekstrand
On Wed, May 24, 2017 at 12:06 AM, Dave Airlie wrote: > From: Dave Airlie > > This interface will allow sync object to be used to back > Vulkan fences. This API is pretty much the vulkan fence waiting > API, and I've ported the code from amdgpu. > > v2:

Re: [PATCH 3/5] drm/syncobj: add sync_file interaction.

2017-05-24 Thread Jason Ekstrand
Yes, I believe this is the proper way for sync_file and syncobj to interact. Again, I can't really review for all of the kernel details (though the seem ok to me) so this mostly applies to the API: Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> On Wed, May 24, 2017 at 12:06 AM, Dave

[PATCH] drm/syncobj: Add a signal ioctl

2017-08-24 Thread Jason Ekstrand
that is already signaled but the IOCTL seemed a bit cleaner and more generic. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 2 ++ drivers/gpu/drm/drm_syncobj.c | 71 ++ includ

Re: [PATCH] i915,drm/fourcc: Improve the CCS modifier documentation

2017-08-21 Thread Jason Ekstrand
On Mon, Aug 21, 2017 at 9:25 AM, Ben Widawsky <b...@bwidawsk.net> wrote: > On 17-08-18 11:34:40, Jason Ekstrand wrote: > >> This updates the documentation on the intel CCS modifiers for a couple >> of reasons: >> >> 1) The old documentation require

Re: [PATCH 0/9] drm/syncobj: Add full-featured wait support (v2)

2017-08-21 Thread Jason Ekstrand
On Wed, Aug 16, 2017 at 1:10 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Wed, Aug 16, 2017 at 9:53 AM, Christian König <christian.koe...@amd.com > > wrote: > >> [SNIP] >> >>> See a wait_queue is a callback mechanism anyway, so you are wrappin

Re: [PATCH] i915,drm/fourcc: Improve the CCS modifier documentation

2017-08-25 Thread Jason Ekstrand
On Fri, Aug 25, 2017 at 8:10 AM, Ville Syrjälä < ville.syrj...@linux.intel.com> wrote: > On Fri, Aug 18, 2017 at 11:34:40AM -0700, Jason Ekstrand wrote: > > This updates the documentation on the intel CCS modifiers for a couple > > of reasons: > > > >

[PATCH] drm/syncobj: Fix the cb_list comment

2017-08-28 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- include/drm/drm_syncobj.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_syncobj.h b/include/drm/drm_syncobj.h index aef7c10..c00fee5 100644 --- a/include/drm/drm_syncobj.h +++ b/inclu

Re: [PATCH] drm/syncobj: Fix the cb_list comment

2017-08-28 Thread Jason Ekstrand
Never mind this one. I'm squashing this into the relavant patch and sending a v2 of that one patch On Mon, Aug 28, 2017 at 7:33 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > --- > include/drm/drm_syncobj.h | 2 +-

[PATCH 5/10] drm/syncobj: Add a callback mechanism for replace_fence (v3)

2017-08-28 Thread Jason Ekstrand
there is no callback list, it spends a very short amount of time inside the lock. v2: - Don't lock in drm_syncobj_fence_get. We only really need to lock around fence_replace to make the callback work. v3: - Fix the cb_list comment to make kbuild happy Signed-off-by: Jason Ekstrand <

[PATCH 1/2] drm/syncobj: Add a reset ioctl (v3)

2017-08-28 Thread Jason Ekstrand
This just resets the dma_fence to NULL so it looks like it's never been signaled. This will be useful once we add the new wait API for allowing wait on "submit and signal" behavior. v2: - Take an array of sync objects (Dave Airlie) v3: - Throw -EINVAL if pad != 0 Signed-off-by: Jaso

[PATCH 2/2] drm/syncobj: Add a signal ioctl (v3)

2017-08-28 Thread Jason Ekstrand
that is already signaled but the IOCTL seemed a bit cleaner and more generic. v2: - Take an array of sync objects (Dave Airlie) v3: - Throw -EINVAL if pad != 0 Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> signal --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c

[PATCH 04/10] drm/syncobj: add sync obj wait interface. (v8)

2017-08-25 Thread Jason Ekstrand
: Dave Airlie <airl...@redhat.com> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> Acked-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/

[PATCH 06/10] drm/syncobj: Allow wait for submit and signal behavior (v5)

2017-08-25 Thread Jason Ekstrand
tra layer of callbacks Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Dave Airlie <airl...@redhat.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/drm_syncobj.c | 252 +

[PATCH 07/10] drm/syncobj: Add a CREATE_SIGNALED flag

2017-08-25 Thread Jason Ekstrand
. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_syncobj.c | 57 --- include/uapi/drm/drm.h| 1 + 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/g

[PATCH 05/10] drm/syncobj: Add a callback mechanism for replace_fence (v2)

2017-08-25 Thread Jason Ekstrand
there is no callback list, it spends a very short amount of time inside the lock. v2: - Don't lock in drm_syncobj_fence_get. We only really need to lock around fence_replace to make the callback work. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_syn

[PATCH 01/10] drm/syncobj: Rename fence_get to find_fence

2017-08-25 Thread Jason Ekstrand
The function has far more in common with drm_syncobj_find than with any in the get/put functions. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Acked-by: Christian König <christian.koe...@amd.com> (v1) --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/d

[PATCH 02/10] drm/syncobj: Add a race-free drm_syncobj_fence_get helper (v2)

2017-08-25 Thread Jason Ekstrand
t more than just get a reference in drm_syncobj_fence_get should we wish to do so. v2: - RCU isn't that scary - Call rcu_read_lock/unlock - Don't rename fence to _fence - Make the helper static inline Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Acked-by: Christian König &l

[PATCH 03/10] i915: Use drm_syncobj_fence_get

2017-08-25 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 3d74f3a..4c20162

[PATCH 08/10] drm/syncobj: Add a syncobj_array_find helper

2017-08-25 Thread Jason Ekstrand
The wait ioctl has a bunch of code to read an syncobj handle array from userspace and turn it into an array of syncobj pointers. We're about to add two new IOCTLs which will need to work with arrays of syncobj handles so let's make some helpers. Signed-off-by: Jason Ekstrand <

[PATCH 10/10] drm/syncobj: Add a signal ioctl (v2)

2017-08-25 Thread Jason Ekstrand
that is already signaled but the IOCTL seemed a bit cleaner and more generic. v2: - Take an array of sync objects (Dave Airlie) Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 2 ++ drivers/gpu/drm/drm_syncobj.c

[PATCH 09/10] drm/syncobj: Add a reset ioctl (v2)

2017-08-25 Thread Jason Ekstrand
This just resets the dma_fence to NULL so it looks like it's never been signaled. This will be useful once we add the new wait API for allowing wait on "submit and signal" behavior. v2: - Take an array of sync objects (Dave Airlie) Signed-off-by: Jason Ekstrand <ja...@jlekstrand.

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-14 Thread Jason Ekstrand
Looks good to me. With this properly sprinkled on the appropriate patches, the entire series is Reviewed-by: Jason Ekstrand On Thu, Jun 14, 2018 at 5:57 PM, Keith Packard wrote: > We sorted out what 'vscan' means and are trying to use it correctly. > > vscan = 0 is the same as

Re: [PATCH 1/7] vulkan: Add VK_EXT_display_surface_counter [v4]

2018-06-16 Thread Jason Ekstrand
e of places > > v4: Adopt Jason Ekstrand's coding conventions > > Declare variables at first use, eliminate extra whitespace > between types and names. Wrap lines to 80 columns. > > Suggested-by: Jason Ekstrand > > Signed-off-by: Keith Packard > --- &g

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Jason Ekstrand
ng conventions > > Declare variables at first use, eliminate extra whitespace between > types and names. Wrap lines to 80 columns. > > Suggested-by: Jason Ekstrand > > Signed-off-by: Keith Packard > --- > src/intel/vulkan/anv_queue.c | 105 ++

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-19 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 1:56 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > 1) We weren't setting planeReorderPossible at all and we were using 0 > > instead of VK_FALSE (they're the same but we should use the enum) for > > persistentContent > > 2) We we

Re: [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-19 Thread Jason Ekstrand
; Add NULL parameter to drmCrtcQueueSequence ioctl as we > don't care what sequence the event was actually queued to. > > v3: Adapt to pthread clock switch to MONOTONIC > > v4: Fix scope for wsi_display_mode andwsi_display_connector allocs > > Suggested-by: Jason Ek

  1   2   3   4   5   6   7   8   9   >