Re: [PATCH] drm/fb-helper: Fixup fill_info cleanup

2019-03-27 Thread Noralf Trønnes
Den 27.03.2019 13.58, skrev Daniel Vetter: > I forgot the !CONFIG_FBDEV case. Also some kerneldoc needed more > adjusting. > > Cc: Noralf Trønnes > Cc: Alex Deucher > Signed-off-by: Daniel Vetter > --- Really nice that we have all these bots helping us out. Review

[PATCH 14/16] drm/client: Add display abstraction

2019-03-26 Thread Noralf Trønnes
Add display abstraction and helpers to probe for displays and commit modesets. TODO: If the bootsplash client doesn't need to subclass drm_client_display, the callbacks can be removed. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c

[PATCH 15/16] drm/client: Hack: Add bootsplash example

2019-03-26 Thread Noralf Trønnes
bootsplash to fend off fbdev. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_bootsplash.c | 216 +++ drivers/gpu/drm/drm_client.c | 7 + drivers/gpu/drm/drm_drv.c

[PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

2019-03-26 Thread Noralf Trønnes
drm_dev_register() initializes internal clients like bootsplash as the last thing it does, so all setup needs to be done at this point. Fix by calling vc4_kms_load() before registering. Also check the error code returned from that function. Cc: Eric Anholt Signed-off-by: Noralf Trønnes

[PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-03-26 Thread Noralf Trønnes
ck while committing. When DRM userspace does its first open, it will now wait until fb-helper is done. The helper will stay away if there's a master. Locking rule: Always take the fb-helper lock first. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_aut

[PATCH 12/16] drm/fb-helper: Move out modeset config code

2019-03-26 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. There is one addition and that is exporting drm_client_modesets_probe(). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 698 drivers/gpu/drm/drm_fb_helper.c | 697

[PATCH 11/16] drm/fb-helper: Prepare to move out modeset config code

2019-03-26 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 75 + include/drm/drm_fb_helper.h | 4 -- 2 files changed, 57 insertions(+), 22 deletions(-) diff --git a

[PATCH 10/16] drm/fb-helper: Remove drm_fb_helper_connector

2019-03-26 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Rename functions which signature is changed since they will be moved to drm_client in a later patch. Signed-off-by: Noralf Trønnes --- checkpatch complains, but I'm unable to

[PATCH 06/16] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-03-26 Thread Noralf Trønnes
intel-...@lists.freedesktop.org Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c| 194 - drivers/gpu/drm/i915/intel_fbdev.c | 218 - include/drm/drm_fb_helper.h| 23 --- 3 files changed, 190 insertions(+), 245 del

[PATCH 09/16] drm/fb-helper: Move out commit code

2019-03-26 Thread Noralf Trønnes
Move the modeset commit code to drm_client. No changes except exporting API. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 236 drivers/gpu/drm/drm_fb_helper.c | 232 --- include/drm/drm_client.h| 3

[PATCH 05/16] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-03-26 Thread Noralf Trønnes
The values are already present in the modeset. This is done in preparation for the removal of struct drm_fb_helper_crtc. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 12 include/drm/drm_fb_helper.h | 2 -- 2 files changed, 4 insertions(+), 10 deletions

[PATCH 00/16] drm/fb-helper: Move modesetting code to drm_client

2019-03-26 Thread Noralf Trønnes
. Noralf. Noralf Trønnes (16): drm/fb-helper: Remove unused gamma_size variable drm/fb-helper: dpms_legacy(): Only set on connectors in use drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() drm/fb-helper: No need to cache rotation and sw_rotations drm/fb-helper: Remove

[PATCH 08/16] drm/fb-helper: Prepare to move out commit code

2019-03-26 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 93 + 1 file changed, 59 insertions(+), 34 dele

[PATCH 07/16] drm/fb-helper: Remove drm_fb_helper_crtc

2019-03-26 Thread Noralf Trønnes
. This means that the max connector argument for drm_fb_helper_init() and drm_fb_helper_fbdev_setup() isn't used anymore, a todo entry for this is added. Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 7 + drivers/gpu/drm/drm_client.c| 93 drivers/gp

[PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-26 Thread Noralf Trønnes
*/ on a separate line - CHECK: Alignment should match open parenthesis Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_atomic.c| 168 drivers/gpu/drm/drm_atomic_helper.c | 164 --- drivers/gpu/drm/drm_crtc_internal.h | 5 + include

[PATCH 01/16] drm/fb-helper: Remove unused gamma_size variable

2019-03-26 Thread Noralf Trønnes
erface using fb."). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 04d23cb430bf..eea15465da7a 100644 --- a/drivers/gpu/drm/drm_fb_helper

[PATCH 04/16] drm/fb-helper: No need to cache rotation and sw_rotations

2019-03-26 Thread Noralf Trønnes
Getting rotation info is cheap so we can do it on demand. This is done in preparation for the removal of struct drm_fb_helper_crtc. Cc: Hans de Goede Signed-off-by: Noralf Trønnes --- Hans, You had this comment inline in restore_fbdev_mode_atomic() the last time I sent this out: We want

[PATCH 02/16] drm/fb-helper: dpms_legacy(): Only set on connectors in use

2019-03-26 Thread Noralf Trønnes
For each enabled crtc the functions sets dpms on all registered connectors. Limit this to only doing it once and on the connectors actually in use. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a

Re: [PATCH 21/21] drm/fb-helper: Unexport fill_{var,info}

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > Not used by drivers anymore. > > v2: Rebase > > Signed-off-by: Daniel Vetter > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lis

Re: [PATCH 20/21] drm/vboxvideo: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
: Greg Kroah-Hartman > Cc: Hans de Goede > Cc: Daniel Vetter > Cc: Alexander Kapshuk > Cc: Bartlomiej Zolnierkiewicz > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 19/21] drm/udl: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
; /* must be first */ > struct udl_framebuffer ufb; > int fb_count; > }; > @@ -402,15 +402,12 @@ static int udlfb_create(struct drm_fb_helper *helper, > You forgot to remove the info->par assignement here. With that: Acked-by: Noralf Trønnes > ufbdev-&g

Re: [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
@vger.kernel.org > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
lists.infradead.org > Cc: linux-rockc...@lists.infradead.org > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 16/21] drm/radeon: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This should not result in any changes. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: amd-...@lists.

Re: [PATCH 15/21] drm/omap: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This changes the fb name from "omapdrm" to "omapdrmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Tomi Valkeinen > --- Reviewed-by: Noralf Trønnes ___

Re: [PATCH 14/21] drm/nouveau: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
evil calling contexts. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Ben Skeggs > Cc: nouv...@lists.freedesktop.org > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 15.42, skrev Noralf Trønnes: > > > Den 26.03.2019 14.20, skrev Daniel Vetter: >> This will change the fb name from "msm" to "msmdrmfb". >> >> v2: Rebase >> >> Signed-off-by: Daniel Vetter >>

Re: [PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This will change the fb name from "msm" to "msmdrmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: linux-arm-...@vger.kernel.org > Cc: freedr...@lists.freede

Re: [PATCH 12/21] drm/mga200g: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > Should not result in any changes. It changes the name, so: Only changes the name of the fb from "mgadrmfb" to "mga200drmfb". Acked-by: Noralf Trønnes > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc:

Re: [PATCH 11/21] drm/i915: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > This changes the fb name from "inteldrmfb" to "i915drmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-...@lists.fre

Re: [PATCH 10/21] drm/hibmc: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
rder > Cc: Daniel Vetter > Cc: John Garry > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 09/21] drm/gma500: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > This will change the fb name from "psbdrmfb" to "gma500drmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Patrik Jakobsson > --- Acked-by: Noralf Trønnes ___

Re: [PATCH 08/21] drm/exynos: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
of Kozlowski > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel.org > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 07/21] drm/cirrus: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
drv.h > @@ -143,7 +143,7 @@ struct cirrus_device { > > > struct cirrus_fbdev { > - struct drm_fb_helper helper; > + struct drm_fb_helper helper; /* must be first */ Same implicit issue here as with ast, but anyways: Acked-by: Noralf Trønnes > struct drm_framebuffer *gfb; &

Re: [PATCH 06/21] drm/ast: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
t */ I think being implicit like this is confusing. I would prefer to set 'info->par = afbdev;' after calling drm_fb_helper_fill_info(). But it works and the pattern is used elsewhere: Acked-by: Noralf Trønnes > struct ast_framebuffer afb; > void *sysram;

Re: [PATCH 05/21] drm/armada: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > Only changes the name of the fb from "armada-drmfb" to armadafb. armadafb -> armadadrmfb > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Russell King > --- Reviewed-by: Noralf Trønnes > driv

Re: [PATCH 04/21] drm/amdgpu: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Zhang > Cc: Daniel Vetter > Cc: Daniel Stone > Cc: Shirish S > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 03/21] drm/fb_helper: set info->par in fill_info()

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > The fbdev emulation helpers pretty much assume that this is set. > Let's do it for everyone. > > Reviewed-by: Sam Ravnborg > Cc: Sam Ravnborg > Signed-off-by: Daniel Vetter > --- R

Re: [PATCH 02/21] drm/fb-helper: set fbi->fix.id in fill_info()

2019-03-26 Thread Noralf Trønnes
hink. > > v2: Rebase and amend commit message, thanks to Ilia for pointing out > that this needs to be spelled out. > > Cc: Ilia Mirkin > igned-off-by: Daniel Vetter igned -> Signed Reviewed-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_fb_helper.c | 5 +++--

Re: [PATCH 01/21] drm/fb-helper: Add fill_info() functions

2019-03-26 Thread Noralf Trønnes
neric fbdev > helper code. Follow-up patches will beef it up more and roll > it out to all drivers. > > v2: We need to keep sizes, since they might not match the fb dimesions dimesions -> dimensions > (Noralf) > > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter

Re: [PATCH 2/2] drm/udl: add a release method and delay modeset teardown

2019-03-15 Thread Noralf Trønnes
Den 15.03.2019 06.13, skrev Dave Airlie: > From: Dave Airlie > > If we unplug a udl device, the usb callback with deinit the > mode_config struct, however userspace will still have an open > file descriptor and a framebuffer on that device. When userspace > closes the fd, we'll oops because it'

Re: [PATCH 1/2] drm: do lower level device put on unplugged releases

2019-03-15 Thread Noralf Trønnes
Den 15.03.2019 06.13, skrev Dave Airlie: > From: Dave Airlie > > When we release the file handle on a device that has been unplugged > it has already called the unregister path, which doesn't like being > called again. We should just do the dev put version instead. > > This fixes some crashes

Re: udl hotunplug broken

2019-03-15 Thread Noralf Trønnes
Den 15.03.2019 05.19, skrev Dave Airlie: > Hey, > > Not sure how long this has been broken, considering plugging it in was > broken, unplugging is much worse. Is there anything outside my tree > that might be fixing this? > > Currently it appears if I unplug udl while userspace has the device >

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Noralf Trønnes
Den 12.03.2019 23.13, skrev Ahmed S. Darwish: > Hi, > > [[ CCing John for the trylock parts ]] > > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: >> >> >> Den 11.03.2019 20.23, skrev Daniel Vetter: >>> On Mon, Mar 11, 2019 at 06:42:1

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 18.37, skrev Noralf Trønnes: > > > Den 12.03.2019 18.25, skrev Ville Syrjälä: >> On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: >>> >>> >>> Den 12.03.2019 17.17, skrev Ville Syrjälä: >>>> On Tue, Mar 12, 2

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 18.25, skrev Ville Syrjälä: > On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: >> >> >> Den 12.03.2019 17.17, skrev Ville Syrjälä: >>> On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: >>>> On 2019-03-11 6:42 p

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 17.17, skrev Ville Syrjälä: > On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: >> On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: >>> This adds support for outputting kernel messages on panic(). >>> A kernel message dumper is used to dump t

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 11.58, skrev Daniel Vetter: > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: >> >> >> Den 11.03.2019 20.23, skrev Daniel Vetter: >>> On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: >>>> This adds suppo

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Noralf Trønnes
Den 11.03.2019 20.29, skrev Daniel Vetter: > On Mon, Mar 11, 2019 at 08:23:38PM +0100, Daniel Vetter wrote: >> On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: >>> This adds support for outputting kernel messages on panic(). >>> A kernel message dumper i

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Noralf Trønnes
Den 11.03.2019 20.23, skrev Daniel Vetter: > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: >> This adds support for outputting kernel messages on panic(). >> A kernel message dumper is used to dump the log. The dumper iterates >> over each DRM device an

Re: DRM-based Oops viewer

2019-03-11 Thread Noralf Trønnes
Den 10.03.2019 02.31, skrev Ahmed S. Darwish: > Hello DRM/UEFI maintainers, > > Several years ago, I wrote a set of patches to dump the kernel > log to disk upon panic -- through BIOS INT 0x13 services. [1] > > The overwhelming response was that it's unsafe to do this in a > generic manner. Lin

[PATCH v2 0/3] drm: Add panic handling

2019-03-11 Thread Noralf Trønnes
ulticolumn support - Support some YUV formats - cma: vmap PRIME buffers on import to support that case Noralf Trønnes (3): drm: Add support for panic message output drm/cma-helper: Add support for panic screen drm/vc4: Support for panic screen drivers/gpu/drm/Kconfig | 3 + drive

[PATCH v2 3/3] drm/vc4: Support for panic screen

2019-03-11 Thread Noralf Trønnes
Use drm_fb_cma_fb_create() to get panic screen support. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/vc4/vc4_kms.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index

[PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Noralf Trønnes
supported. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 3 + drivers/gpu/drm/drm_drv.c | 3 + drivers/gpu/drm/drm_framebuffer.c | 117 ++ drivers/gpu/drm/drm_internal.h| 4 + drivers/gpu/drm/drm_panic.c | 363 ++ i

[PATCH v2 2/3] drm/cma-helper: Add support for panic screen

2019-03-11 Thread Noralf Trønnes
Add drm_fb_cma_fb_create() which creates a framebuffer that supports panic message output. vmap PRIME buffers on import to support panic on those as well. There is no atomic way to get a virtual address on a dma_buf. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_cma_helper.c | 43

Re: [PATCH] tinydrm/mipi-dbi: Use dma-safe buffers for all SPI transfers

2019-03-04 Thread Noralf Trønnes
Den 04.03.2019 16.10, skrev Andy Shevchenko: > On Mon, Mar 04, 2019 at 03:45:56PM +0100, Noralf Trønnes wrote: >> >> >> Den 22.02.2019 16.58, skrev Andy Shevchenko: >>> On Fri, Feb 22, 2019 at 01:43:29PM +0100, Noralf Trønnes wrote: >>>> Buffers pass

Re: [PATCH] tinydrm/mipi-dbi: Use dma-safe buffers for all SPI transfers

2019-03-04 Thread Noralf Trønnes
Den 22.02.2019 16.58, skrev Andy Shevchenko: > On Fri, Feb 22, 2019 at 01:43:29PM +0100, Noralf Trønnes wrote: >> Buffers passed to spi_sync() must be dma-safe even for tiny buffers since >> some SPI controllers use DMA for all transfers. >> >> Example splat with C

Re: [PATCH v3 0/7] drm/tinydrm: Remove tinydrm_device

2019-03-04 Thread Noralf Trønnes
Den 25.02.2019 15.42, skrev Noralf Trønnes: > This patchset is part of the effort to remove tinydrm.ko. It removes > struct tinydrm_device and tinydrm.h. > > Only one change in this version and that is expanding the driver > example. > > The drm_dev_unplug() dependency se

Re: [Intel-gfx] [RFC v4 12/25] drm/i915: Add drm_driver->initial_client_display callback

2019-03-01 Thread Noralf Trønnes
Den 16.04.2018 10.38, skrev Daniel Vetter: > On Sat, Apr 14, 2018 at 01:53:05PM +0200, Noralf Trønnes wrote: >> As part of moving the modesetting code out of drm_fb_helper and into >> drm_client, the drm_fb_helper_funcs->initial_config callback needs to go. >> Repl

Re: [PATCH 1/2] drm/hibmc: Drop best_encoder

2019-02-28 Thread Noralf Trønnes
Den 21.02.2019 16.58, skrev Daniel Vetter: > This is the default for atomic drivers. > > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Neil Armstrong > Cc: Luc Van Oostenryck > Cc: Rodrigo Vivi > --- Acked-by: Noralf Trønnes &

Re: [PATCH 3/3] drm/virtio: implement prime export

2019-02-27 Thread Noralf Trønnes
nevertheless. > > Signed-off-by: Gerd Hoffmann Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/virtio: implement prime mmap

2019-02-27 Thread Noralf Trønnes
Den 27.02.2019 15.44, skrev Gerd Hoffmann: > Sync gem vm_node.start with ttm vm_node.start, > then we can just call drm_gem_prime_mmap(). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing

Re: [PATCH 2/3] drm/virtio: implement prime pin/unpin

2019-02-27 Thread Noralf Trønnes
void virtgpu_gem_prime_unpin(struct drm_gem_object *obj) > { > - WARN_ONCE(1, "not implemented"); > + /* nothing */ > } You can just remove these dummies the callbacks are optional. See drm_gem_pin(). With that: Reviewed-by: Noralf Trønnes > > void *v

Re: [PATCH v3 5/7] drm/tinydrm: Drop using tinydrm_device

2019-02-27 Thread Noralf Trønnes
Den 27.02.2019 15.27, skrev Gerd Hoffmann: > On Mon, Feb 25, 2019 at 03:42:30PM +0100, Noralf Trønnes wrote: >> Use devm_drm_dev_init() and drop using tinydrm_device. >> >> v2: devm_drm_dev_register() was dropped so add driver release callbacks. >> >&

Re: [PATCH v1] drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display

2019-02-25 Thread Noralf Trønnes
Den 25.02.2019 15.45, skrev Andy Shevchenko: > The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one. > Add support for it. > > [1]: https://cdn-shop.adafruit.com/datasheets/MI0283QT-11+V1.1.PDF This one is supported by drivers/gpu/drm/tinydrm/mi0283qt.c. It was the first tin

[PATCH v3 4/7] drm/tinydrm/repaper: Drop using tinydrm_device

2019-02-25 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add a driver release callback. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/tinydrm/repaper.c | 84 ++- 1 file changed, 61 insertions

[PATCH v3 0/7] drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Noralf Trønnes
27;ve cc'ed intel-gfx so the Intel CI can verify the parent device ref patch. Noralf. Noralf Trønnes (7): drm/drv: Hold ref on parent device during drm_device lifetime drm: Add devm_drm_dev_init() drm/drv: DOC: Add driver example code drm/tinydrm/repaper: Drop using tinydrm_device d

[PATCH v3 5/7] drm/tinydrm: Drop using tinydrm_device

2019-02-25 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add driver release callbacks. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 40 +-- drivers/gpu/drm/tinydrm/ili9225.c | 40 +-- drivers/gpu/drm/tinydrm

[PATCH v3 7/7] drm/tinydrm: Use drm_dev_enter/exit()

2019-02-25 Thread Noralf Trønnes
t do block ->disable after unplug. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 9 -- drivers/gpu/drm/tinydrm/ili9225.c | 23 +-- drivers/gpu/drm/tinydrm/ili9341.c | 9 -- drivers/gpu/drm/tinydrm/mi0283qt.c | 9 -- drivers/gpu/drm/tinyd

[PATCH v3 6/7] drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Noralf Trønnes
No more users left so it can go alongside its helpers. Update the tinydrm docs description and remove todo entry. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg Acked-by: Daniel Vetter --- Documentation/gpu/tinydrm.rst | 32 ++-- Documentation/gpu/todo.rst

[PATCH v3 3/7] drm/drv: DOC: Add driver example code

2019-02-25 Thread Noralf Trønnes
Add driver example that shows how devm_drm_dev_init() can be used. v2: Expand docs (Sam, Daniel) Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 132 ++ 1 file changed, 132 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v3 2/7] drm: Add devm_drm_dev_init()

2019-02-25 Thread Noralf Trønnes
This adds a resource managed (devres) version of drm_dev_init(). v2: Remove devm_drm_dev_register() since we can't touch hw in devm release functions and drivers want to disable hw on driver module unload (Daniel Vetter, Greg KH) Cc: Daniel Vetter Cc: Greg KH Signed-off-by: N

[PATCH v3 1/7] drm/drv: Hold ref on parent device during drm_device lifetime

2019-02-25 Thread Noralf Trønnes
This makes it safe to access drm_device->dev after the parent device has been removed/unplugged. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c in

[PATCH] tinydrm/mipi-dbi: Use dma-safe buffers for all SPI transfers

2019-02-22 Thread Noralf Trønnes
i_sync+0x1dd/0x1f0 [ 23.750773] spi_sync+0x26/0x40 [ 23.750790] mipi_dbi_typec3_command_read+0x14d/0x240 [mipi_dbi] [ 23.750802] ? spi_finalize_current_transfer+0x10/0x10 [ 23.750821] mipi_dbi_typec3_command+0x1bc/0x1d0 [mipi_dbi] Reported-by: Andy Shevchenko Signed-off-by: Noralf T

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Noralf Trønnes
Den 21.02.2019 12.35, skrev Gerd Hoffmann: > It'll be useful for other drivers too, so move it to drm_fb_helper.c > (and rename it of course). Also add docs. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_fb_helper.h | 2 ++ > drivers/gpu/drm/drm_fb_helper.c | 39 ++

Re: [PATCH v2 0/2] drm/drv: Rework drm_dev_unplug() (was: Remove drm_dev_unplug())

2019-02-21 Thread Noralf Trønnes
Den 08.02.2019 15.01, skrev Noralf Trønnes: > This series makes drm_dev_unplug() compatible with the upcoming > devm_drm_dev_init(), fixes a double drm_dev_unregister() situation and > simplifies the drm_device ref handling wrt to the last fd closed after > unregister. > > Th

Re: [PATCH v1] drm/tinydrm: Trivia typo fix

2019-02-21 Thread Noralf Trønnes
Den 19.02.2019 19.13, skrev Andy Shevchenko: > Fix adddress -> address typo. > > Signed-off-by: Andy Shevchenko > --- Applied, thanks. Noralf. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/

Re: [PATCH 0/2] Lima DRM driver

2019-02-14 Thread Noralf Trønnes
Den 13.02.2019 02.44, skrev Rob Herring: > On Tue, Feb 12, 2019 at 7:00 PM Eric Anholt wrote: >> >> Rob Herring writes: >> [snip] >>> FWIW, I'm working on the panfrost driver and am using the shmem >>> helpers from Noralf. It's the early stages though. I started a patch >>> for etnaviv to use

Re: [PATCH v2 03/12] drm/drv: DOC: Add driver example code

2019-02-12 Thread Noralf Trønnes
Den 12.02.2019 15.06, skrev Daniel Vetter: > On Sun, Feb 10, 2019 at 02:10:30PM +0100, Noralf Trønnes wrote: >> Add driver example that shows how devm_drm_dev_init() can be used. >> >> Signed-off-by: Noralf Trønnes >> --- >> >> I'm not sure how detail

Re: [PATCH v2 03/12] drm/drv: DOC: Add driver example code

2019-02-12 Thread Noralf Trønnes
Den 10.02.2019 22.03, skrev Sam Ravnborg: > Hi Noralf > > On Sun, Feb 10, 2019 at 02:10:30PM +0100, Noralf Trønnes wrote: >> Add driver example that shows how devm_drm_dev_init() can be used. >> >> Signed-off-by: Noralf Trønnes > > Always good with examples

[PATCH v2 11/12] drm/tinydrm: Use drm_dev_enter/exit()

2019-02-10 Thread Noralf Trønnes
t do block ->disable after unplug. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 9 -- drivers/gpu/drm/tinydrm/ili9225.c | 23 +-- drivers/gpu/drm/tinydrm/ili9341.c | 9 -- drivers/gpu/drm/tinydrm/mi0283qt.c | 9 -- drivers/gpu/drm/tinyd

[PATCH v2 12/12] drm/fb-helper: generic: Don't take module ref for fbcon

2019-02-10 Thread Noralf Trønnes
It's now safe to let fbcon unbind automatically on fbdev unregister. The crash problem was fixed in commit 2122b40580dd ("fbdev: fbcon: Fix unregister crash when more than one framebuffer") Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_

[PATCH v2 10/12] drm/tinydrm: Remove tinydrm_device

2019-02-10 Thread Noralf Trønnes
No more users left so it can go alongside its helpers. Update the tinydrm docs description and remove todo entry. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg Acked-by: Daniel Vetter --- Documentation/gpu/tinydrm.rst | 32 ++-- Documentation/gpu/todo.rst

[PATCH v2 04/12] drm/modes: Add DRM_SIMPLE_MODE()

2019-02-10 Thread Noralf Trønnes
This adds a helper macro to specify modes that only contain info about resolution. v2: Actually set the width and height (Ilia Mirkin) Cc: Ilia Mirkin Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- drivers/gpu/drm/tinydrm/ili9225.c | 2 +- drivers/gpu/drm

[PATCH v2 02/12] drm: Add devm_drm_dev_init()

2019-02-10 Thread Noralf Trønnes
This adds a resource managed (devres) version of drm_dev_init(). v2: Remove devm_drm_dev_register() since we can't touch hw in devm release functions and drivers want to disable hw on driver module unload (Daniel Vetter, Greg KH) Cc: Daniel Vetter Cc: Greg KH Signed-off-by: N

[PATCH v2 09/12] drm/tinydrm: Drop using tinydrm_device

2019-02-10 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add driver release callbacks. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 40 +-- drivers/gpu/drm/tinydrm/ili9225.c | 40 +-- drivers/gpu/drm/tinydrm

[PATCH v2 05/12] drm/tinydrm: tinydrm_display_pipe_init() don't use tinydrm_device

2019-02-10 Thread Noralf Trønnes
Rework function signature so tinydrm_device can be avoided. Move definition to tinydrm-helpers.h so tinydrm.h can be deleted in a later patch. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 24 ++--- drivers/gpu/drm/tinydrm/mipi-dbi.c

[PATCH v2 00/12] drm/tinydrm: Remove tinydrm_device

2019-02-10 Thread Noralf Trønnes
series depends on this: drm/drv: Rework drm_dev_unplug() https://patchwork.freedesktop.org/series/56406/ Noralf. Noralf Trønnes (12): drm/drv: Hold ref on parent device during drm_device lifetime drm: Add devm_drm_dev_init() drm/drv: DOC: Add driver example code drm/modes: Add DRM_SIMP

[PATCH v2 08/12] drm/tinydrm/repaper: Drop using tinydrm_device

2019-02-10 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add a driver release callback. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/repaper.c | 84 ++- 1 file changed, 61 insertions(+), 23 deletions(-) diff

[PATCH v2 03/12] drm/drv: DOC: Add driver example code

2019-02-10 Thread Noralf Trønnes
Add driver example that shows how devm_drm_dev_init() can be used. Signed-off-by: Noralf Trønnes --- I'm not sure how detailed such an example such be and a description of some kind is also required. Help is needed :-) Noralf. drivers/gpu/drm/drm_drv.c

[PATCH v2 01/12] drm/drv: Hold ref on parent device during drm_device lifetime

2019-02-10 Thread Noralf Trønnes
This makes it safe to access drm_device->dev after the parent device has been removed/unplugged. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c in

[PATCH v2 07/12] drm/tinydrm/mipi-dbi: Add drm_to_mipi_dbi()

2019-02-10 Thread Noralf Trønnes
Add a function to derive mipi_dbi from drm_device now that tinydrm_device is going away. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/tinydrm/hx8357d.c | 3 +-- drivers/gpu/drm/tinydrm/ili9225.c | 11 --- drivers/gpu/drm/tinydrm/ili9341.c | 3

[PATCH v2 06/12] drm/tinydrm: Remove tinydrm_shutdown()

2019-02-10 Thread Noralf Trønnes
It's just a wrapper around drm_atomic_helper_shutdown() now. Also store drm_device in the drvdata field, since that's what's used. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 14 -- drivers/gpu/drm/ti

[PATCH v2 1/2] drm: Fix drm_release() and device unplug

2019-02-08 Thread Noralf Trønnes
struct device When both sides are done with drm_device, it is released. Signed-off-by: Noralf Trønnes Reviewed-by: Oleksandr Andrushchenko Reviewed-by: Daniel Vetter Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_drv.c | 6 +- drivers/gpu/drm/drm_file.c | 6 ++ 2 files changed, 3 i

[PATCH v2 2/2] drm/drv: drm_dev_unplug(): Move out drm_dev_put() call

2019-02-08 Thread Noralf Trønnes
: Noralf Trønnes --- I will take this through drm-misc-next. Noralf. drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/drm_drv.c | 1 - drivers/gpu/drm/udl/udl_drv.c | 1 + drivers/gpu/drm/xen/xen_drm_front.c | 1 + 4 files changed, 3 insertions(+), 1

[PATCH v2 0/2] drm/drv: Rework drm_dev_unplug() (was: Remove drm_dev_unplug())

2019-02-08 Thread Noralf Trønnes
discussion as to why it is kept for the time being: [2/6] drm/drv: Prepare to remove drm_dev_unplug() https://patchwork.freedesktop.org/patch/282902/ Noralf. Noralf Trønnes (2): drm: Fix drm_release() and device unplug drm/drv: drm_dev_unplug(): Move out drm_dev_put() call drivers/gpu/drm

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-06 Thread Noralf Trønnes
Den 06.02.2019 16.26, skrev Daniel Vetter: > On Tue, Feb 05, 2019 at 06:57:50PM +0100, Noralf Trønnes wrote: >> >> >> Den 05.02.2019 17.31, skrev Daniel Vetter: >>> On Tue, Feb 05, 2019 at 11:20:55AM +0100, Noralf Trønnes wrote: >>>> >>>> &g

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-05 Thread Noralf Trønnes
Den 05.02.2019 17.31, skrev Daniel Vetter: > On Tue, Feb 05, 2019 at 11:20:55AM +0100, Noralf Trønnes wrote: >> >> >> Den 05.02.2019 10.11, skrev Daniel Vetter: >>> On Mon, Feb 04, 2019 at 06:35:28PM +0100, Noralf Trønnes wrote: >>>> >>>> &g

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-05 Thread Noralf Trønnes
Den 05.02.2019 10.11, skrev Daniel Vetter: > On Mon, Feb 04, 2019 at 06:35:28PM +0100, Noralf Trønnes wrote: >> >> >> Den 04.02.2019 16.41, skrev Daniel Vetter: >>> On Sun, Feb 03, 2019 at 04:41:56PM +0100, Noralf Trønnes wrote: >>>> The only thing now t

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-04 Thread Noralf Trønnes
Den 04.02.2019 16.41, skrev Daniel Vetter: > On Sun, Feb 03, 2019 at 04:41:56PM +0100, Noralf Trønnes wrote: >> The only thing now that makes drm_dev_unplug() special is that it sets >> drm_device->unplugged. Move this code to drm_dev_unregister() so that we >> c

<    5   6   7   8   9   10   11   12   13   14   >