; lmem obj")
> Testcase: igt@gem_lmem_swapping@basic-big
> Testcase: igt@gem_lmem_swapping@verify-ccs-big
> Signed-off-by: Matthew Auld
> Cc: Thomas Hellström
> Cc: Ramalingam C
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 44 -
> 1
On 2022-08-05 at 14:22:39 +0100, Matthew Auld wrote:
> We only ever need to emit one ccs block copy command.
Since max size we handle at a time is CHUNK_SZ, we will need only one
cmd.
Reviewed-by: Ramalingam C
>
> Signed-off-by: Matthew Auld
> Cc: Thomas Hellström
> C
On 2022-07-05 at 10:40:56 +0200, Thomas Hellström wrote:
> On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> > VM_BIND functionality maintain that vm->vm_bind_mutex will never be
> > taken
> > while holding vm->mutex.
> > However, while closing 'vm', vma is destroyed while holdi
On 2022-07-04 at 17:05:38 +, Zeng, Oak wrote:
>
>
> Thanks,
> Oak
>
> > -Original Message-
> > From: Intel-gfx On Behalf Of
> > Niranjana Vishwanathapura
> > Sent: July 1, 2022 6:51 PM
> > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > Cc: Zanoni, Paulo R ;
leak.
>
> Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs
> objects")
Looks good to me.
Reviewed-by: Ramalingam C
> Signed-off-by: Matthew Auld
> Cc: Thomas Hellström
> Cc: Lionel Landwerlin
> Cc: Tvrtko Ursulin
> Cc: Jon Bloomfield
>
On 2022-06-28 at 10:40:56 +0100, Matthew Auld wrote:
> On 27/06/2022 18:35, Ramalingam C wrote:
> > When calculating the starting address for ccs data in smem scatterlist,
> > handle the NULL pointer returned from sg_next, incase of scatterlist
> > less than required size..
On 2022-06-27 at 10:18:59 -0700, Matthew Brost wrote:
> On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote:
> > Do not use reserved requests for virtual engines as this is only
> > needed for kernel contexts.
> >
> > Signed-off-by: Ramalingam C
>
When calculating the starting address for ccs data in smem scatterlist,
handle the NULL pointer returned from sg_next, incase of scatterlist
less than required size..
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 13 ++---
1 file changed, 10 insertions(+), 3
Do not use reserved requests for virtual engines as this is only
needed for kernel contexts.
Signed-off-by: Ramalingam C
Suggested-by: Matthew Brost
---
drivers/gpu/drm/i915/i915_request.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915
ff-by: Ramalingam C
Suggested-by: Matthew Brost
---
drivers/gpu/drm/i915/i915_request.c | 55 +
1 file changed, 32 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c
b/drivers/gpu/drm/i915/i915_request.c
index 7f6998bf390c..c71905d8e154 100644
From: Niranjana Vishwanathapura
In i915_fence_get_driver_name(), user may not hold a
reference to rq->engine. Hence do not access it. Instead,
store required device private pointer in 'rq->i915' and use it.
Signed-off-by: Niranjana Vishwanathapura
Suggested-by: Matthew Brost
---
drivers/gpu/d
ce
Revert "drm/i915: Hold reference to intel_context over life of
i915_request"
Ramalingam C (1):
drm/i915: Do not use reserved requests for virtual engines
drivers/gpu/drm/i915/i915_request.c | 55 ++---
drivers/gpu/drm/i915/i915_request.h | 2 ++
On 2022-05-13 at 14:06:11 -0700, Jordan Justen wrote:
> On 2022-05-13 05:31:00, Lionel Landwerlin wrote:
> > On 02/05/2022 17:15, Ramalingam C wrote:
> > > Capture the impact of memory region preference list of the objects, on
> > > their memory residency and Flat-CCS
Capture the eviction details for Flat-CCS capable, lmem objects.
v2:
Fix the Flat-ccs capbility of lmem obj with smem residency
possibility [Thomas]
v3:
Fixed the suggestions [Matt]
Signed-off-by: Ramalingam C
cc: Thomas Hellstrom
cc: Matthew Auld
Reviewed-by: Matthew Auld
---
drivers
Calculate the ccs_sz that needs to be emitted based on the src
and dst pages emitted per chunk. And handle the return value of emit_pte
for the ccs pages.
v2:
ccs_sz moved to the reduced scope [Matt]
Signed-off-by: Ramalingam C
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/gt
documentation [Matt]
Signed-off-by: Ramalingam C
Reviewed-by: Matthew Auld (v1)
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c
b/drivers/gpu/drm/i915/gt/intel_migrate.c
index
Flat-CCS eviction enhancements
v3:
Incorporated the review suggestions [Matt]
Ramalingam C (3):
drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking
drm/i915/gt: optimize the ccs_sz calculation per chunk
drm/i915/gt: Document the eviction of the Flat-CCS objects
drivers/gpu/drm
Capture the impact of memory region preference list of the objects, on
their memory residency and Flat-CCS capability.
v2:
Fix the Flat-CCS capability of an obj with {lmem, smem} preference
list [Thomas]
v3:
Reworded the doc [Matt]
Signed-off-by: Ramalingam C
cc: Matthew Auld
cc: Thomas
On 2022-05-02 at 16:40:00 +0530, Ramalingam C wrote:
> From: Chris Wilson
>
> Even though the initial protocontext we load onto HW has the register
> cleared, by the time we save it into the default image, BB_OFFSET has
> had the enable bit set. Reclear BB_OFFSET for e
-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c
b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 3271f01fe7db..e4d5d74489bf 100644
emit an invalid zero-length
LRI.
Reported-by: Daniele Ceraolo Spurio
Signed-off-by: Chris Wilson
Cc: Daniele Ceraolo Spurio
Signed-off-by: Ramalingam C
Acked-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++---
1 file changed, 54 insertions(+), 7
POISON_INUSE (0x5a)
so that is both non-zero and distinct from the poison values used during
the test.
v2:
Use i915_gem_object_pin_map_unlocked
Reported-by: CQ Tang
Signed-off-by: Chris Wilson
Cc: CQ Tang
cc: Joonas Lahtinen
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu
:
BB_OFFSET is recorded per engine from Gen9 onwards
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 +
drivers/gpu/drm/i915/gt/intel_lrc.c | 20
drivers/gpu/drm
Few bug fixes for lrc selftest.
v4:
Gen8 don't have per engine recording of BB_OFFSET [Chris]
Chris Wilson (4):
drm/i915/gt: Explicitly clear BB_OFFSET for new contexts
drm/i915/selftests: Check for incomplete LRI from the context image
drm/i915/selftest: Always cancel semaphore on error
POISON_INUSE (0x5a)
so that is both non-zero and distinct from the poison values used during
the test.
v2:
Use i915_gem_object_pin_map_unlocked
Reported-by: CQ Tang
Signed-off-by: Chris Wilson
Cc: CQ Tang
cc: Joonas Lahtinen
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu
-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c
b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 684a63de156a..51e4b7092d4f 100644
emit an invalid zero-length
LRI.
Reported-by: Daniele Ceraolo Spurio
Signed-off-by: Chris Wilson
Cc: Daniele Ceraolo Spurio
Signed-off-by: Ramalingam C
Acked-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++---
1 file changed, 54 insertions(+), 7
-off-by: Chris Wilson
Cc: Mika Kuoppala
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 +
drivers/gpu/drm/i915/gt/intel_lrc.c | 19 +++
drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 +
3 files changed
Few bug fixes for lrc selftest.
v3:
Extending the first patch for gen8
Chris Wilson (4):
drm/i915/gt: Explicitly clear BB_OFFSET for new contexts
drm/i915/selftests: Check for incomplete LRI from the context image
drm/i915/selftest: Always cancel semaphore on error
drm/i915/selftest: Cl
Capture the impact of memory region preference list of an object, on
their memory residency and Flat-CCS capability of the objects.
v2:
Fix the Flat-CCS capability of an obj with {lmem, smem} preference
list [Thomas]
Signed-off-by: Ramalingam C
cc: Matthew Auld
cc: Thomas Hellstrom
Calculate the ccs_sz that needs to be emitted based on the src
and dst pages emitted per chunk. And handle the return value of emit_pte
for the ccs pages.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 36 +
1 file changed, 12 insertions(+), 24
Capture the eviction details for Flat-CCS capable, lmem objects.
v2:
Fix the Flat-ccs capbility of lmem obj with smem residency
possibility [Thomas]
Signed-off-by: Ramalingam C
cc: Thomas Hellstrom
cc: Matthew Auld
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 23
While locating the start of ccs scatterlist in smem scatterlist, that has
to be the size of lmem obj size + corresponding ccs data size. Report bug
if scatterlist terminate before that length.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++
1 file changed, 6
Flat-CCS eviction enhancements
v2: Correcting the memory residency requirement for flat-ccs capability
[Thomas]
Ramalingam C (4):
drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking
drm/i915/gt: optimize the ccs_sz calculation per chunk
drm/i915/gt: Document the eviction of
ned-off-by: Chris Wilson
Cc: Zbigniew Kempczynski
Cc: Thomas Hellstrom
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 54 +
drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 7 ++
drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 +
.../d
quest are
nop'ed. Not only do we then not signal the waiting context, but we even
prevent re-enabling arbitration and the GPU will not perform a context
switch at the end of the request.
Cc: Joonas Lahtinen
Suggested-by: CQ Tang
Signed-off-by: Chris Wilson
Signed-off-by: Ramalingam C
---
d
-off-by: Akeem G Abodunrin
cc: Prathap Kumar Valsan
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 36 +-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c
b/drivers/gpu/drm/i915/gt/selftest_lrc.c
in
Userspace can leave SET_PREDICATE_RESULT active at the end of their
batch, causing all the kernel operations from the ring to be noop'ed.
This includes workarounds for memory corruption on dg2, as well as the
usual synchronisation, arbitration, coherency and signaling. The latter
can be used to cau
POISON_INUSE (0x5a)
so that is both non-zero and distinct from the poison values used during
the test.
v2:
Use i915_gem_object_pin_map_unlocked
Reported-by: CQ Tang
Signed-off-by: Chris Wilson
Cc: CQ Tang
cc: Joonas Lahtinen
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu
-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c
b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 684a63de156a..51e4b7092d4f 100644
emit an invalid zero-length
LRI.
Reported-by: Daniele Ceraolo Spurio
Signed-off-by: Chris Wilson
Cc: Daniele Ceraolo Spurio
Signed-off-by: Ramalingam C
Acked-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++---
1 file changed, 54 insertions(+), 7
: Mika Kuoppala
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 +
drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +
drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 +
3 files changed, 23 insertions(+)
diff --git
Few bug fixes for lrc selftest.
Resending the reviewed patches for CI feedback.
Chris Wilson (4):
drm/i915/gt: Explicitly clear BB_OFFSET for new contexts
drm/i915/selftests: Check for incomplete LRI from the context image
drm/i915/selftest: Always cancel semaphore on error
drm/i915/selft
On 2022-04-21 at 19:07:29 +0530, Hellstrom, Thomas wrote:
> On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote:
> > Capture the eviction details for Flat-CCS capable lmem only objects
> > and
> > lmem objects with smem residency. This also captures the impact of
> > e
On 2022-04-21 at 18:57:59 +0530, Hellstrom, Thomas wrote:
> On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote:
> > While locating the start of ccs scatterlist in smem scatterlist, that
> > has
> > to be the size of lmem obj size + corresponding ccs data size. Report
>
Calculate the ccs_sz that needs to be emitted based on the src
and dst pages emitted per chunk. And handle the return value of emit_pte
for the ccs pages.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 36 +
1 file changed, 12 insertions(+), 24
Capture the eviction details for Flat-CCS capable lmem only objects and
lmem objects with smem residency. This also captures the impact of
eviction on object's memory residency and Flat-CCS compression
state.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c
ression is supported only on objects of
I915_MEMORY_CLASS_DEVICE. When the Flat-CCS compressed objects migrates
out of I915_MEMORY_CLASS_DEVICE, due to memory constrain, content will
be decompressed without notifying the userpsace.
Record these details in Kernel documentation.
Signed-off-by: Ra
Flat-CCS eviction enhancements.
Ramalingam C (4):
drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking
drm/i915/gt: optimize the ccs_sz calculation per chunk
drm/i915/gt: Extend doc on Flat-CCS obj eviction
uapi/drm/i915: Update the placement list impact on obj residency
While locating the start of ccs scatterlist in smem scatterlist, that has
to be the size of lmem obj size + corresponding ccs data size. Report bug
if scatterlist terminate before that length.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++
1 file changed, 6
Flat-CCS eviction enhancements.
Ramalingam C (4):
drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking
drm/i915/gt: optimize the ccs_sz calculation per chunk
drm/i915/gt: Extend doc on Flat-CCS obj eviction
uapi/drm/i915: Update the placement list impact on obj residency
as Hellström
> Cc: Nirmoy Das
> Cc: Ramalingam C
Looks good to me.
Reviewed-by: Ramalingam C
> ---
> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i
good to me.
Reviewed-by: Ramalingam C
> Cc: Thomas Hellström
> Cc: Nirmoy Das
> Cc: Ramalingam C
> ---
> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
On 2022-04-13 at 11:28:28 +0300, Joonas Lahtinen wrote:
> (+ Tvrtko and Jani)
>
> Quoting Ramalingam C (2022-04-02 06:02:38)
> > On 2022-04-01 at 16:31:19 +0200, Christian König wrote:
> > > I would be nicer to push this through drm-misc-next, but the intel branch
&g
Extend the live migrate selftest, to verify the ccs surface clearing
during the Flat-CCS capable lmem obj clear.
v2:
Look at right places for ccs data [Thomas]
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 250
op as main memory [Thomas]
v4: changes for emit_copy_ccs
v5: handle non-flat-ccs scenario
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++-
1 file changed, 160 insertions(+), 4 deletions(-)
diff --git a/drivers/gp
when obj's placement is lmem only
v4:
GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas]
Signed-off-by: Ramalingam C
cc: Christian Koenig
cc: Hellstrom Thomas
Reviewed-by: Thomas Hellstrom
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem
Consider the possible round up happened at obj size alignment to
min_page_size during the obj allocation.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt
]
only one ctrl surf cmd is used as size of lmem is <=8M [Thomas]
Signed-off-by: Ramalingam C
Signed-off-by: Ayaz A Siddiqui
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-
-off-by: Ramalingam C
Signed-off-by: Chris Wilson
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +---
2 files changed, 43 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915
When emit_pte doesn't update any PTE with return value as 0, interpret
it as -EINVAL.
v2:
Add missing goto [Thomas]
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i9
Move the static calculations out of the loops for copy and clear.
v2:
Fix the loss of proper error code on emit_pte
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom (v1)
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 34 -
1 file changed, 17 insertions(+), 17
To make it uniform across copy and clear, use the engine offset directly
to calculate the offset in the cmd forming for emit_clear.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 11 ---
1 file changed, 4 insertions(+), 7
ta is done through a special cmd called
XY_CTRL_SURF_COPY_BLT
v8 and v9:
New patch for return value fix
Fix a return error code
Test-with: 20220405141050.16037-1-ramalinga...@intel.com
Ramalingam C (9):
drm/i915/gt: use engine instance directly for offset
drm/i915/gt: Use XY_FAST_COLOR_B
Consider the possible round up happened at obj size alignment to
min_page_size during the obj allocation.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt
op as main memory [Thomas]
v4: changes for emit_copy_ccs
v5: handle non-flat-ccs scenario
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++-
1 file changed, 160 insertions(+), 4 deletions(-)
diff --git a/drivers/gp
when obj's placement is lmem only
v4:
GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas]
Signed-off-by: Ramalingam C
cc: Christian Koenig
cc: Hellstrom Thomas
Reviewed-by: Thomas Hellstrom
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem
Extend the live migrate selftest, to verify the ccs surface clearing
during the Flat-CCS capable lmem obj clear.
v2:
Look at right places for ccs data [Thomas]
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 250
When emit_pte doesn't update any PTE with return value as 0, interpret
it as -EINVAL.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c
b/drivers/gpu/drm/i9
]
only one ctrl surf cmd is used as size of lmem is <=8M [Thomas]
Signed-off-by: Ramalingam C
Signed-off-by: Ayaz A Siddiqui
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-
Move the static calculations out of the loops for copy and clear.
v2:
Fix the loss of proper error code on emit_pte
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom (v1)
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 34 -
1 file changed, 17 insertions(+), 17
To make it uniform across copy and clear, use the engine offset directly
to calculate the offset in the cmd forming for emit_clear.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 11 ---
1 file changed, 4 insertions(+), 7
-off-by: Ramalingam C
Signed-off-by: Chris Wilson
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +---
2 files changed, 43 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915
ta is done through a special cmd called
XY_CTRL_SURF_COPY_BLT
v8:
New patch for return value fix
Fix a return error code
Test-with: 20220405141050.16037-1-ramalinga...@intel.com
Ramalingam C (9):
drm/i915/gt: use engine instance directly for offset
drm/i915/gt: Use XY_FAST_COLOR_BLT to
On 2022-03-29 at 18:53:42 +0530, Balasubramani Vivekanandan wrote:
> On 29.03.2022 00:37, Ramalingam C wrote:
> > Move the static calculations out of the loops for copy and clear.
> >
> > Signed-off-by: Ramalingam C
> > Reviewed-by: Thomas Hellström
> >
4.22 um 16:28 schrieb Ramalingam C:
> > Christian, Joonas and vivi
> >
> > Once the premerge results are greeen, if this patch can be merged into
> > drm-intel-gt-next along with other patches could you please ack the
> > request to merge into drm-intel-gt-next?
> >
&g
Christian, Joonas and vivi
Once the premerge results are greeen, if this patch can be merged into
drm-intel-gt-next along with other patches could you please ack the
request to merge into drm-intel-gt-next?
Thanks
Ram
On 2022-04-01 at 18:07:49 +0530, Ramalingam C wrote:
> Add a parameter cal
op as main memory [Thomas]
v4: changes for emit_copy_ccs
v5: handle non-flat-ccs scenario
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++-
1 file changed, 160 insertions(+), 4 deletions(-)
diff --git a/drivers/gp
when obj's placement is lmem only
v4:
GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas]
Signed-off-by: Ramalingam C
cc: Christian Koenig
cc: Hellstrom Thomas
Reviewed-by: Thomas Hellstrom
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that
driver needs extra pages in ttm_tt.
v2:
Used imperative wording [Thomas and Christian]
Signed-off-by: Ramalingam C
cc: Christian Koenig
cc: Hellstrom Thomas
Reviewed-by: Thomas Hellstrom
Reviewed-by: Chris
Extend the live migrate selftest, to verify the ccs surface clearing
during the Flat-CCS capable lmem obj clear.
v2:
Look at right places for ccs data [Thomas]
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 250
Consider the possible round up happened at obj size alignment to
min_page_size during the obj allocation.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt
]
only one ctrl surf cmd is used as size of lmem is <=8M [Thomas]
Signed-off-by: Ramalingam C
Signed-off-by: Ayaz A Siddiqui
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-
Move the static calculations out of the loops for copy and clear.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 40 -
1 file changed, 19 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt
-off-by: Ramalingam C
Signed-off-by: Chris Wilson
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +---
2 files changed, 43 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915
To make it uniform across copy and clear, use the engine offset directly
to calculate the offset in the cmd forming for emit_clear.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 11 ---
1 file changed, 4 insertions(+), 7
forms
Resending with updated igt version for test with.
Test-with: 20220401074527.15709-2-ramalinga...@intel.com
Ramalingam C (9):
drm/i915/gt: use engine instance directly for offset
drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+
drm/i915/gt: Optimize the migration and clear
Move the static calculations out of the loops for copy and clear.
Signed-off-by: Ramalingam C
Reviewed-by: Thomas Hellström
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 44 -
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt
op as main memory [Thomas]
v4: changes for emit_copy_ccs
v5: handle non-flat-ccs scenario
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++-
1 file changed, 160 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that
driver needs extra pages in ttm_tt.
v2:
Used imperative wording [Thomas and Christian]
Signed-off-by: Ramalingam C
cc: Christian Koenig
cc: Hellstrom Thomas
Reviewed-by: Thomas Hellstrom
Reviewed-by: Chris
when obj's placement is lmem only
v4:
GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas]
Signed-off-by: Ramalingam C
cc: Christian Koenig
cc: Hellstrom Thomas
Reviewed-by: Thomas Hellstrom
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem
Extend the live migrate selftest, to verify the ccs surface clearing
during the Flat-CCS capable lmem obj clear.
v2:
Look at right places for ccs data [Thomas]
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 250 ++---
1 file changed, 222
Consider the possible round up happened at obj size alignment to
min_page_size during the obj allocation.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c
b/drivers/gpu
]
only one ctrl surf cmd is used as size of lmem is <=8M [Thomas]
Signed-off-by: Ramalingam C
Signed-off-by: Ayaz A Siddiqui
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-
2 files changed, 152 inserti
To make it uniform across copy and clear, use the engine offset directly
to calculate the offset in the cmd forming for emit_clear.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu
-off-by: Ramalingam C
Signed-off-by: Chris Wilson
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +---
2 files changed, 43 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915
Test-with: 20220314051432.15785-1-ramalinga...@intel.com
Ramalingam C (9):
drm/i915/gt: use engine instance directly for offset
drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+
drm/i915/gt: Optimize the migration and clear loop
drm/i915/gt: Clear compress metadata for Fla
On 2022-03-24 at 17:14:53 +0100, Thomas Hellström (Intel) wrote:
> Hi, Ram
>
> On 3/21/22 23:44, Ramalingam C wrote:
> > Xe-HP and latest devices support Flat CCS which reserved a portion of
> > the device memory to store compression metadata, during the clearing of
>
On 2022-03-24 at 17:28:08 +0100, Thomas Hellström wrote:
>
> On 3/21/22 23:44, Ramalingam C wrote:
> > On Xe-HP and later devices, dedicated compression control state (CCS)
> > stored in local memory is used for each surface, to support the
> > 3D and media compressi
On 2022-03-24 at 17:20:28 +0100, Thomas Hellström (Intel) wrote:
>
> On 3/21/22 23:44, Ramalingam C wrote:
> > Handle the src and dst chunk offsets for different instances of the copy
> > engines.
> >
> > Signed-off-by: Ramalingam C
> > ---
> > d
1 - 100 of 1001 matches
Mail list logo
