Re: [Y2038] [PATCH v2 13/24] drm/etnaviv: reject timeouts with tv_nsec >= NSEC_PER_SEC

2020-01-08 Thread Ben Hutchings
t; NSEC_PER_SEC) [...] There's an off-by-one error between the subject line and the actual changes. The subject line seems to have the correct comparison. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Da

[PATCH 3.16 053/132] PCI: Reset Lenovo ThinkPad P50 nvgpu at boot if necessary

2019-09-20 Thread Ben Hutchings
Signed-off-by: Lyude Paul Signed-off-by: Bjorn Helgaas Cc: nouv...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: Karol Herbst Cc: Ben Skeggs [bwh: Backported to 3.16: - Use dev_{err,info}() instead of pci_{err,info}() - Adjust context] Signed-off-by: Ben

[PATCH 5/5] drm: EDID: Add a 1280x768 ("WXGA") EDID

2018-11-14 Thread Ben Hutchings
This is one of several modes sometimes called WXGA. Signed-off-by: Ben Hutchings --- Documentation/EDID/1280x768.S | 45 +++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/EDID/1280x768.S diff --git a/Documentation/EDID/1280x768.S b

[PATCH 1/5] drm: EDID: Remove a mess involving the number 63

2018-11-14 Thread Ben Hutchings
e additions and subtractions and fix the comment. Signed-off-by: Ben Hutchings --- Documentation/EDID/1024x768.S | 4 ++-- Documentation/EDID/1280x1024.S | 4 ++-- Documentation/EDID/1600x1200.S | 4 ++-- Documentation/EDID/1680x1050.S | 4 ++-- Documentation/EDID/1920x1080.S | 4 ++-- Documentation

[PATCH 3/5] drm: EDID: Don't force make to be silent

2018-11-14 Thread Ben Hutchings
Hiding all commands is unhelpful unless there's some way to override it (e.g. Kbuild's V=1). The -s option is available for those who like it. Signed-off-by: Ben Hutchings --- Documentation/EDID/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

[PATCH 2/5] drm: EDID: Fix bit masking of {X,Y}{OFFSET,PULSE}

2018-11-14 Thread Ben Hutchings
. Signed-off-by: Ben Hutchings --- Documentation/EDID/edid.S | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/EDID/edid.S b/Documentation/EDID/edid.S index ce4b8b4a20b2..8abbf6c24d88 100644 --- a/Documentation/EDID/edid.S +++ b/Documentation/EDID/edid.S @@ -48,8

[PATCH 4/5] drm: EDID: Add a 1280x720 (720p) EDID

2018-11-14 Thread Ben Hutchings
This should match standard HDTV 720p 60 Hz timings. Signed-off-by: Ben Hutchings --- Documentation/EDID/1280x720.S | 45 +++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/EDID/1280x720.S diff --git a/Documentation/EDID/1280x720.S b

[PATCH 0/5] Fixes and additions to EDID generation

2018-11-14 Thread Ben Hutchings
D/1280x720.S create mode 100644 Documentation/EDID/1280x768.S -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1

[PATCH] drm/msm: Fix possible null dereference on failure of get_pages()

2018-04-04 Thread Ben Hutchings
("drm/msm: fix leak in failed get_pages") Signed-off-by: Ben Hutchings --- drivers/gpu/drm/msm/msm_gem.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 07376de9ff4c..37ec3411297b

[PATCH 3.16 013/136] drm/i915: Read timings from the correct transcoder in intel_crtc_mode_get()

2018-02-10 Thread Ben Hutchings
Wilson Link: https://patchwork.freedesktop.org/patch/msgid/1459525046-19425-1-git-send-email-ville.syrj...@linux.intel.com [bwh: Backported to 3.16: pipe_config is a struct not a pointer] Signed-off-by: Ben Hutchings --- drivers/gpu/drm/i915/intel_display.c | 14 +- 1 file changed, 9

Re: [PATCH] drm/msm: update adreno firmware path in MODULE_FIRMWARE

2017-11-23 Thread Ben Hutchings
der, > > > especially now that we are adding some of them in linux-firmware. > > > > > > Reported-by: Ben Hutchings > > > Signed-off-by: Nicolas Dechesne > > > > Thanks, I was wondering if we should perhaps list both old and new > > paths?

Re: [PATCH 4.4 23/31] drm/bridge: adv7511: Use work_struct to defer hotplug handing to out of irq context

2017-10-15 Thread Ben Hutchings
rom > the HPD signal. > > Thus this patch changes the logic to handle the HPD signal > via a work_struct so we can be out of irq context. [...] Shouldn't there also be a cancel_work_sync() in the remove function? Ben. -- Ben Hutchings Software Developer, Codethink Ltd. ___

Bug#768157: machine hangs when loading cirrus with modeset=1 while booted with vga=791

2014-11-05 Thread Ben Hutchings
tal error during GPU init: -6 and I can log in there. But, as the driver detects this error after the point of no return (remove_conflicting_framebuffers()), the display remains broken. Ben. -- Ben Hutchings The program is absolutely right; therefore, the computer must be wrong. --

Bug#765415: linux-image-3.17-rc5-amd64: mgag200drmfb driver fails on Supermicro X8DAH system

2014-10-15 Thread Ben Hutchings
, non-prefetchable) [size=8M] > Expansion ROM at [disabled] > Capabilities: [dc] Power Management version 1 > Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA > PME(D0-,D1-,D2-,D3hot-,D3cold-) > Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-

[PATCH] drm/radeon/pm: don't allow debugfs/sysfs access when PX card is off (v2)

2014-05-21 Thread Ben Hutchings
gt;asic->pm.get_temperature) > temp = radeon_get_temperature(rdev); > else > @@ -1614,8 +1650,12 @@ static int radeon_debugfs_pm_info(struct seq_file *m, > void *data) > struct drm_info_node *node = (struct drm_info_node *) m->private; > struct d

Add radeon firmware for hawaii gpus

2014-01-19 Thread Ben Hutchings
n > create mode 100644 radeon/HAWAII_rlc.bin > create mode 100644 radeon/HAWAII_sdma.bin > create mode 100644 radeon/HAWAII_smc.bin [...] Applied, thanks. Ben. -- Ben Hutchings friends: People who know you well, but like you anyway. -- next part -- A non-t

[PATCH 3.2 74/87] drm: Prevent overwriting from userspace underallocating core ioctl structs

2013-11-25 Thread Ben Hutchings
ilson Cc: Dave Airlie Reviewed-by: Ville Syrj?l? Cc: dri-devel at lists.freedesktop.org Signed-off-by: Dave Airlie Signed-off-by: Ben Hutchings --- drivers/gpu/drm/drm_drv.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_

[PATCH 3.2 75/87] drm: Pad drm_mode_get_connector to 64-bit boundary

2013-11-25 Thread Ben Hutchings
Roskin Signed-off-by: Chris Wilson Cc: Dave Airlie Cc: dri-devel at lists.freedesktop.org Signed-off-by: Dave Airlie [bwh: Backported to 3.2: adjust filename] Signed-off-by: Ben Hutchings --- include/uapi/drm/drm_mode.h | 2 ++ 1 file changed, 2 insertions(+) --- a/include/drm/drm_mode.h +++ b

[PATCH 4/8] drm: Pass pointers to virt_to_page()

2013-10-27 Thread Ben Hutchings
id *)dma->pagelist[page_nr]); get_page(page); vmf->page = page; -- Ben Hutchings If at first you don't succeed, you're doing about average. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-sig

[PATCH 3/8] drm: Do not include page offset in argument to virt_to_page()

2013-10-27 Thread Ben Hutchings
By definition, the page offset will not affect the result. Compile-tested only. Signed-off-by: Ben Hutchings --- drivers/gpu/drm/drm_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c index b5c5af7..8ef6503 100644 --- a

[PATCH 0/8] Fix minor address type errors

2013-10-27 Thread Ben Hutchings
Various bits of code are mixing making assumptions about the size of dma_addr_t or resource_size_t, or mixing up pointer and integer types. All these fixes are based on compiler warnings and so far as I can see the bugs are practically harmless. Ben. Ben Hutchings (8): IB/cxgb4: Fix

[PATCH] drm: Pad drm_mode_get_connector to 64-bit boundary

2013-10-17 Thread Ben Hutchings
connector { > > __u32 connection; > > __u32 mm_width, mm_height; /**< HxW in millimeters */ > > __u32 subpixel; > > + > > + __u32 pad; > > }; > > > > #define DRM_MODE_PROP_PENDING (1<<0) > > -- > > 1.8.4.rc3 >

Re: New radeon ucode

2013-09-29 Thread Ben Hutchings
On Wed, 2013-09-18 at 16:33 -0400, Alex Deucher wrote: > On Wed, Sep 18, 2013 at 4:32 PM, Alex Deucher wrote: > > Hi Ben, > > > > The attached patches add new firmware for radeon GPUs. Please apply > > to the firmware tree. > > Attached this time... Applied,

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-20 Thread Ben Hutchings
f. I would suggest: "The coherent mask can always be set to the same or a smaller mask than the streaming mask." Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare

radeon ucode updates

2013-05-27 Thread Ben Hutchings
On Wed, 2013-05-15 at 15:28 -0400, Alex Deucher wrote: > Hi Ben, > > The attached patch adds the new radeon ucode required for the new > hainan asic. Please apply to the firmware tree. Applied, thanks. Ben. -- Ben Hutchings Experience is what causes a person to make new mistake

Re: radeon ucode updates

2013-05-27 Thread Ben Hutchings
On Wed, 2013-05-15 at 15:28 -0400, Alex Deucher wrote: > Hi Ben, > > The attached patch adds the new radeon ucode required for the new > hainan asic. Please apply to the firmware tree. Applied, thanks. Ben. -- Ben Hutchings Experience is what causes a person to make new mistake

radeon ucode updates

2013-04-21 Thread Ben Hutchings
On Fri, 2013-04-12 at 11:26 -0400, Alex Deucher wrote: > Hi Ben, > > Attached are patches for the Linux firmware tree to update to the > latest ucode for UVD support and adds support for the new Oland GPUs. > > Thanks! Applied, thanks. Ben. -- Ben Hutchings All extremis

Re: radeon ucode updates

2013-04-21 Thread Ben Hutchings
On Fri, 2013-04-12 at 11:26 -0400, Alex Deucher wrote: > Hi Ben, > > Attached are patches for the Linux firmware tree to update to the > latest ucode for UVD support and adds support for the new Oland GPUs. > > Thanks! Applied, thanks. Ben. -- Ben Hutchings All extremis

[PATCH] nouveau: ACPI support depends on X86 and X86_PLATFORM_DEVICES

2013-02-20 Thread Ben Hutchings
mp; ACPI_WMI) Make all the ACPI support depend on X86 and select X86_PLATFORM_DEVICES. Signed-off-by: Ben Hutchings --- Debian has had this patch (or earlier versions of it) for the last 20 months. I submitted it previously but didn't receive any response. Please apply or explain what's

[PATCH] nouveau: ACPI support depends on X86 and X86_PLATFORM_DEVICES

2013-02-19 Thread Ben Hutchings
mp; ACPI_WMI) Make all the ACPI support depend on X86 and select X86_PLATFORM_DEVICES. Signed-off-by: Ben Hutchings --- Debian has had this patch (or earlier versions of it) for the last 20 months. I submitted it previously but didn't receive any response. Please apply or explain what's

[PATCH 3.0.y] drm/i915: Implement WaDisableHiZPlanesWhenMSAAEnabled

2013-02-01 Thread Ben Hutchings
eeds to be set always to "1", Project: DevSNB > > Reviewed-by: Rodrigo Vivi > Signed-off-by: Daniel Vetter > Signed-off-by: Abdallah Chatila [...] Also queued up for 3.2, thanks. Ben. -- Ben Hutchings Everything shou

Re: [PATCH 3.0.y] drm/i915: Implement WaDisableHiZPlanesWhenMSAAEnabled

2013-02-01 Thread Ben Hutchings
eeds to be set always to "1", Project: DevSNB > > Reviewed-by: Rodrigo Vivi > Signed-off-by: Daniel Vetter > Signed-off-by: Abdallah Chatila [...] Also queued up for 3.2, thanks. Ben. -- Ben Hutchings Everything shou

[PATCH] drm/radeon: fix typo in evergreen_mc_resume()

2012-11-11 Thread Ben Hutchings
://bugs.freedesktop.org/show_bug.cgi?id=56139 > > > > Signed-off-by: Alex Deucher > > Cc: stable at vger.kernel.org > > Looks like the stable cc got dropped when this patch got pulled. The > original patch was backported to older kernels. [...] Queued up for 3.2, thanks. B

Re: [PATCH] drm/radeon: fix typo in evergreen_mc_resume()

2012-11-11 Thread Ben Hutchings
://bugs.freedesktop.org/show_bug.cgi?id=56139 > > > > Signed-off-by: Alex Deucher > > Cc: sta...@vger.kernel.org > > Looks like the stable cc got dropped when this patch got pulled. The > original patch was backported to older kernels. [...] Queued up for 3.2, thanks. Ben.

[3.0.y, 3.2.y, 3.4.y] Please add LVDS patch for the Zotac ZBOX SD ID13

2012-10-28 Thread Ben Hutchings
6 merge window, so newer kernels don't need it. [...] Added to the queue for 3.2, thanks. Ben. -- Ben Hutchings Reality is just a crutch for people who can't handle science fiction. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: a

Re: [3.0.y, 3.2.y, 3.4.y] Please add LVDS patch for the Zotac ZBOX SD ID13

2012-10-27 Thread Ben Hutchings
6 merge window, so newer kernels don't need it. [...] Added to the queue for 3.2, thanks. Ben. -- Ben Hutchings Reality is just a crutch for people who can't handle science fiction. signature.asc Description: This is a digitally signed message part

[3.2.y] drm/i915: add Ivy Bridge GT2 Server entries

2012-10-07 Thread Ben Hutchings
On Sun, 2012-10-07 at 15:11 +0100, Chris Wilson wrote: > On Sun, 07 Oct 2012 15:01:17 +0100, Ben Hutchings > wrote: > > On Mon, 2012-10-01 at 03:24 -0700, Jonathan Nieder wrote: > > > Hi Ben, > > > > > > Please consider > > > > > >

[3.2.y] drm/i915: add Ivy Bridge GT2 Server entries

2012-10-07 Thread Ben Hutchings
.] > - with this patch, and with libdrm lacking 2.4.34~22 and 2.4.38~10, >X freezes at startup. > > "No regressions" means you probably shouldn't take this patch without > a safety to work around the old X userspace, [...] Then this workaround is also required in m

Re: [3.2.y] drm/i915: add Ivy Bridge GT2 Server entries

2012-10-07 Thread Ben Hutchings
On Sun, 2012-10-07 at 15:11 +0100, Chris Wilson wrote: > On Sun, 07 Oct 2012 15:01:17 +0100, Ben Hutchings > wrote: > > On Mon, 2012-10-01 at 03:24 -0700, Jonathan Nieder wrote: > > > Hi Ben, > > > > > > Please consider > > > > > >

Re: [3.2.y] drm/i915: add Ivy Bridge GT2 Server entries

2012-10-07 Thread Ben Hutchings
.] > - with this patch, and with libdrm lacking 2.4.34~22 and 2.4.38~10, >X freezes at startup. > > "No regressions" means you probably shouldn't take this patch without > a safety to work around the old X userspace, [...] Then this workaround is also required in m

[ 027/135] drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for ASUS VW222S

2012-09-17 Thread Ben Hutchings
=bc42aabc6a01b92b0f961d65671564e0e1cd7592 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17629 Signed-off-by: Paul Menzel Cc: Cc: Adam Jackson Cc: Ian Pilcher Signed-off-by: Dave Airlie Signed-off-by: Ben Hutchings --- drivers/gpu/drm/drm_edid.c |3 +++ 1 file changed, 3 insertions

[ 027/135] drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for ASUS VW222S

2012-09-16 Thread Ben Hutchings
=bc42aabc6a01b92b0f961d65671564e0e1cd7592 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17629 Signed-off-by: Paul Menzel Cc: Cc: Adam Jackson Cc: Ian Pilcher Signed-off-by: Dave Airlie Signed-off-by: Ben Hutchings --- drivers/gpu/drm/drm_edid.c |3 +++ 1 file changed, 3 insertions

[PATCH 4/8] drm: Pass pointers to virt_to_page()

2011-12-21 Thread Ben Hutchings
Most architectures define virt_to_page() as a macro that casts its argument such that an argument of type unsigned long will be accepted without complaint. However, the proper type is void *, and passing unsigned long results in a warning on MIPS. Signed-off-by: Ben Hutchings --- drivers/gpu

[PATCH 3/8] drm: Do not include page offset in argument to virt_to_page()

2011-12-21 Thread Ben Hutchings
By definition, the page offset will not affect the result. Compile-tested only. Signed-off-by: Ben Hutchings --- drivers/gpu/drm/drm_vm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c index 8c03eaf..98c3922 100644

[PATCH 0/8] Fix virtual and physical address types

2011-12-21 Thread Ben Hutchings
This series fixes compiler warnings on some architectures about implicit conversions and narrowing conversions between pointer and integer types. Please apply these to the appropriate trees. Ben. Ben Hutchings (8): IB/cxgb4: Fix formatting of physical address farsync: Fix confusion about

high_memory address in /proc/dri/*/vma

2011-12-20 Thread Ben Hutchings
On Tue, Dec 20, 2011 at 05:32:13PM +0100, Daniel Vetter wrote: > On Tue, Dec 20, 2011 at 12:09:39AM +0000, Ben Hutchings wrote: > > [Re-sent to the right address, I hope.] > > > > Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not > > leak kern

[PATCH 4/8] drm: Pass pointers to virt_to_page()

2011-12-20 Thread Ben Hutchings
Most architectures define virt_to_page() as a macro that casts its argument such that an argument of type unsigned long will be accepted without complaint. However, the proper type is void *, and passing unsigned long results in a warning on MIPS. Signed-off-by: Ben Hutchings --- drivers/gpu

[PATCH 3/8] drm: Do not include page offset in argument to virt_to_page()

2011-12-20 Thread Ben Hutchings
By definition, the page offset will not affect the result. Compile-tested only. Signed-off-by: Ben Hutchings --- drivers/gpu/drm/drm_vm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c index 8c03eaf..98c3922 100644

[PATCH 0/8] Fix virtual and physical address types

2011-12-20 Thread Ben Hutchings
This series fixes compiler warnings on some architectures about implicit conversions and narrowing conversions between pointer and integer types. Please apply these to the appropriate trees. Ben. Ben Hutchings (8): IB/cxgb4: Fix formatting of physical address farsync: Fix confusion about

Re: high_memory address in /proc/dri/*/vma

2011-12-20 Thread Ben Hutchings
On Tue, Dec 20, 2011 at 05:32:13PM +0100, Daniel Vetter wrote: > On Tue, Dec 20, 2011 at 12:09:39AM +0000, Ben Hutchings wrote: > > [Re-sent to the right address, I hope.] > > > > Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not > > leak kern

high_memory address in /proc/dri/*/vma

2011-12-20 Thread Ben Hutchings
On Mon, 2011-12-19 at 18:35 -0800, Kees Cook wrote: > On Mon, Dec 19, 2011 at 6:18 PM, Ben Hutchings wrote: > > On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote: > >> On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings > >> wrote: > >> > Kees, in commit 0

high_memory address in /proc/dri/*/vma

2011-12-20 Thread Ben Hutchings
On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote: > On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings wrote: > > Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not > > leak kernel addresses via /proc/dri/*/vma") you changed the l

high_memory address in /proc/dri/*/vma

2011-12-20 Thread Ben Hutchings
the physical address may be truncated (in theory at least). I think it would make more sense to make this entire file readable by root only, but I don't know whether anything depends on being able to read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that is always true at the

Re: high_memory address in /proc/dri/*/vma

2011-12-19 Thread Ben Hutchings
On Mon, 2011-12-19 at 18:35 -0800, Kees Cook wrote: > On Mon, Dec 19, 2011 at 6:18 PM, Ben Hutchings wrote: > > On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote: > >> On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings > >> wrote: > >> > Kees, in commit 0

Re: high_memory address in /proc/dri/*/vma

2011-12-19 Thread Ben Hutchings
On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote: > On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings wrote: > > Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not > > leak kernel addresses via /proc/dri/*/vma") you changed the l

high_memory address in /proc/dri/*/vma

2011-12-19 Thread Ben Hutchings
the physical address may be truncated (in theory at least). I think it would make more sense to make this entire file readable by root only, but I don't know whether anything depends on being able to read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that is always true at the

high_memory address in /proc/dri/*/vma

2011-12-19 Thread Ben Hutchings
n theory at least). I think it would make more sense to make this entire file readable by root only, but I don't know whether anything depends on being able to read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that is always true at the moment. Ben. -- Ben Hutchings Humans

high_memory address in /proc/dri/*/vma

2011-12-18 Thread Ben Hutchings
n theory at least). I think it would make more sense to make this entire file readable by root only, but I don't know whether anything depends on being able to read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that is always true at the moment. Ben. -- Ben Hutchings Humans

Bug#649448: udev loading radeon drivers garbles screen output

2011-11-21 Thread Ben Hutchings
rm/radeon/kms: Add support for interrupts on r6xx/r7xx chips (v3) And the 'Northern Islands' GPUs and 'Fusion' APUs appear to require the 'MC' firmware blobs: commit 0af62b0168043896a042b005ff88caa77dd94d04 Author: Alex Deucher Date: Thu Jan 6 21:19:31 2011 -0500

Re: Bug#649448: udev loading radeon drivers garbles screen output

2011-11-20 Thread Ben Hutchings
rm/radeon/kms: Add support for interrupts on r6xx/r7xx chips (v3) And the 'Northern Islands' GPUs and 'Fusion' APUs appear to require the 'MC' firmware blobs: commit 0af62b0168043896a042b005ff88caa77dd94d04 Author: Alex Deucher Date: Thu Jan 6 21:19:31 2011 -0500

[PATCH/RFC] m68k/bitops: Make bitmap data pointer of atomic ops volatile

2011-06-07 Thread Ben Hutchings
7;t really hurt in this case. These operations are required to be atomic and therefore they must be suitable for use with volatile-qualified variables. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus

Re: [PATCH/RFC] m68k/bitops: Make bitmap data pointer of atomic ops volatile

2011-06-07 Thread Ben Hutchings
;t really hurt in this case. These operations are required to be atomic and therefore they must be suitable for use with volatile-qualified variables. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking.

[PATCH] nouveau: ACPI support is dependent on X86

2011-06-06 Thread Ben Hutchings
The ACPI support code probably wasn't very useful on ia64, and now depends on mxm-wmi which is definitely x86-only. Compile-tested on ia64 and i386. Signed-off-by: Ben Hutchings --- drivers/gpu/drm/nouveau/Kconfig |4 ++-- drivers/gpu/drm/nouveau/Makefile |2 ++ driver

[PATCH] nouveau: ACPI support is dependent on X86

2011-06-05 Thread Ben Hutchings
The ACPI support code probably wasn't very useful on ia64, and now depends on mxm-wmi which is definitely x86-only. Compile-tested on ia64 and i386. Signed-off-by: Ben Hutchings --- drivers/gpu/drm/nouveau/Kconfig |4 ++-- drivers/gpu/drm/nouveau/Makefile |2 ++ driver

[PATCH 1/2] i915: Remove pipe A force quirk for 855GM and 845G

2011-03-22 Thread Ben Hutchings
On Mon, 2011-03-21 at 07:38 +, Chris Wilson wrote: > On Sun, 20 Mar 2011 23:07:04 +0000, Ben Hutchings > wrote: > > Applying this quirk to the 855GM in all systems causes regressions > > (Debian bugs #493096, #619019). Instead, apply the quirk to specific > > model

Re: [PATCH 1/2] i915: Remove pipe A force quirk for 855GM and 845G

2011-03-21 Thread Ben Hutchings
On Mon, 2011-03-21 at 07:38 +, Chris Wilson wrote: > On Sun, 20 Mar 2011 23:07:04 +0000, Ben Hutchings > wrote: > > Applying this quirk to the 855GM in all systems causes regressions > > (Debian bugs #493096, #619019). Instead, apply the quirk to specific > > model

[PATCH 2/2] i915: Apply the 'pipe A force' quirk to some more models

2011-03-20 Thread Ben Hutchings
Add some more IDs as listed in the old X driver. Signed-off-by: Ben Hutchings --- Is there some reason these were omitted from the kernel driver? If not, it seems sensible to include them. Ben. drivers/gpu/drm/i915/intel_display.c |8 1 files changed, 8 insertions(+), 0 deletions

[PATCH 1/2] i915: Remove 'pipe A force' quirk for 855GM and 845G

2011-03-20 Thread Ben Hutchings
ng if pipe A was turned off. However, that seems to be a problem only when using UMS. So remove the quirk for the 845G as well. Signed-off-by: Ben Hutchings --- Needs people to test it, as I can't. Ben. drivers/gpu/drm/i915/intel_display.c | 23 +++ 1 files changed, 19

[PATCH 1/2] i915: Remove 'pipe A force' quirk for 855GM and 845G

2011-03-20 Thread Ben Hutchings
ng if pipe A was turned off. However, that seems to be a problem only when using UMS. So remove the quirk for the 845G as well. Signed-off-by: Ben Hutchings --- Needs people to test it, as I can't. Ben. drivers/gpu/drm/i915/intel_display.c | 23 +++ 1 files changed, 19

[PATCH 2/2] i915: Apply the 'pipe A force' quirk to some more models

2011-03-20 Thread Ben Hutchings
Add some more IDs as listed in the old X driver. Signed-off-by: Ben Hutchings --- Is there some reason these were omitted from the kernel driver? If not, it seems sensible to include them. Ben. drivers/gpu/drm/i915/intel_display.c |8 1 files changed, 8 insertions(+), 0 deletions

[PATCH v2] drm/nouveau: Only select ACPI_VIDEO if its dependencies are met

2010-12-27 Thread Ben Hutchings
CONFIG_ACPI_VIDEO depends on more than just CONFIG_ACPI, so add those dependencies to the Kconfig select condition and make the code conditional on CONFIG_ACPI_VIDEO. Signed-off-by: Ben Hutchings --- On Sat, 2010-12-25 at 16:21 +0100, Francisco Jerez wrote: [...] > > --- a/drivers/g

[PATCH v2] drm/nouveau: Only select ACPI_VIDEO if its dependencies are met

2010-12-25 Thread Ben Hutchings
CONFIG_ACPI_VIDEO depends on more than just CONFIG_ACPI, so add those dependencies to the Kconfig select condition and make the code conditional on CONFIG_ACPI_VIDEO. Signed-off-by: Ben Hutchings --- On Sat, 2010-12-25 at 16:21 +0100, Francisco Jerez wrote: [...] > > --- a/drivers/g

[PATCH] drm/nouveau: Only select ACPI_VIDEO if its dependencies are met

2010-12-12 Thread Ben Hutchings
CONFIG_ACPI_VIDEO depends on more than just CONFIG_ACPI, so add those dependencies to the Kconfig select condition and make the code conditional on CONFIG_ACPI_VIDEO. Fixes building for ia64 (ACPI && !X86). Signed-off-by: Ben Hutchings --- Please send this up to Linus for 2.6.

[PATCH] drm/nouveau: Only select ACPI_VIDEO if its dependencies are met

2010-12-11 Thread Ben Hutchings
CONFIG_ACPI_VIDEO depends on more than just CONFIG_ACPI, so add those dependencies to the Kconfig select condition and make the code conditional on CONFIG_ACPI_VIDEO. Fixes building for ia64 (ACPI && !X86). Signed-off-by: Ben Hutchings --- Please send this up to Linus for 2.6.

Re: [PATCH] i915, drm: Fix build dependency on VGA_ARB

2010-08-26 Thread Ben Hutchings
ILLRECT > > I reported this build failure here: > > http://lkml.org/lkml/2010/8/23/127 > > Is there no other way to fix this? From the Kconfig description > of VGA_ARB I thought I would not need this (and it's a new thing too), > so why make my kernel bigg

[PATCH] i915, drm: Fix build dependency on VGA_ARB

2010-08-26 Thread Ben Hutchings
ILLRECT > > I reported this build failure here: > > http://lkml.org/lkml/2010/8/23/127 > > Is there no other way to fix this? From the Kconfig description > of VGA_ARB I thought I would not need this (and it's a new thing too), > so why make my kernel bigg

DRM stable updates beyond 2.6.33.6

2010-08-08 Thread Ben Hutchings
n * default setup @@ -172,7 +173,6 @@ static int rs690_mc_init(struct radeon_device *rdev) rdev->mc.vram_location = G_000100_MC_FB_START(tmp) << 16; rdev->mc.gtt_location = 0xUL; r = radeon_mc_setup(rdev); - rdev->mc.igp_sideport_enabled = rad

DRM stable updates beyond 2.6.33.6

2010-08-08 Thread Ben Hutchings
. Do you have any suggestions for how we should to this? Could you maintain a drm-2.6.33 branch? Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. -- next part -- A non-text attachment was scrubbed... Name: not available Type

Re: DRM stable updates beyond 2.6.33.6

2010-08-08 Thread Ben Hutchings
n * default setup @@ -172,7 +173,6 @@ static int rs690_mc_init(struct radeon_device *rdev) rdev->mc.vram_location = G_000100_MC_FB_START(tmp) << 16; rdev->mc.gtt_location = 0xUL; r = radeon_mc_setup(rdev); - rdev->mc.igp_sideport_enabled = rad

DRM stable updates beyond 2.6.33.6

2010-08-08 Thread Ben Hutchings
. Do you have any suggestions for how we should to this? Could you maintain a drm-2.6.33 branch? Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. signature.asc Description: This is a digitally signed message part

[PATCH] drm/ttm: Fix build on architectures without AGP

2010-07-19 Thread Ben Hutchings
Make inclusion of conditional on TTM_HAS_AGP. The use of the functions declared in it is already conditional. Reported-by: Geert Stappers Signed-off-by: Ben Hutchings Tested-by: Geert Stappers --- drivers/gpu/drm/ttm/ttm_page_alloc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH] drm/ttm: Fix build on architectures without AGP

2010-07-18 Thread Ben Hutchings
Make inclusion of conditional on TTM_HAS_AGP. The use of the functions declared in it is already conditional. Reported-by: Geert Stappers Signed-off-by: Ben Hutchings Tested-by: Geert Stappers --- drivers/gpu/drm/ttm/ttm_page_alloc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions